[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247202#comment-15247202
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit 2859cd26a0c2084bff80dece8c1d8cf9ba681b3e in nifi's branch 
refs/heads/NIFI-1654 from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2859cd2 ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247201#comment-15247201
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit 2859cd26a0c2084bff80dece8c1d8cf9ba681b3e in nifi's branch 
refs/heads/NIFI-1654 from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2859cd2 ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245530#comment-15245530
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit 2859cd26a0c2084bff80dece8c1d8cf9ba681b3e in nifi's branch refs/heads/0.x 
from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2859cd2 ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245529#comment-15245529
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit 2859cd26a0c2084bff80dece8c1d8cf9ba681b3e in nifi's branch refs/heads/0.x 
from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2859cd2 ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245527#comment-15245527
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit f719cbf60c58d52facaad69daf8c75f4cca5b8b6 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=f719cbf ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245526#comment-15245526
 ] 

ASF subversion and git services commented on NIFI-1777:
---

Commit f719cbf60c58d52facaad69daf8c75f4cca5b8b6 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=f719cbf ]

NIFI-1777 Prevent deleting a connection going to a running processor

NIFI-1777 Added unit tests to test processor removal
This closes #357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245528#comment-15245528
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/357


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245446#comment-15245446
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/357#issuecomment-211322321
  
Was able to validate that when/if someone attempts to delete a connected 
processor a window pops up with the error message "Destination of Connection 
(LogAttribute[id=7a37a5bb-1017-4732-8c31-a6c1f44eea18]) is running". So all 
good, adequate tests provided, +1.

@mcgilman @scottyaslan  perhaps in the future we can further address it (as 
an additional feature) in the UI and disable "Delete" option all together. 


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 1.0.0, 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245437#comment-15245437
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/357#issuecomment-211319503
  
@pvillard31 also, when you submit PR click on "Submit Patch" in JIRA 
(without writing anything in description). I know it may be a bit awkward but 
this is how we signal that JIRA is ready for review/resolution.


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245434#comment-15245434
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/357#issuecomment-211318338
  
Perfect, reviewing now


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245322#comment-15245322
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/357#issuecomment-211276565
  
@olegz You're right, just added a unit test. (Note: I believe that travis 
build failure is not related to this PR)


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244819#comment-15244819
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/357#issuecomment-211079403
  
@pvillard31 I know this is a simple one, but would you consider adding a 
simple unit test for it as well?


> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243057#comment-15243057
 ] 

ASF GitHub Bot commented on NIFI-1777:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/357

NIFI-1777 Prevent deleting a connection going to a running processor



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-1777

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #357


commit de8b65e3b16f0185029fd53f201334347e0f5ffd
Author: Pierre Villard 
Date:   2016-04-15T14:49:47Z

NIFI-1777 Prevent deleting a connection going to a running processor




> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Assignee: Pierre Villard
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243022#comment-15243022
 ] 

Pierre Villard commented on NIFI-1777:
--

Yes, that's what I told myself when trying to reproduce the issue.
Will submit a PR shortly to prevent deleting a connection going to a running 
processor.

> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[Bryan Bende (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243000#comment-15243000
 ] 

Bryan Bende commented on NIFI-1777:
---

[~pvillard] you are right, I tried it again, and it appears that you can stop 
it. So I guess the issue is just that you shouldn't be able to delete a 
connection going to a running processor, because a processor should never be 
running in an invalid state. 

For what it is worth, you can make this happen with any two processors, but it 
is only obvious on processors that have @TriggerWhenEmpty because you will see 
the tasks increasing even when there is no incoming connection.

> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1777) Incoming Connection Deleted While Processor Still Running

[Pierre Villard (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242987#comment-15242987
 ] 

Pierre Villard commented on NIFI-1777:
--

[~bende] I just tried and did not reproduce the issue: I was able to stop 
PutKafka without adding an incoming connection. Did you get errors when trying 
to stop PutKafka?

> Incoming Connection Deleted While Processor Still Running
> -
>
> Key: NIFI-1777
> URL: https://issues.apache.org/jira/browse/NIFI-1777
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.6.0, 0.6.1
>Reporter: Bryan Bende
>Priority: Minor
> Fix For: 0.7.0
>
>
> I created a simple flow with ExecuteCommand connected to PutKafka. I had 
> PutKafka running and ExecuteCommand stopped, and then deleted ExecuteCommand. 
> At this point PutKafka showed a bulletin for being invalid because it 
> requires an incoming connection, but PutKafka was still running and couldn't 
> be stopped until adding back an incoming connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)