[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068538#comment-15068538 ] Joseph Witt commented on NIFI-810: -- ...this looks like it needs the FixVersion set. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973289#comment-14973289 ] ASF subversion and git services commented on NIFI-810: -- Commit 8e2308b78de480dd7848ffe8efb485a5ee61c42a in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8e2308b ] NIFI-810: Reworded validation errors pertaining ot upstream connections > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973287#comment-14973287 ] ASF subversion and git services commented on NIFI-810: -- Commit b974445ddd38ec7e84995225b86987e6af1af52c in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b974445 ] NIFI-810: rebased from master > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973288#comment-14973288 ] ASF subversion and git services commented on NIFI-810: -- Commit ccfb57fe9ff43f11319dcb1625bfc78b1d88f56a in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ccfb57f ] NIFI-810: Addressed several checkstyle violations > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948771#comment-14948771 ] Matt Gilman commented on NIFI-810: -- +1 - Relevant code changes look good. Behavior is as expected. Updated validation error is more concise. 0 - Extraneous formatting changes and sporadic ^M line breaks. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947672#comment-14947672 ] Mark Payne commented on NIFI-810: - I addressed the wording in the validation errors, rebased from master, and pushed the changes. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947670#comment-14947670 ] ASF subversion and git services commented on NIFI-810: -- Commit 8e2308b78de480dd7848ffe8efb485a5ee61c42a in nifi's branch refs/heads/NIFI-810-InputRequirement from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8e2308b ] NIFI-810: Reworded validation errors pertaining ot upstream connections > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947669#comment-14947669 ] ASF subversion and git services commented on NIFI-810: -- Commit ccfb57fe9ff43f11319dcb1625bfc78b1d88f56a in nifi's branch refs/heads/NIFI-810-InputRequirement from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ccfb57f ] NIFI-810: Addressed several checkstyle violations > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947666#comment-14947666 ] ASF subversion and git services commented on NIFI-810: -- Commit 13edcfda2ef830e1b160b31f7cd3bea874ccd3f0 in nifi's branch refs/heads/NIFI-810-InputRequirement from [~mcgilman] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=13edcfd ] NIFI-810: - Adding basic support for preventing connection when appropriate. - Updating validation when [dis]connecting processors. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947667#comment-14947667 ] ASF subversion and git services commented on NIFI-810: -- Commit 5ecdb1858e94938cd426b12bc48d3725109c6e96 in nifi's branch refs/heads/NIFI-810-InputRequirement from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5ecdb18 ] NIFI-810: Updated the wording on validation errors due to upstream connections > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935206#comment-14935206 ] Rob Moran commented on NIFI-810: Functionality looks good. More user-friendly messaging could help a lot. I think what I suggested in my earlier comment for the validation error language is more clear that what is currently being generated. It uses language seen in UI, such as 'upstream connection' making it more relatable to a users workflow. Current language is clear for the most part, but it is difficult to read and therefore probably takes longer to comprehend. It would also be great to include follow-on actions directly from tooltips - where applicable of course. For example, if there is a validation error stating some configuration has not been made, provide a link at the end of the message (e.g., 'Configure') that would open the configuration dialog, select the correct tab, and put browser focus on the relevant input needed to correct the issue. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[
https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908618#comment-14908618
]
Rob Moran commented on NIFI-810:
{quote}
if a Processor has no incoming connections but is started, it will continually
without ever accomplishing anything.
{quote}
In the UI I believe it would make sense to a user to flag that processor as
invalid and display the alert icon (yellow triangle). The tooltip could state
something like:
_A required upstream connection to this processor is not present._
I’ll make additional comments relating to NIFI-891 in that ticket.
> Create Annotation that indicates that a Processor cannot be scheduled to run
> without an incoming connection
> ---
>
> Key: NIFI-810
> URL: https://issues.apache.org/jira/browse/NIFI-810
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Mark Payne
>
> Currently, if a Processor has no incoming connections but is started, it will
> continually without ever accomplishing anything. We should have an
> annotation, perhaps @RequiresInput, that indicates that the Processor should
> not be scheduled to run unless it has an incoming connection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907033#comment-14907033 ] Aldrin Piri commented on NIFI-810: -- Bah, sorry for never having responded. You were consumed by the blackhole that is my inbox. The InputRequirement looks good and probably makes it easier than having to do additional checking on annotations applied to make sure everything makes sense (IgnoresInput and RequiresInput applied to a processor). From the standpoint of clarity, this seems like the best path in my view. > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731304#comment-14731304 ] Mark Payne commented on NIFI-810: - [~aldrin]: thoughts on using an annotation like "@InputRequirement" that takes an enumeration instead of @IgnoresInput and @RequestInput? Then you could use one of: @InputRequirement(INPUT_REQUIRED) @InputRequirement(INPUT_OPTIONAL) @InputRequirement(INPUT_FORBIDDEN) If the annotation is not present, it would be the same as using INPUT_OPTIONAL, which is how this behaves now. Not sure which way is cleaner: to have explicit annotations for each or to have an annotation that accepts input? > Create Annotation that indicates that a Processor cannot be scheduled to run > without an incoming connection > --- > > Key: NIFI-810 > URL: https://issues.apache.org/jira/browse/NIFI-810 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne > > Currently, if a Processor has no incoming connections but is started, it will > continually without ever accomplishing anything. We should have an > annotation, perhaps @RequiresInput, that indicates that the Processor should > not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708650#comment-14708650 ] Aldrin Piri commented on NIFI-810: -- In favor of all of this. I will make a ticket. Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection --- Key: NIFI-810 URL: https://issues.apache.org/jira/browse/NIFI-810 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Mark Payne Currently, if a Processor has no incoming connections but is started, it will continually without ever accomplishing anything. We should have an annotation, perhaps @RequiresInput, that indicates that the Processor should not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-810) Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection
[ https://issues.apache.org/jira/browse/NIFI-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708562#comment-14708562 ] Aldrin Piri commented on NIFI-810: -- The counter for this seems like it should be true as well. Something to the effect of @IgnoresInput or similar concept seems like it would be applicable and prevent processors from running that are taking input and do not use it. Create Annotation that indicates that a Processor cannot be scheduled to run without an incoming connection --- Key: NIFI-810 URL: https://issues.apache.org/jira/browse/NIFI-810 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Mark Payne Currently, if a Processor has no incoming connections but is started, it will continually without ever accomplishing anything. We should have an annotation, perhaps @RequiresInput, that indicates that the Processor should not be scheduled to run unless it has an incoming connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
