[GitHub] [incubator-nuttx] yamt opened a new pull request #517: dlfcn, modlib: Appease nxstyle complaints
yamt opened a new pull request #517: dlfcn, modlib: Appease nxstyle complaints URL: https://github.com/apache/incubator-nuttx/pull/517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #516: checkpatch: add checkpatch.sh README and correct some typos
liuguo09 opened a new pull request #516: checkpatch: add checkpatch.sh README and correct some typos URL: https://github.com/apache/incubator-nuttx/pull/516 Change-Id: Ib917dae235dc42fa2fa29e40c925f8fd048131df Signed-off-by: liuhaitao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] iceaway opened a new pull request #515: fix various nxstyle warnings
iceaway opened a new pull request #515: fix various nxstyle warnings URL: https://github.com/apache/incubator-nuttx/pull/515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #514: sched/module: Wrap long lines to make nxstyle happy
yamt opened a new pull request #514: sched/module: Wrap long lines to make nxstyle happy URL: https://github.com/apache/incubator-nuttx/pull/514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #513: include/nuttx/arch.h: Wrap long lines to make nxstyle happy
yamt opened a new pull request #513: include/nuttx/arch.h: Wrap long lines to make nxstyle happy URL: https://github.com/apache/incubator-nuttx/pull/513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #512: sched/signal: Wrap long lines to make nxstyle happy
yamt opened a new pull request #512: sched/signal: Wrap long lines to make nxstyle happy URL: https://github.com/apache/incubator-nuttx/pull/512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed
xiaoxiang781216 commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed URL: https://github.com/apache/incubator-nuttx/issues/510#issuecomment-596883751 > When I do "ls /dev/", there really isn't "/dev/fb0". But in "boards\arm\stm32\stm32f4discovery\src\stm32_bringup.c", it calls "fb_register" function. I don't know why the fb driver is not registered. You need add some log to debug, other people is hard to help here without the same enviornment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r390074355 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: > @xiaoxiang781216 Make can run all the pieces. Please do not only think abut this ONLY the way you have to work. Good tools solve everyone problems are self documenting. I already suggest you provide a patch to add check_format(actually check_patch may a better name) in Makefile, what I oppose is to call nxstyle directly in Makefile. It's better to call checkpatch.sh so devloeper can get the same result in his machine as the github CI. > What if a user is doing a style cleanup NOW and not concerned about about licenses in the PR? > Do you monitor the recent comment or PR from @patacongo? https://github.com/apache/incubator-nuttx/pull/414 https://github.com/apache/incubator-nuttx/pull/508/files ... All new source code need use Apache license, but most people forget this and copy BSD license from other files. It's the right time to enforce the license check like coding style. > The documentation of the script tools is poor. There are no examples of what the arguments take as values. Do you think the following help isn't enough? ``` ./tools/checkpatch.sh -h USAGE: ./tools/checkpatch.sh [options] [list|-] Options: -h -c spell check with codespell(install with: pip install codespell -r range check only (used with -p and -g) -p (default) -g -f - read standard input mainly used by git pre-commit hook as below: git diff --cached | ./tools/checkpatch.sh - ``` If not, please enhance the description so everyone can get the benefit. > Forcing a user to decodes the script when it is not necessary is not inviting. Why is it it tools/configure.sh imx-1060evk/nsh not `make imx-1060evk/nsh'? > It's hard to teach people invoke make with argument every time. It's also hard to discover how many targets supported by a specific Makefile. BTW, how can you show something like this from Makefile naturally? ``` ./tools/configure.sh -h USAGE: ./tools/configure.sh [-d] [-s] [-l|m|c|u|g|n] [-a ] : Where: -d enables script debug output -s skip the .config/Make.defs existence check -l selects the Linux (l) host environment. -m selects the macOS (m) host environment. -c selects the Windows host and Cygwin (c) environment. -u selects the Windows host and Ubuntu under Windows 10 (u) environment. -g selects the Windows host and MinGW/MSYS environment. -n selects the Windows host and Windows native (n) environment. Default: Use host setup in the defconfig file Default Windows: Cygwin -a is the path to the apps/ directory, relative to the nuttx directory is the name of the board in the boards directory configs/ is the name of the board configuration sub-directory ``` > A lot of pieces all over the place is fine jut keep them out the the users face and have reasonable granularity. > > > The correct version is always the latest one on the master, we need rebase/cherry-pick our patch with the master anyway, why don't we run checkpatch.sh before sending PR? > > No we do not. I explained this already (in email and comments) that work flow is a waste of time and effort with back and forth chery-picking. You do not have a good solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure
[GitHub] [incubator-nuttx] hanwenlei commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed
hanwenlei commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed URL: https://github.com/apache/incubator-nuttx/issues/510#issuecomment-596879132 When I do "ls /dev/", there really isn't "/dev/fb0". But in "boards\arm\stm32\stm32f4discovery\src\stm32_bringup.c", it calls "fb_register" function. I don't know why the fb driver is not registered. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #511: Fix some nxstyle complaints in arm addrenv
yamt opened a new pull request #511: Fix some nxstyle complaints in arm addrenv URL: https://github.com/apache/incubator-nuttx/pull/511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed
xiaoxiang781216 commented on issue #510: Use lcd ssd1289 in stm32f4discovery failed URL: https://github.com/apache/incubator-nuttx/issues/510#issuecomment-596872577 > I use the config "CONFIG_EXAMPLES_LVGLDEMO=y, CONFIG_LCD_SSD1289=y and CONFIG_VIDEO_FB=y" in "stm32f4discovery:usbnsh", and can be compiled. But when I run the lvgldemo application in nsh, I get the error "ERROR: Failed to open /dev/fb0: 2". I don't know what went wrong. How can i solve this problem? 2 means that lvgldemo can't find /dev/fb0: #define ENOENT 2 Please make sure you can see fb0 by: ls /dev/ Otherwise, you have to fix fb0 issue before trying the lvgl demo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] hanwenlei opened a new issue #510: Use lcd ssd1289 in stm32f4discovery failed
hanwenlei opened a new issue #510: Use lcd ssd1289 in stm32f4discovery failed URL: https://github.com/apache/incubator-nuttx/issues/510 I use the config "CONFIG_EXAMPLES_LVGLDEMO=y, CONFIG_LCD_SSD1289=y and CONFIG_VIDEO_FB=y" in "stm32f4discovery:usbnsh", and can be compiled. But when I run the lvgldemo application in nsh, I get the error "ERROR: Failed to open /dev/fb0: 2". I don't know what went wrong. How can i solve this problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (722de0f -> f886d81)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 722de0f Remove the additional apps checkout step for PR check job add f886d81 z20x: Correct issues loading code from FLASH No new revisions were added by this update. Summary of changes: boards/z80/ez80/z20x/src/w25_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #509: z20x: Correct issues loading code from FLASH
xiaoxiang781216 merged pull request #509: z20x: Correct issues loading code from FLASH URL: https://github.com/apache/incubator-nuttx/pull/509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (199b4d6 -> 722de0f)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 199b4d6 z20x: Changes to reduce serial Rx data overrun add 722de0f Remove the additional apps checkout step for PR check job No new revisions were added by this update. Summary of changes: .github/workflows/main.yml | 7 --- 1 file changed, 7 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #500: Remove the additional apps checkout step for PR check job
xiaoxiang781216 merged pull request #500: Remove the additional apps checkout step for PR check job URL: https://github.com/apache/incubator-nuttx/pull/500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
masayuki2009 commented on a change in pull request #502: tools: Add workaround
not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#discussion_r390027526
##
File path: tools/testbuild.sh
##
@@ -190,7 +190,16 @@ function configure {
function build {
echo " Building NuttX..."
echo
""
- makefunc ${JOPTION} ${MAKE_FLAGS} 1>/dev/null
+
+ elf=`grep CONFIG_ELF=y $nuttx/.config`
Review comment:
@liuguo09 Thanks for the comment, I'll fix it later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #509: z20x: Correct issues loading code from FLASH
patacongo opened a new pull request #509: z20x: Correct issues loading code from FLASH URL: https://github.com/apache/incubator-nuttx/pull/509 boards/z80/ez80/z20x/src/w25_main.c: (1) Correct size comparison typo: Should have been >= not != (2) Fix sizeof(): Was getting the sizeof the pointer instead of the sizeof the pointed at structure. (3) Improve some comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: z20x: Changes to reduce serial Rx data overrun
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 199b4d6 z20x: Changes to reduce serial Rx data overrun 199b4d6 is described below commit 199b4d68525b079eb0a38c9b938ec0dd99107fcc Author: Gregory Nutt AuthorDate: Mon Mar 9 14:28:20 2020 -0600 z20x: Changes to reduce serial Rx data overrun boards/z80/ez80/z20x: Increase RX buffer size to 4Kb, reduce BAUD to 2400 in w25boot configuration arch/z80/src/ez80/ez80_serial.c: Reduce Rx FIFO trigger level for eZ80F92 to 1 so that will respond more quickly to incoming data. --- arch/z80/src/ez80/Kconfig | 45 +++- arch/z80/src/ez80/ez80_serial.c| 141 + arch/z80/src/ez80/ez80f91.h| 70 +--- arch/z80/src/ez80/ez80f92.h| 5 +- boards/z80/ez80/z20x/README.txt| 69 ++-- boards/z80/ez80/z20x/configs/w25boot/defconfig | 3 +- libs/libc/hex2bin/Make.defs| 39 +++ libs/libc/hex2bin/lib_fhex2mem.c | 39 +++ libs/libc/hex2bin/lib_hex2bin.c| 89 libs/libc/hex2bin/lib_hex2mem.c| 39 +++ libs/libc/stdio/lib_rawinstream.c | 10 +- libs/libc/stdio/lib_rawsistream.c | 6 +- 12 files changed, 274 insertions(+), 281 deletions(-) diff --git a/arch/z80/src/ez80/Kconfig b/arch/z80/src/ez80/Kconfig index e3561b7..b22191b 100644 --- a/arch/z80/src/ez80/Kconfig +++ b/arch/z80/src/ez80/Kconfig @@ -5,6 +5,8 @@ if ARCH_CHIP_EZ80 +# Chip capabilities + config ARCH_EZ80_HAVE_PLL bool default n @@ -21,6 +23,8 @@ config ARCH_EZ80_HAVE_TIMER_INTREGS bool default n +# Chip selection + choice prompt "eZ80 Chip Selection" default ARCH_CHIP_EZ80F91 @@ -72,6 +76,8 @@ config EZ80_ZDSII_V533 endchoice # ZDS-II Toolchain version +# Build type selection + config EZ80_BOOTLOADER bool default n @@ -89,20 +95,29 @@ config EZ80_PROGRAM may require special properties such as re-direction of interrupts (eZ80F92) +# Peripheral selection + +config EZ80_UART + bool + default n + menu "ez80 Peripheral Support" config EZ80_UART0 bool "UART0" + select EZ80_UART select UART0_SERIALDRIVER default n config EZ80_UART1 bool "UART1" + select EZ80_UART select UART1_SERIALDRIVER default n config EZ80_UART2 bool "UART2" + select EZ80_UART select UART2_SERIALDRIVER default n depends on ARCH_EZ80_HAVE_UART2 @@ -132,6 +147,30 @@ config EZ80_EMAC endmenu # ez80 Peripheral Support +# UART Configuration + +choice + prompt "UART Rx FIFO depth" + default EZ80_UART_RXFIFO_1 if ARCH_CHIP_EZ80F92 || ARCH_CHIP_EZ80F93 + default EZ80_UART_RXFIFO_4 if ARCH_CHIP_EZ80F91 + depends on EZ80_UART + +config EZ80_UART_RXFIFO_1 + bool "1" + +config EZ80_UART_RXFIFO_4 + bool "4" + +config EZ80_UART_RXFIFO_8 + bool "8" + +config EZ80_UART_RXFIFO_14 + bool "14" + +endchoice + +# RTC/Crystal Configuration + config EZ80_RTC_32KHZ bool "32KHz crystal present" default y @@ -148,10 +187,12 @@ config EZ80_RTC_LINEFREQ50 If there is no 32Hz crystal, the RTC will fall back to use the line frequency, either 50 or 60Hz. +# EMAC Configuration + if EZ80_EMAC config EZ80_FIAD -hex "PHY Address" + hex "PHY Address" range 0x00 0x1f default 0x1f ---help--- @@ -208,6 +249,8 @@ config ARCH_MCFILTER endif # EZ80_EMAC +# System integration + config ARCH_TIMERHOOK bool "Timer Hook" default n diff --git a/arch/z80/src/ez80/ez80_serial.c b/arch/z80/src/ez80/ez80_serial.c index bfa4e78..12ebaf5 100644 --- a/arch/z80/src/ez80/ez80_serial.c +++ b/arch/z80/src/ez80/ez80_serial.c @@ -1,36 +1,20 @@ / * arch/z80/src/ez08/ez80_serial.c * - * Copyright (C) 2008-2009, 2012, 2017 Gregory Nutt. All rights reserved. - * Author: Gregory Nutt - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in - *the documentation and/or other materials provided with the - *distribution. - * 3. Neither the name NuttX nor the names
[GitHub] [incubator-nuttx] Ouss4 merged pull request #508: z20x: Changes to reduce serial Rx data overrun
Ouss4 merged pull request #508: z20x: Changes to reduce serial Rx data overrun URL: https://github.com/apache/incubator-nuttx/pull/508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596774228 One changed behavior I am seeing is for example with this code snippet: case RECORD_EXT_SEGADDR: /* Extended segment address record */ /* The address specified by the data field is multiplied by 16 * (shifted 4 bits left) and added to the subsequent data record * addresses. This allows addressing of up to a megabyte of nxstyle in the past would have claimed that I need a blank line before the (second) comment. Now it complains that the second "right hand" comment is not aligned properly. Both are correct complaints, but the old one was more interpretable. Both are fixed in the same way... by adding the blank like before the comment. case RECORD_EXT_SEGADDR: /* Extended segment address record */ + /* The address specified by the data field is multiplied by 16 * (shifted 4 bits left) and added to the subsequent data record * addresses. This allows addressing of up to a megabyte of I don't think that there is a problem here, just a change in behavior. BTW: I think you did a great job! Feel free to add additional functionality to nxstyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #508: z20x: Changes to reduce serial Rx data overrun
patacongo opened a new pull request #508: z20x: Changes to reduce serial Rx data overrun URL: https://github.com/apache/incubator-nuttx/pull/508 boards/z80/ez80/z20x: Increase RX buffer size to 4Kb, reduce BAUD to 2400 in w25boot configuration arch/z80/src/ez80/ez80_serial.c: Reduce Rx FIFO trigger level for eZ80F92 to 1 so that will respond more quickly to incoming data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook
davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r389883624 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: @xiaoxiang781216 Make can run all the pieces. Please do not only think abut this ONLY the way you have to work. Good tools solve everyone problems are self documenting. What if a user is doing a style cleanup NOW and not concerned about about licenses in the PR? The documentation of the script tools is poor. There are no examples of what the arguments take as values. Forcing a user to decodes the script when it is not necessary is not inviting. Why is it it tools/configure.sh imx-1060evk/nsh not `make imx-1060evk/nsh'? A lot of pieces all over the place is fine jut keep them out the the users face and have reasonable granularity. > The correct version is always the latest one on the master, we need rebase/cherry-pick our patch with the master anyway, why don't we run checkpatch.sh before sending PR? No we do not. I explained this already (in email and comments) that work flow is a waste of time and effort with back and forth chery-picking. You do not have a good solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: sched/: Fix some new coding standard issues.
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9f3648d sched/: Fix some new coding standard issues. 9f3648d is described below commit 9f3648d32912d637546ab0cb7e3a637ef383be01 Author: Gregory Nutt AuthorDate: Mon Mar 9 10:01:09 2020 -0600 sched/: Fix some new coding standard issues. Fix new coding standard issues found by new, revised nxstyle. --- sched/irq/irq_procfs.c | 2 +- sched/task/task_vfork.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sched/irq/irq_procfs.c b/sched/irq/irq_procfs.c index eacc53e..48da0d5 100644 --- a/sched/irq/irq_procfs.c +++ b/sched/irq/irq_procfs.c @@ -95,7 +95,7 @@ struct irq_file_s size_t remaining; /* Number of available characters in buffer */ size_t ncopied; /* Number of characters in buffer */ off_t offset; /* Current file offset */ - char line[IRQ_LINELEN];/* Pre-allocated buffer for formatted lines */ + char line[IRQ_LINELEN]; /* Pre-allocated buffer for formatted lines */ }; / diff --git a/sched/task/task_vfork.c b/sched/task/task_vfork.c index 6e1e4d9..a9c6471 100644 --- a/sched/task/task_vfork.c +++ b/sched/task/task_vfork.c @@ -335,7 +335,7 @@ FAR struct task_tcb_s *nxtask_vforksetup(start_t retaddr, size_t *argsize) /* Get the priority of the parent task */ #ifdef CONFIG_PRIORITY_INHERITANCE - priority = parent->base_priority; /* "Normal," unboosted priority */ + priority = parent->base_priority; /* "Normal," unboosted priority */ #else priority = parent->sched_priority; /* Current priority */ #endif
[GitHub] [incubator-nuttx] Ouss4 merged pull request #507: sched/: Fix some new coding standard issues.
Ouss4 merged pull request #507: sched/: Fix some new coding standard issues. URL: https://github.com/apache/incubator-nuttx/pull/507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596620396 > sched\task\task_vfork.c:340:38: warning: Wrong column position of comment right of code > sched\semaphore\sem_holder.c:445:6: error: No multiline comment right of code allowed here > sched\irq\irq_procfs.c:98:29: warning: Wrong column position of comment right of code PR #507 and #505 should resolve all of these. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #507: sched/: Fix some new coding standard issues.
patacongo commented on issue #507: sched/: Fix some new coding standard issues. URL: https://github.com/apache/incubator-nuttx/pull/507#issuecomment-596620738 As noted in PR #496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #507: sched/: Fix some new coding standard issues.
patacongo opened a new pull request #507: sched/: Fix some new coding standard issues. URL: https://github.com/apache/incubator-nuttx/pull/507 Fix new coding standard issues found by new, revised nxstyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 01/07: Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 574344c56eabd2117f1128c165420a09bd1e245f
Author: Johanne Schock
AuthorDate: Sun Mar 8 20:02:51 2020 +0100
Changes to nxstyle which address issue #120 and add checks for column
position of right of code comments
---
tools/nxstyle.c | 79 +
1 file changed, 52 insertions(+), 27 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index f49c84f..2ef78dd 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -505,8 +505,8 @@ int main(int argc, char **argv, char **envp)
bool bblank; /* Used to verify block comment terminator */
bool ppline; /* True: The next line the continuation of a
pre-processor command */
bool bexternc;/* True: Within 'extern "C"' */
- bool brhcomment; /* True: Comment to the right of code */
- bool prevbrhcmt; /* True: previous line had comment to the right of
code */
+ int rhcomment; /* Indentation of Comment to the right of code */
+ int prevrhcmt; /* Indentation of previous Comment to the right of code
*/
int lineno; /* Current line number */
int indent; /* Indentation level */
int ncomment; /* Comment nesting level on this line */
@@ -625,8 +625,8 @@ int main(int argc, char **argv, char **envp)
bstring= false; /* True: Within a string */
ppline = false; /* True: Continuation of a pre-processor line */
bexternc = false; /* True: Within 'extern "C"' */
- brhcomment = false; /* True: Comment to the right of code */
- prevbrhcmt = false; /* True: Previous line had comment to the right
+ rhcomment = 0; /* Indentation of Comment to the right of code */
+ prevrhcmt = 0; /* Indentation of previous Comment to the right
* of code */
lineno = 0; /* Current line number */
ncomment = 0; /* Comment nesting level on this line */
@@ -658,10 +658,10 @@ int main(int argc, char **argv, char **envp)
* comment.
*/
- prevbrhcmt = brhcomment;
+ prevrhcmt = rhcomment;
if (ncomment <= 0)
{
- brhcomment = false;
+ rhcomment = 0;
}
/* Check for a blank line */
@@ -707,7 +707,7 @@ int main(int argc, char **argv, char **envp)
* a comment. Generally it is acceptable for one comment to
* follow another with no space separation.
*
- * REVISIT: prevbrhcmt is tested to case the preceding line
+ * REVISIT: prevrhcmt is tested to case the preceding line
* contained comments to the right of the code. In such cases,
* the comments are normally aligned and do not follow normal
* indentation rules. However, this code will generate a false
@@ -715,7 +715,7 @@ int main(int argc, char **argv, char **envp)
* preceding line has no comment.
*/
- if (line[n] != '}' && line[n] != '#' && !prevbrhcmt)
+ if (line[n] != '}' && line[n] != '#' && !prevrhcmt)
{
ERROR("Missing blank line after comment", comment_lineno,
1);
@@ -915,21 +915,23 @@ int main(int argc, char **argv, char **envp)
ppline = (line[len] == '\\');
+ /* Propagate rhcomment over preprocessor lines Issue #120 */
+
+ rhcomment = prevrhcmt;
+
if (!ppline)
{
lptr = strstr(line, "/*");
if (lptr != NULL)
{
- lptr += 2;
- if (*lptr == '\n')
+ n = lptr - [0];
+ if (line[n + 2] == '\n')
{
- ERROR("C comment opening on separate line",
- lineno, lptr - [0]);
+ ERROR("C comment opening on separate line", lineno, n);
}
- else if (!isspace((int)*lptr))
+ else if (!isspace((int)line[n + 2]) && line[n + 2] != '*')
{
- ERROR("Missing space after opening C comment",
- lineno, lptr - [0]);
+ ERROR("Missing space after opening C comment", lineno,
n);
}
if (strstr(lptr, "*/") == NULL)
@@ -937,7 +939,14 @@ int main(int argc, char **argv, char **envp)
/* Increment the count of nested comments */
ncomment++;
- brhcomment = true;
+}
+
+ rhcomment = n;
+ if (prevrhcmt != 0 && n != prevrhcmt)
+{
+ rhcomment
[incubator-nuttx] 06/07: Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 745e0a4ca9de577405a8ab2a6a4294b3225e4ef3
Author: Johanne Schock
AuthorDate: Mon Mar 9 12:53:21 2020 +0100
Some more fine tuning
Handle #define different than other preprocessor lines
Ignore backslash at the end of a comment right of a preprocessor line
---
tools/nxstyle.c | 121 +---
1 file changed, 72 insertions(+), 49 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index d704df3..71ca4c2 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -112,6 +112,13 @@ enum section_s
PUBLIC_FUNCTION_PROTOTYPES
};
+enum pptype_e
+{
+ PPLINE_NONE = 0,
+ PPLINE_DEFINE,
+ PPLINE_OTHER
+};
+
struct file_section_s
{
const char *name; /* File section name */
@@ -503,10 +510,13 @@ int main(int argc, char **argv, char **envp)
bool bstring; /* True: Within a string */
bool bquote; /* True: Backslash quoted character next */
bool bblank; /* Used to verify block comment terminator */
- bool ppline; /* True: The next line the continuation of a
pre-processor command */
bool bexternc;/* True: Within 'extern "C"' */
- int rhcomment;/* Indentation of Comment to the right of code */
- int prevrhcmt;/* Indentation of previous Comment to the right of
code */
+ enum pptype_e ppline; /* > 0: The next line the continuation of a
+ * pre-processor command */
+ int rhcomment;/* Indentation of Comment to the right of code
+ * (-1 -> don't check position) */
+ int prevrhcmt;/* Indentation of previous Comment to the right
+ * of code (-1 -> don't check position) */
int lineno; /* Current line number */
int indent; /* Indentation level */
int ncomment; /* Comment nesting level on this line */
@@ -618,27 +628,29 @@ int main(int argc, char **argv, char **envp)
g_maxline = get_line_width(instream) + excess;
rewind(instream);
- btabs = false; /* True: TAB characters found on the line */
- bcrs = false; /* True: Carriage return found on the line */
- bfunctions = false; /* True: In private or public functions */
- bswitch= false; /* True: Within a switch statement */
- bstring= false; /* True: Within a string */
- ppline = false; /* True: Continuation of a pre-processor line */
- bexternc = false; /* True: Within 'extern "C"' */
- rhcomment = 0; /* Indentation of Comment to the right of code */
- prevrhcmt = 0; /* Indentation of previous Comment to the right
- * of code */
- lineno = 0; /* Current line number */
- ncomment = 0; /* Comment nesting level on this line */
- bnest = 0; /* Brace nesting level on this line */
- dnest = 0; /* Data declaration nesting level on this line */
- pnest = 0; /* Parenthesis nesting level on this line */
- comment_lineno = -1;/* Line on which the last comment was closed */
- blank_lineno = -1;/* Line number of the last blank line */
- noblank_lineno = -1;/* A blank line is not needed after this line */
- lbrace_lineno = -1;/* Line number of last left brace */
- rbrace_lineno = -1;/* Last line containing a right brace */
- externc_lineno = -1;/* Last line where 'extern "C"' declared */
+ btabs = false; /* True: TAB characters found on the line */
+ bcrs = false; /* True: Carriage return found on the line */
+ bfunctions = false; /* True: In private or public functions */
+ bswitch= false; /* True: Within a switch statement */
+ bstring= false; /* True: Within a string */
+ bexternc = false; /* True: Within 'extern "C"' */
+ ppline = PPLINE_NONE; /* > 0: The next line the continuation of a
+ * pre-processor command */
+ rhcomment = 0; /* Indentation of Comment to the right of code
+ * (-1 -> don't check position) */
+ prevrhcmt = 0; /* Indentation of previous Comment to the right
+ * of code (-1 -> don't check position) */
+ lineno = 0; /* Current line number */
+ ncomment = 0; /* Comment nesting level on this line */
+ bnest = 0; /* Brace nesting level on this line */
+ dnest = 0; /* Data declaration nesting level on this line
*/
+ pnest = 0; /* Parenthesis nesting level on this line */
+ comment_lineno = -1; /* Line on which the last comment was closed */
+ blank_lineno = -1; /* Line number
[incubator-nuttx] 02/07: Formatting
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b324596bac6eb3cc00cdf3aa034d13be42e8a4d7
Author: Johanne Schock
AuthorDate: Sun Mar 8 20:08:47 2020 +0100
Formatting
---
tools/nxstyle.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 2ef78dd..cf3a378 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -505,8 +505,8 @@ int main(int argc, char **argv, char **envp)
bool bblank; /* Used to verify block comment terminator */
bool ppline; /* True: The next line the continuation of a
pre-processor command */
bool bexternc;/* True: Within 'extern "C"' */
- int rhcomment; /* Indentation of Comment to the right of code */
- int prevrhcmt; /* Indentation of previous Comment to the right of code
*/
+ int rhcomment;/* Indentation of Comment to the right of code */
+ int prevrhcmt;/* Indentation of previous Comment to the right of
code */
int lineno; /* Current line number */
int indent; /* Indentation level */
int ncomment; /* Comment nesting level on this line */
@@ -625,8 +625,8 @@ int main(int argc, char **argv, char **envp)
bstring= false; /* True: Within a string */
ppline = false; /* True: Continuation of a pre-processor line */
bexternc = false; /* True: Within 'extern "C"' */
- rhcomment = 0; /* Indentation of Comment to the right of code */
- prevrhcmt = 0; /* Indentation of previous Comment to the right
+ rhcomment = 0; /* Indentation of Comment to the right of code */
+ prevrhcmt = 0; /* Indentation of previous Comment to the right
* of code */
lineno = 0; /* Current line number */
ncomment = 0; /* Comment nesting level on this line */
@@ -658,7 +658,7 @@ int main(int argc, char **argv, char **envp)
* comment.
*/
- prevrhcmt = rhcomment;
+ prevrhcmt = rhcomment;
if (ncomment <= 0)
{
rhcomment = 0;
[incubator-nuttx] 04/07: Restrict check of right of code comments to #define in case of preprocessor lines
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit fbe65a2d7dc5024e829ceba1409f9da8c0c68d76
Author: Johanne Schock
AuthorDate: Sun Mar 8 22:24:27 2020 +0100
Restrict check of right of code comments to #define in case of preprocessor
lines
---
tools/nxstyle.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 47c5615..9edd48f 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -941,12 +941,15 @@ int main(int argc, char **argv, char **envp)
ncomment++;
}
- rhcomment = n;
- if (prevrhcmt != 0 && n != prevrhcmt)
+ if (!strncmp([ii], "define", 6))
{
- rhcomment = prevrhcmt;
- WARN("Wrong column position of comment right of code",
- lineno, n);
+ rhcomment = n;
+ if (prevrhcmt != 0 && n != prevrhcmt)
+{
+ rhcomment = prevrhcmt;
+ WARN("Wrong column position of comment right of
code",
+ lineno, n);
+}
}
}
}
[GitHub] [incubator-nuttx] patacongo merged pull request #496: Nxstyle
patacongo merged pull request #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 03/07: Style
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 46b8347217f5ab3cd8b08bb4dfbfbbf415321e5b
Author: Johanne Schock
AuthorDate: Sun Mar 8 20:12:06 2020 +0100
Style
---
tools/nxstyle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index cf3a378..47c5615 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -715,7 +715,7 @@ int main(int argc, char **argv, char **envp)
* preceding line has no comment.
*/
- if (line[n] != '}' && line[n] != '#' && !prevrhcmt)
+ if (line[n] != '}' && line[n] != '#' && prevrhcmt == 0)
{
ERROR("Missing blank line after comment", comment_lineno,
1);
[incubator-nuttx] 05/07: Finetuning false positive
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5e5b6c206993815f8bf11598825e22ca6e726517
Author: Johanne Schock
AuthorDate: Sun Mar 8 22:37:39 2020 +0100
Finetuning false positive
---
tools/nxstyle.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 9edd48f..d704df3 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -941,15 +941,14 @@ int main(int argc, char **argv, char **envp)
ncomment++;
}
- if (!strncmp([ii], "define", 6))
+ rhcomment = n;
+
+ if (!strncmp([ii], "define", 6)
+ && prevrhcmt != 0 && n != prevrhcmt)
{
- rhcomment = n;
- if (prevrhcmt != 0 && n != prevrhcmt)
-{
- rhcomment = prevrhcmt;
- WARN("Wrong column position of comment right of
code",
- lineno, n);
-}
+ rhcomment = prevrhcmt;
+ WARN("Wrong column position of comment right of code",
+ lineno, n);
}
}
}
[GitHub] [incubator-nuttx] patacongo closed issue #120: tools/nxstyle.c: FALSE alarms on right hand aligned comments.
patacongo closed issue #120: tools/nxstyle.c: FALSE alarms on right hand aligned comments. URL: https://github.com/apache/incubator-nuttx/issues/120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (9e40a0d -> f764947)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9e40a0d sched/semaphore/sem_holder.c: Fix bad line separation. new 574344c Changes to nxstyle which address issue #120 and add checks for column position of right of code comments new b324596 Formatting new 46b8347 Style new fbe65a2 Restrict check of right of code comments to #define in case of preprocessor lines new 5e5b6c2 Finetuning false positive new 745e0a4 Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line new f764947 Signal error for multiline comment right of #if The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: tools/nxstyle.c | 174 +--- 1 file changed, 115 insertions(+), 59 deletions(-)
[incubator-nuttx] 07/07: Signal error for multiline comment right of #if
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f764947c731fbc65d33aceb4da3e25513a2013c6
Author: Johanne Schock
AuthorDate: Mon Mar 9 16:16:06 2020 +0100
Signal error for multiline comment right of #if
---
tools/nxstyle.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 71ca4c2..9b7badd 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -968,6 +968,12 @@ int main(int argc, char **argv, char **envp)
/* Signal rhcomment, but ignore position */
rhcomment = -1;
+
+ if (ncomment > 0 && !strncmp([ii], "if", 2))
+{
+ ERROR("No multiline comment right of code allowed here",
+ lineno, n);
+}
}
}
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596608964 Hmmm... there is discussion in the CS document. I stand corrected: "Comments to the Right of Statements. Comments to the right of statements in C source files are discouraged. If such comments are used, they should be (1) very short so that they do not exceed the line width (typically 78 characters), (2) fit on one line, and (3) be aligned so that the comment begins in the same comment (sic) on each line. " It does explicitly prohibit multiple line comments to the right! That, unfortunately is not realizable. You cannot simultaneously limit line width, allow comments to the right, and force right hand comments to be a single line. That doesn't make sense. Within C code, I have no problem with this prohibitioin. I don't like right hand comments after C statements; placing the comment above the statement is always a better option. But within #defines and data definitions, it is essential to provide sufficient information for item on a line-by-line basis. The compactness and readability is worth it. In general, we must avoid problems by change the coding standard to match the code or tools. That just opens a Pandora's box. But we can make well considered and agreed to changes in the coding standard if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596608964 Hmmm... there is discussion in the CS document. I stand corrected: "Comments to the Right of Statements. Comments to the right of statements in C source files are discouraged. If such comments are used, they should be (1) very short so that they do not exceed the line width (typically 78 characters), (2) fit on one line, and (3) be aligned so that the comment begins in the same comment on each line. " It does explicitly prohibit multiple line comments to the right! That, unfortunately is not realizable. You cannot simultaneously limit line width, allow comments to the right, and force right hand comments to be a single line. That doesn't make sense. Within C code, I have no problem with this prohibitioin. I don't like right hand comments after C statements; placing the comment above the statement is always a better option. But within #defines and data definitions, it is essential to provide sufficient information for item on a line-by-line basis. The compactness and readability is worth it. In general, we must avoid problems by change the coding standard to match the code or tools. That just opens a Pandora's box. But we can make well considered and agreed to changes in the coding standard if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus edited a comment on issue #496: Nxstyle
johannes-nivus edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596608253 I'm confident with the changes so far. Running on all c files of sched/ gives the following additional lines: sched\task\task_vfork.c:340:38: warning: Wrong column position of comment right of code sched\semaphore\sem_holder.c:445:6: error: No multiline comment right of code allowed here sched\irq\irq_procfs.c:98:29: warning: Wrong column position of comment right of code The other output is identical to current master. include\nuttx\can\can.h passes Please review and merge if acceptable. Edit: You already fixed the sched\semaphore\sem_holder.c:445:6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596608964 Hmmm... there is discussion in the CS document. I stand corrected: "Comments to the Right of Statements. Comments to the right of statements in C source files are discouraged. If such comments are used, they should be (1) very short so that they do not exceed the line width (typically 78 characters), (2) fit on one line, and (3) be aligned so that the comment begins in the same comment on each line. " It does explicitly prohibit multiple line comments to the right! That, unfortunately is not realizable. You simultaneously limit line width, allow comments to the right, and force right hand comments to be a single line. That doesn't make sense. Within C code, I have no problem with this prohibitioin. But in #defines and data definitions, it is essential to provide sufficient information for item on a line-by-line basis. In general, we must avoid problems by change the coding standard to match the code or tools. That just opens a Pandora's box. But we can make well considered and agreed to changes in the coding standard if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #496: Nxstyle
johannes-nivus commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596608253 I'm confident with the changes so far. Running on all c files of sched/ gives the following additional lines: sched\task\task_vfork.c:340:38: warning: Wrong column position of comment right of code sched\semaphore\sem_holder.c:445:6: error: No multiline comment right of code allowed here sched\irq\irq_procfs.c:98:29: warning: Wrong column position of comment right of code The other output is identical to current master. include\nuttx\can\can.h passes Please review and merge if acceptable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596603850 > haven't found an paragraph were it's explicitly stated when multiline comments right of code are allowed. If they are not prohibited, then they are allowed. There is much about C programming that is not discussed in the coding standard. This is the same argument for accepting #504 : If the kind of indentation that YAMT wanted to do is not explictly prohibited, then it is permitted. If we find controversial things that should be prohibited, then we must update the coding style to add the prohibition. The Coding Standard should probably be extended to address rigiht hand comments. They are basically the same as other comments except: - The should be aligned vertically. - No horizontal alignment is required. - No blank line separation is required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596603850 > haven't found an paragraph were it's explicitly stated when multiline comments right of code are allowed. If they are not prohibited, then they are allowed. There is much about C programming that is not discussed in the coding standard. This is the same argument for accepting #504 : If the kind of indentation that YAMT wanted to do is not explictly prohibited, then it is permitted. If we find controversial things that should be prohibited, then we must update the coding style to add the prohibition. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #505: sched/semaphore/sem_holder.c: Fix bad line separation.
Ouss4 merged pull request #505: sched/semaphore/sem_holder.c: Fix bad line separation. URL: https://github.com/apache/incubator-nuttx/pull/505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (7dd5356 -> 9e40a0d)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7dd5356 nxstyle: fixed various nxstyle warnings add 9e40a0d sched/semaphore/sem_holder.c: Fix bad line separation. No new revisions were added by this update. Summary of changes: sched/semaphore/sem_holder.c | 85 +++- 1 file changed, 37 insertions(+), 48 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596603850 > haven't found an paragraph were it's explicitly stated when multiline comments right of code are allowed. If they are not prohibited, then they are allowed. There is much about C programming that is not discussed in the coding standard. This is the same argument for accepting #504 : If the kind of indentation that YAMT wanted to do is not explictly prohibited, then it is permitted. If we find controversial things taht should be prohibited, then we must update the coding style to add the prohibition. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #496: Nxstyle
johannes-nivus commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596598781 > > > You are familiar with the coding standard document, correct? https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard > > That is really the specification for nxstyle. Make sure that anything you do is consistent with and required by that document. Yes I am (and I always look up the cases I'm modifying/implementing), but I haven't found an paragraph were it's explicitly stated when multiline comments right of code are allowed. Perhaps I missed it... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596585743 You are familiar with the coding standard document, correct? https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard That is really the specification for nxstyle. Make sure that anything you do is consistent with and required by that document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596584530 The are okay everywhere except for #if type commands. The line continuation '\' should not be used anywhere in a C file except for in multiple line definitions. It is incorrect to continue a C comments use \ at the end of one line of the multi-line comment. it is not the right hand comment that is the issue, it is the use of \ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: nxstyle: fixed various nxstyle warnings
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 7dd5356 nxstyle: fixed various nxstyle warnings
7dd5356 is described below
commit 7dd5356055fa46198da023134886ce10d7263cff
Author: Pelle Windestam
AuthorDate: Mon Mar 9 15:21:22 2020 +0100
nxstyle: fixed various nxstyle warnings
---
fs/aio/aio.h| 1 +
fs/aio/aio_cancel.c | 8 +---
fs/aio/aio_fsync.c | 17 +
fs/aio/aio_write.c | 12 ++--
4 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/fs/aio/aio.h b/fs/aio/aio.h
index 5e80d19..e94cdf1 100644
--- a/fs/aio/aio.h
+++ b/fs/aio/aio.h
@@ -55,6 +55,7 @@
/
* Pre-processor Definitions
/
+
/* Configuration /
/* Number of pre-allocated AIO Control block containers */
diff --git a/fs/aio/aio_cancel.c b/fs/aio/aio_cancel.c
index b8cd392..1bfe747 100644
--- a/fs/aio/aio_cancel.c
+++ b/fs/aio/aio_cancel.c
@@ -124,8 +124,9 @@ int aio_cancel(int fildes, FAR struct aiocb *aiocbp)
aioc && aioc->aioc_aiocbp != aiocbp;
aioc = (FAR struct aio_container_s *)aioc->aioc_link.flink);
- /* Did we find a container for this fildes? We should; the
aio_result says
- * that the transfer is pending. If not we return AIO_ALLDONE.
+ /* Did we find a container for this fildes? We should; the
+ * aio_result says that the transfer is pending. If not we return
+ * AIO_ALLDONE.
*/
if (aioc)
@@ -198,7 +199,8 @@ int aio_cancel(int fildes, FAR struct aiocb *aiocbp)
{
/* Remove the container from the list of pending transfers */
- next = (FAR struct aio_container_s *)aioc->aioc_link.flink;
+ next =
+(FAR struct aio_container_s *)aioc->aioc_link.flink;
pid= aioc->aioc_pid;
aiocbp = aioc_decant(aioc);
DEBUGASSERT(aiocbp);
diff --git a/fs/aio/aio_fsync.c b/fs/aio/aio_fsync.c
index 687e8ef..8ef7a3e 100644
--- a/fs/aio/aio_fsync.c
+++ b/fs/aio/aio_fsync.c
@@ -165,17 +165,18 @@ static void aio_fsync_worker(FAR void *arg)
* referenced by aiocbp becomes an illegal address prior to asynchronous
* I/O completion, then the behavior is undefined.
*
- * If the aio_fsync() function fails or aiocbp indicates an error condition,
- * data is not guaranteed to have been successfully transferred.
+ * If the aio_fsync() function fails or aiocbp indicates an error
+ * condition, data is not guaranteed to have been successfully transferred.
*
* Input Parameters:
- * op - Should be either O_SYNC or O_DSYNC. Ignored in this
implementation.
+ * op - Should be either O_SYNC or O_DSYNC. Ignored in this
+ *implementation.
* aiocbp - A pointer to an instance of struct aiocb
*
* Returned Value:
* The aio_fsync() function will return the value 0 if the I/O operation is
- * successfully queued; otherwise, the function will return the value -1 and
- * set errno to indicate the error.
+ * successfully queued; otherwise, the function will return the value -1
+ * and set errno to indicate the error.
*
* The aio_fsync() function will fail if:
*
@@ -193,8 +194,8 @@ static void aio_fsync_worker(FAR void *arg)
* operation, which can be retrieved using aio_error().
*
* POSIX Compliance
- * - NuttX does not currently make any distinction between O_DYSNC and O_SYNC.
- * Hence, the 'op' argument is ignored altogether.
+ * - NuttX does not currently make any distinction between O_DYSNC and
+ * O_SYNC. Hence, the 'op' argument is ignored altogether.
* - Most errors required in the standard are not detected at this point.
* There are no pre-queuing checks for the validity of the operation.
*
@@ -205,7 +206,7 @@ int aio_fsync(int op, FAR struct aiocb *aiocbp)
FAR struct aio_container_s *aioc;
int ret;
- DEBUGASSERT(op == O_SYNC /* || op == O_DSYNC */);
+ DEBUGASSERT(op == O_SYNC); /* || op == O_DSYNC */
DEBUGASSERT(aiocbp);
/* The result -EINPROGRESS means that the transfer has not yet completed */
diff --git a/fs/aio/aio_write.c b/fs/aio/aio_write.c
index 840b7e9..0a45e73 100644
--- a/fs/aio/aio_write.c
+++ b/fs/aio/aio_write.c
@@ -204,12 +204,12 @@ errout:
*
* If O_APPEND is not set for the file descriptor aio_fildes, then the
* requested operation will take place at the absolute position in the file
- * as given by aio_offset, as if lseek() were called immediately prior to the
- * operation with an offset equal to
[GitHub] [incubator-nuttx] patacongo merged pull request #506: nxstyle: fixed various nxstyle warnings
patacongo merged pull request #506: nxstyle: fixed various nxstyle warnings URL: https://github.com/apache/incubator-nuttx/pull/506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #504: Fix nxstyle complants
patacongo merged pull request #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (3fa6bae -> 76aa3dd)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3fa6bae spi: change spi_send() interface to support of 32-bit word transfer add 76aa3dd Fix nxstyle complants No new revisions were added by this update. Summary of changes: sched/init/nx_start.c | 40 1 file changed, 20 insertions(+), 20 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle complants
patacongo commented on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596578632 I think the change seems reasonable, but should be documented in the coding standard. I see no reason to hold this up. Having one concurrence is enough to assure that this is not just the personal opinion of KAMT or me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #496: Nxstyle
johannes-nivus commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596577726 Then I should allow only single-line right of code comments in case of any other than #define preprocessor lines? I've already seen at least one multiline right of code comment next to #endif also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #504: Fix nxstyle complants
jerpelea edited a comment on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596569555 I think that we should simplify the convention and make it easy to understand +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #504: Fix nxstyle complants
jerpelea commented on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596569555 I am for simplifying the convention and making it easy to understand +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle complants
patacongo commented on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596568519 > do you disagree? No, I don't disagree at all. This situation is this: - It is and "undocumented" convention to indent all such compound statement by only two spaces. It is like this in all files. - This is not documented clearly in the coding standard. That is probably an oversight. This is not addressed at all in the coding standard except under https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#indentation where it says that the first level of indentation is 2-spaces. - I don't think there is anything wrong with changing that convention. It certainly simplified nxstyle. I am not opposed so there no reason to argue with me. I would just like to get the opinion and consenus of others. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] iceaway opened a new pull request #506: nxstyle: fixed various nxstyle warnings
iceaway opened a new pull request #506: nxstyle: fixed various nxstyle warnings URL: https://github.com/apache/incubator-nuttx/pull/506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596545421 > @patacongo @xiaoxiang781216 What do you think? > Is \sched\semaphore\sem_holder.c:445 an error or is this acceptable? > The backslash after the comment is bothering my current version: > > `#if 0 /* Need to revisit this, but these assumptions seem to be untrue -- \` > ` * OR there is a bug??? */` The backslash should be removed from sem_holder.c. It is incorrect. I just opened #505 to fix this. It is also incorrect that */ is not on a separate line. It is also incorrect that no blank line follows. PR #505 fixes those too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #500: Remove the additional apps checkout step for PR check job
liuguo09 commented on issue #500: Remove the additional apps checkout step for PR check job URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596554672 Yes, apps checkout step in nuttx PR check job is redundant. However, nuttx checkout step in apps PR check job is necessary since nuttx/tools/checkpatch.sh in need at first, as https://github.com/apache/incubator-nuttx-apps/pull/113 shows. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #505: sched/semaphore/sem_holder.c: Fix bad line separation.
patacongo commented on issue #505: sched/semaphore/sem_holder.c: Fix bad line separation. URL: https://github.com/apache/incubator-nuttx/pull/505#issuecomment-596553499 Problem noted in #496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #496: Nxstyle
patacongo edited a comment on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596545421 > @patacongo @xiaoxiang781216 What do you think? > Is \sched\semaphore\sem_holder.c:445 an error or is this acceptable? > The backslash after the comment is bothering my current version: > > `#if 0 /* Need to revisit this, but these assumptions seem to be untrue -- \` > ` * OR there is a bug??? */` The backslash should be removed from sem_holder.c. It is incorrect. I just opened #505 to fix this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #500: Remove the additional apps checkout step for PR check job
xiaoxiang781216 commented on issue #500: Remove the additional apps checkout step for PR check job URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596553421 > Was this redundant? How do we check that the PR's nuttx builds with apps? This step is ust for checking style/spell..., it's enough to only fetch nuttx git, the build step will fetch both nuttx/apps. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #505: sched/semaphore/sem_holder.c: Fix bad line separation.
patacongo opened a new pull request #505: sched/semaphore/sem_holder.c: Fix bad line separation. URL: https://github.com/apache/incubator-nuttx/pull/505 #if 0 cannot be followed by a multi-line comment to the right. Well, not without raising some odd coding standard/nxstyle issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
patacongo commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596545421 > @patacongo @xiaoxiang781216 What do you think? > Is \sched\semaphore\sem_holder.c:445 an error or is this acceptable? > The backslash after the comment is bothering my current version: > > `#if 0 /* Need to revisit this, but these assumptions seem to be untrue -- \` > ` * OR there is a bug??? */` The backslash should be removed from sem_holder.c. It is incorrect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r389686312 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: > 1. Just do not make it the the swiss arm knife. Break this stuff out to files that have names that make sense. (checkpatch should check a patch, or call it checkcontrib [ution] if it does it all things, spellcheck should check spelling...) Do this to reduce coupling. If you have common code include it. Have a separate install script for the hooks. The goal of checkpatch.sh is to ensure the patch is good to merge, so it make sense to check license/spell in checkpatch.sh too. You can implement license/spelling in another script/program just like nxstyle, but user just need run checkpatch.sh to know whether his/her patch is ready for merging. 1.Do you want user invoke check_format/check_license/check_spelling for every PR? 2.Do you want to update all pre-commit/Jenkins/github action scripts if you need add a new precheck? Or all callers(user/pre-commit/jenkin/makefile/github) invoke one script and we just modify this one script to adapter the new workflow requirement. Please remember we may change the precheck frequently before we lockdown the workflow. > 2. Add simple targets to make' - this will simplify the docs and user experiences and add an abstraction. Thy all can run the script. Do as much for the users as you can - this will empower them and make more contributors. > > `make check_format` > `make check_license` > `make check_spelling` > `make check_` It's better to just has one target(check_patch), so the user don't need to invoke make several time to know his/her patch is good. Or let user invoke check_format today, check_format/check_license tomorrow etc. > > 1. Solve the issue running the correct version of the nxstlye without the uses needed to deal with the mess. If you feel submodules are to difficult. wget the file from githup from master, add it to the ignore and build it. We just need this to not be a repeated point of error. It waste peoples time over and over again. The correct vesion is always the latest one on the master, we need rebase/cherry-pick our patch with the master anyway, why don't we run checkpatch.sh before sending PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (29be471 -> 3fa6bae)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 29be471 sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT add 3fa6bae spi: change spi_send() interface to support of 32-bit word transfer No new revisions were added by this update. Summary of changes: Documentation/NuttxPortingGuide.html | 4 +- arch/arm/src/armv7-m/up_ramvec_initialize.c| 9 +- arch/arm/src/cxd56xx/cxd56_spi.c | 35 +- arch/arm/src/efm32/efm32_spi.c | 76 +++-- arch/arm/src/efm32/efm32_spi.h | 14 +- arch/arm/src/imx1/imx_spi.c| 99 +++--- arch/arm/src/imx6/imx_ecspi.c | 91 +++--- arch/arm/src/imxrt/imxrt_lpspi.c | 26 +- arch/arm/src/kinetis/kinetis_spi.c | 6 +- arch/arm/src/kl/kl_spi.c | 144 + arch/arm/src/lc823450/lc823450_spi.c | 57 ++-- arch/arm/src/lc823450/lc823450_spi.h | 41 ++- arch/arm/src/lpc17xx_40xx/lpc17_40_spi.c | 54 ++-- arch/arm/src/lpc17xx_40xx/lpc17_40_ssp.c | 91 -- arch/arm/src/lpc2378/lpc23xx_spi.c | 58 ++-- arch/arm/src/lpc31xx/lpc31_spi.c | 237 -- arch/arm/src/lpc43xx/lpc43_spi.c | 54 ++-- arch/arm/src/lpc43xx/lpc43_ssp.c | 61 ++-- arch/arm/src/lpc54xx/lpc54_spi_master.c| 58 ++-- arch/arm/src/max326xx/max32660/max32660_spim.c | 69 ++-- arch/arm/src/nrf52/nrf52_spi.c | 15 +- arch/arm/src/s32k1xx/s32k1xx_lpspi.c | 56 ++-- arch/arm/src/sam34/sam_spi.c | 58 ++-- arch/arm/src/sama5/sam_spi.c | 74 +++-- arch/arm/src/samd2l2/sam_spi.c | 34 +- arch/arm/src/samd5e5/sam_spi.c | 30 +- arch/arm/src/samv7/sam_spi.c | 114 --- arch/arm/src/stm32/stm32_i2s.c | 164 ++ arch/arm/src/stm32/stm32_spi.c | 26 +- arch/arm/src/stm32f0l0g0/stm32_spi.c | 432 ++--- arch/arm/src/stm32f7/stm32_spi.c | 393 -- arch/arm/src/stm32f7/stm32_tim.c | 6 +- arch/arm/src/stm32h7/stm32_spi.c | 360 +++-- arch/arm/src/stm32h7/stm32_tim.c | 29 +- arch/arm/src/stm32l4/stm32l4_lptim.c | 2 +- arch/arm/src/stm32l4/stm32l4_spi.c | 378 -- arch/arm/src/stm32l4/stm32l4_tim.c | 18 +- arch/arm/src/tiva/common/tiva_ssi.c| 115 --- arch/arm/src/xmc4/xmc4_spi.c | 38 ++- arch/avr/src/avr/up_spi.c | 35 +- arch/mips/src/pic32mx/pic32mx-spi.c| 30 +- arch/mips/src/pic32mz/pic32mz-spi.c| 28 +- arch/sim/src/sim/up_spiflash.c | 31 +- arch/z16/src/z16f/z16f_espi.c | 57 ++-- arch/z80/src/ez80/ez80_spi.c | 8 +- drivers/spi/spi_bitbang.c | 9 +- include/nuttx/spi/spi.h| 13 +- 47 files changed, 2159 insertions(+), 1678 deletions(-)
[GitHub] [incubator-nuttx] yamt commented on issue #504: Fix nxstyle complants
yamt commented on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596543107 nxstyle told me this. and i couldn't find any counter-explanations in NuttXCCodingStandard.html. so i thought it should be. do you disagree? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #495: SPI: Change spi_send() interface to support of 32-bit word transfer
patacongo merged pull request #495: SPI: Change spi_send() interface to support of 32-bit word transfer URL: https://github.com/apache/incubator-nuttx/pull/495 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #495: SPI: Change spi_send() interface to support of 32-bit word transfer
patacongo commented on issue #495: SPI: Change spi_send() interface to support of 32-bit word transfer URL: https://github.com/apache/incubator-nuttx/pull/495#issuecomment-596542387 All chekcs pass. 2 of the 4 requested reviewers have approved (one cannot review until next week). The current PR is current not reviewable further due to all of the nxstyle fixes. All-in-all, I see no reason to hold thie change up any further. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #492: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT
patacongo merged pull request #492: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT URL: https://github.com/apache/incubator-nuttx/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (674417b -> 29be471)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 674417b Don't actually send a signal with signo 0 add 29be471 sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT No new revisions were added by this update. Summary of changes: arch/arm/src/sama5/sam_flexcom_serial.c | 73 - arch/arm/src/sama5/sam_serial.c | 43 ++- arch/arm/src/sama5/sam_serial.h | 4 +- arch/arm/src/sama5/sam_serialinit.c | 5 ++- 4 files changed, 74 insertions(+), 51 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on issue #504: Fix nxstyle complants
patacongo commented on issue #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504#issuecomment-596539886 What say you all... should we indent these kinds of changes by 4 spaces instead of the usual 2? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #503: Don't actually send a signal with signo 0
patacongo merged pull request #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: Don't actually send a signal with signo 0
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 674417b Don't actually send a signal with signo 0
674417b is described below
commit 674417bb3331e2f6bb8fbe569960da55645a20d0
Author: YAMAMOTO Takashi
AuthorDate: Mon Mar 9 19:38:21 2020 +0900
Don't actually send a signal with signo 0
As stated by standards.
---
sched/signal/sig_dispatch.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/sched/signal/sig_dispatch.c b/sched/signal/sig_dispatch.c
index 1e9f531..013d144 100644
--- a/sched/signal/sig_dispatch.c
+++ b/sched/signal/sig_dispatch.c
@@ -310,6 +310,13 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t
*info)
DEBUGASSERT(stcb != NULL && info != NULL);
+ /* Don't actually send a signal for signo 0. */
+
+ if (info->si_signo == 0)
+{
+ return OK;
+}
+
/** MASKED SIGNAL ACTIONS */
masked = (bool)sigismember(>sigprocmask, info->si_signo);
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596538089 Okay, it sounds like you have done a complete analysis. I will merge the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596537191 There are three ways to get to nxsig_dispatch(): kill(), sigqueue(), and via signal notifications which are used message queue and timer signal notifications. Those all seem okay. The only problem is at nxsig_dispatch() which can have different behaviors depending on configuration. So any zero signal check needs to go early in nxsg_dispatch() while the common patch is being followed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #503: Don't actually send a signal with signo 0
yamt commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596536262 do you have an example of user-facinig API with a different semantics for signo zero? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #503: Don't actually send a signal with signo 0
yamt commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596535173 group_signal uses nxsig_tcbdispatch. it was actually one of the reasons why i fixed it this way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r389686312 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: > 1. Just do not make it the the swiss arm knife. Break this stuff out to files that have names that make sense. (checkpatch should check a patch, or call it checkcontrib [ution] if it does it all things, spellcheck should check spelling...) Do this to reduce coupling. If you have common code include it. Have a separate install script for the hooks. The goal of checkpatch.sh is to ensure the patch is good to merge, so it make sense to check license/spell in checkpatch.sh too. You can implement license/spelling in another script/program just like nxstyle, but user just need run checkpatch.sh to know whether his/her patch is ready for merging. 1.Do you want user invoke check_format/check_license/check_spelling for every PR? 2.Do you want to update all pre-commit/Jenkins/github action scripts if you need add a new precheck? > 2. Add simple targets to make' - this will simplify the docs and user experiences and add an abstraction. Thy all can run the script. Do as much for the users as you can - this will empower them and make more contributors. > > `make check_format` > `make check_license` > `make check_spelling` > `make check_` It's better to just has one target(check_patch), so the user don't need to invoke make several time to know his/her patch is good. > > 1. Solve the issue running the correct version of the nxstlye without the uses needed to deal with the mess. If you feel submodules are to difficult. wget the file from githup from master, add it to the ignore and build it. We just need this to not be a repeated point of error. It waste peoples time over and over again. The correct vesion is always the latest one on the master, we need rebase/cherry-pick our patch with the master anyway, why don't we run checkpatch.sh before sending PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #503: Don't actually send a signal with signo 0
patacongo edited a comment on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596532129 Basically, your change only works if HAVE_GROUP_MEMBERS is not defined. If that is defined, then calling kill() or sigqueue() will go a different path: kill->nxsig_kill->nxsig_dispatch->group_signal You change also does not handle multi-threaded task groups. The task ID may no longer be valid, but the task group may persist. In this case, a different pthread member of the group will receive the signal. That can be fixed by moving the null signal check to lines 528 and 546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596532129 Basically, your change only works if HAVE_GROUP_MEMBERS is not defined. If that is defined, then calling kill() or sigqueue() will go a different path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596530544 I don't see the logic in kill(), it should be there because this feature has been used for years, so I am surprised. But I still need to close this change. It is not correct. Any special signal handling must be moved higher. The logic in nxsig_dispatch may do other, improper things with signal 0. It may for example, call group_signal() instead of nxsig_tcbdispatch(). The specific requirement for signal zero handler ONLY applies to kill() and sigqueue() so those would be the best place in order to keep the requirement associated with the interface. But the check the existence of the task is not performed until nxsid_tcbdispatch() so maybe that would be an acceptable place. I don't think nxsig_tcbdispatch() is the correct place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #503: Don't actually send a signal with signo 0
yamt commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596526842 @patacongo i disagree. * kill(pid, 0) still needs to do error checks (ESRCH) which is done by nxsig_dispatch. * the signo=0 semantics are shard with other API like sigqueue and pthread_kill. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #500: Remove the additional apps checkout step for PR check job
davids5 commented on issue #500: Remove the additional apps checkout step for PR check job URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596522592 Was this redundant? How do we check that the PR's nuttx builds with apps? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596521802 Then that is an error in kill() (or really nxsig_kill()). kill() has specific requirements to ignore signal 0 https://pubs.opengroup.org/onlinepubs/009695399/functions/kill.html That change should go in kill(), not nxsig_dispatch(). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook
davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r389652821 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: >@davids5 as I said before there isn't real difference between checkpatch.sh and make check_format, and it's very easy to implement check_format on top of checkpatch.sh and the patch is welcome. We talk before the reason to select checkpatch.sh as the base and let pre-commit/check_format to inovke checkpatch.sh, let me reemphasis again here: 1.The bash script can be invoke easily from most environment(jenkins, travis, github action, git hook...). 2.The coding style isn't the only check we need to do, we need do more: a.spell check b.copyright check c.defconfig check If we call nxstyle directly from pre-commit/check_format/checkpatch/..., could you tell me how can we improve(most likely) the precheck flow in the furture? 3.Since we can pass the argument to a bash script, it's very easy to let checkpatch.sh support many different usecase(patch file, source file, commit id, or even stdin). Could you tell me how can you do this in Makefile? 4.Since nxstyle isn't perfect, I have saw many discussion(at least three times) in email list to replace nxstyle with clang-format, uncrustify and more. We can adapter this change quickly if all place invoke checkpath.sh instead of nxstyle. I am not arguing against having the script. I never have. 1) Just do not make it the the swiss arm knife. Break this stuff out to files that have names that make sense. (checkpatch should check a patch, or call it checkcontrib [ution] if it does it all things, spellcheck should check spelling...) Do this to reduce coupling. If you have common code include it. Have a separate install script for the hooks. 2) Add simple targets to make' - this will simplify the docs and user experiences and add an abstraction. Thy all can run the script. Do as much for the users as you can - this will empower them and make more contributors. `make check_format` `make check_license` `make check_spelling` `make check_` 3) Solve the issue running the correct version of the nxstlye without the uses needed to deal with the mess. If you feel submodules are to difficult. wget the file from githup from master, add it to the ignore and build it. We just need this to not be a repeated point of error. It waste peoples time over and over again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #503: Don't actually send a signal with signo 0
yamt commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596516262 @patacongo yes, i saw the symptom. can you pinpoint where "much high up in the signal sequence" is? (gdb) bt #0 nxsig_tcbdispatch (stcb=0xfffd, info=0x3ffb7b34) at signal/sig_dispatch.c:302 #1 0x400d19e0 in nxsig_dispatch (pid=, info=0x3ffb7b34) at signal/sig_dispatch.c:546 #2 0x400dc028 in nxsig_kill (pid=5, signo=0) at signal/sig_kill.c:129 #3 0x400dc03c in kill (pid=5, signo=0) at signal/sig_kill.c:172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596514262 > Are you seeing an actual bug that this fixes? If you are, I would also like to know the logic sequence. As I said, signal 0 should never get here. A DEBUGASSERT(signal != 0) might be appropriate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #504: Fix nxstyle complants
yamt opened a new pull request #504: Fix nxstyle complants URL: https://github.com/apache/incubator-nuttx/pull/504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #503: Don't actually send a signal with signo 0
patacongo commented on issue #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503#issuecomment-596513682 This should not be needed. The check for signal zero is handled much high up in the signal sequence. Signal 0 should never make it to this code. Are you seeing an actual bug that this fixes? Otherwise, I believe that this change is incorrect and I will decline it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #496: Nxstyle
davids5 commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596503383 @johannes-nivus - If you run ito more of these it would be of great value, if you would share the section of code that fails and where you think the issues in in nxstyle. By having that context we can add more value here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #501: Fixed RTC periodic callback issue
xiaoxiang781216 merged pull request #501: Fixed RTC periodic callback issue URL: https://github.com/apache/incubator-nuttx/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (712e4b5 -> 655fcf1)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 712e4b5 change README.txt link to github add 655fcf1 Fixed RTC periodic callback issue No new revisions were added by this update. Summary of changes: drivers/timers/rtc.c | 4 1 file changed, 4 deletions(-)
[GitHub] [incubator-nuttx] anjana-tel commented on issue #501: Fixed RTC periodic callback issue
anjana-tel commented on issue #501: Fixed RTC periodic callback issue URL: https://github.com/apache/incubator-nuttx/pull/501#issuecomment-596463772 I have squashed the commits. Commit ID : 9e864c49299f35d71e0cb305742d35f870eeadf2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #496: Nxstyle
johannes-nivus commented on issue #496: Nxstyle URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596463253 I answer myself: The backslash is just part of the comment, so it must be ignored. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #503: Don't actually send a signal with signo 0
yamt opened a new pull request #503: Don't actually send a signal with signo 0 URL: https://github.com/apache/incubator-nuttx/pull/503 As stated by standards. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
