[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824556566 Lets just revert this as is in this PR, and I can make a fix this weekend that allows unicast bootp again with the L2 filtering and validate it with wireshark/iperf especially since I think this should apply to TCP as well (need to read the RFC). I will be sure to add more comments in that PR explaining exactly what is going on, and it does seem reasonable to put this behind a Kconfig flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] annotated tag nuttx-10.0.1 updated (fcdaba9 -> 136e7e0)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to annotated tag nuttx-10.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. *** WARNING: tag nuttx-10.0.1 was modified! *** from fcdaba9 (commit) to 136e7e0 (tag) tagging fcdaba9254efc355ecad812a01d8f3f774122954 (commit) replaces nuttx-9.1.0-RC0 by Brennan Ashton on Sat Dec 5 21:41:50 2020 -0800 - Log - nuttx-10.0.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEZsSDKhZezJNUiVogl1DtfmkrmeIFAl/Mbx4ACgkQl1Dtfmkr meJ5nQ//SL2SMc8LdOS2gOr6SD2RGJ1K+F+MQgcM0tootd54msLTx4R1IGDCX/O6 8yigS1L66ojRHAcXXS7EmBWAgA1xn/5XsrDBEgHvlsPZrz6r0c7mbA0tuamK4UJx 8kJqpz+zOkNPCTOK5R6Qk/Zu8qdDkgkF/hoYzW8HrNUqj+9pNHPROUNGE8OTyQ+m R6MTK8qQ9K0s+Q7WPam+WCvw+Af8e5tjg5p7cJIxahMyM7Tuzhs+dZNO3boB74fX TK/S0YQKfPYOgZiX8eF88jPoHGXSTOYsn0IcsBvO6QXiiMlODH2sY8K1r87mcf2l LB5ziYXlqgCm3/K9BoR3EkMOvbeKIOIQwCv9YWSIhkzLOHK4cSCFAvq9yhwPnduL 1IEv4pCwkQdyVo2XXWzQFQvtFYgcDC5w5TYAcrJcQxzbeblHGGAtT2iGsOtRbFEl TyS0vGkgVVpjV0XBq8CRYUATnf9NQXRzQ48S3HLyl9Ovgy/5FrPpIGBYdhu5BGQ7 C/4VaLl3bJ5bkEh6OSkEuCjqF1mCe7RQOVTTIJA65wUtcQv5UyYeGnAStQim9q2L D/zFJHF7VB5YUnqk+UlZdKhVkgN+hJ2+19et9VV648wsXKiWiIIiUbU4Pcj0bgqt 2SV1w5dVcj/6RuY3G4kuxLyxUarL1rmw66Dpd0PNR3xRploCZfU= =c09T -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[incubator-nuttx-apps] annotated tag nuttx-9.1.1 updated (4fac1c1 -> 3daaaf7)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to annotated tag nuttx-9.1.1 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. *** WARNING: tag nuttx-9.1.1 was modified! *** from 4fac1c1 (commit) to 3daaaf7 (tag) tagging 4fac1c185c01adfa84f04618af9be7b9c4b884f5 (commit) replaces nuttx-9.1.0-RC1 by Brennan Ashton on Wed Apr 21 22:16:24 2021 -0700 - Log - nuttx-9.1.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEZsSDKhZezJNUiVogl1DtfmkrmeIFAmCBBqgACgkQl1Dtfmkr meJngA/+Ng9i3TZbGbRFibHa/StDbbn4WNhv83acn/ZAtkLLheltrjRpXlpCuLO3 AxBpY+dqZQgtc6YkVwc56Vk2ZwNVDkL3dpvm2TTd9lRQ9oJcUy0ZIRfLnri8xXou UV1qZtkIaFm/PI7y+VPZUz3agjvm3Znq+QMPK/wPIKmXQOVZ/pnKHmxu9CPTG6dA azBA7FW+5N9bESZfhXLUIZnfq8OMpfso3NXBm3YtKM7BP2wQfFvoBO2+y8kzt+2q DrgzL8me96MjDwgQP8oAH9hfQROfgnoZiU46chX9LI4RJ0TGFNGFcAKnv7/7up1p CDR2mHildNVRekM6v0P//zXv1WWpu6KH+LN6owH4GL27dBqPwfoyN4VpdrtV0Nq1 gNUk2km2Y8sOAHf2K5hea4wMS38CWve2Ks3JfPhpuY4jvR62bqO3TNNbq9+UjjQ9 xo3wE5v++cBFwAgUK2UkYlKP/AKe30LL5DjIS3USBORNtG41Dsp6BOkfv29260+9 97Q82/o8i/6ps91V5a6jOTMyC3BPfxEsiT+hbdpLi5fIuJs+ZhgXSoUZID2+B1y7 Z7mmR/BJhDQG4vNvdOnIvway7bBQg3T0KHwJm45++IuFNzWX0RVT25MC1tNfWsBb 2NpN7o2WCNBDeniqnCFfiQYb5FrA/glnfw/iPKDbXj2JrTwLDtM= =a/X/ -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824545670 > > > @antmerlino do you think we could just further conditional this on having the L2 address be correct? Then we would still drop all UDP traffic that is not destined for us unless it targeted our L2 address. As it is now, I think it is a real performance killer. As much filtering as soon as possible would help recover some of the performance that was lost. Couldn't you also do a simple check for A bootstrap protocol packet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] annotated tag nuttx-9.1.1 updated (561cbbc -> 2e9dd3f)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to annotated tag nuttx-9.1.1 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. *** WARNING: tag nuttx-9.1.1 was modified! *** from 561cbbc (commit) to 2e9dd3f (tag) tagging 561cbbca96a749e4d2e9ec2ea672f257dc5348aa (commit) replaces nuttx-9.1.0 by Brennan Ashton on Wed Apr 21 22:14:02 2021 -0700 - Log - nuttx-9.1.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEZsSDKhZezJNUiVogl1DtfmkrmeIFAmCBBhoACgkQl1Dtfmkr meIcqg/9H2vp/WL935CxueFOsaDU30pzD7vOY3qqJb80MqDK6MPWo+0yiSXTmGtg g2NJiEI2yWr0ECaJ2jgbRSrOz4ekrdFJkTbrI7RNuYjPmjjQF2Xt7vU/f+RtFQ1T jiTrRFe9FpaqAEXukFcJTbfbD8ChHIdGbDjT23KokiWGxMA3KCcMjNmUDMQyo7Ri B5UdnmZY0kXZFvMF4RLqdCV3b59JEbAOHXcyn2kR0Do8U9BQW7zjrqYwcaXkzAcx 9oQGPfVQ3KsrexNflO1uoUNTpZt9oI9tJDyL7opnlJOGL5HWBLKPDyUdTLBZUVjk mOXsI6SGErwrRNvS1jNJyimIr9EG3QZZKx1XL8MBAU2Xn1DESCwSMqN49Dua+I8I k8lJRDkix0CDRGKOzLg/U4K3FydTmVfP4AjSzGmVh6EJ7UChn08nA5lE8ybCk+Nc mehdfgFL+2n4U5szSFIrdumkdRd0RDu27iUjY6TIUnUcJw1fTkCMZ0EFyaopupJX NWlCJfjLPeahlTt6PVhW6TAbVQeEi4+D+IJ7MxAHs3Pb/iLwfGUlGWm8GZq4U8f9 AGfSd/tPC+ssSEs091Y0Ln5PsdtFhIBx9ArEsLwZRxizYzzoz8WeBXcEhy3q1pfI u9reZdrPrdsPXP9wvFqJKLDWFBaRhPUvYibphIOR9j+LqZ6YcGk= =Y8Ky -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824540220 @antmerlino do you think we could just further conditional this on having the L2 address be correct? Then we would still drop all UDP traffic that is not destined for us unless it targeted our L2 address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (f696364 -> ae42005)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f696364 xtensa/esp32: Adds freerun wrapper add ae42005 esp32/mcp2515: Enable irq after attaching to the pin irq No new revisions were added by this update. Summary of changes: boards/xtensa/esp32/common/src/esp32_mcp2515.c | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3585: esp32/mcp2515: Enable irq after attaching to the pin irq
xiaoxiang781216 merged pull request #3585: URL: https://github.com/apache/incubator-nuttx/pull/3585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #3587: risc-v/esp32-c3: Adds oneshot timer driver.
saramonteiro opened a new pull request #3587: URL: https://github.com/apache/incubator-nuttx/pull/3587 ## Summary This PR adds support for the oneshot timer driver for ESP32-C3. It implements the lower-half and also an oneshot wrapper that can be used in the future by other drivers or OS code as necessary, e.g., tickless code. ## Impact All ESP32-C3 timers users. Note: The timers logic in the bring up files was changed to provide a better decoupling. ## Testing The oneshot timer driver was successfully tested in esp32c3-devkitc using the oneshot example.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824448321 > > I will remove myself as a reviewer since I obviously have no clue why the change was made. > > @patacongo Do you mean the original change, or my change reverting it? Both, but I was referring to the original change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446646 > > > This is required to support dhcp bootp unicast. > This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2 @btashton There are some useful bits in here: https://networkengineering.stackexchange.com/questions/16947/is-a-dhcp-offer-packet-a-broadcast-or-unicast So I understand why it's needed now, but I still don't think the way it's implemented is acceptable. Two things mentioned in the link above that might be helpful: 1. Some hosts simply don't support receiving unicast before an IP is assigned. 2. On the hosts that do, I see notes about checking the L2 address Another thought after reading that is that we only enable this logic when there is not an IP address assigned. I propose 2 things: 1) Add a Kconfig option for allowing unicast before IP address is set that enables this behavior - this way users have to opt-in for this. 2) Only allow UDP unicast not destined for us through when we haven't assigned an IP address yet. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446646 > > > This is required to support dhcp bootp unicast. > This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2 @btashton There are some useful bits in here: https://networkengineering.stackexchange.com/questions/16947/is-a-dhcp-offer-packet-a-broadcast-or-unicast So I understand why it's needed now, but I still don't think the way it's implemented is acceptable. Two things mentioned in the link above that might be helpful: 1. Some hosts simply don't support receiving unicast before an IP is assigned. 2. On the hosts that do, I see notes about checking the L2 address Another thought after reading that is that we only enable this logic when there is not an IP address assigned. I propose 2 things: 1) Add a Kconfig option for allowing unicast before IP address is set that enables this behavior - this way users have to opt-in for this. 2) Only allow UDP unicaset not destined for us through when we haven't assigned an IP address yet. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446903 > > > I will remove myself as a reviewer since I obviously have no clue why the change was made. @patacongo Do you mean the original change, or my change reverting it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446774 This can be any address as it is the offer IP. @anchao would be better to respond though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824446646 > > > This is required to support dhcp bootp unicast. > This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2 @btashton There are some useful bits in here: https://networkengineering.stackexchange.com/questions/16947/is-a-dhcp-offer-packet-a-broadcast-or-unicast So I understand why it's needed now, but I still don't think the way it's implemented is acceptable. Two things mentioned in the link above that might be helpful: 1. Some hosts simply don't support receiving unicast before an IP is assigned. 2. On the hosts that do, I see notes about checking the L2 address Another thought after reading that is that we only enable this logic when there is not an IP address assigned. I propose 2 things: 1) Add a Kconfig option for allowing unicast before IP address is set that enables this behavior - this way uses have to opt-in for this. 2) Only allow UDP unicaset not destined for us through when we haven't assigned an IP address yet. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: 706feb7a8f09ba9c0ea4111239db9d4c65cf9a00 docs: f696364b6aba19fc89390e98574cdeb6d110eb55
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new b76ba2a Publishing web: 706feb7a8f09ba9c0ea4111239db9d4c65cf9a00 docs: f696364b6aba19fc89390e98574cdeb6d110eb55 b76ba2a is described below commit b76ba2ab44a874cdbe3c5edd2e60d0ece04111fd Author: Ouss4 AuthorDate: Thu Apr 22 00:14:49 2021 + Publishing web: 706feb7a8f09ba9c0ea4111239db9d4c65cf9a00 docs: f696364b6aba19fc89390e98574cdeb6d110eb55 --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/latest/_sources/guides/drivers.rst.txt | 2 +- .../_sources/platforms/arm/imxrt/index.rst.txt | 2 +- .../_sources/platforms/xtensa/esp32/index.rst.txt | 5 ++--- .../docs/latest/_sources/reference/os/index.rst.txt | 2 +- content/docs/latest/guides/drivers.html | 2 +- content/docs/latest/index.html | 2 +- content/docs/latest/objects.inv | Bin 31725 -> 31720 bytes .../arm/imxrt/boards/teensy-4.x/index.html | 2 +- content/docs/latest/platforms/arm/imxrt/index.html | 6 +++--- .../docs/latest/platforms/xtensa/esp32/index.html | 5 ++--- content/docs/latest/reference/os/index.html | 2 +- content/docs/latest/searchindex.js | 2 +- content/feed.xml| 4 ++-- 15 files changed, 19 insertions(+), 21 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 9c9a22c..4188969 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 April 21 at 00:11 +Last Updated: 22 April 21 at 00:12 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 1da3a82..f17964d 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -211,7 +211,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 April 21 at 00:11 +Last Updated: 22 April 21 at 00:12 Table of Contents diff --git a/content/docs/latest/_sources/guides/drivers.rst.txt b/content/docs/latest/_sources/guides/drivers.rst.txt index 4ff167f..fbf5464 100644 --- a/content/docs/latest/_sources/guides/drivers.rst.txt +++ b/content/docs/latest/_sources/guides/drivers.rst.txt @@ -149,7 +149,7 @@ NuttX Drivers as a Reference If you're not porting a NuttX driver from another architecture, it still helps to look at other similar NuttX drivers, if there are any. For instance, when implementing an Ethernet driver, look at other NuttX Ethernet drivers; -for an SD Card driver, look at other NuttX Ethernet drivers. Even if the chip-specific code won't be the same, the +for an SD Card driver, look at other NuttX SD Card drivers. Even if the chip-specific code won't be the same, the structure to interface with NuttX can be used. Using Chip Datasheets diff --git a/content/docs/latest/_sources/platforms/arm/imxrt/index.rst.txt b/content/docs/latest/_sources/platforms/arm/imxrt/index.rst.txt index ab39387..6a0f9b3 100644 --- a/content/docs/latest/_sources/platforms/arm/imxrt/index.rst.txt +++ b/content/docs/latest/_sources/platforms/arm/imxrt/index.rst.txt @@ -5,7 +5,7 @@ i.MX RT The i.MX RT series of chips from NXP Semiconductors is based around an ARM Cortex-M7 core running at 500 MHz, 600 MHz or 1 GHz based on particular MCUs -Suported MCUs +Supported MCUs = The following list includes MCUs from i.MX RT series and indicates whether they are supported in NuttX diff --git a/content/docs/latest/_sources/platforms/xtensa/esp32/index.rst.txt b/content/docs/latest/_sources/platforms/xtensa/esp32/index.rst.txt index 6124430..c47ab0c 100644 ---
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824445603 I will remove myself as a reviewer since I obviously have no clue why the change was made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824445207 > > > This is required to support dhcp bootp unicast. > This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2 Comments would still be helpful. Wouldn't it also be better to check for any special addresses rather than letting all of them pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #521: nshlib: Fix nsh_usbconsole.c
masayuki2009 commented on pull request #521: URL: https://github.com/apache/incubator-nuttx-apps/pull/521#issuecomment-824443431 FYI. https://github.com/apache/incubator-nuttx-apps/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo removed a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo removed a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824433977 > 2\. It is abysmal programming style that there are no comments explaining this in the code but this might be an acceptable case. I would also like to hear the explanation. Should there also be a case for CONFIG_NET_TCP_NO_STACK? I don't understand that situation where this special kludge handling of UDP is needed, but why is TCP not symmetric since it has the same kind of conditioning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
_G... I got some things confused here. I was looking at the wrong line
number in viewing the file. So the talk about the switch statement and default
case (around line 380) is bogus since the change is at line 300 for IPv4.
Sorry. Maybe this rambling is useful anyway._
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
_G... I got some things confused here. I was looking at the wrong line
number in viewing the file. So the talk about the switch statement and default
case (around line 380) is bogus. Sorry. Maybe this rambling is useful anyway._
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824439762 This is required to support dhcp bootp unicast. This looks like this https://community.arubanetworks.com/browse/articles/blogviewer?blogkey=f5df0149-baf4-485a-9c1b-5e136b1a7ad2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824433977 > 2\. It is abysmal programming style that there are no comments explaining this in the code but this might be an acceptable case. I would also like to hear the explanation. Should there also be a case for CONFIG_NET_TCP_NO_STACK? I don't understand that situation where this special kludge handling of UDP is needed, but why is TCP not symmetric since it has the same kind of conditioning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
!defined(CONFIG_NET_UDP) || defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifndef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
!defined(CONFIG_NET_UDP) || defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifndef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
!defined(CONFIG_NET_UDP) || defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
!defined(CONFIG_NET_UDP) || defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If UDP is _not_
enabled, then UDP packets much always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.These "bad" UDP packets would be accepted if:
1. UDP is not enabled. THAT is a bug!!! If UDP is not enabled, then UDP
packets much always be dropped. That needs to be fixed.
2. This can also happen is `NET_UDP_HAVE_STACK` is not defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
`NET_UDP_HAVE_STACK` is equivalent to:
!defined(CONFIG_NET_UDP) || defined(CONFIG_NET_UDP_NO_STACK)
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
Although it seems like the "dropped" statistics are incremented in any case.
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet. These "bad" UDP packets would be accepted if:
1. UDP is not enabled. THAT is a bug!!! If UDP is not enabled, then UDP
packets much always be dropped. That needs to be fixed.
2. This can also happen is `NET_UDP_HAVE_STACK` is not defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be even better if the if were conditioned on `#ifndef
NET_UDP_HAVE_STACK`. With that conditioning, I think the change is OK, isn't
it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino opened a new pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino opened a new pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586 ## Summary Reverts a change introduced in ab148bc69fe that allowed specifically UDP packets that aren't destined for the interface to pass through. Perhaps there is a need for extended support for bypassing address checks if needed, but I strongly disagree with changing the default behavior to blindly accept traffic not destined for us. I can tell you first hand the havic it can wreak when packets that aren't destined for an endpoint start being accepted as valid data. ## Impact @anchao Can you better explain why this was needed so that we can find a more appropriate solution? To me, this is a hack and should never have been accepted. ## Testing Built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (e23c3ff -> f696364)
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from e23c3ff arch: remove up_irq{save|restore} these come from irq.h
add f696364 xtensa/esp32: Adds freerun wrapper
No new revisions were added by this update.
Summary of changes:
arch/xtensa/src/esp32/Kconfig | 7 +
arch/xtensa/src/esp32/Make.defs| 4 +
.../src/esp32/esp32_freerun.c} | 235 -
.../src/esp32/esp32_freerun.h} | 59 ++
arch/xtensa/src/esp32/esp32_tim.c | 55 -
arch/xtensa/src/esp32/esp32_tim.h | 2 +
6 files changed, 224 insertions(+), 138 deletions(-)
copy arch/{arm/src/stm32/stm32_freerun.c => xtensa/src/esp32/esp32_freerun.c}
(54%)
copy arch/{arm/src/stm32/stm32_freerun.h => xtensa/src/esp32/esp32_freerun.h}
(76%)
[GitHub] [incubator-nuttx] acassis merged pull request #3583: xtensa/esp32: Adds freerun wrapper
acassis merged pull request #3583: URL: https://github.com/apache/incubator-nuttx/pull/3583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (f43f066 -> e23c3ff)
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f43f066 boards: Update the iperf configs.
add e23c3ff arch: remove up_irq{save|restore} these come from irq.h
No new revisions were added by this update.
Summary of changes:
include/nuttx/arch.h | 33 -
1 file changed, 33 deletions(-)
[GitHub] [incubator-nuttx] acassis merged pull request #3580: arch: move up_irq{save|restore} to irq.h
acassis merged pull request #3580: URL: https://github.com/apache/incubator-nuttx/pull/3580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis opened a new pull request #3585: esp32/mcp2515: Enable irq after attaching to the pin irq
acassis opened a new pull request #3585: URL: https://github.com/apache/incubator-nuttx/pull/3585 ## Summary esp32/mcp2515: Enable irq after attaching to the pin irq ## Impact MCP2515 will work to receive data ## Testing ESP32-Devkitc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3584: boards: Update the iperf configs.
xiaoxiang781216 merged pull request #3584: URL: https://github.com/apache/incubator-nuttx/pull/3584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (1b00e5d -> f43f066)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1b00e5d spinlock: Remove SP_SECTION add f43f066 boards: Update the iperf configs. No new revisions were added by this update. Summary of changes: boards/arm/cxd56xx/spresense/configs/rndis/defconfig | 4 ++-- boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig | 4 ++-- boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig | 4 ++-- boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig | 4 ++-- boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig | 4 ++-- boards/arm/imxrt/imxrt1064-evk/configs/netnsh/defconfig | 4 ++-- boards/arm/lc823450/lc823450-xgevk/configs/rndis/defconfig | 4 ++-- boards/arm/stm32h7/nucleo-h743zi2/configs/jumbo/defconfig| 4 ++-- boards/arm/tiva/lm3s6965-ek/configs/discover/defconfig | 4 ++-- boards/risc-v/bl602/bl602evb/configs/wifi/defconfig | 2 +- boards/xtensa/esp32/esp32-devkitc/configs/wapi_smp/defconfig | 2 +- 11 files changed, 20 insertions(+), 20 deletions(-)
[incubator-nuttx-apps] branch master updated: netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_.
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 80eba3a netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_. 80eba3a is described below commit 80eba3aad1299ebb67fcb5df4b07e4d541254a6b Author: Abdelatif Guettouche AuthorDate: Wed Apr 21 14:27:02 2021 +0100 netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_. --- netutils/iperf/Kconfig | 12 ++-- netutils/iperf/Make.defs| 2 +- netutils/iperf/Makefile | 8 netutils/iperf/README.md| 4 netutils/iperf/iperf_main.c | 4 ++-- 5 files changed, 13 insertions(+), 17 deletions(-) diff --git a/netutils/iperf/Kconfig b/netutils/iperf/Kconfig index 0c4f008..3cebb9c 100644 --- a/netutils/iperf/Kconfig +++ b/netutils/iperf/Kconfig @@ -3,7 +3,7 @@ # see the file kconfig-language.txt in the NuttX tools repository. # -config EXAMPLES_IPERF +config NETUTILS_IPERF bool "iperf example" default n depends on NET @@ -13,24 +13,24 @@ config EXAMPLES_IPERF ---help--- Enable the \"iperf example\" -if EXAMPLES_IPERF +if NETUTILS_IPERF -config EXAMPLES_IPERF_PROGNAME +config NETUTILS_IPERF_PROGNAME string "Program name" default "iperf" ---help--- This is the name of the program that will be used when the NSH ELF program is installed. -config EXAMPLES_IPERF_PRIORITY +config NETUTILS_IPERF_PRIORITY int "iperf task priority" default 100 -config EXAMPLES_IPERF_STACKSIZE +config NETUTILS_IPERF_STACKSIZE int "iperf stack size" default DEFAULT_TASK_STACKSIZE -config EXAMPLES_IPERFTEST_DEVNAME +config NETUTILS_IPERFTEST_DEVNAME string "Wi-Fi Network device" default "wlan0" diff --git a/netutils/iperf/Make.defs b/netutils/iperf/Make.defs index 13effb7..0e12136 100644 --- a/netutils/iperf/Make.defs +++ b/netutils/iperf/Make.defs @@ -19,6 +19,6 @@ # -ifneq ($(CONFIG_EXAMPLES_IPERF),) +ifneq ($(CONFIG_NETUTILS_IPERF),) CONFIGURED_APPS += $(APPDIR)/netutils/iperf endif diff --git a/netutils/iperf/Makefile b/netutils/iperf/Makefile index 437675c..9db5e0c 100644 --- a/netutils/iperf/Makefile +++ b/netutils/iperf/Makefile @@ -22,10 +22,10 @@ include $(APPDIR)/Make.defs # iperf example! built-in application info -PROGNAME = $(CONFIG_EXAMPLES_IPERF_PROGNAME) -PRIORITY = $(CONFIG_EXAMPLES_IPERF_PRIORITY) -STACKSIZE = $(CONFIG_EXAMPLES_IPERF_STACKSIZE) -MODULE= $(CONFIG_EXAMPLES_IPERF) +PROGNAME = $(CONFIG_NETUTILS_IPERF_PROGNAME) +PRIORITY = $(CONFIG_NETUTILS_IPERF_PRIORITY) +STACKSIZE = $(CONFIG_NETUTILS_IPERF_STACKSIZE) +MODULE= $(CONFIG_NETUTILS_IPERF) # Iperf Example diff --git a/netutils/iperf/README.md b/netutils/iperf/README.md index 7d76d80..89d95fe 100644 --- a/netutils/iperf/README.md +++ b/netutils/iperf/README.md @@ -92,7 +92,3 @@ Now on the host you should see something like: This will tell you the link speed in Kbits/sec – kilobits per second. If you want kilobytes, divide by 8. - - - - diff --git a/netutils/iperf/iperf_main.c b/netutils/iperf/iperf_main.c index 15c1c08..39e8cfc 100644 --- a/netutils/iperf/iperf_main.c +++ b/netutils/iperf/iperf_main.c @@ -34,8 +34,8 @@ * Pre-processor Definitions / -#ifdef CONFIG_EXAMPLES_IPERFTEST_DEVNAME -# define DEVNAME CONFIG_EXAMPLES_IPERFTEST_DEVNAME +#ifdef CONFIG_NETUTILS_IPERFTEST_DEVNAME +# define DEVNAME CONFIG_NETUTILS_IPERFTEST_DEVNAME #else # define DEVNAME "wlan0" #endif
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #690: netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_.
xiaoxiang781216 merged pull request #690: URL: https://github.com/apache/incubator-nuttx-apps/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed issue #689: netutils/iperf uses CONFIG_EXAMPLES_IPERF
xiaoxiang781216 closed issue #689: URL: https://github.com/apache/incubator-nuttx-apps/issues/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #690: netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_.
xiaoxiang781216 commented on pull request #690: URL: https://github.com/apache/incubator-nuttx-apps/pull/690#issuecomment-824126884 @Ouss4 need update spresense/rndis config too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (0146e88 -> 084cc55)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 0146e88 examples/modbus: Add Reg Coil support and use it to control USERLEDs add 2214e51 netutls/usrsock_rpmsg_server: add support for send reassemble add 084cc55 usrsock/server: replace the wakeup source to eventfd No new revisions were added by this update. Summary of changes: netutils/usrsock_rpmsg/Kconfig| 8 +- netutils/usrsock_rpmsg/usrsock_rpmsg_server.c | 277 +++--- 2 files changed, 216 insertions(+), 69 deletions(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #688: netutls/usrsock_rpmsg_server: add support for send reassemble
xiaoxiang781216 merged pull request #688: URL: https://github.com/apache/incubator-nuttx-apps/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3580: arch: move up_irq{save|restore} to irq.h
davids5 commented on pull request #3580: URL: https://github.com/apache/incubator-nuttx/pull/3580#issuecomment-824066329 > > @gustavonihei @btashton - how should we proceed? > > I believe that those function declarations on bl602/irq.h are not necessary and should be removed. Those function are already declared on the RISC-V generic header, which is shared among other chips. > If removing them triggers another error, then we should fix the root cause. @gustavonihei - thank you. Let's See how CI feels about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 opened a new pull request #690: netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_.
Ouss4 opened a new pull request #690: URL: https://github.com/apache/incubator-nuttx-apps/pull/690 ## Summary netutils/iperf: Configs were using EXAMPLES_ instead of NETUTILS_. ## Impact Closes #689 ## Testing esp32-devkitc:wapi with iperf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3580: arch: move up_irq{save|restore} to irq.h
gustavonihei commented on pull request #3580: URL: https://github.com/apache/incubator-nuttx/pull/3580#issuecomment-824030006 > @gustavonihei @btashton - how should we proceed? I believe that those function declarations on bl602/irq.h are not necessary and should be removed. Those function are already declared on the RISC-V generic header, which is shared among other chips. If removing them triggers another error, then we should fix the root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #3583: xtensa/esp32: Adds freerun wrapper
saramonteiro opened a new pull request #3583: URL: https://github.com/apache/incubator-nuttx/pull/3583 ## Summary This PR aims to: - Create a freerun wrapper for ESP32. ## Impact N/A ## Testing Tests results: To perform a test por the freerun wrapper was a little bit tricky, since it is not exposed as a character driver like oneshot is. So, I had to "violate" and call it from the user space:  To make sure the the timer was properly configured and ensure its accuracy I tested the get counter function by using the timer driver because `usleep` and similar functions don't garante accuracy. Besides that, since the freerun standard timeout period is too long (the maximum the timer can count), I used other short period only to test the interrupt. Dependencies: Any timer instance that will be used by the freerun and CONFIG_ESP32_FREERUN. NOTE for future users: If someone wishes to develop some driver upon the freerun wrapper, have to keep in mind that the timer logic on bringup must be adjusted to prevent the used timer to be initialized as a character driver. Just like it was done for the oneshot. For now, since nothing is currently using freerun, there was anything to do on bringup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiewenxiang commented on a change in pull request #3543: feat(esp32c3): Support esp32c3 ble function
xiewenxiang commented on a change in pull request #3543:
URL: https://github.com/apache/incubator-nuttx/pull/3543#discussion_r617282565
##
File path: arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c
##
@@ -0,0 +1,2059 @@
+/
+ * arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#ifdef CONFIG_ESP32C3_BLE
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "esp32c3_ble_adapter.h"
+#include "hardware/esp32c3_syscon.h"
+#include "esp32c3.h"
+#include "esp32c3_attr.h"
+#include "esp32c3_irq.h"
+#include "esp32c3_rt_timer.h"
+
+#include "nuttx/kmalloc.h"
+#include
+#include "nuttx/spinlock.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "espidf_wifi.h"
+
+/
+ * Pre-processor Definitions
+ /
+#define OSI_FUNCS_TIME_BLOCKING 0x
+#define OSI_VERSION 0x00010006
+#define OSI_MAGIC_VALUE 0xfadebead
+
+/
+ * Private Types
+ /
+
+/* BLE message queue private data */
+
+struct mq_adpt
+{
+ struct file mq; /* Message queue handle */
+ uint32_tmsgsize; /* Message size */
+ charname[16]; /* Message queue name */
+};
+
+/* BLE interrupt adapter private data */
+
+struct irq_adpt
+{
+ void (*func)(void *arg); /* Interrupt callback function */
+ void *arg;/* Interrupt private data */
+};
+
+/* BLE low power control struct */
+
+typedef union
+{
+struct
+{
+uint32_t enable : 1; /* whether low power mode is
required */
+uint32_t lpclk_sel : 2; /* low power clock source */
+uint32_t mac_bb_pd : 1; /* whether hardware(MAC, BB)
force-power-down is required during sleep */
+uint32_t wakeup_timer_required : 1; /* whether system timer is
needed */
+uint32_t no_light_sleep : 1; /* do not allow system to enter
light sleep after bluetooth is enabled */
+uint32_t reserved: 26; /* reserved */
+};
+uint32_t val;
+} btdm_lpcntl_t;
+
+/* low power control status */
+
+typedef union
+{
+struct
+{
+uint32_t pm_lock_released: 1; /* whether power management
lock is released */
+uint32_t mac_bb_pd : 1; /* whether hardware(MAC, BB) is
powered down */
+uint32_t phy_enabled : 1; /* whether phy is switched on */
+uint32_t wakeup_timer_started: 1; /* whether wakeup timer is
started */
+uint32_t reserved: 28; /* reserved */
+};
+uint32_t val;
+} btdm_lpstat_t;
+
+/* vendor dependent signals to be posted to controller task */
+
+typedef enum
+{
+BTDM_VND_OL_SIG_WAKEUP_TMR = 0,
+BTDM_VND_OL_SIG_NUM,
+} btdm_vnd_ol_sig_t;
+
+/* prototype of function to handle vendor dependent signals */
+
+typedef void (* btdm_vnd_ol_task_func_t)(void *param);
+
+/* VHCI function interface */
+
+typedef struct vhci_host_callback
+{
+void (*notify_host_send_available)(void); /* callback used
to notify that the host can send packet to controller */
+int (*notify_host_recv)(uint8_t *data, uint16_t len); /* callback used
to notify that the controller has a packet to send to the host */
+} vhci_host_callback_t;
+
+/* Dram region */
+
+typedef struct
+{
+esp_bt_mode_t mode;
+intptr_t start;
+intptr_t end;
+} btdm_dram_available_region_t;
+
+typedef void (* osi_intr_handler)(void);
+
+/* BLE OS
