[GitHub] [incubator-nuttx] anchao opened a new pull request #3759: arm/v7-a/fpu: add VFP-v3 D32 support
anchao opened a new pull request #3759: URL: https://github.com/apache/incubator-nuttx/pull/3759 ## Summary arm/v7-a/fpu: add VFP-v3 D32 support There are some necessary neon registers that have not been properly saved and restored Reference here: https://developer.arm.com/documentation/dht0002/a/Introducing-NEON/NEON-architecture-overview/NEON-registers ## Impact NEON registers ## Testing check/assign/save/restore the D16-D31 registers after/before context switch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request #3758: net/tcp/retransmit: recounter the ack counter during obtain newdata
anchao opened a new pull request #3758: URL: https://github.com/apache/incubator-nuttx/pull/3758 ## Summary net/tcp/retransmit: recounter the ack counter during obtain newdata Only accumulate duplicate ACK counter when we receive duplicate ACK data ## Impact Fast retransmit ## Testing iperf test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #3757: riscv: Add inline IRQ process functions
donghengqaz opened a new pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757 ## Summary riscv adds inline IRQ process functions. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request #3756: net/tcp: set/get TCP_KEEPINTVL/IDLE value as BSD style
anchao opened a new pull request #3756: URL: https://github.com/apache/incubator-nuttx/pull/3756 ## Summary net/tcp: set/get TCP_KEEPINTVL/IDLE value as BSD style Add integer support ## Impact set/getsockopt ## Testing set/getsockopt to TCP_KEEPINTVL/IDLE with integer value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request #3755: net/icmp: icmp bug fix and enhancement
anchao opened a new pull request #3755: URL: https://github.com/apache/incubator-nuttx/pull/3755 ## Summary net/icmp: fix race condition in icmp recvmsg net/icmp: add nonblocking support net/icmp: consume the data length to avoid duplicate packet net/icmp: fix invalid condition comparison ## Impact ping/ping6 ## Testing ping/ping6 works as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #3754: wireless/bluetooth: decoupling bt_driver_s and bt_buf_s
anchao commented on pull request #3754: URL: https://github.com/apache/incubator-nuttx/pull/3754#issuecomment-845661728 ``` Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:309:2: error: Mixed case identifier found Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:318:2: error: Mixed case identifier found Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:329:2: error: Mixed case identifier found Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:338:2: error: Mixed case identifier found Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:347:2: error: Mixed case identifier found Error: Process completed with exit code 1. ``` Mixed case found by style check, ignore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #3543: feat(esp32c3): Support esp32c3 ble function
anchao commented on pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#issuecomment-845648227 Hi @all, https://github.com/apache/incubator-nuttx/pull/3754 : Here is decoupling implementation, please help to review further, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request #3754: wireless/bluetooth: decoupling bt_driver_s and bt_buf_s
anchao opened a new pull request #3754: URL: https://github.com/apache/incubator-nuttx/pull/3754 ## Summary wireless/bluetooth: decoupling bt_driver_s and bt_buf_s serial/uart/h4: add bt h4 uart serial driver arch/sim: remove BT uart implement wirelss/bluetooth/bt_buf: add ISO buffer type Feature request by : https://github.com/apache/incubator-nuttx/pull/3543 ## Impact bluetooth uart driver module ## Testing bluetooth uart h4 devcie with 3rd stack running on userspace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] tanushreebaindur edited a comment on issue #246: Illegal calls to romdisk_register()
tanushreebaindur edited a comment on issue #246: URL: https://github.com/apache/incubator-nuttx-apps/issues/246#issuecomment-845635224 Hi @a-lunev , The error is because CONFIG_MMCSD and CONFIG_MMCSD_SPI are not defined. mmcsd_spislotinitialize() is enabled when CONFIG_MMCSD and CONFIG_MMCSD_SPI are defined I do not have the board and I'm currently using the simulator to make the configuration change. Can you please make the following change to the configuration and let me know if it works? If it does work, can you then submit a PR for the corrected eagle100:nxflat defconfig To enable CONFIG_MMCSD: make menuconfig --> Device Drivers --> MMC/SD Driver Support To enable CONFIG_MMCSD_SPI: make menuconfig --> Device Drivers --> SPI Driver Support This is the resulting defconfig after enabling CONFIG_MMCSD and CONFIG_MMCSD_SPI: # # This file is autogenerated: PLEASE DO NOT EDIT IT. # # You can use "make menuconfig" to make any modifications to the installed .config file. # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="eagle100" CONFIG_ARCH_BOARD_EAGLE100=y CONFIG_ARCH_CHIP="tiva" CONFIG_ARCH_CHIP_LM3S6918=y CONFIG_ARCH_CHIP_LM3S=y CONFIG_ARCH_CHIP_LM=y CONFIG_ARCH_STACKDUMP=y CONFIG_BOARDCTL_ROMDISK=y CONFIG_BOARD_LOOPSPERMSEC=4531 CONFIG_CONSOLE_SYSLOG=y CONFIG_DISABLE_ENVIRON=y CONFIG_EXAMPLES_NXFLAT=y CONFIG_FS_ROMFS=y CONFIG_LIB_BOARDCTL=y CONFIG_MAX_TASKS=16 CONFIG_MMCSD=y CONFIG_NXFLAT=y CONFIG_PREALLOC_TIMERS=4 CONFIG_RAM_SIZE=65536 CONFIG_RAM_START=0x2000 CONFIG_RAW_BINARY=y CONFIG_RR_INTERVAL=200 CONFIG_SDCLONE_DISABLE=y CONFIG_SPI=y CONFIG_START_DAY=6 CONFIG_START_MONTH=5 CONFIG_START_YEAR=2009 CONFIG_SYMTAB_ORDEREDBYNAME=y CONFIG_TASK_NAME_SIZE=0 CONFIG_TIVA_GPIOA_IRQS=y CONFIG_TIVA_GPIOB_IRQS=y CONFIG_TIVA_GPIOC_IRQS=y CONFIG_TIVA_GPIOD_IRQS=y CONFIG_TIVA_GPIOE_IRQS=y CONFIG_TIVA_GPIOF_IRQS=y CONFIG_TIVA_GPIOG_IRQS=y CONFIG_TIVA_SSI0=y CONFIG_TIVA_UART0=y CONFIG_UART0_SERIAL_CONSOLE=y CONFIG_USERMAIN_STACKSIZE=4096 CONFIG_USER_ENTRYPOINT="nxflat_main" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] tanushreebaindur commented on issue #246: Illegal calls to romdisk_register()
tanushreebaindur commented on issue #246: URL: https://github.com/apache/incubator-nuttx-apps/issues/246#issuecomment-845635224 Hi @a-lunev , The error is because CONFIG_MMCSD and CONFIG_MMCSD_SPI are not defined. mmcsd_spislotinitialize() is enabled when CONFIG_MMCSD and CONFIG_MMCSD_SPI are defined I do not have the board and I'm currently using the simulator to make the configuration change. Can you please make the following change to the configuration and let me know if it works? I can then submit a PR for the corrected eagle100:nxflat defconfig To enable CONFIG_MMCSD: make menuconfig --> Device Drivers --> MMC/SD Driver Support To enable CONFIG_MMCSD_SPI: make menuconfig --> Device Drivers --> SPI Driver Support This is the resulting defconfig after enabling CONFIG_MMCSD and CONFIG_MMCSD_SPI: # # This file is autogenerated: PLEASE DO NOT EDIT IT. # # You can use "make menuconfig" to make any modifications to the installed .config file. # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="eagle100" CONFIG_ARCH_BOARD_EAGLE100=y CONFIG_ARCH_CHIP="tiva" CONFIG_ARCH_CHIP_LM3S6918=y CONFIG_ARCH_CHIP_LM3S=y CONFIG_ARCH_CHIP_LM=y CONFIG_ARCH_STACKDUMP=y CONFIG_BOARDCTL_ROMDISK=y CONFIG_BOARD_LOOPSPERMSEC=4531 CONFIG_CONSOLE_SYSLOG=y CONFIG_DISABLE_ENVIRON=y CONFIG_EXAMPLES_NXFLAT=y CONFIG_FS_ROMFS=y CONFIG_LIB_BOARDCTL=y CONFIG_MAX_TASKS=16 CONFIG_MMCSD=y CONFIG_NXFLAT=y CONFIG_PREALLOC_TIMERS=4 CONFIG_RAM_SIZE=65536 CONFIG_RAM_START=0x2000 CONFIG_RAW_BINARY=y CONFIG_RR_INTERVAL=200 CONFIG_SDCLONE_DISABLE=y CONFIG_SPI=y CONFIG_START_DAY=6 CONFIG_START_MONTH=5 CONFIG_START_YEAR=2009 CONFIG_SYMTAB_ORDEREDBYNAME=y CONFIG_TASK_NAME_SIZE=0 CONFIG_TIVA_GPIOA_IRQS=y CONFIG_TIVA_GPIOB_IRQS=y CONFIG_TIVA_GPIOC_IRQS=y CONFIG_TIVA_GPIOD_IRQS=y CONFIG_TIVA_GPIOE_IRQS=y CONFIG_TIVA_GPIOF_IRQS=y CONFIG_TIVA_GPIOG_IRQS=y CONFIG_TIVA_SSI0=y CONFIG_TIVA_UART0=y CONFIG_UART0_SERIAL_CONSOLE=y CONFIG_USERMAIN_STACKSIZE=4096 CONFIG_USER_ENTRYPOINT="nxflat_main" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: 1a68dd3405cfbf4f87c58d8ba31efe69f551d462 docs: e4fd99682e4c061dcdc4db7751d1a12c19d96eba
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 28ab083 Publishing web: 1a68dd3405cfbf4f87c58d8ba31efe69f551d462 docs: e4fd99682e4c061dcdc4db7751d1a12c19d96eba 28ab083 is described below commit 28ab0835a09d506075550802def66565831398ab Author: Brennan AuthorDate: Fri May 21 01:46:51 2021 + Publishing web: 1a68dd3405cfbf4f87c58d8ba31efe69f551d462 docs: e4fd99682e4c061dcdc4db7751d1a12c19d96eba --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index c472bb8..be8c4d9 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 20 May 21 at 00:38 +Last Updated: 21 May 21 at 01:44 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 12a99ef..2e6f445 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -211,7 +211,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 20 May 21 at 00:38 +Last Updated: 21 May 21 at 01:44 Table of Contents diff --git a/content/docs/latest/index.html b/content/docs/latest/index.html index d9863ca..f49eb08 100644 --- a/content/docs/latest/index.html +++ b/content/docs/latest/index.html @@ -212,7 +212,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 20 May 21 at 00:39 +Last Updated: 21 May 21 at 01:45 Table of Contents diff --git a/content/feed.xml b/content/feed.xml index b2466db..36ef95e 100644 --- a/content/feed.xml +++ b/content/feed.xml @@ -5,8 +5,8 @@ / -Thu, 20 May 2021 00:40:36 + -Thu, 20 May 2021 00:40:36 + +Fri, 21 May 2021 01:46:49 + +Fri, 21 May 2021 01:46:49 + Jekyll v3.8.5
[GitHub] [incubator-nuttx-apps] a-lunev commented on issue #246: Illegal calls to romdisk_register()
a-lunev commented on issue #246: URL: https://github.com/apache/incubator-nuttx-apps/issues/246#issuecomment-845569082 Hi @tanushreebaindur, I've tested commit 2217d2f0d34c67e30ac32f089410308a6ca6a061. Now the build fails with the following error: ``` ../nuttx/arch/arm/src/board/libboard.a(lm_appinit.o): In function `board_app_initialize': lm_appinit.c:(.text+0x46): undefined reference to `mmcsd_spislotinitialize' make[1]: *** [Makefile:156: nuttx] Error 1 ``` Steps to reproduce are the same as I previously wrote. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3704: Migrate build system to CMake
v01d commented on pull request #3704: URL: https://github.com/apache/incubator-nuttx/pull/3704#issuecomment-845522871 Sure! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3704: Migrate build system to CMake
btashton commented on pull request #3704: URL: https://github.com/apache/incubator-nuttx/pull/3704#issuecomment-845516625 Sorry @v01d I have been on-call this week which has not left me with much time/focus to look, but I will set some time aside this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev opened a new pull request #3753: libelf: fix "nsh: nsh_session: readline failed: 13" error
a-lunev opened a new pull request #3753: URL: https://github.com/apache/incubator-nuttx/pull/3753 Resolves issue #3751 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 opened a new pull request #3752: Pr inttypes stm32fx
davids5 opened a new pull request #3752: URL: https://github.com/apache/incubator-nuttx/pull/3752 ## Summary Fixes build for stm32f7 and stm32h7 i2c driver. ## Impact Fixes warning ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3704: Migrate build system to CMake
v01d commented on pull request #3704: URL: https://github.com/apache/incubator-nuttx/pull/3704#issuecomment-845378978 I managed to have all sim configs building on Linux (although I haven't yet tried to run nuttx in each case since I'm not entirely sure what to run). I will confirm this once CI comes back alive. The issues with macOS persist though. @btashton by any chance did you get to try it? @yamt you're on macos, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo commented on issue #3751: URL: https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845370322 > I tried your patch (loadinfo->filfd instead of loadinfo->fildfd). Yes, it resolves the issue. Can you submit a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
a-lunev commented on issue #3751: URL: https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845366460 Hi @patacongo, Thank you for your investigation. I tried your patch (loadinfo->filfd instead of loadinfo->fildfd). Yes, it resolves the issue. The corrected patch: ``` diff --git a/binfmt/libelf/libelf_init.c b/binfmt/libelf/libelf_init.c index 6658aa0b62..f2da035e41 100644 --- a/binfmt/libelf/libelf_init.c +++ b/binfmt/libelf/libelf_init.c @@ -134,6 +134,7 @@ int elf_init(FAR const char *filename, FAR struct elf_loadinfo_s *loadinfo) /* Clear the load info structure */ memset(loadinfo, 0, sizeof(struct elf_loadinfo_s)); + loadinfo->filfd = -1; /* Get the length of the file. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo commented on issue #3751: URL: https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845354254 Could you try this: diff --git a/binfmt/libelf/libelf_init.c b/binfmt/libelf/libelf_init.c index 6658aa0b62..317c74bc95 100644 --- a/binfmt/libelf/libelf_init.c +++ b/binfmt/libelf/libelf_init.c @@ -134,6 +134,7 @@ int elf_init(FAR const char *filename, FAR struct elf_loadinfo_s *loadinfo) /* Clear the load info structure */ memset(loadinfo, 0, sizeof(struct elf_loadinfo_s)); + loadinfo->fildfd = -1; /* Get the length of the file. */ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo edited a comment on issue #3751:
URL:
https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845343585
>
[468e08c](https://github.com/apache/incubator-nuttx/commit/468e08c1b4ff1441cf898623782869c7daf1c947)
is the first bad commit
>
[e5f1069](https://github.com/apache/incubator-nuttx/commit/e5f10696541dcbd53337b90f53538a48d073b4bc)
is the last good commit
When I first looked, 468e08c seemed like an unlikely cause of the problem.
That commit simply changes some error handling if the ELF load fails. The ELF
loader simply calls `elf_uninit()` in the event of a failure:
65 int elf_uninit(struct elf_loadinfo_s *loadinfo)
66 {
67 /* Free all working buffers */
68
69 elf_freebuffers(loadinfo);
70
71 /* Close the ELF file */
72
73 if (loadinfo->filfd >= 0)
74 {
75 nx_close(loadinfo->filfd);
76 }
77
78 return OK;
79 }
You see a failure that is attributed to readline() which seems unrelated:
79 #define EACCES 13
80 #define EACCES_STR "Permission denied"
The error is reported, apparently, by logic in
`apps/nshlib/nsh_stdsession.c` if a call to `readline()` returns EOF.
`readline()` ultimately calls `read()` on stdin (file descriptor 0). `EACCES`
is returned from `read()` if the file is not opened for reading:
71 /* Was this file opened for read access? */
72
73 if ((filep->f_oflags & O_RDOK) == 0)
74 {
75 /* No.. File is not read-able */
76
77 ret = -EACCES;
78 }
79
So now I think I see how this commit can cause this error to be seen:
1. When ELF support is enabled, NSH will always first attempt to a program
with that command name at the PATH directory. For example, `nsh> ls` will
attempt to run at `/bin/ls`. This is done so that we can replace or override
any of NHS's standard commands.
2. In this case it will fail to run the program and will fail silently. It
will call `elf_unit()` which will close the file at descriptor
`loadinfo->filfd`. But that file descriptor has not been initialized and is
still at its initial state; of zero:
elf_init():
136 memset(loadinfo, 0, sizeof(struct elf_loadinfo_s));
3. So `stdin` will be closed (via nx_close -> file_close).
4. After this fails, then readline() is called which will attempt to
`read()` from `stdin`. But `read()` will fail will errno `EACCES` because stdin
is no open for writing.
If the above analysis is correct, this is a very serious bug! One fix might
be to simply initialize `loadinfo->filfd` to -1 instead of zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo edited a comment on issue #3751:
URL:
https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845343585
>
[468e08c](https://github.com/apache/incubator-nuttx/commit/468e08c1b4ff1441cf898623782869c7daf1c947)
is the first bad commit
>
[e5f1069](https://github.com/apache/incubator-nuttx/commit/e5f10696541dcbd53337b90f53538a48d073b4bc)
is the last good commit
When I first looked, 468e08c seemed like an unlikely cause of the problem.
That commit simply changes some error handling if the ELF load fails. The ELF
loader simply calls `elf_uninit()` in the event of a failure:
65 int elf_uninit(struct elf_loadinfo_s *loadinfo)
66 {
67 /* Free all working buffers */
68
69 elf_freebuffers(loadinfo);
70
71 /* Close the ELF file */
72
73 if (loadinfo->filfd >= 0)
74 {
75 nx_close(loadinfo->filfd);
76 }
77
78 return OK;
79 }
You see a failure that is attributed to readline() which seems unrelated:
79 #define EACCES 13
80 #define EACCES_STR "Permission denied"
The error is reported, apparently, by logic in
`apps/nshlib/nsh_stdsession.c` if a call to `readline()` returns EOF.
`readline()` ultimately calls `read()` on stdin (file descriptor 0). `EACCES`
is returned from `read()` if the file is not opened for reading:
71 /* Was this file opened for read access? */
72
73 if ((filep->f_oflags & O_RDOK) == 0)
74 {
75 /* No.. File is not read-able */
76
77 ret = -EACCES;
78 }
79
So now I think I see how this commit can cause this error to be seen:
1. When ELF support is enabled, NSH will always first attempt to a program
with that command name at the PATH directory. For example, `nsh> ls` will
attempt to run at `/bin/ls`. This is done so that we can replace or override
any of NHS's standard commands.
2. In this case it will fail to run the program and will fail silently. It
will call `elf_unit()` which will close the file at descriptor
`loadinfo->filfd`. But that file descriptor has not been initialized and is
still at its initial state; of zero:
elf_init():
136 memset(loadinfo, 0, sizeof(struct elf_loadinfo_s));
3. So `stdin` will be closed (via nx_close -> file_close).
4. After this fails, then readline() is called which will attempt to
`read()` from `stdin`. But `read()` will fail will errno `EACCES` because stdin
is no open for writing.
One fix might be to simply initialize `loadinfo->filfd` to -1 instead of
zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo edited a comment on issue #3751:
URL:
https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845343585
>
[468e08c](https://github.com/apache/incubator-nuttx/commit/468e08c1b4ff1441cf898623782869c7daf1c947)
is the first bad commit
>
[e5f1069](https://github.com/apache/incubator-nuttx/commit/e5f10696541dcbd53337b90f53538a48d073b4bc)
is the last good commit
When I first looked, 468e08c seemed like an unlikely cause of the problem.
That commit simply changes some error handling if the ELF load fails. The ELF
loader simply calls `elf_uninit()` in the event of a failure:
65 int elf_uninit(struct elf_loadinfo_s *loadinfo)
66 {
67 /* Free all working buffers */
68
69 elf_freebuffers(loadinfo);
70
71 /* Close the ELF file */
72
73 if (loadinfo->filfd >= 0)
74 {
75 nx_close(loadinfo->filfd);
76 }
77
78 return OK;
79 }
You see a failure that is attributed to readline() which seems unrelated:
79 #define EACCES 13
80 #define EACCES_STR "Permission denied"
The error is reported, apparently, by logic in
`apps/nshlib/nsh_stdsession.c` if a call to `readline()` returns EOF.
`readline()` ultimately calls `read()` on stdin (file descriptor 0). `EACCES`
is returned from `read()` if the file is not opened for reading:
71 /* Was this file opened for read access? */
72
73 if ((filep->f_oflags & O_RDOK) == 0)
74 {
75 /* No.. File is not read-able */
76
77 ret = -EACCES;
78 }
79
So now I think I see how this commit can cause this error to be seen:
1. When ELF support is enabled, NSH will always first attempt to a program
with that command name at the PATH directory. For example, `nsh> ls` will
attempt to run at `/bin/ls`. This is done so that we can replace or override
any of NHS's standard commands.
2. In this case it will fail to run the program and will fail silently. It
will call `elf_unit()` which will close the file at descriptor
`loadinfo->filfd`. But that file descriptor has not been initialized and is
still at its initial state; of zero:
elf_init():
136 memset(loadinfo, 0, sizeof(struct elf_loadinfo_s));
3. So `stdin` will be closed (via close -> nx_close -> file_close).
4. After this fails, then readline() is called which will attempt to
`read()` from `stdin`. But `read()` will fail will errno `EACCES` because stdin
is no open for writing.
One fix might be to simply initialize `loadinfo->filfd` to -1 instead of
zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo edited a comment on issue #3751:
URL:
https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845343585
>
[468e08c](https://github.com/apache/incubator-nuttx/commit/468e08c1b4ff1441cf898623782869c7daf1c947)
is the first bad commit
>
[e5f1069](https://github.com/apache/incubator-nuttx/commit/e5f10696541dcbd53337b90f53538a48d073b4bc)
is the last good commit
When I first looked, 468e08c seemed like an unlikely cause of the problem.
That commit simply changes some error handling if the ELF load fails. The ELF
loader simply calls `elf_uninit()` in the event of a failure:
65 int elf_uninit(struct elf_loadinfo_s *loadinfo)
66 {
67 /* Free all working buffers */
68
69 elf_freebuffers(loadinfo);
70
71 /* Close the ELF file */
72
73 if (loadinfo->filfd >= 0)
74 {
75 nx_close(loadinfo->filfd);
76 }
77
78 return OK;
79 }
You see a failure that is attributed to readline() which seems unrelated:
79 #define EACCES 13
80 #define EACCES_STR "Permission denied"
The error is reported, apparently, by logic in
`apps/nshlib/nsh_stdsession.c` if a call to `readline()` returns EOF.
`readline()` ultimately calls `read()` on stdin (file descriptor 0). `EACCES`
is returned from `read()` if the file is not opened for reading:
71 /* Was this file opened for read access? */
72
73 if ((filep->f_oflags & O_RDOK) == 0)
74 {
75 /* No.. File is not read-able */
76
77 ret = -EACCES;
78 }
79
So now I think I see how this commit can cause this error to be seen:
1. When ELF support is enabled, NSH will always first attempt to a program
with that command name at the PATH directory. For example, `nsh> ls` will
attempt to run at `/bin/ls`. This is done so that we can replace or override
any of NHS's standard commands.
2. In this case it will fail to run the program and will fail silently. It
will call `elf_unit()` which will close the file at descriptor
`loadinfo->filfd`. But that file descriptor has not been initialized and is
still at its initial state; of zero:
elf_init():
136 memset(loadinfo, 0, sizeof(struct elf_loadinfo_s));
3. So `stdin` will be closed (via close -> nx_close -> file_close).
4. After this fails, then readline() is called which will attempt to
`read()` from `stdin`. But `read()` will fail will errno `EACCES` because stdin
is no open for writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
patacongo commented on issue #3751:
URL:
https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845343585
>
[468e08c](https://github.com/apache/incubator-nuttx/commit/468e08c1b4ff1441cf898623782869c7daf1c947)
is the first bad commit
>
[e5f1069](https://github.com/apache/incubator-nuttx/commit/e5f10696541dcbd53337b90f53538a48d073b4bc)
is the last good commit
When I first looked, 468e08c seemed like an unlikely cause of the problem.
That commit simply changes some error handling if the ELF load fails. The ELF
loader simply calls `elf_uninit()` in the event of a failure:
65 int elf_uninit(struct elf_loadinfo_s *loadinfo)
66 {
67 /* Free all working buffers */
68
69 elf_freebuffers(loadinfo);
70
71 /* Close the ELF file */
72
73 if (loadinfo->filfd >= 0)
74 {
75 nx_close(loadinfo->filfd);
76 }
77
78 return OK;
79 }
You see a failure that is attributed to readline() which seems unrelated:
79 #define EACCES 13
80 #define EACCES_STR "Permission denied"
The error is reported, apparently, by logic in
`apps/nshlib/nsh_stdsession.c` if a call to `readline()` returns EOF.
`readline()` ultimately calls `read()` on stdin (file descriptor 0). `EACCES`
is returned from `read()` if the file is not opened for reading:
71 /* Was this file opened for read access? */
72
73 if ((filep->f_oflags & O_RDOK) == 0)
74 {
75 /* No.. File is not read-able */
76
77 ret = -EACCES;
78 }
79
So now I think I see how this commit can cause this error to be seen:
1. When ELF support is enabled, NSH will always first attempt to a program
with that command name at the PATH directory. For example, `nsh> ls` will
attempt to run at `/bin/ls`
2. In this case it will fail to run the problem and will fail silently. It
will call `elf_unit()` which will close the file at descriptor
`loadinfo->filfd`. But that file descriptor has not been initialized and is
still at its initial state; of zero:
elf_init():
136 memset(loadinfo, 0, sizeof(struct elf_loadinfo_s));
3. So `stdin` will be closed (via close -> nx_close -> file_close).
4. After this fails, then readline() is called which will attempt to
`read()` from `stdin`. But `read()` will fail will errno `EACCES` because stdin
is no open for writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
a-lunev commented on issue #3751: URL: https://github.com/apache/incubator-nuttx/issues/3751#issuecomment-845246680 git bisecting nuttx: $ git checkout e4fd99682e4c061dcdc4db7751d1a12c19d96eba $ git bisect start $ git bisect bad $ git bisect good 705c64e5ff50df4f7ea202ad870e7106243c good: nuttx: f16a0a7380d64a01dc9cf4839f5b2d5e611f1f99, apps: f2100104663704be498179f06bd78adcbe62a809 good: nuttx: d1e06b4c0919e49f9589a295f66dbd50db8961a3, apps: f2100104663704be498179f06bd78adcbe62a809 good: nuttx: 7fb73dba1c2175d720170f21094194130819ff81, apps: f2100104663704be498179f06bd78adcbe62a809 good: nuttx: 649e680f75b3a247be98e8624e03b3c7fe0ad600, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: 09a0ed111c0c193a57b2a538e23c2b6a6e9cdf26, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: 1856a85b2850a49065e8869ccc952fb98dd02c34, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: db517cc2293ea53bebd9730d20ed35db46c08b3b, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: 90a4e8d718c269ac110289ea0fac368abe78ef54, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: bf733f72132d387206c3ffe21fb6b2a085dd5506, apps: f2100104663704be498179f06bd78adcbe62a809 bad: nuttx: 468e08c1b4ff1441cf898623782869c7daf1c947, apps: f2100104663704be498179f06bd78adcbe62a809 good: nuttx: e5f10696541dcbd53337b90f53538a48d073b4bc, apps: f2100104663704be498179f06bd78adcbe62a809 468e08c1b4ff1441cf898623782869c7daf1c947 is the first bad commit e5f10696541dcbd53337b90f53538a48d073b4bc is the last good commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev opened a new issue #3751: nucleo-h743zi:elf config got broken (nsh: nsh_session: readline failed: 13)
a-lunev opened a new issue #3751: URL: https://github.com/apache/incubator-nuttx/issues/3751 Steps to reproduce: ``` $ mkdir TEST_ROOT $ git clone https://github.com/apache/incubator-nuttx.git TEST_ROOT/nuttx $ git clone https://github.com/apache/incubator-nuttx-apps TEST_ROOT/apps $ cd TEST_ROOT/nuttx $ ./tools/configure.sh -l nucleo-h743zi:elf $ make CROSSDEV=arm-none-eabi- $ sudo openocd -f interface/stlink.cfg \ -f board/st_nucleo_h743zi.cfg \ -c "init" \ -c "reset init" \ -c "flash probe 0" \ -c "flash info 0" \ -c "flash write_image erase nuttx.bin 0x0800" \ -c "reset run" -c "shutdown" ``` ``` nsh> ls nsh> nsh: nsh_session: readline failed: 13 ``` The last known working pair was: nuttx: 705c64e5ff50df4f7ea202ad870e7106243c (13-Dec-2020) apps: f2100104663704be498179f06bd78adcbe62a809 (17-Dec-2020) Thus the issue has appeared somewhere between 13-Dec-2020 and now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3747: mm:initialize ensure alignment.
xiaoxiang781216 commented on pull request #3747: URL: https://github.com/apache/incubator-nuttx/pull/3747#issuecomment-845166533 I agree to improve the process to get more review from more people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3747: mm:initialize ensure alignment.
antmerlino commented on pull request #3747: URL: https://github.com/apache/incubator-nuttx/pull/3747#issuecomment-845134457 > Yes, we need more test to avoid the regression. But, please give some test plan or progress in PR, so we can coordinate with each other. I think we need to give people more time. Everyone is dealing with their own sets of problems on a day to day basis. 3 days is an eternity when it's your work you're trying to push through - but it's not so long when you've got your own deadlines and then additional PRs come in that need thorough testing/review. To @davids5 point, this is why it is probably better practice to not allow individuals from the same organization to approve PRs. Both will be incentivized to get it through. Much sophisticated engineering is done and cross-checked using red/blue teams. This mentality helps be critical of the others work. The same philosophy should be being applied here. I really don't want to create processes that are burdensome and slow things down. However, I do think it's important that we adjust our process to avoid regressions like this and improve the security/reliability of the OS. What I would propose is this: 1. Change 'Impact' in the PR template to be 'What boards will be affected by this change?' To this, common answers will be: - All stm32h7 boards - All boards - Any board using XX driver The reason for this question is to be able to quickly find PRs that will effect everyone. If the PR states it effects all boards, as this change would, we can add a tag to the PR. Those PRs should get a more thorough review. 2. Any PR that gets the tag, or is otherwise labeled a critical change should be reviewed by more than 1 person. Perhaps we say 2 is enough, or maybe it should be 3. In either case we should setup Github to require 2-3 accepted reviews before allowing a merge. 3. In general, I think we should set a policy that individuals from the same organization cannot approve their own PRs. If this seems like a reasonable proposal, we can move the conversation to the dev list. Let me know what you guys think. -Anthony -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] f4grx commented on issue #2206: Out-of-tree custom board example missing from documentation
f4grx commented on issue #2206: URL: https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-845128005 OK so the solution to this was given by Abdelatif Guettouche on the mailing list ``` I just copied the nucleo-fe446re board without the common directory. Here are the steps I took: Add the correct custom board CONFIGs to nsh/defconfig (and remove some of the old ones) Rename Make.defs to Makefile Add include $(TOPDIR)/boards/Board.mk to the end of the file. ./tools/configure.sh ../boards/nucleo-f446re/configs/nsh make Builds fine. ``` The trick about RENAMING a make.defs to Makefile is probably not normal. This process has to be documented somewhere in the official doc under "how to make an external board config" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] f4grx edited a comment on issue #2206: Out-of-tree custom board example missing from documentation
f4grx edited a comment on issue #2206: URL: https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-845104620 ``` make[1]: Entering directory '/home/slo/nut/nuttx/fs' make[1]: 'libfs.a' is up to date. make[1]: Leaving directory '/home/slo/nut/nuttx/fs' make[1]: Entering directory '/home/slo/nut/nuttx/binfmt' make[1]: 'libbinfmt.a' is up to date. make[1]: Leaving directory '/home/slo/nut/nuttx/binfmt' make[1]: Entering directory '/home/slo/nut/nuttx/arch/arm/src' make[2]: Entering directory '/home/slo/nut/my_own_nucleo/src' echo "damn you libboard" damn you libboard make[2]: Leaving directory '/home/slo/nut/my_own_nucleo/src' LD: nuttx arm-none-eabi-ld: cannot find -lboard make[1]: *** [Makefile:156: nuttx] Error 1 make[1]: Leaving directory '/home/slo/nut/nuttx/arch/arm/src' make: *** [tools/Makefile.unix:422: nuttx] Error 2 $ cat /home/slo/nut/my_own_nucleo/src/Makefile context: echo "damn you context" libboard.a: echo "damn you libboard" ``` The issue seems to be a missing Makefile in the src subdirectory of the custom board. If I add one with a small echo comment in it, I see it displayed. the makefile is probably optional for built-in boards but it is required for custom boards. So WHAT makefile has to be there and with what rules? edit: The makefile in stm32/common/src does not work when copied in my_board/src -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] f4grx edited a comment on issue #2206: Out-of-tree custom board example missing from documentation
f4grx edited a comment on issue #2206: URL: https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-845104620 ``` make[1]: Entering directory '/home/slo/nut/nuttx/fs' make[1]: 'libfs.a' is up to date. make[1]: Leaving directory '/home/slo/nut/nuttx/fs' make[1]: Entering directory '/home/slo/nut/nuttx/binfmt' make[1]: 'libbinfmt.a' is up to date. make[1]: Leaving directory '/home/slo/nut/nuttx/binfmt' make[1]: Entering directory '/home/slo/nut/nuttx/arch/arm/src' make[2]: Entering directory '/home/slo/nut/my_own_nucleo/src' echo "damn you libboard" damn you libboard make[2]: Leaving directory '/home/slo/nut/my_own_nucleo/src' LD: nuttx arm-none-eabi-ld: cannot find -lboard make[1]: *** [Makefile:156: nuttx] Error 1 make[1]: Leaving directory '/home/slo/nut/nuttx/arch/arm/src' make: *** [tools/Makefile.unix:422: nuttx] Error 2 $ cat /home/slo/nut/my_own_nucleo/src/Makefile context: echo "damn you context" libboard.a: echo "damn you libboard" ``` The issue seems to be a missing Makefile in the src subdirectory of the custom board. If I add one with a small echo comment in it, I see it displayed. the makefile is probably optional for built-in boards but it is required for custom boards. So WHAT makefile has to be there and with what rules? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] f4grx commented on issue #2206: Out-of-tree custom board example missing from documentation
f4grx commented on issue #2206: URL: https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-845104620 The issue seems to be a missing Makefile in the src subdirectory of the custom board. If I add one with a small echo comment in it, I see it displayed. the makefile is probably optional for built-in boards but it is required for custom boards. So WHAT makefile has to be there and with what rules? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] f4grx commented on issue #2206: Out-of-tree custom board example missing from documentation
f4grx commented on issue #2206: URL: https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-845099520 Hello, This is still not working OK. copying a board config to a custom dir. using ./configure.sh builds the original built-in board changing the config file to point into the custom board fails to build libboard.a The old mechanism where you could just ln your custom board in the nuttx tree worked better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3747: mm:initialize ensure alignment.
xiaoxiang781216 commented on pull request #3747: URL: https://github.com/apache/incubator-nuttx/pull/3747#issuecomment-845097148 > > I think @davids5's concern is addressed before merging: both background info and ASAN heap manager is provided in PR. > > ## Testing > ## Pass the build without error. > No. Build testing an architectural change of this nature was NOT addressing my concerns. > The change pass our internal test. The real problem is that your CONFIG_IDLE_STACKSIZE is too odd, but we don't have the similar config to reproduce this issue. > Yet you merged it. > If you look at the timeline: https://github.com/apache/incubator-nuttx/pull/3086 1. PR is created on March 17 2. You give the comment for more info, we update PR immediately 3. There are more dissusion and clarification on March 18 4. I ask people for more comment on March 19 5. Nobody give the nagtive feedback or request more time to test 6. I finally merge PR on March 20 > No one diversity tested it or had a chance to commented on the potential security issue this change could be used to exploit. > > The diversity of configuration used to test is what finds this type of thing. Testing on Real HW finds this sort of thing. > > I think this raises a bigger issue. The `authored by`, `reviewed by` and `committed by` should NOT be that same organization. That would be akin to merging your own PR. There needs to be real testing and approval on changes greater that a emergency build fix that effect the system. Yes, we need more test to avoid the regression. But, please give some test plan or progress in PR, so we can coordinate with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #3750: riscv/esp32c3: Support SPI Flash encryption read/write
donghengqaz opened a new pull request #3750: URL: https://github.com/apache/incubator-nuttx/pull/3750 ## Summary Support SPI Flash encryption read/write. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #3747: mm:initialize ensure alignment.
davids5 edited a comment on pull request #3747: URL: https://github.com/apache/incubator-nuttx/pull/3747#issuecomment-844977465 > I think @davids5's concern is addressed before merging: both background info and ASAN heap manager is provided in PR. ## Testing Pass the build without error. --- No. Build testing an architectural change of this nature was NOT addressing my concerns. Yet you merged it. No one diversity tested it or had a chance to commented on the potential security issue this change could be used to exploit. The diversity of configuration used to test is what finds this type of thing. Testing on Real HW finds this sort of thing. I think this raises a bigger issue. The `authored by`, `reviewed by` and `committed by` should NOT be that same organization. That would be akin to merging your own PR. There needs to be real testing and approval on changes greater that a emergency build fix that effect the system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3747: mm:initialize ensure alignment.
davids5 commented on pull request #3747: URL: https://github.com/apache/incubator-nuttx/pull/3747#issuecomment-844977465 > I think @davids5's concern is addressed before merging: both background info and ASAN heap manager is provided in PR. ## Testing Pass the build without error. --- No. Build testing an architectural change of this nature was NOT addressing my concerns. Yet you merged it. No one diversity tested it or had a chance to commented on the potential security issue this change could be used to exploit. The diversity of configuration used to test is what finds this type of thing. Testing on Real HW finds this sort of thing. I think this raises a bigger issue. The `authored by`, 'reviewed by` and `committed by` should NOT be that same organization. That would be akin to merging your own PR. There needs to be real testing and approval on changes greater that a emergency build fix that effect the system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #725: nimble: Update version to cd8ab38c3da91b71dd428979153a408f38d3b02e
xiaoxiang781216 edited a comment on pull request #725: URL: https://github.com/apache/incubator-nuttx-apps/pull/725#issuecomment-844975409 @v01d could you take a look why nuttx can't pass the compile with the latest mynewt-nimble? https://github.com/apache/incubator-nuttx-apps/pull/725/checks?check_run_id=2629009817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #725: nimble: Update version to cd8ab38c3da91b71dd428979153a408f38d3b02e
xiaoxiang781216 commented on pull request #725: URL: https://github.com/apache/incubator-nuttx-apps/pull/725#issuecomment-844975409 @v01d could you take a look why nuttx can't work with the latest mynewt-nimble? https://github.com/apache/incubator-nuttx-apps/pull/725/checks?check_run_id=2629009817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3749: RISC-V compilation fixes
xiaoxiang781216 merged pull request #3749: URL: https://github.com/apache/incubator-nuttx/pull/3749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 01/02: rv64gc/riscv_assert.c: Fix compilation without CONFIG_DEBUG_ALERT
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e79a45bb93df5adca7d35897558e99c0deeef8a2
Author: Jukka Laitinen
AuthorDate: Tue May 18 08:46:22 2021 +0300
rv64gc/riscv_assert.c: Fix compilation without CONFIG_DEBUG_ALERT
Signed-off-by: Jukka Laitinen
---
arch/risc-v/src/rv64gc/riscv_assert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/risc-v/src/rv64gc/riscv_assert.c
b/arch/risc-v/src/rv64gc/riscv_assert.c
index 6a99759..a643f96 100644
--- a/arch/risc-v/src/rv64gc/riscv_assert.c
+++ b/arch/risc-v/src/rv64gc/riscv_assert.c
@@ -336,7 +336,7 @@ static int assert_tracecallback(FAR struct usbtrace_s
*trace, FAR void *arg)
void up_assert(const char *filename, int lineno)
{
-#if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_DEBUG_ALERT)
+#if CONFIG_TASK_NAME_SIZE > 0
struct tcb_s *rtcb = running_task();
#endif
[incubator-nuttx] 02/02: rv64gc: use PRIx64 format for alert and assert
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e4fd99682e4c061dcdc4db7751d1a12c19d96eba
Author: Jukka Laitinen
AuthorDate: Tue May 18 08:46:58 2021 +0300
rv64gc: use PRIx64 format for alert and assert
This fixes compilation warnings caused by number formatting
Signed-off-by: Jukka Laitinen
---
arch/risc-v/src/rv64gc/riscv_assert.c | 50 +--
arch/risc-v/src/rv64gc/riscv_fault.c | 29 +---
2 files changed, 49 insertions(+), 30 deletions(-)
diff --git a/arch/risc-v/src/rv64gc/riscv_assert.c
b/arch/risc-v/src/rv64gc/riscv_assert.c
index a643f96..79c20a7 100644
--- a/arch/risc-v/src/rv64gc/riscv_assert.c
+++ b/arch/risc-v/src/rv64gc/riscv_assert.c
@@ -78,7 +78,9 @@ static void up_stackdump(uint64_t sp, uintptr_t stack_top)
for (stack = sp & ~0x1f; stack < stack_top; stack += 32)
{
uint32_t *ptr = (uint32_t *)stack;
- _alert("%08x: %08x %08x %08x %08x %08x %08x %08x %08x\n",
+ _alert("%08" PRIxPTR ": %08" PRIx32 " %08" PRIx32 " %08" PRIx32
+ " %08" PRIx32 " %08" PRIx32 " %08" PRIx32 " %08" PRIx32
+ " %08" PRIx32 "\n",
stack, ptr[0], ptr[1], ptr[2], ptr[3],
ptr[4], ptr[5], ptr[6], ptr[7]);
}
@@ -130,44 +132,52 @@ static inline void up_registerdump(void)
if (CURRENT_REGS)
{
- _alert("EPC:%016x \n",
+ _alert("EPC:%016" PRIx64 " \n",
CURRENT_REGS[REG_EPC]);
- _alert("A0:%016x A1:%016x A2:%016x A3:%016x \n",
+ _alert("A0:%016" PRIx64 " A1:%01" PRIx64 "6 A2:%016" PRIx64
+ " A3:%016" PRIx64 " \n",
CURRENT_REGS[REG_A0], CURRENT_REGS[REG_A1],
CURRENT_REGS[REG_A2], CURRENT_REGS[REG_A3]);
- _alert("A4:%016x A5:%016x A6:%016x A7:%016x \n",
+ _alert("A4:%016" PRIx64 " A5:%016" PRIx64 "A6:%016" PRIx64
+ " A7:%016" PRIx64 " \n",
CURRENT_REGS[REG_A4], CURRENT_REGS[REG_A5],
CURRENT_REGS[REG_A6], CURRENT_REGS[REG_A7]);
- _alert("T0:%016x T1:%016x T2:%016x T3:%016x \n",
+ _alert("T0:%016" PRIx64 " T1:%016" PRIx64 " T2:%016" PRIx64
+ " T3:%016" PRIx64 " \n",
CURRENT_REGS[REG_T0], CURRENT_REGS[REG_T1],
CURRENT_REGS[REG_T2], CURRENT_REGS[REG_T3]);
- _alert("T4:%016x T5:%016x T6:%016x \n",
+ _alert("T4:%016" PRIx64 " T5:%016" PRIx64 " T6:%016" PRIx64 " \n",
CURRENT_REGS[REG_T4], CURRENT_REGS[REG_T5],
CURRENT_REGS[REG_T6]);
- _alert("S0:%016x S1:%016x S2:%016x S3:%016x \n",
+ _alert("S0:%016" PRIx64 " S1:%016" PRIx64 " S2:%016" PRIx64
+ " S3:%016" PRIx64 " \n",
CURRENT_REGS[REG_S0], CURRENT_REGS[REG_S1],
CURRENT_REGS[REG_S2], CURRENT_REGS[REG_S3]);
- _alert("S4:%016x S5:%016x S6:%016x S7:%016x \n",
+ _alert("S4:%016" PRIx64 " S5:%016" PRIx64 " S6:%016" PRIx64
+ " S7:%016" PRIx64 " \n",
CURRENT_REGS[REG_S4], CURRENT_REGS[REG_S5],
CURRENT_REGS[REG_S6], CURRENT_REGS[REG_S7]);
- _alert("S8:%016x S9:%016x S10:%016x S11:%016x \n",
+ _alert("S8:%016" PRIx64 " S9:%016" PRIx64 " S10:%016" PRIx64
+ " S11:%016" PRIx64 " \n",
CURRENT_REGS[REG_S8], CURRENT_REGS[REG_S9],
CURRENT_REGS[REG_S10], CURRENT_REGS[REG_S11]);
#ifdef RISCV_SAVE_GP
- _alert("GP:%016x SP:%016x FP:%016x TP:%016x RA:%016x \n",
+ _alert("GP:%016" PRIx64 " SP:%016" PRIx64 " FP:%016" PRIx64
+ " TP:%016" PRIx64 " RA:%016" PRIx64 " \n",
CURRENT_REGS[REG_GP], CURRENT_REGS[REG_SP],
CURRENT_REGS[REG_FP], CURRENT_REGS[REG_TP],
CURRENT_REGS[REG_RA]);
#else
- _alert("SP:%016x FP:%016x TP:%016x RA:%016x \n",
+ _alert("SP:%016" PRIx64 " FP:%016" PRIx64 " TP:%016" PRIx64
+ " RA:%016" PRIx64 " \n",
CURRENT_REGS[REG_SP], CURRENT_REGS[REG_FP],
CURRENT_REGS[REG_TP], CURRENT_REGS[REG_RA]);
#endif
@@ -206,10 +216,10 @@ static void up_dumpstate(void)
/* Show interrupt stack info */
- _alert("sp: %016x\n", sp);
+ _alert("sp: %016" PRIx64 "\n", sp);
_alert("IRQ stack:\n");
- _alert(" base: %016x\n", istackbase);
- _alert(" size: %016x\n", istacksize);
+ _alert(" base: %016" PRIxPTR "\n", istackbase);
+ _alert(" size: %016" PRIxPTR "\n", istacksize);
/* Does the current stack pointer lie within the interrupt
* stack?
@@ -224,7 +234,7 @@ static void up_dumpstate(void)
/* Extract the user stack pointer */
sp = CURRENT_REGS[REG_SP];
- _alert("sp: %016x\n", sp);
+ _alert("sp: %016" PRIx64 "\n", sp);
}
else if (CURRENT_REGS)
{
@@ -235,12 +245,12 @@ static void up_dumpstate(void)
/* Show user stack info */
_alert("User
[incubator-nuttx] branch master updated (c9ccbb9 -> e4fd996)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9ccbb9 stm32h7_rcc.c: Fixes typo in comment new e79a45b rv64gc/riscv_assert.c: Fix compilation without CONFIG_DEBUG_ALERT new e4fd996 rv64gc: use PRIx64 format for alert and assert The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/risc-v/src/rv64gc/riscv_assert.c | 52 +-- arch/risc-v/src/rv64gc/riscv_fault.c | 29 --- 2 files changed, 50 insertions(+), 31 deletions(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #725: nimble: Update version to cd8ab38c3da91b71dd428979153a408f38d3b02e
xiaoxiang781216 opened a new pull request #725: URL: https://github.com/apache/incubator-nuttx-apps/pull/725 ## Summary which contain the following fix: commit cd8ab38c3da91b71dd428979153a408f38d3b02e Author: Xiang Xiao Date: Thu May 20 15:43:50 2021 +0800 nuttx: fix error: use of undeclared identifier 'ENOMEM' Signed-off-by: Xiang Xiao Change-Id: Idd832450d98306750ece8307ec7eef5c0c367a48 ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
davids5 commented on pull request #3730: URL: https://github.com/apache/incubator-nuttx/pull/3730#issuecomment-844952050 @btashton - Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jlaitine opened a new pull request #3749: RISC-V compilation fixes
jlaitine opened a new pull request #3749: URL: https://github.com/apache/incubator-nuttx/pull/3749 ## Summary These are simple fixes for compilation errors for rv64gc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #724: Arrow keys not working when in INSERT mode
xiaoxiang781216 merged pull request #724: URL: https://github.com/apache/incubator-nuttx-apps/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: Arrow keys not working when in INSERT mode
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 6b53a19 Arrow keys not working when in INSERT mode
6b53a19 is described below
commit 6b53a1959b0ff7ccdbe7f55ed78e13073cbbda6c
Author: jturnsek
AuthorDate: Thu May 20 08:08:30 2021 +0200
Arrow keys not working when in INSERT mode
---
system/vi/vi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/system/vi/vi.c b/system/vi/vi.c
index 4ba0eef..31d812f 100644
--- a/system/vi/vi.c
+++ b/system/vi/vi.c
@@ -5392,7 +5392,7 @@ static void vi_insert_mode(FAR struct vi_s *vi)
*/
vi->updatereqcol = true;
- if (!iscntrl(ch) || ch == '\t')
+ if (isprint(ch) || ch == '\t')
{
/* Insert the filtered character into the buffer */
@@ -5586,7 +5586,7 @@ static void vi_insert_mode(FAR struct vi_s *vi)
vi->curpos = vi_cursorright(vi, vi->curpos, 1);
if (vi->curpos >= vi->textsize)
{
- vi->curpos = vi->textsize - 1;
+ vi->curpos = vi->textsize;
}
}
break;
[GitHub] [incubator-nuttx] btashton merged pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
btashton merged pull request #3730: URL: https://github.com/apache/incubator-nuttx/pull/3730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 01/02: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 35553147ba2afdf240bfb744d1c58b7df4fc96e0
Author: Anthony Merlino
AuthorDate: Sat May 15 18:00:52 2021 -0400
stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
---
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c | 20 ++-
arch/arm/src/stm32h7/stm32h7x7xx_rcc.c | 36 --
2 files changed, 45 insertions(+), 11 deletions(-)
diff --git a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
index c9e0dd2..49f8d49 100644
--- a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
+++ b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
@@ -247,11 +247,17 @@ static inline void rcc_enableahb2(void)
regval = getreg32(STM32_RCC_AHB2ENR);
#ifdef CONFIG_STM32H7_SDMMC2
- /* SDMMC clock enable */
+ /* SDMMC2 clock enable */
regval |= RCC_AHB2ENR_SDMMC2EN;
#endif
+#ifdef CONFIG_STM32H7_RNG
+ /* Random number generator clock enable */
+
+ regval |= RCC_AHB2ENR_RNGEN;
+#endif
+
putreg32(regval, STM32_RCC_AHB2ENR); /* Enable peripherals */
}
@@ -473,6 +479,18 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
+#ifdef CONFIG_STM32H7_USART1
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART1EN;
+#endif
+
+#ifdef CONFIG_STM32H7_USART6
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART6EN;
+#endif
+
putreg32(regval, STM32_RCC_APB2ENR); /* Enable peripherals */
}
diff --git a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
index 13464ad..af179c5 100644
--- a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
+++ b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
@@ -246,7 +246,17 @@ static inline void rcc_enableahb2(void)
regval = getreg32(STM32_RCC_AHB2ENR);
- /* TODO: ... */
+#ifdef CONFIG_STM32H7_SDMMC2
+ /* SDMMC2 clock enable */
+
+ regval |= RCC_AHB2ENR_SDMMC2EN;
+#endif
+
+#ifdef CONFIG_STM32H7_RNG
+ /* Random number generator clock enable */
+
+ regval |= RCC_AHB2ENR_RNGEN;
+#endif
putreg32(regval, STM32_RCC_AHB2ENR); /* Enable peripherals */
}
@@ -469,12 +479,6 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
-#ifdef CONFIG_STM32H7_SDMMC2
- /* SDMMC2 clock enable */
-
- regval |= RCC_APB2ENR_SDMMC2EN;
-#endif
-
#ifdef CONFIG_STM32H7_USART1
/* USART1 clock enable */
@@ -826,8 +830,6 @@ void stm32_stdclockconfig(void)
regval |= STM32_PWR_CR3_LDOEN | STM32_PWR_CR3_LDOESCUEN;
putreg32(regval, STM32_PWR_CR3);
-#if 0
-
/* Set the voltage output scale */
regval = getreg32(STM32_PWR_D3CR);
@@ -839,6 +841,12 @@ void stm32_stdclockconfig(void)
{
}
+ /* See Reference manual Section 5.4.1, System supply startup */
+
+ while ((getreg32(STM32_PWR_CSR1) & PWR_CSR1_ACTVOSRDY) == 0)
+{
+}
+
/* Over-drive is needed if
* - Voltage output scale 1 mode is selected and SYSCLK frequency is
*over 400 MHz.
@@ -863,7 +871,6 @@ void stm32_stdclockconfig(void)
{
}
}
-#endif
/* Configure FLASH wait states */
@@ -952,6 +959,15 @@ void stm32_stdclockconfig(void)
putreg32(regval, STM32_RCC_D3CCIPR);
#endif
+ /* Configure FDCAN source clock */
+
+#if defined(STM32_RCC_D2CCIP1R_FDCANSEL)
+ regval = getreg32(STM32_RCC_D2CCIP1R);
+ regval &= ~RCC_D2CCIP1R_FDCANSEL_MASK;
+ regval |= STM32_RCC_D2CCIP1R_FDCANSEL;
+ putreg32(regval, STM32_RCC_D2CCIP1R);
+#endif
+
#if defined(CONFIG_STM32H7_IWDG) || defined(CONFIG_STM32H7_RTC_LSICLOCK)
/* Low speed internal clock source LSI */
[incubator-nuttx] branch master updated (6b5a4cb -> c9ccbb9)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6b5a4cb arch: cxd56xx: Fix parameter check of hostif buffer new 3555314 stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both new c9ccbb9 stm32h7_rcc.c: Fixes typo in comment The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c | 20 +- arch/arm/src/stm32h7/stm32h7x7xx_rcc.c | 38 -- 2 files changed, 46 insertions(+), 12 deletions(-)
[incubator-nuttx] 02/02: stm32h7xxxx_rcc.c: Fixes typo in comment
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit c9ccbb9e035450688cf53707eaa741f7832225f2 Author: Anthony Merlino AuthorDate: Sun May 16 11:28:04 2021 -0400 stm32h7_rcc.c: Fixes typo in comment --- arch/arm/src/stm32h7/stm32h7x3xx_rcc.c | 2 +- arch/arm/src/stm32h7/stm32h7x7xx_rcc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c index 49f8d49..9218861 100644 --- a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c +++ b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c @@ -486,7 +486,7 @@ static inline void rcc_enableapb2(void) #endif #ifdef CONFIG_STM32H7_USART6 - /* USART1 clock enable */ + /* USART6 clock enable */ regval |= RCC_APB2ENR_USART6EN; #endif diff --git a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c index af179c5..81e7e8a 100644 --- a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c +++ b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c @@ -486,7 +486,7 @@ static inline void rcc_enableapb2(void) #endif #ifdef CONFIG_STM32H7_USART6 - /* USART1 clock enable */ + /* USART6 clock enable */ regval |= RCC_APB2ENR_USART6EN; #endif
[GitHub] [incubator-nuttx] btashton commented on pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
btashton commented on pull request #3730: URL: https://github.com/apache/incubator-nuttx/pull/3730#issuecomment-844826342 @antmerlino @davids5 seems to be working on the hardware I had intermittent issues with previously so I will merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #723: include debug.h for xerr/xinfo/xwarn caller
Ouss4 merged pull request #723: URL: https://github.com/apache/incubator-nuttx-apps/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (7ef5055 -> 6ff7e42)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 7ef5055 system/system: Include errno.h add 6ff7e42 include debug.h for xerr/xinfo/xwarn caller No new revisions were added by this update. Summary of changes: graphics/nxwidgets/src/cscaledbitmap.cxx | 1 + graphics/nxwidgets/src/cwidgetcontrol.cxx | 1 + 2 files changed, 2 insertions(+)
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #721: system/system: Include errno.h
Ouss4 merged pull request #721: URL: https://github.com/apache/incubator-nuttx-apps/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (bff9221 -> 7ef5055)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from bff9221 Check CONFIG_BOARDCTL_ROMDISK is set add 7ef5055 system/system: Include errno.h No new revisions were added by this update. Summary of changes: system/system/system.c | 1 + 1 file changed, 1 insertion(+)
[GitHub] [incubator-nuttx-apps] jturnsek opened a new pull request #724: Arrow keys not working when in INSERT mode
jturnsek opened a new pull request #724: URL: https://github.com/apache/incubator-nuttx-apps/pull/724 ## Summary Using Arrow keys in vi when in INSERT mode causes abnormal behaviour ## Impact vi text editor ## Testing Tested with Minicom 2.7.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
