[incubator-nuttx] branch master updated: ci: enable pytest on docker file

2022-09-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 8b3a936588 ci: enable pytest on docker file
8b3a936588 is described below

commit 8b3a93658816c49d1e55c07c8bdd68c5bbdde688
Author: nietingting 
AuthorDate: Mon Sep 26 10:05:57 2022 +0800

ci: enable pytest on docker file

Signed-off-by: nietingting 
---
 tools/ci/cibuild.sh  | 7 ++-
 tools/ci/docker/linux/Dockerfile | 7 +++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/tools/ci/cibuild.sh b/tools/ci/cibuild.sh
index 19ca20de09..68001c65ba 100755
--- a/tools/ci/cibuild.sh
+++ b/tools/ci/cibuild.sh
@@ -62,7 +62,12 @@ function python-tools {
   PYTHONUSERBASE=${prebuilt}/pylocal
   export PYTHONUSERBASE
   add_path "${PYTHONUSERBASE}"/bin
-  pip3 install pexpect
+  pip3 install pexpect==4.8.0
+  pip3 install pytest==6.2.5
+  pip3 install pytest-repeat==0.9.1
+  pip3 install pytest-json==0.4.0
+  pip3 install pytest-ordering==0.6
+  pip3 install pyserial==3.5
 
   # MCUboot's tool for image signing and key management
   if ! command -v imgtool &> /dev/null; then
diff --git a/tools/ci/docker/linux/Dockerfile b/tools/ci/docker/linux/Dockerfile
index 54c0fd7adf..66850cb4f4 100644
--- a/tools/ci/docker/linux/Dockerfile
+++ b/tools/ci/docker/linux/Dockerfile
@@ -264,6 +264,13 @@ ENV PIP_NO_CACHE_DIR=0
 RUN pip3 install setuptools wheel
 # Install CodeChecker and use it to statically analyze the code.
 RUN pip3 install CodeChecker
+# Install pytest
+RUN pip3 install pexpect==4.8.0
+RUN pip3 install pytest==6.2.5
+RUN pip3 install pytest-repeat==0.9.1
+RUN pip3 install pytest-json==0.4.0
+RUN pip3 install pytest-ordering==0.6
+RUN pip3 install pyserial==3.5
 
 RUN mkdir /tools
 WORKDIR /tools



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7186: ci: enable pytest on docker file

2022-09-25 Thread GitBox


xiaoxiang781216 merged PR #7186:
URL: https://github.com/apache/incubator-nuttx/pull/7186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257510475

   But anyway we need one shared(not individual) and reliable place to host the 
change can't upstream or tools which isn't maintained anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


btashton commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257453088

   > How about we fork https://bitbucket.org/nuttx/tools.git to 
https://github.com/NuttX? @btashton @pkarashchenko @acassis 
   
   This has come up before that https://github.com/NuttX will need to be 
removed. We don't have a great home for the content that is in the bitbucket 
repo since much of it cannot be apache licenced. 
   
   Some of it is also broken. I forked nxflat from it and fixed some bugs here. 
https://github.com/btashton/nxflat


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1324: netutils/dhcpc: Add dhcp client id option

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #1324:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1324#issuecomment-1257445523

   @SunJun8 please fix the compiler error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated: poll: add poll_notify() api and call it in all drivers

2022-09-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 344c8be049 poll: add poll_notify() api and call it in all drivers
344c8be049 is described below

commit 344c8be049df5a90556dffa3a68ad90c9883d66b
Author: wangbowen6 
AuthorDate: Mon Sep 19 11:08:57 2022 +0800

poll: add poll_notify() api and call it in all drivers

Signed-off-by: wangbowen6 
---
 arch/arm/src/cxd56xx/cxd56_geofence.c  | 12 +---
 arch/arm/src/cxd56xx/cxd56_gnss.c  | 12 +---
 arch/arm/src/sama5/sam_tsd.c   | 13 +
 arch/arm/src/stm32/stm32_bbsram.c  |  6 +-
 arch/arm/src/stm32f7/stm32_bbsram.c|  6 +-
 arch/arm/src/stm32h7/stm32_bbsram.c|  6 +-
 arch/renesas/src/rx65n/rx65n_sbram.c   |  6 +-
 boards/arm/sam34/sam4l-xplained/src/sam_slcd.c |  6 +-
 .../stm32/mikroe-stm32f4/src/stm32_touchscreen.c   | 14 +
 boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c   |  6 +-
 .../pic32mx/pic32mx7mmb/src/pic32_touchscreen.c| 14 +
 .../pic32mx/sure-pic32mx/src/pic32mx_lcd1602.c |  6 +-
 drivers/analog/adc.c   | 23 +---
 drivers/analog/comp.c  | 44 +--
 drivers/bch/bchdev_driver.c|  6 +-
 drivers/can/can.c  | 42 ++
 drivers/crypto/dev_urandom.c   |  6 +-
 drivers/input/ads7843e.c   | 13 +
 drivers/input/ajoystick.c  | 23 +---
 drivers/input/button_upper.c   | 23 +---
 drivers/input/cypress_mbr3108.c| 25 ++---
 drivers/input/djoystick.c  | 23 +---
 drivers/input/ft5x06.c | 13 +
 drivers/input/keyboard_upper.c | 29 +-
 drivers/input/max11802.c   | 13 +
 drivers/input/mxt.c| 13 +
 drivers/input/spq10kbd.c   | 25 +
 drivers/input/stmpe811_tsc.c   | 13 +
 drivers/input/touchscreen_upper.c  | 34 +---
 drivers/input/tsc2007.c| 13 +
 drivers/ipcc/ipcc_poll.c   | 60 +---
 drivers/lcd/pcf8574_lcd_backpack.c |  6 +-
 drivers/lcd/tda19988.c |  6 +-
 drivers/misc/dev_null.c|  6 +-
 drivers/misc/dev_zero.c|  6 +-
 drivers/modem/u-blox.c |  6 +-
 drivers/mtd/mtd_config.c   |  6 +-
 drivers/mtd/mtd_config_fs.c|  6 +-
 drivers/net/telnet.c   |  6 +-
 drivers/net/tun.c  | 17 ++
 drivers/pipes/pipe_common.c| 54 +++---
 drivers/power/battery/battery_charger.c|  7 +--
 drivers/power/battery/battery_gauge.c  |  7 +--
 drivers/power/battery/battery_monitor.c|  7 +--
 drivers/rc/lirc_dev.c  | 38 ++---
 drivers/sensors/hc_sr04.c  | 28 +-
 drivers/sensors/hts221.c   | 28 +-
 drivers/sensors/lis2dh.c   | 31 +--
 drivers/sensors/max44009.c |  4 +-
 drivers/sensors/sensor.c   | 31 ++-
 drivers/serial/serial.c| 50 ++---
 drivers/serial/uart_bth4.c | 26 ++---
 drivers/syslog/ramlog.c| 17 +-
 drivers/usbdev/adb.c   | 45 ++-
 drivers/usbhost/usbhost_cdcmbim.c  | 32 +--
 drivers/usbhost/usbhost_hidkbd.c   | 31 +--
 drivers/usbhost/usbhost_hidmouse.c | 42 +-
 drivers/usbhost/usbhost_xboxcontroller.c   | 13 +
 drivers/usbmisc/fusb301.c  | 37 +
 drivers/usbmisc/fusb303.c  | 37 +
 drivers/usrsock/usrsock_dev.c  | 30 +-
 drivers/wireless/cc1101.c  |  8 +--
 drivers/wireless/gs2200m.c |  7 +--
 drivers/wireless/lpwan/sx127x/sx127x.c | 13 +
 drivers/wireless/nrf24l01.c|  8 +--
 fs/mqueue/mq_open.c| 37 +
 fs/vfs/fs_epoll.c  |  3 +-
 fs/vfs/fs_eventfd.c| 35 +---
 fs/vfs/fs_poll.c

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7131: poll: add poll_notify() api and call it in all drivers.

2022-09-25 Thread GitBox


xiaoxiang781216 merged PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257444381

   How about we fork https://bitbucket.org/nuttx/tools.git to 
https://github.com/NuttX?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] SunJun8 opened a new pull request, #1324: netutils/dhcpc: Add dhcp client id option

2022-09-25 Thread GitBox


SunJun8 opened a new pull request, #1324:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1324

   ## Summary
   - Add client id field for dhcp discover and request
   
   ## Impact
   - Maybe optimize dhcp server response 
   - unknown
   
   ## Testing
   Pass CI
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] ttnie commented on pull request #7186: ci: enable pytest on docker file

2022-09-25 Thread GitBox


ttnie commented on PR #7186:
URL: https://github.com/apache/incubator-nuttx/pull/7186#issuecomment-1257429038

   > 
   
   update done. pls help to review 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #7131: poll: add poll_notify() api and call it in all drivers.

2022-09-25 Thread GitBox


CV-Bowen commented on code in PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#discussion_r979510556


##
drivers/serial/uart_bth4.c:
##
@@ -398,10 +383,10 @@ static int uart_bth4_poll(FAR struct file *filep, FAR 
struct pollfd *fds,
 
   if (!circbuf_is_empty(>circbuf))
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
 
-  eventset |= (fds->events & POLLOUT);
+  eventset |= POLLOUT;
 
   if (eventset)

Review Comment:
   Done



##
drivers/sensors/sensor.c:
##
@@ -899,25 +883,25 @@ static int sensor_poll(FAR struct file *filep,
 
   if (filep->f_oflags & O_NONBLOCK)
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
   else
 {
   nxsem_get_value(>buffersem, );
   if (semcount > 0)
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
 }
 }
   else if (sensor_is_updated(upper, user))
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
 
   if (user->changed)
 {
-  eventset |= (fds->events & POLLPRI);
+  eventset |= POLLPRI;
 }
 
   if (eventset)

Review Comment:
   Done



##
drivers/net/tun.c:
##
@@ -1270,7 +1264,7 @@ int tun_poll(FAR struct file *filep, FAR struct pollfd 
*fds, bool setup)
 
   if (priv->read_d_len != 0 || priv->write_d_len != 0)
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
 
   if (eventset)

Review Comment:
   Done



##
fs/mqueue/mq_open.c:
##
@@ -127,12 +127,12 @@ static int nxmq_file_poll(FAR struct file *filep,
 
   if (msgq->nmsgs < msgq->maxmsgs)
 {
-  eventset |= (fds->events & POLLOUT);
+  eventset |= POLLOUT;
 }
 
   if (msgq->nmsgs)
 {
-  eventset |= (fds->events & POLLIN);
+  eventset |= POLLIN;
 }
 
   if (eventset)

Review Comment:
   Done



##
fs/vfs/fs_poll.c:
##
@@ -276,6 +277,60 @@ static inline int poll_teardown(FAR struct pollfd *fds, 
nfds_t nfds,
  * Public Functions
  /
 
+/
+ * Name: poll_notify
+ *
+ * Description:
+ *   Notify the poll, this function should be called by drivers to notify
+ *   the caller the poll is ready.
+ *
+ * Input Parameters:
+ *   afds - The fds array
+ *   nfds - Number of fds array
+ *   eventset - List of events to check for activity
+ *
+ * Returned Value:
+ *   None
+ *
+ /
+
+void poll_notify(FAR struct pollfd **afds, int nfds, pollevent_t eventset)
+{
+  int i;
+  int semcount;
+  FAR struct pollfd *fds;
+
+  DEBUGASSERT(afds != NULL && nfds >= 1);
+
+  for (i = 0; i < nfds; i++)

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] CV-Bowen commented on pull request #7131: poll: add poll_notify() api and call it in all drivers.

2022-09-25 Thread GitBox


CV-Bowen commented on PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#issuecomment-1257384621

   Delete `if (eventset)` and add this judgement to fs_poll.c
   modified:   drivers/net/tun.c
   modified:   drivers/sensors/sensor.c
   modified:   drivers/serial/uart_bth4.c
   modified:   drivers/syslog/ramlog.c
   modified:   fs/mqueue/mq_open.c
   modified:   fs/vfs/fs_poll.c
   modified:   graphics/nxterm/nxterm_kbdin.c
   modified:   net/local/local_netpoll.c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7186: ci: enable pytest on docker file

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7186:
URL: https://github.com/apache/incubator-nuttx/pull/7186#issuecomment-1257382084

   let's install in 
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/cibuild.sh too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] ttnie opened a new pull request, #7186: ci: enable pytest on docker file

2022-09-25 Thread GitBox


ttnie opened a new pull request, #7186:
URL: https://github.com/apache/incubator-nuttx/pull/7186

   Signed-off-by: nietingting 
   
   ## Summary
   enable pytest support on docker
   ## Impact
   no
   ## Testing
   test on local
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 74842880f9430b9b404cdc5f9c59dd4c7dea7997

2022-09-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new e93d78c  Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a 
docs: 74842880f9430b9b404cdc5f9c59dd4c7dea7997
e93d78c is described below

commit e93d78c8e8523d3150effcacfa0eb0b8501290eb
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Mon Sep 26 00:17:53 2022 +

Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 
74842880f9430b9b404cdc5f9c59dd4c7dea7997
---
 content/docs/10.0.0/index.html | 2 +-
 content/docs/10.0.1/index.html | 2 +-
 content/docs/10.1.0/index.html | 2 +-
 content/docs/10.2.0/index.html | 2 +-
 content/docs/10.3.0/index.html | 2 +-
 content/docs/latest/index.html | 2 +-
 content/feed.xml   | 4 ++--
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 32d4fdc..3652339 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -207,7 +207,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 25 September 22 at 00:13
+Last Updated: 26 September 22 at 00:14
 
 Table of Contents
 
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index dd74f8f..790176c 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -217,7 +217,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 25 September 22 at 00:14
+Last Updated: 26 September 22 at 00:14
 
 Table of Contents
 
diff --git a/content/docs/10.1.0/index.html b/content/docs/10.1.0/index.html
index c35998c..55eee4d 100644
--- a/content/docs/10.1.0/index.html
+++ b/content/docs/10.1.0/index.html
@@ -217,7 +217,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller 
environments, the primary governing standards in NuttX are POSIX and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 25 September 22 at 00:14
+Last Updated: 26 September 22 at 00:15
 
 Table of Contents
 
diff --git a/content/docs/10.2.0/index.html b/content/docs/10.2.0/index.html
index e5d4181..46bea14 100644
--- a/content/docs/10.2.0/index.html
+++ b/content/docs/10.2.0/index.html
@@ -218,7 +218,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller 
environments, the primary governing standards in NuttX are POSIX and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 25 September 22 at 00:14
+Last Updated: 26 September 22 at 00:15
 
 Table of Contents
 
diff --git a/content/docs/10.3.0/index.html b/content/docs/10.3.0/index.html
index e5d4181..345b449 100644
--- a/content/docs/10.3.0/index.html
+++ b/content/docs/10.3.0/index.html
@@ -218,7 +218,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller 
environments, the primary governing standards in NuttX are POSIX and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for 

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


hartmannathan commented on PR #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183#issuecomment-1257277429

   > > You might find this PR of interest where I updated the docs for these 
and then it got stuck #3604
   > 
   > @hartmannathan could you continue @btashton 's work?
   
   @btashton @xiaoxiang781216 Yes. I am traveling but will be back in a few 
days and I'll look at it then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 74842880f9 compiler.h: add MSVC(Microsoft Visual C++)-specific 
definitions
74842880f9 is described below

commit 74842880f9430b9b404cdc5f9c59dd4c7dea7997
Author: chao an 
AuthorDate: Sun Sep 25 20:12:14 2022 +0800

compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

Signed-off-by: chao an 
---
 include/nuttx/compiler.h | 69 
 1 file changed, 69 insertions(+)

diff --git a/include/nuttx/compiler.h b/include/nuttx/compiler.h
index 9f282daa40..7e1407d32b 100644
--- a/include/nuttx/compiler.h
+++ b/include/nuttx/compiler.h
@@ -745,6 +745,75 @@
 
 #  define no_builtin(n)
 
+/* MSVC(Microsoft Visual C++)-specific definitions **/
+
+#elif defined(_MSC_VER)
+
+/* Define these here and allow specific architectures to override as needed */
+
+#  define CONFIG_HAVE_LONG_LONG 1
+#  define CONFIG_HAVE_FLOAT 1
+#  define CONFIG_HAVE_DOUBLE 1
+#  define CONFIG_HAVE_LONG_DOUBLE 1
+
+/* Pre-processor */
+
+#  define CONFIG_CPP_HAVE_VARARGS 1 /* Supports variable argument macros */
+
+/* Intriniscs */
+
+#  define CONFIG_HAVE_FUNCTIONNAME 1 /* Has __FUNCTION__ */
+#  define CONFIG_HAVE_FILENAME 1 /* Has __FILE__ */
+
+#  undef  CONFIG_CPP_HAVE_WARNING
+#  undef  CONFIG_HAVE_WEAKFUNCTIONS
+#  define weak_alias(name, aliasname)
+#  define weak_data
+#  define weak_function
+#  define weak_const_function
+#  define restrict
+#  define noreturn_function
+#  define farcall_function
+#  define aligned_data(n)
+#  define locate_code(n)
+#  define locate_data(n)
+#  define begin_packed_struct
+#  define end_packed_struct
+#  define reentrant_function
+#  define naked_function
+#  define always_inline_function
+#  define noinline_function
+#  define noinstrument_function
+#  define nosanitize_address
+#  define nosanitize_undefined
+#  define nostackprotect_function
+#  define unused_code
+#  define unused_data
+#  define used_code
+#  define used_data
+#  define formatlike(a)
+#  define printflike(a, b)
+#  define sysloglike(a, b)
+#  define scanflike(a, b)
+#  define strftimelike(a)
+
+#  define FAR
+#  define NEAR
+#  define DSEG
+#  define CODE
+#  define IOBJ
+#  define IPTR
+
+#  undef  CONFIG_SMALL_MEMORY
+#  undef  CONFIG_LONG_IS_NOT_INT
+#  undef  CONFIG_PTR_IS_NOT_INT
+
+#  define UNUSED(a) ((void)(1 || &(a)))
+
+#  define offsetof(a, b) ((size_t)(&(((a *)(0))->b)))
+
+#  define no_builtin(n)
+
 /* Unknown compiler */
 
 #else



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


xiaoxiang781216 merged PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181#issuecomment-1257275435

   Let's ignore the false alarm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 09c006b9c8 libs: fix visual studio Compiler Error C2124
09c006b9c8 is described below

commit 09c006b9c84c19dcad883faf366b70cca304872a
Author: chao an 
AuthorDate: Sun Sep 25 23:19:54 2022 +0800

libs: fix visual studio Compiler Error C2124

D:\code\incubator-nuttx\libs\libc\stdlib\lib_strtod.c: error C2124: divide 
or mod by zero

Windows MSVC restrictions, MSVC doesn't allow division through a
zero literal, but allows it through non-const variable set to zero

Reference:

https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2124?view=msvc-170

Signed-off-by: chao an 
---
 libs/libc/stdlib/lib_strtod.c  | 15 +--
 libs/libc/stdlib/lib_strtold.c | 15 +--
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/libs/libc/stdlib/lib_strtod.c b/libs/libc/stdlib/lib_strtod.c
index fe8e48ff4b..529bf9d1c6 100644
--- a/libs/libc/stdlib/lib_strtod.c
+++ b/libs/libc/stdlib/lib_strtod.c
@@ -71,7 +71,12 @@
 
 static inline int is_real(double x)
 {
-  const double infinite = 1.0 / 0.0;
+  /* NOTE: Windows MSVC restrictions, MSVC doesn't allow division through a
+   * zero literal, but allows it through non-const variable set to zero
+   */
+
+  const double divzero = 0.0;
+  const double infinite = 1.0 / divzero;
   return (x < infinite) && (x >= -infinite);
 }
 
@@ -101,7 +106,13 @@ double strtod(FAR const char *str, FAR char **endptr)
   int n;
   int num_digits;
   int num_decimals;
-  const double infinite = 1.0 / 0.0;
+
+  /* NOTE: Windows MSVC restrictions, MSVC doesn't allow division through a
+   * zero literal, but allows it through non-const variable set to zero
+   */
+
+  const double divzero = 0.0;
+  const double infinite = 1.0 / divzero;
 
   /* Skip leading whitespace */
 
diff --git a/libs/libc/stdlib/lib_strtold.c b/libs/libc/stdlib/lib_strtold.c
index cd569561d2..a043412d04 100644
--- a/libs/libc/stdlib/lib_strtold.c
+++ b/libs/libc/stdlib/lib_strtold.c
@@ -71,7 +71,12 @@
 
 static inline int is_real(long double x)
 {
-  const long double infinite = 1.0L / 0.0L;
+  /* NOTE: Windows MSVC restrictions, MSVC doesn't allow division through a
+   * zero literal, but allows it through non-const variable set to zero
+   */
+
+  const long double divzero = 0.0L;
+  const long double infinite = 1.0L / divzero;
   return (x < infinite) && (x >= -infinite);
 }
 
@@ -101,7 +106,13 @@ long double strtold(FAR const char *str, FAR char **endptr)
   int n;
   int num_digits;
   int num_decimals;
-  const long double infinite = 1.0L / 0.0L;
+
+  /* NOTE: Windows MSVC restrictions, MSVC doesn't allow division through a
+   * zero literal, but allows it through non-const variable set to zero
+   */
+
+  const long double divzero = 0.0L;
+  const long double infinite = 1.0L / divzero;
 
   /* Skip leading whitespace */
 



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


xiaoxiang781216 merged PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257275326

   Let's ignore the false alarm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183#issuecomment-1257275092

   > You might find this PR of interest where I updated the docs for these and 
then it got stuck #3604
   
   @hartmannathan could you continue @btashton 's work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 34192c07de boards/tm4c129e-launchpad: Expand README.txt
34192c07de is described below

commit 34192c07dec0545ad9d1304750b32561cbdad8d6
Author: Nathan Hartman <59230071+hartmannat...@users.noreply.github.com>
AuthorDate: Sun Sep 25 10:12:47 2022 -0400

boards/tm4c129e-launchpad: Expand README.txt

* boards/arm/tiva/tm4c129e-launchpad/README.txt:
  Expand this documentation with information about: toolchains,
  debugging (including the elusive openocd incantation to flash program
  the board), MCU clocking, more details about the Virtual COM port
  exposed via ICDI, and a description of the recently added ostest
  configuration.
---
 boards/arm/tiva/tm4c129e-launchpad/README.txt | 119 --
 1 file changed, 112 insertions(+), 7 deletions(-)

diff --git a/boards/arm/tiva/tm4c129e-launchpad/README.txt 
b/boards/arm/tiva/tm4c129e-launchpad/README.txt
index dec1e129d6..3c4fc1000e 100644
--- a/boards/arm/tiva/tm4c129e-launchpad/README.txt
+++ b/boards/arm/tiva/tm4c129e-launchpad/README.txt
@@ -5,6 +5,27 @@ README
   LaunchPad (more correctly, the EK-TM4C129EXL). For more information about 
this
   board, see https://www.ti.com/tool/EK-TM4C129EXL.
 
+Contents
+
+
+  - EK-TM4C1294XL and DK-TM4C129X
+  - Status
+  - Directory Structure
+  - Development Environment
+- Toolchains
+- Debugging
+  - Hardware
+- MCU Clocking
+- Serial Console
+- GPIOs
+- Buttons
+- LEDs
+- GPIOs
+  - Configurations
+- nsh
+- ipv6
+- ostest
+
 EK-TM4C1294XL and DK-TM4C129X
 =
 
@@ -15,6 +36,11 @@ EK-TM4C1294XL and DK-TM4C129X
 boards/arm/tiva/tm4c1294-launchpad/README.txt
 boards/arm/tiva/dk-tm4c129x/README.txt
 
+Status
+==
+
+  This port boots NuttX through to a functional NSH prompt.
+
 Directory Structure
 ===
 
@@ -33,15 +59,80 @@ Within chip subdirectory:
 configs/- Subdirectory for one or more board configuration(s)
- Configuration for use with tools/configure.sh or .bat
 
-Serial Console
-==
+Development Environment
+===
+
+  Toolchains
+  --
+  An appropriate ARM toolchain is needed, such as:
+
+  * The toolchain built with the customized NuttX buildroot
+
+  * The ready-made GNU Tools for Arm Embedded Processors:
+https://developer.arm.com/Tools%20and%20Software/GNU%20Toolchain
+
+  * The toolchain that installs with Texas Instruments Code Composer Studio
+(CCS): https://www.ti.com/tool/CCSTUDIO
+
+  Debugging
+  -
+
+  The board incorporates an In-Circuit Debug Interface (ICDI) which allows
+  FLASH programming and JTAG debugging. This is accessible via the Micro-USB
+  Type B connector labeled DEBUG (opposite end of the board from the Ethernet
+  port). The ICDI interface is implemented by a TM4C123G microcontroller.
+
+  To debug with OpenOCD and arm-nuttx-eabi-gdb:
+
+  * Use 'make menuconfig' to set CONFIG_DEBUG_SYMBOLS and CONFIG_DEBUG_NOOPT.
+To see debug output, e.g., the "ABCDE" printed in __start(), also set
+CONFIG_DEBUG_FEATURES.
+
+  * Build NuttX.
 
-  These configurations use UART0 for the serial console. UART0 is connected to
-  the on-board TM4C123G-based debugger and is forwarded through the ICDI 
virtual
-  UART.
+  * Flash the code using:
+$ openocd -f board/ek-tm4c1294xl.cfg -c "init" -c "reset halt" \
+  -c "stellaris mass_erase 0" -c "flash write_bank 0 nuttx.bin"
 
-Buttons and LEDs
-
+NOTE: The above command might fail unless either: udev rules have been
+configured on the development system (preferred) or the command is run as
+root with 'sudo' (not encouraged). See:
+- https://openocd.org/doc/html/Running.html
+- https://forgge.github.io/theCore/guides/running-openocd-without-sudo.html
+
+  * Start GDB with:
+$ arm-nuttx-eabi-gdb -tui nuttx
+
+  * In GDB:
+(gdb) target remote localhost:
+(gdb) monitor reset halt
+(gdb) load
+
+Hardware
+
+
+  MCU Clocking
+  
+
+By default, the MCU on this board is clocked from 25 MHz crystal Y1, also
+required for clocking the TM4C129's internal Ethernet MAC and PHY. For core
+and peripheral timing, the MCU's internal PLL multiplies this 25 MHz clock
+to 120 MHz.
+
+The MCU's Hibernation peripheral is clocked from 32.768-KHz crystal Y3.
+
+  Serial Console
+  --
+
+These configurations use UART0 for the serial console.
+
+By default (check jumper settings on the board), UART0 is connected to the
+on-board ICDI interface and is forwarded through the ICDI virtual UART. On
+the PC, this appears a Virtual COM Port over the same Micro-USB Type 

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


xiaoxiang781216 merged PR #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183#issuecomment-1257274849

   Let's ignore the false ci alarm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


xiaoxiang781216 commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979456101


##
include/nuttx/wdog.h:
##
@@ -29,7 +29,6 @@
 
 #include 
 #include 
-#include 

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


pkarashchenko commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979451829


##
include/nuttx/wdog.h:
##
@@ -29,7 +29,6 @@
 
 #include 
 #include 
-#include 

Review Comment:
   Seems now we need to add `#include `  to `sched/wdog/wdog.h` 
as it was implicitly included till now.
   After adding it code builds locally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


pkarashchenko commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979451829


##
include/nuttx/wdog.h:
##
@@ -29,7 +29,6 @@
 
 #include 
 #include 
-#include 

Review Comment:
   Seems now we need to add `#include `  to `sched/wdog/wdog.h` 
as it was implicitly included till now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


btashton commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257257477

   > @acassis seems that it is not a matter of retry. I can't access that URL 
from my laptop as well. Something is wrong with that repo
   
   Yeah looks like they are having a partial outage. 
https://bitbucket.status.atlassian.com/incidents/3308g2hlkfsx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


pkarashchenko commented on PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#issuecomment-1257256414

   Seems like some files still need to be updated
   ```
   In file included from wdog/wd_gettime.c:30:
   Error: /github/workspace/sources/nuttx/sched/wdog/wdog.h:75:8: error: 
unknown type name 'sq_queue_t'
  75 | extern sq_queue_t g_wdactivelist;
 |^~
   ```
   I will try to run the build locally and feedback


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


pkarashchenko commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257255516

   @acassis seems that it is not a matter of retry. I can't access that URL 
from my laptop as well. Something is wrong with that repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1323: Replace #include with #include

2022-09-25 Thread GitBox


xiaoxiang781216 opened a new pull request, #1323:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1323

   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #1321: libuv: Fix queue.h conflict with nuttx verson

2022-09-25 Thread GitBox


xiaoxiang781216 closed pull request #1321: libuv: Fix queue.h conflict with 
nuttx verson
URL: https://github.com/apache/incubator-nuttx-apps/pull/1321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1321: libuv: Fix queue.h conflict with nuttx verson

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #1321:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1321#issuecomment-1257227486

   Let's close this PR to prefer 
https://github.com/apache/incubator-nuttx/pull/7185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#issuecomment-1257225358

   Please ignore the mix case warning from arch/arm/src/phy62xx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7185: libc: Move queue.h from include to include/nuttx

2022-09-25 Thread GitBox


xiaoxiang781216 opened a new pull request, #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185

   ## Summary
   to avoid the conflict with libuv's queue.h
   
   ## Impact
   Code refactor
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


acassis commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257219647

   Is it possible to change the CI script to try again when these kind of 
errors show up:
   ```
   Cloning into 
'/Users/runner/work/incubator-nuttx/incubator-nuttx/sources/tools'...
   fatal: unable to access 'https://bitbucket.org/nuttx/tools.git/': Empty 
reply from server
   Error: Process completed with exit code 128.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] anchao opened a new pull request, #7184: libs: fix visual studio Compiler Error C2124

2022-09-25 Thread GitBox


anchao opened a new pull request, #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184

   
   ## Summary
   
   libs: fix visual studio Compiler Error C2124
   
   D:\code\incubator-nuttx\libs\libc\stdlib\lib_strtod.c: error C2124: divide 
or mod by zero
   
   Windows MSVC restrictions, MSVC doesn't allow division through a
   zero literal, but allows it through non-const variable set to zero
   
   Reference:
   
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2124?view=msvc-170
   
   Signed-off-by: chao an 
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   cmake + sim/windows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7182: sim/windows: add more net configs

2022-09-25 Thread GitBox


masayuki2009 merged PR #7182:
URL: https://github.com/apache/incubator-nuttx/pull/7182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


btashton commented on PR #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183#issuecomment-1257216244

   You might find this PR of interest where I updated the docs for these and 
then it got stuck 
   https://github.com/apache/incubator-nuttx/pull/3604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated (d129c95fd2 -> f43be61f69)

2022-09-25 Thread masayuki
This is an automated email from the ASF dual-hosted git repository.

masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


from d129c95fd2 boards/b-g474e-dpow1: Add note about udev/sudo regarding 
openocd
 add d71e8dacd4 sim/windows: add more net configs
 add f43be61f69 net/tcp: remove the redundant ifdef CONFIG_NET_TCP

No new revisions were added by this update.

Summary of changes:
 boards/sim/sim/sim/configs/windows/defconfig | 18 ++
 net/tcp/tcp_accept.c |  2 --
 2 files changed, 18 insertions(+), 2 deletions(-)



[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


anchao commented on code in PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181#discussion_r979419890


##
include/nuttx/compiler.h:
##
@@ -745,6 +745,69 @@
 
 #  define no_builtin(n)
 
+/* MSVC(Microsoft Visual C++)-specific definitions **/
+
+#elif defined(_MSC_VER)
+
+/* Define these here and allow specific architectures to override as needed */
+
+#  define CONFIG_HAVE_LONG_LONG 1
+
+#  undef  CONFIG_CPP_HAVE_VARARGS
+#  undef  CONFIG_CPP_HAVE_WARNING
+#  undef  CONFIG_HAVE_FUNCTIONNAME
+#  undef  CONFIG_HAVE_FILENAME
+#  undef  CONFIG_HAVE_WEAKFUNCTIONS
+#  define weak_alias(name, aliasname)
+#  define weak_data
+#  define weak_function
+#  define weak_const_function
+#  define restrict
+#  define noreturn_function
+#  define farcall_function
+#  define aligned_data(n)
+#  define locate_code(n)
+#  define locate_data(n)
+#  define begin_packed_struct
+#  define end_packed_struct
+#  define reentrant_function
+#  define naked_function
+#  define always_inline_function
+#  define noinline_function
+#  define noinstrument_function
+#  define nosanitize_address
+#  define nosanitize_undefined
+#  define nostackprotect_function
+#  define unused_code
+#  define unused_data
+#  define used_code
+#  define used_data
+#  define formatlike(a)
+#  define printflike(a, b)
+#  define sysloglike(a, b)
+#  define scanflike(a, b)
+#  define strftimelike(a)
+
+#  define FAR
+#  define NEAR
+#  define DSEG
+#  define CODE
+#  define IOBJ
+#  define IPTR
+
+#  undef  CONFIG_SMALL_MEMORY
+#  undef  CONFIG_LONG_IS_NOT_INT
+#  undef  CONFIG_PTR_IS_NOT_INT
+#  define CONFIG_HAVE_FLOAT 1
+#  undef  CONFIG_HAVE_DOUBLE
+#  undef  CONFIG_HAVE_LONG_DOUBLE

Review Comment:
   OK, let me enable long double defines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] btashton merged pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt

2022-09-25 Thread GitBox


btashton merged PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[incubator-nuttx] branch master updated (70290b6e38 -> d129c95fd2)

2022-09-25 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


from 70290b6e38 arch: Change the linker generated symbols from uint32_t to 
uint8_t *
 add d129c95fd2 boards/b-g474e-dpow1: Add note about udev/sudo regarding 
openocd

No new revisions were added by this update.

Summary of changes:
 boards/arm/stm32/b-g474e-dpow1/README.txt | 6 ++
 1 file changed, 6 insertions(+)



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt

2022-09-25 Thread GitBox


hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257210672

   Okay, squashed. Ready for merge if you're happy with it. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt

2022-09-25 Thread GitBox


hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257210254

   One moment, I forgot to squash commits...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7177: boards/b-g474e-dpow1: Fix 'openocd' incantation in README.txt

2022-09-25 Thread GitBox


hartmannathan commented on PR #7177:
URL: https://github.com/apache/incubator-nuttx/pull/7177#issuecomment-1257208645

   @btashton, @gustavonihei, @pkarashchenko, thank you all for your input. The 
changes I just pushed offer the following compromise:
   
   (1) Removed 'sudo' from the 'openocd' incantation shown.
   
   (2) Added a note about configuring udev rules.
   
   (3) Added a link to OpenOCD's upstream docs about that, as well as the very 
helpful link found by @gustavonihei (thanks!).
   
   (4) Although I still mention the possibility of 'sudo', it is mentioned last 
and I specifically state that it is not encouraged.
   
   Now it is up to the embedded developer to decide what is best in his or her 
own situation.
   
   Please re-review if you can and let me know what you think! Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #7183: boards/tm4c129e-launchpad: Expand README.txt

2022-09-25 Thread GitBox


hartmannathan opened a new pull request, #7183:
URL: https://github.com/apache/incubator-nuttx/pull/7183

   ## Summary
   
   Expand the README.txt for `tm4c129e-launchpad`.
   
   (The main motivation was to add the elusive `openocd` incantation to flash 
program this board. However, I also added useful documentation about 
toolchains, debugging, clocking, and the ICDI virtual serial interface.)
   
   ## Impact
   
   Improve documentation.
   
   ## Testing
   
   The openocd incantation works. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


pkarashchenko commented on code in PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181#discussion_r979413120


##
include/nuttx/compiler.h:
##
@@ -745,6 +745,69 @@
 
 #  define no_builtin(n)
 
+/* MSVC(Microsoft Visual C++)-specific definitions **/
+
+#elif defined(_MSC_VER)
+
+/* Define these here and allow specific architectures to override as needed */
+
+#  define CONFIG_HAVE_LONG_LONG 1
+
+#  undef  CONFIG_CPP_HAVE_VARARGS
+#  undef  CONFIG_CPP_HAVE_WARNING
+#  undef  CONFIG_HAVE_FUNCTIONNAME
+#  undef  CONFIG_HAVE_FILENAME
+#  undef  CONFIG_HAVE_WEAKFUNCTIONS
+#  define weak_alias(name, aliasname)
+#  define weak_data
+#  define weak_function
+#  define weak_const_function
+#  define restrict
+#  define noreturn_function
+#  define farcall_function
+#  define aligned_data(n)
+#  define locate_code(n)
+#  define locate_data(n)
+#  define begin_packed_struct
+#  define end_packed_struct
+#  define reentrant_function
+#  define naked_function
+#  define always_inline_function
+#  define noinline_function
+#  define noinstrument_function
+#  define nosanitize_address
+#  define nosanitize_undefined
+#  define nostackprotect_function
+#  define unused_code
+#  define unused_data
+#  define used_code
+#  define used_data
+#  define formatlike(a)
+#  define printflike(a, b)
+#  define sysloglike(a, b)
+#  define scanflike(a, b)
+#  define strftimelike(a)
+
+#  define FAR
+#  define NEAR
+#  define DSEG
+#  define CODE
+#  define IOBJ
+#  define IPTR
+
+#  undef  CONFIG_SMALL_MEMORY
+#  undef  CONFIG_LONG_IS_NOT_INT
+#  undef  CONFIG_PTR_IS_NOT_INT
+#  define CONFIG_HAVE_FLOAT 1
+#  undef  CONFIG_HAVE_DOUBLE
+#  undef  CONFIG_HAVE_LONG_DOUBLE

Review Comment:
   But those defines are more what compiler supports or not. Otherwise those 
would be located in Kconfig



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


anchao commented on code in PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181#discussion_r979409478


##
include/nuttx/compiler.h:
##
@@ -745,6 +745,69 @@
 
 #  define no_builtin(n)
 
+/* MSVC(Microsoft Visual C++)-specific definitions **/
+
+#elif defined(_MSC_VER)
+
+/* Define these here and allow specific architectures to override as needed */
+
+#  define CONFIG_HAVE_LONG_LONG 1
+
+#  undef  CONFIG_CPP_HAVE_VARARGS
+#  undef  CONFIG_CPP_HAVE_WARNING
+#  undef  CONFIG_HAVE_FUNCTIONNAME
+#  undef  CONFIG_HAVE_FILENAME
+#  undef  CONFIG_HAVE_WEAKFUNCTIONS
+#  define weak_alias(name, aliasname)
+#  define weak_data
+#  define weak_function
+#  define weak_const_function
+#  define restrict
+#  define noreturn_function
+#  define farcall_function
+#  define aligned_data(n)
+#  define locate_code(n)
+#  define locate_data(n)
+#  define begin_packed_struct
+#  define end_packed_struct
+#  define reentrant_function
+#  define naked_function
+#  define always_inline_function
+#  define noinline_function
+#  define noinstrument_function
+#  define nosanitize_address
+#  define nosanitize_undefined
+#  define nostackprotect_function
+#  define unused_code
+#  define unused_data
+#  define used_code
+#  define used_data
+#  define formatlike(a)
+#  define printflike(a, b)
+#  define sysloglike(a, b)
+#  define scanflike(a, b)
+#  define strftimelike(a)
+
+#  define FAR
+#  define NEAR
+#  define DSEG
+#  define CODE
+#  define IOBJ
+#  define IPTR
+
+#  undef  CONFIG_SMALL_MEMORY
+#  undef  CONFIG_LONG_IS_NOT_INT
+#  undef  CONFIG_PTR_IS_NOT_INT
+#  define CONFIG_HAVE_FLOAT 1
+#  undef  CONFIG_HAVE_DOUBLE
+#  undef  CONFIG_HAVE_LONG_DOUBLE

Review Comment:
long double should be supported, I just enabled the flags which I 
interested in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257196601

   When you test with stm32f4, if the test passes, it will be a good idea to 
compare defconfig and see if there are any differences that give a clue...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


pkarashchenko commented on code in PR #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181#discussion_r979408698


##
include/nuttx/compiler.h:
##
@@ -745,6 +745,69 @@
 
 #  define no_builtin(n)
 
+/* MSVC(Microsoft Visual C++)-specific definitions **/
+
+#elif defined(_MSC_VER)
+
+/* Define these here and allow specific architectures to override as needed */
+
+#  define CONFIG_HAVE_LONG_LONG 1
+
+#  undef  CONFIG_CPP_HAVE_VARARGS
+#  undef  CONFIG_CPP_HAVE_WARNING
+#  undef  CONFIG_HAVE_FUNCTIONNAME
+#  undef  CONFIG_HAVE_FILENAME
+#  undef  CONFIG_HAVE_WEAKFUNCTIONS
+#  define weak_alias(name, aliasname)
+#  define weak_data
+#  define weak_function
+#  define weak_const_function
+#  define restrict
+#  define noreturn_function
+#  define farcall_function
+#  define aligned_data(n)
+#  define locate_code(n)
+#  define locate_data(n)
+#  define begin_packed_struct
+#  define end_packed_struct
+#  define reentrant_function
+#  define naked_function
+#  define always_inline_function
+#  define noinline_function
+#  define noinstrument_function
+#  define nosanitize_address
+#  define nosanitize_undefined
+#  define nostackprotect_function
+#  define unused_code
+#  define unused_data
+#  define used_code
+#  define used_data
+#  define formatlike(a)
+#  define printflike(a, b)
+#  define sysloglike(a, b)
+#  define scanflike(a, b)
+#  define strftimelike(a)
+
+#  define FAR
+#  define NEAR
+#  define DSEG
+#  define CODE
+#  define IOBJ
+#  define IPTR
+
+#  undef  CONFIG_SMALL_MEMORY
+#  undef  CONFIG_LONG_IS_NOT_INT
+#  undef  CONFIG_PTR_IS_NOT_INT
+#  define CONFIG_HAVE_FLOAT 1
+#  undef  CONFIG_HAVE_DOUBLE
+#  undef  CONFIG_HAVE_LONG_DOUBLE

Review Comment:
   So MSC does not have long double?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257196243

   Sadly, no joy with `tm4c129e-launchpad:ostest` (+ 
`CONFIG_PRIORITY_INHERITANCE=y` added manually) either.
   
   Although `b-g474e-dpow1` is STM32 and `tm4c129e-launchpad` is Tiva, they are 
both armv7-m. However, they seem to be crashing in different parts of the test.
   
   I am beginning to wonder if the problem is not in priority inheritance, but 
in something else that is manifested because of conditions created in the 
priority inheritance test.
   
   Below is the log.
   
   ```
   user_main: priority inheritance test
   priority_inheritance: Started
   priority_inheritance: Starting lowpri_thread-1 (of 3) at 1
   priority_inheritance: Set lowpri_thread-1 priority to 1
   priority_inheritance: Starting lowpri_thread-2 (of 3) at 1
   lowpri_thread-1: Started
   priority_inheritance: Set lowpri_thread-2 priority to 1
   lowpri_thread-1: initial priority: 1
   priority_inheritance: Starting lowpri_thread-3 (of 3) at 1
   lowpri_thread-2: Started
   priority_inheritance: Set lowpri_thread-3 priority to 1
   lowpri_thread-1: Waiting for the midle pri task to run
   priority_inheritance: Waiting...
   lowpri_thread-2: initial priority: 1
   lowpri_thread-3: Started
   g_middlestate:  0
   lowpri_thread-2: Waiting for the midle pri task to run
   lowpri_thread-3: initial priority: 1
   g_highstate[0]: 0
   g_middlestate:  0
   lowpri_thread-3: Waiting for the midle pri task to run
   I still have a count on the semaphore
   g_highstate[0]: 0
   g_middlestate:  0
   I still have a count on the semaphore
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-1: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-2: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-3: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   priority_inheritance: Starting medpri_thread at 99
   priority_inheritance: Set medpri_thread priority to 99
   priority_inheritance: Waiting...
   medpri_thread: Started ... I won't let go of the CPU!
   priority_inheritance: Starting highpri_thread-1 (of 1) at 255
   priority_inheritance: Set highpri_thread-1 priority to 255
   highpri_thread-1: Started
   priority_inheritance: Waiting for highpri_thread-1 to complete
   highpri_thread-1: Calling sem_wait()
   lowpri_thread-3: Sem count: -1, No. highpri thread: 1
   highpri_thread-1: SUCCESS midpri_thread is still running!
   highpri_thread-1: Okay... I'm done!
   priority_inheritance: Waiting for medpri_thread to complete
   medpri_thread: Okay... I'm done!
   priority_inheritance: Waiting for lowpri_thread-1 to complete
   lowpri_thread-2: Sem count: 1, No. highpri thread: 0
   lowpri_thread-2: SUCCESS the middle priority task has already exitted!
  g_middlestate:  3 sem count=1
  g_highstate[0]: 3
   lowpri_thread-2: SUCCESS priority before sem_post: 1
   lowpri_thread-1: Sem count: 2, No. highpri thread: 0
   lowpri_thread-3: SUCCESS priority before sem_post: 255
   lowpri_thread-2: SUCCESS final priority: 1
   lowpri_thread-1: SUCCESS the middle priority task has already exitted!
   lowpri_thread-3: SUCCESS final priority: 1
   lowpri_thread-2: Okay... I'm done!
  g_middlestate:  3 sem count=2
   lowpri_thread-3: Okay... I'm done!
  g_highstate[0]: 3
   lowpri_thread-1: SUCCESS priority before sem_post: 1
   lowpri_thread-1: SUCCESS final priority: 1
   lowpri_thread-1: Okay... I'm done!
   priority_inheritance: Waiting for lowpri_thread-2 to complete
   priority_inheritance: Waiting for lowpri_thread-3 to complete
   priority_inheritance: Restoraup_assert: Assertion failed at 
file:assert/lib_sta0
   arm_registerdump: R0:  R1: 2000876c R2: 000466a4  R3: 2000876c
   arm_registerdump: R4:  R5:  R6:   FP: 200114b0
   arm_registerdump: R8:  SB:  SL:  R11: 
   arm_registerdump: IP:  SP: 20011478 LR: 000169bf  PC: 0001698c
   arm_registerdump: xPSR: 6100 PRIMASK:  CONTROL: 
   arm_registerdump: EXC_RETURN: fff9
   arm_dump_stack: User Stack:
   arm_dump_stack: sp: 200114b0
   arm_dump_stack:   base: 20011260
   arm_dump_stack:   size: 03c0
   arm_stackdump: 200114a0: 000100c2 00016419 0001  200114c0 
20012bb0 4
   arm_stackdump: 200114c0:  0001650d 0039 20012c30 0039 
000466a8 4
   arm_stackdump: 200114e0: fff5 00011c37 0039 000466a8 0001 
000466a4 3
   arm_stackdump: 20011500: deadbeef 000466a4  0002a113  
20011594 0
   arm_stackdump: 20011520: 2001 

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1321: libuv: Fix queue.h conflict with nuttx verson

2022-09-25 Thread GitBox


pkarashchenko commented on PR #1321:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1321#issuecomment-1257196138

   What about my comment in https://github.com/apache/incubator-nuttx/pull/6987 
? Maybe we can move nuttx specific queue.h instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


pkarashchenko commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257195775

   I use default. Unfortunately I do not have the same bord as you. I just got 
stm32f4 based board, but need to solder UART pins. Will test with that board on 
upcoming week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257190965

   By the way, how many `CONFIG_SEM_PREALLOCHOLDERS` "Number of pre-allocated 
holders" are you using? (I used the default of 8.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257190633

   No joy. :-(
   
   This still gets a hardfault on `b-g474e-dpow1:ostest` 
(`CONFIG_PRIORITY_INHERITANCE=y` needs to be enabled manually).
   
   Log:
   
   ```
   user_main: priority inheritance test
   priority_inheritance: Started
   priority_inheritance: Starting lowpri_thread-1 (of 3) at 1
   priority_inheritance: Set lowpri_thread-1 priority to 1
   priority_inheritance: Starting lowpri_thread-2 (of 3) at 1
   lowpri_thread-1: Started
   priority_inheritance: Set lowpri_thread-2 priority to 1
   lowpri_thread-1: initial priority: 1
   priority_inheritance: Starting lowpri_thread-3 (of 3) at 1
   lowpri_thread-2: Started
   priority_inheritance: Set lowpri_thread-3 priority to 1
   lowpri_thread-1: Waiting for the midle pri task to run
   priority_inheritance: Waiting...
   lowpri_thread-2: initial priority: 1
   lowpri_thread-3: Started
   g_middlestate:  0
   lowpri_thread-2: Waiting for the midle pri task to run
   lowpri_thread-3: initial priority: 1
   g_highstate[0]: 0
   g_middlestate:  0
   lowpri_thread-3: Waiting for the midle pri task to run
   I still have a count on the semaphore
   g_highstate[0]: 0
   g_middlestate:  0
   I still have a count on the semaphore
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-1: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-2: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   lowpri_thread-3: Waiting for the midle pri task to run
   g_middlestate:  0
   g_highstate[0]: 0
   I still have a count on the semaphore
   priority_inheritance: Starting medpri_thread at 99
   priority_inheritance: Set medpri_thread priority to 99
   priority_inheritance: Waiting...
   medpri_thread: Started ... I won't let go of the CPU!
   priority_inheritance: Starting highpri_thread-1 (of 1) at 255
   priority_inheritance: Set highpri_thread-1 priority to 255
   highpri_thread-1: Started
   priority_inheritance: Waiting for highpri_thread-1 to complete
   highpri_thread-1: Calling sem_wait()
   lowpri_thread-3: Sem count: -1, No. highpri thread: 1
   highpri_thread-1: SUCCESS midpri_thread is still running!
   highpri_thread-1: Okay... I'm done!
   priority_inheritance: Waiting for medpri_thread to complete
   medpri_thread: Okay... I'm done!
   priority_inheritance: Waiting for lowpri_thread-1 to complete
   lowpri_thread-2: Sem count: 1, No. highpri thread: 0
   lowpri_thread-2: SUCCESS the middle priority task has already exitted!
  g_middlestate:  3 sem count=1
  g_highstate[0]: 3
   lowpri_thread-1: Sem count: 1, No. highpri thread: 0
   lowpri_thread-3: SUCCESS priority before sem_post: 255
   lowpri_thread-2: SUCCESS priority before sem_post: 1
   lowpri_thread-1: SUCCESS the middle priority task has already exitted!
   lowpri_thread-3: SUCCESS final priority: 1
   lowpri_thread-2: SUCCESS final priority: 1
  g_middlestate:  3 sem count=1
   lowpri_thread-3: Okay... I'm done!
   lowpri_thread-2: Okay... I'm done!
  g_highstate[0]: 3
   lowpri_thread-1: SUCCESS priority before sem_post: 1
   lowpri_thread-1: SUCCESS final priority: 1
   lowpri_thread-1: Okay... I'm done!
   priority_inheritance: Waiting for lowpri_thread-2 to complete
   priority_inheritance: Waiting for lowpri_thread-3 to complete
   priority_inheritancpriority_inheritance: Waiting for Task-0 to complete
   priority_inheritance: FF�]�� Started, waiting 0 uS to take count
   priority_inheritance:  Started, waiting 2 uS to take count
   priority_inheritance: Task0 priority was:200 is:220
   priority_inheritance: � Posted
   priority_inheritance: Task0 priority was:220 is:200
   priority_inheritance: Waiting for Task-1 to complete
   up_assert: Assertion failed at file:armv7-m/arm_hardfault.c line: 173 task: 
Tas2
   arm_registerdump: R0: 00e2 R1: 0800310d R2: 0072  R3: 14110800
   arm_registerdump: R4:  R5:  R6:   FP: 
   arm_registerdump: R8:  SB:  SL:  R11: 
   arm_registerdump: IP: 8000 SP: 20008cc8 LR: 08010d77  PC: 080117e0
   arm_registerdump: xPSR: 2100 BASEPRI: 00f0 CONTROL: 
   arm_registerdump: EXC_RETURN: ffe9
   arm_dump_stack: User Stack:
   arm_dump_stack: sp: 20008a88
   arm_dump_stack:   base: 200089d0
   arm_dump_stack:   size: 03c0
   arm_stackdump: 20008a80: 0001 20008a90 20008a88 20008610  
0800a1bd c
   arm_stackdump: 20008aa0: 00ad 08023db4 20008610 08007341 00ad 
08023db4 3
   arm_stackdump: 20008ac0: 40004808  20008bf4 0003 20008704 
8200 1
   arm_stackdump: 20008ae0: 00f0 4000 

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1321: libuv: Fix queue.h conflict with nuttx verson

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #1321:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1321#issuecomment-1257189289

   @pkarashchenko it's pass ci now, could you merge this patch to unblock 
https://github.com/apache/incubator-nuttx/pull/6987 and 
https://github.com/apache/incubator-nuttx/pull/6318.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-09-25 Thread GitBox


hartmannathan commented on PR #6318:
URL: https://github.com/apache/incubator-nuttx/pull/6318#issuecomment-1257186809

   Checking right now...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] anchao opened a new pull request, #7182: sim/windows: add more net configs

2022-09-25 Thread GitBox


anchao opened a new pull request, #7182:
URL: https://github.com/apache/incubator-nuttx/pull/7182

   ## Summary
   
   sim/windows: add more net configs
   
   
   
![img_v2_dd34a4b3-c263-4c32-b95f-9eeed7e0c62l](https://user-images.githubusercontent.com/758493/192143088-b1015df0-176f-4d7d-ad46-a1460a670ba3.png)
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   cmake + sim/windows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] anchao opened a new pull request, #7181: compiler.h: add MSVC(Microsoft Visual C++)-specific definitions

2022-09-25 Thread GitBox


anchao opened a new pull request, #7181:
URL: https://github.com/apache/incubator-nuttx/pull/7181

   
   ## Summary
   
   compiler.h: add MSVC(Microsoft Visual C++)-specific definitions
   
   Signed-off-by: chao an 
   
   ## Impact
   
   N/A
   
   ## Testing
   
   cmake + sim/windows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1321: libuv: Fix queue.h conflict with nuttx verson

2022-09-25 Thread GitBox


xiaoxiang781216 commented on PR #1321:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1321#issuecomment-1257169222

   > @xiaoxiang781216 I think that you need to generate patch with 
`--no-renames` option to get `patch` correctly interpreted on MAC
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6987: nuttx/sched: semaphore and mqueue task list optimize

2022-09-25 Thread GitBox


pkarashchenko commented on PR #6987:
URL: https://github.com/apache/incubator-nuttx/pull/6987#issuecomment-1257133925

   > @pkarashchenko the break is fixed here 
https://github.com/apache/incubator-nuttx-apps/pull/1321
   
   @xiaoxiang781216 let's better move `include/queue.h` to 
`include/nuttx/queue.h`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org