[GitHub] [incubator-nuttx] btashton opened a new issue, #7636: CI: MacOS tool cache is broken leading to longer build times
btashton opened a new issue, #7636: URL: https://github.com/apache/incubator-nuttx/issues/7636 It appears that at some point we broke the cache of the CI tools for MacOS which means we are likely rebuilding them more.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: netutils/iperf: add support of multi-instance
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 60dc92070 netutils/iperf: add support of multi-instance
60dc92070 is described below
commit 60dc9207012a0fcbcf84345ccfff5005dc441d1e
Author: chao an
AuthorDate: Sun Nov 20 18:23:45 2022 +0800
netutils/iperf: add support of multi-instance
Signed-off-by: chao an
---
netutils/iperf/iperf.c | 289 +++-
netutils/iperf/iperf.h | 2 +-
netutils/iperf/iperf_main.c | 18 +--
3 files changed, 159 insertions(+), 150 deletions(-)
diff --git a/netutils/iperf/iperf.c b/netutils/iperf/iperf.c
index 042963cfb..aea1b024e 100644
--- a/netutils/iperf/iperf.c
+++ b/netutils/iperf/iperf.c
@@ -42,7 +42,6 @@
#define IPERF_REPORT_TASK_NAME "iperf_report"
#define IPERF_REPORT_TASK_PRIORITY 100
#define IPERF_REPORT_TASK_STACK 4096
-#define IPERF_REPORT_TASK_NAME "iperf_report"
#define IPERF_UDP_TX_LEN (1472)
#define IPERF_UDP_RX_LEN (16 << 10)
@@ -58,11 +57,12 @@
struct iperf_ctrl_t
{
+ FAR struct iperf_ctrl_t *flink;
struct iperf_cfg_t cfg;
bool finish;
uintmax_t total_len;
uint32_t buffer_len;
- uint8_t *buffer;
+ FAR uint8_t *buffer;
uint32_t sockfd;
};
@@ -77,27 +77,27 @@ struct iperf_udp_pkt_t
* Private Data
/
-static bool s_iperf_is_running = false;
-static struct iperf_ctrl_t s_iperf_ctrl;
+static pthread_mutex_t g_iperf_ctrl_mutex = PTHREAD_MUTEX_INITIALIZER;
+static sq_queue_t g_iperf_ctrl_list;
/
* Private Functions Prototypes
/
-inline static bool iperf_is_udp_client(void);
-inline static bool iperf_is_udp_server(void);
-inline static bool iperf_is_tcp_client(void);
-inline static bool iperf_is_tcp_server(void);
+inline static bool iperf_is_udp_client(FAR struct iperf_ctrl_t *ctrl);
+inline static bool iperf_is_udp_server(FAR struct iperf_ctrl_t *ctrl);
+inline static bool iperf_is_tcp_client(FAR struct iperf_ctrl_t *ctrl);
+inline static bool iperf_is_tcp_server(FAR struct iperf_ctrl_t *ctrl);
static int iperf_get_socket_error_code(int sockfd);
-static int iperf_show_socket_error_reason(const char *str, int sockfd);
-static void iperf_report_task(void *arg);
-static int iperf_start_report(void);
-static int iperf_run_tcp_server(void);
-static int iperf_run_udp_server(void);
-static int iperf_run_udp_client(void);
-static int iperf_run_tcp_client(void);
-static void iperf_task_traffic(void *arg);
-static uint32_t iperf_get_buffer_len(void);
+static int iperf_show_socket_error_reason(FAR const char *str, int sockfd);
+static void iperf_report_task(FAR void *arg);
+static int iperf_start_report(FAR struct iperf_ctrl_t *ctrl);
+static int iperf_run_tcp_server(FAR struct iperf_ctrl_t *ctrl);
+static int iperf_run_udp_server(FAR struct iperf_ctrl_t *ctrl);
+static int iperf_run_udp_client(FAR struct iperf_ctrl_t *ctrl);
+static int iperf_run_tcp_client(FAR struct iperf_ctrl_t *ctrl);
+static void iperf_task_traffic(FAR void *arg);
+static uint32_t iperf_get_buffer_len(FAR struct iperf_ctrl_t *ctrl);
/
* Private Functions
@@ -111,10 +111,10 @@ static uint32_t iperf_get_buffer_len(void);
*
/
-inline static bool iperf_is_udp_client(void)
+inline static bool iperf_is_udp_client(FAR struct iperf_ctrl_t *ctrl)
{
- return ((s_iperf_ctrl.cfg.flag & IPERF_FLAG_CLIENT)
- && (s_iperf_ctrl.cfg.flag & IPERF_FLAG_UDP));
+ return ((ctrl->cfg.flag & IPERF_FLAG_CLIENT)
+ && (ctrl->cfg.flag & IPERF_FLAG_UDP));
}
/
@@ -125,10 +125,10 @@ inline static bool iperf_is_udp_client(void)
*
/
-inline static bool iperf_is_udp_server(void)
+inline static bool iperf_is_udp_server(FAR struct iperf_ctrl_t *ctrl)
{
- return ((s_iperf_ctrl.cfg.flag & IPERF_FLAG_SERVER)
- && (s_iperf_ctrl.cfg.flag & IPERF_FLAG_UDP));
+ return ((ctrl->cfg.flag & IPERF_FLAG_SERVER)
+ && (ctrl->cfg.flag & IPERF_FLAG_UDP));
}
/
@@ -139,10 +139,10 @@ inline static bool iperf_is_udp_server(void)
*
/
-inline static bool iperf_is_tcp_client(void)
+inline static bool iperf_is_tcp_client(FAR struct iperf_ctrl_t
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1432: netutils/iperf: add support of multi-instance
pkarashchenko merged PR #1432: URL: https://github.com/apache/incubator-nuttx-apps/pull/1432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo commented on a diff in pull request #7634: drivers/segger: make RTT_MODE configurable
XuNeo commented on code in PR #7634: URL: https://github.com/apache/incubator-nuttx/pull/7634#discussion_r1027671457 ## drivers/segger/Kconfig: ## @@ -62,6 +62,21 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN ---help--- Size of the buffer for terminal input to target from host (Usually keyboard input) +choice + prompt "SEGGER_RTT_MODE" + default SEGGER_RTT_MODE_NO_BLOCK_SKIP Review Comment: The default option in SEGGER_RTT.c is set to SEGGER_RTT_MODE_NO_BLOCK_SKIP. If default to block mode, the board will stuck when debugger disconnected, so we have to build the code again with non-block mode when test on field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #1435: CI: Update worker base OS versions
btashton commented on PR #1435: URL: https://github.com/apache/incubator-nuttx-apps/pull/1435#issuecomment-1321580970 I have rebased. https://github.com/apache/incubator-nuttx/pull/7632 looks like it should pass now, that will still have to merge prior to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7634: drivers/segger: make RTT_MODE configurable
xiaoxiang781216 commented on code in PR #7634: URL: https://github.com/apache/incubator-nuttx/pull/7634#discussion_r1027663970 ## drivers/segger/Kconfig: ## @@ -62,6 +62,21 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN ---help--- Size of the buffer for terminal input to target from host (Usually keyboard input) +choice + prompt "SEGGER_RTT_MODE" + default SEGGER_RTT_MODE_NO_BLOCK_SKIP Review Comment: should we default to SEGGER_RTT_MODE_BLOCK_IF_FIFO_FULL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7635: net/tcp: TCP_WAITALL should use state flag
anchao opened a new pull request, #7635: URL: https://github.com/apache/incubator-nuttx/pull/7635 ## Summary net/tcp: TCP_WAITALL should use state flag The feature of MSG_WAITALL is broken since the wrong flag is used Signed-off-by: chao an ## Impact N/A ## Testing recv with flag MSG_WAITALL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo opened a new pull request, #7634: drivers/segger: make RTT_MODE configurable
XuNeo opened a new pull request, #7634: URL: https://github.com/apache/incubator-nuttx/pull/7634 Configure segger RTT_MODE through Kconfig ## Summary Change default RTT_MODE to NO_BLOCK_SKIP, so code can run without debugger connected. ## Impact Default mode is changed. ## Testing Tested with stm32f1, syslog works as usual. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton opened a new pull request, #7633: docs: Include released 10.x and 11.x versions under security policy.
btashton opened a new pull request, #7633: URL: https://github.com/apache/incubator-nuttx/pull/7633 Fixes #7514 Linked page for security questions now lists the 10.x and 11.x releases as supported for fixes and backports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #7624: tools/ci: Remove thttpd related config from the black list
xiaoxiang781216 closed pull request #7624: tools/ci: Remove thttpd related config from the black list URL: https://github.com/apache/incubator-nuttx/pull/7624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] lupyuen commented on pull request #7630: arch/arm64: Add support for Generic Interrupt Controller Version 2
lupyuen commented on PR #7630: URL: https://github.com/apache/incubator-nuttx/pull/7630#issuecomment-1321494883 Thank you so much Brennan and Xiao Xiang, NuttX is finally ready for PinePhone! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7630: arch/arm64: Add support for Generic Interrupt Controller Version 2
btashton commented on PR #7630: URL: https://github.com/apache/incubator-nuttx/pull/7630#issuecomment-1321493867 Thank you @lupyuen for the detailed verification comments on the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: arch/arm64: Add support for Generic Interrupt Controller Version 2
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6aba739f05 arch/arm64: Add support for Generic Interrupt Controller
Version 2
6aba739f05 is described below
commit 6aba739f0542993635aabf7716a60972bf099076
Author: Lee Lup Yuen
AuthorDate: Wed Nov 16 15:29:43 2022 +0800
arch/arm64: Add support for Generic Interrupt Controller Version 2
Currently NuttX on Arm64 supports Generic Interrupt Controller (GIC)
Versions 3 and 4:
[`arm64_gicv3.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c),
[`arm64_gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm64/src/common/arm64_gic.h).
This PR adds support for GIC Version 2, which is needed by [Pine64
PinePhone](https://lupyuen.github.io/articles/interrupt) based on Allwinner A64
SoC.
This 64-bit implementation of GIC v2 is mostly identical to the existing
GIC v2 for 32-bit Armv7-A
([`armv7-a/arm_gicv2.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_gicv2.c),
[`armv7-a/gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/gic.h)),
with minor modifications to support 64-bit Registers (Interrupt Context).
- `arch/arm64/Kconfig`: Under "ARM64 Options", we added an integer option
`ARM_GIC_VERSION` ("GIC version") that selects the GIC Version. Valid values
are 2, 3 and 4, default is 3.
- `arch/arm64/src/common/arm64_gicv2.c`: Implements 64-bit GIC v2 based
on 32-bit
[`armv7-a/arm_gicv2.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_gicv2.c)
and
[`armv7-a/gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/gic.h),
modified to support 64-bit Registers (Interrupt Context).
Function and Macro Names have not been changed, for easier
cross-referencing between the 32-bit and 64-bit implementations of GIC v2.
- `arch/arm64/src/common/arm64_gicv3.c`: Added Conditional Compilation
for GIC v3. This file will not be compiled if `ARM_GIC_VERSION` is 2.
- `arch/arm64/src/common/arm64_gic.h`: Added the Version Identifier for
GIC v2. At startup we read the GIC Version from hardware and verify that it
matches `ARM_GIC_VERSION`.
- `arch/arm64/include/qemu/chip.h`: Added the QEMU Base Addresses for GIC
v2.
- `arch/arm64/src/common/Make.defs`: Added the source file that
implements GIC v2.
- `boards/arm64/qemu/qemu-armv8a/README.txt`: Added the documentation for
testing GIC v2 with QEMU.
- `boards/arm64/qemu/qemu-armv8a/configs/nsh_gicv2/defconfig`: Added the
Board Configuration `qemu-armv8a:nsh_gicv2` for testing GIC v2 with QEMU.
Identical to `qemu-armv8a:nsh`, except that `ARM_GIC_VERSION` is 2.
---
arch/arm64/Kconfig |8 +
arch/arm64/include/qemu/chip.h | 13 +
arch/arm64/src/common/Make.defs|2 +-
arch/arm64/src/common/arm64_gic.h |1 +
arch/arm64/src/common/arm64_gicv2.c| 1389
arch/arm64/src/common/arm64_gicv3.c|4 +
boards/arm64/qemu/qemu-armv8a/README.txt | 21 +-
.../qemu/qemu-armv8a/configs/nsh_gicv2/defconfig | 66 +
8 files changed, 1500 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 483f3f6073..cb74385bf4 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -95,6 +95,14 @@ config ARM_HAVE_NEON
---help---
Decide whether support NEON instruction
+config ARM_GIC_VERSION
+ int "GIC version"
+ default 3
+ range 2 4
+ ---help---
+ Version of Generic Interrupt Controller (GIC) supported by the
+ architecture
+
if ARCH_CHIP_QEMU
source "arch/arm64/src/qemu/Kconfig"
endif
diff --git a/arch/arm64/include/qemu/chip.h b/arch/arm64/include/qemu/chip.h
index 745876852b..6b6cae7521 100644
--- a/arch/arm64/include/qemu/chip.h
+++ b/arch/arm64/include/qemu/chip.h
@@ -35,9 +35,22 @@
#if defined(CONFIG_ARCH_CHIP_QEMU)
+#if CONFIG_ARM_GIC_VERSION == 2
+
+#define CONFIG_GICD_BASE 0x800
+#define CONFIG_GICR_BASE 0x801
+
+#elif CONFIG_ARM_GIC_VERSION == 3 || CONFIG_ARM_GIC_VERSION == 4
+
#define CONFIG_GICD_BASE 0x800
#define CONFIG_GICR_BASE 0x80a
+#else
+
+#error CONFIG_ARM_GIC_VERSION should be 2, 3 or 4
+
+#endif /* CONFIG_ARM_GIC_VERSION */
+
#define CONFIG_RAMBANK1_ADDR 0x4000
#define CONFIG_RAMBANK1_SIZE MB(128)
diff --git a/arch/arm64/src/common/Make.defs b/arch/arm64/src/common/Make.defs
index 4e4b1a3a76..515b85f793 100644
--- a/arch/arm64/src/common/Make.defs
+++
[GitHub] [incubator-nuttx] btashton merged pull request #7630: arch/arm64: Add support for Generic Interrupt Controller Version 2
btashton merged PR #7630: URL: https://github.com/apache/incubator-nuttx/pull/7630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #1435: CI: Update worker base OS versions
btashton commented on PR #1435: URL: https://github.com/apache/incubator-nuttx-apps/pull/1435#issuecomment-1321490807 Will rebase when [this](https://github.com/apache/incubator-nuttx/pull/7632) merges. Need to update Bloaty in ci script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: net/arp: Make NET_ARP(Address Resolution Protocol) configurable
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ce1c945136 net/arp: Make NET_ARP(Address Resolution Protocol) configurable ce1c945136 is described below commit ce1c945136e7067e217837b186d1ae36daa35c87 Author: chao an AuthorDate: Mon Nov 21 11:22:54 2022 +0800 net/arp: Make NET_ARP(Address Resolution Protocol) configurable Some boards that use USRSOCK will not need this feature Signed-off-by: chao an --- net/arp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/arp/Kconfig b/net/arp/Kconfig index 540e4b0c87..dd5e5ea7e0 100644 --- a/net/arp/Kconfig +++ b/net/arp/Kconfig @@ -6,7 +6,7 @@ menu "ARP Configuration" config NET_ARP - bool + bool "Address Resolution Protocol" default y depends on NET_ETHERNET && NET_IPv4 ---help---
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7631: net/arp: Make NET_ARP(Address Resolution Protocol) configurable
xiaoxiang781216 merged PR #7631: URL: https://github.com/apache/incubator-nuttx/pull/7631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1435: CI: Update worker base OS versions
xiaoxiang781216 commented on PR #1435: URL: https://github.com/apache/incubator-nuttx-apps/pull/1435#issuecomment-1321481062 @btashton please rebase your change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1433: system/vi: fix nxstyle warning
xiaoxiang781216 merged PR #1433: URL: https://github.com/apache/incubator-nuttx-apps/pull/1433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: system/vi: fix nxstyle warning
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8edfe8818 system/vi: fix nxstyle warning 8edfe8818 is described below commit 8edfe88187e9526c6b57cde465dc4d64a7b194b3 Author: chao an AuthorDate: Sun Nov 20 19:04:17 2022 +0800 system/vi: fix nxstyle warning system/vi/vi.c:540:57: error: Multiple data definitions system/vi/vi.c:541:54: error: Multiple data definitions Signed-off-by: chao an --- system/vi/vi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/vi/vi.c b/system/vi/vi.c index 0b23da4fb..eb89307c9 100644 --- a/system/vi/vi.c +++ b/system/vi/vi.c @@ -537,8 +537,8 @@ static const char g_fmtmodified[] = "No write since last change (add ! to override)"; static const char g_fmtnotvalid[] = "Command not valid"; static const char g_fmtnotcmd[] = "Not an editor command: %s"; -static const char g_fmtsrcbot[] = "search hit BOTTOM, continuing at TOP"; -static const char g_fmtsrctop[] = "search hit TOP, continuing at BOTTOM"; +static const char g_fmtsrcbot[] = "search hit BOTTOM(continuing at TOP)"; +static const char g_fmtsrctop[] = "search hit TOP(continuing at BOTTOM)"; static const char g_fmtinsert[] = "--INSERT--"; /
[GitHub] [incubator-nuttx-apps] btashton opened a new pull request, #1435: CI: Update worker base OS versions
btashton opened a new pull request, #1435: URL: https://github.com/apache/incubator-nuttx-apps/pull/1435 ## Summary Update base OS versions: Linux * Only the check job is updated from Ubuntu 18.04 [deprecated] to "latest" (20.04). Others were already on "latest" which is Ubuntu 20.04 MacOS * Update from macOS Catalina 10.15 [deprecated] to macOS Monterey 12 ## Impact Builds are moved off deprecated runner images. The Linux build itself should not change as it was already running in a container with a pinned version. ## Testing Passing CI provides coverage for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton opened a new pull request, #7632: CI: Update worker base OS versions
btashton opened a new pull request, #7632: URL: https://github.com/apache/incubator-nuttx/pull/7632 ## Summary Update base OS versions: Linux * Only the check job is updated from Ubuntu 18.04 [deprecated] to "latest" (20.04). Others were already on "latest" which is Ubuntu 20.04 MacOS * Update from macOS Catalina 10.15 [deprecated] to macOS Monterey 12 ## Impact Builds are moved off deprecated runner images. The Linux build itself should not change as it was already running in a container with a pinned version. ## Testing Passing CI provides coverage for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7631: net/arp: Make NET_ARP(Address Resolution Protocol) configurable
anchao opened a new pull request, #7631: URL: https://github.com/apache/incubator-nuttx/pull/7631 ## Summary net/arp: Make NET_ARP(Address Resolution Protocol) configurable Some boards that use USRSOCK will not need this feature Signed-off-by: chao an ## Impact N/A ## Testing ci-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] lupyuen opened a new pull request, #7630: arch/arm64: Add support for Generic Interrupt Controller Version 2
lupyuen opened a new pull request, #7630:
URL: https://github.com/apache/incubator-nuttx/pull/7630
# Summary
Currently NuttX on Arm64 supports Generic Interrupt Controller (GIC)
Versions 3 and 4:
[`arm64_gicv3.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c),
[`arm64_gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm64/src/common/arm64_gic.h).
This PR adds support for GIC Version 2, which is needed by [Pine64
PinePhone](https://lupyuen.github.io/articles/interrupt) based on Allwinner A64
SoC.
This 64-bit implementation of GIC v2 is mostly identical to the existing GIC
v2 for 32-bit Armv7-A
([`armv7-a/arm_gicv2.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_gicv2.c),
[`armv7-a/gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/gic.h)),
with minor modifications to support 64-bit Registers (Interrupt Context).
- `arch/arm64/Kconfig`: Under "ARM64 Options", we added an integer option
`ARM_GIC_VERSION` ("GIC version") that selects the GIC Version. Valid values
are 2, 3 and 4, default is 3.
- `arch/arm64/src/common/arm64_gicv2.c`: Implements 64-bit GIC v2 based on
32-bit
[`armv7-a/arm_gicv2.c`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_gicv2.c)
and
[`armv7-a/gic.h`](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/gic.h),
modified to support 64-bit Registers (Interrupt Context).
Function and Macro Names have not been changed, for easier
cross-referencing between the 32-bit and 64-bit implementations of GIC v2.
- `arch/arm64/src/common/arm64_gicv3.c`: Added Conditional Compilation for
GIC v3. This file will not be compiled if `ARM_GIC_VERSION` is 2.
- `arch/arm64/src/common/arm64_gic.h`: Added the Version Identifier for
GIC v2. At startup we read the GIC Version from hardware and verify that it
matches `ARM_GIC_VERSION`.
- `arch/arm64/include/qemu/chip.h`: Added the QEMU Base Addresses for GIC
v2.
- `arch/arm64/src/common/Make.defs`: Added the source file that implements
GIC v2.
- `boards/arm64/qemu/qemu-armv8a/README.txt`: Added the documentation for
testing GIC v2 with QEMU.
- `boards/arm64/qemu/qemu-armv8a/configs/nsh_gicv2/defconfig`: Added the
Board Configuration `qemu-armv8a:nsh_gicv2` for testing GIC v2 with QEMU.
Identical to `qemu-armv8a:nsh`, except that `ARM_GIC_VERSION` is 2.
# Impact
With this PR, NuttX now supports GIC v2 on Arm64. We select GIC v2 through
the new Board Configuration `qemu-armv8a:nsh_gicv2` (that sets
`ARM_GIC_VERSION` to 2):
```bash
./tools/configure.sh -l qemu-armv8a:nsh_gicv2
```
GIC v2 on Arm64 is needed for the upcoming port of NuttX to [Pine64
PinePhone](https://lupyuen.github.io/articles/interrupt) based on Allwinner A64
SoC.
There is no impact on the existing implementation of GIC v3, as tested below.
# Testing
We tested with QEMU our implementation of GIC v2:
```bash
./tools/configure.sh -l qemu-armv8a:nsh_gicv2
make
qemu-system-aarch64 \
-cpu cortex-a53 \
-nographic \
-machine virt,virtualization=on,gic-version=2 \
-net none \
-chardev stdio,id=con,mux=on \
-serial chardev:con \
-mon chardev=con,mode=readline \
-kernel ./nuttx
```
[(See the NuttX QEMU
Log)](https://gist.github.com/lupyuen/7537da777d728a22ab379b1ef234a2d1)
The [NuttX QEMU
Log](https://gist.github.com/lupyuen/7537da777d728a22ab379b1ef234a2d1) shows
that NuttX responds correctly to UART Input (in NSH). This means that GIC v2
has correctly handled UART Input Interrupts.
For Regression Testing: We tested the existing implementation of GIC v3 for
Single Core:
```bash
./tools/configure.sh -l qemu-armv8a:nsh
make
qemu-system-aarch64 \
-cpu cortex-a53 \
-nographic \
-machine virt,virtualization=on,gic-version=3 \
-net none \
-chardev stdio,id=con,mux=on \
-serial chardev:con \
-mon chardev=con,mode=readline \
-kernel ./nuttx
```
[(See the NuttX QEMU
Log)](https://gist.github.com/lupyuen/dec66bc348092a998772b32993e5ed65)
And we tested GIC v3 for Multiple Cores (SMP):
```bash
./tools/configure.sh -l qemu-armv8a:nsh_smp
make
qemu-system-aarch64 \
-smp 4 \
-cpu cortex-a53 \
-nographic \
-machine virt,virtualization=on,gic-version=3 \
-net none \
-chardev stdio,id=con,mux=on \
-serial chardev:con \
-mon chardev=con,mode=readline \
-kernel ./nuttx
```
[(See the NuttX QEMU
Log)](https://gist.github.com/lupyuen/f8a89a10d6a7503e186b3503dae5e153)
For Single and Multiple Cores, GIC v3 responds correctly to UART Input (in
NSH). This means that GIC v3 has correctly handled UART Input Interrupts.
--
This is
[incubator-nuttx-website] branch asf-site updated: Publishing web: 7e21510459ba6f754fb1da76a14d643b3953b931 docs: 3e1c73f8c9f8f9e6b2ac039d601c4055973e8282
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 1928fb89 Publishing web: 7e21510459ba6f754fb1da76a14d643b3953b931
docs: 3e1c73f8c9f8f9e6b2ac039d601c4055973e8282
1928fb89 is described below
commit 1928fb8934fe7f66248a4dd9c6348232508591f6
Author: Nathan <59230071+hartmannat...@users.noreply.github.com>
AuthorDate: Mon Nov 21 00:13:46 2022 +
Publishing web: 7e21510459ba6f754fb1da76a14d643b3953b931 docs:
3e1c73f8c9f8f9e6b2ac039d601c4055973e8282
---
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
15 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 31346058..eb199386 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 20 November 22 at 00:11
+Last Updated: 21 November 22 at 00:11
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index 7b2d31b1..550c15bf 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index 62bdad2b..e6d43246 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -145,7 +145,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 20 November 22 at 00:11
+Last Updated: 21 November 22 at 00:11
Table of
Contents
diff --git a/content/docs/10.0.1/searchindex.js
b/content/docs/10.0.1/searchindex.js
index 7b2d31b1..550c15bf 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
[incubator-nuttx] 01/10: fs/userfs: destroy nxmutex properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3727de1a93d813febbe3fe25916abb3307947fe4 Author: chao an AuthorDate: Sun Nov 20 21:36:28 2022 +0800 fs/userfs: destroy nxmutex properly Signed-off-by: chao an --- fs/userfs/fs_userfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/userfs/fs_userfs.c b/fs/userfs/fs_userfs.c index 063c3aec30..8dff18f5d4 100644 --- a/fs/userfs/fs_userfs.c +++ b/fs/userfs/fs_userfs.c @@ -1487,6 +1487,7 @@ errout_with_psock: psock_close(>psock); errout_with_alloc: + nxmutex_destroy(>lock); kmm_free(priv); return ret; } @@ -1570,6 +1571,7 @@ static int userfs_unbind(FAR void *handle, FAR struct inode **blkdriver, /* Free resources and return success */ psock_close(>psock); + nxmutex_destroy(>lock); kmm_free(priv); return OK; }
[incubator-nuttx] 07/10: drivers/rpmsg/clk/ioe: destroy nxsem properly
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 07604b3220c54e10841b1004b6992600d3b684bf
Author: chao an
AuthorDate: Sun Nov 20 22:07:15 2022 +0800
drivers/rpmsg/clk/ioe: destroy nxsem properly
Signed-off-by: chao an
---
drivers/clk/clk_rpmsg.c| 17 -
drivers/ioexpander/ioe_rpmsg.c | 17 -
2 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/drivers/clk/clk_rpmsg.c b/drivers/clk/clk_rpmsg.c
index 2918b73399..e0bbc50f35 100644
--- a/drivers/clk/clk_rpmsg.c
+++ b/drivers/clk/clk_rpmsg.c
@@ -485,18 +485,17 @@ static int64_t clk_rpmsg_sendrecv(FAR struct
rpmsg_endpoint *ept,
cookie.result = -EIO;
ret = rpmsg_send_nocopy(ept, msg, len);
- if (ret < 0)
-{
- return ret;
-}
-
- ret = nxsem_wait_uninterruptible();
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
+ ret = nxsem_wait_uninterruptible();
+ if (ret >= 0)
+{
+ ret = cookie.result;
+}
}
- return cookie.result;
+ nxsem_destroy();
+ return ret;
}
static bool clk_rpmsg_server_match(FAR struct rpmsg_device *rdev,
diff --git a/drivers/ioexpander/ioe_rpmsg.c b/drivers/ioexpander/ioe_rpmsg.c
index 8e26fa3060..7507ce6adb 100644
--- a/drivers/ioexpander/ioe_rpmsg.c
+++ b/drivers/ioexpander/ioe_rpmsg.c
@@ -275,18 +275,17 @@ static int ioe_rpmsg_sendrecv(FAR struct rpmsg_endpoint
*ept,
msg->cookie = (uintptr_t)
ret = rpmsg_send(ept, msg, len);
- if (ret < 0)
-{
- return ret;
-}
-
- ret = rpmsg_wait(ept, );
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
+ ret = rpmsg_wait(ept, );
+ if (ret >= 0)
+{
+ ret = cookie.result;
+}
}
- return cookie.result;
+ nxsem_destroy();
+ return ret;
}
static int ioe_rpmsg_direction(FAR struct ioexpander_dev_s *dev, uint8_t pin,
[incubator-nuttx] 04/10: drivers/misc/rpmsgdev: destroy nxmutex properly
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a1abb818a934354289d2b9f6a11d5c0255436bdd
Author: chao an
AuthorDate: Sun Nov 20 21:46:53 2022 +0800
drivers/misc/rpmsgdev: destroy nxmutex properly
---
drivers/misc/rpmsgdev_server.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/rpmsgdev_server.c b/drivers/misc/rpmsgdev_server.c
index 0e5b214849..9df1066830 100644
--- a/drivers/misc/rpmsgdev_server.c
+++ b/drivers/misc/rpmsgdev_server.c
@@ -403,6 +403,7 @@ static void rpmsgdev_ns_bind(FAR struct rpmsg_device *rdev,
rpmsgdev_ept_cb, rpmsgdev_ns_unbind);
if (ret < 0)
{
+ nxmutex_destroy(>lock);
kmm_free(server);
}
}
[incubator-nuttx] 10/10: wireless/bluetooth: destroy nxsem properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3e1c73f8c9f8f9e6b2ac039d601c4055973e8282 Author: chao an AuthorDate: Sun Nov 20 23:16:37 2022 +0800 wireless/bluetooth: destroy nxsem properly --- wireless/bluetooth/bt_hcicore.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wireless/bluetooth/bt_hcicore.c b/wireless/bluetooth/bt_hcicore.c index 9db624715d..55b1d78000 100644 --- a/wireless/bluetooth/bt_hcicore.c +++ b/wireless/bluetooth/bt_hcicore.c @@ -1846,6 +1846,8 @@ int bt_hci_cmd_send_sync(uint16_t opcode, FAR struct bt_buf_s *buf, bt_buf_release(buf->u.hci.sync); } + nxsem_destroy(_sem); + return ret; }
[incubator-nuttx] 02/10: drivers/mtd: destroy nxmutex properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit d256b8334e6c6e7793b6ee91b4a0893f9892d90a Author: chao an AuthorDate: Sun Nov 20 21:43:42 2022 +0800 drivers/mtd: destroy nxmutex properly --- drivers/mtd/rpmsgmtd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/rpmsgmtd.c b/drivers/mtd/rpmsgmtd.c index 7612cb06bf..aeaa83814f 100644 --- a/drivers/mtd/rpmsgmtd.c +++ b/drivers/mtd/rpmsgmtd.c @@ -1109,6 +1109,7 @@ fail_with_rpmsg: fail: nxsem_destroy(>wait); + nxmutex_destroy(>geolock); kmm_free(dev); return ret; }
[incubator-nuttx] 03/10: drivers/loop: destroy nxmutex properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 40581558d3a3064abc3fc3abebb9b7763ad65c22 Author: chao an AuthorDate: Sun Nov 20 21:45:32 2022 +0800 drivers/loop: destroy nxmutex properly --- drivers/loop/losetup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/loop/losetup.c b/drivers/loop/losetup.c index cdc7032915..8ea964b864 100644 --- a/drivers/loop/losetup.c +++ b/drivers/loop/losetup.c @@ -408,6 +408,7 @@ errout_with_file: file_close(>devfile); errout_with_dev: + nxmutex_destroy(>lock); kmm_free(dev); return ret; } @@ -471,6 +472,7 @@ int loteardown(FAR const char *devname) file_close(>devfile); } + nxmutex_destroy(>lock); kmm_free(dev); return ret; }
[incubator-nuttx] 08/10: drivers/regulator_rpmsg: destroy nxsem properly
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit dff81756cf86cb974134e82f713d2fbd609f050b
Author: chao an
AuthorDate: Sun Nov 20 22:28:39 2022 +0800
drivers/regulator_rpmsg: destroy nxsem properly
Signed-off-by: chao an
---
drivers/power/supply/regulator_rpmsg.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/power/supply/regulator_rpmsg.c
b/drivers/power/supply/regulator_rpmsg.c
index 03c2785bd8..ccd4edb0f7 100644
--- a/drivers/power/supply/regulator_rpmsg.c
+++ b/drivers/power/supply/regulator_rpmsg.c
@@ -495,18 +495,17 @@ static int regulator_rpmsg_sendrecv(FAR struct
rpmsg_endpoint *ept,
msg->cookie = (uintptr_t)
ret = rpmsg_send_nocopy(ept, msg, len);
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
-}
-
- ret = nxsem_wait_uninterruptible();
- if (ret < 0)
-{
- return ret;
+ ret = nxsem_wait_uninterruptible();
+ if (ret >= 0)
+{
+ ret = cookie.result;
+}
}
- return cookie.result;
+ nxsem_destroy();
+ return ret;
}
static int regulator_rpmsg_enable(FAR struct regulator_dev_s *rdev)
[incubator-nuttx] 06/10: drivers/misc/rwbuffer: destroy nxmutex/nxsem properly
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 74cfa7ddb90b622eb3f475fe7ded175518175e87
Author: chao an
AuthorDate: Sun Nov 20 21:58:48 2022 +0800
drivers/misc/rwbuffer: destroy nxmutex/nxsem properly
Signed-off-by: chao an
---
drivers/misc/rwbuffer.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/misc/rwbuffer.c b/drivers/misc/rwbuffer.c
index a1b19760f5..40355e8469 100644
--- a/drivers/misc/rwbuffer.c
+++ b/drivers/misc/rwbuffer.c
@@ -814,6 +814,7 @@ int rwb_initialize(FAR struct rwbuffer_s *rwb)
if (!rwb->wrbuffer)
{
ferr("Write buffer kmm_malloc(%" PRIu32 ") failed\n", allocsize);
+ nxmutex_destroy(>wrlock);
return -ENOMEM;
}
@@ -842,6 +843,19 @@ int rwb_initialize(FAR struct rwbuffer_s *rwb)
{
ferr("Read-ahead buffer kmm_malloc(%" PRIu32 ") failed\n",
allocsize);
+ nxmutex_destroy(>rhlock);
+#ifdef CONFIG_DRVR_WRITEBUFFER
+ if (rwb->wrmaxblocks > 0)
+{
+ nxmutex_destroy(>wrlock);
+}
+
+ if (rwb->wrbuffer != NULL)
+{
+ kmm_free(rwb->wrbuffer);
+}
+#endif
+
return -ENOMEM;
}
[incubator-nuttx] branch master updated (f2320a4a69 -> 3e1c73f8c9)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from f2320a4a69 Fix board/stm32_lcd.c:584:14: error: converting the result of '<<' to a boolean; did you mean '(7 << (10)) != 0'? new 3727de1a93 fs/userfs: destroy nxmutex properly new d256b8334e drivers/mtd: destroy nxmutex properly new 40581558d3 drivers/loop: destroy nxmutex properly new a1abb818a9 drivers/misc/rpmsgdev: destroy nxmutex properly new 4413c5a563 graphics/nxterm: destroy nxmutex/nxsem properly new 74cfa7ddb9 drivers/misc/rwbuffer: destroy nxmutex/nxsem properly new 07604b3220 drivers/rpmsg/clk/ioe: destroy nxsem properly new dff81756cf drivers/regulator_rpmsg: destroy nxsem properly new 873023f89b net/icmp[v6]: destroy nxsem properly new 3e1c73f8c9 wireless/bluetooth: destroy nxsem properly The 10 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: drivers/clk/clk_rpmsg.c| 17 - drivers/ioexpander/ioe_rpmsg.c | 17 - drivers/loop/losetup.c | 2 ++ drivers/misc/rpmsgdev_server.c | 1 + drivers/misc/rwbuffer.c| 14 ++ drivers/mtd/rpmsgmtd.c | 1 + drivers/power/supply/regulator_rpmsg.c | 17 - fs/userfs/fs_userfs.c | 2 ++ graphics/nxterm/nxterm_register.c | 4 net/icmp/icmp_recvmsg.c| 2 ++ net/icmp/icmp_sendmsg.c| 2 ++ net/icmpv6/icmpv6_recvmsg.c| 2 ++ net/icmpv6/icmpv6_sendmsg.c| 2 ++ wireless/bluetooth/bt_hcicore.c| 2 ++ 14 files changed, 58 insertions(+), 27 deletions(-)
[incubator-nuttx] 09/10: net/icmp[v6]: destroy nxsem properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 873023f89b6fd018479c906bf142b5d1456720dd Author: chao an AuthorDate: Sun Nov 20 23:11:18 2022 +0800 net/icmp[v6]: destroy nxsem properly Signed-off-by: chao an --- net/icmp/icmp_recvmsg.c | 2 ++ net/icmp/icmp_sendmsg.c | 2 ++ net/icmpv6/icmpv6_recvmsg.c | 2 ++ net/icmpv6/icmpv6_sendmsg.c | 2 ++ 4 files changed, 8 insertions(+) diff --git a/net/icmp/icmp_recvmsg.c b/net/icmp/icmp_recvmsg.c index 38c56d4ca6..000a5e5bd9 100644 --- a/net/icmp/icmp_recvmsg.c +++ b/net/icmp/icmp_recvmsg.c @@ -449,6 +449,8 @@ ssize_t icmp_recvmsg(FAR struct socket *psock, FAR struct msghdr *msg, icmp_callback_free(dev, conn, state.recv_cb); } + nxsem_destroy(_sem); + /* Return the negated error number in the event of a failure, or the * number of bytes received on success. */ diff --git a/net/icmp/icmp_sendmsg.c b/net/icmp/icmp_sendmsg.c index 4ac4e63117..fb0fc659bf 100644 --- a/net/icmp/icmp_sendmsg.c +++ b/net/icmp/icmp_sendmsg.c @@ -445,6 +445,8 @@ ssize_t icmp_sendmsg(FAR struct socket *psock, FAR struct msghdr *msg, icmp_callback_free(dev, conn, state.snd_cb); } + nxsem_destroy(_sem); + net_unlock(); /* Return the negated error number in the event of a failure, or the diff --git a/net/icmpv6/icmpv6_recvmsg.c b/net/icmpv6/icmpv6_recvmsg.c index 9933f0c02a..9a805586ad 100644 --- a/net/icmpv6/icmpv6_recvmsg.c +++ b/net/icmpv6/icmpv6_recvmsg.c @@ -456,6 +456,8 @@ ssize_t icmpv6_recvmsg(FAR struct socket *psock, FAR struct msghdr *msg, icmpv6_callback_free(dev, conn, state.recv_cb); } + nxsem_destroy(_sem); + /* Return the negated error number in the event of a failure, or the * number of bytes received on success. */ diff --git a/net/icmpv6/icmpv6_sendmsg.c b/net/icmpv6/icmpv6_sendmsg.c index 98c9d2eea0..2e5f2d9943 100644 --- a/net/icmpv6/icmpv6_sendmsg.c +++ b/net/icmpv6/icmpv6_sendmsg.c @@ -426,6 +426,8 @@ ssize_t icmpv6_sendmsg(FAR struct socket *psock, FAR struct msghdr *msg, icmpv6_callback_free(dev, conn, state.snd_cb); } + nxsem_destroy(_sem); + net_unlock(); /* Return the negated error number in the event of a failure, or the
[incubator-nuttx] 05/10: graphics/nxterm: destroy nxmutex/nxsem properly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4413c5a563972aaa06a7562c03db3ad8337f235b Author: chao an AuthorDate: Sun Nov 20 21:49:22 2022 +0800 graphics/nxterm: destroy nxmutex/nxsem properly Signed-off-by: chao an --- graphics/nxterm/nxterm_register.c | 4 1 file changed, 4 insertions(+) diff --git a/graphics/nxterm/nxterm_register.c b/graphics/nxterm/nxterm_register.c index 50676df511..4031783b01 100644 --- a/graphics/nxterm/nxterm_register.c +++ b/graphics/nxterm/nxterm_register.c @@ -143,6 +143,10 @@ FAR struct nxterm_state_s * return (NXTERM)priv; errout: + nxmutex_destroy(>lock); +#ifdef CONFIG_NXTERM_NXKBDIN + nxsem_destroy(>waitsem); +#endif kmm_free(priv); return NULL; }
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7628: fs/userfs: destroy nxmutex properly
xiaoxiang781216 merged PR #7628: URL: https://github.com/apache/incubator-nuttx/pull/7628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: dhcp: Make the option dependence work for usrsock case
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 37c0cdd1a dhcp: Make the option dependence work for usrsock case 37c0cdd1a is described below commit 37c0cdd1a6b79b6c615621cd02d13f17985b8b7a Author: Xiang Xiao AuthorDate: Sun Nov 20 11:13:33 2022 +0800 dhcp: Make the option dependence work for usrsock case Signed-off-by: Xiang Xiao --- netutils/dhcpc/Kconfig | 2 +- netutils/dhcpd/Kconfig | 2 +- system/dhcpc/Kconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/netutils/dhcpc/Kconfig b/netutils/dhcpc/Kconfig index 2862e0ce7..d82b1edf0 100644 --- a/netutils/dhcpc/Kconfig +++ b/netutils/dhcpc/Kconfig @@ -6,7 +6,7 @@ config NETUTILS_DHCPC bool "DHCP client" default n - depends on NET_UDP && NET_BROADCAST && NET_IPv4 + depends on NET_UDP select NET_BINDTODEVICE if !NET_UDP_NO_STACK ---help--- Enable support for the DHCP client. diff --git a/netutils/dhcpd/Kconfig b/netutils/dhcpd/Kconfig index c595b079a..0c1d0b24a 100644 --- a/netutils/dhcpd/Kconfig +++ b/netutils/dhcpd/Kconfig @@ -6,7 +6,7 @@ config NETUTILS_DHCPD bool "DHCP server" default n - depends on NET_UDP && NET_IPv4 + depends on NET_UDP ---help--- Enable support for the DHCP server. diff --git a/system/dhcpc/Kconfig b/system/dhcpc/Kconfig index f6794344d..bac4d3881 100644 --- a/system/dhcpc/Kconfig +++ b/system/dhcpc/Kconfig @@ -7,7 +7,7 @@ config SYSTEM_DHCPC_RENEW tristate "DHCP Address Renewal" default n select NETUTILS_DHCPC - depends on NET_UDP && NET_BROADCAST && NET_IPv4 && NET_ETHERNET + depends on NET_UDP ---help--- Enable the DHCP client 'renew' command
[GitHub] [incubator-nuttx-apps] anchao merged pull request #1434: dhcp: Make the option dependence work for usrsock case
anchao merged PR #1434: URL: https://github.com/apache/incubator-nuttx-apps/pull/1434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7628: fs/userfs: destroy nxmutex properly
anchao commented on code in PR #7628:
URL: https://github.com/apache/incubator-nuttx/pull/7628#discussion_r102733
##
drivers/clk/clk_rpmsg.c:
##
@@ -485,18 +485,17 @@ static int64_t clk_rpmsg_sendrecv(FAR struct
rpmsg_endpoint *ept,
cookie.result = -EIO;
ret = rpmsg_send_nocopy(ept, msg, len);
- if (ret < 0)
-{
- return ret;
-}
-
- ret = nxsem_wait_uninterruptible();
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
+ ret = nxsem_wait_uninterruptible();
+ if (ret == 0)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7627: Refine net/usrsock Kconfig option
xiaoxiang781216 commented on code in PR #7627:
URL: https://github.com/apache/incubator-nuttx/pull/7627#discussion_r1027310878
##
net/usrsock/usrsock_sockif.c:
##
@@ -98,43 +98,6 @@ static int usrsock_sockif_setup(FAR struct socket *psock,
int protocol)
int type = psock->s_type;
int ret;
-#ifdef CONFIG_NET_USRSOCK_NO_INET
- if (domain == PF_INET)
-{
- return -ENETDOWN;
-}
-#endif
-
-#ifdef CONFIG_NET_USRSOCK_NO_INET6
- if (domain == PF_INET6)
-{
- return -ENETDOWN;
-}
-#endif
Review Comment:
The option is removed since other side need always check whether the domain
is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7628: fs/userfs: destroy nxmutex properly
xiaoxiang781216 commented on code in PR #7628:
URL: https://github.com/apache/incubator-nuttx/pull/7628#discussion_r1027310175
##
drivers/ioexpander/ioe_rpmsg.c:
##
@@ -275,18 +275,17 @@ static int ioe_rpmsg_sendrecv(FAR struct rpmsg_endpoint
*ept,
msg->cookie = (uintptr_t)
ret = rpmsg_send(ept, msg, len);
- if (ret < 0)
-{
- return ret;
-}
-
- ret = rpmsg_wait(ept, );
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
+ ret = rpmsg_wait(ept, );
+ if (ret == 0)
Review Comment:
```suggestion
if (ret >= 0)
```
##
drivers/clk/clk_rpmsg.c:
##
@@ -485,18 +485,17 @@ static int64_t clk_rpmsg_sendrecv(FAR struct
rpmsg_endpoint *ept,
cookie.result = -EIO;
ret = rpmsg_send_nocopy(ept, msg, len);
- if (ret < 0)
-{
- return ret;
-}
-
- ret = nxsem_wait_uninterruptible();
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
+ ret = nxsem_wait_uninterruptible();
+ if (ret == 0)
Review Comment:
```suggestion
if (ret >= 0)
```
##
drivers/power/supply/regulator_rpmsg.c:
##
@@ -495,18 +495,17 @@ static int regulator_rpmsg_sendrecv(FAR struct
rpmsg_endpoint *ept,
msg->cookie = (uintptr_t)
ret = rpmsg_send_nocopy(ept, msg, len);
- if (ret < 0)
+ if (ret >= 0)
{
- return ret;
-}
-
- ret = nxsem_wait_uninterruptible();
- if (ret < 0)
-{
- return ret;
+ ret = nxsem_wait_uninterruptible();
+ if (ret == 0)
Review Comment:
```suggestion
if (ret >= 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7629: Fix the clang warning
xiaoxiang781216 opened a new pull request, #7629: URL: https://github.com/apache/incubator-nuttx/pull/7629 ## Summary Found by https://github.com/apache/incubator-nuttx/pull/7391 ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao commented on a diff in pull request #1432: netutils/iperf: add support of multi-instance
anchao commented on code in PR #1432:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1432#discussion_r1027301274
##
netutils/iperf/iperf.c:
##
@@ -740,54 +744,58 @@ static uint32_t iperf_get_buffer_len(void)
*
/
-int iperf_start(struct iperf_cfg_t *cfg)
+int iperf_start(FAR struct iperf_cfg_t *cfg)
{
- int ret;
- void *retval;
+ struct iperf_ctrl_t ctrl;
struct sched_param param;
- pthread_t thread;
pthread_attr_t attr;
+ pthread_t thread;
+ FAR void *retval;
+ int ret;
if (!cfg)
{
return -1;
}
- if (s_iperf_is_running)
-{
- printf("iperf is running\n");
- return -1;
-}
-
- memset(_iperf_ctrl, 0, sizeof(s_iperf_ctrl));
- memcpy(_iperf_ctrl.cfg, cfg, sizeof(*cfg));
- s_iperf_is_running = true;
- s_iperf_ctrl.finish = false;
- s_iperf_ctrl.buffer_len = iperf_get_buffer_len();
- s_iperf_ctrl.buffer = (uint8_t *)malloc(s_iperf_ctrl.buffer_len);
- if (!s_iperf_ctrl.buffer)
+ memset(, 0, sizeof(ctrl));
+ memcpy(, cfg, sizeof(*cfg));
+ ctrl.is_running = true;
+ ctrl.finish = false;
+ ctrl.buffer_len = iperf_get_buffer_len();
+ ctrl.buffer = (FAR uint8_t *)malloc(ctrl.buffer_len);
+ if (!ctrl.buffer)
Review Comment:
Done, Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7628: fs/userfs: destroy nxmutex properly
anchao commented on code in PR #7628:
URL: https://github.com/apache/incubator-nuttx/pull/7628#discussion_r1027300737
##
drivers/misc/rwbuffer.c:
##
@@ -842,6 +843,19 @@ int rwb_initialize(FAR struct rwbuffer_s *rwb)
{
ferr("Read-ahead buffer kmm_malloc(%" PRIu32 ") failed\n",
allocsize);
+ nxmutex_destroy(>rhlock);
+#ifdef CONFIG_DRVR_WRITEBUFFER
+ if (rwb->wrmaxblocks > 0)
+{
+ nxmutex_destroy(>wrlock);
+}
+
+ if (rwb->wrbuffer)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7628: fs/userfs: destroy nxmutex properly
pkarashchenko commented on code in PR #7628:
URL: https://github.com/apache/incubator-nuttx/pull/7628#discussion_r1027300392
##
drivers/misc/rwbuffer.c:
##
@@ -842,6 +843,19 @@ int rwb_initialize(FAR struct rwbuffer_s *rwb)
{
ferr("Read-ahead buffer kmm_malloc(%" PRIu32 ") failed\n",
allocsize);
+ nxmutex_destroy(>rhlock);
+#ifdef CONFIG_DRVR_WRITEBUFFER
+ if (rwb->wrmaxblocks > 0)
+{
+ nxmutex_destroy(>wrlock);
+}
+
+ if (rwb->wrbuffer)
Review Comment:
Optional
```suggestion
if (rwb->wrbuffer != NULL)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1432: netutils/iperf: add support of multi-instance
pkarashchenko commented on code in PR #1432:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1432#discussion_r1027294689
##
netutils/iperf/iperf.c:
##
@@ -740,54 +744,58 @@ static uint32_t iperf_get_buffer_len(void)
*
/
-int iperf_start(struct iperf_cfg_t *cfg)
+int iperf_start(FAR struct iperf_cfg_t *cfg)
{
- int ret;
- void *retval;
+ struct iperf_ctrl_t ctrl;
struct sched_param param;
- pthread_t thread;
pthread_attr_t attr;
+ pthread_t thread;
+ FAR void *retval;
+ int ret;
if (!cfg)
{
return -1;
}
- if (s_iperf_is_running)
-{
- printf("iperf is running\n");
- return -1;
-}
-
- memset(_iperf_ctrl, 0, sizeof(s_iperf_ctrl));
- memcpy(_iperf_ctrl.cfg, cfg, sizeof(*cfg));
- s_iperf_is_running = true;
- s_iperf_ctrl.finish = false;
- s_iperf_ctrl.buffer_len = iperf_get_buffer_len();
- s_iperf_ctrl.buffer = (uint8_t *)malloc(s_iperf_ctrl.buffer_len);
- if (!s_iperf_ctrl.buffer)
+ memset(, 0, sizeof(ctrl));
+ memcpy(, cfg, sizeof(*cfg));
+ ctrl.is_running = true;
+ ctrl.finish = false;
+ ctrl.buffer_len = iperf_get_buffer_len();
+ ctrl.buffer = (FAR uint8_t *)malloc(ctrl.buffer_len);
+ if (!ctrl.buffer)
Review Comment:
```suggestion
if (ctrl.buffer == NULL)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7627: Refine net/usrsock Kconfig option
pkarashchenko commented on code in PR #7627:
URL: https://github.com/apache/incubator-nuttx/pull/7627#discussion_r1027293792
##
net/usrsock/usrsock_sockif.c:
##
@@ -98,43 +98,6 @@ static int usrsock_sockif_setup(FAR struct socket *psock,
int protocol)
int type = psock->s_type;
int ret;
-#ifdef CONFIG_NET_USRSOCK_NO_INET
- if (domain == PF_INET)
-{
- return -ENETDOWN;
-}
-#endif
-
-#ifdef CONFIG_NET_USRSOCK_NO_INET6
- if (domain == PF_INET6)
-{
- return -ENETDOWN;
-}
-#endif
Review Comment:
Is this now covered by config options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7628: fs/userfs: destroy nxmutex properly
anchao opened a new pull request, #7628: URL: https://github.com/apache/incubator-nuttx/pull/7628 ## Summary fs/userfs: destroy nxmutex properly Signed-off-by: chao an ## Impact N/A ## Testing ci-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 24/26: Fix chip/stm32_eth.c:3358:20: error: unused function 'stm32_selectrmii'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f28cfbf2f3dbb756a97e1ca9831812b7b29db97d
Author: Xiang Xiao
AuthorDate: Sat Nov 19 13:22:34 2022 +0800
Fix chip/stm32_eth.c:3358:20: error: unused function 'stm32_selectrmii'
Signed-off-by: Xiang Xiao
---
arch/arm/src/stm32/stm32_eth.c| 2 ++
arch/arm/src/stm32f7/stm32_ethernet.c | 2 ++
arch/arm/src/stm32h7/stm32_ethernet.c | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/arm/src/stm32/stm32_eth.c b/arch/arm/src/stm32/stm32_eth.c
index e9c38e0628..e50a82d61d 100644
--- a/arch/arm/src/stm32/stm32_eth.c
+++ b/arch/arm/src/stm32/stm32_eth.c
@@ -3355,6 +3355,7 @@ static inline void stm32_selectmii(void)
*
/
+#ifdef CONFIG_STM32_RMII
static inline void stm32_selectrmii(void)
{
uint32_t regval;
@@ -3369,6 +3370,7 @@ static inline void stm32_selectrmii(void)
putreg32(regval, STM32_SYSCFG_PMC);
#endif
}
+#endif
/
* Function: stm32_ethgpioconfig
diff --git a/arch/arm/src/stm32f7/stm32_ethernet.c
b/arch/arm/src/stm32f7/stm32_ethernet.c
index b16c578cc7..c82b703d81 100644
--- a/arch/arm/src/stm32f7/stm32_ethernet.c
+++ b/arch/arm/src/stm32f7/stm32_ethernet.c
@@ -3443,6 +3443,7 @@ static inline void stm32_selectmii(void)
*
/
+#ifdef CONFIG_STM32F7_RMII
static inline void stm32_selectrmii(void)
{
uint32_t regval;
@@ -3451,6 +3452,7 @@ static inline void stm32_selectrmii(void)
regval |= SYSCFG_PMC_MII_RMII_SEL;
putreg32(regval, STM32_SYSCFG_PMC);
}
+#endif
/
* Function: stm32_ethgpioconfig
diff --git a/arch/arm/src/stm32h7/stm32_ethernet.c
b/arch/arm/src/stm32h7/stm32_ethernet.c
index 6ff98cdc63..52524a02cc 100644
--- a/arch/arm/src/stm32h7/stm32_ethernet.c
+++ b/arch/arm/src/stm32h7/stm32_ethernet.c
@@ -3616,6 +3616,7 @@ static inline void stm32_selectmii(void)
*
/
+#ifdef CONFIG_STM32H7_RMII
static inline void stm32_selectrmii(void)
{
uint32_t regval;
@@ -3625,6 +3626,7 @@ static inline void stm32_selectrmii(void)
regval |= SYSCFG_PMC_EPIS_RMII;
putreg32(regval, STM32_SYSCFG_PMC);
}
+#endif
/
* Function: stm32_ethgpioconfig
[incubator-nuttx] 25/26: Fix lcd/ili9225.c:388:46: error: shift count >= width of type
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1a942c3c319afabe19b457cf295c72bb1fa73ecd Author: Xiang Xiao AuthorDate: Sat Nov 19 13:24:26 2022 +0800 Fix lcd/ili9225.c:388:46: error: shift count >= width of type Signed-off-by: Xiang Xiao --- include/nuttx/lcd/ili9225.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/nuttx/lcd/ili9225.h b/include/nuttx/lcd/ili9225.h index 399e5f4e43..e4c158f997 100644 --- a/include/nuttx/lcd/ili9225.h +++ b/include/nuttx/lcd/ili9225.h @@ -223,7 +223,7 @@ #define ILI9225_VCI_REC_VCIR_SHIFT (4) /* Set CVI recycling period */ #define ILI9225_VCI_REC_VCIR_MASK (0x7 << ILI9225_VCI_REC_VCIR_SHIFT) -#define ILI9225_VCI_REC_VCIR(n)(((uint16_t)(n) << ILI9225_VCI_REC_VCIR_MASK) & ILI9225_VCI_REC_VCIR_SHIFT) +#define ILI9225_VCI_REC_VCIR(n)(((uint16_t)(n) << ILI9225_VCI_REC_VCIR_SHIFT) & ILI9225_VCI_REC_VCIR_MASK) /* ILI9225_HORIZONTAL_GRAM_ADDR_SET, * Horizontal GRAM Address Set, Offset: 0x20
[incubator-nuttx] 21/26: Fix error: converting the result of '<<' to a boolean always evaluates to true
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 908bade7a7904f8e7e32fbe3983c2fa0ca2dd24c Author: Xiang Xiao AuthorDate: Sat Nov 19 13:14:03 2022 +0800 Fix error: converting the result of '<<' to a boolean always evaluates to true Signed-off-by: Xiang Xiao --- boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c | 19 +-- boards/arm/stm32/stm32f429i-disco/src/stm32_lcd.c| 17 - 2 files changed, 9 insertions(+), 27 deletions(-) diff --git a/boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c b/boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c index 0b5ae9d488..6f2b9d74d8 100644 --- a/boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c +++ b/boards/arm/stm32/nucleo-l152re/src/stm32_ili93418b.c @@ -70,11 +70,8 @@ * ByPass_Mode: 1 (Memory) */ -#define STM32_ILI9341_IFMODE_PARAM ((!ILI9341_INTERFACE_CONTROL_EPL) | \ -ILI9341_INTERFACE_CONTROL_DPL | \ -(!ILI9341_INTERFACE_CONTROL_HSPL) | \ -(!ILI9341_INTERFACE_CONTROL_VSPL) | \ -ILI9341_INTERFACE_CONTROL_RCM(2) | \ +#define STM32_ILI9341_IFMODE_PARAM (ILI9341_INTERFACE_CONTROL_DPL |\ +ILI9341_INTERFACE_CONTROL_RCM(2) | \ ILI9341_INTERFACE_CONTROL_BPASS) /* Interface control (IFCTL) @@ -87,11 +84,7 @@ * WEMODE: 1 Reset column and page if data transfer exceeds */ -#define STM32_ILI9341_IFCTL_PARAM1 (ILI9341_INTERFACE_CONTROL_WEMODE | \ -!ILI9341_INTERFACE_CONTROL_BGREOR | \ -!ILI9341_INTERFACE_CONTROL_MVEOR | \ -!ILI9341_INTERFACE_CONTROL_MXEOR | \ -!ILI9341_INTERFACE_CONTROL_MYEOR) +#define STM32_ILI9341_IFCTL_PARAM1 (ILI9341_INTERFACE_CONTROL_WEMODE) /* Parameter 2: 0x * @@ -110,10 +103,8 @@ * RIM: 0 18-bit 1 transfer/pixel RGB interface mode * */ -#define STM32_ILI9341_IFCTL_PARAM3 ((!ILI9341_INTERFACE_CONTROL_RIM) | \ -ILI9341_INTERFACE_CONTROL_RM | \ -ILI9341_INTERFACE_CONTROL_DM(1) | \ -(!ILI9341_INTERFACE_CONTROL_ENDIAN)) +#define STM32_ILI9341_IFCTL_PARAM3 (ILI9341_INTERFACE_CONTROL_RM | \ +ILI9341_INTERFACE_CONTROL_DM(1)) /* LCD CONTROL */ diff --git a/boards/arm/stm32/stm32f429i-disco/src/stm32_lcd.c b/boards/arm/stm32/stm32f429i-disco/src/stm32_lcd.c index d84882b089..5820ea759e 100644 --- a/boards/arm/stm32/stm32f429i-disco/src/stm32_lcd.c +++ b/boards/arm/stm32/stm32f429i-disco/src/stm32_lcd.c @@ -79,10 +79,7 @@ * ByPass_Mode: 1 (Memory) */ -#define STM32_ILI9341_IFMODE_PARAM((!ILI9341_INTERFACE_CONTROL_EPL) | \ - ILI9341_INTERFACE_CONTROL_DPL | \ - (!ILI9341_INTERFACE_CONTROL_HSPL) | \ - (!ILI9341_INTERFACE_CONTROL_VSPL) | \ +#define STM32_ILI9341_IFMODE_PARAM(ILI9341_INTERFACE_CONTROL_DPL | \ ILI9341_INTERFACE_CONTROL_RCM(2) | \ ILI9341_INTERFACE_CONTROL_BPASS) @@ -96,11 +93,7 @@ * WEMODE: 1 Reset column and page if data transfer exceeds */ -#define STM32_ILI9341_IFCTL_PARAM1(ILI9341_INTERFACE_CONTROL_WEMODE | \ - !ILI9341_INTERFACE_CONTROL_BGREOR | \ - !ILI9341_INTERFACE_CONTROL_MVEOR | \ - !ILI9341_INTERFACE_CONTROL_MXEOR | \ - !ILI9341_INTERFACE_CONTROL_MYEOR) +#define STM32_ILI9341_IFCTL_PARAM1(ILI9341_INTERFACE_CONTROL_WEMODE) /* Parameter 2: 0x * @@ -119,10 +112,8 @@ * RIM: 0 18-bit 1 transfer/pixel RGB interface mode * */ -#define STM32_ILI9341_IFCTL_PARAM3((!ILI9341_INTERFACE_CONTROL_RIM) | \ - ILI9341_INTERFACE_CONTROL_RM | \ - ILI9341_INTERFACE_CONTROL_DM(1) | \ - (!ILI9341_INTERFACE_CONTROL_ENDIAN)) +#define STM32_ILI9341_IFCTL_PARAM3(ILI9341_INTERFACE_CONTROL_RM | \ + ILI9341_INTERFACE_CONTROL_DM(1)) /* Memory access control (MADCTL) */
[incubator-nuttx] 08/26: Fix chip/kinetis_spi.c:473:23: error: unused function 'spi_getreg8'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 658dfeaf40352a8fbd70118499422f0e7b1dc8fb
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:29:45 2022 +0800
Fix chip/kinetis_spi.c:473:23: error: unused function 'spi_getreg8'
Signed-off-by: Xiang Xiao
---
arch/arm/src/kinetis/kinetis_spi.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/arch/arm/src/kinetis/kinetis_spi.c
b/arch/arm/src/kinetis/kinetis_spi.c
index 817b5103da..91383c605f 100644
--- a/arch/arm/src/kinetis/kinetis_spi.c
+++ b/arch/arm/src/kinetis/kinetis_spi.c
@@ -128,8 +128,6 @@ static inline uint16_t spi_getreg16(struct kinetis_spidev_s
*priv,
uint8_t offset);
static inline void spi_putreg16(struct kinetis_spidev_s *priv,
uint8_t offset, uint16_t value);
-static inline uint8_t spi_getreg8(struct kinetis_spidev_s *priv,
- uint8_t offset);
static inline void spi_putreg8(struct kinetis_spidev_s *priv,
uint8_t offset, uint8_t value);
static inline uint16_t spi_readword(struct kinetis_spidev_s *priv);
@@ -464,27 +462,6 @@ static inline void spi_putreg16(struct kinetis_spidev_s
*priv,
putreg16(value, priv->spibase + offset);
}
-/
- * Name: spi_getreg8
- *
- * Description:
- * Get the 8 bit contents of the SPI register at offset
- *
- * Input Parameters:
- * priv - private SPI device structure
- * offset - offset to the register of interest
- *
- * Returned Value:
- * The contents of the 8-bit register
- *
- /
-
-static inline uint8_t spi_getreg8(struct kinetis_spidev_s *priv,
- uint8_t offset)
-{
- return getreg8(priv->spibase + offset);
-}
-
/
* Name: spi_putreg8
*
[incubator-nuttx] 12/26: Fix chip/s32k3xx_lpi2c.c:624:3: error: unused function 's32k3xx_lpi2c_sem_waitstop'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 670c3e0e3572770b73535c6efe66100fcc5493fb
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:36:10 2022 +0800
Fix chip/s32k3xx_lpi2c.c:624:3: error: unused function
's32k3xx_lpi2c_sem_waitstop'
Signed-off-by: Xiang Xiao
---
arch/arm/src/s32k3xx/s32k3xx_lpi2c.c | 97 ++--
1 file changed, 3 insertions(+), 94 deletions(-)
diff --git a/arch/arm/src/s32k3xx/s32k3xx_lpi2c.c
b/arch/arm/src/s32k3xx/s32k3xx_lpi2c.c
index 85172d187b..e1eb35a3f8 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_lpi2c.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_lpi2c.c
@@ -238,9 +238,7 @@ static uint32_t s32k3xx_lpi2c_toticks(int msgc, struct
i2c_msg_s *msgs);
#endif /* CONFIG_S32K3XX_I2C_DYNTIMEO */
static inline int
- s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv);
-static inline void
- s32k3xx_lpi2c_sem_waitstop(struct s32k3xx_lpi2c_priv_s *priv);
+s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv);
#ifdef CONFIG_I2C_TRACE
static void s32k3xx_lpi2c_tracereset(struct s32k3xx_lpi2c_priv_s *priv);
@@ -470,7 +468,7 @@ static uint32_t s32k3xx_lpi2c_toticks(int msgc, struct
i2c_msg_s *msgs)
#ifndef CONFIG_I2C_POLLED
static inline int
- s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv)
+s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv)
{
irqstate_t flags;
uint32_t regval;
@@ -561,7 +559,7 @@ static inline int
}
#else
static inline int
- s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv)
+s32k3xx_lpi2c_sem_waitdone(struct s32k3xx_lpi2c_priv_s *priv)
{
clock_t timeout;
clock_t start;
@@ -612,95 +610,6 @@ static inline int
}
#endif
-/
- * Name: s32k3xx_lpi2c_sem_waitstop
- *
- * Description:
- * Wait for a STOP to complete
- *
- /
-
-static inline void
- s32k3xx_lpi2c_sem_waitstop(struct s32k3xx_lpi2c_priv_s *priv)
-{
- clock_t start;
- clock_t elapsed;
- clock_t timeout;
- uint32_t regval;
-
- /* Select a timeout */
-
-#ifdef CONFIG_S32K3XX_I2C_DYNTIMEO
- timeout = USEC2TICK(CONFIG_S32K3XX_I2C_DYNTIMEO_STARTSTOP);
-#else
- timeout = CONFIG_S32K3XX_I2CTIMEOTICKS;
-#endif
-
- /* Wait as stop might still be in progress; but stop might also
- * be set because of a timeout error: "The [STOP] bit is set and
- * cleared by software, cleared by hardware when a Stop condition is
- * detected, set by hardware when a timeout error is detected."
- */
-
- start = clock_systime_ticks();
- do
-{
- /* Calculate the elapsed time */
-
- elapsed = clock_systime_ticks() - start;
-
- /* Check for STOP condition */
-
- if (priv->config->mode == LPI2C_MASTER)
-{
- regval = s32k3xx_lpi2c_getreg(priv, S32K3XX_LPI2C_MSR_OFFSET);
- if ((regval & LPI2C_MSR_SDF) == LPI2C_MSR_SDF)
-{
- return;
-}
-}
-
- /* Enable Interrupts when slave mode */
-
- else
-{
- regval = s32k3xx_lpi2c_getreg(priv, S32K3XX_LPI2C_SSR_OFFSET);
- if ((regval & LPI2C_SSR_SDF) == LPI2C_SSR_SDF)
-{
- return;
-}
-}
-
- /* Check for NACK error */
-
- if (priv->config->mode == LPI2C_MASTER)
-{
- regval = s32k3xx_lpi2c_getreg(priv, S32K3XX_LPI2C_MSR_OFFSET);
- if ((regval & LPI2C_MSR_NDF) == LPI2C_MSR_NDF)
-{
- return;
-}
-}
-
- /* Enable Interrupts when slave mode */
-
- else
-{
-#warning Missing logic for I2C Slave
-}
-}
-
- /* Loop until the stop is complete or a timeout occurs. */
-
- while (elapsed < timeout);
-
- /* If we get here then a timeout occurred with the STOP condition
- * still pending.
- */
-
- i2cinfo("Timeout with Status Register: %" PRIx32 "\n", regval);
-}
-
/
* Name: s32k3xx_lpi2c_trace*
*
[incubator-nuttx] 07/26: Fix chip/kinetis_usbdev.c:3317:1: error: unused function 'khci_epreserved'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6fd08787b662edfbf3bc1cd358d6f9dc4d770fda
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:25:39 2022 +0800
Fix chip/kinetis_usbdev.c:3317:1: error: unused function 'khci_epreserved'
Signed-off-by: Xiang Xiao
---
arch/arm/src/kinetis/kinetis_usbdev.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/arm/src/kinetis/kinetis_usbdev.c
b/arch/arm/src/kinetis/kinetis_usbdev.c
index f6484274b2..5a3d3d006e 100644
--- a/arch/arm/src/kinetis/kinetis_usbdev.c
+++ b/arch/arm/src/kinetis/kinetis_usbdev.c
@@ -589,8 +589,6 @@ static inline struct khci_ep_s *
static inline void
khci_epunreserve(struct khci_usbdev_s *priv,
struct khci_ep_s *privep);
-static inline bool
- khci_epreserved(struct khci_usbdev_s *priv, int epno);
static void khci_ep0configure(struct khci_usbdev_s *priv);
/* Endpoint operations **/
@@ -3309,16 +3307,6 @@ khci_epunreserve(struct khci_usbdev_s *priv, struct
khci_ep_s *privep)
leave_critical_section(flags);
}
-/
- * Name: khci_epreserved
- /
-
-static inline bool
-khci_epreserved(struct khci_usbdev_s *priv, int epno)
-{
- return ((priv->epavail & KHCI_ENDP_BIT(epno)) == 0);
-}
-
/
* Name: khci_ep0configure
/
[incubator-nuttx] 18/26: Fix video/max7456.c:775:19: error: unused function '__mx7_write_reg__dmm'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 3453fe799d8c07245d5902d634c9f5690ff21f73
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:58:53 2022 +0800
Fix video/max7456.c:775:19: error: unused function '__mx7_write_reg__dmm'
video/max7456.c:792:19: error: unused function '__mx7_write_reg__dmdi'
video/max7456.c:809:19: error: unused function '__mx7_write_reg__dmah'
video/max7456.c:826:19: error: unused function '__mx7_write_reg__dmal'
Signed-off-by: Xiang Xiao
---
drivers/video/max7456.c | 68 -
1 file changed, 68 deletions(-)
diff --git a/drivers/video/max7456.c b/drivers/video/max7456.c
index 550757e9d7..c1dd97121a 100644
--- a/drivers/video/max7456.c
+++ b/drivers/video/max7456.c
@@ -761,74 +761,6 @@ static inline int __mx7_read_reg__cmdo(FAR struct
mx7_dev_s *dev)
return val;
}
-/
- * Name: __mx7_read_reg__dmm
- *
- * Description:
- * Returns the contents of DMM. A simple helper around __mx7_read_reg().
- *
- * Returned value:
- * Returns the register value, or a negative errno.
- *
- /
-
-static inline int __mx7_write_reg__dmm(FAR struct mx7_dev_s *dev,
- uint8_t val)
-{
- return __mx7_write_reg(dev, DMM, , sizeof(val));
-}
-
-/
- * Name: __mx7_read_reg__dmdi
- *
- * Description:
- * Returns the contents of DMDI. A simple helper around __mx7_read_reg().
- *
- * Returned value:
- * Returns the register value, or a negative errno.
- *
- /
-
-static inline int __mx7_write_reg__dmdi(FAR struct mx7_dev_s *dev,
-uint8_t val)
-{
- return __mx7_write_reg(dev, DMDI, , sizeof(val));
-}
-
-/
- * Name: __mx7_read_reg__dmah
- *
- * Description:
- * Returns the contents of DMAH. A simple helper around __mx7_read_reg().
- *
- * Returned value:
- * Returns the register value, or a negative errno.
- *
- /
-
-static inline int __mx7_write_reg__dmah(FAR struct mx7_dev_s *dev,
-uint8_t val)
-{
- return __mx7_write_reg(dev, DMAH, , sizeof(val));
-}
-
-/
- * Name: __mx7_read_reg__dmal
- *
- * Description:
- * Returns the contents of DMAL. A simple helper around __mx7_read_reg().
- *
- * Returned value:
- * Returns the register value, or a negative errno.
- *
- /
-
-static inline int __mx7_write_reg__dmal(FAR struct mx7_dev_s *dev,
-uint8_t val)
-{
- return __mx7_write_reg(dev, DMAL, , sizeof(val));
-}
-
/
* Name: __mx7_wait_reset
*
[incubator-nuttx] 19/26: Fix error: more '%' conversions than data arguments
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6af9afaa60a276aba9d6c59746e60c034a974f52
Author: Xiang Xiao
AuthorDate: Sat Nov 19 13:01:43 2022 +0800
Fix error: more '%' conversions than data arguments
Signed-off-by: Xiang Xiao
---
arch/arm/src/stm32/stm32_usbdev.c | 2 +-
arch/arm/src/stm32/stm32_usbfs.c| 2 +-
arch/arm/src/stm32f0l0g0/stm32_usbdev.c | 2 +-
arch/arm/src/stm32l4/stm32l4_usbdev.c | 2 +-
arch/mips/src/pic32mx/pic32mx_usbdev.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/src/stm32/stm32_usbdev.c
b/arch/arm/src/stm32/stm32_usbdev.c
index 22018c925c..79e0f9187a 100644
--- a/arch/arm/src/stm32/stm32_usbdev.c
+++ b/arch/arm/src/stm32/stm32_usbdev.c
@@ -2892,7 +2892,7 @@ static int stm32_epconfigure(struct usbdev_ep_s *ep,
if (!ep || !desc)
{
usbtrace(TRACE_DEVERROR(STM32_TRACEERR_INVALIDPARMS), 0);
- uerr("ERROR: ep=%p desc=%p\n");
+ uerr("ERROR: ep=%p desc=%p\n", ep, desc);
return -EINVAL;
}
#endif
diff --git a/arch/arm/src/stm32/stm32_usbfs.c b/arch/arm/src/stm32/stm32_usbfs.c
index 6c6cd46f0f..44e783dcc5 100644
--- a/arch/arm/src/stm32/stm32_usbfs.c
+++ b/arch/arm/src/stm32/stm32_usbfs.c
@@ -2868,7 +2868,7 @@ static int stm32_epconfigure(struct usbdev_ep_s *ep,
if (!ep || !desc)
{
usbtrace(TRACE_DEVERROR(STM32_TRACEERR_INVALIDPARMS), 0);
- uerr("ERROR: ep=%p desc=%p\n");
+ uerr("ERROR: ep=%p desc=%p\n", ep, desc);
return -EINVAL;
}
#endif
diff --git a/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
b/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
index 365973a169..d08370a55b 100644
--- a/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
+++ b/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
@@ -2815,7 +2815,7 @@ static int stm32_epconfigure(struct usbdev_ep_s *ep,
if (!ep || !desc)
{
usbtrace(TRACE_DEVERROR(STM32_TRACEERR_INVALIDPARMS), 0);
- uerr("ERROR: ep=%p desc=%p\n");
+ uerr("ERROR: ep=%p desc=%p\n", ep, desc);
return -EINVAL;
}
#endif
diff --git a/arch/arm/src/stm32l4/stm32l4_usbdev.c
b/arch/arm/src/stm32l4/stm32l4_usbdev.c
index a748a1afb1..d6bba1652e 100644
--- a/arch/arm/src/stm32l4/stm32l4_usbdev.c
+++ b/arch/arm/src/stm32l4/stm32l4_usbdev.c
@@ -2827,7 +2827,7 @@ static int stm32l4_epconfigure(struct usbdev_ep_s *ep,
if (!ep || !desc)
{
usbtrace(TRACE_DEVERROR(STM32L4_TRACEERR_INVALIDPARMS), 0);
- uerr("ERROR: ep=%p desc=%p\n");
+ uerr("ERROR: ep=%p desc=%p\n", ep, desc);
return -EINVAL;
}
#endif
diff --git a/arch/mips/src/pic32mx/pic32mx_usbdev.c
b/arch/mips/src/pic32mx/pic32mx_usbdev.c
index ef292c00e9..543f36752f 100644
--- a/arch/mips/src/pic32mx/pic32mx_usbdev.c
+++ b/arch/mips/src/pic32mx/pic32mx_usbdev.c
@@ -3193,7 +3193,7 @@ static int pic32mx_epconfigure(struct usbdev_ep_s *ep,
if (!ep || !desc)
{
usbtrace(TRACE_DEVERROR(PIC32MX_TRACEERR_INVALIDPARMS), 0);
- uerr("ERROR: ep=%p desc=%p\n");
+ uerr("ERROR: ep=%p desc=%p\n", ep, desc);
return -EINVAL;
}
#endif
[incubator-nuttx] 22/26: Fix error: shifting a negative signed value is undefined
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ffda739704c51e4082350552a8661163b4ab70fe Author: Xiang Xiao AuthorDate: Sat Nov 19 13:15:54 2022 +0800 Fix error: shifting a negative signed value is undefined Signed-off-by: Xiang Xiao --- boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c | 4 ++-- boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c b/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c index 6a385dcf0c..b7277383d0 100644 --- a/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c +++ b/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c @@ -163,8 +163,8 @@ void stm32_selectlcd(void) /* Bank1 NOR/SRAM timing register configuration */ - putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(0) | - FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(0) | + putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(1) | + FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(1) | FSMC_BTR_CLKDIV(1) | FSMC_BTR_DATLAT(2) | FSMC_BTR_ACCMODA, STM32_FSMC_BTR1); diff --git a/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c b/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c index ad62481973..2214ef3850 100644 --- a/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c +++ b/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c @@ -115,8 +115,8 @@ void stm32_selectlcd(void) /* Bank4 NOR/SRAM timing register configuration */ - putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(0) | - FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(0) | + putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(1) | + FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(1) | FSMC_BTR_CLKDIV(1) | FSMC_BTR_DATLAT(2) | FSMC_BTR_ACCMODA, STM32_FSMC_BTR4);
[incubator-nuttx] 06/26: Fix chip/kinetis_enet.c:875:59: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int')
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 232360cbd00e8b3ddb47f8cfa15e44085d275db5
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:24:52 2022 +0800
Fix chip/kinetis_enet.c:875:59: error: format specifies type 'unsigned
long' but the argument has type 'uint32_t' (aka 'unsigned int')
Signed-off-by: Xiang Xiao
---
arch/arm/src/kinetis/kinetis_enet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/src/kinetis/kinetis_enet.c
b/arch/arm/src/kinetis/kinetis_enet.c
index 779a15fabe..bc8f206645 100644
--- a/arch/arm/src/kinetis/kinetis_enet.c
+++ b/arch/arm/src/kinetis/kinetis_enet.c
@@ -872,7 +872,7 @@ static void kinetis_interrupt_work(void *arg)
{
/* An error has occurred, update statistics */
- nerr("pending %0" PRIx32 "d ints %0lxd\n", pending, priv->ints);
+ nerr("pending %0" PRIx32 "ints %0" PRIx32 "\n", pending, priv->ints);
NETDEV_ERRORS(>dev);
[incubator-nuttx] 01/26: Fix chip/imxrt_lpi2c.c:755:1: error: unused function 'imxrt_lpi2c_sem_waitstop'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 427f65ac28b532c601db025bd0b31375b0c3b094
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:09:42 2022 +0800
Fix chip/imxrt_lpi2c.c:755:1: error: unused function
'imxrt_lpi2c_sem_waitstop'
Signed-off-by: Xiang Xiao
---
arch/arm/src/imxrt/imxrt_lpi2c.c | 91
1 file changed, 91 deletions(-)
diff --git a/arch/arm/src/imxrt/imxrt_lpi2c.c b/arch/arm/src/imxrt/imxrt_lpi2c.c
index 652e13da54..0b6d89b53d 100644
--- a/arch/arm/src/imxrt/imxrt_lpi2c.c
+++ b/arch/arm/src/imxrt/imxrt_lpi2c.c
@@ -243,8 +243,6 @@ static uint32_t imxrt_lpi2c_toticks(int msgc, struct
i2c_msg_s *msgs);
static inline int
imxrt_lpi2c_sem_waitdone(struct imxrt_lpi2c_priv_s *priv);
-static inline void
-imxrt_lpi2c_sem_waitstop(struct imxrt_lpi2c_priv_s *priv);
#ifdef CONFIG_I2C_TRACE
static void imxrt_lpi2c_tracereset(struct imxrt_lpi2c_priv_s *priv);
@@ -743,95 +741,6 @@ imxrt_lpi2c_sem_waitdone(struct imxrt_lpi2c_priv_s *priv)
}
#endif
-/
- * Name: imxrt_lpi2c_sem_waitstop
- *
- * Description:
- * Wait for a STOP to complete
- *
- /
-
-static inline void
-imxrt_lpi2c_sem_waitstop(struct imxrt_lpi2c_priv_s *priv)
-{
- clock_t start;
- clock_t elapsed;
- clock_t timeout;
- uint32_t regval;
-
- /* Select a timeout */
-
-#ifdef CONFIG_IMXRT_LPI2C_DYNTIMEO
- timeout = USEC2TICK(CONFIG_IMXRT_LPI2C_DYNTIMEO_STARTSTOP);
-#else
- timeout = CONFIG_IMXRT_LPI2C_TIMEOTICKS;
-#endif
-
- /* Wait as stop might still be in progress; but stop might also
- * be set because of a timeout error: "The [STOP] bit is set and
- * cleared by software, cleared by hardware when a Stop condition is
- * detected, set by hardware when a timeout error is detected."
- */
-
- start = clock_systime_ticks();
- do
-{
- /* Calculate the elapsed time */
-
- elapsed = clock_systime_ticks() - start;
-
- /* Check for STOP condition */
-
- if (priv->config->mode == LPI2C_MASTER)
-{
- regval = imxrt_lpi2c_getreg(priv, IMXRT_LPI2C_MSR_OFFSET);
- if ((regval & LPI2C_MSR_SDF) == LPI2C_MSR_SDF)
-{
- return;
-}
-}
-
- /* Enable Interrupts when slave mode */
-
- else
-{
- regval = imxrt_lpi2c_getreg(priv, IMXRT_LPI2C_SSR_OFFSET);
- if ((regval & LPI2C_SSR_SDF) == LPI2C_SSR_SDF)
-{
- return;
-}
-}
-
- /* Check for NACK error */
-
- if (priv->config->mode == LPI2C_MASTER)
-{
- regval = imxrt_lpi2c_getreg(priv, IMXRT_LPI2C_MSR_OFFSET);
- if ((regval & LPI2C_MSR_NDF) == LPI2C_MSR_NDF)
-{
- return;
-}
-}
-
- /* Enable Interrupts when slave mode */
-
- else
-{
-#warning Missing logic for I2C Slave
-}
-}
-
- /* Loop until the stop is complete or a timeout occurs. */
-
- while (elapsed < timeout);
-
- /* If we get here then a timeout occurred with the STOP condition
- * still pending.
- */
-
- i2cinfo("Timeout with Status Register: %" PRIx32 "\n", regval);
-}
-
/
* Name: imxrt_dma_callback
*
[incubator-nuttx] 14/26: Fix chip/s32k3xx_qspi.c:925:44: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int')
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d3e282e56170f2efe3fbeceaa13372edbdde325e
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:48:12 2022 +0800
Fix chip/s32k3xx_qspi.c:925:44: error: format specifies type 'unsigned
long' but the argument has type 'uint32_t' (aka 'unsigned int')
Signed-off-by: Xiang Xiao
---
arch/arm/src/s32k3xx/s32k3xx_qspi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/src/s32k3xx/s32k3xx_qspi.c
b/arch/arm/src/s32k3xx/s32k3xx_qspi.c
index 833701cb7c..ef3b53116a 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_qspi.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_qspi.c
@@ -926,7 +926,8 @@ static int qspi_transmit_blocking(struct s32k3xx_qspidev_s
*priv,
regval |= QSPI_MCR_CLR_TXF;
putreg32(regval, S32K3XX_QSPI_MCR);
- spiinfo("Transmit: %lu size: %lu\n", meminfo->addr, meminfo->buflen);
+ spiinfo("Transmit: %" PRIu32 " size: %" PRIu32 "\n",
+ meminfo->addr, meminfo->buflen);
for (count = 0U; count < write_cycle; count++)
{
[incubator-nuttx] 23/26: Fix error: variable 'buflen' is uninitialized when used here
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 19138560f47319a66b12bdce4a4eae292f6e55a0
Author: Xiang Xiao
AuthorDate: Sat Nov 19 13:19:26 2022 +0800
Fix error: variable 'buflen' is uninitialized when used here
Signed-off-by: Xiang Xiao
---
net/sixlowpan/sixlowpan_icmpv6send.c | 2 +-
net/sixlowpan/sixlowpan_tcpsend.c| 2 +-
net/sixlowpan/sixlowpan_udpsend.c| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/sixlowpan/sixlowpan_icmpv6send.c
b/net/sixlowpan/sixlowpan_icmpv6send.c
index 0b3090814a..0e7448edcd 100644
--- a/net/sixlowpan/sixlowpan_icmpv6send.c
+++ b/net/sixlowpan/sixlowpan_icmpv6send.c
@@ -121,7 +121,7 @@ void sixlowpan_icmpv6_send(FAR struct net_driver_s *dev,
if (hdrlen > dev->d_len)
{
nwarn("WARNING: Dropping small ICMPv6 packet: %u < %u\n",
-buflen, hdrlen);
+dev->d_len, hdrlen);
}
else
{
diff --git a/net/sixlowpan/sixlowpan_tcpsend.c
b/net/sixlowpan/sixlowpan_tcpsend.c
index f5b7416416..a127dd9743 100644
--- a/net/sixlowpan/sixlowpan_tcpsend.c
+++ b/net/sixlowpan/sixlowpan_tcpsend.c
@@ -907,7 +907,7 @@ void sixlowpan_tcp_send(FAR struct net_driver_s *dev,
if (hdrlen > dev->d_len)
{
nwarn("WARNING: Dropping small TCP packet: %u < %u\n",
-buflen, hdrlen);
+dev->d_len, hdrlen);
}
else
{
diff --git a/net/sixlowpan/sixlowpan_udpsend.c
b/net/sixlowpan/sixlowpan_udpsend.c
index fd08b7b09b..d0a6d26ad9 100644
--- a/net/sixlowpan/sixlowpan_udpsend.c
+++ b/net/sixlowpan/sixlowpan_udpsend.c
@@ -459,7 +459,7 @@ void sixlowpan_udp_send(FAR struct net_driver_s *dev,
if (hdrlen > dev->d_len)
{
nwarn("WARNING: Dropping small UDP packet: %u < %u\n",
-buflen, hdrlen);
+dev->d_len, hdrlen);
}
else
{
[incubator-nuttx] 17/26: Fix sensors/mpu60x0.c:650:23: error: unused function '__mpu_read_who_am_i'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a4eeeb23de0b1a4f8ad1632faa562215f27d70fd
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:57:41 2022 +0800
Fix sensors/mpu60x0.c:650:23: error: unused function '__mpu_read_who_am_i'
Signed-off-by: Xiang Xiao
---
drivers/sensors/mpu60x0.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/sensors/mpu60x0.c b/drivers/sensors/mpu60x0.c
index a91d55cea2..ff2b45a180 100644
--- a/drivers/sensors/mpu60x0.c
+++ b/drivers/sensors/mpu60x0.c
@@ -645,15 +645,6 @@ static inline int __mpu_write_config(FAR struct mpu_dev_s
*dev,
return __mpu_write_reg(dev, CONFIG, , sizeof(val));
}
-/* WHO_AM_I (0x75) : read-only, always returns 0x68 for mpu60x0 */
-
-static inline uint8_t __mpu_read_who_am_i(FAR struct mpu_dev_s *dev)
-{
- uint8_t val = 0xff;
- __mpu_read_reg(dev, WHO_AM_I, , sizeof(val));
- return val;
-}
-
/* Resets the mpu60x0, sets it to a default configuration. */
static int mpu_reset(FAR struct mpu_dev_s *dev)
[incubator-nuttx] 20/26: Fix chip/stm32_usbdev.c:929:20: error: unused function 'stm32_setstatusout'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 720acac6afafb3f1feb44baebef8cddf40c87899
Author: Xiang Xiao
AuthorDate: Sat Nov 19 13:02:51 2022 +0800
Fix chip/stm32_usbdev.c:929:20: error: unused function 'stm32_setstatusout'
Signed-off-by: Xiang Xiao
---
arch/arm/src/stm32/stm32_usbdev.c | 22 --
arch/arm/src/stm32/stm32_usbfs.c| 22 --
arch/arm/src/stm32f0l0g0/stm32_usbdev.c | 21 -
3 files changed, 65 deletions(-)
diff --git a/arch/arm/src/stm32/stm32_usbdev.c
b/arch/arm/src/stm32/stm32_usbdev.c
index 79e0f9187a..dc70cad438 100644
--- a/arch/arm/src/stm32/stm32_usbdev.c
+++ b/arch/arm/src/stm32/stm32_usbdev.c
@@ -406,8 +406,6 @@ static inline void
stm32_seteptype(uint8_t epno, uint16_t type);
static inline void
stm32_seteptxaddr(uint8_t epno, uint16_t addr);
-static inline void
- stm32_setstatusout(uint8_t epno);
static inline void
stm32_clrstatusout(uint8_t epno);
static void stm32_clrrxdtog(uint8_t epno);
@@ -922,26 +920,6 @@ static inline void stm32_seteptype(uint8_t epno, uint16_t
type)
stm32_putreg(regval, epaddr);
}
-/
- * Name: stm32_setstatusout
- /
-
-static inline void stm32_setstatusout(uint8_t epno)
-{
- uint32_t epaddr = STM32_USB_EPR(epno);
- uint16_t regval;
-
- /* For a BULK endpoint the EP_KIND bit is used to enabled double buffering;
- * for a CONTROL endpoint, it is set to indicate that a status OUT
- * transaction is expected. The bit is not used with out endpoint types.
- */
-
- regval = stm32_getreg(epaddr);
- regval &= EPR_NOTOG_MASK;
- regval |= USB_EPR_EP_KIND;
- stm32_putreg(regval, epaddr);
-}
-
/
* Name: stm32_clrstatusout
/
diff --git a/arch/arm/src/stm32/stm32_usbfs.c b/arch/arm/src/stm32/stm32_usbfs.c
index 44e783dcc5..3205b2638e 100644
--- a/arch/arm/src/stm32/stm32_usbfs.c
+++ b/arch/arm/src/stm32/stm32_usbfs.c
@@ -387,8 +387,6 @@ static inline void
stm32_seteptype(uint8_t epno, uint16_t type);
static inline void
stm32_seteptxaddr(uint8_t epno, uint16_t addr);
-static inline void
- stm32_setstatusout(uint8_t epno);
static inline void
stm32_clrstatusout(uint8_t epno);
static void stm32_clrrxdtog(uint8_t epno);
@@ -904,26 +902,6 @@ static inline void stm32_seteptype(uint8_t epno, uint16_t
type)
stm32_putreg(regval, epaddr);
}
-/
- * Name: stm32_setstatusout
- /
-
-static inline void stm32_setstatusout(uint8_t epno)
-{
- uint32_t epaddr = STM32_USB_EPR(epno);
- uint16_t regval;
-
- /* For a BULK endpoint the EP_KIND bit is used to enabled double buffering;
- * for a CONTROL endpoint, it is set to indicate that a status OUT
- * transaction is expected. The bit is not used with out endpoint types.
- */
-
- regval = stm32_getreg(epaddr);
- regval &= EPR_NOTOG_MASK;
- regval |= USB_EPR_EP_KIND;
- stm32_putreg(regval, epaddr);
-}
-
/
* Name: stm32_clrstatusout
/
diff --git a/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
b/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
index d08370a55b..a213f884b4 100644
--- a/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
+++ b/arch/arm/src/stm32f0l0g0/stm32_usbdev.c
@@ -382,7 +382,6 @@ static inline uint16_t stm32_geteprxaddr(uint8_t epno);
static inline void stm32_setepaddress(uint8_t epno, uint16_t addr);
static inline void stm32_seteptype(uint8_t epno, uint16_t type);
static inline void stm32_seteptxaddr(uint8_t epno, uint16_t addr);
-static inline void stm32_setstatusout(uint8_t epno);
static inline void stm32_clrstatusout(uint8_t epno);
static void stm32_clrrxdtog(uint8_t epno);
static void stm32_clrtxdtog(uint8_t epno);
@@ -866,26 +865,6 @@ static inline void stm32_seteptype(uint8_t epno, uint16_t
type)
stm32_putreg(regval, epaddr);
}
-/
- * Name: stm32_setstatusout
- /
-
-static inline void stm32_setstatusout(uint8_t epno)
-{
- uint32_t epaddr = STM32_USB_EPR(epno);
- uint16_t regval;
-
- /* For a BULK endpoint the EP_KIND bit is used to enabled double buffering;
- * for a
[incubator-nuttx] 16/26: Fix chip/sam_tc.c:682:24: error: unused function 'sam_tc_getreg'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 22768ede1709e8b0f5a992c813b255396b1dec62
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:52:11 2022 +0800
Fix chip/sam_tc.c:682:24: error: unused function 'sam_tc_getreg'
Signed-off-by: Xiang Xiao
---
arch/arm/src/sama5/sam_tc.c | 54 -
arch/arm/src/samv7/sam_tc.c | 27 ---
2 files changed, 81 deletions(-)
diff --git a/arch/arm/src/sama5/sam_tc.c b/arch/arm/src/sama5/sam_tc.c
index 31a3ad9406..8ac403f23a 100644
--- a/arch/arm/src/sama5/sam_tc.c
+++ b/arch/arm/src/sama5/sam_tc.c
@@ -157,11 +157,6 @@ static bool sam_checkreg(struct sam_tc_s *tc, bool wr,
uint32_t regaddr,
# define sam_checkreg(tc,wr,regaddr,regval) (false)
#endif
-static inline uint32_t sam_tc_getreg(struct sam_chan_s *chan,
- unsigned int offset);
-static inline void sam_tc_putreg(struct sam_chan_s *chan,
- unsigned int offset, uint32_t regval);
-
static inline uint32_t sam_chan_getreg(struct sam_chan_s *chan,
unsigned int offset);
static inline void sam_chan_putreg(struct sam_chan_s *chan,
@@ -566,55 +561,6 @@ static bool sam_checkreg(struct sam_tc_s *tc, bool wr,
uint32_t regaddr,
}
#endif
-/
- * Name: sam_tc_getreg
- *
- * Description:
- * Read an TC register
- *
- /
-
-static inline uint32_t sam_tc_getreg(struct sam_chan_s *chan,
- unsigned int offset)
-{
- struct sam_tc_s *tc = chan->tc;
- uint32_t regaddr= tc->base + offset;
- uint32_t regval = getreg32(regaddr);
-
-#ifdef CONFIG_SAMA5_TC_REGDEBUG
- if (sam_checkreg(tc, false, regaddr, regval))
-{
- tmrinfo("%08x->%08x\n", regaddr, regval);
-}
-#endif
-
- return regval;
-}
-
-/
- * Name: sam_tc_putreg
- *
- * Description:
- * Write a value to an TC register
- *
- /
-
-static inline void sam_tc_putreg(struct sam_chan_s *chan, uint32_t regval,
- unsigned int offset)
-{
- struct sam_tc_s *tc = chan->tc;
- uint32_t regaddr= tc->base + offset;
-
-#ifdef CONFIG_SAMA5_TC_REGDEBUG
- if (sam_checkreg(tc, true, regaddr, regval))
-{
- tmrinfo("%08x<-%08x\n", regaddr, regval);
-}
-#endif
-
- putreg32(regval, regaddr);
-}
-
/
* Name: sam_chan_getreg
*
diff --git a/arch/arm/src/samv7/sam_tc.c b/arch/arm/src/samv7/sam_tc.c
index ca06910078..30bf27614f 100644
--- a/arch/arm/src/samv7/sam_tc.c
+++ b/arch/arm/src/samv7/sam_tc.c
@@ -164,8 +164,6 @@ static bool sam_checkreg(struct sam_tc_s *tc, bool wr,
uint32_t regaddr,
# define sam_checkreg(tc,wr,regaddr,regval) (false)
#endif
-static inline uint32_t sam_tc_getreg(struct sam_chan_s *chan,
- unsigned int offset);
static inline void sam_tc_putreg(struct sam_chan_s *chan,
unsigned int offset, uint32_t regval);
@@ -680,31 +678,6 @@ static bool sam_checkreg(struct sam_tc_s *tc, bool wr,
uint32_t regaddr,
}
#endif
-/
- * Name: sam_tc_getreg
- *
- * Description:
- * Read an TC register
- *
- /
-
-static inline uint32_t sam_tc_getreg(struct sam_chan_s *chan,
- unsigned int offset)
-{
- struct sam_tc_s *tc = chan->tc;
- uint32_t regaddr= tc->base + offset;
- uint32_t regval = getreg32(regaddr);
-
-#ifdef CONFIG_SAMV7_TC_REGDEBUG
- if (sam_checkreg(tc, false, regaddr, regval))
-{
- tmrinfo("%08x->%08x\n", regaddr, regval);
-}
-#endif
-
- return regval;
-}
-
/
* Name: sam_tc_putreg
*
[incubator-nuttx] 26/26: Fix board/stm32_lcd.c:584:14: error: converting the result of '<<' to a boolean; did you mean '(7 << (10)) != 0'?
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit f2320a4a697a1093c7823bd18589c727e837f30c Author: Xiang Xiao AuthorDate: Sat Nov 19 13:25:53 2022 +0800 Fix board/stm32_lcd.c:584:14: error: converting the result of '<<' to a boolean; did you mean '(7 << (10)) != 0'? Signed-off-by: Xiang Xiao --- boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c b/boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c index 7a0ac5dcaf..7b05554a5a 100644 --- a/boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c +++ b/boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c @@ -581,7 +581,7 @@ static int slcd_setcontrast(uint8_t contrast) } regval = getreg32(STM32_LCD_FCR); - regval &= !LCD_FCR_CC_MASK; + regval &= ~LCD_FCR_CC_MASK; regval |= contrast << LCD_FCR_CC_SHIFT; putreg32(regval, STM32_LCD_FCR);
[incubator-nuttx] 04/26: Fix chip/imxrt_lpspi.c:553:23: error: unused function 'imxrt_lpspi_readbyte'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4913552140a32a8f2cb14b1ed37889dad151b69f
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:17:06 2022 +0800
Fix chip/imxrt_lpspi.c:553:23: error: unused function 'imxrt_lpspi_readbyte'
and chip/imxrt_lpspi.c:580:20: error: unused function
'imxrt_lpspi_writebyte'
Signed-off-by: Xiang Xiao
---
arch/arm/src/imxrt/imxrt_lpspi.c | 94
1 file changed, 94 deletions(-)
diff --git a/arch/arm/src/imxrt/imxrt_lpspi.c b/arch/arm/src/imxrt/imxrt_lpspi.c
index c978d3fdbb..1893d8858d 100644
--- a/arch/arm/src/imxrt/imxrt_lpspi.c
+++ b/arch/arm/src/imxrt/imxrt_lpspi.c
@@ -409,46 +409,6 @@ static struct imxrt_lpspidev_s g_lpspi4dev =
* Private Functions
/
-/
- * Name: imxrt_lpspi_getreg8
- *
- * Description:
- * Get the contents of the SPI register at offset
- *
- * Input Parameters:
- * priv - private SPI device structure
- * offset - offset to the register of interest
- *
- * Returned Value:
- * The contents of the 8-bit register
- *
- /
-
-static inline uint8_t imxrt_lpspi_getreg8(struct imxrt_lpspidev_s *priv,
- uint8_t offset)
-{
- return getreg8(priv->spibase + offset);
-}
-
-/
- * Name: imxrt_lpspi_putreg8
- *
- * Description:
- * Write a 8-bit value to the SPI register at offset
- *
- * Input Parameters:
- * priv - private SPI device structure
- * offset - offset to the register of interest
- * value - the 8-bit value to be written
- *
- /
-
-static inline void imxrt_lpspi_putreg8(struct imxrt_lpspidev_s *priv,
- uint8_t offset, uint8_t value)
-{
- putreg8(value, priv->spibase + offset);
-}
-
/
* Name: imxrt_lpspi_getreg
*
@@ -548,60 +508,6 @@ static inline void imxrt_lpspi_writeword(struct
imxrt_lpspidev_s *priv,
imxrt_lpspi_putreg32(priv, IMXRT_LPSPI_TDR_OFFSET, word);
}
-/
- * Name: imxrt_lpspi_readbyte
- *
- * Description:
- * Read one byte from SPI
- *
- * Input Parameters:
- * priv - Device-specific state data
- *
- * Returned Value:
- * Byte as read
- *
- /
-
-static inline uint8_t imxrt_lpspi_readbyte(struct imxrt_lpspidev_s *priv)
-{
- /* Wait until the receive buffer is not empty */
-
- while ((imxrt_lpspi_getreg32(priv, IMXRT_LPSPI_SR_OFFSET)
- & LPSPI_SR_RDF) == 0);
-
- /* Then return the received byte */
-
- return imxrt_lpspi_getreg8(priv, IMXRT_LPSPI_RDR_OFFSET);
-}
-
-/
- * Name: imxrt_lpspi_writebyte
- *
- * Description:
- * Write one 8-bit frame to the SPI FIFO
- *
- * Input Parameters:
- * priv - Device-specific state data
- * byte - Byte to send
- *
- * Returned Value:
- * None
- *
- /
-
-static inline void imxrt_lpspi_writebyte(struct imxrt_lpspidev_s *priv,
- uint8_t byte)
-{
- /* Wait until the transmit buffer is empty */
-
- while ((imxrt_lpspi_getreg32(priv, IMXRT_LPSPI_SR_OFFSET)
- & LPSPI_SR_TDF) == 0);
-
- /* Then send the byte */
-
- imxrt_lpspi_putreg8(priv, IMXRT_LPSPI_TDR_OFFSET, byte);
-}
-
/
* Name: imxrt_lpspi_9to16bitmode
*
[incubator-nuttx] 10/26: Fix chip/s32k3xx_lpspi.c:719:23: error: unused function 's32k3xx_lpspi_readbyte'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e18d5870db006e859dd553773dd39d5162ec8913
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:32:00 2022 +0800
Fix chip/s32k3xx_lpspi.c:719:23: error: unused function
's32k3xx_lpspi_readbyte'
and chip/s32k3xx_lpspi.c:748:20: error: unused function
's32k3xx_lpspi_writebyte'
Signed-off-by: Xiang Xiao
---
arch/arm/src/s32k3xx/s32k3xx_lpspi.c | 58
1 file changed, 58 deletions(-)
diff --git a/arch/arm/src/s32k3xx/s32k3xx_lpspi.c
b/arch/arm/src/s32k3xx/s32k3xx_lpspi.c
index a7d1bca823..109c81a5dc 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_lpspi.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_lpspi.c
@@ -720,64 +720,6 @@ static inline void s32k3xx_lpspi_write_dword(struct
s32k3xx_lpspidev_s *priv,
#endif
-/
- * Name: s32k3xx_lpspi_readbyte
- *
- * Description:
- * Read one byte from SPI
- *
- * Input Parameters:
- * priv - Device-specific state data
- *
- * Returned Value:
- * Byte as read
- *
- /
-
-static inline uint8_t s32k3xx_lpspi_readbyte(struct s32k3xx_lpspidev_s *priv)
-{
- /* Wait until the receive buffer is not empty */
-
- while ((s32k3xx_lpspi_getreg32(priv, S32K3XX_LPSPI_SR_OFFSET) &
- LPSPI_SR_RDF) == 0)
-{
-}
-
- /* Then return the received byte */
-
- return s32k3xx_lpspi_getreg8(priv, S32K3XX_LPSPI_RDR_OFFSET);
-}
-
-/
- * Name: s32k3xx_lpspi_writebyte
- *
- * Description:
- * Write one 8-bit frame to the SPI FIFO
- *
- * Input Parameters:
- * priv - Device-specific state data
- * byte - Byte to send
- *
- * Returned Value:
- * None
- *
- /
-
-static inline void s32k3xx_lpspi_writebyte(struct s32k3xx_lpspidev_s *priv,
- uint8_t byte)
-{
- /* Wait until the transmit buffer is empty */
-
- while ((s32k3xx_lpspi_getreg32(priv, S32K3XX_LPSPI_SR_OFFSET) &
- LPSPI_SR_TDF) == 0)
-{
-}
-
- /* Then send the byte */
-
- s32k3xx_lpspi_putreg8(priv, S32K3XX_LPSPI_TDR_OFFSET, byte);
-}
-
/
* Name: s32k3xx_lpspi_9to16bitmode
*
[incubator-nuttx] 15/26: Fix chip/sam4l_clockconfig.c:923:20: error: unused function 'sam_enable_fastwakeup'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d01fbf77d0978a893d823a521606dc5ef8c8305b
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:50:19 2022 +0800
Fix chip/sam4l_clockconfig.c:923:20: error: unused function
'sam_enable_fastwakeup'
Signed-off-by: Xiang Xiao
---
arch/arm/src/sam34/sam4l_clockconfig.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/src/sam34/sam4l_clockconfig.c
b/arch/arm/src/sam34/sam4l_clockconfig.c
index 96070331ee..77efe7b396 100644
--- a/arch/arm/src/sam34/sam4l_clockconfig.c
+++ b/arch/arm/src/sam34/sam4l_clockconfig.c
@@ -920,6 +920,8 @@ static inline void sam_setdividers(void)
*
/
+#if BOARD_CPU_FREQUENCY > FLASH_MAXFREQ_PS1_HSDIS_FWS0 && \
+BOARD_CPU_FREQUENCY <= FLASH_MAXFREQ_PS1_HSDIS_FWS1
static inline void sam_enable_fastwakeup(void)
{
uint32_t regval;
@@ -930,6 +932,7 @@ static inline void sam_enable_fastwakeup(void)
SAM_BPM_UNLOCK);
putreg32(regval, SAM_BPM_PMCON);
}
+#endif
/
* Name: set_flash_waitstate
[incubator-nuttx] 13/26: Fix error: format specifies type 'unsigned long' but the argument has type 'unsigned int'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d8e53d7b4fdd6b5eeca3089450116c7a513b56d9
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:44:07 2022 +0800
Fix error: format specifies type 'unsigned long' but the argument has type
'unsigned int'
Signed-off-by: Xiang Xiao
---
arch/arm/src/s32k1xx/s32k1xx_enet.c | 8
arch/arm/src/s32k3xx/s32k3xx_emac.c | 12 ++--
arch/arm/src/samd5e5/sam_gmac.c | 4 ++--
drivers/net/encx24j600.c| 8
drivers/net/ftmac100.c | 4 ++--
drivers/net/lan91c111.c | 4 ++--
drivers/net/rpmsgdrv.c | 4 ++--
drivers/net/slip.c | 4 ++--
drivers/usbhost/usbhost_cdcmbim.c | 4 ++--
9 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/arch/arm/src/s32k1xx/s32k1xx_enet.c
b/arch/arm/src/s32k1xx/s32k1xx_enet.c
index 92f818f81e..a62a74acb2 100644
--- a/arch/arm/src/s32k1xx/s32k1xx_enet.c
+++ b/arch/arm/src/s32k1xx/s32k1xx_enet.c
@@ -1217,8 +1217,8 @@ static int s32k1xx_ifup_action(struct net_driver_s *dev,
bool resetphy)
int ret;
ninfo("Bringing up: %d.%d.%d.%d\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Initialize ENET buffers */
@@ -1357,8 +1357,8 @@ static int s32k1xx_ifdown(struct net_driver_s *dev)
irqstate_t flags;
ninfo("Taking down: %d.%d.%d.%d\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Flush and disable the Ethernet interrupts at the NVIC */
diff --git a/arch/arm/src/s32k3xx/s32k3xx_emac.c
b/arch/arm/src/s32k3xx/s32k3xx_emac.c
index 4ed344bf9d..f93260c7e3 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_emac.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_emac.c
@@ -1918,9 +1918,9 @@ static int s32k3xx_ifup_action(struct net_driver_s *dev,
bool resetphy)
uint32_t regval;
int ret;
- ninfo("Bringing up: %lu.%lu.%lu.%lu\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+ ninfo("Bringing up: %d.%d.%d.%d\n",
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Initialize the free buffer list */
@@ -2034,9 +2034,9 @@ static int s32k3xx_ifdown(struct net_driver_s *dev)
struct s32k3xx_driver_s *priv = (struct s32k3xx_driver_s *)dev->d_private;
irqstate_t flags;
- ninfo("Taking down: %lu.%lu.%lu.%lu\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+ ninfo("Taking down: %d.%d.%d.%d\n",
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Flush and disable the Ethernet interrupts at the NVIC */
diff --git a/arch/arm/src/samd5e5/sam_gmac.c b/arch/arm/src/samd5e5/sam_gmac.c
index 4807fc8d05..e4ba499d3c 100644
--- a/arch/arm/src/samd5e5/sam_gmac.c
+++ b/arch/arm/src/samd5e5/sam_gmac.c
@@ -1753,8 +1753,8 @@ static int sam_ifup(struct net_driver_s *dev)
int ret;
ninfo("Bringing up: %d.%d.%d.%d\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Configure the GMAC interface for normal operation. */
diff --git a/drivers/net/encx24j600.c b/drivers/net/encx24j600.c
index 99b33a29c2..2bdbacba0e 100644
--- a/drivers/net/encx24j600.c
+++ b/drivers/net/encx24j600.c
@@ -2120,8 +2120,8 @@ static int enc_ifup(struct net_driver_s *dev)
int ret;
ninfo("Bringing up: %d.%d.%d.%d\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+(int)((dev->d_ipaddr >> 16) & 0xff), (int)(dev->d_ipaddr >> 24));
/* Lock the SPI bus so that we have exclusive access */
@@ -2188,8 +2188,8 @@ static int enc_ifdown(struct net_driver_s *dev)
int ret;
ninfo("Taking down: %d.%d.%d.%d\n",
-dev->d_ipaddr & 0xff, (dev->d_ipaddr >> 8) & 0xff,
-(dev->d_ipaddr >> 16) & 0xff, dev->d_ipaddr >> 24);
+(int)(dev->d_ipaddr & 0xff), (int)((dev->d_ipaddr >> 8) & 0xff),
+
[incubator-nuttx] 11/26: Fix chip/s32k3xx_fs26.c:249:31: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int')
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 987d2561c0e732a9da28b1d13ab177e52d3f0b79
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:33:09 2022 +0800
Fix chip/s32k3xx_fs26.c:249:31: error: format specifies type 'unsigned
long' but the argument has type 'uint32_t' (aka 'unsigned int')
Signed-off-by: Xiang Xiao
---
arch/arm/src/s32k3xx/s32k3xx_fs26.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/src/s32k3xx/s32k3xx_fs26.c
b/arch/arm/src/s32k3xx/s32k3xx_fs26.c
index 2acf7c2d2a..e1c93a7652 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_fs26.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_fs26.c
@@ -246,7 +246,7 @@ uint32_t fs26_setreg(struct fs26_dev_s *priv, uint8_t
regaddr,
retval = __builtin_bswap32(retval);
#endif
- spiinfo("Received %08lx\n", retval);
+ spiinfo("Received %08" PRIx32 "\n", retval);
if (fs26_calcrc((uint8_t *), 3) != ((uint8_t *))[0])
{
@@ -316,7 +316,7 @@ uint32_t fs26_getreg(struct fs26_dev_s *priv, uint8_t
regaddr)
/* DEBUG print */
- spiinfo("%02x->%04lx\n", regaddr, retval);
+ spiinfo("%02x->%04" PRIx32 "\n", regaddr, retval);
return retval;
}
@@ -423,7 +423,7 @@ void fs26_initialize(struct spi_dev_s *spi)
if ((FS26_GET_DATA(retval) & (ABIST1_PASS_MASK | LBIST_STATUS_MASK))
!= (ABIST1_PASS | LBIST_STATUS_OK))
{
- spierr("FS26 DIAG failed %08lx\n", retval);
+ spierr("FS26 DIAG failed %08" PRIx32 "\n", retval);
}
/* Get state machine state */
[incubator-nuttx] 05/26: Fix chip/imxrt_enc.c:950:27: error: use of logical '&&' with constant operand
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9a50c30168cfbf275670e111ab72f902bebb2041
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:23:29 2022 +0800
Fix chip/imxrt_enc.c:950:27: error: use of logical '&&' with constant
operand
Signed-off-by: Xiang Xiao
---
arch/arm/src/imxrt/imxrt_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/src/imxrt/imxrt_enc.c b/arch/arm/src/imxrt/imxrt_enc.c
index d1cc4f3ba5..5640efaa49 100644
--- a/arch/arm/src/imxrt/imxrt_enc.c
+++ b/arch/arm/src/imxrt/imxrt_enc.c
@@ -951,7 +951,7 @@ static int imxrt_setup(struct qe_lowerhalf_s *lower)
imxrt_enc_putreg16(priv, IMXRT_ENC_TST_OFFSET, regval);
#endif
- if ((config->init_flags && XIE_SHIFT) == 1)
+ if (((config->init_flags >> XIE_SHIFT) & 1) != 0)
{
ret = irq_attach(config->irq, imxrt_enc_index, priv);
if (ret < 0)
@@ -1011,10 +1011,9 @@ static int imxrt_shutdown(struct qe_lowerhalf_s *lower)
/* Disable interrupts if used */
- if ((priv->config->init_flags && XIE_SHIFT) == 1)
+ if (((priv->config->init_flags >> XIE_SHIFT) & 1) != 0)
{
up_disable_irq(priv->config->irq);
-
irq_detach(priv->config->irq);
}
[incubator-nuttx] 02/26: Fix chip/imxrt_lpi2c.c:1254:1: error: unused function 'imxrt_lpi2c_getenabledints'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9f7d7c046a92dfe7bfbd609a933719d8b07f16c2
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:11:47 2022 +0800
Fix chip/imxrt_lpi2c.c:1254:1: error: unused function
'imxrt_lpi2c_getenabledints'
Signed-off-by: Xiang Xiao
---
arch/arm/src/imxrt/imxrt_lpi2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/src/imxrt/imxrt_lpi2c.c b/arch/arm/src/imxrt/imxrt_lpi2c.c
index 0b6d89b53d..499d26e502 100644
--- a/arch/arm/src/imxrt/imxrt_lpi2c.c
+++ b/arch/arm/src/imxrt/imxrt_lpi2c.c
@@ -1159,11 +1159,13 @@ imxrt_lpi2c_getstatus(struct imxrt_lpi2c_priv_s *priv)
*
/
+#ifdef CONFIG_IMXRT_LPI2C_DMA
static inline uint32_t
imxrt_lpi2c_getenabledints(struct imxrt_lpi2c_priv_s *priv)
{
return imxrt_lpi2c_getreg(priv, IMXRT_LPI2C_MIER_OFFSET);
}
+#endif
/
* Name: imxrt_lpi2c_isr_process
[incubator-nuttx] 09/26: Fix wireless/ieee80211/bcm43xxx/bcmf_gspi.c:151:20: error: unused function 'bcmf_gspi_write_reg_32'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 416d7301c4af56a020ce52dcf747a3d7ff70c2ff
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:31:14 2022 +0800
Fix wireless/ieee80211/bcm43xxx/bcmf_gspi.c:151:20: error: unused function
'bcmf_gspi_write_reg_32'
Signed-off-by: Xiang Xiao
---
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c
b/drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c
index 36462a64fb..f47372ef04 100644
--- a/drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c
+++ b/drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c
@@ -140,22 +140,6 @@ static inline uint8_t bcmf_gspi_read_reg_8(FAR gspi_dev_t
*gspi,
return buffer;
}
-/
- * Name: bcmf_gspi_write_reg_32
- *
- * Description:
- * Write a 32-bit register
- *
- /
-
-static inline void bcmf_gspi_write_reg_32(FAR gspi_dev_t *gspi,
- enum gspi_cmd_func_e function,
- uint32_t address,
- uint32_t value)
-{
- gspi->write(gspi, true, function, address, 4, );
-}
-
/
* Name: bcmf_gspi_write_reg_16
*
[incubator-nuttx] branch master updated (422272044b -> f2320a4a69)
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 422272044b boards/iperf: device name will vary across different NICs new 427f65ac28 Fix chip/imxrt_lpi2c.c:755:1: error: unused function 'imxrt_lpi2c_sem_waitstop' new 9f7d7c046a Fix chip/imxrt_lpi2c.c:1254:1: error: unused function 'imxrt_lpi2c_getenabledints' new 3ecf66415c Fix chip/imxrt_serial.c:1375:20: error: unused function 'imxrt_disableuartint' new 4913552140 Fix chip/imxrt_lpspi.c:553:23: error: unused function 'imxrt_lpspi_readbyte' new 9a50c30168 Fix chip/imxrt_enc.c:950:27: error: use of logical '&&' with constant operand new 232360cbd0 Fix chip/kinetis_enet.c:875:59: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int') new 6fd08787b6 Fix chip/kinetis_usbdev.c:3317:1: error: unused function 'khci_epreserved' new 658dfeaf40 Fix chip/kinetis_spi.c:473:23: error: unused function 'spi_getreg8' new 416d7301c4 Fix wireless/ieee80211/bcm43xxx/bcmf_gspi.c:151:20: error: unused function 'bcmf_gspi_write_reg_32' new e18d5870db Fix chip/s32k3xx_lpspi.c:719:23: error: unused function 's32k3xx_lpspi_readbyte' new 987d2561c0 Fix chip/s32k3xx_fs26.c:249:31: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int') new 670c3e0e35 Fix chip/s32k3xx_lpi2c.c:624:3: error: unused function 's32k3xx_lpi2c_sem_waitstop' new d8e53d7b4f Fix error: format specifies type 'unsigned long' but the argument has type 'unsigned int' new d3e282e561 Fix chip/s32k3xx_qspi.c:925:44: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int') new d01fbf77d0 Fix chip/sam4l_clockconfig.c:923:20: error: unused function 'sam_enable_fastwakeup' new 22768ede17 Fix chip/sam_tc.c:682:24: error: unused function 'sam_tc_getreg' new a4eeeb23de Fix sensors/mpu60x0.c:650:23: error: unused function '__mpu_read_who_am_i' new 3453fe799d Fix video/max7456.c:775:19: error: unused function '__mx7_write_reg__dmm' new 6af9afaa60 Fix error: more '%' conversions than data arguments new 720acac6af Fix chip/stm32_usbdev.c:929:20: error: unused function 'stm32_setstatusout' new 908bade7a7 Fix error: converting the result of '<<' to a boolean always evaluates to true new ffda739704 Fix error: shifting a negative signed value is undefined new 19138560f4 Fix error: variable 'buflen' is uninitialized when used here new f28cfbf2f3 Fix chip/stm32_eth.c:3358:20: error: unused function 'stm32_selectrmii' new 1a942c3c31 Fix lcd/ili9225.c:388:46: error: shift count >= width of type new f2320a4a69 Fix board/stm32_lcd.c:584:14: error: converting the result of '<<' to a boolean; did you mean '(7 << (10)) != 0'? The 26 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/src/imxrt/imxrt_enc.c | 5 +- arch/arm/src/imxrt/imxrt_lpi2c.c | 93 + arch/arm/src/imxrt/imxrt_lpspi.c | 94 - arch/arm/src/imxrt/imxrt_serial.c | 6 ++ arch/arm/src/kinetis/kinetis_enet.c| 2 +- arch/arm/src/kinetis/kinetis_spi.c | 23 - arch/arm/src/kinetis/kinetis_usbdev.c | 12 --- arch/arm/src/s32k1xx/s32k1xx_enet.c| 8 +- arch/arm/src/s32k3xx/s32k3xx_emac.c| 12 +-- arch/arm/src/s32k3xx/s32k3xx_fs26.c| 6 +- arch/arm/src/s32k3xx/s32k3xx_lpi2c.c | 97 +- arch/arm/src/s32k3xx/s32k3xx_lpspi.c | 58 - arch/arm/src/s32k3xx/s32k3xx_qspi.c| 3 +- arch/arm/src/sam34/sam4l_clockconfig.c | 3 + arch/arm/src/sama5/sam_tc.c| 54 arch/arm/src/samd5e5/sam_gmac.c| 4 +- arch/arm/src/samv7/sam_tc.c| 27 -- arch/arm/src/stm32/stm32_eth.c | 2 + arch/arm/src/stm32/stm32_usbdev.c | 24 +- arch/arm/src/stm32/stm32_usbfs.c | 24 +- arch/arm/src/stm32f0l0g0/stm32_usbdev.c| 23 + arch/arm/src/stm32f7/stm32_ethernet.c | 2 + arch/arm/src/stm32h7/stm32_ethernet.c | 2 + arch/arm/src/stm32l4/stm32l4_usbdev.c | 2 +- arch/mips/src/pic32mx/pic32mx_usbdev.c | 2 +- .../arm/stm32/fire-stm32v2/src/stm32_selectlcd.c | 4 +- .../arm/stm32/nucleo-l152re/src/stm32_ili93418b.c | 19 ++---
[incubator-nuttx] 03/26: Fix chip/imxrt_serial.c:1375:20: error: unused function 'imxrt_disableuartint'
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 3ecf66415c97c3ecc131a46e961277a1a19816a3
Author: Xiang Xiao
AuthorDate: Sat Nov 19 12:14:32 2022 +0800
Fix chip/imxrt_serial.c:1375:20: error: unused function
'imxrt_disableuartint'
and chip/imxrt_serial.c:1400:20: error: unused function
'imxrt_restoreuartint'
Signed-off-by: Xiang Xiao
---
arch/arm/src/imxrt/imxrt_serial.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/src/imxrt/imxrt_serial.c
b/arch/arm/src/imxrt/imxrt_serial.c
index 8b166ee22d..f4017e76b6 100644
--- a/arch/arm/src/imxrt/imxrt_serial.c
+++ b/arch/arm/src/imxrt/imxrt_serial.c
@@ -530,10 +530,12 @@ static inline uint32_t imxrt_serialin(struct imxrt_uart_s
*priv,
uint32_t offset);
static inline void imxrt_serialout(struct imxrt_uart_s *priv,
uint32_t offset, uint32_t value);
+#if defined(CONFIG_SERIAL_TERMIOS) || defined(CONSOLE_DEV)
static inline void imxrt_disableuartint(struct imxrt_uart_s *priv,
uint32_t *ie);
static inline void imxrt_restoreuartint(struct imxrt_uart_s *priv,
uint32_t ie);
+#endif
static int imxrt_setup(struct uart_dev_s *dev);
static void imxrt_shutdown(struct uart_dev_s *dev);
@@ -1380,6 +1382,7 @@ static int imxrt_dma_nextrx(struct imxrt_uart_s *priv)
* Name: imxrt_disableuartint
/
+#if defined(CONFIG_SERIAL_TERMIOS) || defined(CONSOLE_DEV)
static inline void imxrt_disableuartint(struct imxrt_uart_s *priv,
uint32_t *ie)
{
@@ -1400,11 +1403,13 @@ static inline void imxrt_disableuartint(struct
imxrt_uart_s *priv,
imxrt_serialout(priv, IMXRT_LPUART_CTRL_OFFSET, regval);
spin_unlock_irqrestore(NULL, flags);
}
+#endif
/
* Name: imxrt_restoreuartint
/
+#if defined(CONFIG_SERIAL_TERMIOS) || defined(CONSOLE_DEV)
static inline void imxrt_restoreuartint(struct imxrt_uart_s *priv,
uint32_t ie)
{
@@ -1422,6 +1427,7 @@ static inline void imxrt_restoreuartint(struct
imxrt_uart_s *priv,
imxrt_serialout(priv, IMXRT_LPUART_CTRL_OFFSET, regval);
spin_unlock_irqrestore(NULL, flags);
}
+#endif
/
* Name: imxrt_dma_setup
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7622: Fix clang compiler warning
pkarashchenko merged PR #7622: URL: https://github.com/apache/incubator-nuttx/pull/7622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: netutils: correct iperf thread name
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 63e3c6c52 netutils: correct iperf thread name
63e3c6c52 is described below
commit 63e3c6c52180d54133ee3bf1499c485714745b15
Author: chao an
AuthorDate: Sun Nov 20 17:35:58 2022 +0800
netutils: correct iperf thread name
Signed-off-by: chao an
---
netutils/iperf/iperf.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/netutils/iperf/iperf.c b/netutils/iperf/iperf.c
index 0d83974b4..042963cfb 100644
--- a/netutils/iperf/iperf.c
+++ b/netutils/iperf/iperf.c
@@ -22,6 +22,7 @@
* Included Files
/
+#include
#include
#include
#include
@@ -234,6 +235,8 @@ static void iperf_report_task(void *arg)
uintmax_t now_len;
int ret;
+ prctl(PR_SET_NAME, IPERF_REPORT_TASK_NAME);
+
now_len = s_iperf_ctrl.total_len;
ret = clock_gettime(CLOCK_MONOTONIC, );
if (ret != 0)
@@ -308,7 +311,7 @@ static int iperf_start_report(void)
pthread_attr_setstacksize(, IPERF_REPORT_TASK_STACK);
ret = pthread_create(, , (void *)iperf_report_task,
- IPERF_REPORT_TASK_NAME);
+ NULL);
if (ret != 0)
{
printf("iperf_thread: pthread_create failed: %d, %s\n",
@@ -666,6 +669,8 @@ static int iperf_run_tcp_client(void)
static void iperf_task_traffic(void *arg)
{
+ prctl(PR_SET_NAME, IPERF_TRAFFIC_TASK_NAME);
+
if (iperf_is_udp_client())
{
iperf_run_udp_client();
@@ -772,7 +777,7 @@ int iperf_start(struct iperf_cfg_t *cfg)
pthread_attr_setschedparam(, );
pthread_attr_setstacksize(, IPERF_TRAFFIC_TASK_STACK);
ret = pthread_create(, , (void *)iperf_task_traffic,
- IPERF_TRAFFIC_TASK_NAME);
+ NULL);
if (ret != 0)
{
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1431: netutils: correct iperf thread name
xiaoxiang781216 merged PR #1431: URL: https://github.com/apache/incubator-nuttx-apps/pull/1431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1434: dhcp: Make the option dependence work for usrsock case
xiaoxiang781216 opened a new pull request, #1434: URL: https://github.com/apache/incubator-nuttx-apps/pull/1434 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: boards/iperf: device name will vary across different NICs
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 422272044b boards/iperf: device name will vary across different NICs 422272044b is described below commit 422272044b342ecf149a07cdfeddd504be1a0d26 Author: chao an AuthorDate: Sun Nov 20 18:49:14 2022 +0800 boards/iperf: device name will vary across different NICs Signed-off-by: chao an --- boards/arm/cxd56xx/spresense/configs/rndis/defconfig | 1 - boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig | 1 - boards/arm/imx6/sabre-6quad/configs/netknsh/defconfig | 1 - boards/arm/imx6/sabre-6quad/configs/netknsh_smp/defconfig | 1 - boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig | 1 - boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig | 1 - boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig| 1 - boards/arm/imxrt/imxrt1064-evk/configs/netnsh/defconfig| 1 - boards/arm/lc823450/lc823450-xgevk/configs/rndis/defconfig | 1 - boards/arm/stm32/stm32f4discovery/configs/rndis/defconfig | 1 - boards/arm/stm32h7/nucleo-h743zi2/configs/jumbo/defconfig | 1 - boards/arm/tiva/lm3s6965-ek/configs/discover/defconfig | 1 - boards/risc-v/litex/arty_a7/configs/netnsh/defconfig | 1 - 13 files changed, 13 deletions(-) diff --git a/boards/arm/cxd56xx/spresense/configs/rndis/defconfig b/boards/arm/cxd56xx/spresense/configs/rndis/defconfig index 8c8477d09a..99a62a125e 100644 --- a/boards/arm/cxd56xx/spresense/configs/rndis/defconfig +++ b/boards/arm/cxd56xx/spresense/configs/rndis/defconfig @@ -88,7 +88,6 @@ CONFIG_NETUTILS_FTPD=y CONFIG_NETUTILS_HTTPD_DIRLIST=y CONFIG_NETUTILS_HTTPD_SENDFILE=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_WEBCLIENT=y CONFIG_NETUTILS_WEBSERVER=y diff --git a/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig b/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig index bd96607839..c317410632 100644 --- a/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig +++ b/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig @@ -90,7 +90,6 @@ CONFIG_NETUTILS_FTPD=y CONFIG_NETUTILS_HTTPD_DIRLIST=y CONFIG_NETUTILS_HTTPD_SENDFILE=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_WEBCLIENT=y CONFIG_NETUTILS_WEBSERVER=y diff --git a/boards/arm/imx6/sabre-6quad/configs/netknsh/defconfig b/boards/arm/imx6/sabre-6quad/configs/netknsh/defconfig index 2ba467f6f8..379783e3da 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netknsh/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netknsh/defconfig @@ -79,7 +79,6 @@ CONFIG_NETINIT_IPADDR=0x0a00020f CONFIG_NETINIT_NOMAC=y CONFIG_NETUTILS_CODECS=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_TFTPC=y CONFIG_NETUTILS_WEBCLIENT=y diff --git a/boards/arm/imx6/sabre-6quad/configs/netknsh_smp/defconfig b/boards/arm/imx6/sabre-6quad/configs/netknsh_smp/defconfig index 58bce0a311..a11c47f838 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netknsh_smp/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netknsh_smp/defconfig @@ -79,7 +79,6 @@ CONFIG_NETINIT_IPADDR=0x0a00020f CONFIG_NETINIT_NOMAC=y CONFIG_NETUTILS_CODECS=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_TFTPC=y CONFIG_NETUTILS_WEBCLIENT=y diff --git a/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig b/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig index 06e57da484..949f74df2b 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig @@ -72,7 +72,6 @@ CONFIG_NETINIT_IPADDR=0x0a00020f CONFIG_NETINIT_NOMAC=y CONFIG_NETUTILS_CODECS=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_TFTPC=y CONFIG_NETUTILS_WEBCLIENT=y diff --git a/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig b/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig index fe40748c7e..7cc8af2e09 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig @@ -55,7 +55,6 @@ CONFIG_NETINIT_IPADDR=0x0a00020f CONFIG_NETINIT_NOMAC=y CONFIG_NETUTILS_CODECS=y CONFIG_NETUTILS_IPERF=y -CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" CONFIG_NETUTILS_TELNETD=y CONFIG_NETUTILS_TFTPC=y CONFIG_NETUTILS_WEBCLIENT=y diff --git a/boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig b/boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig index 081cd3078c..ccbdd1dcad 100644 --- a/boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig +++ b/boards/arm/imxrt/imxrt1060-evk/configs/netnsh/defconfig @@ -34,7 +34,6 @@
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7626: boards/iperf: device name will vary across different NICs
xiaoxiang781216 merged PR #7626: URL: https://github.com/apache/incubator-nuttx/pull/7626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: netutils/iperf: add more default device name
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new a3390417f netutils/iperf: add more default device name a3390417f is described below commit a3390417f7c0c106902415bde077e83fc4c71315 Author: chao an AuthorDate: Sun Nov 20 17:27:13 2022 +0800 netutils/iperf: add more default device name Signed-off-by: chao an --- netutils/iperf/Kconfig | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/netutils/iperf/Kconfig b/netutils/iperf/Kconfig index 7d310198d..ec9738c15 100644 --- a/netutils/iperf/Kconfig +++ b/netutils/iperf/Kconfig @@ -32,6 +32,12 @@ config NETUTILS_IPERF_STACKSIZE config NETUTILS_IPERFTEST_DEVNAME string "iperf Network device" - default "wlan0" + default "wlan0" if DRIVERS_IEEE80211 + default "wpan0" if NET_6LOWPAN + default "sl0" if NET_SLIP + default "tun0" if NET_TUN + default "can0" if NET_CAN + default "eth0" if NET_ETHERNET + default "lo" # if NET_LOOPBACK endif
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1430: netutils/iperf: add more default device name
xiaoxiang781216 merged PR #1430: URL: https://github.com/apache/incubator-nuttx-apps/pull/1430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7627: Refine net/usrsock Kconfig option
xiaoxiang781216 opened a new pull request, #7627: URL: https://github.com/apache/incubator-nuttx/pull/7627 ## Summary - net/usrsock: Remove NET_USRSOCK_NO_INET[6] - net/udp: NET_BROADCAST shouldn't configurable if NET_UDP_NO_STACK enable - net/tcp: Remove the dependence on SCHED_WORKQUEUE - net/usrsock: Should select NET_[UDP|TCP]_NO_STACK instead NET_[UDP|TCP] - net/usrsock: Split NET_USRSOCK_OTHER to NET_USRSOCK_ICMP[v6] - boards: Refresh ursock related config ## Impact usrsock configuration ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1429: system/ping: remove depends since NETUTILS_PING already contains this check
xiaoxiang781216 merged PR #1429: URL: https://github.com/apache/incubator-nuttx-apps/pull/1429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: system/ping: remove depends since NETUTILS_PING already contains this check
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new c81da4c18 system/ping: remove depends since NETUTILS_PING already contains this check c81da4c18 is described below commit c81da4c185c212de9cf19e35840037b30e8cf7c5 Author: chao an AuthorDate: Sun Nov 20 16:51:05 2022 +0800 system/ping: remove depends since NETUTILS_PING already contains this check Signed-off-by: chao an --- system/ping/Kconfig | 1 - system/ping6/Kconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/system/ping/Kconfig b/system/ping/Kconfig index 37b7ef305..7559ac2e9 100644 --- a/system/ping/Kconfig +++ b/system/ping/Kconfig @@ -6,7 +6,6 @@ config SYSTEM_PING tristate "ICMP 'ping' command" default n - depends on NET_ICMP || NET_ICMP_NO_STACK select NETUTILS_PING ---help--- Enable support for the ICMP 'ping' command. diff --git a/system/ping6/Kconfig b/system/ping6/Kconfig index 90008e2bc..b67543140 100644 --- a/system/ping6/Kconfig +++ b/system/ping6/Kconfig @@ -6,7 +6,6 @@ config SYSTEM_PING6 tristate "ICMPv6 'ping6' command" default n - depends on NET_ICMPv6 || NET_ICMPv6_NO_STACK select NETUTILS_PING6 ---help--- Enable support for the ICMP 'ping' command.
[incubator-nuttx] branch master updated (6898409d04 -> f9479885ba)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 6898409d04 net/icmp[v6]: ICMP[v6]_NO_STACK should not depends on NET_IPv4/6 add f9479885ba arch/arm64: Move group_addrenv to arm64_syscall_switch No new revisions were added by this update. Summary of changes: arch/arm64/src/common/arm64_blocktask.c | 9 - arch/arm64/src/common/arm64_exit.c| 10 -- arch/arm64/src/common/arm64_releasepending.c | 9 - arch/arm64/src/common/arm64_reprioritizertr.c | 9 - arch/arm64/src/common/arm64_syscall.c | 14 -- arch/arm64/src/common/arm64_unblocktask.c | 9 - 6 files changed, 12 insertions(+), 48 deletions(-)
[GitHub] [incubator-nuttx] acassis merged pull request #7623: arch/arm64: Move group_addrenv to arm64_syscall_switch
acassis merged PR #7623: URL: https://github.com/apache/incubator-nuttx/pull/7623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (63bcca985f -> 6898409d04)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 63bcca985f arch/armv7-r: Don't clear SCTLR_U bit since spec require it's always one add 6898409d04 net/icmp[v6]: ICMP[v6]_NO_STACK should not depends on NET_IPv4/6 No new revisions were added by this update. Summary of changes: net/icmp/Kconfig| 2 -- net/icmpv6/Kconfig | 2 -- net/utils/Make.defs | 8 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
[GitHub] [incubator-nuttx] acassis merged pull request #7625: net/icmp: ICMP_NO_STACK should not depends on NET_IPv4
acassis merged PR #7625: URL: https://github.com/apache/incubator-nuttx/pull/7625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request, #1433: system/vi: fix nxstyle warning
anchao opened a new pull request, #1433: URL: https://github.com/apache/incubator-nuttx-apps/pull/1433 ## Summary ``` system/vi: fix nxstyle warning system/vi/vi.c:540:57: error: Multiple data definitions system/vi/vi.c:541:54: error: Multiple data definitions Signed-off-by: chao an ``` ## Impact N/A ## Testing ci-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] 01/02: Fix Error: vi.c:888:57: error: format string is not a string literal (potentially insecure)
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit d706510064be474783881d69c30d8669ae7de18b Author: Xiang Xiao AuthorDate: Sun Nov 20 04:11:35 2022 +0800 Fix Error: vi.c:888:57: error: format string is not a string literal (potentially insecure) Signed-off-by: Xiang Xiao --- system/vi/vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/vi/vi.c b/system/vi/vi.c index 7baff382d..0b23da4fb 100644 --- a/system/vi/vi.c +++ b/system/vi/vi.c @@ -885,7 +885,7 @@ static void vi_printf(FAR struct vi_s *vi, FAR const char *prefix, /* Expand the prefix message in the scratch buffer */ - len = prefix ? snprintf(vi->scratch, SCRATCH_BUFSIZE, prefix) : 0; + len = prefix ? snprintf(vi->scratch, SCRATCH_BUFSIZE, "%s", prefix) : 0; va_start(ap, fmt); len += vsnprintf(vi->scratch + len, SCRATCH_BUFSIZE - len, fmt, ap);
[incubator-nuttx-apps] 02/02: Fix ft80x_coprocessor.c:3911:14: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int')
This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit bce24201c7c7aa902de7f746d45b8631851c955c
Author: Xiang Xiao
AuthorDate: Sun Nov 20 06:25:49 2022 +0800
Fix ft80x_coprocessor.c:3911:14: error: format specifies type 'unsigned
long' but the argument has type 'uint32_t' (aka 'unsigned int')
Signed-off-by: Xiang Xiao
---
examples/ft80x/ft80x_coprocessor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/examples/ft80x/ft80x_coprocessor.c
b/examples/ft80x/ft80x_coprocessor.c
index 1e56f0a88..0060f6670 100644
--- a/examples/ft80x/ft80x_coprocessor.c
+++ b/examples/ft80x/ft80x_coprocessor.c
@@ -3907,7 +3907,8 @@ int ft80x_coproc_calibrate(int fd, FAR struct
ft80x_dlbuffer_s *buffer)
return ret;
}
- ft80x_info("Transform A-F: {%08lx, %08lx, %08lx, %08lx, %08lx, %08lx}\n",
+ ft80x_info("Transform A-F: {%08" PRIx32 ", %08" PRIx32 ", %08"
+ PRIx32 ", %08" PRIx32 ", %08" PRIx32 ", %08" PRIx32 "}\n",
matrix[0], matrix[1], matrix[2],
matrix[3], matrix[4], matrix[5]);
return OK;
[incubator-nuttx-apps] branch master updated (bb24794fc -> bce24201c)
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from bb24794fc system/ping[6]: ping[6] should also be enabled if NET_ICMP[v6]_NO_STACK == y new d70651006 Fix Error: vi.c:888:57: error: format string is not a string literal (potentially insecure) new bce24201c Fix ft80x_coprocessor.c:3911:14: error: format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int') The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: examples/ft80x/ft80x_coprocessor.c | 3 ++- system/vi/vi.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx-apps] anchao merged pull request #1427: Fix Error: vi.c:888:57: error: format string is not a string literal(potentially insecure)
anchao merged PR #1427: URL: https://github.com/apache/incubator-nuttx-apps/pull/1427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao commented on pull request #1430: netutils/iperf: add more default device name
anchao commented on PR #1430: URL: https://github.com/apache/incubator-nuttx-apps/pull/1430#issuecomment-1321099137 Depends on https://github.com/apache/incubator-nuttx/pull/7626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7626: boards/iperf: device name will vary across different NICs
anchao opened a new pull request, #7626: URL: https://github.com/apache/incubator-nuttx/pull/7626 ## Summary boards/iperf: device name will vary across different NICs Depends on: https://github.com/apache/incubator-nuttx-apps/pull/1430 ## Impact N/A ## Testing iperf test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request, #1432: netutils/iperf: add support of multi-instance
anchao opened a new pull request, #1432: URL: https://github.com/apache/incubator-nuttx-apps/pull/1432 ## Summary netutils/iperf: add support of multi-instance ## Impact N/A ## Testing iperf test on different port -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request, #1431: netutils: correct iperf thread name
anchao opened a new pull request, #1431: URL: https://github.com/apache/incubator-nuttx-apps/pull/1431 ## Summary netutils: correct iperf thread name ## Impact N/A ## Testing Before: ``` 7 7 100 FIFO Task--- Waiting Semaphore 067504 iperf -s -i 1 14 7 100 FIFO pthread --- Waiting Semaphore 069600 pt-0x5665f854 0x566786f9 15 7 100 FIFO pthread --- Waiting Signal 069600 pt-0x5665eb01 0x5667856b ``` After: ``` 7 7 100 FIFO Task--- Waiting Semaphore 067504 iperf -s -i 1 14 7 100 FIFO pthread --- Waiting Semaphore 069600 iperf_traffic 0 15 7 100 FIFO pthread --- Waiting Signal 069600 iperf_report 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
