[GitHub] [nuttx] GooTal commented on pull request #6242: rv-virt:knsh64
GooTal commented on PR #6242: URL: https://github.com/apache/nuttx/pull/6242#issuecomment-1409910314 > By "added" did you run `make menuconfig` or add them by hand? `make menuconfig` is needed to insure the dependency. Oh sorry. I added them by hand. Thanks @davids5. It\`s really helpful that using menuconfig to ensure the dependency. And thanks a lot @masayuki2009 . I just noticed this in `nuttx/libs/libc/builtin/Kconfig` so that the menuconfig do not show this option. ``` config BUILTIN bool "Support Builtin Applications" default n depends on !BUILD_KERNEL ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #6242: rv-virt:knsh64
masayuki2009 commented on PR #6242: URL: https://github.com/apache/nuttx/pull/6242#issuecomment-1409905854 @GooTal >BTW, can knsh64 run ostest? I notice that rv-virt:nsh64 got some built-in apps: Currently, no. Because the ostest uses some non-POISX API (i.e. task_create) which can not be used for BUILD_KERNEL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure
pussuw commented on code in PR #8355:
URL: https://github.com/apache/nuttx/pull/8355#discussion_r1091552332
##
sched/addrenv/addrenv.c:
##
@@ -0,0 +1,523 @@
+/
+ * sched/addrenv/addrenv.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include "sched/sched.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+/
+ * Private Functions
+ /
+
+/
+ * Name: addrenv_dsr
+ *
+ * Description:
+ * Deferred service routine for destroying an address environment. This is
+ * so that the heavy lifting is not done when the context is switching, or
+ * from ISR.
+
+ * Input Parameters:
+ * arg - Contains pointer to the address environment that is freed
+ *
+ * Returned Value:
+ * None
+ *
+ /
+
+static void addrenv_dsr(FAR void *arg)
+{
+ FAR struct addrenv_s *addrenv = (FAR struct addrenv_s *)arg;
+
+ /* Destroy the address environment */
+
+ up_addrenv_destroy(>pgdir);
+
+ /* Then finally release the memory */
+
+ kmm_free(addrenv);
+}
+
+/
+ * Public Data
+ /
+
+/* This variable holds the current address environment. These contents are
+ * _never_ NULL, besides when the system is started and there are only the
+ * initial kernel mappings available.
+ *
+ * This must only be accessed with interrupts disabled.
+ */
+
+static FAR struct addrenv_s *g_addrenv[CONFIG_SMP_NCPUS];
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: addrenv_switch
+ *
+ * Description:
+ * Instantiate the group address environment for the current thread at the
+ * the head of the ready to run list.
+ *
+ * This function is called from platform-specific code after any context
+ * switch (i.e., after any change in the thread at the head of the
+ * ready-to-run list). This function will change the address environment
+ * if the new thread is part of a different task group.
+ *
+ * Input Parameters:
+ * tcb - The TCB of thread that needs an address environment. This should
+ * be the TCB at the head of the ready-to-run list, but that is not
+ * enough.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. A negated errno value is returned on
+ * any failure.
+ *
+ * Assumptions:
+ * This function should only be called within critical OS sections with
+ * interrupts disabled. Interrupts are disabled internally just to be
+ * certain, however.
+ *
+ /
+
+int addrenv_switch(FAR struct tcb_s *tcb)
+{
+ FAR struct addrenv_s *curr;
+ FAR struct addrenv_s *next;
+ irqstate_t flags;
+ int cpu;
+ int ret;
+
+ /* NULL for the tcb means to use the TCB of the task at the head of the
+ * ready to run list.
+ */
+
+ if (!tcb)
+{
+ tcb = this_task();
+}
+
+ DEBUGASSERT(tcb);
+ next = tcb->mm_curr;
+
+ /* Does the group have an address environment? */
+
+ if (!next)
+{
+ /* No... just return perhaps leaving a different address environment
+ * intact.
+ */
+
+ return OK;
+}
+
[GitHub] [nuttx] davids5 commented on pull request #6242: rv-virt:knsh64
davids5 commented on PR #6242: URL: https://github.com/apache/nuttx/pull/6242#issuecomment-1409882231 By "added" did you run `make menuconfig` or add them by hand? `make menuconfig` is needed to insure the dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on pull request #8371: Change sec2tick macros to round up
btashton commented on PR #8371: URL: https://github.com/apache/nuttx/pull/8371#issuecomment-1409880880 This looks reasonable to me, but it would be really good to validate that we have not broken anything on a few different core platforms. Maybe not prior to merging but at least prior to the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] GUIDINGLI opened a new pull request, #8372: arch:xtena: modify timer interrupt level large to XCHAL_IRQ_LEVEL level
GUIDINGLI opened a new pull request, #8372: URL: https://github.com/apache/nuttx/pull/8372 ## Summary arch:xtena: modify timer interrupt level large to XCHAL_IRQ_LEVEL level. ## Impact xtensa timer ## Testing VELA Xiaomi watch S1 pro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (372fee9412 -> 55679aec5f)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 372fee9412 Added SocketCAN driver implementation to the tiva chip, modified the EK-TC1294XL launchpad board to use the new SocketCAN API add 55679aec5f drivers/camera: Support the private data for imgsensor and imgdata No new revisions were added by this update. Summary of changes: arch/arm/src/cxd56xx/cxd56_cisif.c | 131 --- arch/sim/src/sim/sim_video.c | 209 +- drivers/video/isx012.c | 139 +++ drivers/video/isx019.c | 766 - drivers/video/video.c | 213 --- include/nuttx/video/imgdata.h | 45 ++- include/nuttx/video/imgsensor.h| 75 +++- 7 files changed, 857 insertions(+), 721 deletions(-)
[GitHub] [nuttx] jerpelea merged pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata
jerpelea merged PR #8230: URL: https://github.com/apache/nuttx/pull/8230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine commented on issue #8346: Regression in many places due to change of nxsem_timedwait_uninterruptible with nxsem_tickwait_uninterruptible
jlaitine commented on issue #8346: URL: https://github.com/apache/nuttx/issues/8346#issuecomment-1409853979 I decided to make a PR #8371 of the proposed change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine opened a new pull request, #8371: Change sec2tick macros to round up
jlaitine opened a new pull request, #8371: URL: https://github.com/apache/nuttx/pull/8371 ## Summary This change is discussed in https://github.com/apache/nuttx/issues/8346 ; in short, this proposes changing USEC2TICK, MSEC2TICK and SEC2TICK to round up instead of round to nearest. This is the same practice that is used in many other OSs (like linux msecs_to_jiffies ; when converting a value to ticks the integer result is always greater or equivalent of the exact result. The rationale behind this change is that typical use is a timeout or schedule wq event. That is, to go to sleep for *at least* N msec. ## Impact This fixes regression in i2c drivers, networking and iob caused by https://github.com/apache/nuttx/commit/1fb8c13e5e80ee4cd5758e76821378162451c2fa ## Testing It has been tested that the change fixes the found problems on stm32f7 and mpfs targets with 10ms systick. However, this affects many drivers in many platforms, I am not able to test them all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1517: netutils/cjson: fix unpackage error when local gerrit does not exist
xiaoxiang781216 commented on code in PR #1517: URL: https://github.com/apache/nuttx-apps/pull/1517#discussion_r1091510457 ## netutils/cjson/Makefile: ## @@ -54,7 +54,7 @@ $(CJSON_TARBALL): $(CJSON_UNPACKNAME): $(CJSON_TARBALL) @echo "Unpacking: $(CJSON_TARBALL) -> $(CJSON_UNPACKNAME)" - $(Q) $(UNPACK) $(CJSON_TARBALL) + $(Q) $(UNPACK) $(CJSON_TARBALL) --one-top-level=$(CJSON_UNPACKNAME) --strip-components=1 Review Comment: let's change to mv? I am afraid that unzip on other OS mayn't support --one-top-level --strip-components -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #8347: tools: compile with full file path
Gary-Hobson commented on PR #8347: URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1409829481 > @Gary-Hobson this patch need rebase Done， need to merge https://github.com/apache/nuttx-apps/pull/1515 before merging this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: Added SocketCAN driver implementation to the tiva chip, modified the EK-TC1294XL launchpad board to use the new SocketCAN API
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 372fee9412 Added SocketCAN driver implementation to the tiva chip, modified the EK-TC1294XL launchpad board to use the new SocketCAN API 372fee9412 is described below commit 372fee9412bbdffb13cb8cb14916b8220f6c03fe Author: David Vosahlik AuthorDate: Wed Jan 25 15:38:02 2023 +0100 Added SocketCAN driver implementation to the tiva chip, modified the EK-TC1294XL launchpad board to use the new SocketCAN API --- arch/arm/src/tiva/Kconfig | 71 +- arch/arm/src/tiva/Make.defs |6 +- arch/arm/src/tiva/common/tiva_sock_can.c | 2373 + arch/arm/src/tiva/tiva_can.h | 19 +- boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c | 30 + 5 files changed, 2473 insertions(+), 26 deletions(-) diff --git a/arch/arm/src/tiva/Kconfig b/arch/arm/src/tiva/Kconfig index c5935ad070..0a3dd5b180 100644 --- a/arch/arm/src/tiva/Kconfig +++ b/arch/arm/src/tiva/Kconfig @@ -436,7 +436,6 @@ config TIVA_CAN bool default n select CAN - select ARCH_HAVE_CAN_ERRORS select CAN_TXREADY select CAN_USE_RTR @@ -612,33 +611,12 @@ config TIVA_CAN0 default n depends on TIVA_HAVE_CAN0 select TIVA_CAN - -config TIVA_CAN0_PRIO - int "CAN0 kthread priority" - default 300 - depends on TIVA_CAN0 - ---help--- - The Tiva CAN driver retrieves messages using a kthread rather - than in the ISR or using a work queue. The ISR signals the - kthread, but the kthread can be preempted if needed. This - option sets the thread priority for CAN module 0. - config TIVA_CAN1 bool "CAN1" default n depends on TIVA_HAVE_CAN1 select TIVA_CAN -config TIVA_CAN1_PRIO - int "CAN1 kthread priority" - default 300 - depends on TIVA_CAN1 - ---help--- - The Tiva CAN driver retrieves messages using a kthread rather - than in the ISR or using a work queue. The ISR signals the - kthread, but the kthread can be preempted if needed. This - option sets the thread priority for CAN module 1. - config TIVA_QEI0 bool "QEI0" default n @@ -1520,10 +1498,55 @@ endif # TIVA_ADC menu "CAN Driver Configuration" depends on TIVA_CAN +choice + prompt "CAN bus driver selection" + default TIVA_SOCKET_CAN + +config TIVA_SOCKET_CAN + bool "Use SocketCAN driver" + depends on (TIVA_CAN0 || TIVA_CAN1) && NET_CAN + select NET_CAN_HAVE_ERRORS + +config TIVA_CHAR_DEV_CAN + bool "Character device driver" + depends on (TIVA_CAN0 || TIVA_CAN1) && !NET_CAN + select ARCH_HAVE_CAN_ERRORS + +endchoice # CAN driver selection + +config TIVA_CAN0_PRIO + int "CAN0 kthread priority" + default 300 + depends on TIVA_CAN0 && TIVA_CHAR_DEV_CAN + ---help--- + The Tiva CAN driver retrieves messages using a kthread rather + than in the ISR or using a work queue. The ISR signals the + kthread, but the kthread can be preempted if needed. This + option sets the thread priority for CAN module 0. + +config TIVA_CAN0_BAUD + int "CAN0 baud rate kb/s" + default 125 + depends on TIVA_CAN0 && TIVA_SOCKET_CAN + +config TIVA_CAN1_BAUD + int "CAN1 baud rate kb/s" + default 125 + depends on TIVA_CAN1 && TIVA_SOCKET_CAN + +config TIVA_CAN1_PRIO + int "CAN1 kthread priority" + default 300 + depends on TIVA_CAN1 && TIVA_CHAR_DEV_CAN + ---help--- + The Tiva CAN driver retrieves messages using a kthread rather + than in the ISR or using a work queue. The ISR signals the + kthread, but the kthread can be preempted if needed. This + option sets the thread priority for CAN module 1. config TIVA_CAN_REGDEBUG bool "CAN register level debug" - depends on DEBUG_CAN_INFO + depends on DEBUG_CAN_INFO && TIVA_CHAR_DEV_CAN default n ---help--- Output detailed register-level CAN device debug information. @@ -1589,7 +1612,7 @@ config TIVA_CAN_ERR_HANDLER_PER int "Rate-limited error handling period (milliseconds)" range 10 1000 default 100 - depends on CAN_ERRORS + depends on CAN_ERRORS || NET_CAN_ERRORS ---help--- When error messages (CAN_ERRORS) are enabled, the Tiva CAN driver will disable interrupts for individual errors diff --git a/arch/arm/src/tiva/Make.defs b/arch/arm/src/tiva/Make.defs index
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8304: Added SocketCAN driver implementation to the tiva chip, modified the …
xiaoxiang781216 merged PR #8304: URL: https://github.com/apache/nuttx/pull/8304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8347: tools: compile with full file path
xiaoxiang781216 commented on PR #8347: URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1409813266 @Gary-Hobson this patch need rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8368: litex: Add GPIO driver.
xiaoxiang781216 commented on code in PR #8368:
URL: https://github.com/apache/nuttx/pull/8368#discussion_r1091483501
##
arch/risc-v/src/litex/hardware/litex_memorymap.h:
##
@@ -50,6 +50,20 @@
#define LITEX_TIMER0_BASE 0xf0006000
#define LITEX_UART0_BASE0xf0006800
+/* GPIO peripheral definitions.
+ * - LITEX_GPIO_BASE is the first 32-bit address which contains a block
+ *of GPIO registers (peripheral). Each block can contain up to 32 pins.
+ * - LITEX_GPIO_OFFSET is the number of bytes between each GPIO peripheral.
+ * - LITEX_GPIO_MAX is the number of peripherals enabled in gateware.
+ *
+ * Each peripheral is referenced by an index in the GPIO driver. E.g Index 0
+ * is the first GPIO peripheral at 0xF0008000. Index 1 is at 0xF00080020.
+ */
+
+#define LITEX_GPIO_BASE 0xF0008000
Review Comment:
```suggestion
#define LITEX_GPIO_BASE 0xf0008000
```
##
arch/risc-v/src/litex/litex_gpio.c:
##
@@ -0,0 +1,357 @@
+/
+ * arch/risc-v/src/litex/litex_gpio.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+
+#include "riscv_internal.h"
+#include "litex_gpio.h"
+#include "litex_memorymap.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+#define GPIO_REG_OE_OFFSET 0x00
+#define GPIO_REG_IN_OFFSET 0x04
+#define GPIO_REG_OUT_OFFSET 0x08
+#define GPIO_REG_MODE_OFFSET0x0C
+#define GPIO_REG_EDGE_OFFSET0x10
+#define GPIO_REG_EV_STATUS_OFFSET 0x14
+#define GPIO_REG_EV_PEND_OFFSET 0x18
+#define GPIO_REG_EV_ENABLE_OFFSET 0x1C
+
+#ifdef CONFIG_LITEX_GPIO_IRQ
+/* Helper to calculate the GPIO port index from an IRQ number. */
+#define irq_to_gpio_index(_irqno) (( _irqno - LITEX_IRQ_GPIO) % 32)
+
+/* Helper to calculate the extended IRQ number from GPIO port index. */
+#define gpio_index_to_irq(_i, _p) ((_i * 32) + _p + LITEX_FIRST_GPIOIRQ)
+#endif
+
+/
+ * Private Types
+ /
+
+/
+ * Private Functions Prototypes
+ /
+
+static uint32_t gpiobase_at(uint32_t index);
+
+#ifdef CONFIG_LITEX_GPIO_IRQ
+static void gpio_dispatch(int irq, uint32_t gpiobase, uint32_t * regs);
+static int litex_gpio_interrupt(int irq, void *context, void * arg);
+#endif
+
+/
+ * Private Data
+ /
+
+/* A lookup table to keep track of all the base addresses for all gateware
+ * defined GPIO peripherals. This saves calculating the actual base address
+ * in the ISR routines, as there is only an IRQ number available at that
+ * point.
+ *
+ * The actual memory addresses are populated the first time it is used.
+ */
+
+static uint32_t gpio_base_s[LITEX_GPIO_MAX] =
+{
+ 0
+};
+
+/
+ * Public Data
+ /
+
+/
+ * Private Functions
+ /
+
+static uint32_t gpiobase_at(uint32_t index)
+{
+ DEBUGASSERT(index < LITEX_GPIO_MAX);
+ if (gpio_base_s[0] == 0)
+{
+ for (int i = 0; i < LITEX_GPIO_MAX; i++)
+{
+ gpio_base_s[i] = LITEX_GPIO_BASE +
+
[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 3f97a87162c5d16a2cb17addaaab075d8338c4a3
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f8c24acd Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff
docs: 3f97a87162c5d16a2cb17addaaab075d8338c4a3
f8c24acd is described below
commit f8c24acd1b275c599670ec140bd7879085d7ca7c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Tue Jan 31 05:47:46 2023 +
Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs:
3f97a87162c5d16a2cb17addaaab075d8338c4a3
---
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/12.0.0/index.html | 2 +-
content/docs/12.0.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
17 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 7002b42a..9844b8c9 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 31 January 23 at 00:10
+Last Updated: 31 January 23 at 05:45
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index 1fcab5ea..71335b5e 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index 26117e4d..f3135f7a 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -147,7 +147,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 31 January 23 at 00:11
+Last Updated: 31 January 23 at 05:45
Table of
Contents
diff --git a/content/docs/10.0.1/searchindex.js
b/content/docs/10.0.1/searchindex.js
index 8982f54a..71335b5e 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
[GitHub] [nuttx-website] dependabot[bot] commented on pull request #85: Bump commonmarker from 0.23.6 to 0.23.7
dependabot[bot] commented on PR #85: URL: https://github.com/apache/nuttx-website/pull/85#issuecomment-1409796706 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] xiaoxiang781216 closed pull request #85: Bump commonmarker from 0.23.6 to 0.23.7
xiaoxiang781216 closed pull request #85: Bump commonmarker from 0.23.6 to 0.23.7 URL: https://github.com/apache/nuttx-website/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Bump activesupport from 6.0.6 to 6.0.6.1
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new b50f5ca4 Bump activesupport from 6.0.6 to 6.0.6.1 b50f5ca4 is described below commit b50f5ca4ed22743959c1160aab5dcc9ae18b3eff Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Tue Jan 31 04:21:46 2023 + Bump activesupport from 6.0.6 to 6.0.6.1 Bumps [activesupport](https://github.com/rails/rails) from 6.0.6 to 6.0.6.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v6.0.6...v6.0.6.1) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 5da05f46..3d7287e9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ GEM remote: https://rubygems.org/ specs: -activesupport (6.0.6) +activesupport (6.0.6.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -15,7 +15,7 @@ GEM coffee-script-source (1.11.1) colorator (1.1.0) commonmarker (0.23.6) -concurrent-ruby (1.1.10) +concurrent-ruby (1.2.0) dnsruby (1.61.9) simpleidn (~> 0.1) em-websocket (0.5.3) @@ -210,7 +210,7 @@ GEM jekyll (>= 3.5, < 5.0) jekyll-feed (~> 0.9) jekyll-seo-tag (~> 2.1) -minitest (5.16.3) +minitest (5.17.0) nokogiri (1.13.10-x86_64-linux) racc (~> 1.4) octokit (4.25.1) @@ -243,7 +243,7 @@ GEM thread_safe (0.3.6) typhoeus (1.4.0) ethon (>= 0.9.0) -tzinfo (1.2.10) +tzinfo (1.2.11) thread_safe (~> 0.1) unf (0.1.4) unf_ext
[GitHub] [nuttx-website] xiaoxiang781216 merged pull request #86: Bump activesupport from 6.0.6 to 6.0.6.1
xiaoxiang781216 merged PR #86: URL: https://github.com/apache/nuttx-website/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (74e032e924 -> 3f97a87162)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 74e032e924 drivers/pipes: fix write busy loop because POLLOUT always ready. add 3f97a87162 tools: add separate flags parameter for COMPILE/COMPILEXX No new revisions were added by this update. Summary of changes: arch/arm/src/Makefile| 2 +- arch/arm64/src/Makefile | 2 +- arch/risc-v/src/Makefile | 2 +- arch/sim/src/Makefile| 2 +- arch/xtensa/src/Makefile | 2 +- tools/Config.mk | 8 6 files changed, 9 insertions(+), 9 deletions(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8357: tools: add separate flags parameter for COMPILE/COMPILEXX
xiaoxiang781216 merged PR #8357: URL: https://github.com/apache/nuttx/pull/8357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] pengxiang-hao opened a new pull request, #1517: netutils/cjson: fix unpackage error when local gerrit does not exist
pengxiang-hao opened a new pull request, #1517: URL: https://github.com/apache/nuttx-apps/pull/1517 Signed-off-by: haopengxiang ## Summary if no cjson repo exist in local, download specific version cJSON and `tar` those into foler(cJSON), but not folder "v1.7.12.tar.gz" ## Impact fix error https://github.com/apache/nuttx-apps/issues/1516 with downloaded has ## Testing Local check without cJSON repo passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #8361: net/devif: check the net device before use
anchao commented on code in PR #8361:
URL: https://github.com/apache/nuttx/pull/8361#discussion_r1091462986
##
net/devif/devif_iobsend.c:
##
@@ -56,67 +57,53 @@ void devif_iob_send(FAR struct net_driver_s *dev, FAR
struct iob_s *iob,
unsigned int len, unsigned int offset,
unsigned int target_offset)
{
-#ifndef CONFIG_NET_IPFRAG
- unsigned int limit = NETDEV_PKTSIZE(dev) -
- NET_LL_HDRLEN(dev) - target_offset;
+ int ret;
- if (dev == NULL || len == 0 || len > limit)
-#else
if (dev == NULL || len == 0)
-#endif
{
- if (dev->d_iob == NULL)
-{
- iob_free_chain(iob);
-}
+ ret = -EINVAL;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[nuttx] branch master updated (004853d6d1 -> 74e032e924)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 004853d6d1 drivers/watchdog: Fix the wrong value of WATCHDOG_AUTOMONITOR_PING_INTERVAL add 74e032e924 drivers/pipes: fix write busy loop because POLLOUT always ready. No new revisions were added by this update. Summary of changes: drivers/pipes/pipe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8369: drivers/pipes: fix write busy loop because POLLOUT always ready.
xiaoxiang781216 merged PR #8369: URL: https://github.com/apache/nuttx/pull/8369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch dependabot/bundler/activesupport-6.0.6.1 created (now f958ec5f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/bundler/activesupport-6.0.6.1 in repository https://gitbox.apache.org/repos/asf/nuttx-website.git at f958ec5f Bump activesupport from 6.0.6 to 6.0.6.1 No new revisions were added by this update.
[GitHub] [nuttx-website] dependabot[bot] opened a new pull request, #86: Bump activesupport from 6.0.6 to 6.0.6.1
dependabot[bot] opened a new pull request, #86: URL: https://github.com/apache/nuttx-website/pull/86 Bumps [activesupport](https://github.com/rails/rails) from 6.0.6 to 6.0.6.1. Release notes Sourced from https://github.com/rails/rails/releases;>activesupport's releases. v6.0.6.1 Active Support No changes. Active Model No changes. Active Record Make sanitize_as_sql_comment more strict Though this method was likely never meant to take user input, it was attempting sanitization. That sanitization could be bypassed with carefully crafted input. This commit makes the sanitization more robust by replacing any occurrances of / or / with / or /. It also performs a first pass to remove one surrounding comment to avoid compatibility issues for users relying on the existing removal. This also clarifies in the documentation of annotate that it should not be provided user input. [CVE-2023-22794] Action View No changes. Action Pack No changes. Active Job No changes. ... (truncated) Commits https://github.com/rails/rails/commit/28bb76d3efc39b2ef663dfe2346f7c2621343cd6;>28bb76d Version 6.0.6.1 See full diff in https://github.com/rails/rails/compare/v6.0.6...v6.0.6.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nuttx-website/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (570c7587c7 -> 004853d6d1)
This is an automated email from the ASF dual-hosted git repository. ligd pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 570c7587c7 risc-v/Toolchain.defs: Correct indent add 004853d6d1 drivers/watchdog: Fix the wrong value of WATCHDOG_AUTOMONITOR_PING_INTERVAL No new revisions were added by this update. Summary of changes: drivers/timers/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [nuttx] GUIDINGLI merged pull request #8345: drivers/watchdog: Fix the wrong value of WATCHDOG_AUTOMONITOR_PING_INTERVAL
GUIDINGLI merged PR #8345: URL: https://github.com/apache/nuttx/pull/8345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on issue #1516: Unable to build cJSON
xiaoxiang781216 commented on issue #1516: URL: https://github.com/apache/nuttx-apps/issues/1516#issuecomment-1409700219 > This error is caused by this commit [ad31936](https://github.com/apache/nuttx-apps/commit/ad319360eb704efe1933e73cae8046c296d03180). (#1512) I don't know the purpose of this commit. The idea is simple: if user already have git locally, it's better to skip the donwload process. This patch make the intention from https://github.com/apache/nuttx-apps/pull/1295 work for cJSON. > Please correct it. @pengxiang-hao please fix it, look like the mainline doesn't enable cJSON for daily ci:(. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8230: drivers/camera: Support the private data for imgsensor and imgdata
SPRESENSE commented on PR #8230: URL: https://github.com/apache/nuttx/pull/8230#issuecomment-1409699133 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] SPRESENSE opened a new issue, #1516: Unable to build cJSON
SPRESENSE opened a new issue, #1516: URL: https://github.com/apache/nuttx-apps/issues/1516 I get a build error with cJSON when building `examples/json`. ``` Downloading: v1.7.12.tar.gz curl -O -L "https://github.com/DaveGamble/cJSON/archive"/v1.7.12.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 340k0 340k0 0 747k 0 --:--:-- --:--:-- --:--:-- 2707k Unpacking: v1.7.12.tar.gz -> cJSON tar -zxf v1.7.12.tar.gz touch cJSON cp cJSON/cJSON.h /xxx/include/netutils/cJSON.h cp: cannot stat 'cJSON/cJSON.h': Not a directory ``` This error is caused by this commit https://github.com/apache/nuttx-apps/pull/1512/commits/ad319360eb704efe1933e73cae8046c296d03180. (https://github.com/apache/nuttx-apps/pull/1512) I don't know the purpose of this commit. Please correct it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (c9e52cb283 -> 570c7587c7)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c9e52cb283 net: Implement shutdown() for local stream socket add 570c7587c7 risc-v/Toolchain.defs: Correct indent No new revisions were added by this update. Summary of changes: arch/risc-v/src/common/Toolchain.defs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8367: risc-v/Toolchain.defs: Correct indent
xiaoxiang781216 merged PR #8367: URL: https://github.com/apache/nuttx/pull/8367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (fcdba7a3ef -> c9e52cb283)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from fcdba7a3ef sim/usrsocktest: Enable CONFIG_DEBUG_ASSERTIONS
add 8819eeaf15 net: Implement shutdown() interface and tcp shutdown
add d3dd349649 net: Implement shutdown() for usrsock
add c9e52cb283 net: Implement shutdown() for local stream socket
No new revisions were added by this update.
Summary of changes:
arch/sim/src/sim/posix/sim_hostusrsock.c | 20 +++
arch/sim/src/sim/sim_hostusrsock.h | 2 +
arch/sim/src/sim/sim_usrsock.c | 10 ++
drivers/usrsock/usrsock_rpmsg_server.c | 21 +++
include/nuttx/net/net.h| 35 +
include/nuttx/net/usrsock.h| 9 ++
include/sys/syscall_lookup.h | 1 +
libs/libc/net/Make.defs| 2 +-
libs/libc/net/lib_shutdown.c | 74 -
net/can/can_sockif.c | 3 +-
net/inet/inet_sockif.c | 39 -
net/local/local_recvmsg.c | 7 +-
net/local/local_sockif.c | 66 +++-
net/socket/Make.defs | 2 +-
net/socket/shutdown.c | 149 ++
net/tcp/Make.defs | 2 +-
net/tcp/tcp.h | 20 ++-
net/tcp/tcp_shutdown.c | 168 +
net/usrsock/Make.defs | 2 +-
net/usrsock/usrsock.h | 23 +++
.../{usrsock_close.c => usrsock_shutdown.c}| 65
net/usrsock/usrsock_sockif.c | 3 +-
syscall/syscall.csv| 1 +
23 files changed, 601 insertions(+), 123 deletions(-)
delete mode 100644 libs/libc/net/lib_shutdown.c
create mode 100644 net/socket/shutdown.c
create mode 100644 net/tcp/tcp_shutdown.c
copy net/usrsock/{usrsock_close.c => usrsock_shutdown.c} (75%)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8351: net: Implement socket shutdown() interface
xiaoxiang781216 merged PR #8351: URL: https://github.com/apache/nuttx/pull/8351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8182: Add the holder for mutex
xiaoxiang781216 commented on PR #8182: URL: https://github.com/apache/nuttx/pull/8182#issuecomment-1409680278 Thanks, @masayuki2009 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] 02/02: sim/usrsocktest: Enable CONFIG_DEBUG_ASSERTIONS
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fcdba7a3efd1d5e4af22ee9b7f3961e274642449 Author: Xiang Xiao AuthorDate: Sat Jan 28 23:03:40 2023 +0800 sim/usrsocktest: Enable CONFIG_DEBUG_ASSERTIONS Signed-off-by: Xiang Xiao --- boards/sim/sim/sim/configs/usrsocktest/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boards/sim/sim/sim/configs/usrsocktest/defconfig b/boards/sim/sim/sim/configs/usrsocktest/defconfig index ce94ff5009..15ac56c932 100644 --- a/boards/sim/sim/sim/configs/usrsocktest/defconfig +++ b/boards/sim/sim/sim/configs/usrsocktest/defconfig @@ -13,6 +13,8 @@ CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARDCTL_POWEROFF=y CONFIG_BUILTIN=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_LOOP=y CONFIG_DEV_ZERO=y
[nuttx] 01/02: add holder for mutex
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 1d8af7e105c9a6a7ed05c078990ce9abe8218252
Author: lilei19
AuthorDate: Sat Jan 28 23:02:52 2023 +0800
add holder for mutex
Signed-off-by: lilei19
---
arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c | 16 +-
drivers/modem/alt1250/alt1250.c | 38 +--
drivers/usrsock/usrsock_dev.c| 2 +-
include/nuttx/modem/alt1250.h| 13 +-
include/nuttx/mutex.h| 416 ---
include/nuttx/net/net.h | 47 +++
include/nuttx/semaphore.h| 12 +-
include/semaphore.h | 21 +-
libs/libc/semaphore/sem_getprotocol.c| 5 -
libs/libc/semaphore/sem_init.c | 3 +-
libs/libc/wqueue/work_usrthread.c| 2 +-
net/usrsock/usrsock_devif.c | 4 +-
net/utils/net_lock.c | 88 ++
13 files changed, 512 insertions(+), 155 deletions(-)
diff --git a/arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c
b/arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c
index 4c6a1e290e..3e03f4145f 100644
--- a/arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c
+++ b/arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c
@@ -174,13 +174,13 @@ void _raise_r(struct _reent *r)
void _lock_init(_lock_t *lock)
{
nxmutex_init(_nxlock_common);
- nxsem_get_value(_nxlock_common, lock);
+ nxsem_get_value(_nxlock_common.sem, lock);
}
void _lock_init_recursive(_lock_t *lock)
{
nxmutex_init(_nxlock_recursive);
- nxsem_get_value(_nxlock_recursive, lock);
+ nxsem_get_value(_nxlock_recursive.sem, lock);
}
void _lock_close(_lock_t *lock)
@@ -198,39 +198,39 @@ void _lock_close_recursive(_lock_t *lock)
void _lock_acquire(_lock_t *lock)
{
nxmutex_lock(_nxlock_common);
- nxsem_get_value(_nxlock_common, lock);
+ nxsem_get_value(_nxlock_common.sem, lock);
}
void _lock_acquire_recursive(_lock_t *lock)
{
nxmutex_lock(_nxlock_recursive);
- nxsem_get_value(_nxlock_recursive, lock);
+ nxsem_get_value(_nxlock_recursive.sem, lock);
}
int _lock_try_acquire(_lock_t *lock)
{
nxmutex_trylock(_nxlock_common);
- nxsem_get_value(_nxlock_common, lock);
+ nxsem_get_value(_nxlock_common.sem, lock);
return 0;
}
int _lock_try_acquire_recursive(_lock_t *lock)
{
nxmutex_trylock(_nxlock_recursive);
- nxsem_get_value(_nxlock_recursive, lock);
+ nxsem_get_value(_nxlock_recursive.sem, lock);
return 0;
}
void _lock_release(_lock_t *lock)
{
nxmutex_unlock(_nxlock_common);
- nxsem_get_value(_nxlock_common, lock);
+ nxsem_get_value(_nxlock_common.sem, lock);
}
void _lock_release_recursive(_lock_t *lock)
{
nxmutex_unlock(_nxlock_recursive);
- nxsem_get_value(_nxlock_recursive, lock);
+ nxsem_get_value(_nxlock_recursive.sem, lock);
}
struct _reent *__getreent(void)
diff --git a/drivers/modem/alt1250/alt1250.c b/drivers/modem/alt1250/alt1250.c
index b8481cdb08..73ed186539 100644
--- a/drivers/modem/alt1250/alt1250.c
+++ b/drivers/modem/alt1250/alt1250.c
@@ -1028,12 +1028,12 @@ static int alt1250_open(FAR struct file *filep)
if (ret == OK)
{
- nxsem_init(>waitlist.lock, 0, 1);
- nxsem_init(>replylist.lock, 0, 1);
- nxsem_init(>evtmaplock, 0, 1);
- nxsem_init(>pfdlock, 0, 1);
- nxsem_init(>senddisablelock, 0, 1);
- nxsem_init(>select_inst.stat_lock, 0, 1);
+ nxmutex_init(>waitlist.lock);
+ nxmutex_init(>replylist.lock);
+ nxmutex_init(>evtmaplock);
+ nxmutex_init(>pfdlock);
+ nxmutex_init(>senddisablelock);
+ nxmutex_init(>select_inst.stat_lock);
sq_init(>waitlist.queue);
sq_init(>replylist.queue);
@@ -1048,12 +1048,12 @@ static int alt1250_open(FAR struct file *filep)
m_err("thread create failed: %d\n", errno);
ret = -errno;
- nxsem_destroy(>waitlist.lock);
- nxsem_destroy(>replylist.lock);
- nxsem_destroy(>evtmaplock);
- nxsem_destroy(>pfdlock);
- nxsem_destroy(>senddisablelock);
- nxsem_destroy(>select_inst.stat_lock);
+ nxmutex_destroy(>waitlist.lock);
+ nxmutex_destroy(>replylist.lock);
+ nxmutex_destroy(>evtmaplock);
+ nxmutex_destroy(>pfdlock);
+ nxmutex_destroy(>senddisablelock);
+ nxmutex_destroy(>select_inst.stat_lock);
nxmutex_lock(>refslock);
dev->crefs--;
@@ -1103,12 +1103,12 @@ static int alt1250_close(FAR struct file *filep)
if (ret == OK)
{
- nxsem_destroy(>waitlist.lock);
- nxsem_destroy(>replylist.lock);
- nxsem_destroy(>evtmaplock);
- nxsem_destroy(>pfdlock);
- nxsem_destroy(>senddisablelock);
- nxsem_destroy(>select_inst.stat_lock);
+ nxmutex_destroy(>waitlist.lock);
+ nxmutex_destroy(>replylist.lock);
+
[nuttx] branch master updated (6b89b6f945 -> fcdba7a3ef)
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6b89b6f945 Remove executable permissions from source files new 1d8af7e105 add holder for mutex new fcdba7a3ef sim/usrsocktest: Enable CONFIG_DEBUG_ASSERTIONS The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c | 16 +- boards/sim/sim/sim/configs/usrsocktest/defconfig | 2 + drivers/modem/alt1250/alt1250.c | 38 +-- drivers/usrsock/usrsock_dev.c| 2 +- include/nuttx/modem/alt1250.h| 13 +- include/nuttx/mutex.h| 416 +-- include/nuttx/net/net.h | 47 +++ include/nuttx/semaphore.h| 12 +- include/semaphore.h | 21 +- libs/libc/semaphore/sem_getprotocol.c| 5 - libs/libc/semaphore/sem_init.c | 3 +- libs/libc/wqueue/work_usrthread.c| 2 +- net/usrsock/usrsock_devif.c | 4 +- net/utils/net_lock.c | 88 + 14 files changed, 514 insertions(+), 155 deletions(-)
[GitHub] [nuttx] masayuki2009 merged pull request #8182: Add the holder for mutex
masayuki2009 merged PR #8182: URL: https://github.com/apache/nuttx/pull/8182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8182: Add the holder for mutex
masayuki2009 commented on PR #8182: URL: https://github.com/apache/nuttx/pull/8182#issuecomment-1409676369 @xiaoxiang781216 >Hmm, spresense:rndis_smp and spresesnse:wifi_smp are still unstable. I confirmed that the latest PR is stable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8364: boards: Enable assert for citest
xiaoxiang781216 commented on PR #8364: URL: https://github.com/apache/nuttx/pull/8364#issuecomment-1409674770 @ttnie could you check why the citest fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8370: include/sys/socket.h: Add SOCK_CTRL to socket type
xiaoxiang781216 commented on PR #8370: URL: https://github.com/apache/nuttx/pull/8370#issuecomment-1409673772 @SPRESENSE but how to pass the ioctl to usrsock server now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE opened a new pull request, #8370: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE opened a new pull request, #8370: URL: https://github.com/apache/nuttx/pull/8370 ## Summary SOCK_CTRL is added to provide special control over network drivers and daemons. Currently, SOCK_DGRAM and SOCK_STREAM perform this control, but these use socket resources. In the case of usersocket in particular, this is a waste of the device's limited socket resources. ## Impact Applications using NET_SOCK_TYPE. ## Testing SPRESENSE LTE board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Donny9 commented on pull request #8359: drivers/pipes: fix write busy loop because POLLOUT always ready.
Donny9 commented on PR #8359: URL: https://github.com/apache/nuttx/pull/8359#issuecomment-1409663631 > why close this PR, @Donny9 ? Sorry, let's use PR #8369. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Donny9 opened a new pull request, #8369: drivers/pipes: fix write busy loop because POLLOUT always ready.
Donny9 opened a new pull request, #8369: URL: https://github.com/apache/nuttx/pull/8369 ## Summary drivers/pipes: fix write busy loop because POLLOUT always ready. the size of pipes buffer +1 as compensate the full indicator Signed-off-by: dongjiuzhu1 [dongjiuz...@xiaomi.com](mailto:dongjiuz...@xiaomi.com) ## Impact fix write busyloop for local socket ## Testing vela ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8357: tools: add separate flags parameter for COMPILE/COMPILEXX
Gary-Hobson commented on code in PR #8357: URL: https://github.com/apache/nuttx/pull/8357#discussion_r1091367423 ## tools/Config.mk: ## @@ -285,11 +285,11 @@ endef define COMPILE @echo "CC: $1" - $(Q) $(CCACHE) $(CC) -c $(CFLAGS) $($(strip $1)_CFLAGS) $1 -o $2 + $(Q) $(CCACHE) $(CC) -c $(CFLAGS) $($(strip $1)_CFLAGS) $1 -o $2 $3 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8364: boards: Enable assert for citest
masayuki2009 commented on PR #8364:
URL: https://github.com/apache/nuttx/pull/8364#issuecomment-1409649074
@xiaoxiang781216
```
+++ dirname
/github/workspace/sources/nuttx/../nuttx/boards/arm/imx6/sabre-6quad/configs/citest/run
++ cd
/github/workspace/sources/nuttx/../nuttx/boards/arm/imx6/sabre-6quad/configs/citest
++ pwd
+
WD=/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest
++ cd
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest/../../../../../../../
++ pwd -P
+ WORKSPACE=/github/workspace/sources
+ nuttx=/github/workspace/sources/nuttx
+
logs=/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest/logs
++ echo
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest
++ awk -F / '{print $(NF-2)}'
+ BOARD=sabre-6quad
+ echo
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest
+ echo /github/workspace/sources
/github/workspace/sources
++ basename
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest
+ config=citest
+ '[' sabre-6quad == sim ']'
+ '[' st == 64 ']'
+ target=qemu
+ mark=qemu
+ core=qemu
++ find /github/workspace/sources/nuttx -type f -name nuttx
+ image=/github/workspace/sources/nuttx/nuttx
+ path=/github/workspace/sources/nuttx
+ cd /github/workspace/sources/nuttx/tools/ci/testrun/script
+ python3 -m pytest -m qemu ./ -B sabre-6quad -P
/github/workspace/sources/nuttx -L
/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest/logs/sabre-6quad/qemu
-R qemu -C
--json=/github/workspace/sources/nuttx/boards/arm/imx6/sabre-6quad/configs/citest/logs/sabre-6quad/qemu/pytest.json
= test session starts
==
platform linux -- Python 3.8.10, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 --
/usr/bin/python3
cachedir: .pytest_cache
rootdir: /github/workspace/sources/nuttx/tools/ci/testrun, configfile:
pytest.ini
plugins: repeat-0.9.1, ordering-0.6, json-0.4.0
collecting ... collected 12 items
test_example/test_example.py::test_hello ERROR [
8%]
test_example/test_example.py::test_helloxx ERROR [
16%]
test_example/test_example.py::test_pipe ERROR[
25%]
test_example/test_example.py::test_popen ERROR [
33%]
test_example/test_example.py::test_usrsocktest ERROR [
41%]
test_os/test_os.py::test_ostest ERROR[
50%]
test_os/test_os.py::test_mm ERROR[
58%]
test_os/test_os.py::test_cxxtest ERROR [
66%]
test_os/test_os.py::test_scanftest ERROR [
75%]
test_os/test_os.py::test_getprime ERROR [
83%]
test_os/test_os.py::test_fs_test ERROR [
91%]
test_os/test_os.py::test_psram_test ERROR
[100%]
ERRORS
_ ERROR at setup of test_hello
_
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] GooTal commented on pull request #6242: rv-virt:knsh64
GooTal commented on PR #6242: URL: https://github.com/apache/nuttx/pull/6242#issuecomment-1409648892 Oh thank you. I checked out to releases/12.0 and saw the updated readme. BTW, can knsh64 run ostest? I notice that rv-virt:nsh64 got some built-in apps:  I added these config variables in `nuttx/boards/risc-v/qemu-rv/rv-virt/configs/knsh64/defconfig`: ``` CONFIG_BUILTIN=y CONFIG_NSH_BUILTIN_APPS=y CONFIG_TESTING_OSTEST=y ``` I read readme under `apps/testing/ostest` but it seems not working. Could you give me some advice? Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] CV-Bowen commented on pull request #8353: mm/mm_heap: reduce the memory node overhead size
CV-Bowen commented on PR #8353: URL: https://github.com/apache/nuttx/pull/8353#issuecomment-1409639844 > @CV-Bowen what is "sim mmtest" ? I couldn't find it here :-) Sorry, the mmtest is `mm` command and you can enable it by set `CONFIG_TESTING_MM=y`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps opened a new pull request, #8368: litex: Add GPIO driver.
g2gps opened a new pull request, #8368: URL: https://github.com/apache/nuttx/pull/8368 ## Summary GPIO driver for Litex with optional ISR support. Allows for multiple GPIO peripherals to be specified at an arbitrary addresses. Supports only push / pull output or input. Each peripheral can contain up to 32 signals, each with its own 'second level' dispatched IRQ. ## Impact Add Kconfig options for GPIO driver and GPIO IRQ selection. GPIO driver is only added to build when selected. `LITEX_GPIO_BASE`, `LITEX_GPIO_OFFSET`, and `LITEX_GPIO_MAX`, are set to values which work. However, they can be overridden using custom definitions (see #8233) to suit gateware. ## Testing Testing conducted on our development board, with a peripheral built-in to gateware. I've tested: - GPIO write, high and low signals. - GPIO read, high and low signals - GPIO interrupts on rising edge, falling edge and both edges. on various pins over a single port. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] no1wudi opened a new pull request, #8367: risc-v/Toolchain.defs: Correct indent
no1wudi opened a new pull request, #8367: URL: https://github.com/apache/nuttx/pull/8367 ## Summary Minor style fix ## Impact N/A ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch asf-site updated: Publishing web: 94ac6a38fee09a8d54ee96573f16ea8fc881f5d4 docs: 6b89b6f94576fe93865b4da0469f109e6a79c66b
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 9f1a1ff5 Publishing web: 94ac6a38fee09a8d54ee96573f16ea8fc881f5d4
docs: 6b89b6f94576fe93865b4da0469f109e6a79c66b
9f1a1ff5 is described below
commit 9f1a1ff5f9d60e76369bd29c1961b4762a59a05e
Author: Alin
AuthorDate: Tue Jan 31 00:13:20 2023 +
Publishing web: 94ac6a38fee09a8d54ee96573f16ea8fc881f5d4 docs:
6b89b6f94576fe93865b4da0469f109e6a79c66b
---
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/12.0.0/index.html | 2 +-
content/docs/12.0.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
17 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index e28e92a4..7002b42a 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 30 January 23 at 00:09
+Last Updated: 31 January 23 at 00:10
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index 62d9c013..1fcab5ea 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index 8744ed5c..26117e4d 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -147,7 +147,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 30 January 23 at 00:09
+Last Updated: 31 January 23 at 00:11
Table of
Contents
diff --git a/content/docs/10.0.1/searchindex.js
b/content/docs/10.0.1/searchindex.js
index 62d9c013..8982f54a 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
[nuttx] branch master updated (f63754c4c0 -> 6b89b6f945)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f63754c4c0 arch/tiva: Remove dead store add 6b89b6f945 Remove executable permissions from source files No new revisions were added by this update. Summary of changes: arch/arm/src/sama5/sam_flexcom_spi.h | 0 arch/risc-v/src/mpfs/mpfs_ihc_sbi.c | 0 drivers/usbdev/adb.c | 0 libs/libc/math/lib_scalbn.c | 0 libs/libc/math/lib_scalbnf.c | 0 net/ipfrag/Make.defs | 0 net/ipfrag/ipfrag.c | 0 net/ipfrag/ipfrag.h | 0 net/ipfrag/ipv4_frag.c | 0 net/ipfrag/ipv6_frag.c | 0 10 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 arch/arm/src/sama5/sam_flexcom_spi.h mode change 100755 => 100644 arch/risc-v/src/mpfs/mpfs_ihc_sbi.c mode change 100755 => 100644 drivers/usbdev/adb.c mode change 100755 => 100644 libs/libc/math/lib_scalbn.c mode change 100755 => 100644 libs/libc/math/lib_scalbnf.c mode change 100755 => 100644 net/ipfrag/Make.defs mode change 100755 => 100644 net/ipfrag/ipfrag.c mode change 100755 => 100644 net/ipfrag/ipfrag.h mode change 100755 => 100644 net/ipfrag/ipv4_frag.c mode change 100755 => 100644 net/ipfrag/ipv6_frag.c
[GitHub] [nuttx] acassis merged pull request #8363: Remove executable permissions from source files
acassis merged PR #8363: URL: https://github.com/apache/nuttx/pull/8363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8353: mm/mm_heap: reduce the memory node overhead size
acassis commented on PR #8353: URL: https://github.com/apache/nuttx/pull/8353#issuecomment-1409471945 @CV-Bowen what is "sim mmtest" ? I couldn't find it here :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] lucasssvaz closed pull request #8366: arch/xtensa/esp32: Fix RTC IRQ status clear
lucasssvaz closed pull request #8366: arch/xtensa/esp32: Fix RTC IRQ status clear URL: https://github.com/apache/nuttx/pull/8366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on pull request #8366: arch/xtensa/esp32: Fix RTC IRQ status clear
lucasssvaz commented on PR #8366: URL: https://github.com/apache/nuttx/pull/8366#issuecomment-1409254737 @acassis @gustavonihei PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] lucasssvaz opened a new pull request, #8366: arch/xtensa/esp32: Fix RTC IRQ status clear
lucasssvaz opened a new pull request, #8366: URL: https://github.com/apache/nuttx/pull/8366 ## Summary This PR aims to fix a potential problem with the RTC interrupt status register. Clearing the interrupt status register before calling the lower level handlers might impact its result. ## Impact Nothing is affected by this currently. Avoids possible problems that might occur in the future. ## Testing Tested using the `esp32-lyrat:buttons` defconfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #8363: Remove executable permissions from source files
hartmannathan commented on PR #8363: URL: https://github.com/apache/nuttx/pull/8363#issuecomment-1409113466 > @hartmannathan can we add the check to tools/checkpatch.sh? Filed as Issue #8365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan opened a new issue, #8365: tools/checkpatch.sh should check for wrongly set Executable bit
hartmannathan opened a new issue, #8365: URL: https://github.com/apache/nuttx/issues/8365 Sometimes source files (e.g., `*.c`, `*.h`, `Make.defs`, etc.) are committed to the repository with the Executable bit unintentionally set (that is, file perms are stored in Git as `100755` instead of `100644`). `tools/checkpatch.sh` should check for this and warn if the permissions are not set properly. Files which should be allowed executable bit: - `*.sh` - `*.py` - Not sure about `*.bat` since these are for Windows. Does Executable bit have effect on Windows? Note: Not recommended to use GNU Find arguments: `find . -type f -executable -print` because this is non-portable. POSIX Find command is: `find . -type f -perm +111 -print` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #8363: Remove executable permissions from source files
hartmannathan commented on PR #8363: URL: https://github.com/apache/nuttx/pull/8363#issuecomment-1409099006 > @hartmannathan can we add the check to tools/checkpatch.sh? It would be nice to add it. Unfortunately I can't add it right now because of other work. I'll create an issue to track it until I (or someone else) can get to it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8340: Fixed non-UTF characters.
xiaoxiang781216 commented on PR #8340: URL: https://github.com/apache/nuttx/pull/8340#issuecomment-1409045471 you can install here: https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile#L282 https://github.com/apache/nuttx/blob/master/tools/ci/cibuild.sh#L286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8363: Remove executable permissions from source files
xiaoxiang781216 commented on PR #8363: URL: https://github.com/apache/nuttx/pull/8363#issuecomment-1409042433 @hartmannathan can we add the check to tools/checkpatch.sh? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: arch/tiva: Remove dead store
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f63754c4c0 arch/tiva: Remove dead store
f63754c4c0 is described below
commit f63754c4c0031377b035b4882ee23187fc103b26
Author: Nathan Hartman <59230071+hartmannat...@users.noreply.github.com>
AuthorDate: Mon Jan 30 09:59:11 2023 -0500
arch/tiva: Remove dead store
* arch/arm/src/tiva/common/tiva_can.c:
(tiva_can_initialize): Remove the local variable 'canmod', which was
assigned but never used.
---
arch/arm/src/tiva/common/tiva_can.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/src/tiva/common/tiva_can.c
b/arch/arm/src/tiva/common/tiva_can.c
index b2da64d2dd..761ea89215 100644
--- a/arch/arm/src/tiva/common/tiva_can.c
+++ b/arch/arm/src/tiva/common/tiva_can.c
@@ -2344,7 +2344,6 @@ static int tivacan_initfilter(struct can_dev_s *dev,
int tiva_can_initialize(char *devpath, int modnum)
{
struct can_dev_s *dev;
- struct tiva_canmod_s *canmod;
int ret;
caninfo("tiva_can_initialize module %d\n", modnum);
@@ -2372,8 +2371,6 @@ int tiva_can_initialize(char *devpath, int modnum)
}
#endif
- canmod = dev->cd_priv;
-
/* Register the driver */
ret = can_register(devpath, dev);
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8362: arch/tiva: Remove dead store
xiaoxiang781216 merged PR #8362: URL: https://github.com/apache/nuttx/pull/8362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8280: Add more battery operation
xiaoxiang781216 commented on code in PR #8280: URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090940485 ## include/nuttx/power/battery_ioctl.h: ## @@ -143,6 +143,7 @@ enum batio_operate_e BATIO_OPRTN_SYSON, BATIO_OPRTN_RESET, BATIO_OPRTN_WDOG, + BATIO_OPRTN_SHIPMODE, Review Comment: The standby is too general and may give the programmer the expression that the charger will switch between standby and normal frequently. But the ship mode is set on factory line, exit when the customer activates the device at first time, and then never come back to the ship mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8280: Add more battery operation
xiaoxiang781216 commented on code in PR #8280: URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090931717 ## include/nuttx/power/battery_ioctl.h: ## @@ -144,6 +144,7 @@ enum batio_operate_e BATIO_OPRTN_RESET, BATIO_OPRTN_WDOG, BATIO_OPRTN_SHIPMODE, + BATIO_OPRTN_CUTOFF_CURRENT, Review Comment: BATIO_OPRTN_CUTOFF_CURRENT is used to set the end condition: the charger stop when the charging current is smaller than the specific value by this operation. It's different from BATIO_OPRTN_SYSOFF and BATIO_OPRTN_HIZ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: drivers/mmcsd: Add MMC_IOC_CMD ioctl
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4b4004b874 drivers/mmcsd: Add MMC_IOC_CMD ioctl
4b4004b874 is described below
commit 4b4004b874a36c604a611bf5eba8645cfad7b66b
Author: helei8
AuthorDate: Mon Dec 5 19:54:31 2022 +0800
drivers/mmcsd: Add MMC_IOC_CMD ioctl
Signed-off-by: helei8
---
drivers/mmcsd/Kconfig | 6 +
drivers/mmcsd/mmcsd_sdio.c | 383 +
include/nuttx/mmcsd.h | 56 ++-
3 files changed, 438 insertions(+), 7 deletions(-)
diff --git a/drivers/mmcsd/Kconfig b/drivers/mmcsd/Kconfig
index bf6ac955bc..6511a0c40b 100644
--- a/drivers/mmcsd/Kconfig
+++ b/drivers/mmcsd/Kconfig
@@ -27,6 +27,12 @@ menuconfig MMCSD
if MMCSD
+config MMCSD_IOCSUPPORT
+ int "Enable MMC/SD ioctl support"
+ default y
+ ---help---
+ Disable it to save some code size if required.
+
config MMCSD_NSLOTS
int "Number of MMC/SD slots"
default 1
diff --git a/drivers/mmcsd/mmcsd_sdio.c b/drivers/mmcsd/mmcsd_sdio.c
index 3b8cabf379..a26c4d4953 100644
--- a/drivers/mmcsd/mmcsd_sdio.c
+++ b/drivers/mmcsd/mmcsd_sdio.c
@@ -221,6 +221,12 @@ static int mmcsd_probe(FAR struct mmcsd_state_s *priv);
static int mmcsd_removed(FAR struct mmcsd_state_s *priv);
static int mmcsd_hwinitialize(FAR struct mmcsd_state_s *priv);
static voidmmcsd_hwuninitialize(FAR struct mmcsd_state_s *priv);
+#ifdef CONFIG_MMCSD_IOCSUPPORT
+static int mmcsd_iocmd(FAR struct mmcsd_state_s *priv,
+ FAR struct mmc_ioc_cmd *ic_ptr);
+static int mmcsd_multi_iocmd(FAR struct mmcsd_state_s *priv,
+ FAR struct mmc_ioc_multi_cmd *imc_ptr);
+#endif
/
* Private Data
@@ -2342,6 +2348,30 @@ static int mmcsd_ioctl(FAR struct inode *inode, int cmd,
unsigned long arg)
}
break;
+#ifdef CONFIG_MMCSD_IOCSUPPORT
+case MMC_IOC_CMD: /* MMCSD device ioctl commands */
+ {
+finfo("MMC_IOC_CMD\n");
+ret = mmcsd_iocmd(priv, (FAR struct mmc_ioc_cmd *)arg);
+if (ret != OK)
+ {
+ferr("ERROR: mmcsd_iocmd failed: %d\n", ret);
+ }
+ }
+ break;
+
+case MMC_IOC_MULTI_CMD: /* MMCSD device ioctl muti commands */
+ {
+finfo("MMC_IOC_MULTI_CMD\n");
+ret = mmcsd_multi_iocmd(priv, (FAR struct mmc_ioc_multi_cmd *)arg);
+if (ret != OK)
+ {
+ferr("ERROR: mmcsd_iocmd failed: %d\n", ret);
+ }
+ }
+ break;
+#endif
+
default:
ret = -ENOTTY;
break;
@@ -2760,6 +2790,359 @@ static int mmcsd_read_csd(FAR struct mmcsd_state_s
*priv)
}
#endif
+/
+ * Name: mmcsd_general_cmd_write
+ *
+ * Description:
+ * Send cmd56 data, one sector size
+ *
+ /
+
+static int mmcsd_general_cmd_write(FAR struct mmcsd_state_s *priv,
+ FAR const uint8_t *buffer,
+ off_t startblock)
+{
+ int ret;
+
+ DEBUGASSERT(priv != NULL && buffer != NULL);
+
+ /* Check if the card is locked or write protected (either via software or
+ * via the mechanical write protect on the card)
+ */
+
+ if (mmcsd_wrprotected(priv))
+{
+ ferr("ERROR: Card is locked or write protected\n");
+ return -EPERM;
+}
+
+#if defined(CONFIG_SDIO_DMA) && defined(CONFIG_ARCH_HAVE_SDIO_PREFLIGHT)
+ /* If we think we are going to perform a DMA transfer, make sure that we
+ * will be able to before we commit the card to the operation.
+ */
+
+ if ((priv->caps & SDIO_CAPS_DMASUPPORTED) != 0)
+{
+ ret = SDIO_DMAPREFLIGHT(priv->dev, buffer, priv->blocksize);
+ if (ret != OK)
+{
+ return ret;
+}
+}
+#endif
+
+ /* Verify that the card is ready for the transfer. The card may still be
+ * busy from the preceding write transfer. It would be simpler to check
+ * for write busy at the end of each write, rather than at the beginning of
+ * each read AND write, but putting the busy-wait at the beginning of the
+ * transfer allows for more overlap and, hopefully, better performance
+ */
+
+ ret = mmcsd_transferready(priv);
+ if (ret != OK)
+{
+ ferr("ERROR: Card not ready: %d\n", ret);
+ return ret;
+}
+
+ /* Select the block size for the card */
+
+ ret = mmcsd_setblocklen(priv, priv->blocksize);
+ if (ret != OK)
+{
+ ferr("ERROR: mmcsd_setblocklen failed: %d\n", ret);
+ return ret;
+}
+
+ /* If Controller does not need DMA setup before the write then send CMD56
+ * now.
[GitHub] [nuttx] acassis merged pull request #8256: drivers/mmcsd: Add MMC_IOC_CMD ioctl
acassis merged PR #8256: URL: https://github.com/apache/nuttx/pull/8256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8280: Add more battery operation
acassis commented on code in PR #8280: URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090905217 ## include/nuttx/power/battery_ioctl.h: ## @@ -143,6 +143,7 @@ enum batio_operate_e BATIO_OPRTN_SYSON, BATIO_OPRTN_RESET, BATIO_OPRTN_WDOG, + BATIO_OPRTN_SHIPMODE, Review Comment: I was going to suggest a generic name like _STANDBY, but I agree _SHIPMODE has a sense of purpose. In the automotive industry we use it too when shipping a car from a country to another or even inside big countries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8280: Add more battery operation
acassis commented on code in PR #8280: URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090905217 ## include/nuttx/power/battery_ioctl.h: ## @@ -143,6 +143,7 @@ enum batio_operate_e BATIO_OPRTN_SYSON, BATIO_OPRTN_RESET, BATIO_OPRTN_WDOG, + BATIO_OPRTN_SHIPMODE, Review Comment: I was going to suggest a generic name like _STANDBY, but I agree _SHIPMODE is has a sense of purpose. In the automotive industry we use it too when shipping a car from a country to another or even inside big countries ## include/nuttx/power/battery_ioctl.h: ## @@ -144,6 +144,7 @@ enum batio_operate_e BATIO_OPRTN_RESET, BATIO_OPRTN_WDOG, BATIO_OPRTN_SHIPMODE, + BATIO_OPRTN_CUTOFF_CURRENT, Review Comment: Isn't BATIO_OPRTN_CUTOFF_CURRENT equivalent to BATIO_OPRTN_SYSOFF or even BATIO_OPRTN_HIZ ? What is the purpose in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8182: Add the holder for mutex
xiaoxiang781216 commented on code in PR #8182: URL: https://github.com/apache/nuttx/pull/8182#discussion_r1090897946 ## boards/sim/sim/sim/configs/usrsocktest/defconfig: ## @@ -13,6 +13,8 @@ CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARDCTL_POWEROFF=y CONFIG_BUILTIN=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_SYMBOLS=y Review Comment: Here is the patch: https://github.com/apache/nuttx/pull/8364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8364: boards: Enable assert for citest
xiaoxiang781216 opened a new pull request, #8364: URL: https://github.com/apache/nuttx/pull/8364 ## Summary to find more error in daily ci ## Impact citest ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8182: Add the holder for mutex
xiaoxiang781216 commented on code in PR #8182: URL: https://github.com/apache/nuttx/pull/8182#discussion_r1090892898 ## boards/sim/sim/sim/configs/usrsocktest/defconfig: ## @@ -13,6 +13,8 @@ CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARDCTL_POWEROFF=y CONFIG_BUILTIN=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_SYMBOLS=y Review Comment: let me create a new patch for ./boards/sim/sim/sim/configs/citest/defconfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8357: tools: add separate flags parameter for COMPILE/COMPILEXX
xiaoxiang781216 commented on code in PR #8357: URL: https://github.com/apache/nuttx/pull/8357#discussion_r1090887881 ## tools/Config.mk: ## @@ -285,11 +285,11 @@ endef define COMPILE @echo "CC: $1" - $(Q) $(CCACHE) $(CC) -c $(CFLAGS) $($(strip $1)_CFLAGS) $1 -o $2 + $(Q) $(CCACHE) $(CC) -c $(CFLAGS) $($(strip $1)_CFLAGS) $1 -o $2 $3 Review Comment: ```suggestion $(Q) $(CCACHE) $(CC) -c $(CFLAGS) $3 $($(strip $1)_CFLAGS) $1 -o $2 $3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8357: tools: add separate flags parameter for COMPILE/COMPILEXX
xiaoxiang781216 commented on code in PR #8357: URL: https://github.com/apache/nuttx/pull/8357#discussion_r1090887480 ## tools/Config.mk: ## @@ -303,7 +303,7 @@ endef define COMPILEXX @echo "CXX: $1" - $(Q) $(CCACHE) $(CXX) -c $(CXXFLAGS) $($(strip $1)_CXXFLAGS) $1 -o $2 + $(Q) $(CCACHE) $(CXX) -c $(CXXFLAGS) $($(strip $1)_CXXFLAGS) $1 -o $2 $3 Review Comment: ```suggestion $(Q) $(CCACHE) $(CXX) -c $(CXXFLAGS) $3 $($(strip $1)_CXXFLAGS) $1 -o $2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #8182: Add the holder for mutex
masayuki2009 commented on code in PR #8182: URL: https://github.com/apache/nuttx/pull/8182#discussion_r1090885862 ## boards/sim/sim/sim/configs/usrsocktest/defconfig: ## @@ -13,6 +13,8 @@ CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARDCTL_POWEROFF=y CONFIG_BUILTIN=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_SYMBOLS=y Review Comment: @xiaoxiang781216 Should we add these configs to `./boards/sim/sim/sim/configs/citest/defconfig` instead of this file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8359: drivers/pipes: fix write busy loop because POLLOUT always ready.
xiaoxiang781216 commented on PR #8359: URL: https://github.com/apache/nuttx/pull/8359#issuecomment-1408965627 why close this PR, @Donny9 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] 01/02: mm/iob: Support negative offset when copyin/out.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit be89bcc0445eba4101d09960f0b58ee63824dbfd
Author: Zhe Weng
AuthorDate: Wed Jan 18 19:58:52 2023 +0800
mm/iob: Support negative offset when copyin/out.
Signed-off-by: Zhe Weng
---
include/nuttx/mm/iob.h| 6 +++---
mm/iob/iob_copyin.c | 21 ++---
mm/iob/iob_copyout.c | 13 +++--
net/devif/devif_poll.c| 7 +--
net/netdev/netdev_input.c | 23 +--
5 files changed, 34 insertions(+), 36 deletions(-)
diff --git a/include/nuttx/mm/iob.h b/include/nuttx/mm/iob.h
index ee3987d086..ede9816f9e 100644
--- a/include/nuttx/mm/iob.h
+++ b/include/nuttx/mm/iob.h
@@ -405,7 +405,7 @@ unsigned int iob_get_queue_size(FAR struct iob_queue_s
*queue);
/
int iob_copyin(FAR struct iob_s *iob, FAR const uint8_t *src,
- unsigned int len, unsigned int offset, bool throttled);
+ unsigned int len, int offset, bool throttled);
/
* Name: iob_trycopyin
@@ -418,7 +418,7 @@ int iob_copyin(FAR struct iob_s *iob, FAR const uint8_t
*src,
/
int iob_trycopyin(FAR struct iob_s *iob, FAR const uint8_t *src,
- unsigned int len, unsigned int offset, bool throttled);
+ unsigned int len, int offset, bool throttled);
/
* Name: iob_copyout
@@ -430,7 +430,7 @@ int iob_trycopyin(FAR struct iob_s *iob, FAR const uint8_t
*src,
/
int iob_copyout(FAR uint8_t *dest, FAR const struct iob_s *iob,
-unsigned int len, unsigned int offset);
+unsigned int len, int offset);
/
* Name: iob_tailroom
diff --git a/mm/iob/iob_copyin.c b/mm/iob/iob_copyin.c
index 039cd923bd..0d221ee3b9 100644
--- a/mm/iob/iob_copyin.c
+++ b/mm/iob/iob_copyin.c
@@ -51,7 +51,7 @@
/
static int iob_copyin_internal(FAR struct iob_s *iob, FAR const uint8_t *src,
- unsigned int len, unsigned int offset,
+ unsigned int len, int offset,
bool throttled, bool can_block)
{
FAR struct iob_s *head = iob;
@@ -61,23 +61,30 @@ static int iob_copyin_internal(FAR struct iob_s *iob, FAR
const uint8_t *src,
unsigned int avail;
unsigned int total = len;
- iobinfo("iob=%p len=%u offset=%u\n", iob, len, offset);
+ iobinfo("iob=%p len=%u offset=%d\n", iob, len, offset);
DEBUGASSERT(iob && src);
/* The offset must applied to data that is already in the I/O buffer
* chain
*/
- if (offset > iob->io_pktlen)
+ if ((int)(offset - iob->io_pktlen) > 0)
{
- ioberr("ERROR: offset is past the end of data: %u > %u\n",
+ ioberr("ERROR: offset is past the end of data: %d > %u\n",
offset, iob->io_pktlen);
return -ESPIPE;
}
+ if ((int)(offset + iob->io_offset) < 0)
+{
+ ioberr("ERROR: offset is before the start of data: %d < %d\n",
+ offset, -(int)iob->io_offset);
+ return -ESPIPE;
+}
+
/* Skip to the I/O buffer containing the data offset */
- while (offset > iob->io_len)
+ while ((int)(offset - iob->io_len) > 0)
{
offset -= iob->io_len;
iob = iob->io_flink;
@@ -216,7 +223,7 @@ static int iob_copyin_internal(FAR struct iob_s *iob, FAR
const uint8_t *src,
/
int iob_copyin(FAR struct iob_s *iob, FAR const uint8_t *src,
- unsigned int len, unsigned int offset, bool throttled)
+ unsigned int len, int offset, bool throttled)
{
return iob_copyin_internal(iob, src, len, offset, throttled, true);
}
@@ -232,7 +239,7 @@ int iob_copyin(FAR struct iob_s *iob, FAR const uint8_t
*src,
/
int iob_trycopyin(FAR struct iob_s *iob, FAR const uint8_t *src,
- unsigned int len, unsigned int offset, bool throttled)
+ unsigned int len, int offset, bool throttled)
{
return iob_copyin_internal(iob, src, len, offset, throttled, false);
}
diff --git a/mm/iob/iob_copyout.c b/mm/iob/iob_copyout.c
index 5d9643c750..a32e777d10 100644
--- a/mm/iob/iob_copyout.c
+++ b/mm/iob/iob_copyout.c
@@ -54,16 +54,25 @@
/
int
[nuttx] branch master updated (0f35ad29a8 -> ff68d9ac04)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0f35ad29a8 arm/unwinder: set default unwinder type to arm exidx/extab new be89bcc044 mm/iob: Support negative offset when copyin/out. new ff68d9ac04 net/tun: Change TUN/TAP to use IOB The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: drivers/net/tun.c | 77 ++- include/nuttx/mm/iob.h| 6 ++-- mm/iob/iob_copyin.c | 21 - mm/iob/iob_copyout.c | 13 ++-- net/devif/devif_poll.c| 7 + net/netdev/netdev_input.c | 23 +++--- 6 files changed, 83 insertions(+), 64 deletions(-)
[nuttx] 02/02: net/tun: Change TUN/TAP to use IOB
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit ff68d9ac04bdf20a12b8420b622f3cef282459d2
Author: Zhe Weng
AuthorDate: Tue Jan 10 20:03:02 2023 +0800
net/tun: Change TUN/TAP to use IOB
TUN/TAP is not working after IOB offload, try to fix.
Signed-off-by: Zhe Weng
---
drivers/net/tun.c | 77 +++
1 file changed, 49 insertions(+), 28 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 47d32be57d..65e54fcdb1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -61,6 +61,8 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
@@ -98,12 +100,6 @@
# define CONFIG_TUN_NINTERFACES 1
#endif
-/* Make sure that packet buffers include in configured guard size and are an
- * even multiple of 16-bits in length.
- */
-
-#define NET_TUN_PKTSIZE ((CONFIG_NET_TUN_PKTSIZE + CONFIG_NET_GUARDSIZE + 1) &
~1)
-
/* This is a helper pointer for accessing the contents of the Ethernet
* header.
*/
@@ -137,8 +133,8 @@ struct tun_device_s
* is assured only by the preceding wide data types.
*/
- uint8_t read_buf[NET_TUN_PKTSIZE];
- uint8_t write_buf[NET_TUN_PKTSIZE];
+ FAR struct iob_s *read_buf;
+ FAR struct iob_s *write_buf;
/* This holds the information visible to the NuttX network */
@@ -310,8 +306,14 @@ static void tun_fd_transmit(FAR struct tun_device_s *priv)
static int tun_txpoll(FAR struct net_driver_s *dev)
{
+ FAR struct tun_device_s *priv = (FAR struct tun_device_s *)dev->d_private;
int ret;
+ DEBUGASSERT(priv->read_buf == NULL);
+ priv->read_d_len = dev->d_len;
+ priv->read_buf = dev->d_iob;
+ netdev_iob_clear(dev);
+
#ifdef CONFIG_NET_ETHERNET
if (dev->d_lltype == NET_LL_ETHERNET)
{
@@ -358,7 +360,6 @@ static int tun_txpoll_tap(FAR struct net_driver_s *dev)
/* Send the packet */
- priv->read_d_len = priv->dev.d_len;
tun_fd_transmit(priv);
return 1;
@@ -394,7 +395,6 @@ static int tun_txpoll_tun(FAR struct net_driver_s *dev)
{
FAR struct tun_device_s *priv = (FAR struct tun_device_s *)dev->d_private;
- priv->read_d_len = priv->dev.d_len;
tun_fd_transmit(priv);
return 1;
@@ -495,17 +495,6 @@ static void tun_net_receive_tap(FAR struct tun_device_s
*priv)
{
arp_input(>dev);
NETDEV_RXARP(>dev);
-
- /* If the above function invocation resulted in data that should be
- * sent out on the network, the field d_len will set to a value > 0.
- */
-
- if (priv->dev.d_len > 0)
-{
- priv->write_d_len = priv->dev.d_len;
- tun_fd_transmit(priv);
- priv->dev.d_len = 0;
-}
}
else
#endif
@@ -522,7 +511,10 @@ static void tun_net_receive_tap(FAR struct tun_device_s
*priv)
{
/* And send the packet */
+ DEBUGASSERT(priv->write_buf == NULL);
priv->write_d_len = priv->dev.d_len;
+ priv->write_buf = priv->dev.d_iob;
+ netdev_iob_clear(>dev);
tun_fd_transmit(priv);
}
}
@@ -599,7 +591,10 @@ static void tun_net_receive_tun(FAR struct tun_device_s
*priv)
if (dev->d_len > 0)
{
+ DEBUGASSERT(priv->write_buf == NULL);
priv->write_d_len = dev->d_len;
+ priv->write_buf = dev->d_iob;
+ netdev_iob_clear(dev);
tun_fd_transmit(priv);
}
}
@@ -629,7 +624,6 @@ static void tun_txdone(FAR struct tun_device_s *priv)
/* Then poll the network for new XMIT data */
- priv->dev.d_buf = priv->read_buf;
devif_poll(>dev, tun_txpoll);
}
@@ -751,7 +745,6 @@ static void tun_txavail_work(FAR void *arg)
{
/* Poll the network for new XMIT data */
- priv->dev.d_buf = priv->read_buf;
devif_poll(>dev, tun_txpoll);
}
@@ -965,6 +958,7 @@ static ssize_t tun_write(FAR struct file *filep, FAR const
char *buffer,
{
FAR struct tun_device_s *priv = filep->f_priv;
ssize_t nwritten = 0;
+ uint8_t llhdrlen;
int ret;
if (priv == NULL || buflen > CONFIG_NET_TUN_PKTSIZE)
@@ -972,6 +966,8 @@ static ssize_t tun_write(FAR struct file *filep, FAR const
char *buffer,
return -EINVAL;
}
+ llhdrlen = NET_LL_HDRLEN(>dev);
+
for (; ; )
{
/* Write must return immediately if interrupted by a signal (or if the
@@ -988,10 +984,24 @@ static ssize_t tun_write(FAR struct file *filep, FAR
const char *buffer,
if (priv->write_d_len == 0)
{
- memcpy(priv->write_buf, buffer, buflen);
-
net_lock();
- priv->dev.d_buf = priv->write_buf;
+ ret = netdev_iob_prepare(>dev, false, 0);
+ if (ret < 0)
+{
+ nwritten = (nwritten == 0) ? ret : nwritten;
+ net_unlock();
+ break;
+}
+
+ ret = iob_trycopyin(priv->dev.d_iob, (FAR const uint8_t
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8343: net/tun: Change TUN/TAP to use IOB
xiaoxiang781216 merged PR #8343: URL: https://github.com/apache/nuttx/pull/8343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: arm/unwinder: set default unwinder type to arm exidx/extab
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0f35ad29a8 arm/unwinder: set default unwinder type to arm exidx/extab 0f35ad29a8 is described below commit 0f35ad29a823e6041b1a50e50a44e776f8aea115 Author: chao an AuthorDate: Mon Jan 30 21:42:23 2023 +0800 arm/unwinder: set default unwinder type to arm exidx/extab Signed-off-by: chao an --- arch/arm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 614b83d66e..96d93b609c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1245,8 +1245,7 @@ if SCHED_BACKTRACE choice prompt "Choose ARM unwinder" - default UNWINDER_STACK_POINTER if ARM_THUMB - default UNWINDER_FRAME_POINTER if !ARM_THUMB + default UNWINDER_ARM ---help--- This determines which method will be used for unwinding nuttx stack traces for debug.
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8360: arm/unwinder: set default unwinder type to arm exidx/extab
xiaoxiang781216 merged PR #8360: URL: https://github.com/apache/nuttx/pull/8360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8361: net/devif: check the net device before use
acassis commented on code in PR #8361:
URL: https://github.com/apache/nuttx/pull/8361#discussion_r1090830195
##
net/devif/devif_iobsend.c:
##
@@ -56,67 +57,53 @@ void devif_iob_send(FAR struct net_driver_s *dev, FAR
struct iob_s *iob,
unsigned int len, unsigned int offset,
unsigned int target_offset)
{
-#ifndef CONFIG_NET_IPFRAG
- unsigned int limit = NETDEV_PKTSIZE(dev) -
- NET_LL_HDRLEN(dev) - target_offset;
+ int ret;
- if (dev == NULL || len == 0 || len > limit)
-#else
if (dev == NULL || len == 0)
-#endif
{
- if (dev->d_iob == NULL)
-{
- iob_free_chain(iob);
-}
+ ret = -EINVAL;
Review Comment:
Case dev==NULL shouldn't it return -ENODEV instead of -EINVAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] TimJTi commented on issue #8325: RNDIS/CDC-ECM/CDC-NCM
TimJTi commented on issue #8325: URL: https://github.com/apache/nuttx/issues/8325#issuecomment-1408879666 Initial results today, on Ubuntu which, I now remember, is exactly what I saw > 1 year ago and I gave up at that time as it wasn't important then. It is now :( [282860.884239] usb 1-2: USB disconnect, device number 28 [282861.360379] usb 1-2: new high-speed USB device number 29 using xhci_hcd [282861.509252] usb 1-2: New USB device found, idVendor=584e, idProduct=5342, bcdDevice= 0.01 [282861.509258] usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [282861.509261] usb 1-2: Product: RNDIS gadget [282861.509263] usb 1-2: Manufacturer: NuttX [282861.509265] usb 1-2: SerialNumber: 1234 [282861.510911] rndis_host 1-2:1.0: skipping garbage [282861.511154] rndis_host 1-2:1.0: dev can't take 1558 byte packets (max 1542), adjusting MTU to 1484 [282861.511483] rndis_host 1-2:1.0: RNDIS_MSG_QUERY(0x01010101) failed, -32 [282861.511489] rndis_host 1-2:1.0: rndis get ethaddr, -32 [282861.511584] rndis_host: probe of 1-2:1.0 failed with error -32 [282861.511830] rndis_wlan 1-2:1.0: skipping garbage [282861.511989] rndis_wlan 1-2:1.0: dev can't take 1558 byte packets (max 1542), adjusting MTU to 1484 A web search for that RNDIS_MSG_QUERY fail shows it has been seen by others on different boards and in different situations but still looking...but my belief is it is due to a combination of latest Ubuntu and Windows RNDIS drivers and a possible shortcoming of the SAMA5-specific usb device driver which is why I see it but stm32 users (for example) don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: net/slip: Change SLIP to use IOB
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new af0a35f9ae net/slip: Change SLIP to use IOB
af0a35f9ae is described below
commit af0a35f9aedc103a71b56b304540882076e4f18c
Author: Zhe Weng
AuthorDate: Sat Jan 28 11:58:58 2023 +0800
net/slip: Change SLIP to use IOB
Signed-off-by: Zhe Weng
---
drivers/net/slip.c | 83 --
1 file changed, 56 insertions(+), 27 deletions(-)
diff --git a/drivers/net/slip.c b/drivers/net/slip.c
index 1501538f5e..ba6cd8db91 100644
--- a/drivers/net/slip.c
+++ b/drivers/net/slip.c
@@ -46,6 +46,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -122,7 +123,6 @@ struct slip_driver_s
volatile bool bifup; /* true:ifup false:ifdown */
bool txnodelay; /* True: nxsig_usleep() not needed */
struct file file; /* TTY file descriptor */
- uint16_t rxlen; /* The number of bytes in rxbuf */
pid_t rxpid; /* Receiver thread ID */
pid_t txpid; /* Transmitter thread ID */
sem_t waitsem;/* Mutually exclusive access to the network */
@@ -130,8 +130,7 @@ struct slip_driver_s
/* This holds the information visible to the NuttX network */
struct net_driver_s dev; /* Interface understood by the network */
- uint8_t rxbuf[CONFIG_NET_SLIP_PKTSIZE + 2];
- uint8_t txbuf[CONFIG_NET_SLIP_PKTSIZE + 2];
+ FAR struct iob_s *rxiob;
};
/
@@ -200,6 +199,32 @@ static inline void slip_write(FAR struct slip_driver_s
*priv,
}
}
+/
+ * Name: slip_write_iob
+ *
+ * Description:
+ * Just an inline wrapper around IOB writing.
+ *
+ * Input Parameters:
+ * priv - Reference to the driver state structure
+ * iob - IO Buffer data to send
+ * len - Buffer length in bytes
+ *
+ /
+
+static inline void slip_write_iob(FAR struct slip_driver_s *priv,
+ FAR struct iob_s **iob, int len)
+{
+ while (len > 0 && (*iob)->io_pktlen > 0)
+{
+ int nbytes = MIN(len, (*iob)->io_len);
+ slip_write(priv, IOB_DATA(*iob), nbytes);
+
+ len -= nbytes;
+ *iob = iob_trimhead(*iob, nbytes);
+}
+}
+
/
* Name: slip_putc
*
@@ -235,8 +260,7 @@ static inline void slip_putc(FAR struct slip_driver_s
*priv, int ch)
static void slip_transmit(FAR struct slip_driver_s *priv)
{
- uint8_t *src;
- uint8_t *start;
+ uint8_t src;
uint8_t esc;
int remaining;
int len;
@@ -254,14 +278,13 @@ static void slip_transmit(FAR struct slip_driver_s *priv)
/* For each byte in the packet, send the appropriate character sequence */
- src = priv->dev.d_buf;
+ iob_copyout(, priv->dev.d_iob, 1, 0);
remaining = priv->dev.d_len;
- start = src;
len = 0;
while (remaining-- > 0)
{
- switch (*src)
+ switch (src)
{
/* If it's the same code as an END character, we send a special two
* character code so as not to make the receiver think we sent an
@@ -286,13 +309,13 @@ static void slip_transmit(FAR struct slip_driver_s *priv)
if (len > 0)
{
- slip_write(priv, start, len);
+ slip_write_iob(priv, >dev.d_iob, len);
}
/* Reset */
- start = src + 1;
- len = 0;
+ priv->dev.d_iob = iob_trimhead(priv->dev.d_iob, 1);
+ len = 0;
/* Then send the escape sequence */
@@ -308,9 +331,9 @@ static void slip_transmit(FAR struct slip_driver_s *priv)
break;
}
- /* Point to the next character in the packet */
+ /* Copyout the next character in the packet */
- src++;
+ iob_copyout(, priv->dev.d_iob, 1, len);
}
/* We have looked at every character in the packet. Now flush any unsent
@@ -319,7 +342,7 @@ static void slip_transmit(FAR struct slip_driver_s *priv)
if (len > 0)
{
- slip_write(priv, start, len);
+ slip_write_iob(priv, >dev.d_iob, len);
}
/* And send the END token */
@@ -425,7 +448,6 @@ static int slip_txtask(int argc, FAR char *argv[])
/* Poll the networking layer for new XMIT data. */
net_lock();
- priv->dev.d_buf = priv->txbuf;
/* perform the normal TX poll */
@@ -511,9 +533,9 @@ static inline void slip_receive(FAR struct slip_driver_s
*priv)
* are in turn sent to try to
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8344: net/slip: Change SLIP to use IOB
xiaoxiang781216 merged PR #8344: URL: https://github.com/apache/nuttx/pull/8344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 closed pull request #8239: Remove use of IPv[4|6]BUF macro from net/slip
xiaoxiang781216 closed pull request #8239: Remove use of IPv[4|6]BUF macro from net/slip URL: https://github.com/apache/nuttx/pull/8239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8239: Remove use of IPv[4|6]BUF macro from net/slip
xiaoxiang781216 commented on PR #8239: URL: https://github.com/apache/nuttx/pull/8239#issuecomment-1408850177 let use #8344 and close this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (fa63da22ae -> ba016eb5eb)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fa63da22ae libs/netdb: add sanity check to avoid null pointer reference add ba016eb5eb libc/stdio: fix rounding errors for fractional values less than 1 No new revisions were added by this update. Summary of changes: libs/libc/stdio/lib_dtoa_engine.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8356: libc/stdio: fix rounding errors for fractional values less than 1
xiaoxiang781216 merged PR #8356: URL: https://github.com/apache/nuttx/pull/8356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: libs/netdb: add sanity check to avoid null pointer reference
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fa63da22ae libs/netdb: add sanity check to avoid null pointer reference
fa63da22ae is described below
commit fa63da22ae0ad203bf0e544068234dc225d14d63
Author: chao an
AuthorDate: Mon Jan 30 16:26:32 2023 +0800
libs/netdb: add sanity check to avoid null pointer reference
Signed-off-by: chao an
---
libs/libc/netdb/lib_gethostentbynamer.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libs/libc/netdb/lib_gethostentbynamer.c
b/libs/libc/netdb/lib_gethostentbynamer.c
index 1b17d8ac84..6285b39dc2 100644
--- a/libs/libc/netdb/lib_gethostentbynamer.c
+++ b/libs/libc/netdb/lib_gethostentbynamer.c
@@ -737,7 +737,10 @@ int gethostentbyname_r(FAR const char *name,
}
else if ((flags & AI_NUMERICHOST) != 0)
{
- *h_errnop = EAI_NONAME;
+ if (h_errnop)
+{
+ *h_errnop = EAI_NONAME;
+}
return ERROR;
}
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8349: libs/netdb: add sanity check to avoid null pointer reference
xiaoxiang781216 merged PR #8349: URL: https://github.com/apache/nuttx/pull/8349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Donny9 closed pull request #8359: drivers/pipes: fix write busy loop because POLLOUT always ready.
Donny9 closed pull request #8359: drivers/pipes: fix write busy loop because POLLOUT always ready. URL: https://github.com/apache/nuttx/pull/8359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pussuw commented on a diff in pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure
pussuw commented on code in PR #8355:
URL: https://github.com/apache/nuttx/pull/8355#discussion_r1090746638
##
sched/addrenv/addrenv.c:
##
@@ -0,0 +1,523 @@
+/
+ * sched/addrenv/addrenv.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include "sched/sched.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+/
+ * Private Functions
+ /
+
+/
+ * Name: addrenv_dsr
+ *
+ * Description:
+ * Deferred service routine for destroying an address environment. This is
+ * so that the heavy lifting is not done when the context is switching, or
+ * from ISR.
+
+ * Input Parameters:
+ * arg - Contains pointer to the address environment that is freed
+ *
+ * Returned Value:
+ * None
+ *
+ /
+
+static void addrenv_dsr(FAR void *arg)
+{
+ FAR struct addrenv_s *addrenv = (FAR struct addrenv_s *)arg;
+
+ /* Destroy the address environment */
+
+ up_addrenv_destroy(>pgdir);
+
+ /* Then finally release the memory */
+
+ kmm_free(addrenv);
+}
+
+/
+ * Public Data
+ /
+
+/* This variable holds the current address environment. These contents are
+ * _never_ NULL, besides when the system is started and there are only the
+ * initial kernel mappings available.
+ *
+ * This must only be accessed with interrupts disabled.
+ */
+
+static FAR struct addrenv_s *g_addrenv[CONFIG_SMP_NCPUS];
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: addrenv_switch
+ *
+ * Description:
+ * Instantiate the group address environment for the current thread at the
+ * the head of the ready to run list.
+ *
+ * This function is called from platform-specific code after any context
+ * switch (i.e., after any change in the thread at the head of the
+ * ready-to-run list). This function will change the address environment
+ * if the new thread is part of a different task group.
+ *
+ * Input Parameters:
+ * tcb - The TCB of thread that needs an address environment. This should
+ * be the TCB at the head of the ready-to-run list, but that is not
+ * enough.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. A negated errno value is returned on
+ * any failure.
+ *
+ * Assumptions:
+ * This function should only be called within critical OS sections with
+ * interrupts disabled. Interrupts are disabled internally just to be
+ * certain, however.
+ *
+ /
+
+int addrenv_switch(FAR struct tcb_s *tcb)
+{
+ FAR struct addrenv_s *curr;
+ FAR struct addrenv_s *next;
+ irqstate_t flags;
+ int cpu;
+ int ret;
+
+ /* NULL for the tcb means to use the TCB of the task at the head of the
+ * ready to run list.
+ */
+
+ if (!tcb)
+{
+ tcb = this_task();
+}
+
+ DEBUGASSERT(tcb);
+ next = tcb->mm_curr;
+
+ /* Does the group have an address environment? */
+
+ if (!next)
+{
+ /* No... just return perhaps leaving a different address environment
+ * intact.
+ */
+
+ return OK;
+}
+
