[GitHub] [nuttx] jerpelea merged pull request #8534: Adding myself to AUTHORS
jerpelea merged PR #8534: URL: https://github.com/apache/nuttx/pull/8534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #8536: STM32H7 socketcan extended filter fixes
davids5 commented on code in PR #8536: URL: https://github.com/apache/nuttx/pull/8536#discussion_r1106733563 ## arch/arm/src/stm32h7/stm32_fdcan_sock.c: ## @@ -2236,9 +2236,20 @@ int fdcan_initialize(struct fdcan_driver_s *priv) putreg32(regval, priv->base + STM32_FDCAN_SIDFC_OFFSET); ram_offset += n_stdid; - /* Extended ID Filters: Allow space for 128 filters (128 words) */ + /* Extended ID Filters: Allow space for 64 filters (64 words) + * The reference manual claims that 128 words are possible, but in Review Comment: ```suggestion * The register definition of FDCAN_XIDFC:LSE - List size extended, in the reference manual (RM0433 Rev 8) is defined as 8 bits and claims that a value of 0-128 (Number of extended ID filter elements) are possible, but in the text in section 56.4.22 and in ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] julianoes opened a new pull request, #8536: STM32H7 socketcan extended filter fixes
julianoes opened a new pull request, #8536: URL: https://github.com/apache/nuttx/pull/8536 ## Summary When I checked how this register was set I discovered that 128 was not accepted by the H7 but 64 was ok. Looking at the STM32Cube's HAL it seems to be only 64 words long, however, the reference manual claims otherwise. I have opened a discussion on the ST community forum https://community.st.com/s/question/0D73W01nzqFSAQ but unfortunately not received an answer yet. In the meantime, I think, we should update this to what I found to be working though. ## Impact I expect this to help to get socketcan working on H7. ## Testing I've tested this on a board but it would be great if someone could cross test this on another platform, if possible. FYI @davids5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
xiaoxiang781216 commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1106630085 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: Ok, let's wait your finding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1557: Wolfssl code back
xiaoxiang781216 commented on PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#issuecomment-1430727537 @jpbland1 but I don't see the download/clone in Makefile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE opened a new pull request, #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE opened a new pull request, #8535: URL: https://github.com/apache/nuttx/pull/8535 ## Summary SOCK_CTRL is added to provide special control over network drivers and daemons. Currently, SOCK_DGRAM and SOCK_STREAM perform this control, but these use socket resources. In the case of usersocket in particular, this is a waste of the device's limited socket resources. ## Impact Applications using NET_SOCK_TYPE. ## Testing Confirmed that it works with spresense:rndis and qemu-armv8a:netnsh config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106563655 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: The directory is different on Mac and Linux. From macOS Catalina and above the X11 libraries will install to opt/X11/lib. Only opt/X11/bin will be added to PATH so build system cannot find linker even aftermarket exporting /lib to PATH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8524: usbdev/adb: add adb usbclass_unbind function
masayuki2009 commented on PR #8524: URL: https://github.com/apache/nuttx/pull/8524#issuecomment-1430628720 @zyfeier >Yes, it's in the internal review. I'm interested in how the USB device mode (not the USB host mode) works on the NuttX simulator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan opened a new pull request, #8534: Adding myself to AUTHORS
hartmannathan opened a new pull request, #8534: URL: https://github.com/apache/nuttx/pull/8534 ## Summary Adding myself to AUTHORS file. ## Impact None. ## Testing N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 409e2f37012cffd4aa3ebd12b969ae57e8aaacde
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 6c959e5c Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff
docs: 409e2f37012cffd4aa3ebd12b969ae57e8aaacde
6c959e5c is described below
commit 6c959e5c891387204382589fc5cf09de4e2fa23f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Wed Feb 15 00:13:13 2023 +
Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs:
409e2f37012cffd4aa3ebd12b969ae57e8aaacde
---
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/12.0.0/index.html | 2 +-
content/docs/12.0.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
17 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index cb0c73a9..229f6869 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 14 February 23 at 00:11
+Last Updated: 15 February 23 at 00:10
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index 0f238a8e..2f020209 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index befdcabb..58777867 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -147,7 +147,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 14 February 23 at 00:11
+Last Updated: 15 February 23 at 00:11
Table of
Contents
diff --git a/content/docs/10.0.1/searchindex.js
b/content/docs/10.0.1/searchindex.js
index 0f238a8e..86799939 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
[nuttx] branch master updated (b9ba262fb7 -> 409e2f3701)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b9ba262fb7 risc-v/mpfs: add athena irq defines add 409e2f3701 drivers/serial, libc/termios: Implement tcsendbreak No new revisions were added by this update. Summary of changes: drivers/serial/serial.c | 101 libs/libc/termios/Make.defs | 2 +- libs/libc/termios/lib_tcsendbreak.c | 112 3 files changed, 214 insertions(+), 1 deletion(-) create mode 100644 libs/libc/termios/lib_tcsendbreak.c
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8483: drivers/serial, libc/termios: Implement tcsendbreak
xiaoxiang781216 merged PR #8483: URL: https://github.com/apache/nuttx/pull/8483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8483: drivers/serial, libc/termios: Implement tcsendbreak
xiaoxiang781216 commented on code in PR #8483:
URL: https://github.com/apache/nuttx/pull/8483#discussion_r1106496663
##
drivers/serial/serial.c:
##
@@ -485,6 +489,87 @@ static int uart_tcdrain(FAR uart_dev_t *dev,
return ret;
}
+/
+ * Name: uart_tcsendbreak
+ *
+ * Description:
+ * Request a serial line Break by calling the lower half driver's
+ * BSD-compatible Break IOCTLs TIOCSBRK and TIOCCBRK, with a sleep of the
+ * specified duration between them.
+ *
+ * Input Parameters:
+ * dev - Serial device.
+ * filep- Required for issuing lower half driver IOCTL call.
+ * ms - If non-zero, duration of the Break in milliseconds; if
+ * zero, duration is 400 milliseconds.
+ *
+ * Returned Value:
+ * 0 on success or a negated errno value on failure.
+ *
+ /
+
+static int uart_tcsendbreak(FAR uart_dev_t *dev, FAR struct file *filep,
+unsigned int ms)
+{
+ int ret;
+
+ /* tcsendbreak is a cancellation point */
+
+ if (enter_cancellation_point())
+{
+#ifdef CONFIG_CANCELLATION_POINTS
Review Comment:
ok, let keep it mow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106496154 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: let's remove #else block and share STDLIBS for both host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] fjpanag closed issue #1562: Assertion fails while freeing IOBs.
fjpanag closed issue #1562: Assertion fails while freeing IOBs. URL: https://github.com/apache/nuttx-apps/issues/1562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] fjpanag opened a new issue, #8533: Assertion fails while freeing IOBs.
fjpanag opened a new issue, #8533:
URL: https://github.com/apache/nuttx/issues/8533
I constantly get the following assertion to fail:
`mm/iob/iob_free.c:100`
```c
/* Copy and decrement the total packet length, being careful to
* do nothing too crazy.
*/
if (iob->io_pktlen > iob->io_len)
{
/* Adjust packet length and move it to the next entry */
next->io_pktlen = iob->io_pktlen - iob->io_len;
DEBUGASSERT(next->io_pktlen >= next->io_len);
}
```
At least for me, the failure seems to be triggered while I am using a custom
TCP server (mostly when connections are closed).
I haven't been able to find any specific commit that is suspicious.
Unfortunately, I am also not able to reproduce the issue reliably.
It randomly happens, sometimes almost immediately when connections are
closed, sometimes everything seems fine for extended periods of time.
I would appreciate any hint as to what to look for to fix this.
---
As a reference, this is the stack trace at the moment of the failure:
*(Moved from the apps repo,
[where](https://github.com/apache/nuttx-apps/issues/1562) I accidentally opened
the issue.)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx-apps] fjpanag commented on issue #1562: Assertion fails while freeing IOBs.
fjpanag commented on issue #1562: URL: https://github.com/apache/nuttx-apps/issues/1562#issuecomment-1430437165 Ooops... This bellongs to the kernel repository, not to the apps... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] TimJTi commented on issue #8491: USB HID Keyboard causes crash
TimJTi commented on issue #8491: URL: https://github.com/apache/nuttx/issues/8491#issuecomment-1430435316 @acassis - I only have sama5 boards and not sure if my eval boards are still usable! My thinking was that since the USB memory stick works 100% reliably and I can plug/unplug many times without issue it was unlikely to be the SAMA5 usb code - but it is possible. I think one is ohci and the other ehci so i will investigate further. After all, I did find an issue with the SAMA5 device driver so further issues are I guess rather likely. I did trace the connect, enumeration, and detach events and they superficially seemed to make sense. the keyboard actually works the first time, and it "feels" perhaps like a big chunk of memory is not being released. What I've not got a good handle on is debugging full blown crashes as the screenful's of register dumps seem rather pointless! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] fjpanag opened a new issue, #8532: MSG_PEEK support
fjpanag opened a new issue, #8532: URL: https://github.com/apache/nuttx/issues/8532 As far as I can tell `MSG_PEEK` is not supported by TCP sockets. It would be great to add support for this feature. This flag can be very useful when the size of the incoming packet is unknown, and it is encoded in the packet itself. You can "peek" into the data, determine the size of the packer, allocate the needed space, and then perform the actual read. A great example of this is MQTT. In MQTT you have a header byte, 1 to 4 bytes that encode the size of the payload, and then the payload. Now, these bytes have to be read one-by-one, allocate the space and then read the payload. This is not optimal, because if the packet has not been received yet completely (or malloc fails), it is difficult to try again later. (You have to keep somewhere the already read data to reuse later - complicated). With `MSG_PEEK` you can read bytes 1-4 to determine the size, check that everything is correct, and then read in one go. If everything goes wrong, just try again later. Everything is still in the buffer, untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on issue #8491: USB HID Keyboard causes crash
acassis commented on issue #8491: URL: https://github.com/apache/nuttx/issues/8491#issuecomment-1430224898 @TimJTi Did you test it on STM32F4Discovery board to confirm the issue is not in your arch driver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on pull request #8483: drivers/serial, libc/termios: Implement tcsendbreak
hartmannathan commented on PR #8483: URL: https://github.com/apache/nuttx/pull/8483#issuecomment-1430186312 Hmm. It seems I should rebase on latest master... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8483: drivers/serial, libc/termios: Implement tcsendbreak
hartmannathan commented on code in PR #8483:
URL: https://github.com/apache/nuttx/pull/8483#discussion_r1106204091
##
drivers/serial/serial.c:
##
@@ -485,6 +489,87 @@ static int uart_tcdrain(FAR uart_dev_t *dev,
return ret;
}
+/
+ * Name: uart_tcsendbreak
+ *
+ * Description:
+ * Request a serial line Break by calling the lower half driver's
+ * BSD-compatible Break IOCTLs TIOCSBRK and TIOCCBRK, with a sleep of the
+ * specified duration between them.
+ *
+ * Input Parameters:
+ * dev - Serial device.
+ * filep- Required for issuing lower half driver IOCTL call.
+ * ms - If non-zero, duration of the Break in milliseconds; if
+ * zero, duration is 400 milliseconds.
+ *
+ * Returned Value:
+ * 0 on success or a negated errno value on failure.
+ *
+ /
+
+static int uart_tcsendbreak(FAR uart_dev_t *dev, FAR struct file *filep,
+unsigned int ms)
+{
+ int ret;
+
+ /* tcsendbreak is a cancellation point */
+
+ if (enter_cancellation_point())
+{
+#ifdef CONFIG_CANCELLATION_POINTS
Review Comment:
I don't know; in other functions (e.g., see uart_tcdrain() above this
function) `#ifdef CONFIG_CANCELLATION_POINTS` is after `if
(enter_cancellation_point())`. If order should be changed, then perhaps we are
not consistent everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1430184759 > > > @spi3ex let's squash the last two patch into one > > > > > > I'm unable to do, It is not possible for this "git error". > > Just follow the instructions here: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request > > There is not problem if you have a commit after the commit you want to squash. Just add "squash" or "s" in the third line (the commit before the "remove -L/opt/X11/lib". > > The git rebase interactive is very flexible, you can even use it to change the commits order. Thanks @acassis , it worked now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #7525: Improvements in TCP connections allocation.
xiaoxiang781216 commented on PR #7525: URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1430177540 @fjpanag thanks, I will review it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8483: drivers/serial, libc/termios: Implement tcsendbreak
xiaoxiang781216 commented on code in PR #8483:
URL: https://github.com/apache/nuttx/pull/8483#discussion_r1106188619
##
drivers/serial/serial.c:
##
@@ -485,6 +489,87 @@ static int uart_tcdrain(FAR uart_dev_t *dev,
return ret;
}
+/
+ * Name: uart_tcsendbreak
+ *
+ * Description:
+ * Request a serial line Break by calling the lower half driver's
+ * BSD-compatible Break IOCTLs TIOCSBRK and TIOCCBRK, with a sleep of the
+ * specified duration between them.
+ *
+ * Input Parameters:
+ * dev - Serial device.
+ * filep- Required for issuing lower half driver IOCTL call.
+ * ms - If non-zero, duration of the Break in milliseconds; if
+ * zero, duration is 400 milliseconds.
+ *
+ * Returned Value:
+ * 0 on success or a negated errno value on failure.
+ *
+ /
+
+static int uart_tcsendbreak(FAR uart_dev_t *dev, FAR struct file *filep,
+unsigned int ms)
+{
+ int ret;
+
+ /* tcsendbreak is a cancellation point */
+
+ if (enter_cancellation_point())
+{
+#ifdef CONFIG_CANCELLATION_POINTS
Review Comment:
should we move before line 518?
##
libs/libc/termios/lib_tcsendbreak.c:
##
@@ -0,0 +1,112 @@
+/
+ * libs/libc/termios/lib_tcsendbreak.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+
+#include
+#include
+
+#include
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: tcsendbreak
+ *
+ * Description:
+ * Transmit a serial line Break, which is a continuous stream of 0 bits.
+ *
+ * A proper Break needs to last longer than a NUL ('\0') character.
+ * Effectively this causes a Framing Error at the receiver's UART. Most
+ * UARTs have the ability to distinguish between a Break and other types
+ * of Framing Errors and may treat it specially. Some devices utilize
+ * Breaks for things like synchronization.
+ *
+ * Regarding the duration parameter and its portability between Unix-like
+ * systems: It seems that a duration parameter of 0 specifies a Break of
+ * 0.25 to 0.5 seconds with consistency between various Unix flavors, but
+ * the interpretation of a nonzero duration parameter varies wildly from
+ * one operating system to another:
+ *
+ * - Linux, AIX, Tru64: duration in milliseconds
+ * - BSDs, macOS, HP-UX: ignore duration
+ * - Solaris, UnixWare: behaves like tcdrain()
+ *
+ * On FreeBSD and OpenBSD, a duration of 0 gives a Break of 0.4 seconds.
+ *
+ * Sources of information about the duration parameter include: the man
+ * page for termios(3) as found in release 5.13 of the Linux man-pages
+ * project, the man page for tcsendbreak(3) as found in FreeBSD 13.1 and
+ * OpenBSD 7.2, and some StackOverflow search results.
+ *
+ * In NuttX, we combine the above treatments of duration: Zero or negative
+ * values will give a Break of 0.4 seconds; positive values will be
+ * treated as a duration in milliseconds. We hope this combination will
+ * work well for programs that are ported from any of the above families.
+ *
+ * NuttX-specific implementation details: tcsendbreak() calls IOCTL
+ * TCSBRK. This is handled in the upper half serial driver (see
+ * drivers/serial/serial.c), which treats its argument like 'duration'
+ * described here, except unsigned, supporting only 0 or positive values;
+ * 0 maps to 400 and all other values are used as-is, in milliseconds.
+ * This, in turn, calls IOCTLs TIOCSBRK and TIOCCBRK to start and end a
+ *
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8525: drivers: record the latest scheduling information
xiaoxiang781216 commented on code in PR #8525: URL: https://github.com/apache/nuttx/pull/8525#discussion_r1106163907 ## drivers/note/note_initialize.c: ## @@ -25,6 +25,7 @@ #include #include #include +#include Review Comment: ```suggestion #include ``` ## include/nuttx/note/note_lastsched.h: ## @@ -0,0 +1,49 @@ +/ + * include/nuttx/note/note_lastsched.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __INCLUDE_NUTTX_NOTE_LASTSCHED_DRIVER_H +#define __INCLUDE_NUTTX_NOTE_LASTSCHED_DRIVER_H + +/ + * Included Files + / + +#include + +/ + * Public Function Prototypes + / + +#ifdef CONFIG_DRIVER_NOTE_LASTSCHED + +/ + * Name: note_lastched_register + / + +int note_lastched_register(void); + +/ + * Name: note_lastsched_dump + / + +void note_lastsched_dump(void); Review Comment: let's call panic_notifier_call_chain and dump automatically ## drivers/note/note_lastsched_driver.c: ## @@ -0,0 +1,397 @@ +/ + * drivers/note/note_lastsched_driver.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include +#include +#include + +#include +#include +#include +#include +#include + +/ + * Private Function Prototypes + / + +static void note_lastsched_start(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_stop(FAR struct note_driver_s *drv, +FAR struct tcb_s *tcb); +#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH +static void note_lastsched_suspend(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_resume(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +# ifdef CONFIG_SMP +static void note_lastsched_cpu_start(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb, int cpu); +static void note_lastsched_cpu_started(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_cpu_pause(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb, int cpu);
[GitHub] [nuttx-apps] jpbland1 commented on a diff in pull request #1557: Wolfssl code back
jpbland1 commented on code in PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#discussion_r1106175871 ## crypto/wolfssl/Makefile: ## @@ -0,0 +1,136 @@ +include $(APPDIR)/Make.defs + +# wolfSSL SSL/TLS crypto library + +WOLFSSL_VERSION = $(patsubst "%",%,$(strip $(CONFIG_WOLFSSL_VERSION))) + +WOLFSSL_UNPACKNAME = wolfssl +WOLFSSL_EXAMPLESNAME = wolfssl-examples +UNPACK ?= unzip -q -o + +# WOLFSSL TLS FILES +CSRCS += $(WOLFSSL_UNPACKNAME)/src/crl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/internal.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/keys.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ocsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/sniffer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ssl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls13.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/wolfio.c + +# wolfCrypt Core (FIPS validated crypto available contact f...@wolfssl.com) +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/aes.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/des3.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/dh.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/random.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rsa.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha256.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha512.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha3.c + +# wolfCrypt Additional +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asn.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/blake2s.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha20_poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/coding.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/compress.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cpuid.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cryptocb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc_fp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/eccsi.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/error.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hash.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/kdf.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/integer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/logging.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/md5.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/memory.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs12.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs7.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pwdbased.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rc2.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sakke.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/signature.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/srp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_armthumb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_cortexm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_dsp32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_int.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_x86_64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/tfm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_dsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_encrypt.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_pkcs11.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_port.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfevent.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfmath.c + + +CFLAGS += -DWOLFSSL_USER_SETTINGS + + Review Comment: or did you mean the white space, that I removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8515: tools: Extract a valid trace line and resolve the address to a function name
xiaoxiang781216 commented on code in PR #8515:
URL: https://github.com/apache/nuttx/pull/8515#discussion_r1106148434
##
tools/parsetrace.py:
##
@@ -0,0 +1,197 @@
+#!python3
+
+# tools/parsetrace.py
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+import argparse
+import bisect
+import os
+import re
+from typing import Union
+
+import cxxfilt
+import parse
+from elftools.elf.elffile import ELFFile
+from elftools.elf.sections import SymbolTableSection
+from pydantic import BaseModel
+
+
+class SymbolTables(object):
+def __init__(self, file):
+elffile = open(file, "rb")
+self.elffile = ELFFile(elffile)
+self.symbol_dict = dict()
+self.addr_list = list()
+
+def __symbol_filter(self, symbol):
+if symbol["st_info"]["type"] != "STT_FUNC":
+return None
+if symbol["st_info"]["bind"] == "STB_WEAK":
+return None
+if symbol["st_shndx"] == "SHN_UNDEF":
+return None
+return symbol
+
+def __get_symtable(self):
+symbol_tables = [
+s
+for _, s in enumerate(self.elffile.iter_sections())
+if isinstance(s, SymbolTableSection)
+and s.name == ".symtab"
+and s["sh_entsize"]
+]
+
+if not symbol_tables:
+return None
+
+return symbol_tables[0]
+
+def parse_symbol(self):
+if self.elffile is None:
+return
+
+symtable = self.__get_symtable()
+for nsym, symbol in enumerate(symtable.iter_symbols()):
+if self.__symbol_filter(symbol) is not None:
+symbol_name = cxxfilt.demangle(symbol.name)
+func_name = re.sub(r"\(.*$", "", symbol_name)
+if func_name[0] == "_" or func_name.find(".") != -1:
+continue
+
+self.symbol_dict[symbol["st_value"] & ~0x01] = func_name
+self.addr_list = sorted(self.symbol_dict, reverse=False)
+
+def addr2symbol(self, addr: int):
+index = bisect.bisect(self.addr_list, addr) - 1
+if index != -1:
+return self.symbol_dict[self.addr_list[index]]
+return "<%#x>: unknow function" % addr
Review Comment:
should we keep the original address without change
##
tools/parsetrace.py:
##
@@ -0,0 +1,197 @@
+#!python3
+
+# tools/parsetrace.py
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+import argparse
+import bisect
+import os
+import re
+from typing import Union
+
+import cxxfilt
+import parse
+from elftools.elf.elffile import ELFFile
+from elftools.elf.sections import SymbolTableSection
+from pydantic import BaseModel
+
+
+class SymbolTables(object):
+def __init__(self, file):
+elffile = open(file, "rb")
+self.elffile = ELFFile(elffile)
+self.symbol_dict = dict()
+self.addr_list = list()
+
+def __symbol_filter(self, symbol):
+if symbol["st_info"]["type"] != "STT_FUNC":
+return None
+if symbol["st_info"]["bind"] == "STB_WEAK":
+return None
+if symbol["st_shndx"] == "SHN_UNDEF":
+return None
+return
[GitHub] [nuttx] acassis commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
acassis commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1430139064 > > @spi3ex let's squash the last two patch into one > > I'm unable to do, It is not possible for this "git error". Just follow the instructions here: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request There is not problem if you have a commit after the commit you want to squash. Just add "squash" or "s" in the third line (the commit before the "remove -L/opt/X11/lib". The git rebase interactive is very flexible, you can even use it to change the commits order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106145710 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -L/opt/X11/lib -lXext Review Comment: without -L/opt/X11/lib , the linker does not find the libraries even if added to PATHon macOS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8531: Refine the drivers/note Kconfig
acassis commented on PR #8531: URL: https://github.com/apache/nuttx/pull/8531#issuecomment-1430132626 @xiaoxiang781216 I didn't get the complete idea, why it is needed to move this driver from drivers/note/ just because some boards could have their our implementation. Could just keep the generic implementation inside drivers/note and use the board specific like a CUSTOM driver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1430130119 > @spi3ex let's squash the last two patch into one I'm unable to do, It is not possible for this "git error". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106145710 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -L/opt/X11/lib -lXext Review Comment: without -L/opt/X11/lib , the linker does not find the libraries even if added to PATH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106143739 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -L/opt/X11/lib -lXext Review Comment: Remove the second -L/opt/X11/lib. BTW, can we remove all -L/opt/X11/lib like Linux? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] spi3ex commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
spi3ex commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1106143014 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: > I just try sim:lvgl_fb, but can't reproduce your symptom: > https://user-images.githubusercontent.com/18066964/218812978-25496046-adfb-49ba-8d78-b28609cc7dec.png;> > lvgl package only download the first time. Maybe a macOS issue, will try another fix then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1430124211 @spi3ex let's squash the last two patch into one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1565: Bug fix on repeated lvgl downloads from git
xiaoxiang781216 commented on PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#issuecomment-1430120121 I just sim:lvgl_fb, but can't reproduce your symptom: https://user-images.githubusercontent.com/18066964/218812978-25496046-adfb-49ba-8d78-b28609cc7dec.png;> lvgl package only download the first time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] spi3ex commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
spi3ex commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1106135874 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: Okay I will check on that in my local machine on if the indent is required or not, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
xiaoxiang781216 commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1106131760 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: > The LVGL application requires #include to compile if the lvgl source is already built "lvgl.h" will be present in (LVGL_UNPACKNAME)/lvgl.h and it will return true. > [2] without Indent I see makefile errors. But the ci run many boards which enable lvgl, no error report before this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] jpbland1 commented on a diff in pull request #1557: Wolfssl code back
jpbland1 commented on code in PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#discussion_r1106122181 ## crypto/wolfssl/Makefile: ## @@ -0,0 +1,136 @@ +include $(APPDIR)/Make.defs + +# wolfSSL SSL/TLS crypto library + +WOLFSSL_VERSION = $(patsubst "%",%,$(strip $(CONFIG_WOLFSSL_VERSION))) + +WOLFSSL_UNPACKNAME = wolfssl +WOLFSSL_EXAMPLESNAME = wolfssl-examples +UNPACK ?= unzip -q -o + +# WOLFSSL TLS FILES +CSRCS += $(WOLFSSL_UNPACKNAME)/src/crl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/internal.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/keys.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ocsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/sniffer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ssl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls13.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/wolfio.c + +# wolfCrypt Core (FIPS validated crypto available contact f...@wolfssl.com) +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/aes.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/des3.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/dh.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/random.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rsa.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha256.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha512.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha3.c + +# wolfCrypt Additional +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asn.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/blake2s.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha20_poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/coding.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/compress.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cpuid.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cryptocb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc_fp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/eccsi.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/error.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hash.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/kdf.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/integer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/logging.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/md5.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/memory.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs12.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs7.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pwdbased.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rc2.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sakke.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/signature.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/srp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_armthumb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_cortexm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_dsp32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_int.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_x86_64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/tfm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_dsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_encrypt.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_pkcs11.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_port.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfevent.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfmath.c + + +CFLAGS += -DWOLFSSL_USER_SETTINGS + + Review Comment: that has to be there, wolfssl needs that flag so it knows to read the user_settings.h file instead of the normal configure command -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at:
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1557: Wolfssl code back
xiaoxiang781216 commented on code in PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#discussion_r1106112217 ## crypto/wolfssl/Makefile: ## @@ -0,0 +1,136 @@ +include $(APPDIR)/Make.defs + +# wolfSSL SSL/TLS crypto library + +WOLFSSL_VERSION = $(patsubst "%",%,$(strip $(CONFIG_WOLFSSL_VERSION))) + +WOLFSSL_UNPACKNAME = wolfssl +WOLFSSL_EXAMPLESNAME = wolfssl-examples +UNPACK ?= unzip -q -o + +# WOLFSSL TLS FILES +CSRCS += $(WOLFSSL_UNPACKNAME)/src/crl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/internal.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/keys.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ocsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/sniffer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/ssl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/tls13.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/wolfio.c + +# wolfCrypt Core (FIPS validated crypto available contact f...@wolfssl.com) +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/aes.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/des3.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/dh.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hmac.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/random.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rsa.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha256.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha512.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sha3.c + +# wolfCrypt Additional +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/asn.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/blake2s.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/chacha20_poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/coding.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/compress.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cpuid.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/cryptocb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/curve448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ecc_fp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/eccsi.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed25519.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ed448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/error.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/fe_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_448.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_low_mem.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/ge_operations.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/hash.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/kdf.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/integer.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/logging.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/md5.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/memory.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs12.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pkcs7.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/poly1305.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/pwdbased.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/rc2.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sakke.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/signature.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/srp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_arm64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_armthumb.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_c64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_cortexm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_dsp32.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_int.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/sp_x86_64.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/tfm.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_dsp.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_encrypt.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_pkcs11.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wc_port.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfevent.c +CSRCS += $(WOLFSSL_UNPACKNAME)/wolfcrypt/src/wolfmath.c + + Review Comment: remove the blank line ## crypto/wolfssl/Makefile: ## @@ -0,0 +1,136 @@ +include $(APPDIR)/Make.defs + +# wolfSSL SSL/TLS crypto library + +WOLFSSL_VERSION = $(patsubst "%",%,$(strip $(CONFIG_WOLFSSL_VERSION))) + +WOLFSSL_UNPACKNAME = wolfssl +WOLFSSL_EXAMPLESNAME = wolfssl-examples +UNPACK ?= unzip -q -o + +# WOLFSSL TLS FILES +CSRCS += $(WOLFSSL_UNPACKNAME)/src/crl.c +CSRCS += $(WOLFSSL_UNPACKNAME)/src/internal.c +CSRCS +=
[GitHub] [nuttx-apps] jpbland1 commented on pull request #1557: Wolfssl code back
jpbland1 commented on PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#issuecomment-1430094592 yeah sorry, should have just made it simple, squashed again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1557: Wolfssl code back
xiaoxiang781216 commented on PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#issuecomment-1430091754 > I've squashed the readme commits, removed the old zip and curl logic since we now clone directly from git and removed the platform specific checks in user_settings.h But the last two commit still should merge to the first one since the intermediate change doesn't need keep in the history to confuse the people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1566: testing/cmocka: update cmocka version and add patch
xiaoxiang781216 commented on code in PR #1566: URL: https://github.com/apache/nuttx-apps/pull/1566#discussion_r1106108819 ## testing/cmocka/.gitignore: ## @@ -1 +0,0 @@ -/cmocka Review Comment: shuld we keep this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1567: system: Change DRIVER_NOTExxx to DRIVERS_NOTExxx
xiaoxiang781216 opened a new pull request, #1567: URL: https://github.com/apache/nuttx-apps/pull/1567 ## Summary follow the kernel side change: https://github.com/apache/nuttx/pull/8531 ## Impact Minor ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] jpbland1 commented on pull request #1557: Wolfssl code back
jpbland1 commented on PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#issuecomment-1430078438 I've squashed the readme commits, removed the old zip and curl logic since we now clone directly from git and removed the platform specific checks in user_settings.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8531: Refine the drivers/note Kconfig
xiaoxiang781216 opened a new pull request, #8531: URL: https://github.com/apache/nuttx/pull/8531 ## Summary - driver/note: Restore SCHED_INSTRUMENTATION config to sched/Konfig - drivers/note: Remove the dependence of noteram driver - drivers/note: Change DRIVER_NOTExxx to DRIVERS_NOTExxx ## Impact drivers/note ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8515: tools: Extract a valid trace line and resolve the address to a function name
hartmannathan commented on code in PR #8515: URL: https://github.com/apache/nuttx/pull/8515#discussion_r1106101271 ## tools/parsetrace.py: ## @@ -0,0 +1,197 @@ +#!python3 Review Comment: ```suggestion #!/usr/bin/env python3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] spi3ex commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
spi3ex commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1106087515 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: The LVGL application requires #include to compile if the lvgl source is already built "lvgl.h" will be present in (LVGL_UNPACKNAME)/lvgl.h and it will return true. [2] without Indent I see makefile errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex opened a new pull request, #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex opened a new pull request, #8530: URL: https://github.com/apache/nuttx/pull/8530 Summary ### macOS requires genromfs and X11 Libraries to run Simulators. Added instructions to install genromfs Added instructions to install X11 Impact # The Simulator will not run without these tools. Testing # This Works on ARM MacBooks. Tested on sim:nsh Tested on sim:lvgl_lcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: risc-v/mpfs: add athena irq defines
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b9ba262fb7 risc-v/mpfs: add athena irq defines b9ba262fb7 is described below commit b9ba262fb7d3a562d8ab4a53217eeb0fb93f77cb Author: Eero Nurkkala AuthorDate: Tue Feb 14 15:48:18 2023 +0200 risc-v/mpfs: add athena irq defines Add the Athena cryptographic microprocessor irq defines. Signed-off-by: Eero Nurkkala --- arch/risc-v/include/mpfs/irq.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/risc-v/include/mpfs/irq.h b/arch/risc-v/include/mpfs/irq.h index fc968edd21..d33e9c24ce 100644 --- a/arch/risc-v/include/mpfs/irq.h +++ b/arch/risc-v/include/mpfs/irq.h @@ -200,6 +200,9 @@ #define MPFS_IRQ_WDOG2_TOUT (MPFS_IRQ_GLOBAL_START + 94) #define MPFS_IRQ_WDOG3_TOUT (MPFS_IRQ_GLOBAL_START + 95) #define MPFS_IRQ_WDOG4_TOUT (MPFS_IRQ_GLOBAL_START + 96) +#define MPFS_IRQ_ATHENA_COMPLETE(MPFS_IRQ_GLOBAL_START + 99) +#define MPFS_IRQ_ATHENA_ALARM (MPFS_IRQ_GLOBAL_START + 100) +#define MPFS_IRQ_ATHENA_BUS_ERROR (MPFS_IRQ_GLOBAL_START + 101) #define MPFS_IRQ_FABRIC_F2H_0 (MPFS_IRQ_GLOBAL_START + 105) #define MPFS_IRQ_FABRIC_F2H_1 (MPFS_IRQ_GLOBAL_START + 106) #define MPFS_IRQ_FABRIC_F2H_2 (MPFS_IRQ_GLOBAL_START + 107)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8529: risc-v/mpfs: add athena irq defines
xiaoxiang781216 merged PR #8529: URL: https://github.com/apache/nuttx/pull/8529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex closed pull request #8526: Simulator Documentation for macOS
spi3ex closed pull request #8526: Simulator Documentation for macOS URL: https://github.com/apache/nuttx/pull/8526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
xiaoxiang781216 commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1105910529 ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) -context:: $(LVGL_UNPACKNAME) + context:: $(LVGL_UNPACKNAME) Review Comment: why add intent for the follow code ## graphics/lvgl/Makefile: ## @@ -106,12 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) touch $(LVGL_UNPACKNAME) # Download and unpack tarball if no git repo found + ifeq ($(wildcard $(LVGL_UNPACKNAME)/.git),) Review Comment: let's move to line 98 and replace: ifneq ($(wildcard $(LVGL_UNPACKNAME)/lvgl.h) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8526: Simulator Documentation for macOS
xiaoxiang781216 commented on PR #8526: URL: https://github.com/apache/nuttx/pull/8526#issuecomment-1429846999 @spi3ex could you sqush your patch into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: utsname: Expand the buffer for version information slightly
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a9fb20039e utsname: Expand the buffer for version information slightly a9fb20039e is described below commit a9fb20039ee0204d5b430c98e096fabf34e23716 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate: Tue Feb 14 17:38:41 2023 +0900 utsname: Expand the buffer for version information slightly The version information basically uses 20 characters for date and time, which is small enough to specify an arbitrary version string. Therefore, increase the buffer a little. --- include/sys/utsname.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sys/utsname.h b/include/sys/utsname.h index 3920299cd8..03c4a08010 100644 --- a/include/sys/utsname.h +++ b/include/sys/utsname.h @@ -47,7 +47,7 @@ / #define SYS_NAMELEN 21 -#define VERSION_NAMELEN 41 +#define VERSION_NAMELEN 51 / * Public Types
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8527: utsname: Expand the buffer for version information slightly
xiaoxiang781216 merged PR #8527: URL: https://github.com/apache/nuttx/pull/8527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: usbdev/adb: add adb usbclass_unbind function
This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 32513cedf0 usbdev/adb: add adb usbclass_unbind function
32513cedf0 is described below
commit 32513cedf0bb9851ba04ba91454237d034e8ea0d
Author: zhangyuan21
AuthorDate: Thu Feb 2 14:34:31 2023 +0800
usbdev/adb: add adb usbclass_unbind function
Signed-off-by: zhangyuan21
---
drivers/usbdev/adb.c | 109 ++-
1 file changed, 108 insertions(+), 1 deletion(-)
diff --git a/drivers/usbdev/adb.c b/drivers/usbdev/adb.c
index 490819b983..281cf454e9 100644
--- a/drivers/usbdev/adb.c
+++ b/drivers/usbdev/adb.c
@@ -333,6 +333,28 @@ static const struct adb_cfgdesc_s g_adb_cfgdesc =
* Private Functions
/
+/
+ * Name: usbclass_freereq
+ *
+ * Description:
+ * Free a request instance along with its buffer
+ *
+ /
+
+static void usbclass_freereq(FAR struct usbdev_ep_s *ep,
+ FAR struct usbdev_req_s *req)
+{
+ if (ep != NULL && req != NULL)
+{
+ if (req->buf != NULL)
+{
+ EP_FREEBUFFER(ep, req->buf);
+}
+
+ EP_FREEREQ(ep, req);
+}
+}
+
/
* Name: usbclass_allocreq
*
@@ -1103,9 +1125,94 @@ errout:
static void usbclass_unbind(FAR struct usbdevclass_driver_s *driver,
FAR struct usbdev_s *dev)
{
+ FAR struct usbdev_adb_s *priv;
+ int i;
+
usbtrace(TRACE_CLASSUNBIND, 0);
- #warning Missing logic
+#ifdef CONFIG_DEBUG_FEATURES
+ if (!driver || !dev || !dev->ep0)
+{
+ usbtrace(TRACE_CLSERROR(USBSER_TRACEERR_INVALIDARG), 0);
+ return;
+}
+#endif
+
+ /* Extract reference to private data */
+
+ priv = &((FAR struct adb_driver_s *)driver)->dev;
+
+#ifdef CONFIG_DEBUG_FEATURES
+ if (!priv)
+{
+ usbtrace(TRACE_CLSERROR(USBSER_TRACEERR_EP0NOTBOUND), 0);
+ return;
+}
+#endif
+
+ /* Make sure that we are not already unbound */
+
+ if (priv != NULL)
+{
+ /* Make sure that the endpoints have been unconfigured. If
+ * we were terminated gracefully, then the configuration should
+ * already have been reset. If not, then calling usbclass_resetconfig
+ * should cause the endpoints to immediately terminate all
+ * transfers and return the requests to us (with result == -ESHUTDOWN)
+ */
+
+ usbclass_resetconfig(priv);
+
+ /* Free the bulk IN endpoint */
+
+ if (priv->epbulkin)
+{
+ DEV_FREEEP(dev, priv->epbulkin);
+ priv->epbulkin = NULL;
+}
+
+ /* Free the bulk OUT endpoint */
+
+ if (priv->epbulkout)
+{
+ DEV_FREEEP(dev, priv->epbulkout);
+ priv->epbulkout = NULL;
+}
+
+ /* Free the pre-allocated control request */
+
+ if (priv->ctrlreq != NULL)
+{
+ usbclass_freereq(dev->ep0, priv->ctrlreq);
+ priv->ctrlreq = NULL;
+}
+
+ /* Free write requests that are not in use (which should be all
+ * of them
+ */
+
+ for (i = 0; i < CONFIG_USBADB_NRDREQS; i++)
+{
+ FAR struct usbadb_rdreq_s *rdcontainer;
+
+ rdcontainer = >rdreqs[i];
+ if (rdcontainer->req != NULL)
+{
+ usbclass_freereq(priv->epbulkout, rdcontainer->req);
+}
+}
+
+ for (i = 0; i < CONFIG_USBADB_NWRREQS; i++)
+{
+ FAR struct usbadb_wrreq_s *wrcontainer;
+
+ wrcontainer = >wrreqs[i];
+ if (wrcontainer->req != NULL)
+{
+ usbclass_freereq(priv->epbulkin, wrcontainer->req);
+}
+}
+}
}
/
[GitHub] [nuttx] anchao merged pull request #8524: usbdev/adb: add adb usbclass_unbind function
anchao merged PR #8524: URL: https://github.com/apache/nuttx/pull/8524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: Added myself in AUTHORS file.
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4d341ed152 Added myself in AUTHORS file. 4d341ed152 is described below commit 4d341ed15251f0596edaf5e81d4fd3de175b6c68 Author: Fotis Panagiotopoulos AuthorDate: Tue Feb 14 13:24:36 2023 +0200 Added myself in AUTHORS file. --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index f0cb2362a1..724ef37d0e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -20,6 +20,7 @@ Daniel P. Carvalho David S. Alessio David Sidrane Dong Heng +Fotis Panagiotopoulos Giorgio Groß Goden Freemans Guiding Li
[GitHub] [nuttx] jerpelea merged pull request #8528: Added myself in AUTHORS file.
jerpelea merged PR #8528: URL: https://github.com/apache/nuttx/pull/8528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] eenurkka opened a new pull request, #8529: risc-v/mpfs: add athena irq defines
eenurkka opened a new pull request, #8529: URL: https://github.com/apache/nuttx/pull/8529 Add the Athena cryptographic microprocessor irq defines. Signed-off-by: Eero Nurkkala ## Summary Add a few defines ## Impact None ## Testing Tested IRQs performing some interaction with the Athena cryptoprocessor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zyfeier commented on pull request #8524: usbdev/adb: add adb usbclass_unbind function
zyfeier commented on PR #8524: URL: https://github.com/apache/nuttx/pull/8524#issuecomment-1429778459 > @zyfeier > > > sim usbdev > > Can we use usbdev on the NuttX simulator? Yes, it's in the internal review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] spi3ex commented on a diff in pull request #1565: Bug fix on repeated lvgl downloads from git
spi3ex commented on code in PR #1565: URL: https://github.com/apache/nuttx-apps/pull/1565#discussion_r1105837808 ## graphics/lvgl/Makefile: ## @@ -105,13 +107,14 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL) $(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME) $(Q) touch $(LVGL_UNPACKNAME) -# Download and unpack tarball if no git repo found +#Download and unpack tarball if no git repo found Review Comment: Hi @pkarashchenko , I think that is resolved in the latest commit, and also the logic is changed to check if "lvgl/lvgl.h" is present to skip the download of tar file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8524: usbdev/adb: add adb usbclass_unbind function
masayuki2009 commented on PR #8524: URL: https://github.com/apache/nuttx/pull/8524#issuecomment-1429739226 @zyfeier > sim usbdev Can we use usbdev on the NuttX simulator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8486: sched/nxtask_sigchild: Set process exit code to group exit code
pkarashchenko commented on code in PR #8486:
URL: https://github.com/apache/nuttx/pull/8486#discussion_r1105696648
##
sched/task/task_exithook.c:
##
@@ -80,7 +80,7 @@ static inline void nxtask_exitstatus(FAR struct task_group_s
*group,
}
#else
-# define nxtask_exitstatus(group,status)
+# define nxtask_exitstatus(group,status) (group)->tg_exitcode = (status);
Review Comment:
Yes. `do {} while (0)` is even better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] pussuw commented on a diff in pull request #8486: sched/nxtask_sigchild: Set process exit code to group exit code
pussuw commented on code in PR #8486:
URL: https://github.com/apache/nuttx/pull/8486#discussion_r1105674275
##
sched/task/task_exithook.c:
##
@@ -80,7 +80,7 @@ static inline void nxtask_exitstatus(FAR struct task_group_s
*group,
}
#else
-# define nxtask_exitstatus(group,status)
+# define nxtask_exitstatus(group,status) (group)->tg_exitcode = (status);
Review Comment:
Yes. I was going to do do { ... } while(0) but for some reason did this
brainfart instead.
Need to come back to this later.
##
sched/task/task_exithook.c:
##
@@ -80,7 +80,7 @@ static inline void nxtask_exitstatus(FAR struct task_group_s
*group,
}
#else
-# define nxtask_exitstatus(group,status)
+# define nxtask_exitstatus(group,status) (group)->tg_exitcode = (status);
Review Comment:
Yes. I was going to do `do { ... } while(0)` but for some reason did this
brainfart instead.
Need to come back to this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] fjpanag opened a new pull request, #8528: Added myself in AUTHORS file.
fjpanag opened a new pull request, #8528: URL: https://github.com/apache/nuttx/pull/8528 ## Summary Since I've signed the ICLA on 09/11/2020, shouldn't be in the authors list? If so, this PR takes care of it. ## Impact N/A ## Testing N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8486: sched/nxtask_sigchild: Set process exit code to group exit code
pkarashchenko commented on code in PR #8486: URL: https://github.com/apache/nuttx/pull/8486#discussion_r1105659865 ## sched/task/task_exithook.c: ## @@ -80,7 +80,7 @@ static inline void nxtask_exitstatus(FAR struct task_group_s *group, } #else -# define nxtask_exitstatus(group,status) +# define nxtask_exitstatus(group,status) (group)->tg_exitcode = (status); Review Comment: Better to `# define nxtask_exitstatus(group,status) ((group)->tg_exitcode = (status))` to catch possible missing `;` after `nxtask_exitstatus(a,b)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
pkarashchenko commented on code in PR #8523: URL: https://github.com/apache/nuttx/pull/8523#discussion_r1105651098 ## include/limits.h: ## @@ -136,11 +136,11 @@ #else /* CONFIG_SMALL_MEMORY */ -#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */ +#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */ Review Comment: ```suggestion #define _POSIX_SIZE_MAX ULONG_MAX ``` ## include/limits.h: ## @@ -136,11 +136,11 @@ #else /* CONFIG_SMALL_MEMORY */ -#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */ +#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */ #define _POSIX_SIZE_MIN 0 -#define _POSIX_SSIZE_MAX 2147483647L /* See sys/types.h */ -#define _POSIX_SSIZE_MIN -2147483648L +#define _POSIX_SSIZE_MAX LONG_MAX /* See sys/types.h */ Review Comment: ```suggestion #define _POSIX_SSIZE_MAX LONG_MAX ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE opened a new pull request, #8527: utsname: Expand the buffer for version information slightly
SPRESENSE opened a new pull request, #8527: URL: https://github.com/apache/nuttx/pull/8527 ## Summary The version information basically uses 20 characters for date and time, which is small enough to specify an arbitrary version string. Therefore, increase the buffer a little. ## Impact None ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex opened a new pull request, #8526: Simulator Documentation for macOS
spi3ex opened a new pull request, #8526: URL: https://github.com/apache/nuttx/pull/8526 Summary macOS requires genromfs and X11 Libraries to run Simulators. Added instructions to install genromfs Added instructions to install X11 Impact The Simulator will not run without these tools. Testing This Works on ARM MacBooks. Tested on sim:nsh Tested on sim:lvgl_lcd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
