[nuttx-apps] branch master updated: readline: Check the fd before echo
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 120797744 readline: Check the fd before echo
120797744 is described below
commit 1207977447daba0297212b3cba9e083c30334434
Author: Huang Qi
AuthorDate: Mon Feb 13 20:07:53 2023 +0800
readline: Check the fd before echo
Signed-off-by: Huang Qi
---
system/readline/readline_fd.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/system/readline/readline_fd.c b/system/readline/readline_fd.c
index e3e6101cc..351b416e4 100644
--- a/system/readline/readline_fd.c
+++ b/system/readline/readline_fd.c
@@ -117,6 +117,13 @@ static void readline_putc(FAR struct rl_common_s *vtbl,
int ch)
DEBUGASSERT(priv);
+ /* If outfd is a invalid fd, return directly. */
+
+ if (priv->outfd < 0)
+{
+ return;
+}
+
/* Loop until we successfully write a character (or until an unexpected
* error occurs).
*/
@@ -149,6 +156,13 @@ static void readline_write(FAR struct rl_common_s *vtbl,
FAR struct readline_s *priv = (FAR struct readline_s *)vtbl;
DEBUGASSERT(priv && buffer && buflen > 0);
+ /* If outfd is a invalid fd, return directly. */
+
+ if (priv->outfd < 0)
+{
+ return;
+}
+
write(priv->outfd, buffer, buflen);
}
#endif
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1569: readline: Check the fd before echo
xiaoxiang781216 merged PR #1569: URL: https://github.com/apache/nuttx-apps/pull/1569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] PeterBee97 opened a new pull request, #1570: system/nxcamera: fix sscanf overflow
PeterBee97 opened a new pull request, #1570: URL: https://github.com/apache/nuttx-apps/pull/1570 ## Summary Add space for trailing zero ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1567: system: Change DRIVER_NOTExxx to DRIVERS_NOTExxx
xiaoxiang781216 commented on PR #1567: URL: https://github.com/apache/nuttx-apps/pull/1567#issuecomment-1432626974 All update, but it merge with apache/nuttx#8531 tegather to fix the break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8525: drivers: record the latest scheduling information
Gary-Hobson commented on code in PR #8525: URL: https://github.com/apache/nuttx/pull/8525#discussion_r1108086294 ## include/nuttx/note/note_lastsched.h: ## @@ -0,0 +1,49 @@ +/ + * include/nuttx/note/note_lastsched.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __INCLUDE_NUTTX_NOTE_LASTSCHED_DRIVER_H +#define __INCLUDE_NUTTX_NOTE_LASTSCHED_DRIVER_H + +/ + * Included Files + / + +#include + +/ + * Public Function Prototypes + / + +#ifdef CONFIG_DRIVER_NOTE_LASTSCHED + +/ + * Name: note_lastched_register + / + +int note_lastched_register(void); + +/ + * Name: note_lastsched_dump + / + +void note_lastsched_dump(void); Review Comment: This will submit a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8525: drivers: record the latest scheduling information
Gary-Hobson commented on code in PR #8525:
URL: https://github.com/apache/nuttx/pull/8525#discussion_r1108085927
##
drivers/note/note_lastsched_driver.c:
##
@@ -0,0 +1,397 @@
+/
+ * drivers/note/note_lastsched_driver.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+/
+ * Private Function Prototypes
+ /
+
+static void note_lastsched_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_stop(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb);
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+static void note_lastsched_suspend(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# ifdef CONFIG_SMP
+static void note_lastsched_cpu_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_started(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_pause(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_paused(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_resumed(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# endif
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
+static void note_lastsched_premption(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, bool locked);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
+static void note_lastsched_csection(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb, bool enter);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SPINLOCKS
+static void note_spinlock(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, FAR volatile void *spinlock,
+ int type);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SYSCALL
+static void note_lastsched_syscall_enter(FAR struct note_driver_s *drv,
+ int nr, int argc, va_list *ap);
+static void note_lastsched_syscall_leave(FAR struct note_driver_s *drv,
+ int nr, uintptr_t result);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_IRQHANDLER
+static void note_lastsched_irqhandler(FAR struct note_driver_s *drv, int irq,
+ FAR void *handler, bool enter);
+#endif
+
+struct note_lastsched_chunk_s
+{
+ uint32_t systick;
+ uint32_t cpu_pid;
+ enum note_type_e type;
+ void *args;
+};
+
+struct note_lastsched_s
+{
+ uint32_t freq;
+ size_t index;
+ struct timespec ts;
+ struct note_lastsched_chunk_s
+ buffer[CONFIG_DRIVER_NOTE_LASTSCHED_NBUFFERS];
+};
+
+/
+ * Private Data
+ /
+
+static struct note_lastsched_s g_note_lastsched;
+
+static const struct note_driver_ops_s g_note_lastsched_ops =
+{
+ NULL,
+ note_lastsched_start,
+ note_lastsched_stop,
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+ note_lastsched_suspend,
+
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8525: drivers: record the latest scheduling information
Gary-Hobson commented on code in PR #8525: URL: https://github.com/apache/nuttx/pull/8525#discussion_r1108085777 ## drivers/note/note_initialize.c: ## @@ -74,5 +75,13 @@ int note_initialize(void) } #endif +#ifdef CONFIG_DRIVER_NOTE_LASTSCHED + ret = note_lastched_register(); Review Comment: done ## drivers/note/note_lastsched_driver.c: ## @@ -0,0 +1,397 @@ +/ + * drivers/note/note_lastsched_driver.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include +#include +#include + +#include +#include +#include +#include +#include + +/ + * Private Function Prototypes + / + +static void note_lastsched_start(FAR struct note_driver_s *drv, Review Comment: done ## drivers/note/note_lastsched_driver.c: ## @@ -0,0 +1,397 @@ +/ + * drivers/note/note_lastsched_driver.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include +#include +#include + +#include +#include +#include +#include +#include + +/ + * Private Function Prototypes + / + +static void note_lastsched_start(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_stop(FAR struct note_driver_s *drv, +FAR struct tcb_s *tcb); +#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH +static void note_lastsched_suspend(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_resume(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +# ifdef CONFIG_SMP +static void note_lastsched_cpu_start(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb, int cpu); +static void note_lastsched_cpu_started(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_cpu_pause(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb, int cpu); +static void note_lastsched_cpu_paused(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +static void note_lastsched_cpu_resume(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb, int cpu); +static void note_lastsched_cpu_resumed(FAR struct note_driver_s *drv, + FAR struct tcb_s *tcb); +# endif +#endif +#ifdef
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8525: drivers: record the latest scheduling information
Gary-Hobson commented on code in PR #8525:
URL: https://github.com/apache/nuttx/pull/8525#discussion_r1108085589
##
drivers/note/note_lastsched_driver.c:
##
@@ -0,0 +1,397 @@
+/
+ * drivers/note/note_lastsched_driver.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+/
+ * Private Function Prototypes
+ /
+
+static void note_lastsched_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_stop(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb);
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+static void note_lastsched_suspend(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# ifdef CONFIG_SMP
+static void note_lastsched_cpu_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_started(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_pause(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_paused(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_resumed(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# endif
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
+static void note_lastsched_premption(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, bool locked);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
+static void note_lastsched_csection(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb, bool enter);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SPINLOCKS
+static void note_spinlock(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, FAR volatile void *spinlock,
+ int type);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SYSCALL
+static void note_lastsched_syscall_enter(FAR struct note_driver_s *drv,
+ int nr, int argc, va_list *ap);
+static void note_lastsched_syscall_leave(FAR struct note_driver_s *drv,
+ int nr, uintptr_t result);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_IRQHANDLER
+static void note_lastsched_irqhandler(FAR struct note_driver_s *drv, int irq,
+ FAR void *handler, bool enter);
+#endif
+
+struct note_lastsched_chunk_s
+{
+ uint32_t systick;
+ uint32_t cpu_pid;
+ enum note_type_e type;
+ void *args;
+};
+
+struct note_lastsched_s
+{
+ uint32_t freq;
+ size_t index;
+ struct timespec ts;
+ struct note_lastsched_chunk_s
+ buffer[CONFIG_DRIVER_NOTE_LASTSCHED_NBUFFERS];
+};
+
+/
+ * Private Data
+ /
+
+static struct note_lastsched_s g_note_lastsched;
+
+static const struct note_driver_ops_s g_note_lastsched_ops =
+{
+ NULL,
+ note_lastsched_start,
+ note_lastsched_stop,
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+ note_lastsched_suspend,
+
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8525: drivers: record the latest scheduling information
Gary-Hobson commented on code in PR #8525:
URL: https://github.com/apache/nuttx/pull/8525#discussion_r1108085445
##
drivers/note/note_lastsched_driver.c:
##
@@ -0,0 +1,397 @@
+/
+ * drivers/note/note_lastsched_driver.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+/
+ * Private Function Prototypes
+ /
+
+static void note_lastsched_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_stop(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb);
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+static void note_lastsched_suspend(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# ifdef CONFIG_SMP
+static void note_lastsched_cpu_start(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_started(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_pause(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_paused(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+static void note_lastsched_cpu_resume(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, int cpu);
+static void note_lastsched_cpu_resumed(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb);
+# endif
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
+static void note_lastsched_premption(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, bool locked);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
+static void note_lastsched_csection(FAR struct note_driver_s *drv,
+FAR struct tcb_s *tcb, bool enter);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SPINLOCKS
+static void note_spinlock(FAR struct note_driver_s *drv,
+ FAR struct tcb_s *tcb, FAR volatile void *spinlock,
+ int type);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SYSCALL
+static void note_lastsched_syscall_enter(FAR struct note_driver_s *drv,
+ int nr, int argc, va_list *ap);
+static void note_lastsched_syscall_leave(FAR struct note_driver_s *drv,
+ int nr, uintptr_t result);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_IRQHANDLER
+static void note_lastsched_irqhandler(FAR struct note_driver_s *drv, int irq,
+ FAR void *handler, bool enter);
+#endif
+
+struct note_lastsched_chunk_s
+{
+ uint32_t systick;
+ uint32_t cpu_pid;
+ enum note_type_e type;
+ void *args;
+};
+
+struct note_lastsched_s
+{
+ uint32_t freq;
+ size_t index;
+ struct timespec ts;
+ struct note_lastsched_chunk_s
+ buffer[CONFIG_DRIVER_NOTE_LASTSCHED_NBUFFERS];
+};
+
+/
+ * Private Data
+ /
+
+static struct note_lastsched_s g_note_lastsched;
+
+static const struct note_driver_ops_s g_note_lastsched_ops =
+{
+ NULL,
+ note_lastsched_start,
+ note_lastsched_stop,
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+ note_lastsched_suspend,
+
[nuttx] branch master updated (277e0b941a -> 491c3b564f)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 277e0b941a include/sys/socket.h: Add SOCK_CTRL to socket type add 491c3b564f Repeated Command "sudo port install" No new revisions were added by this update. Summary of changes: Documentation/guides/simulator.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8542: doc:sim Repeated Command "sudo port install"
xiaoxiang781216 merged PR #8542: URL: https://github.com/apache/nuttx/pull/8542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] no1wudi commented on pull request #1559: nsh: Decouple with CONFIG_FILE_STREAM
no1wudi commented on PR #1559: URL: https://github.com/apache/nuttx-apps/pull/1559#issuecomment-1432562707 Split to 2 PR (readline relative and nsh) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1569: readline: Check the fd before echo
no1wudi opened a new pull request, #1569: URL: https://github.com/apache/nuttx-apps/pull/1569 ## Summary readline: Check the fd before echo ## Impact readline, minor ## Testing QEMU -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432554742 I rased a new pull-request. https://github.com/apache/nuttx/pull/8543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE opened a new pull request, #8543: boards/spresense: Enable broadcast flag in DHCP process
SPRESENSE opened a new pull request, #8543: URL: https://github.com/apache/nuttx/pull/8543 ## Summary In spresense:wifi, renew command will be failed with disabling broadcast flag. For spresense defconfig, enabling it. ## Impact Spresense with GS2200 module only. ## Testing Confirmed that it works with spresense:wifi and spresense:wifi_smp config, and target AP is Xperia1 and RaspberryPi-B(Ubuntu 21.04). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432551787 > @SPRESENSE > > Thanks for your confirmation. I will merge this PR. > > > And I tried to set NETUTILS_DHCPC_BOOTP_FLAGS=0x8000 with #8535 change, WiFi working propery. > > OK. Could you please create a new PR that changes spresense:wifi and spresense:wifi_smp configurations to use the above value? Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8531: Refine the drivers/note Kconfig
hartmannathan commented on code in PR #8531: URL: https://github.com/apache/nuttx/pull/8531#discussion_r1107991809 ## sched/Kconfig: ## @@ -945,6 +945,148 @@ config SCHED_CPULOAD_TIMECONSTANT endif # SCHED_CPULOAD +menuconfig SCHED_INSTRUMENTATION + bool "System performance monitor hooks" + default n + select SCHED_SUSPENDSCHEDULER + select SCHED_RESUMESCHEDULER + ---help--- + Enables instrumentation in scheduler to monitor system performance. + If enabled, then the board-specific logic must provide the following + functions (see include/sched.h): + + void sched_note_start(FAR struct tcb_s *tcb); + void sched_note_stop(FAR struct tcb_s *tcb); + + If CONFIG_SMP is enabled, then these additional interfaces are + expected: + + void sched_note_cpu_start(FAR struct tcb_s *tcb, int cpu); + void sched_note_cpu_started(FAR struct tcb_s *tcb); + +if SCHED_INSTRUMENTATION + +config SCHED_INSTRUMENTATION_CPUSET + hex "CPU bit set" + default 0x + depends on SMP && SCHED_INSTRUMENTATION_FILTER + ---help--- + Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc. + +config SCHED_INSTRUMENTATION_HIRES + bool "Use Hi-Res RTC for instrumentation" + default n + ---help--- + Use higher resolution system timer for instrumentation. + +config SCHED_INSTRUMENTATION_FILTER + bool "Instrumenation filter" Review Comment: ```suggestion bool "Instrumentation filter" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8522: libc/lib_memcpy.c:Add mempcpy method.
hartmannathan commented on code in PR #8522: URL: https://github.com/apache/nuttx/pull/8522#discussion_r1107988011 ## libs/libc/string/lib_mempcpy.c: ## @@ -0,0 +1,40 @@ +/ + * libs/libc/string/lib_mempcpy.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include +#include +#include + +/ + * Public Functions + / + +/ + * Name: mempcpy + / Review Comment: I recommend a docstring. For example (feel free to commit as-is): ```suggestion * * Description: * Like memcpy(), but returns address of byte after the last copied byte * in dest. This allows constructing data piecewise by copying its parts * into consecutive memory locations. * * This function is not in POSIX. * * Input Parameters: * src - Source location from which to copy. * dest - Destination location into which to copy. * n- Size of data to be copied, in bytes. * * Returned Value: * A pointer to the byte in dest which immediately follows the last copied * byte. * / ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8522: libc/lib_memcpy.c:Add mempcpy method.
hartmannathan commented on code in PR #8522:
URL: https://github.com/apache/nuttx/pull/8522#discussion_r1107985392
##
libs/libc/string/lib_mempcpy.c:
##
@@ -0,0 +1,40 @@
+/
+ * libs/libc/string/lib_mempcpy.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: mempcpy
+ /
+
+FAR void *mempcpy(FAR void *dest, FAR const void *src, size_t n)
+{
+ return memcpy(dest, src, n) + n;
Review Comment:
You could try something like:
```
return (void *)((char *) memcpy(dest, src, n) + n);
```
I know, it's ugly. :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8522: libc/lib_memcpy.c:Add mempcpy method.
hartmannathan commented on code in PR #8522:
URL: https://github.com/apache/nuttx/pull/8522#discussion_r1107982937
##
libs/libc/string/lib_mempcpy.c:
##
@@ -0,0 +1,40 @@
+/
+ * libs/libc/string/lib_mempcpy.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: mempcpy
+ /
+
+FAR void *mempcpy(FAR void *dest, FAR const void *src, size_t n)
+{
+ return memcpy(dest, src, n) + n;
Review Comment:
Agreed; I think that on some compilers void pointer increment will cause (at
least) a warning. Maybe an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] spi3ex opened a new pull request, #8542: doc:sim Repeated Command "sudo port install"
spi3ex opened a new pull request, #8542: URL: https://github.com/apache/nuttx/pull/8542 The merged code had Repeated Command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: include/sys/socket.h: Add SOCK_CTRL to socket type
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 277e0b941a include/sys/socket.h: Add SOCK_CTRL to socket type 277e0b941a is described below commit 277e0b941aca0f749afaf1db806c9c6033a7247c Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate: Wed Jan 18 14:42:42 2023 +0900 include/sys/socket.h: Add SOCK_CTRL to socket type SOCK_CTRL is added to provide special control over network drivers and daemons. Currently, SOCK_DGRAM and SOCK_STREAM perform this control, but these use socket resources. In the case of usersocket in particular, this is a waste of the device's limited socket resources. --- include/nuttx/net/netconfig.h | 44 ++- include/sys/socket.h | 4 + net/bluetooth/bluetooth_sockif.c | 17 +-- net/can/can_sockif.c | 3 +- net/icmp/icmp_sockif.c | 5 +- net/icmpv6/icmpv6_sockif.c | 5 +- net/ieee802154/ieee802154_sockif.c | 11 +- net/inet/inet_sockif.c | 234 + net/local/local_sockif.c | 27 + net/netlink/netlink_sockif.c | 3 +- net/pkt/pkt_sockif.c | 9 +- 11 files changed, 232 insertions(+), 130 deletions(-) diff --git a/include/nuttx/net/netconfig.h b/include/nuttx/net/netconfig.h index e9f3839408..b2e1b072d2 100644 --- a/include/nuttx/net/netconfig.h +++ b/include/nuttx/net/netconfig.h @@ -104,52 +104,24 @@ #define NET_SOCK_PROTOCOL 0 -/* SOCK_DGRAM is the preferred socket type to use when we just want a - * socket for performing driver ioctls. However, we can't use SOCK_DRAM - * if UDP is disabled. - * - * Pick a socket type (and perhaps protocol) compatible with the currently - * selected address family. +/* SOCK_CTRL is the preferred socket type to use when we just want a + * socket for performing driver ioctls. */ +#define NET_SOCK_TYPE SOCK_CTRL + #if NET_SOCK_FAMILY == AF_INET -# if defined(CONFIG_NET_UDP) -#define NET_SOCK_TYPE SOCK_DGRAM -# elif defined(CONFIG_NET_TCP) -# define NET_SOCK_TYPE SOCK_STREAM -# elif defined(CONFIG_NET_ICMP_SOCKET) -# define NET_SOCK_TYPE SOCK_DGRAM +# if !defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_TCP) && \ + defined(CONFIG_NET_ICMP_SOCKET) # undef NET_SOCK_PROTOCOL # define NET_SOCK_PROTOCOL IPPROTO_ICMP # endif #elif NET_SOCK_FAMILY == AF_INET6 -# if defined(CONFIG_NET_UDP) -#define NET_SOCK_TYPE SOCK_DGRAM -# elif defined(CONFIG_NET_TCP) -# define NET_SOCK_TYPE SOCK_STREAM -# elif defined(CONFIG_NET_ICMPv6_SOCKET) -# define NET_SOCK_TYPE SOCK_DGRAM +# if !defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_TCP) && \ + defined(CONFIG_NET_ICMPv6_SOCKET) # undef NET_SOCK_PROTOCOL # define NET_SOCK_PROTOCOL IPPROTO_ICMP6 # endif -#elif NET_SOCK_FAMILY == AF_LOCAL -# if defined(CONFIG_NET_LOCAL_DGRAM) -#define NET_SOCK_TYPE SOCK_DGRAM -# elif defined(CONFIG_NET_LOCAL_STREAM) -# define NET_SOCK_TYPE SOCK_STREAM -# endif -#elif NET_SOCK_FAMILY == AF_PACKET -# define NET_SOCK_TYPE SOCK_RAW -#elif NET_SOCK_FAMILY == AF_CAN -# define NET_SOCK_TYPE SOCK_RAW -#elif NET_SOCK_FAMILY == AF_IEEE802154 -# define NET_SOCK_TYPE SOCK_DGRAM -#elif NET_SOCK_FAMILY == AF_BLUETOOTH -# define NET_SOCK_TYPE SOCK_RAW -#elif NET_SOCK_FAMILY == AF_NETLINK -# define NET_SOCK_TYPE SOCK_DGRAM -#elif NET_SOCK_FAMILY == AF_RPMSG -# define NET_SOCK_TYPE SOCK_STREAM #endif /* Eliminate dependencies on other header files. This should not harm diff --git a/include/sys/socket.h b/include/sys/socket.h index 2226797ec4..b27df12f68 100644 --- a/include/sys/socket.h +++ b/include/sys/socket.h @@ -92,6 +92,10 @@ * required to read an entire packet with each read * system call. */ +#define SOCK_CTRL 6/* SOCK_CTRL is the preferred socket type to use + * when we just want a socket for performing driver + * ioctls. This definition is not POSIX compliant. + */ #define SOCK_PACKET 10/* Obsolete and should not be used in new programs */ #define SOCK_CLOEXEC 0200 /* Atomically set close-on-exec flag for the new diff --git a/net/bluetooth/bluetooth_sockif.c b/net/bluetooth/bluetooth_sockif.c index 06ab903aac..4fd0fadbd8 100644 --- a/net/bluetooth/bluetooth_sockif.c +++ b/net/bluetooth/bluetooth_sockif.c @@ -162,10 +162,10 @@ static int bluetooth_setup(FAR struct socket *psock) * connection structure, it is unallocated at this point. It will not * actually be initialized until the socket is connected. * - * Only SOCK_RAW is supported + * SOCK_RAW and SOCK_CTRL are
[GitHub] [nuttx] masayuki2009 merged pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
masayuki2009 merged PR #8535: URL: https://github.com/apache/nuttx/pull/8535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
masayuki2009 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432428505 @SPRESENSE Thanks for your confirmation. I will merge this PR. >And I tried to set NETUTILS_DHCPC_BOOTP_FLAGS=0x8000 with https://github.com/apache/nuttx/pull/8535 change, WiFi working propery. OK. Could you please create a new PR that changes spresense:wifi and spresense:wifi_smp to use the above value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432413925 @masayuki2009 san, @xiaoxiang781216 san, I found, `NETUTILS_DHCPC_BOOTP_FLAGS` is affect for my environment. After merging https://github.com/apache/nuttx-apps/pull/1418, renew command will be failed with my AP. And I tried to set `NETUTILS_DHCPC_BOOTP_FLAGS=0x8000` with #8535 change, WiFi working propery. So, since the problem I am experiencing in my environment is completely separate from this fix, I have no problem proceeding with the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432372610 @masayuki2009 san Thank you so much for checking spresense:wifi in your environment. I think my issue is caused by my WiFi environment(Buffalo AP), so not a this patch. Could you proceed to revew this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
masayuki2009 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432334011 @SPRESENSE >I checked it, but ERROR: dhcpc_request() failed was happen. Hmm, I tried this PR locally but could not reproduce the issue. ``` NuttShell (NSH) NuttX-11.0.0 nsh> uname -a NuttX 11.0.0 dc2e49e19c Feb 16 2023 10:29:53 arm spresense nsh> gs2200m raspi3-g wifi-test-24g & gs2200m [5:50] nsh> renew wlan0 nsh> ifconfig wlan0Link encap:Ethernet HWaddr 3c:95:09:00:89:96 at UP inet addr:192.168.10.22 DRaddr:192.168.10.1 Mask:255.255.255.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
xiaoxiang781216 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432332883 I am fine with the change, let's wait @masayuki2009 test and review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (212ef18803 -> 37db965cff)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 212ef18803 arch/pic32mz: Fix typos in PPS register mapping defines add 37db965cff This simulator was tested on ARM MacBook. Updating Simulator for macOS No new revisions were added by this update. Summary of changes: Documentation/guides/simulator.rst | 22 +- arch/sim/src/Makefile | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 merged PR #8530: URL: https://github.com/apache/nuttx/pull/8530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8539: arch/pic32mz: Fix PPS register mapping defines
xiaoxiang781216 merged PR #8539: URL: https://github.com/apache/nuttx/pull/8539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: arch/pic32mz: Fix typos in PPS register mapping defines
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 212ef18803 arch/pic32mz: Fix typos in PPS register mapping defines 212ef18803 is described below commit 212ef18803bb20823b51c68044696dc22b15a3bc Author: Nathan Hartman <59230071+hartmannat...@users.noreply.github.com> AuthorDate: Wed Feb 15 14:13:37 2023 -0500 arch/pic32mz: Fix typos in PPS register mapping defines The PIC32MZ architecture provides a Peripheral Pin Select (PPS) which allows mapping peripherals to different GPIO pins. To map a peripheral output, a value is programmed to a register called RPnxR, where n is the GPIO port (A thru K) and x is the GPIO pin (0 thru 15). The names of these registers in code are PIC32MZ_RPnxR. However, in various definitions, these were mistakenly written as PI32MZ_RPnxR (missing C in PIC32). This prevents using any of the affected mappings. This issue is fixed by repairing the define names. * arch/mips/src/pic32mz/hardware/pic32mzec_pps.h, arch/mips/src/pic32mz/hardware/pic32mzef_pps.h: (): s/PI32MZ/PIC32MZ/g --- arch/mips/src/pic32mz/hardware/pic32mzec_pps.h | 192 arch/mips/src/pic32mz/hardware/pic32mzef_pps.h | 194 - 2 files changed, 193 insertions(+), 193 deletions(-) diff --git a/arch/mips/src/pic32mz/hardware/pic32mzec_pps.h b/arch/mips/src/pic32mz/hardware/pic32mzec_pps.h index 39e7def28c..fcc80c47c0 100644 --- a/arch/mips/src/pic32mz/hardware/pic32mzec_pps.h +++ b/arch/mips/src/pic32mz/hardware/pic32mzec_pps.h @@ -1040,102 +1040,102 @@ * the register address. */ -#define C1OUT_RPB0R 14, PI32MZ_RPB0R -#define C1OUT_RPB7R 14, PI32MZ_RPB7R -#define C1OUT_RPB8R 14, PI32MZ_RPB8R -#define C1OUT_RPB15R 14, PI32MZ_RPB15R -#define C1OUT_RPC3R 14, PI32MZ_RPC3R -#define C1OUT_RPD4R 14, PI32MZ_RPD4R -#define C1OUT_RPD9R 14, PI32MZ_RPD9R -#define C1OUT_RPD12R 14, PI32MZ_RPD12R -#define C1OUT_RPE3R 14, PI32MZ_RPE3R -#define C1OUT_RPE9R 14, PI32MZ_RPE9R -#define C1OUT_RPF8R 14, PI32MZ_RPF8R -#define C1OUT_RPF12R 14, PI32MZ_RPF12R -#define C1OUT_RPG6R 14, PI32MZ_RPG6R - -#define C1TX_RPA14R 15, PI32MZ_RPA14R -#define C1TX_RPB5R 15, PI32MZ_RPB5R -#define C1TX_RPB9R 15, PI32MZ_RPB9R -#define C1TX_RPB10R 15, PI32MZ_RPB10R -#define C1TX_RPC1R 15, PI32MZ_RPC1R -#define C1TX_RPC14R 15, PI32MZ_RPC14R -#define C1TX_RPD2R 15, PI32MZ_RPD2R -#define C1TX_RPD6R 15, PI32MZ_RPD6R -#define C1TX_RPD10R 15, PI32MZ_RPD10R -#define C1TX_RPD14R 15, PI32MZ_RPD14R -#define C1TX_RPF1R 15, PI32MZ_RPF1R -#define C1TX_RPF4R 15, PI32MZ_RPF4R -#define C1TX_RPG1R 15, PI32MZ_RPG1R -#define C1TX_RPG8R 15, PI32MZ_RPG8R - -#define C2OUT_RPA14R 14, PI32MZ_RPA14R -#define C2OUT_RPB5R 14, PI32MZ_RPB5R -#define C2OUT_RPB9R 14, PI32MZ_RPB9R -#define C2OUT_RPB10R 14, PI32MZ_RPB10R -#define C2OUT_RPC1R 14, PI32MZ_RPC1R -#define C2OUT_RPC14R 14, PI32MZ_RPC14R -#define C2OUT_RPD2R 14, PI32MZ_RPD2R -#define C2OUT_RPD6R 14, PI32MZ_RPD6R -#define C2OUT_RPD10R 14, PI32MZ_RPD10R -#define C2OUT_RPD14R 14, PI32MZ_RPD14R -#define C2OUT_RPF1R 14, PI32MZ_RPF1R -#define C2OUT_RPF4R 14, PI32MZ_RPF4R -#define C2OUT_RPG1R 14, PI32MZ_RPG1R -#define C2OUT_RPG8R 14, PI32MZ_RPG8R - -#define C2TX_RPB2R 15, PI32MZ_RPB2R -#define C2TX_RPB6R 15, PI32MZ_RPB6R -#define C2TX_RPB14R 15, PI32MZ_RPB14R -#define C2TX_RPC2R 15, PI32MZ_RPC2R -#define C2TX_RPD0R 15, PI32MZ_RPD0R -#define C2TX_RPD1R 15, PI32MZ_RPD1R -#define C2TX_RPD5R 15, PI32MZ_RPD5R -#define C2TX_RPE8R 15, PI32MZ_RPE8R -#define C2TX_RPF2R 15, PI32MZ_RPF2R -#define C2TX_RPF3R 15, PI32MZ_RPF3R -#define C2TX_RPF13R 15, PI32MZ_RPF13R -#define C2TX_RPG9R 15, PI32MZ_RPG9R - -#define OC1_RPB2R
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432330814 @xiaoxiang781216 san, @masayuki2009 san The spresense:wifi behavior is same between with this patch and not. In AP mode, 'ERROR: dhcpc_request() failed' error is happen as follows, and in Sta. mode is working fine. I think, this patch is not affect to this issue. So, we can continue to reviewing. ``` NuttShell (NSH) NuttX-12.0.0 nsh> gs2200m MySSID MyPassWD & gs2200m [6:50] nsh> nsh> ifconfig wlan0 Link encap:Ethernet HWaddr 3c:a0:67:59:35:4f at UP inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0 nsh> nsh> renew wlan0 ERROR: dhcpc_request() failed nsh> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (6fb08b8b03 -> 7c90fbd7c2)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6fb08b8b03 Fix typos: s/UARt/UART/ add 7c90fbd7c2 arch/pic32mz: Fix PPS mappings for RPE5R register No new revisions were added by this update. Summary of changes: arch/mips/src/pic32mz/hardware/pic32mzec_pps.h | 4 ++-- arch/mips/src/pic32mz/hardware/pic32mzef_pps.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8540: arch/pic32mz: Fix PPS mappings for RPE5R register
xiaoxiang781216 merged PR #8540: URL: https://github.com/apache/nuttx/pull/8540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8541: Fix typos: s/UARt/UART/
xiaoxiang781216 merged PR #8541: URL: https://github.com/apache/nuttx/pull/8541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: Fix typos: s/UARt/UART/
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6fb08b8b03 Fix typos: s/UARt/UART/ 6fb08b8b03 is described below commit 6fb08b8b03fc81d4885cedbb2f937b73fa4ad89d Author: Nathan Hartman <59230071+hartmannat...@users.noreply.github.com> AuthorDate: Wed Feb 15 17:58:07 2023 -0500 Fix typos: s/UARt/UART/ --- arch/mips/src/pic32mz/pic32mz_lowconsole.c | 2 +- arch/sparc/src/s698pm/s698pm-lowconsole.c | 2 +- boards/arm/sama5/sama5d2-xult/README.txt | 2 +- boards/arm/sama5/sama5d4-ek/README.txt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/mips/src/pic32mz/pic32mz_lowconsole.c b/arch/mips/src/pic32mz/pic32mz_lowconsole.c index c4036e3c0a..6ca3d59026 100644 --- a/arch/mips/src/pic32mz/pic32mz_lowconsole.c +++ b/arch/mips/src/pic32mz/pic32mz_lowconsole.c @@ -317,7 +317,7 @@ void pic32mz_consoleinit(void) /* Setup up pin selection registers for all configured UARTs. The board.h * header file must provide these definitions to select the correct pin - * configuration for each enabled UARt. + * configuration for each enabled UART. */ #ifdef CONFIG_PIC32MZ_UART1 diff --git a/arch/sparc/src/s698pm/s698pm-lowconsole.c b/arch/sparc/src/s698pm/s698pm-lowconsole.c index 3354db3739..a0b1a08729 100644 --- a/arch/sparc/src/s698pm/s698pm-lowconsole.c +++ b/arch/sparc/src/s698pm/s698pm-lowconsole.c @@ -212,7 +212,7 @@ void s698pm_consoleinit(void) /* Setup up pin selection registers for all configured UARTs. The board.h * header file must provide these definitions to select the correct pin - * configuration for each enabled UARt. + * configuration for each enabled UART. */ gpreg = getreg32(S698PM_GPREG_BASE); diff --git a/boards/arm/sama5/sama5d2-xult/README.txt b/boards/arm/sama5/sama5d2-xult/README.txt index 4e9bf5a560..8606869d8e 100644 --- a/boards/arm/sama5/sama5d2-xult/README.txt +++ b/boards/arm/sama5/sama5d2-xult/README.txt @@ -72,7 +72,7 @@ REVISIT: Unverified, cloned text from the SAMA5D4-EK README.txt NuttX may be executed from SDRAM. But this case means that the NuttX binary must reside on some other media (typically NAND FLASH, Serial - FLASH) or transferred over some interface (perhaps a UARt or even a + FLASH) or transferred over some interface (perhaps a UART or even a TFTP server). In these cases, an intermediate bootloader such as U-Boot or Barebox must be used to configure the SAMA5D2 clocks and SDRAM and then to copy the NuttX binary into SDRAM. diff --git a/boards/arm/sama5/sama5d4-ek/README.txt b/boards/arm/sama5/sama5d4-ek/README.txt index 7cd86d0844..f7e385e0e2 100644 --- a/boards/arm/sama5/sama5d4-ek/README.txt +++ b/boards/arm/sama5/sama5d4-ek/README.txt @@ -492,7 +492,7 @@ Running NuttX from SDRAM NuttX may be executed from SDRAM. But this case means that the NuttX binary must reside on some other media (typically NAND FLASH, Serial - FLASH) or transferred over some interface (perhaps a UARt or even a + FLASH) or transferred over some interface (perhaps a UART or even a TFTP server). In these cases, an intermediate bootloader such as U-Boot or Barebox must be used to configure the SAMA5D4 clocks and SDRAM and then to copy the NuttX binary into SDRAM.
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432308523 @masayuki2009 san > @SPRESENSE > > > Is my operation wrong? > > Please run the renew command in the foreground. It will take a few seconds to obtain a new address. I checked it, but `ERROR: dhcpc_request() failed` was happen. ``` NuttShell (NSH) NuttX-12.0.0 nsh> gs2200m MySSID MyPassWD & gs2200m [6:50] nsh> nsh> ifconfig wlan0 Link encap:Ethernet HWaddr 3c:a0:67:59:35:4f at UP inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0 nsh> nsh> renew wlan0 ERROR: dhcpc_request() failed nsh> nsh> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1432305467 @xiaoxiang781216 san > @SPRESENSE could you document the difference between this patch and reverted one? In #8370, net/inet/inet_sockif.c's inet_ioctl and inet_close, the handling of the added SOCK_CTRL when requested was missing. This change we have improved this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on pull request #1566: testing/cmocka: update cmocka version and add patch
acassis commented on PR #1566: URL: https://github.com/apache/nuttx-apps/pull/1566#issuecomment-1432277477 @yintao707 maybe these modifications could be submitted to mainline of the cmocka project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on pull request #1567: system: Change DRIVER_NOTExxx to DRIVERS_NOTExxx
acassis commented on PR #1567: URL: https://github.com/apache/nuttx-apps/pull/1567#issuecomment-1432276253 Is it breaking because the board configs are not up to date yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 6920fffb00f7206c8d7344a596a455c3913470b0
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 35f5a53f Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff
docs: 6920fffb00f7206c8d7344a596a455c3913470b0
35f5a53f is described below
commit 35f5a53f4cc4fdc5619379c1e1b61484045d94b7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Thu Feb 16 00:12:29 2023 +
Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs:
6920fffb00f7206c8d7344a596a455c3913470b0
---
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/12.0.0/index.html | 2 +-
content/docs/12.0.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
17 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 229f6869..769f1df0 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 15 February 23 at 00:10
+Last Updated: 16 February 23 at 00:10
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index 2f020209..60c926db 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index 58777867..694af582 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -147,7 +147,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 15 February 23 at 00:11
+Last Updated: 16 February 23 at 00:10
Table of
Contents
diff --git a/content/docs/10.0.1/searchindex.js
b/content/docs/10.0.1/searchindex.js
index 86799939..60c926db 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
[GitHub] [nuttx-apps] acassis opened a new pull request, #1568: netinit: Improve WiFi configuration
acassis opened a new pull request, #1568: URL: https://github.com/apache/nuttx-apps/pull/1568 ## Summary The current WiFi configuration expects user to look at symbols in the wireless headers to configure it. This patch will improve it. Notice that even those symbols that are bitfields are not allowed to have more than 1 bit set at time. ## Impact Make it easier to users to configure the WiFi ## Testing ESP32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan opened a new pull request, #8541: Fix typos: s/UARt/UART/
hartmannathan opened a new pull request, #8541: URL: https://github.com/apache/nuttx/pull/8541 ## Summary Fix four copy-paste instances of a typo in comments and README files. ## Impact Correctness and greppability. ## Testing No functional change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan opened a new pull request, #8540: arch/pic32mz: Fix PPS mappings for RPE5R register
hartmannathan opened a new pull request, #8540: URL: https://github.com/apache/nuttx/pull/8540 ## Summary On PIC32MZ, the defines for Peripheral Pin Select (PPS) register RPE5R were called RPE4R inadvertently; however, mappings elsewhere in the file used the correct name of RPE5R, so the build would break if anyone attempted to map those peripherals to GPIO pin E5. This issue is now fixed. ## Impact It is possible to map peripheral output pins to GPIO pin E5 now. ## Testing Build is no longer broken on this issue in custom board port in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] centurysys commented on issue #8537: [RFC] Nim language support
centurysys commented on issue #8537: URL: https://github.com/apache/nuttx/issues/8537#issuecomment-1432084878 @xiaoxiang781216 Thank you for reply! I was thinking that I would have to do some work on Toolchain.defs, etc like Zig/Rust does. I remembered that Nim has a VM called nimscript that can be run at compile time(config.nims). I will investigate how to parse .config with nimscript and change the configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on issue #8538: Kconfig:249: warning: the 'modules' option is not supported
pkarashchenko commented on issue #8538: URL: https://github.com/apache/nuttx/issues/8538#issuecomment-1431952795 I use `kconfig-frontend` installed with `apt` and not one from `tools` repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #8460: Fix/can2 stm32l (WIP)
davids5 commented on code in PR #8460: URL: https://github.com/apache/nuttx/pull/8460#discussion_r1107623234 ## arch/arm/src/stm32l4/hardware/stm32l4_can.h: ## @@ -176,6 +179,60 @@ # define STM32L4_CAN1_FIR(b,i) (STM32L4_CAN1_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) #endif +#if defined(CONFIG_STM32L4_CAN2) +# define STM32L4_CAN2_MCR (STM32L4_CAN2_BASE+STM32L4_CAN_MCR_OFFSET) +# define STM32L4_CAN2_MSR (STM32L4_CAN2_BASE+STM32L4_CAN_MSR_OFFSET) +# define STM32L4_CAN2_TSR (STM32L4_CAN2_BASE+STM32L4_CAN_TSR_OFFSET) +# define STM32L4_CAN2_RF0R (STM32L4_CAN2_BASE+STM32L4_CAN_RF0R_OFFSET) +# define STM32L4_CAN2_RF1R (STM32L4_CAN2_BASE+STM32L4_CAN_RF1R_OFFSET) +# define STM32L4_CAN2_IER (STM32L4_CAN2_BASE+STM32L4_CAN_IER_OFFSET) +# define STM32L4_CAN2_ESR (STM32L4_CAN2_BASE+STM32L4_CAN_ESR_OFFSET) +# define STM32L4_CAN2_BTR (STM32L4_CAN2_BASE+STM32L4_CAN_BTR_OFFSET) + +# define STM32L4_CAN2_TIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TIR_OFFSET(m)) +# define STM32L4_CAN2_TI0R (STM32L4_CAN2_BASE+STM32L4_CAN_TI0R_OFFSET) +# define STM32L4_CAN2_TI1R (STM32L4_CAN2_BASE+STM32L4_CAN_TI1R_OFFSET) +# define STM32L4_CAN2_TI2R (STM32L4_CAN2_BASE+STM32L4_CAN_TI2R_OFFSET) + +# define STM32L4_CAN2_TDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDTR_OFFSET(m)) +# define STM32L4_CAN2_TDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT0R_OFFSET) +# define STM32L4_CAN2_TDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT1R_OFFSET) +# define STM32L4_CAN2_TDT2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT2R_OFFSET) + +# define STM32L4_CAN2_TDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDLR_OFFSET(m)) +# define STM32L4_CAN2_TDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL0R_OFFSET) +# define STM32L4_CAN2_TDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL1R_OFFSET) +# define STM32L4_CAN2_TDL2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL2R_OFFSET) + +# define STM32L4_CAN2_TDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDHR_OFFSET(m)) +# define STM32L4_CAN2_TDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH0R_OFFSET) +# define STM32L4_CAN2_TDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH1R_OFFSET) +# define STM32L4_CAN2_TDH2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH2R_OFFSET) + +# define STM32L4_CAN2_RIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RIR_OFFSET(m)) +# define STM32L4_CAN2_RI0R (STM32L4_CAN2_BASE+STM32L4_CAN_RI0R_OFFSET) +# define STM32L4_CAN2_RI1R (STM32L4_CAN2_BASE+STM32L4_CAN_RI1R_OFFSET) + +# define STM32L4_CAN2_RDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDTR_OFFSET(m)) +# define STM32L4_CAN2_RDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT0R_OFFSET) +# define STM32L4_CAN2_RDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT1R_OFFSET) + +# define STM32L4_CAN2_RDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDLR_OFFSET(m)) +# define STM32L4_CAN2_RDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL0R_OFFSET) +# define STM32L4_CAN2_RDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL1R_OFFSET) + +# define STM32L4_CAN2_RDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDHR_OFFSET(m)) +# define STM32L4_CAN2_RDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH0R_OFFSET) +# define STM32L4_CAN2_RDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH1R_OFFSET) + +# define STM32L4_CAN2_FMR (STM32L4_CAN2_BASE+STM32L4_CAN_FMR_OFFSET) +# define STM32L4_CAN2_FM1R (STM32L4_CAN2_BASE+STM32L4_CAN_FM1R_OFFSET) +# define STM32L4_CAN2_FS1R (STM32L4_CAN2_BASE+STM32L4_CAN_FS1R_OFFSET) +# define STM32L4_CAN2_FFA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FFA1R_OFFSET) +# define STM32L4_CAN2_FA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FA1R_OFFSET) +# define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32_CAN_FIR_OFFSET(b,i)) Review Comment: for matting is off too should be X + Y to X+Y -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan opened a new pull request, #8539: arch/pic32mz: Fix typos in PPS register mapping defines
hartmannathan opened a new pull request, #8539: URL: https://github.com/apache/nuttx/pull/8539 ## Summary On PIC32MZ architecture, fix typos in defined symbols that prevented mapping certain peripherals to certain GPIO pins. ## Impact Possible to use those PPS (Peripheral Pin Select) mappings now. ## Testing nxstyle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8460: Fix/can2 stm32l (WIP)
gustavonihei commented on code in PR #8460: URL: https://github.com/apache/nuttx/pull/8460#discussion_r1107543366 ## arch/arm/src/stm32l4/hardware/stm32l4_can.h: ## @@ -176,6 +179,60 @@ # define STM32L4_CAN1_FIR(b,i) (STM32L4_CAN1_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) #endif +#if defined(CONFIG_STM32L4_CAN2) +# define STM32L4_CAN2_MCR (STM32L4_CAN2_BASE+STM32L4_CAN_MCR_OFFSET) +# define STM32L4_CAN2_MSR (STM32L4_CAN2_BASE+STM32L4_CAN_MSR_OFFSET) +# define STM32L4_CAN2_TSR (STM32L4_CAN2_BASE+STM32L4_CAN_TSR_OFFSET) +# define STM32L4_CAN2_RF0R (STM32L4_CAN2_BASE+STM32L4_CAN_RF0R_OFFSET) +# define STM32L4_CAN2_RF1R (STM32L4_CAN2_BASE+STM32L4_CAN_RF1R_OFFSET) +# define STM32L4_CAN2_IER (STM32L4_CAN2_BASE+STM32L4_CAN_IER_OFFSET) +# define STM32L4_CAN2_ESR (STM32L4_CAN2_BASE+STM32L4_CAN_ESR_OFFSET) +# define STM32L4_CAN2_BTR (STM32L4_CAN2_BASE+STM32L4_CAN_BTR_OFFSET) + +# define STM32L4_CAN2_TIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TIR_OFFSET(m)) +# define STM32L4_CAN2_TI0R (STM32L4_CAN2_BASE+STM32L4_CAN_TI0R_OFFSET) +# define STM32L4_CAN2_TI1R (STM32L4_CAN2_BASE+STM32L4_CAN_TI1R_OFFSET) +# define STM32L4_CAN2_TI2R (STM32L4_CAN2_BASE+STM32L4_CAN_TI2R_OFFSET) + +# define STM32L4_CAN2_TDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDTR_OFFSET(m)) +# define STM32L4_CAN2_TDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT0R_OFFSET) +# define STM32L4_CAN2_TDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT1R_OFFSET) +# define STM32L4_CAN2_TDT2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT2R_OFFSET) + +# define STM32L4_CAN2_TDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDLR_OFFSET(m)) +# define STM32L4_CAN2_TDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL0R_OFFSET) +# define STM32L4_CAN2_TDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL1R_OFFSET) +# define STM32L4_CAN2_TDL2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL2R_OFFSET) + +# define STM32L4_CAN2_TDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDHR_OFFSET(m)) +# define STM32L4_CAN2_TDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH0R_OFFSET) +# define STM32L4_CAN2_TDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH1R_OFFSET) +# define STM32L4_CAN2_TDH2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH2R_OFFSET) + +# define STM32L4_CAN2_RIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RIR_OFFSET(m)) +# define STM32L4_CAN2_RI0R (STM32L4_CAN2_BASE+STM32L4_CAN_RI0R_OFFSET) +# define STM32L4_CAN2_RI1R (STM32L4_CAN2_BASE+STM32L4_CAN_RI1R_OFFSET) + +# define STM32L4_CAN2_RDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDTR_OFFSET(m)) +# define STM32L4_CAN2_RDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT0R_OFFSET) +# define STM32L4_CAN2_RDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT1R_OFFSET) + +# define STM32L4_CAN2_RDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDLR_OFFSET(m)) +# define STM32L4_CAN2_RDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL0R_OFFSET) +# define STM32L4_CAN2_RDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL1R_OFFSET) + +# define STM32L4_CAN2_RDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDHR_OFFSET(m)) +# define STM32L4_CAN2_RDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH0R_OFFSET) +# define STM32L4_CAN2_RDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH1R_OFFSET) + +# define STM32L4_CAN2_FMR (STM32L4_CAN2_BASE+STM32L4_CAN_FMR_OFFSET) +# define STM32L4_CAN2_FM1R (STM32L4_CAN2_BASE+STM32L4_CAN_FM1R_OFFSET) +# define STM32L4_CAN2_FS1R (STM32L4_CAN2_BASE+STM32L4_CAN_FS1R_OFFSET) +# define STM32L4_CAN2_FFA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FFA1R_OFFSET) +# define STM32L4_CAN2_FA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FA1R_OFFSET) +# define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32_CAN_FIR_OFFSET(b,i)) Review Comment: ```suggestion # define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32L4_CAN_FIR_OFFSET(b,i) ``` I believe the macro identifier might be wrong. ## arch/arm/src/stm32l4/hardware/stm32l4_can.h: ## @@ -176,6 +179,60 @@ # define STM32L4_CAN1_FIR(b,i) (STM32L4_CAN1_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) #endif +#if defined(CONFIG_STM32L4_CAN2) +# define STM32L4_CAN2_MCR (STM32L4_CAN2_BASE+STM32L4_CAN_MCR_OFFSET) +# define STM32L4_CAN2_MSR (STM32L4_CAN2_BASE+STM32L4_CAN_MSR_OFFSET) +# define STM32L4_CAN2_TSR (STM32L4_CAN2_BASE+STM32L4_CAN_TSR_OFFSET) +# define STM32L4_CAN2_RF0R (STM32L4_CAN2_BASE+STM32L4_CAN_RF0R_OFFSET) +# define STM32L4_CAN2_RF1R (STM32L4_CAN2_BASE+STM32L4_CAN_RF1R_OFFSET) +# define STM32L4_CAN2_IER (STM32L4_CAN2_BASE+STM32L4_CAN_IER_OFFSET) +# define STM32L4_CAN2_ESR (STM32L4_CAN2_BASE+STM32L4_CAN_ESR_OFFSET) +# define STM32L4_CAN2_BTR (STM32L4_CAN2_BASE+STM32L4_CAN_BTR_OFFSET) + +# define STM32L4_CAN2_TIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TIR_OFFSET(m)) +# define STM32L4_CAN2_TI0R
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8460: Fix/can2 stm32l (WIP)
gustavonihei commented on code in PR #8460: URL: https://github.com/apache/nuttx/pull/8460#discussion_r1107543366 ## arch/arm/src/stm32l4/hardware/stm32l4_can.h: ## @@ -176,6 +179,60 @@ # define STM32L4_CAN1_FIR(b,i) (STM32L4_CAN1_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) #endif +#if defined(CONFIG_STM32L4_CAN2) +# define STM32L4_CAN2_MCR (STM32L4_CAN2_BASE+STM32L4_CAN_MCR_OFFSET) +# define STM32L4_CAN2_MSR (STM32L4_CAN2_BASE+STM32L4_CAN_MSR_OFFSET) +# define STM32L4_CAN2_TSR (STM32L4_CAN2_BASE+STM32L4_CAN_TSR_OFFSET) +# define STM32L4_CAN2_RF0R (STM32L4_CAN2_BASE+STM32L4_CAN_RF0R_OFFSET) +# define STM32L4_CAN2_RF1R (STM32L4_CAN2_BASE+STM32L4_CAN_RF1R_OFFSET) +# define STM32L4_CAN2_IER (STM32L4_CAN2_BASE+STM32L4_CAN_IER_OFFSET) +# define STM32L4_CAN2_ESR (STM32L4_CAN2_BASE+STM32L4_CAN_ESR_OFFSET) +# define STM32L4_CAN2_BTR (STM32L4_CAN2_BASE+STM32L4_CAN_BTR_OFFSET) + +# define STM32L4_CAN2_TIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TIR_OFFSET(m)) +# define STM32L4_CAN2_TI0R (STM32L4_CAN2_BASE+STM32L4_CAN_TI0R_OFFSET) +# define STM32L4_CAN2_TI1R (STM32L4_CAN2_BASE+STM32L4_CAN_TI1R_OFFSET) +# define STM32L4_CAN2_TI2R (STM32L4_CAN2_BASE+STM32L4_CAN_TI2R_OFFSET) + +# define STM32L4_CAN2_TDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDTR_OFFSET(m)) +# define STM32L4_CAN2_TDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT0R_OFFSET) +# define STM32L4_CAN2_TDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT1R_OFFSET) +# define STM32L4_CAN2_TDT2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT2R_OFFSET) + +# define STM32L4_CAN2_TDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDLR_OFFSET(m)) +# define STM32L4_CAN2_TDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL0R_OFFSET) +# define STM32L4_CAN2_TDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL1R_OFFSET) +# define STM32L4_CAN2_TDL2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL2R_OFFSET) + +# define STM32L4_CAN2_TDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDHR_OFFSET(m)) +# define STM32L4_CAN2_TDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH0R_OFFSET) +# define STM32L4_CAN2_TDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH1R_OFFSET) +# define STM32L4_CAN2_TDH2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH2R_OFFSET) + +# define STM32L4_CAN2_RIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RIR_OFFSET(m)) +# define STM32L4_CAN2_RI0R (STM32L4_CAN2_BASE+STM32L4_CAN_RI0R_OFFSET) +# define STM32L4_CAN2_RI1R (STM32L4_CAN2_BASE+STM32L4_CAN_RI1R_OFFSET) + +# define STM32L4_CAN2_RDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDTR_OFFSET(m)) +# define STM32L4_CAN2_RDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT0R_OFFSET) +# define STM32L4_CAN2_RDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT1R_OFFSET) + +# define STM32L4_CAN2_RDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDLR_OFFSET(m)) +# define STM32L4_CAN2_RDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL0R_OFFSET) +# define STM32L4_CAN2_RDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL1R_OFFSET) + +# define STM32L4_CAN2_RDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDHR_OFFSET(m)) +# define STM32L4_CAN2_RDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH0R_OFFSET) +# define STM32L4_CAN2_RDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH1R_OFFSET) + +# define STM32L4_CAN2_FMR (STM32L4_CAN2_BASE+STM32L4_CAN_FMR_OFFSET) +# define STM32L4_CAN2_FM1R (STM32L4_CAN2_BASE+STM32L4_CAN_FM1R_OFFSET) +# define STM32L4_CAN2_FS1R (STM32L4_CAN2_BASE+STM32L4_CAN_FS1R_OFFSET) +# define STM32L4_CAN2_FFA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FFA1R_OFFSET) +# define STM32L4_CAN2_FA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FA1R_OFFSET) +# define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32_CAN_FIR_OFFSET(b,i)) Review Comment: ```suggestion # define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32L4_CAN_FIR_OFFSET((b),(i))) ``` I believe the macro identifier might be wrong. And macro arguments should be wrapped around parentheses to avoid operator precedence issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8460: Fix/can2 stm32l (WIP)
gustavonihei commented on code in PR #8460: URL: https://github.com/apache/nuttx/pull/8460#discussion_r1107543366 ## arch/arm/src/stm32l4/hardware/stm32l4_can.h: ## @@ -176,6 +179,60 @@ # define STM32L4_CAN1_FIR(b,i) (STM32L4_CAN1_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) #endif +#if defined(CONFIG_STM32L4_CAN2) +# define STM32L4_CAN2_MCR (STM32L4_CAN2_BASE+STM32L4_CAN_MCR_OFFSET) +# define STM32L4_CAN2_MSR (STM32L4_CAN2_BASE+STM32L4_CAN_MSR_OFFSET) +# define STM32L4_CAN2_TSR (STM32L4_CAN2_BASE+STM32L4_CAN_TSR_OFFSET) +# define STM32L4_CAN2_RF0R (STM32L4_CAN2_BASE+STM32L4_CAN_RF0R_OFFSET) +# define STM32L4_CAN2_RF1R (STM32L4_CAN2_BASE+STM32L4_CAN_RF1R_OFFSET) +# define STM32L4_CAN2_IER (STM32L4_CAN2_BASE+STM32L4_CAN_IER_OFFSET) +# define STM32L4_CAN2_ESR (STM32L4_CAN2_BASE+STM32L4_CAN_ESR_OFFSET) +# define STM32L4_CAN2_BTR (STM32L4_CAN2_BASE+STM32L4_CAN_BTR_OFFSET) + +# define STM32L4_CAN2_TIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TIR_OFFSET(m)) +# define STM32L4_CAN2_TI0R (STM32L4_CAN2_BASE+STM32L4_CAN_TI0R_OFFSET) +# define STM32L4_CAN2_TI1R (STM32L4_CAN2_BASE+STM32L4_CAN_TI1R_OFFSET) +# define STM32L4_CAN2_TI2R (STM32L4_CAN2_BASE+STM32L4_CAN_TI2R_OFFSET) + +# define STM32L4_CAN2_TDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDTR_OFFSET(m)) +# define STM32L4_CAN2_TDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT0R_OFFSET) +# define STM32L4_CAN2_TDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT1R_OFFSET) +# define STM32L4_CAN2_TDT2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDT2R_OFFSET) + +# define STM32L4_CAN2_TDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDLR_OFFSET(m)) +# define STM32L4_CAN2_TDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL0R_OFFSET) +# define STM32L4_CAN2_TDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL1R_OFFSET) +# define STM32L4_CAN2_TDL2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDL2R_OFFSET) + +# define STM32L4_CAN2_TDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_TDHR_OFFSET(m)) +# define STM32L4_CAN2_TDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH0R_OFFSET) +# define STM32L4_CAN2_TDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH1R_OFFSET) +# define STM32L4_CAN2_TDH2R (STM32L4_CAN2_BASE+STM32L4_CAN_TDH2R_OFFSET) + +# define STM32L4_CAN2_RIR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RIR_OFFSET(m)) +# define STM32L4_CAN2_RI0R (STM32L4_CAN2_BASE+STM32L4_CAN_RI0R_OFFSET) +# define STM32L4_CAN2_RI1R (STM32L4_CAN2_BASE+STM32L4_CAN_RI1R_OFFSET) + +# define STM32L4_CAN2_RDTR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDTR_OFFSET(m)) +# define STM32L4_CAN2_RDT0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT0R_OFFSET) +# define STM32L4_CAN2_RDT1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDT1R_OFFSET) + +# define STM32L4_CAN2_RDLR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDLR_OFFSET(m)) +# define STM32L4_CAN2_RDL0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL0R_OFFSET) +# define STM32L4_CAN2_RDL1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDL1R_OFFSET) + +# define STM32L4_CAN2_RDHR(m) (STM32L4_CAN2_BASE+STM32L4_CAN_RDHR_OFFSET(m)) +# define STM32L4_CAN2_RDH0R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH0R_OFFSET) +# define STM32L4_CAN2_RDH1R (STM32L4_CAN2_BASE+STM32L4_CAN_RDH1R_OFFSET) + +# define STM32L4_CAN2_FMR (STM32L4_CAN2_BASE+STM32L4_CAN_FMR_OFFSET) +# define STM32L4_CAN2_FM1R (STM32L4_CAN2_BASE+STM32L4_CAN_FM1R_OFFSET) +# define STM32L4_CAN2_FS1R (STM32L4_CAN2_BASE+STM32L4_CAN_FS1R_OFFSET) +# define STM32L4_CAN2_FFA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FFA1R_OFFSET) +# define STM32L4_CAN2_FA1R (STM32L4_CAN2_BASE+STM32L4_CAN_FA1R_OFFSET) +# define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32_CAN_FIR_OFFSET(b,i)) Review Comment: ```suggestion # define STM32L4_CAN2_FIR(b,i) (STM32L4_CAN2_BASE+STM32L4_CAN_FIR_OFFSET(b,i)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #8538: Kconfig:249: warning: the 'modules' option is not supported
xiaoxiang781216 commented on issue #8538: URL: https://github.com/apache/nuttx/issues/8538#issuecomment-1431785522 it's a known kconfiglib issue: https://github.com/ulfalizer/Kconfiglib/pull/119, but kconfig-frontend doesn't report this warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko opened a new issue, #8538: Kconfig:249: warning: the 'modules' option is not supporte
pkarashchenko opened a new issue, #8538: URL: https://github.com/apache/nuttx/issues/8538 I'm using Ubuntu:focal as a host system and after recent sync with mainline I have next behavior on attempt to configure the build: ``` make menuconfig CP: arch/dummy/Kconfig to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/arch/dummy/dummy_kconfig CP: boards/dummy/Kconfig to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/boards/dummy/dummy_kconfig LN: platform/board to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/apps/platform/dummy LN: include/arch to arch/arm/include LN: include/arch/board to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/boards/arm/samv7/same70-qmtech/include LN: drivers/platform to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/drivers/dummy LN: include/arch/chip to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/arch/arm/include/samv7 LN: arch/arm/src/chip to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/arch/arm/src/samv7 LN: arch/arm/src/board to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/boards/arm/samv7/same70-qmtech/../common LN: arch/arm/src/board/board to /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/boards/arm/samv7/same70-qmtech/src Kconfig:249: warning: the 'modules' option is not supported. Let me know if this is a problem for you, as it wouldn't be that hard to implement. Note that modules are supported -- Kconfiglib just assumes the symbol name MODULES, like older versions of the C implementation did when 'option modules' wasn't used. warning: ESP32C6_DEVKIT_RUN_IRAM (defined at boards/risc-v/esp32c6/esp32c6-devkit/Kconfig:8) has 'help' but empty help text Loaded configuration '.config' No changes to save (for '.config') ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6920fffb00 limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN] 6920fffb00 is described below commit 6920fffb00f7206c8d7344a596a455c3913470b0 Author: Xiang Xiao AuthorDate: Mon Feb 13 16:33:44 2023 +0800 limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN] correct SIZE_MAX and SSIZE_MAX/SSIZE_MIN definition Signed-off-by: Xiang Xiao --- include/limits.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/limits.h b/include/limits.h index 98b7dc724e..b4502fa8bd 100644 --- a/include/limits.h +++ b/include/limits.h @@ -136,11 +136,11 @@ #else /* CONFIG_SMALL_MEMORY */ -#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */ +#define _POSIX_SIZE_MAX ULONG_MAX #define _POSIX_SIZE_MIN 0 -#define _POSIX_SSIZE_MAX 2147483647L /* See sys/types.h */ -#define _POSIX_SSIZE_MIN -2147483648L +#define _POSIX_SSIZE_MAX LONG_MAX +#define _POSIX_SSIZE_MIN LONG_MIN #endif /* CONFIG_SMALL_MEMORY */
[GitHub] [nuttx] jerpelea merged pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
jerpelea merged PR #8523: URL: https://github.com/apache/nuttx/pull/8523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #8532: MSG_PEEK support
xiaoxiang781216 commented on issue #8532: URL: https://github.com/apache/nuttx/issues/8532#issuecomment-1431559059 Look it's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1355: nshlib: Reuse nsh_session logic in nsh_telnetmain
xiaoxiang781216 commented on PR #1355: URL: https://github.com/apache/nuttx-apps/pull/1355#issuecomment-1431556414 Ok, I will take a look in the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #8533: Assertion fails while freeing IOBs.
xiaoxiang781216 commented on issue #8533: URL: https://github.com/apache/nuttx/issues/8533#issuecomment-1431547337 @anchao could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8524: usbdev/adb: add adb usbclass_unbind function
xiaoxiang781216 commented on PR #8524: URL: https://github.com/apache/nuttx/pull/8524#issuecomment-1431541021 We will provide USB host/device simulator soon. It depends on one latest Linux kernel feature: https://github.com/xairy/raw-gadget. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #8537: [RFC] Nim language support
xiaoxiang781216 commented on issue #8537: URL: https://github.com/apache/nuttx/issues/8537#issuecomment-1431535645 maybe you can follow how Zig/Rust integrate into NuttX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8531: Refine the drivers/note Kconfig
xiaoxiang781216 commented on PR #8531: URL: https://github.com/apache/nuttx/pull/8531#issuecomment-1431523674 > @xiaoxiang781216 I didn't get the complete idea, why it is needed to move this driver from drivers/note/ All note drivers are still in drivers/note, but SCHED_INSTRUMENTATION move back to sched/Kconfig(the initial place) which is moved to drivers/Kconfig by: https://github.com/apache/nuttx/pull/7986/commits/56c9c1bdb23b2f343f96202d6cf1f82156e3d455 > just because some boards could have their our implementation. Could just keep the generic implementation inside drivers/note and use the board specific like a CUSTOM driver? Yes, that's the goal of this patch, user could enable SCHED_INSTRUMENTATION, but disable DRIVERS_NOTE, and then implement all sched_note_xxx callback in a CUSTOM driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8523: limits.h: Map _POSIX_[S]SIZE_M[AX|IN] to [U]LONG_M[AX|IN]
xiaoxiang781216 commented on code in PR #8523: URL: https://github.com/apache/nuttx/pull/8523#discussion_r1107227268 ## include/limits.h: ## @@ -136,11 +136,11 @@ #else /* CONFIG_SMALL_MEMORY */ -#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */ +#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */ #define _POSIX_SIZE_MIN 0 -#define _POSIX_SSIZE_MAX 2147483647L /* See sys/types.h */ -#define _POSIX_SSIZE_MIN -2147483648L +#define _POSIX_SSIZE_MAX LONG_MAX /* See sys/types.h */ Review Comment: Done. ## include/limits.h: ## @@ -136,11 +136,11 @@ #else /* CONFIG_SMALL_MEMORY */ -#define _POSIX_SIZE_MAX 4294967295UL /* See sys/types.h */ +#define _POSIX_SIZE_MAX ULONG_MAX /* See sys/types.h */ Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1431483903 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1107119143 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: This Change is done. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1431334901 > @spi3ex this documentation that you are submitting is very important, please let me know if you can build NuttX on ARM powered computer. If you can please improve the Mac documentation install process (to include details for Intel and ARM processors) Please Check this Article https://www.linkedin.com/pulse/running-lvgl-nuttx-simulator-macos-jackson-r/?trackingId=qqFi2lG2RoGik9eedbhAqQ%3D%3D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
acassis commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1107095214 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: @spi3ex basically what @xiaoxiang781216 is saying is: #if BLABLABLA X += A + B #else X += B #endif So, you can simplify it to: X += B #if BLABLABLA X += A #endif If the "-L/opt/X11/lib" and "-lX11 -lXext" order doesn't care, this suggestion should work fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
acassis commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1107095214 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: @spi3ex basically what @xiaoxiang781216 is saying is: #if BLABLABLA X += A + B #else X += B #endif So, you can simplify it to: X = B #if BLABLABLA X += A #endif If the "-L/opt/X11/lib" and "-lX11 -lXext" order doesn't care, this suggestion should work fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
acassis commented on PR #8530: URL: https://github.com/apache/nuttx/pull/8530#issuecomment-1431326930 @spi3ex this documentation that you are submitting is very important, please let me know if you can build NuttX on ARM powered computer. If you can please improve the Mac documentation install process (to include details for Intel and ARM processors) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] spi3ex commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
spi3ex commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1107068185 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: If you have another ideas let me know, I had a hard time making the builds work on macOS and only this method looks the most efficient way ( works on Intel and Apple Silicon macs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
xiaoxiang781216 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1431291864 @SPRESENSE could you document the difference between this patch and reverted one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] centurysys opened a new issue, #8537: [RFC] Nim language support
centurysys opened a new issue, #8537:
URL: https://github.com/apache/nuttx/issues/8537
I started porting Nim language to NuttX, a simple web server is up and
running.
https://github.com/centurysys/nuttx-apps/blob/MAS1xx/master/examples/hello_nim/webserver.nim
```nim
import std/asyncdispatch
import std/strformat
import jester
router myrouter:
get "/hello/@name":
let username = @"name"
resp &"Hello, {username} !"
proc runserver(): Future[void] {.async.} =
let port = 80.Port
let settings = newSettings(port = port)
var server = initJester(myrouter, settings = settings)
server.serve()
proc run_http_server() {.exportc, cdecl.} =
waitFor runserver()
```
(I have also confirmed the operation of other libraries, such as the
zstandard library.)
I need to configure Makefile and Nim's fine settings (malloc allocation
size, cpu kind, optimization flags, etc.) in a file for Nim. I am wondering how
to incorporate this into the core like Zig/Rust.
https://github.com/centurysys/nuttx-apps/tree/MAS1xx/master/examples/hello_nim
(The file config.nims in the above directory is the file that needs to be
set.)
I don't think the Nim language changes are complete, but submitting a pull
request to the community.
https://github.com/nim-lang/Nim/pull/21372
I would be grateful for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[nuttx] 02/02: stm32h7: reduce the extended filter size to 64
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4f30c298bf67407be2dfabb130e0c27c6c651a58 Author: Julian Oes AuthorDate: Wed Feb 15 17:14:21 2023 +1300 stm32h7: reduce the extended filter size to 64 When I checked how this register was set I discovered that 128 was not accepted by the H7 but 64 was ok. Looking at the STM32Cube's HAL it seems to be only 64 words long, however, the reference manual claims otherwise. I have opened a discussion on the ST community forum https://community.st.com/s/question/0D73W01nzqFSAQ but unfortunately not received an answer yet. In the meantime, I think, we should update this to what I found to be working though. Signed-off-by: Julian Oes --- arch/arm/src/stm32h7/stm32_fdcan_sock.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm/src/stm32h7/stm32_fdcan_sock.c b/arch/arm/src/stm32h7/stm32_fdcan_sock.c index 3892c0839c..f13e5ad5d0 100644 --- a/arch/arm/src/stm32h7/stm32_fdcan_sock.c +++ b/arch/arm/src/stm32h7/stm32_fdcan_sock.c @@ -2236,9 +2236,22 @@ int fdcan_initialize(struct fdcan_driver_s *priv) putreg32(regval, priv->base + STM32_FDCAN_SIDFC_OFFSET); ram_offset += n_stdid; - /* Extended ID Filters: Allow space for 128 filters (128 words) */ + /* Extended ID Filters: Allow space for 64 filters (64 words) + * The register definition of FDCAN_XIDFC:LSE - List size extended, in the + * reference manual (RM0433 Rev 8) is defined as 8 bits and claims that a + * value of 0-128 (Number of extended ID filter elements) are possible, but + * in the text in section 56.4.22 and in STM32CubeH7's HAL it's only 64. + * + * HAL source: + * https://github.com/STMicroelectronics/STM32CubeH7/blob/ + * 43c9e552ba1c038577c48723d96ca8c825b11987/Drivers/STM32H7xx_HAL_Driver/ + * Inc/stm32h7xx_hal_fdcan.h#L112-L113 + * + * Discussion: + * https://community.st.com/s/question/0D73W01nzqFSAQ + */ - const uint8_t n_extid = 128; + const uint8_t n_extid = 64; priv->message_ram.filt_extid_addr = gl_ram_base + ram_offset * WORD_LENGTH; regval = (n_extid << FDCAN_XIDFC_LSE_SHIFT) & FDCAN_XIDFC_LSE_MASK;
[nuttx] 01/02: stm32h7: fix comment
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit a59e65db3f93bc1af4c94480fd9d5d4dbd5cc414 Author: Julian Oes AuthorDate: Wed Feb 15 17:05:52 2023 +1300 stm32h7: fix comment This was likely just a copy-paste error. Signed-off-by: Julian Oes --- arch/arm/src/stm32h7/hardware/stm32_fdcan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/src/stm32h7/hardware/stm32_fdcan.h b/arch/arm/src/stm32h7/hardware/stm32_fdcan.h index 144e6c6f51..e2f932beb2 100644 --- a/arch/arm/src/stm32h7/hardware/stm32_fdcan.h +++ b/arch/arm/src/stm32h7/hardware/stm32_fdcan.h @@ -698,7 +698,7 @@ /* *** Bit definition for FDCAN_XIDFC register / #define FDCAN_XIDFC_FLESA_SHIFT (2U) #define FDCAN_XIDFC_FLESA_MASK(0x3FFFU << FDCAN_XIDFC_FLESA_SHIFT) /* 0xFFFC */ -#define FDCAN_XIDFC_FLESA FDCAN_XIDFC_FLESA_MASK /* Filter List Standard Start Address*/ +#define FDCAN_XIDFC_FLESA FDCAN_XIDFC_FLESA_MASK /* Filter List Extended Start Address*/ #define FDCAN_XIDFC_LSE_SHIFT (16U) #define FDCAN_XIDFC_LSE_MASK (0xFFU << FDCAN_XIDFC_LSE_SHIFT) /* 0x00FF */ #define FDCAN_XIDFC_LSE FDCAN_XIDFC_LSE_MASK /* List Size Extended*/
[nuttx] branch master updated (2092e9a9ca -> 4f30c298bf)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2092e9a9ca Adding myself to AUTHORS new a59e65db3f stm32h7: fix comment new 4f30c298bf stm32h7: reduce the extended filter size to 64 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/src/stm32h7/hardware/stm32_fdcan.h | 2 +- arch/arm/src/stm32h7/stm32_fdcan_sock.c | 17 +++-- 2 files changed, 16 insertions(+), 3 deletions(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8536: STM32H7 socketcan extended filter fixes
xiaoxiang781216 merged PR #8536: URL: https://github.com/apache/nuttx/pull/8536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8530: Simulator Documentation for macOS and X11 Linker Changes
xiaoxiang781216 commented on code in PR #8530: URL: https://github.com/apache/nuttx/pull/8530#discussion_r1106967400 ## arch/sim/src/Makefile: ## @@ -141,7 +141,11 @@ endif ifeq ($(CONFIG_SIM_X11FB),y) HOSTSRCS += sim_x11framebuffer.c +ifeq ($(CONFIG_HOST_MACOS),y) + STDLIBS += -L/opt/X11/lib -lX11 -lXext +else Review Comment: yes, but we just need add the search path for macOS, but the library(e.g. -lX11) could be shared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
masayuki2009 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1431037834 @SPRESENSE >Is my operation wrong? Please run the renew command in the foreground. It will take a few seconds to obtain a new address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
SPRESENSE commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1431031973 > @SPRESENSE > > > Confirmed that it works with spresense:rndis and qemu-armv8a:netnsh config. > > How about `spresense:wifi` that uses the usrsock? I confirmed, but not working. The spresense:wifi is not working at NuttX-12.0.0 TAG too. Is my operation wrong? ``` nsh> gs2200m SSID PassWD & nsh> renew wlan0 & nsh> ifconfig wlan0 Link encap:Ethernet HWaddr 3c:a0:67:59:35:4f at UP inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0 <- Incorrect IP address. ``` In my check. NuttX-11.0.0 TAG is working with this commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8535: include/sys/socket.h: Add SOCK_CTRL to socket type
masayuki2009 commented on PR #8535: URL: https://github.com/apache/nuttx/pull/8535#issuecomment-1430947164 @SPRESENSE >Confirmed that it works with spresense:rndis and qemu-armv8a:netnsh config. How about `spresense:wifi` that uses the usrsock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: Adding myself to AUTHORS
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2092e9a9ca Adding myself to AUTHORS 2092e9a9ca is described below commit 2092e9a9cac7b6ceb6609280316281035aaebb76 Author: Nathan Hartman <59230071+hartmannat...@users.noreply.github.com> AuthorDate: Tue Feb 14 19:34:01 2023 -0500 Adding myself to AUTHORS --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 724ef37d0e..a1c9be8a6c 100644 --- a/AUTHORS +++ b/AUTHORS @@ -59,6 +59,7 @@ Michael Jung Michal Lyszczek Miguel Ángel Herranz Trillo (Miguel Herranz) Mihai Serban +Nathan Hartman Neil Hancock Nicholas Elliot Chin (Nicholas Chin) Oki Minabe
