[GitHub] [nuttx] btashton commented on pull request #9204: fdt: Add initial FDT support and procfs for userspace export
btashton commented on PR #9204: URL: https://github.com/apache/nuttx/pull/9204#issuecomment-1547218486 After doing a little more digging I think the cleanest thing to do is to just copy the structure into some allocated memory. Internal to QEMU the address of the FDT passed could reside in the DRAM address space or after it, depending on if DRAM spans the 3GB address mark (to support 32bit). Relevant logic is in https://github.com/qemu/qemu/blob/8844bb8d896595ee1d25d21c770e6e6f29803097/hw/riscv/boot.c#L277-L325 Since this logic is specific to the qemu sim, I dont see a great reason to not to just set aside 512kB (which would be massive FDT) and memcpy from a1 to that based on the FDT header size information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #9266: ipv6: support SOL_IPV6 options IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS
g2gps commented on PR #9266: URL: https://github.com/apache/nuttx/pull/9266#issuecomment-1547181675 > @g2gps does this patch and #9265 fix your issue? Yes, from what I've tested, I can set the hop limit independently for different UDP sockets. Thanks @zhhyu7 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] jinxiuxu opened a new pull request, #1754: nxlooper: set default format for nxlooper
jinxiuxu opened a new pull request, #1754: URL: https://github.com/apache/nuttx-apps/pull/1754 ## Summary set default format as AUDIO_FMT_PCM for nxlooper. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #97: Update Ruby gem and Github Actions packages
cederom commented on PR #97: URL: https://github.com/apache/nuttx-website/pull/97#issuecomment-1547141811 > @btashton: @cederom this may also make it easier for you to build locally long as you have ruby >= 2.5 > Note my instructions with the updated readme. Cool! Thank you @btashton! :-) Yes we have ruby 3.0, 3.1, 3.2 on FBSD :-) I will verify and report back.. just need to take some sleep its 0530AM here :-P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] GooTal commented on issue #9273: trace not working on rv-virt:knsh64?
GooTal commented on issue #9273: URL: https://github.com/apache/nuttx/issues/9273#issuecomment-1547141781 Yes, i have turned it on. Exactly as [task trace user guide](https://nuttx.apache.org/docs/latest/guides/tasktraceuser.html) told.  But rv-virt:knsh64 is not working.  BTW, rv-virt:nsh64 (flat build) works fine. Is there something wrong with kernel build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton commented on pull request #97: Update Ruby gem and Github Actions packages
btashton commented on PR #97: URL: https://github.com/apache/nuttx-website/pull/97#issuecomment-1547136204 @cederom this may also make it easier for you to build locally long as you have ruby >= 2.5 Note my instructions with the updated readme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton opened a new pull request, #97: Update Ruby gem and Github Actions packages
btashton opened a new pull request, #97: URL: https://github.com/apache/nuttx-website/pull/97 ## Summary This slims down and updates the Ruby gems that we are using. Removing the github-pages gem which was unused with they way that we upload the site meant we could move off a bunch of EOL gems and also on to the latest version on Jekell. I did also have to update sass files, this was automated with sass-migrator https://sass-lang.com/documentation/cli/migrator We are also running old versions of github actions which would spit out a warning about still using node 12. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ ## Impact Living in the future. ## Testing Passing CI should be sufficient. Local testing also passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] shipei-xiaomi opened a new pull request, #9274: modify type of numbytes in audio_buf_desc_s from uint16_t to apb_samp_t
shipei-xiaomi opened a new pull request, #9274: URL: https://github.com/apache/nuttx/pull/9274 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #9273: trace not working on rv-virt:knsh64?
xiaoxiang781216 commented on issue #9273: URL: https://github.com/apache/nuttx/issues/9273#issuecomment-1547133246 you need turn on CONFIG_SYSTEM_TRACE to get the trace command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9252: Add ATSAMA5D2/D4 Secure Fuse Controller (SFC) driver
xiaoxiang781216 commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1193287129 ## include/nuttx/efuse/sama5_sfc_fuses.h: ## @@ -0,0 +1,247 @@ +/ + * include/nuttx/efuse/sama5_sfc_fuses.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H +#define __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H + +/ + * Pre-processor Definitions + / + +#if defined(ATSAMA5D2) +#define SAM_SFC_EFUSE_MAX_LEN 544/* Max length of sfc area. */ +#elif defined ATSAMA5D4 +#define SAM_SFC_EFUSE_MAX_LEN 512/* Max length of sfc area. */ +#endif + +/ + * Included Files + / + +/ + * Type Definitions + / + +#if defined(CONFIG_EFUSE) && defined(CONFIG_SAMA5_SFC) Review Comment: No, I mean the whole stuff could be moved to arch/arm/src/sama5/. Any symbols/macros which aren't shared by multiple source file can be defined in one source file which really use them. It's always better to reduce the scope of symbols. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9252: Add ATSAMA5D2/D4 Secure Fuse Controller (SFC) driver
xiaoxiang781216 commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1193287129 ## include/nuttx/efuse/sama5_sfc_fuses.h: ## @@ -0,0 +1,247 @@ +/ + * include/nuttx/efuse/sama5_sfc_fuses.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H +#define __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H + +/ + * Pre-processor Definitions + / + +#if defined(ATSAMA5D2) +#define SAM_SFC_EFUSE_MAX_LEN 544/* Max length of sfc area. */ +#elif defined ATSAMA5D4 +#define SAM_SFC_EFUSE_MAX_LEN 512/* Max length of sfc area. */ +#endif + +/ + * Included Files + / + +/ + * Type Definitions + / + +#if defined(CONFIG_EFUSE) && defined(CONFIG_SAMA5_SFC) Review Comment: No, I mean the whole stuff could be moved to arch/arm/src/sama5/. Any symbols/macros which aren't shared by multiple source file can be defined in the source file which really use them. It's always better to reduce the scope of symbols. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch asf-site updated: Publishing web: ca9633da151c0f07b91649e4b47692338a6d3d35 docs: d3b6bbe4fd58d365a25adbe1e91253de8589e1d2
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 85351b3c Publishing web: ca9633da151c0f07b91649e4b47692338a6d3d35
docs: d3b6bbe4fd58d365a25adbe1e91253de8589e1d2
85351b3c is described below
commit 85351b3ced267831fd58437b946c6da58f6b373a
Author: Lup Yuen Lee
AuthorDate: Mon May 15 03:02:48 2023 +
Publishing web: ca9633da151c0f07b91649e4b47692338a6d3d35 docs:
d3b6bbe4fd58d365a25adbe1e91253de8589e1d2
---
content/community-members/index.html | 9 +
content/docs/10.0.0/index.html | 2 +-
content/docs/10.0.0/searchindex.js | 2 +-
content/docs/10.0.1/index.html | 2 +-
content/docs/10.0.1/searchindex.js | 2 +-
content/docs/10.1.0/index.html | 2 +-
content/docs/10.1.0/searchindex.js | 2 +-
content/docs/10.2.0/index.html | 2 +-
content/docs/10.2.0/searchindex.js | 2 +-
content/docs/10.3.0/index.html | 2 +-
content/docs/10.3.0/searchindex.js | 2 +-
content/docs/11.0.0/index.html | 2 +-
content/docs/11.0.0/searchindex.js | 2 +-
content/docs/12.0.0/index.html | 2 +-
content/docs/12.0.0/searchindex.js | 2 +-
content/docs/12.1.0/index.html | 2 +-
content/docs/12.1.0/searchindex.js | 2 +-
content/docs/latest/index.html | 2 +-
content/docs/latest/searchindex.js | 2 +-
content/feed.xml | 4 ++--
20 files changed, 29 insertions(+), 20 deletions(-)
diff --git a/content/community-members/index.html
b/content/community-members/index.html
index 6a47789e..e8d56f56 100644
--- a/content/community-members/index.html
+++ b/content/community-members/index.html
@@ -249,6 +249,15 @@
+
+http://github.com/lupyuen;>http://github.com/lupyuen.png; />
+Lup Yuen Lee
+lupyuen
+http://github.com/lupyuen;>lupyuen
+PMC, Committer
+
+
+
http://github.com/masayuki2009;>http://github.com/masayuki2009.png; />
Masayuki Ishikawa
diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 27c6028d..93a3b4cf 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -133,7 +133,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as fork()).
-Last Updated: 15 May 23 at 01:03
+Last Updated: 15 May 23 at 03:00
Table of
Contents
diff --git a/content/docs/10.0.0/searchindex.js
b/content/docs/10.0.0/searchindex.js
index f930cc13..7941a257 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
+Search.setIndex({docnames:["applications/index","boards/index","components/binfmt","components/drivers/block/index","components/drivers/character/analog","components/drivers/character/can","components/drivers/character/index","components/drivers/character/keypad","components/drivers/character/pwm","components/drivers/character/quadrature","components/drivers/character/rtc","components/drivers/character/serial","components/drivers/character/timer","components/drivers/character/touchscreen
[...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index a08399ae..c82d079e 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -149,7 +149,7 @@ by following these
NuttX Documentation
NuttX is a real-time operating system (RTOS) with an emphasis on standards
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller
environments, the primary governing standards in NuttX are Posix and ANSI
standards. Additional standard APIs from Unix and other common RTOS’s (such as
VxWorks) are adopted for functionality not available under these standards, or
for functionality that is not appropriate for deeply-embedded environments
(such as
[GitHub] [nuttx-website] xiaoxiang781216 merged pull request #96: Fix social media hyperlinks on the Community page.
xiaoxiang781216 merged PR #96: URL: https://github.com/apache/nuttx-website/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Fix social media hyperlinks on the Community page.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new f919552b Fix social media hyperlinks on the Community page.
f919552b is described below
commit f919552b7b0e8792df1f4e69d238bf5983f47e24
Author: Tomasz 'CeDeROM' CEDRO
AuthorDate: Mon May 15 04:33:57 2023 +0200
Fix social media hyperlinks on the Community page.
Signed-off-by: Tomasz 'CeDeROM' CEDRO
---
_data/project.yml | 4
community.md | 6 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/_data/project.yml b/_data/project.yml
index db58a387..fa964ddf 100644
--- a/_data/project.yml
+++ b/_data/project.yml
@@ -58,3 +58,7 @@ source_repository_apps_mirror:
https://github.com/apache/nuttx-apps
website_repository: https://gitbox.apache.org/repos/asf?p=nuttx-website.git
website_repository_mirror: https://github.com/apache/nuttx-website
+socialmedia_youtube: https://www.youtube.com/@nuttxchannel
+socialmedia_hackster: https://www.hackster.io/nuttx
+socialmedia_linkedin_company: https://www.linkedin.com/company/nuttx
+socialmedia_linkedin_group: https://www.linkedin.com/groups/12002792
diff --git a/community.md b/community.md
index 225c25a2..40c1b7a5 100644
--- a/community.md
+++ b/community.md
@@ -56,9 +56,9 @@ Get help using {{ site.data.project.short_name }} or
contribute to the project o
The mailing list and project website is our central hub of information, but
there are several social media channels where you can find interesting videos,
updates, DIY projects that may help you work with NuttX RTOS.
-* YouTube: https://www.youtube.com/@nuttxchannel.
-* Hackster: https://www.hackster.io/nuttx.
-* LinkedIn: https://www.linkedin.com/company/nuttx ,
https://www.linkedin.com/groups/12002792.
+* YouTube: [https://www.youtube.com/@nuttxchannel]({{
site.data.project.socialmedia_youtube }}).
+* Hackster: [https://www.hackster.io/nuttx]({{
site.data.project.socialmedia_hackster }}).
+* LinkedIn: [https://www.linkedin.com/company/nuttx]({{
site.data.project.socialmedia_linkedin_company }}) ,
[https://www.linkedin.com/groups/12002792]({{
site.data.project.socialmedia_linkedin_group }}).
### Issue tracker
[nuttx-website] branch master updated: Added Lup Yuen Lee to contributors
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new ca9633da Added Lup Yuen Lee to contributors ca9633da is described below commit ca9633da151c0f07b91649e4b47692338a6d3d35 Author: Lup Yuen Lee AuthorDate: Mon May 15 08:45:20 2023 +0800 Added Lup Yuen Lee to contributors --- _data/contributors.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/_data/contributors.yml b/_data/contributors.yml index 4e7c894d..dbf23386 100644 --- a/_data/contributors.yml +++ b/_data/contributors.yml @@ -113,6 +113,12 @@ role: Champion, Mentor, PMC, IPMC, Committer org: +- name: Lup Yuen Lee + apacheId: lupyuen + githubId: lupyuen + role: PMC, Committer + org: + - name: Masayuki Ishikawa apacheId: masayuki githubId: masayuki2009
[GitHub] [nuttx-website] cederom merged pull request #95: Added Lup Yuen Lee to contributors
cederom merged PR #95: URL: https://github.com/apache/nuttx-website/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #95: Added Lup Yuen Lee to contributors
cederom commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547120998 My next PR have "All checks passed" so the fix is working. I will merge this PR now. Thank you for verification @btashton :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #96: Fix social media hyperlinks on the Community page.
cederom commented on PR #96: URL: https://github.com/apache/nuttx-website/pull/96#issuecomment-1547119848 Thank you @xiaoxiang781216 for approving :-) "All checks have passed" in this PR so Your update works fine! Thank you @btashton :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] GooTal opened a new issue, #9273: trace not working on rv-virt:knsh64?
GooTal opened a new issue, #9273: URL: https://github.com/apache/nuttx/issues/9273 I did as [task trace user guide](https://nuttx.apache.org/docs/latest/guides/tasktraceuser.html) told. Enabled these configuration:  I also enabled these configuration: ``` CONFIG_TRACE=y CONFIG_TRACE_ARCH=y CONFIG_TRACE_AUDIO=y CONFIG_TRACE_BOARDS=y CONFIG_TRACE_CRYPTO=y CONFIG_TRACE_DRIVERS=y CONFIG_TRACE_FS=y CONFIG_TRACE_GRAPHICS=y CONFIG_TRACE_LIBS=y CONFIG_TRACE_NET=y CONFIG_TRACE_SCHED=y CONFIG_TRACE_VIDEO=y CONFIG_TRACE_WIRELESS=y ``` Then i built rv-virt:knsh64 from branch releases/12.1. But trace is still not found.  Thanks if you could help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9226: stm32h7/otg: allow USBDEV and USBHOST to work simultaneously
xiaoxiang781216 commented on PR #9226: URL: https://github.com/apache/nuttx/pull/9226#issuecomment-1547115109 > @davids5 this PR is cursed :) It keeps crashing on unrelated jobs. I don't know if our CI is broken or if github still has problems with its infrastructure. rebase and push again may fix the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: tools/refresh.sh: Add option to refresh all archs or all chips
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d3b6bbe4fd tools/refresh.sh: Add option to refresh all archs or all
chips
d3b6bbe4fd is described below
commit d3b6bbe4fd58d365a25adbe1e91253de8589e1d2
Author: Alan Carvalho de Assis
AuthorDate: Tue May 9 15:27:48 2023 -0300
tools/refresh.sh: Add option to refresh all archs or all chips
Currently when we modify some Kconfig related to some chip or
some architecture we need to run refresh.sh to all boards that
is too slow (more than one hour to finish).
This patch modify the script to update only the boards configs
of an specific chip or only the boards of an specific architecture.
Examples:
$ ./tools/refresh.sh --silent --defaults arch:renesas
Normalize us7032evb1/ostest
Normalize us7032evb1/nsh
Normalize skp16c26/ostest
Normalize rx65n-rsk2mb/netnsh
Normalize rx65n-rsk2mb/ipv6
Normalize rx65n-rsk2mb/nsh
Normalize rx65n-rsk1mb/netnsh
Normalize rx65n-rsk1mb/nsh
Normalize rx65n-grrose/netnsh
Normalize rx65n-grrose/ipv6
Normalize rx65n-grrose/nsh
Normalize rx65n/nsh
It updates the boards from all 'renesas' architecture (m9c, rx65n, sh1)
$ ./tools/refresh.sh --silent --defaults chip:rx65n
Normalize rx65n-rsk2mb/netnsh
Normalize rx65n-rsk2mb/ipv6
Normalize rx65n-rsk2mb/nsh
Normalize rx65n-rsk1mb/netnsh
Normalize rx65n-rsk1mb/nsh
Normalize rx65n-grrose/netnsh
Normalize rx65n-grrose/ipv6
Normalize rx65n-grrose/nsh
Normalize rx65n/nsh
It updates all the boards from renesas chip 'rx65n' family
---
tools/refresh.sh | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools/refresh.sh b/tools/refresh.sh
index d013e5da71..b13edbea17 100755
--- a/tools/refresh.sh
+++ b/tools/refresh.sh
@@ -68,10 +68,16 @@ while [ ! -z "$1" ]; do
echo " --help"
echo " Show this help message and exit"
echo " "
-echo " The board directory under nuttx/boards"
+echo " The board directory under nuttx/boards/arch/chip/"
echo " "
-echo " The board configuration directory under
nuttx/boards//configs"
-echo " Note: all configuration is refreshed if : equals
all."
+echo " The board configuration directory under
nuttx/boards/arch/chip//configs"
+echo " "
+echo " The architecture directory under nuttx/boards/"
+echo " "
+echo " The chip family directory under nuttx/boards//"
+echo " Note1: all configuration is refreshed if : equals
all."
+echo " Note2: all configuration of arch XYZ is refreshed if
\"arch:\" is passed"
+echo " Note3: all configuration of chip XYZ is refreshed if
\"chip:\" is passed"
exit 0
;;
* )
@@ -106,7 +112,22 @@ if [ -z "${CONFIGS}" ]; then
fi
if [ "X${CONFIGS}" == "Xall" ]; then
+ echo "Normalizing all boards!"
CONFIGS=`find boards -name defconfig | cut -d'/' -f4,6`
+else
+ if [[ "X${CONFIGS}" == "Xarch:"* ]]; then
+IFS=: read -r atype archname <<< "${CONFIGS}"
+ARCH=$archname
+echo "Normalizing all boards in arch: ${ARCH} !"
+CONFIGS=`find boards/${ARCH} -name defconfig | cut -d'/' -f4,6`
+ else
+if [[ "X${CONFIGS}" == "Xchip:"* ]]; then
+ IFS=: read -r atype chipname <<< "${CONFIGS}"
+ CHIP=$chipname
+ echo "Normalizing all boards in chip: ${CHIP} !"
+ CONFIGS=`find boards/*/${CHIP} -name defconfig | cut -d'/' -f4,6`
+fi
+ fi
fi
for CONFIG in ${CONFIGS}; do
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9231: tools/refresh.sh: Add option to refresh all archs or all chips
xiaoxiang781216 merged PR #9231: URL: https://github.com/apache/nuttx/pull/9231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: arch/arm/src/stm32f7/stm32_usbhost.c: Fix nxstyle errors
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ac392b5306 arch/arm/src/stm32f7/stm32_usbhost.c: Fix nxstyle errors
ac392b5306 is described below
commit ac392b53066a86cda9542ebacbe0452421acba41
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
AuthorDate: Sun May 14 19:44:44 2023 +0200
arch/arm/src/stm32f7/stm32_usbhost.c: Fix nxstyle errors
error: Long line found
---
arch/arm/src/stm32f7/stm32_usbhost.c | 167 ++-
1 file changed, 106 insertions(+), 61 deletions(-)
diff --git a/arch/arm/src/stm32f7/stm32_usbhost.c
b/arch/arm/src/stm32f7/stm32_usbhost.c
index fbc6ab76ee..4f88f4b5a1 100644
--- a/arch/arm/src/stm32f7/stm32_usbhost.c
+++ b/arch/arm/src/stm32f7/stm32_usbhost.c
@@ -1,4 +1,4 @@
-/
+/
* arch/arm/src/stm32f7/stm32_usbhost.c
*
* Licensed to the Apache Software Foundation (ASF) under one or more
@@ -16,11 +16,11 @@
* License for the specific language governing permissions and limitations
* under the License.
*
-
/
+ /
-/
+/
* Included Files
-
/
+ /
#include
@@ -32,59 +32,83 @@
#ifdef HAVE_USBHOST_TRACE
-/
+/
* Pre-processor Definitions
-
/
+ /
#define TR_FMT1 false
#define TR_FMT2 true
#define TRENTRY(id,fmt1,string) {string}
-/
+/
* Private Types
-
/
+ /
struct stm32_usbhost_trace_s
{
const char *string;
};
-/
+/
* Private Data
-
/
+ /
static const struct stm32_usbhost_trace_s g_trace1[TRACE1_NSTRINGS] =
{
#ifdef HAVE_USBHOST_TRACE
- TRENTRY(OTG_TRACE1_DEVDISCONN, TR_FMT1, "OTG ERROR: Host Port %d.
Device disconnected\n"),
- TRENTRY(OTG_TRACE1_IRQATTACH, TR_FMT1, "OTG ERROR: Failed to attach
IRQ\n"),
- TRENTRY(OTG_TRACE1_TRNSFRFAILED, TR_FMT1, "OTG ERROR: Transfer Failed.
ret=%d\n"),
- TRENTRY(OTG_TRACE1_SENDSETUP, TR_FMT1, "OTG ERROR: ctrl_sendsetup()
failed with: %d\n"),
- TRENTRY(OTG_TRACE1_SENDDATA, TR_FMT1, "OTG ERROR: ctrl_senddata()
failed with: %d\n"),
- TRENTRY(OTG_TRACE1_RECVDATA, TR_FMT1, "OTG ERROR: ctrl_recvdata()
failed with: %d\n"),
+ TRENTRY(OTG_TRACE1_DEVDISCONN, TR_FMT1,
+ "OTG ERROR: Host Port %d. Device disconnected\n"),
+ TRENTRY(OTG_TRACE1_IRQATTACH, TR_FMT1,
+ "OTG ERROR: Failed to attach IRQ\n"),
+ TRENTRY(OTG_TRACE1_TRNSFRFAILED, TR_FMT1,
+ "OTG ERROR: Transfer Failed. ret=%d\n"),
+ TRENTRY(OTG_TRACE1_SENDSETUP, TR_FMT1,
+ "OTG ERROR: ctrl_sendsetup() failed with: %d\n"),
+ TRENTRY(OTG_TRACE1_SENDDATA, TR_FMT1,
+ "OTG ERROR: ctrl_senddata() failed with: %d\n"),
+ TRENTRY(OTG_TRACE1_RECVDATA, TR_FMT1,
+ "OTG ERROR: ctrl_recvdata() failed with: %d\n"),
# ifdef HAVE_USBHOST_TRACE_VERBOSE
- TRENTRY(OTG_VTRACE1_CONNECTED, TR_FMT1, "OTG Host Port %d
connected.\n"),
-
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9272: w25qxxxjv: fix STATUS2_QE_ENABLED bitfield write
xiaoxiang781216 merged PR #9272: URL: https://github.com/apache/nuttx/pull/9272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: w25qxxxjv: fix STATUS2_QE_ENABLED bitfield write
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 482cbc4363 w25qxxxjv: fix STATUS2_QE_ENABLED bitfield write 482cbc4363 is described below commit 482cbc43637089b4a3bb6e450e477bf8d8e47c5f Author: Michal Lenc AuthorDate: Sun May 14 22:04:39 2023 +0200 w25qxxxjv: fix STATUS2_QE_ENABLED bitfield write W25QXXXJV_WRITE_STATUS_2 register uses just first byte therefore all operations has to be done in priv->cmdbuf[0]. Previous priv->cmdbuf[1] caused QuadSPI mode not being enabled. Signed-off-by: Michal Lenc --- drivers/mtd/w25qxxxjv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/w25qxxxjv.c b/drivers/mtd/w25qxxxjv.c index 013704b6f6..e77eeae1b8 100644 --- a/drivers/mtd/w25qxxxjv.c +++ b/drivers/mtd/w25qxxxjv.c @@ -616,7 +616,7 @@ static void w25qxxxjv_quad_enable(FAR struct w25qxxxjv_dev_s *priv) w25qxxxjv_write_enable(priv); priv->cmdbuf[0] &= ~STATUS2_QE_MASK; - priv->cmdbuf[1] |= STATUS2_QE_ENABLED; + priv->cmdbuf[0] |= STATUS2_QE_ENABLED; w25qxxxjv_command_write(priv->qspi, W25QXXXJV_WRITE_STATUS_2, (FAR const void *)priv->cmdbuf, 1);
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9271: arch/arm/src/stm32f7/stm32_usbhost.c: Fix nxstyle errors
xiaoxiang781216 merged PR #9271: URL: https://github.com/apache/nuttx/pull/9271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom opened a new pull request, #96: Fix social media hyperlinks on the Community page.
cederom opened a new pull request, #96: URL: https://github.com/apache/nuttx-website/pull/96 ## Summary * Fix social media hyperlinks on the Community page. ## Impact * Hyperlinks are not generated automatically. * External sites URLs are added to `_data/project.yml`. ## Testing * Please verify :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #95: Added Lup Yuen Lee to contributors
cederom commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547103735 Thank you @btashton !! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] lupyuen commented on pull request #95: Added Lup Yuen Lee to contributors
lupyuen commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547100537 Sure I'll rebase later when I'm back at my computer. Thanks everyone :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton commented on pull request #95: Added Lup Yuen Lee to contributors
btashton commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547097889 @lupyuen you do not have my change, can you try a rebase so we know if that resolves the issue here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #95: Added Lup Yuen Lee to contributors
cederom commented on PR #95:
URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547094325
Thanks @btashton.. can you see that "All checks have failed" here?
Looking at the "Build Site" part:
```
0s
##[debug]Evaluating condition for step: 'Build Site'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Build Site
##[debug]Loading inputs
##[debug]Loading env
Run export GEM_HOME=$HOME/.gem
export GEM_HOME=$HOME/.gem
export PATH=$PATH:$GEM_HOME/bin
username="`git log -1 --pretty=format:'%an'`"
email="`git log -1 --pretty=format:'%ae'`"
git config --global user.name $username
git config --global user.email $email
./publish.sh
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.8.16/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.16/x64/lib
##[debug]/usr/bin/bash -e
/home/runner/work/_temp/b2a7b350-874a-4137-b8f2-3d611c0679e3.sh
usage: git config []
Config file location
--global use global config file
--system use system config file
--local use repository config file
--worktreeuse per-worktree config file
-f, --file use given config file
--blob read config from given blob object
Action
--get get value: name [value-pattern]
--get-all get all values: key [value-pattern]
--get-regexp get values for regexp: name-regex [value-pattern]
--get-urlmatchget value specific for the URL: section[.var] URL
--replace-all replace all matching variables: name value
[value-pattern]
--add add a new variable: name value
--unset remove a variable: name [value-pattern]
--unset-all remove all matches: name [value-pattern]
--rename-section rename section: old-name new-name
--remove-section remove a section: name
-l, --listlist all
--fixed-value use string equality when comparing values to
'value-pattern'
-e, --editopen an editor
--get-color find the color configured: slot [default]
--get-colorbool find the color setting: slot [stdout-is-tty]
Type
-t, --type value is given this type
--boolvalue is "true" or "false"
--int value is decimal number
--bool-or-int value is --bool or --int
--bool-or-str value is --bool or string
--pathvalue is a path (file or directory name)
--expiry-date value is an expiry date
Other
-z, --nullterminate values with NUL byte
--name-only show variable names only
--includesrespect include directives on lookup
--show-origin show origin of config (file, standard input, blob,
command line)
--show-scope show scope of config (worktree, local, global,
system, command)
--default with --get, use default value when missing entry
Error: Process completed with exit code 129.
##[debug]Finishing: Build Site
```
Should I just Merge this one and next checks will use updated scripts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx-website] btashton commented on pull request #95: Added Lup Yuen Lee to contributors
btashton commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547089042 > One momento sorry @lupyuen.. build fails.. and that is done to update website.. I can see that previous builds also failed and so the website is not updated o_O > > @btashton could you please take a look as https://github.com/apache/nuttx-website/actions/runs/4975335982/jobs/8902681849?pr=95? I think https://github.com/apache/nuttx-website/pull/94 did not do the trick.. and there are no special characters now in the username.. and HEAD contains Your commit that also has no special characters in the username. Sorry why do you say that? My patch did fix the publish problem. This is likely something else, see that you are now on the public page.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #95: Added Lup Yuen Lee to contributors
cederom commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547082641 * Can this be caused by GitHub blocking vulnerable ActiveSupport GEM? We have `6.0.6.1.` patched version is `6.1.7.3` and the version 7 is already out. See Security tab at the top (https://github.com/apache/nuttx-website/security/dependabot). On my BSD box I was not able to setup this environment :-( * Or CI script using node12 instead node16 calls as reported here: ``` build Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #95: Added Lup Yuen Lee to contributors
cederom commented on PR #95: URL: https://github.com/apache/nuttx-website/pull/95#issuecomment-1547073154 One momento sorry @lupyuen.. build fails.. and that is done to update website.. I can see that previous builds also failed and so the website is not updated o_O @btashton could you please take a look as https://github.com/apache/nuttx-website/actions/runs/4975335982/jobs/8902681849?pr=95? I think https://github.com/apache/nuttx-website/pull/94 did not do the trick.. and there are no special characters now in the username.. and HEAD contains Your commit that also has no special characters in the username. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch asf-site updated: Publishing web: 0cb4dfd859c0e7040cc76dc5b8ac1e065d6fab69 docs: c9a843bdca252e38ae561326ad49bb4842fbbcc9
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new fc7c8fe9 Publishing web: 0cb4dfd859c0e7040cc76dc5b8ac1e065d6fab69 docs: c9a843bdca252e38ae561326ad49bb4842fbbcc9 fc7c8fe9 is described below commit fc7c8fe95a1bc58829778be2cb4758410fa3149e Author: Brennan Ashton AuthorDate: Mon May 15 01:06:39 2023 + Publishing web: 0cb4dfd859c0e7040cc76dc5b8ac1e065d6fab69 docs: c9a843bdca252e38ae561326ad49bb4842fbbcc9 --- content/community-members/index.html | 41 ++-- content/community/index.html | 14 +++- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.0/searchindex.js | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.0.1/searchindex.js | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/10.1.0/searchindex.js | 2 +- content/docs/10.2.0/index.html | 2 +- content/docs/10.2.0/searchindex.js | 2 +- content/docs/10.3.0/index.html | 2 +- content/docs/10.3.0/searchindex.js | 2 +- content/docs/11.0.0/index.html | 2 +- content/docs/11.0.0/searchindex.js | 2 +- content/docs/12.0.0/index.html | 2 +- content/docs/12.0.0/searchindex.js | 2 +- content/docs/12.1.0/index.html | 2 +- content/docs/12.1.0/searchindex.js | 2 +- content/docs/latest/index.html | 2 +- content/docs/latest/searchindex.js | 2 +- content/feed.xml | 4 ++-- 21 files changed, 58 insertions(+), 37 deletions(-) diff --git a/content/community-members/index.html b/content/community-members/index.html index 7a07ab97..6a47789e 100644 --- a/content/community-members/index.html +++ b/content/community-members/index.html @@ -110,7 +110,7 @@ Abdelatif Guettouche aguettouche http://github.com/Ouss4;>Ouss4 -PPMC, Committer +PMC, Committer @@ -128,7 +128,7 @@ Alan Carvalho de Assis acassis http://github.com/acassis;>acassis -PPMC, Committer +PMC, Committer @@ -137,7 +137,7 @@ Alin Jerpelea jerpelea http://github.com/jerpelea;>jerpelea -PPMC, Committer +PMC, Committer @@ -146,7 +146,7 @@ Anthony Merlino antmerlino http://github.com/antmerlino;>antmerlino -PPMC, Committer +PMC, Committer @@ -155,7 +155,7 @@ Brennan Ashton btashton http://github.com/btashton;>btashton -PPMC, Committer +PMC, Committer @@ -173,7 +173,7 @@ David Sidrane davids5 http://github.com/davids5;>davids5 -PPMC, Committer +PMC, Committer @@ -182,7 +182,7 @@ Duo Zhang zhangduo http://github.com/Apache9;>Apache9 -Mentor, IPMC, PPMC, Committer +Mentor, PMC, IPMC, Committer @@ -191,7 +191,7 @@ Flavio Paiva Junqueira fpj http://github.com/fpj;>fpj -Mentor, IPMC, PPMC, Committer +Mentor, PMC, IPMC, Committer @@ -200,7 +200,7 @@ Gregory Nutt gnutt http://github.com/patacongo;>patacongo -PPMC, Committer +PMC, Committer @@ -236,7 +236,7 @@ Justin Mclean jmclean http://github.com/justinmclean;>justinmclean -Mentor, IPMC, PPMC, Committer +Mentor, PMC, IPMC, Committer @@ -245,7 +245,7 @@ Junping Du junping_du http://github.com/JunpingDu;>JunpingDu -Champion, Mentor, IPMC, PPMC, Committer +Champion, Mentor, PMC, IPMC, Committer @@ -254,7 +254,7 @@ Masayuki Ishikawa masayuki http://github.com/masayuki2009;>masayuki2009 -PPMC, Committer +PMC, Committer @@ -281,7 +281,7 @@ Mohammad Asif Siddiqui asifdxtreme http://github.com/asifdxtreme;>asifdxtreme -Mentor, IPMC, PPMC, Committer +Mentor, PMC, IPMC, Committer @@ -290,7 +290,7 @@ Nathan Hartman hartmannathan http://github.com/hartmannathan;>hartmannathan -PPMC, Committer +PMC, Committer @@ -308,7 +308,7 @@ Sara da Cunha Monteiro de Souza sara http://github.com/saramonteiro;>saramonteiro -PPMC, Committer +PMC, Committer @@ -321,12 +321,21 @@ + +
[GitHub] [nuttx-website] cederom merged pull request #94: ci: Properly capture username it git config
cederom merged PR #94: URL: https://github.com/apache/nuttx-website/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated (af7e8d88 -> 0cb4dfd8)
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git from af7e8d88 Contributors list update after graduation PPMC->PMC, retain IPMC status. add 0cb4dfd8 ci: Properly capture username it git config No new revisions were added by this update. Summary of changes: .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [nuttx] cederom commented on issue #9095: Publish PDF version of documentation alongside html
cederom commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547053503 Here goes the ePub test build: [NuttX.epub.zip](https://github.com/apache/nuttx/files/11473321/NuttX.epub.zip). I had to zip it for GH to accept the file, please unzip after download. You can use Calibre reader to open it [1] :-) [1] https://github.com/kovidgoyal/calibre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] lupyuen opened a new pull request, #95: Added Lup Yuen Lee to contributors
lupyuen opened a new pull request, #95: URL: https://github.com/apache/nuttx-website/pull/95 ## Summary Added myself (Lup Yuen Lee) as PMC and Committer to the list of contributors. Sorry I missed this earlier. ## Impact Updated the list of contributors. ## Testing None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] cederom commented on issue #9095: Publish PDF version of documentation alongside html
cederom commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547044672 > @btashton: Tbh I'm probably not going to make too many tuning changes and what we can do are somewhat limited as this is generated via sphinx and some formatting is going to be opinionated from that. It can be easily tuned in `conf.py` and the LaTeX section from what I can see :-) > What I will do is wire this up to be linked in the website for download. Awesome! Thank you! :-) > As for the size. In this day and age is it really worth making it more optimized? 25MB is tiny compared to even the repo and the PDF is something like 300+ pages with images. Well, old habits, my butt hurts when the overall size can be easily decreased 3x+ and the text to gfx ratio is 1:9. I will try to help with gfx optimization + documentation edit / update no worries :-) > I personally expect minimal usage of this. Even more kudos for doing that @btashton thank you ! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] cederom commented on issue #9095: Publish PDF version of documentation alongside html
cederom commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547042896 * It was just a quick test of sphinx + html + latex on FreeBSD on my side :-) * Regarding LaTeX optimizations / tuning I can handle that no worries I use LaTeX myself for years :-) * Regarding PDF size optimization I have updated the `gs` conversion results above for a comparison. This trick comes handy quite often in various areas working with PDF. No commercial closed source converters involved :-) * We may worry about PDF size optimizations when we have PDF working, cool :-) * Regarding Terminal Graphics / Screenshots, these need good read, we can use Asciinema [1] that even allows animated terminal in the online documentation! * Asciinema frame can be converted to SVG for instance with asciicast2vector [2]. That will result in a relatively small and always perfect quality terminal screenshot :-) [1] https://asciinema.org/ [2] https://github.com/misc0110/asciicast2vector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on issue #9095: Publish PDF version of documentation alongside html
btashton commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547037197 > * Okay so I was able to build HTML documentation on FreeBSD. Images on the website take around 22.8MB. > * I was able to quick-and-dirty try out the PDF build based on example sphinx conf [1] with some small adjutments. > * `sphinx-build -b latex . _build_latex -j8; cd _build_latex; gmake all`. > * there are issues with some UTF characters that cannot be converted to LaTeX. > * all images needs to be converted first to PNG (this can be done with `convert` utility from ImageMagic). > * due to LaTeX build errors I had to add `-f` switch to `pdflatex` in `_build_latex/Makefile`. Also batch mode helps in build no questions asked (to be confirmed by Enter anyways). (`PDFLATEX = latexmk -pdf -dvi- -ps- -f --interaction=batchmode`). > You are reinventing what I have already done. Already resolved the Unicode issue and also all the images outside of two of them. There is no need to change the Unicode characters or bulk change images to png. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on issue #9095: Publish PDF version of documentation alongside html
btashton commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547035619 Tbh I'm probably not going to make too many tuning changes and what we can do are somewhat limited as this is generated via sphinx and some formatting is going to be opinionated from that. What I will do is wire this up to be linked in the website for download. As for the size. In this day and age is it really worth making it more optimized? 25MB is tiny compared to even the repo and the PDF is something like 300+ pages with images. I personally expect minimal usage of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9231: tools/refresh.sh: Add option to refresh all archs or all chips
acassis commented on PR #9231: URL: https://github.com/apache/nuttx/pull/9231#issuecomment-1547029091 @xiaoxiang781216 done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] cederom commented on issue #9095: Publish PDF version of documentation alongside html
cederom commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547019364 Looks awesome first step! Congratulation @btashton :-) We could create a tar.gz packages for each release along with full pdf documentation. Then save it in various places and we are ready for zombie apocalypse! :-) Some tweaking that comes to my mind at first look: * headers, introduction, etc. * re-formatting long tables that does not fit into a single page can be converted to a long list, etc * moving long parts (i.e. Apache License) to Appendix section. * Table of Contents tree embedded into PDF. * clickable table of contents. * images/charts reference index. We need to shrink the full document size from 24MB to as small as possible. Would that be possible to see how small PDF can be with no images at all? I was using LaTeX for some time for documentation / presentation / automation so I have some experience we can use. From what I remember the best format for graphics was vector (where possible) as it results best quality and smallest size (LaTeX converted those to eps/ps and then attached to ps version of the document that was then coverted to pdf).. so we may try using SVG for the diagrams? As for PNG I also had to convert JPG to PNG.. but there may be some smart way around that.. or simply reworking final PDF with the trick below. Quick trick I usually do to make PDF smaller without noticeable graphics quality loss is: ``` gs -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dPDFSETTINGS=/screen -dNOPAUSE -dBATCH -dQUIET -dDownsampleColorImages=true -dColorImageResolution=200 -dColorImageDownsampleType=/Bicubic -sOutputFile=nuttx-small.pdf nuttx.pdf ``` Tuning the image resolution parameter I got: * 200dpi: 24MB -> 7.6MB. * 150dpi: 24MB -> 6.9MB. * 75dpi: 24MB -> 4.7MB. Please let me know how can I help? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on issue #9095: Publish PDF version of documentation alongside html
btashton commented on issue #9095: URL: https://github.com/apache/nuttx/issues/9095#issuecomment-1547008998 I took a stab at this today and have something I think is workable. Let me know if this pdf attached seems workable as a first pass. [nuttx.pdf](https://github.com/apache/nuttx/files/11472992/nuttx.pdf) @cederom @patacongo @hartmannathan For my own reference - Update build packages for tex support - Update latex image to deal with unicode issues `SPHINXOPTS='-D latex_engine=lualatex' pipenv run make latexpdf` - Remove `webp` and `gif` images (there are only two) since they cannot be rendered to tex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #94: ci: Properly capture username it git config
cederom commented on PR #94: URL: https://github.com/apache/nuttx-website/pull/94#issuecomment-1546998662 Thank You @btashton :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton commented on pull request #94: ci: Properly capture username it git config
btashton commented on PR #94: URL: https://github.com/apache/nuttx-website/pull/94#issuecomment-1546994334 @acassis / @cederom this will resolve the CI issue that was preventing the recent changes from being published. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton opened a new pull request, #94: ci: Properly capture username it git config
btashton opened a new pull request, #94: URL: https://github.com/apache/nuttx-website/pull/94 ## Summary Git username that contained certain symbols such as `Tomasz 'CeDeROM' CEDRO` does not get captured properly when setting the git config in the workflow ``` ~/nuttx-wrk/nuttx-website on master via v3.0.2 ❯ username="`git log -1 --pretty=format:'%an'`" email="`git log -1 --pretty=format:'%ae'`" ❯ echo $username Tomasz 'CeDeROM' CEDRO ❯ echo $email to...@cedro.info ❯ git config user.name $username usage: git config [] Config file location --global use global config file --system use system config file ``` With this change ``` ❯ git config user.name "$username" ❯ git config user.name Tomasz 'CeDeROM' CEDRO ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] michallenc commented on issue #9182: W25QxxJV driver does behave correctly for 1 GB flash
michallenc commented on issue #9182: URL: https://github.com/apache/nuttx/issues/9182#issuecomment-1546993300 @acassis Partially. I got an application note from Winbond this week so I implemented dual die support according to this. I still need to do the tests tomorrow. I was mostly stuck at not being capable to even get the first die working. This was caused by flash not enabling QuadSPI mode which should be fixed by this PR https://github.com/apache/nuttx/pull/9272. I am not sure why this problem did not occur on W25Q512JV flash (I also was able to make it work in QuadSPI mode), probably the mode is enabled there by default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] michallenc opened a new pull request, #9272: w25qxxxjv: fix STATUS2_QE_ENABLED bitfield write
michallenc opened a new pull request, #9272: URL: https://github.com/apache/nuttx/pull/9272 ## Summary W25QXXXJV_WRITE_STATUS_2 register uses just first byte therefore all operations has to be done in priv->cmdbuf[0]. Previous priv->cmdbuf[1] caused QE mode not being enabled. ## Impact W25Q flash now enables Quad mode. ## Testing Tested on W25Q01JV flash and SAM E70 based board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #93: Contributors list update after graduation PPMC->PMC, retain IPMC status.
cederom commented on PR #93: URL: https://github.com/apache/nuttx-website/pull/93#issuecomment-1546989195 TANK U =) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Contributors list update after graduation PPMC->PMC, retain IPMC status.
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new af7e8d88 Contributors list update after graduation PPMC->PMC, retain IPMC status. af7e8d88 is described below commit af7e8d88533d0690888e9cb923d55955062a8aa4 Author: Tomasz 'CeDeROM' CEDRO AuthorDate: Sun May 14 21:12:59 2023 +0200 Contributors list update after graduation PPMC->PMC, retain IPMC status. Signed-off-by: Tomasz 'CeDeROM' CEDRO --- _data/contributors.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/_data/contributors.yml b/_data/contributors.yml index 87819167..4e7c894d 100644 --- a/_data/contributors.yml +++ b/_data/contributors.yml @@ -21,7 +21,7 @@ - name: Abdelatif Guettouche apacheId: aguettouche githubId: Ouss4 - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Adam Feuer @@ -33,25 +33,25 @@ - name: Alan Carvalho de Assis apacheId: acassis githubId: acassis - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Alin Jerpelea apacheId: jerpelea githubId: jerpelea - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Anthony Merlino apacheId: antmerlino githubId: antmerlino - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Brennan Ashton apacheId: btashton githubId: btashton - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Chao An @@ -63,25 +63,25 @@ - name: David Sidrane apacheId: davids5 githubId: davids5 - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Duo Zhang apacheId: zhangduo githubId: Apache9 - role: Mentor, PMC, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, Committer org: - name:Flavio Paiva Junqueira apacheId: fpj githubId: fpj - role: Mentor, PMC, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, Committer org: - name: Gregory Nutt apacheId: gnutt githubId: patacongo - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Gustavo Henrique Nihei @@ -104,19 +104,19 @@ - name: Justin Mclean apacheId: jmclean githubId: justinmclean - role: Mentor, PMC, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, Committer org: - name: Junping Du apacheId: junping_du githubId: JunpingDu - role: Champion, Mentor, PMC, IPMC, PPMC, Committer + role: Champion, Mentor, PMC, IPMC, Committer org: - name: Masayuki Ishikawa apacheId: masayuki githubId: masayuki2009 - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Mateusz Szafoni @@ -134,13 +134,13 @@ - name: Mohammad Asif Siddiqui apacheId: asifdxtreme githubId: asifdxtreme - role: Mentor, PMC, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, Committer org: - name: Nathan Hartman apacheId: hartmannathan githubId: hartmannathan - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Petro Karashchenko @@ -152,7 +152,7 @@ - name: Sara da Cunha Monteiro de Souza apacheId: sara githubId: saramonteiro - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Sebastian Ene @@ -170,7 +170,7 @@ - name: Xiang Xiao apacheId: xiaoxiang githubId: xiaoxiang781216 - role: PMC, PPMC, Committer + role: PMC, Committer org: - name: Yamamoto Takashi
[GitHub] [nuttx-website] btashton merged pull request #93: Contributors list update after graduation PPMC->PMC, retain IPMC status.
btashton merged PR #93: URL: https://github.com/apache/nuttx-website/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on a diff in pull request #92: Updated Contributors PMC list.
cederom commented on code in PR #92: URL: https://github.com/apache/nuttx-website/pull/92#discussion_r1193195957 ## _data/contributors.yml: ## @@ -63,25 +63,25 @@ - name: David Sidrane apacheId: davids5 githubId: davids5 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Duo Zhang apacheId: zhangduo githubId: Apache9 - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer Review Comment: as above, please verify :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on a diff in pull request #92: Updated Contributors PMC list.
cederom commented on code in PR #92: URL: https://github.com/apache/nuttx-website/pull/92#discussion_r1193195906 ## _data/contributors.yml: ## @@ -21,7 +21,7 @@ - name: Abdelatif Guettouche apacheId: aguettouche githubId: Ouss4 - role: PPMC, Committer + role: PMC, PPMC, Committer Review Comment: Alan merged the PR already so here goes the update: https://github.com/apache/nuttx-website/pull/93 :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom opened a new pull request, #93: Contributors list update after graduation PPMC->PMC, retain IPMC status.
cederom opened a new pull request, #93: URL: https://github.com/apache/nuttx-website/pull/93 ## Summary * Contributors list update after graduation PPMC->PMC, retain IPMC status. * As instructed by @patacongo in https://github.com/apache/nuttx-website/pull/92 PPMC becomes PMC after graduation, IPMC status is retained. ## Impact * Update PMC status on the Contributors page after graduation. ## Testing * Please verify :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] patacongo commented on a diff in pull request #92: Updated Contributors PMC list.
patacongo commented on code in PR #92: URL: https://github.com/apache/nuttx-website/pull/92#discussion_r1193193879 ## _data/contributors.yml: ## @@ -63,25 +63,25 @@ - name: David Sidrane apacheId: davids5 githubId: davids5 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Duo Zhang apacheId: zhangduo githubId: Apache9 - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer Review Comment: ```suggestion role: Mentor, IPMC, PMC, Committer ``` Same as above. All occurrences of PPMC should be changed to PMC only. Applies to similar cases below as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] patacongo commented on a diff in pull request #92: Updated Contributors PMC list.
patacongo commented on code in PR #92: URL: https://github.com/apache/nuttx-website/pull/92#discussion_r1193193879 ## _data/contributors.yml: ## @@ -63,25 +63,25 @@ - name: David Sidrane apacheId: davids5 githubId: davids5 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Duo Zhang apacheId: zhangduo githubId: Apache9 - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer Review Comment: ```suggestion role: Mentor, IPMC, PMC, Committer ``` Same as above. All occurrences of PPMC should be changed to PMC only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] patacongo commented on a diff in pull request #92: Updated Contributors PMC list.
patacongo commented on code in PR #92: URL: https://github.com/apache/nuttx-website/pull/92#discussion_r1193193761 ## _data/contributors.yml: ## @@ -21,7 +21,7 @@ - name: Abdelatif Guettouche apacheId: aguettouche githubId: Ouss4 - role: PPMC, Committer + role: PMC, PPMC, Committer Review Comment: ```suggestion role: PMC, Committer ``` PPMC is the podling PMC. We are no longer a incubating "podling", we are a TLP (top-level project). So any occurrences of PPMC should be replacement with PMC. Same thing, just promoted to TLP. Same for the following roles that include both PMC and PPMC. Those should be only PMC. IPMC is something different. You need to retain all references to the IPMC. That is the incubator PMC that is in charge of all of the PPMCs. So some people who were our mentors are in the IPMC and were also the PPMC (which is now the PMC). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Updated Contributors PMC list.
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new ffb43f67 Updated Contributors PMC list. ffb43f67 is described below commit ffb43f6743df1bf02c7356a3fcd10059fa4ac690 Author: Tomasz 'CeDeROM' CEDRO AuthorDate: Sun May 14 20:38:28 2023 +0200 Updated Contributors PMC list. * Added current PMC status along the IPMC/PPMC to preserve history. Signed-off-by: Tomasz 'CeDeROM' CEDRO --- _data/contributors.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/_data/contributors.yml b/_data/contributors.yml index 03907e45..87819167 100644 --- a/_data/contributors.yml +++ b/_data/contributors.yml @@ -21,7 +21,7 @@ - name: Abdelatif Guettouche apacheId: aguettouche githubId: Ouss4 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Adam Feuer @@ -33,25 +33,25 @@ - name: Alan Carvalho de Assis apacheId: acassis githubId: acassis - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Alin Jerpelea apacheId: jerpelea githubId: jerpelea - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Anthony Merlino apacheId: antmerlino githubId: antmerlino - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Brennan Ashton apacheId: btashton githubId: btashton - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Chao An @@ -63,25 +63,25 @@ - name: David Sidrane apacheId: davids5 githubId: davids5 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Duo Zhang apacheId: zhangduo githubId: Apache9 - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer org: - name:Flavio Paiva Junqueira apacheId: fpj githubId: fpj - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer org: - name: Gregory Nutt apacheId: gnutt githubId: patacongo - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Gustavo Henrique Nihei @@ -104,19 +104,19 @@ - name: Justin Mclean apacheId: jmclean githubId: justinmclean - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer org: - name: Junping Du apacheId: junping_du githubId: JunpingDu - role: Champion, Mentor, IPMC, PPMC, Committer + role: Champion, Mentor, PMC, IPMC, PPMC, Committer org: - name: Masayuki Ishikawa apacheId: masayuki githubId: masayuki2009 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Mateusz Szafoni @@ -134,13 +134,13 @@ - name: Mohammad Asif Siddiqui apacheId: asifdxtreme githubId: asifdxtreme - role: Mentor, IPMC, PPMC, Committer + role: Mentor, PMC, IPMC, PPMC, Committer org: - name: Nathan Hartman apacheId: hartmannathan githubId: hartmannathan - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Petro Karashchenko @@ -152,7 +152,7 @@ - name: Sara da Cunha Monteiro de Souza apacheId: sara githubId: saramonteiro - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Sebastian Ene @@ -170,7 +170,7 @@ - name: Xiang Xiao apacheId: xiaoxiang githubId: xiaoxiang781216 - role: PPMC, Committer + role: PMC, PPMC, Committer org: - name: Yamamoto Takashi
[GitHub] [nuttx-website] acassis merged pull request #92: Updated Contributors PMC list.
acassis merged PR #92: URL: https://github.com/apache/nuttx-website/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #90: Community page updates.
cederom commented on PR #90: URL: https://github.com/apache/nuttx-website/pull/90#issuecomment-1546972969 Here https://github.com/apache/nuttx-website/pull/92 is the PR for PMC status added alond with IPMC/PPMC to preserve history. I will ask on the mailing list and update accordingly :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom opened a new pull request, #92: Updated Contributors PMC list.
cederom opened a new pull request, #92: URL: https://github.com/apache/nuttx-website/pull/92 ## Summary * Added current PMC status along the IPMC/PPMC to preserve history. ## Impact * Keep the IPMC/PPMC roles to preserve history. ## Testing * Please let me know if we want to preserve IPMC/PPMC hostory or simply replace them with PMC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom commented on pull request #90: Community page updates.
cederom commented on PR #90: URL: https://github.com/apache/nuttx-website/pull/90#issuecomment-1546972073 > @btashton: Looks good, noticed that we need to convert all the PPMC mentions to PMC. Thanks @btashton ! Would you like me to add PMC to the list to keep the IPMC/PPMC history or simply replace IPMC/PPMC with PMC? Shouldn't we ask on the mailing list? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Added Tomek CEDRO to contributors.
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new bcca8395 Added Tomek CEDRO to contributors. bcca8395 is described below commit bcca83955d8ce1ea3a6746c9d2a164b7f987e8cf Author: Tomasz 'CeDeROM' CEDRO AuthorDate: Sun May 14 20:18:35 2023 +0200 Added Tomek CEDRO to contributors. Signed-off-by: Tomasz 'CeDeROM' CEDRO --- _data/contributors.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/_data/contributors.yml b/_data/contributors.yml index 7837e966..03907e45 100644 --- a/_data/contributors.yml +++ b/_data/contributors.yml @@ -161,6 +161,12 @@ role: Committer org: +- name: Tomek CEDRO + apacheId: cederom + githubId: cederom + role: PMC, Committer + org: CeDeROM + - name: Xiang Xiao apacheId: xiaoxiang githubId: xiaoxiang781216
[GitHub] [nuttx-website] btashton merged pull request #91: Added Tomek CEDRO to contributors.
btashton merged PR #91: URL: https://github.com/apache/nuttx-website/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-website] branch master updated: Community page updates.
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new 24d6d933 Community page updates.
24d6d933 is described below
commit 24d6d93373093f1095cdd3a2242bc12fb1df25c2
Author: Tomasz 'CeDeROM' CEDRO
AuthorDate: Sun May 14 20:10:04 2023 +0200
Community page updates.
* Information that mailing list is our main communication channel.
* Information that all important changes must be discussed on mailing list.
* Added social media section.
Signed-off-by: Tomasz 'CeDeROM' CEDRO
---
community.md | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/community.md b/community.md
index 1b768331..225c25a2 100644
--- a/community.md
+++ b/community.md
@@ -40,9 +40,10 @@ You can:
Visit the [Contributing] page for more information.
+
### Mailing list
-Get help using {{ site.data.project.short_name }} or contribute to the project
on our mailing lists:
+Get help using {{ site.data.project.short_name }} or contribute to the project
on our mailing lists. This is our preferred communication channel and all
important discussions take place here.
{% if site.data.project.user_list %}
* [site.data.project.user_list](mailto:{{ site.data.project.user_list }}) is
for usage questions, help, and announcements. [subscribe](mailto:{{
site.data.project.user_list_subscribe }}?subject=send this email to subscribe),
[unsubscribe](mailto:{{ site.data.project.dev_list_unsubscribe
}}?subject=send this email to unsubscribe), [archives]({{
site.data.project.user_list_archive_mailarchive }})
@@ -51,9 +52,16 @@ Get help using {{ site.data.project.short_name }} or
contribute to the project o
* [{{ site.data.project.commits_list }}](mailto:{{
site.data.project.commits_list }}) is for commit messages and patches to {{
site.data.project.short_name }}. [subscribe](mailto:{{
site.data.project.commits_list_subscribe }}?subject=send this email to
subscribe), [unsubscribe](mailto:{{ site.data.project.commits_list_unsubscribe
}}?subject=send this email to unsubscribe), [archives]({{
site.data.project.commits_list_archive_mailarchive }})
-### Issue tracker
+### Social Media
+
+The mailing list and project website is our central hub of information, but
there are several social media channels where you can find interesting videos,
updates, DIY projects that may help you work with NuttX RTOS.
+
+* YouTube: https://www.youtube.com/@nuttxchannel.
+* Hackster: https://www.hackster.io/nuttx.
+* LinkedIn: https://www.linkedin.com/company/nuttx ,
https://www.linkedin.com/groups/12002792.
+### Issue tracker
Bug Reports
@@ -65,12 +73,12 @@ Before submitting an issue, please:
* Search the mailing list [archives]({{
site.data.project.dev_list_archive_mailarchive }}) to verify there is no
existing issue reporting the bug you've found.
* Consider tracking down the bug yourself in the NuttX's source and submitting
a patch along with your bug report. This is a great time saver for the NuttX
developers and helps ensure the bug will be fixed quickly.
-
-
Feature Requests
Enhancement requests for new features are also welcome. The more concrete and
rational the request is, the greater the chance it will be incorporated into
future releases.
+Please note that all important changes must be first discussed on our mailing
list!
+
### Source Code
[GitHub] [nuttx-website] btashton merged pull request #90: Community page updates.
btashton merged PR #90: URL: https://github.com/apache/nuttx-website/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] btashton commented on pull request #90: Community page updates.
btashton commented on PR #90: URL: https://github.com/apache/nuttx-website/pull/90#issuecomment-1546968735 Looks good, noticed that we need to convert all the PPMC mentions to PMC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom opened a new pull request, #91: Added Tomek CEDRO to contributors.
cederom opened a new pull request, #91: URL: https://github.com/apache/nuttx-website/pull/91 ## Summary * Added Tomek CEDRO to contributors. ## Impact * New controbutor on the list. ## Testing * Please verify :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-website] cederom opened a new pull request, #90: Community page updates.
cederom opened a new pull request, #90: URL: https://github.com/apache/nuttx-website/pull/90 ## Summary * Information that mailing list is our main communication channel. * Information that all important changes must be discussed on mailing list. * Added social media section. ## Impact * Website and mailing list is the central point of information. * Better information on social media. ## Testing * Please verify formatting, I have problem installing `github-pages` gem :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] TimJTi commented on a diff in pull request #9252: Add ATSAMA5D2/D4 Secure Fuse Controller (SFC) driver
TimJTi commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1193186911 ## include/nuttx/efuse/sama5_sfc_fuses.h: ## @@ -0,0 +1,247 @@ +/ + * include/nuttx/efuse/sama5_sfc_fuses.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H +#define __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H + +/ + * Pre-processor Definitions + / + +#if defined(ATSAMA5D2) +#define SAM_SFC_EFUSE_MAX_LEN 544/* Max length of sfc area. */ +#elif defined ATSAMA5D4 +#define SAM_SFC_EFUSE_MAX_LEN 512/* Max length of sfc area. */ +#endif + +/ + * Included Files + / + +/ + * Type Definitions + / + +#if defined(CONFIG_EFUSE) && defined(CONFIG_SAMA5_SFC) Review Comment: > why not move the private macro/variable to source file @xiaoxiang781216 - just to check: I assume are you referring to the `#define SAM_SFC_EFUSE_MAX_LEN` macros not the enum and/or static consts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1753: logging/nxscope: various improvements
raiden00pl opened a new pull request, #1753: URL: https://github.com/apache/nuttx-apps/pull/1753 ## Summary - logging/nxscope: fix invalid zalloc size for rxbuf - logging/nxscope: add an option to disable lock in channels put interfaces With this option enabled the user can speed up adding a large amount of data to the stream buffer by minimizing the usage of the nxscope lock interface: nxscope_lock(>nxs); nxscope_put_vfloat(, 0, data0, 1); nxscope_put_vfloat(, 1, data1, 1); nxscope_put_vfloat(, 2, data2, 1); nxscope_put_vfloat(, 3, data3, 1); nxscope_unlock(>nxs); - logging/nxscope: do not complete the stream frame if the previous send failed. In this case, the buffer already contains a frame ready to be send ## Impact ## Testing examples/foc with enabled nxscope logging (not yet upstream) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] simbit18 opened a new pull request, #9271: arch/arm/src/stm32f7/stm32_usbhost.c: Fix nxstyle errors
simbit18 opened a new pull request, #9271: URL: https://github.com/apache/nuttx/pull/9271 ## Summary error: Long line found ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zhoukejun commented on issue #9268: ARM64: Lack of other options about interrupt controller
zhoukejun commented on issue #9268: URL: https://github.com/apache/nuttx/issues/9268#issuecomment-1546942263 > one approach could extend the range from -1 to 4 and select -1 to disable all gic related code That is a good idea. The following patch works fine. -- diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 7aeb721f47..bfdac6f1fd 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -214,7 +214,7 @@ config ARM_GIC_VERSION int "GIC version" default 2 if ARCH_CHIP_A64 default 3 - range 2 4 + range -1 4 ---help--- Version of Generic Interrupt Controller (GIC) supported by the architecture -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on issue #9270: Please add "sudo" to all Ubuntu Getting Started / Installing patterns
btashton commented on issue #9270: URL: https://github.com/apache/nuttx/issues/9270#issuecomment-1546927710 > `sudo` is not supported by Cygwin or MSYS. Adding sudo to the commands would break those build. > > So it probably should be qualified for those platforms. > > But that apt is not supported on those platforms either. This is done per os in the docs. See https://nuttx.apache.org/docs/latest/quickstart/install.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9260: libc/misc: add Fdsan module
anchao commented on code in PR #9260: URL: https://github.com/apache/nuttx/pull/9260#discussion_r1193126783 ## libs/libc/dirent/lib_opendir.c: ## @@ -83,5 +91,12 @@ FAR DIR *opendir(FAR const char *path) } dir->fd = fd; + +#ifdef CONFIG_FDSAN + tag = android_fdsan_create_owner_tag(ANDROID_FDSAN_OWNER_TYPE_DIR, Review Comment: ``` #ifdef CONFIG_FDSAN android_fdsan_exchange_owner_tag(fd, 0, android_fdsan_create_owner_tag(ANDROID_FDSAN_OWNER_TYPE_DIR, (uintptr_t)dir)); #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9260: libc/misc: add Fdsan module
anchao commented on code in PR #9260: URL: https://github.com/apache/nuttx/pull/9260#discussion_r1193126783 ## libs/libc/dirent/lib_opendir.c: ## @@ -83,5 +91,12 @@ FAR DIR *opendir(FAR const char *path) } dir->fd = fd; + +#ifdef CONFIG_FDSAN + tag = android_fdsan_create_owner_tag(ANDROID_FDSAN_OWNER_TYPE_DIR, Review Comment: ``` #ifdef CONFIG_FDSAN android_fdsan_exchange_owner_tag(fd, 0, android_fdsan_create_owner_tag(ANDROID_FDSAN_OWNER_TYPE_DIR, (uintptr_t)dir);); #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9262: Add NewReno congestion control.
anchao commented on code in PR #9262:
URL: https://github.com/apache/nuttx/pull/9262#discussion_r1193124467
##
net/tcp/tcp.h:
##
@@ -71,7 +71,7 @@
# define TCP_WBPKTLEN(wrb) ((wrb)->wb_iob->io_pktlen)
# define TCP_WBSENT(wrb)((wrb)->wb_sent)
# define TCP_WBNRTX(wrb)((wrb)->wb_nrtx)
-#ifdef CONFIG_NET_TCP_FAST_RETRANSMIT
+#if defined(CONFIG_NET_TCP_FAST_RETRANSMIT) &&
!defined(CONFIG_NET_TCP_CC_NEWRENO)
# define TCP_WBNACK(wrb)((wrb)->wb_nack)
Review Comment:
Should we reuse the nack from connection instance and remove this member?
##
net/tcp/tcp_send_buffered.c:
##
@@ -614,11 +619,12 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
/* Do fast retransmit */
rexmitno = ackno;
-#endif
-
+#if !defined(CONFIG_NET_TCP_CC_NEWRENO)
Review Comment:
ifndef
##
net/tcp/tcp_cc.c:
##
@@ -0,0 +1,293 @@
+/
+ * net/tcp/tcp_cc.c
+ * Handling TCP congestion control
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include "tcp/tcp.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+/* Calculate the Initial Window, also used as Restart Window
+ * RFC5681 Section 3.1 specifies the default conservative values.
+ */
+
+#define CC_INIT_CWND(cwnd, mss) \
+ do { \
+ if ((mss) > 2190) \
+{ \
+ (cwnd) = 2 * (mss); \
+} \
+ else if ((mss) > 1095) \
Review Comment:
ditto
##
net/tcp/tcp_cc.c:
##
@@ -0,0 +1,293 @@
+/
+ * net/tcp/tcp_cc.c
+ * Handling TCP congestion control
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include "tcp/tcp.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+/* Calculate the Initial Window, also used as Restart Window
+ * RFC5681 Section 3.1 specifies the default conservative values.
+ */
+
+#define CC_INIT_CWND(cwnd, mss) \
+ do { \
+ if ((mss) > 2190) \
Review Comment:
magic number to marco
##
net/tcp/tcp_send_buffered.c:
##
@@ -584,6 +584,10 @@ static uint16_t psock_send_eventhandler(FAR struct
net_driver_s *dev,
}
else if (ackno == TCP_WBSEQNO(wrb))
{
+#ifdef CONFIG_NET_TCP_CC_NEWRENO
+ if ((flags & TCP_ACKDATA) != 0 &&
Review Comment:
why need to check TCP_ACKDATA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[GitHub] [nuttx] dok-net opened a new issue, #9270: Please add "sudo" to all Ubuntu Getting Started / Installing patterns
dok-net opened a new issue, #9270: URL: https://github.com/apache/nuttx/issues/9270 On Ubuntu, one doesn't log in as root, but uses "sudo". Only the very first "sudo apt install" instruction acknowledges this, the remaining setup instructions don't work copy without adding "sudo" manually. Maybe remove the "$" prompt and implement a "copy" icon, too, like on so many other sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
