[nuttx-apps] branch master updated: Indent the define statement by two spaces

2023-05-20 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new 7032c72f2 Indent the define statement by two spaces
7032c72f2 is described below

commit 7032c72f2f66c9cbe8d803bdd696b830f3f380b3
Author: Xiang Xiao 
AuthorDate: Sat May 20 06:39:53 2023 +0800

Indent the define statement by two spaces

follow the code style convention

Signed-off-by: Xiang Xiao 
---
 examples/calib_udelay/calib_udelay_main.c |   4 +-
 examples/mount/mount_main.c   |   6 +-
 examples/wgetjson/wgetjson_main.c |   6 +-
 fsutils/mkfatfs/fat32.h   | 242 +++---
 graphics/pdcurs34/include/curspriv.h  |   4 +-
 graphics/pdcurs34/nuttx/pdcdisp.c |   2 +-
 include/graphics/curses.h |  18 +--
 include/nshlib/nshlib.h   |   4 +-
 netutils/dhcpd/dhcpd.c|   6 +-
 netutils/netcat/netcat_main.c |   2 +-
 netutils/tftpc/tftpc_internal.h   |   4 +-
 netutils/webserver/httpd.c|   4 +-
 nshlib/nsh.h  |   4 +-
 nshlib/nsh_console.h  |   8 +-
 nshlib/nsh_netcmds.c  |   2 +-
 system/composite/composite_main.c |   2 +-
 system/i2c/i2ctool.h  |   2 +-
 system/spi/spitool.h  |   2 +-
 system/uorb/uORB/uORB.h   |   4 +-
 system/usbmsc/usbmsc_main.c   |   2 +-
 system/zmodem/host/debug.h|   8 +-
 system/zmodem/host/nuttx/compiler.h   | 226 ++--
 testing/ostest/ostest_main.c  |   2 +-
 wireless/gs2200m/gs2200m_main.c   |   4 +-
 24 files changed, 284 insertions(+), 284 deletions(-)

diff --git a/examples/calib_udelay/calib_udelay_main.c 
b/examples/calib_udelay/calib_udelay_main.c
index 9902c4b90..5f1abbf57 100644
--- a/examples/calib_udelay/calib_udelay_main.c
+++ b/examples/calib_udelay/calib_udelay_main.c
@@ -36,11 +36,11 @@
  /
 
 #ifndef CONFIG_EXAMPLES_CALIB_UDELAY_NUM_MEASUREMENTS
-# define CONFIG_EXAMPLES_CALIB_UDELAY_NUM_MEASUREMENTS 3
+#  define CONFIG_EXAMPLES_CALIB_UDELAY_NUM_MEASUREMENTS 3
 #endif
 
 #ifndef CONFIG_EXAMPLES_CALIB_UDELAY_NUM_RESULTS
-# define CONFIG_EXAMPLES_CALIB_UDELAY_NUM_RESULTS 20
+#  define CONFIG_EXAMPLES_CALIB_UDELAY_NUM_RESULTS 20
 #endif
 
 #define DELAY_TEST_ITERS 10
diff --git a/examples/mount/mount_main.c b/examples/mount/mount_main.c
index 30051d9b9..89c23da11 100644
--- a/examples/mount/mount_main.c
+++ b/examples/mount/mount_main.c
@@ -178,7 +178,7 @@ static void show_statfs(const char *path)
 }
 }
 #else
-# define show_statfs(p)
+#  define show_statfs(p)
 #endif
 
 /
@@ -227,7 +227,7 @@ static void show_directories(const char *path, int indent)
   closedir(dirp);
 }
 #else
-# define show_directories(p,i)
+#  define show_directories(p,i)
 #endif
 
 /
@@ -558,7 +558,7 @@ static void fail_stat(const char *path, int expectederror)
 }
 }
 #else
-# define fail_stat(p,e);
+#  define fail_stat(p,e);
 #endif
 
 /
diff --git a/examples/wgetjson/wgetjson_main.c 
b/examples/wgetjson/wgetjson_main.c
index 55a95a94d..4e2dbe38b 100644
--- a/examples/wgetjson/wgetjson_main.c
+++ b/examples/wgetjson/wgetjson_main.c
@@ -43,15 +43,15 @@
  /
 
 #ifndef CONFIG_EXAMPLES_WGETJSON_MAXSIZE
-# define CONFIG_EXAMPLES_WGETJSON_MAXSIZE 1024
+#  define CONFIG_EXAMPLES_WGETJSON_MAXSIZE 1024
 #endif
 
 #ifndef CONFIG_EXAMPLES_WGETJSON_URL
-# define CONFIG_EXAMPLES_WGETJSON_URL "http://10.0.0.1/wgetjson/json_cmd.php;
+#  define CONFIG_EXAMPLES_WGETJSON_URL "http://10.0.0.1/wgetjson/json_cmd.php;
 #endif
 
 #ifndef CONFIG_EXAMPLES_WGETPOST_URL
-# define CONFIG_EXAMPLES_WGETPOST_URL "http://10.0.0.1/wgetjson/post_cmd.php;
+#  define CONFIG_EXAMPLES_WGETPOST_URL "http://10.0.0.1/wgetjson/post_cmd.php;
 #endif
 
 #define MULTI_POST_NDATA 3
diff --git a/fsutils/mkfatfs/fat32.h b/fsutils/mkfatfs/fat32.h
index 96c6c96f7..d70b12301 100644
--- a/fsutils/mkfatfs/fat32.h
+++ b/fsutils/mkfatfs/fat32.h
@@ -274,31 +274,31 @@
 #   error "Illegal value for CONFIG_FAT_MAXFNAME"
 # endif
 
-# define LDIR_MAXLFNCHARS   13  /* Max unicode characters in one LFN entry */
-# define LDIR_MAXLFNS   20  /* Max number of LFN entries */
+#  define LDIR_MAXLFNCHARS   13  /* Max unicode characters in one LFN entry */
+#  define LDIR_MAXLFNS   20  /* Max number of LFN entries */
 
 /* LFN directory entry 

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1768: Indent the define statement by two spaces

2023-05-20 Thread via GitHub


pkarashchenko merged PR #1768:
URL: https://github.com/apache/nuttx-apps/pull/1768


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-website] branch asf-site updated: Publishing web: b5385572da9781727954ec9d98f5329c0d33acf2 docs: 1de1b8adb78701a20cdd0bb29b77d3cb4ee07c4a

2023-05-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 1ff6a0c9 Publishing web: b5385572da9781727954ec9d98f5329c0d33acf2 
docs: 1de1b8adb78701a20cdd0bb29b77d3cb4ee07c4a
1ff6a0c9 is described below

commit 1ff6a0c9bdee83458f254f400fb50de777d03686
Author: Brennan Ashton 
AuthorDate: Sun May 21 00:13:54 2023 +

Publishing web: b5385572da9781727954ec9d98f5329c0d33acf2 docs: 
1de1b8adb78701a20cdd0bb29b77d3cb4ee07c4a
---
 content/docs/10.0.0/index.html | 2 +-
 content/docs/10.0.0/searchindex.js | 2 +-
 content/docs/10.0.1/index.html | 2 +-
 content/docs/10.0.1/searchindex.js | 2 +-
 content/docs/10.1.0/index.html | 2 +-
 content/docs/10.1.0/searchindex.js | 2 +-
 content/docs/10.2.0/index.html | 2 +-
 content/docs/10.2.0/searchindex.js | 2 +-
 content/docs/10.3.0/index.html | 2 +-
 content/docs/10.3.0/searchindex.js | 2 +-
 content/docs/11.0.0/index.html | 2 +-
 content/docs/11.0.0/searchindex.js | 2 +-
 content/docs/12.0.0/index.html | 2 +-
 content/docs/12.0.0/searchindex.js | 2 +-
 content/docs/12.1.0/index.html | 2 +-
 content/docs/12.1.0/searchindex.js | 2 +-
 content/docs/latest/index.html | 2 +-
 content/docs/latest/searchindex.js | 2 +-
 content/feed.xml   | 4 ++--
 19 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 4ef3c7e9..d8850092 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -131,7 +131,7 @@ by following these 
 NuttX Documentation
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 20 May 23 at 14:16
+Last Updated: 21 May 23 at 00:10
 
 Table of 
Contents
 
diff --git a/content/docs/10.0.0/searchindex.js 
b/content/docs/10.0.0/searchindex.js
index 531960a8..21568108 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", "components/drivers/character/keypad", 
"components/drivers/character/pwm", "components/drivers/character/quadrature", 
"components/drivers/character/rtc", "components/drivers/character/serial", 
"components/drivers/character/timer", "components/drivers/chara [...]
\ No newline at end of file
+Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", "components/drivers/character/keypad", 
"components/drivers/character/pwm", "components/drivers/character/quadrature", 
"components/drivers/character/rtc", "components/drivers/character/serial", 
"components/drivers/character/timer", "components/drivers/chara [...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index c3616488..f45e2b91 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -147,7 +147,7 @@ by following these 
 NuttX Documentation
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 20 May 23 at 14:16
+Last Updated: 21 May 23 at 00:10
 
 Table of 
Contents
 
diff --git a/content/docs/10.0.1/searchindex.js 
b/content/docs/10.0.1/searchindex.js
index e62c1c17..8902ca8d 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
-Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", "components/drivers/character/keypad", 
"components/drivers/character/pwm", 

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1768: Indent the define statement by two spaces

2023-05-20 Thread via GitHub


xiaoxiang781216 opened a new pull request, #1768:
URL: https://github.com/apache/nuttx-apps/pull/1768

   ## Summary
   
   follow the code style convention
   
   ## Impact
   
   code refactor only
   
   ## Testing
   
   ci, please ignore mix case warning.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9352: Indent the define statement by two spaces

2023-05-20 Thread via GitHub


xiaoxiang781216 opened a new pull request, #9352:
URL: https://github.com/apache/nuttx/pull/9352

   ## Summary
   
   follow the code style convention
   
   ## Impact
   
   code refactor only
   
   ## Testing
   
   ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] fdcavalcanti commented on issue #9327: Tiva board won't boot when FPU is enabled

2023-05-20 Thread via GitHub


fdcavalcanti commented on issue #9327:
URL: https://github.com/apache/nuttx/issues/9327#issuecomment-1555956704

   Not sure, but I think that line on 'arm_saveusercontext.S' is after the hard 
fault happens. Using GDB, I can track all the way to 'tiva_configgpio' and as 
soon as it enters this function, it goes to a hard fault.
   Really can't see how enabling the FPU is causing this (because the FPU 
configuration comes after configuring those GPIOs!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: arch/nrf53: add SPI support

2023-05-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 1de1b8adb7 arch/nrf53: add SPI support
1de1b8adb7 is described below

commit 1de1b8adb78701a20cdd0bb29b77d3cb4ee07c4a
Author: raiden00pl 
AuthorDate: Mon Mar 13 13:04:09 2023 +0100

arch/nrf53: add SPI support
---
 arch/arm/src/nrf53/Kconfig |   46 ++
 arch/arm/src/nrf53/Make.defs   |4 +
 arch/arm/src/nrf53/nrf53_spi.c | 1500 
 arch/arm/src/nrf53/nrf53_spi.h |  165 +
 4 files changed, 1715 insertions(+)

diff --git a/arch/arm/src/nrf53/Kconfig b/arch/arm/src/nrf53/Kconfig
index b453a776dc..b720166f91 100644
--- a/arch/arm/src/nrf53/Kconfig
+++ b/arch/arm/src/nrf53/Kconfig
@@ -27,6 +27,7 @@ config NRF53_APPCORE
select NRF53_HAVE_SAADC
select NRF53_HAVE_UART1
select NRF53_HAVE_I2C123
+   select NRF53_HAVE_SPI1234
 
 config NRF53_NETCORE
bool
@@ -93,12 +94,20 @@ config NRF53_HAVE_I2C123
bool
default n
 
+config NRF53_HAVE_SPI1234
+   bool
+   default n
+
 # Peripheral Selection
 
 config NRF53_I2C_MASTER
bool
default n
 
+config NRF53_SPI_MASTER
+   bool
+   default n
+
 config NRF53_IPC
bool
default y if RPTUN
@@ -148,6 +157,43 @@ config NRF53_I2C2_MASTER
depends on NRF53_HAVE_I2C123
select NRF53_I2C_MASTER
 
+config NRF53_SPI0_MASTER
+   bool "SPI0 Master"
+   default n
+   select NRF53_SPI_MASTER
+
+if NRF53_HAVE_SPI1234
+
+config NRF53_SPI1_MASTER
+   bool "SPI1 Master"
+   default n
+   select NRF53_SPI_MASTER
+
+config NRF53_SPI2_MASTER
+   bool "SPI2 Master"
+   default n
+   select NRF53_SPI_MASTER
+
+config NRF53_SPI3_MASTER
+   bool "SPI3 Master"
+   default n
+   select NRF53_SPI_MASTER
+
+config NRF53_SPI4_MASTER
+   bool "SPI4 Master"
+   default n
+   select NRF53_SPI_MASTER
+
+endif # NRF53_HAVE_SPI1234
+
+if NRF53_SPI_MASTER
+
+config NRF53_SPI_MASTER_INTERRUPTS
+   bool "SPI Master interrupts support"
+   default n
+
+endif
+
 config NRF53_UART0
bool "UART0"
default n
diff --git a/arch/arm/src/nrf53/Make.defs b/arch/arm/src/nrf53/Make.defs
index b3f43c16a7..0227178801 100644
--- a/arch/arm/src/nrf53/Make.defs
+++ b/arch/arm/src/nrf53/Make.defs
@@ -79,6 +79,10 @@ ifeq ($(CONFIG_NRF53_RTC),y)
 CHIP_CSRCS += nrf53_rtc.c
 endif
 
+ifeq ($(CONFIG_NRF53_SPI_MASTER),y)
+CHIP_CSRCS += nrf53_spi.c
+endif
+
 ifeq ($(CONFIG_PM),y)
 CHIP_CSRCS += nrf53_pminitialize.c
 endif
diff --git a/arch/arm/src/nrf53/nrf53_spi.c b/arch/arm/src/nrf53/nrf53_spi.c
new file mode 100644
index 00..1759835e71
--- /dev/null
+++ b/arch/arm/src/nrf53/nrf53_spi.c
@@ -0,0 +1,1500 @@
+/
+ * arch/arm/src/nrf53/nrf53_spi.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "arm_internal.h"
+#include "barriers.h"
+
+#include "nrf53_gpio.h"
+#include "nrf53_spi.h"
+
+#include "hardware/nrf53_spi.h"
+
+/
+ * Private Types
+ /
+
+struct nrf53_spidev_s
+{
+  struct spi_dev_s spidev; /* Externally visible part of the SPI interface 
*/
+  uint32_t base;   /* Base address of SPI register */
+#ifdef CONFIG_NRF53_SPI_MASTER_INTERRUPTS
+  uint32_t irq;/* SPI IRQ number */
+#endif
+  nrf53_pinset_t   sck_pin;/* SCK pin configuration */
+  uint32_t frequency;  /* Requested clock frequency */
+  uint8_t  mode;   /* Mode 0,1,2,3 

[GitHub] [nuttx] btashton merged pull request #9351: arch/nrf53: add SPI support ported from nrf52

2023-05-20 Thread via GitHub


btashton merged PR #9351:
URL: https://github.com/apache/nuttx/pull/9351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on issue #9327: Tiva board won't boot when FPU is enabled

2023-05-20 Thread via GitHub


acassis commented on issue #9327:
URL: https://github.com/apache/nuttx/issues/9327#issuecomment-1555946428

   Thank you for reporting this issue!
   
   @gustavonihei and @qinwei2004 I think you both have much experience with FPU 
issues, any idea why it is happening on TIVA? 
   The issue seems to happening during the registers copy (FPU Stacking).
   
   @fdcavalcanti maybe you can open a question on TI forum asking why this 
issue is only happening on their chip, really strange.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on issue #9349: "C++ Example using CMake" in latest documentation and main branch is broken

2023-05-20 Thread via GitHub


acassis commented on issue #9349:
URL: https://github.com/apache/nuttx/issues/9349#issuecomment-1555945158

   @dok-net thank you for reporting the issue. This Guide was written by 
@fraviofii ! I'll ask him to review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on issue #9350: Is it there a runnable version of sqlite on NuttX ?

2023-05-20 Thread via GitHub


acassis commented on issue #9350:
URL: https://github.com/apache/nuttx/issues/9350#issuecomment-1555944361

   @GooTal yes, it was a FAE from Microchip that did the port many years ago. 
He shared the port with me and I tried to update it for a new version. It still 
needs some improvement to integrate on mainline. I'm attaching here the patches 
that I was testing on ESP32 in 2021:
   
   
[0001-apps-Add-SQLite-support-on-NuttX.zip](https://github.com/apache/nuttx/files/11522729/0001-apps-Add-SQLite-support-on-NuttX.zip)
   
[0001-esp32-devkitc-Add-board-config-to-sqlite.zip](https://github.com/apache/nuttx/files/11522731/0001-esp32-devkitc-Add-board-config-to-sqlite.zip)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] branch master updated: support memdump can dump by seq number

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new e68d5ffb9 support memdump can dump by seq number
e68d5ffb9 is described below

commit e68d5ffb98a0d84410cce36e60d8f3c24e67605f
Author: anjiahao 
AuthorDate: Tue May 9 12:06:05 2023 +0800

support memdump can dump by seq number

Signed-off-by: anjiahao 
---
 nshlib/nsh_command.c |  3 ++-
 nshlib/nsh_mmcmds.c  | 15 ---
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/nshlib/nsh_command.c b/nshlib/nsh_command.c
index a137f4d2b..930e7f8a0 100644
--- a/nshlib/nsh_command.c
+++ b/nshlib/nsh_command.c
@@ -224,7 +224,8 @@ static const struct cmdmap_s g_cmdmap[] =
 
 #ifdef CONFIG_DEBUG_MM
 # ifndef CONFIG_NSH_DISABLE_MEMDUMP
-  { "memdump",  cmd_memdump,  1, 3, "[pid/used/free/on/off]" },
+  { "memdump",  cmd_memdump,  1, 4, "[pid/used/free/on/off]"
+"  "},
 # endif
 #endif
 
diff --git a/nshlib/nsh_mmcmds.c b/nshlib/nsh_mmcmds.c
index 8f5953a99..0b25becb0 100644
--- a/nshlib/nsh_mmcmds.c
+++ b/nshlib/nsh_mmcmds.c
@@ -56,11 +56,20 @@ int cmd_free(FAR struct nsh_vtbl_s *vtbl, int argc, FAR 
char **argv)
 
 int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
 {
-  FAR const char *arg = "used";
+  char arg[CONFIG_NSH_LINELEN] = "";
+  int i;
 
-  if (argc > 1)
+  if (argc == 1)
 {
-  arg = argv[1];
+  strlcpy(arg, "used", CONFIG_NSH_LINELEN);
+}
+  else
+{
+  for (i = 1; i < argc; i++)
+{
+  strlcat(arg, argv[i], CONFIG_NSH_LINELEN);
+  strlcat(arg, " ", CONFIG_NSH_LINELEN);
+}
 }
 
   return nsh_writefile(vtbl, argv[0], arg, strlen(arg),



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1766: support memdump can dump by seq number

2023-05-20 Thread via GitHub


xiaoxiang781216 merged PR #1766:
URL: https://github.com/apache/nuttx-apps/pull/1766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9309: Fix misc issues in code

2023-05-20 Thread via GitHub


pkarashchenko commented on code in PR #9309:
URL: https://github.com/apache/nuttx/pull/9309#discussion_r1199628100


##
drivers/mtd/w25qxxxjv.c:
##
@@ -628,14 +626,9 @@ static void w25qxxxjv_write_disable(FAR struct 
w25qxxxjv_dev_s *priv)
 
 static void w25qxxxjv_set_die(FAR struct w25qxxxjv_dev_s *priv, uint8_t die)
 {
-  char buff[1] =
-{
-  die,
-};
-
   w25qxxxjv_write_enable(priv);
   w25qxxxjv_command_write(priv->qspi, W25QXXXJV_SW_DIE_SELECT,
-  (FAR const void *)buff, 1);
+  (FAR const void *), 1);

Review Comment:
   Yes. That is true, but `buf[1]` on stack will (most probably) give you 
proper alignment implicitly and that could give you an unexpected behavior in 
future.
   I will be able to take a look here on Monday and provide a proper fix (that 
will be to use a union for `uint32_t` and 4 bytes `uint8_t` array, so it will 
ensure that address will be properly aligned, or explicit usage of align_data 
attribute).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] TimJTi commented on pull request #9342: GD25 Flash memory - performance enhancements

2023-05-20 Thread via GitHub


TimJTi commented on PR #9342:
URL: https://github.com/apache/nuttx/pull/9342#issuecomment-1555933970

   > Sorry @TimJTi did not mean to remove the draft status. Clicked the wrong 
button when reviewing. 
   
   No problem!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] raiden00pl opened a new pull request, #9351: arch/nrf53: add SPI support ported from nrf52

2023-05-20 Thread via GitHub


raiden00pl opened a new pull request, #9351:
URL: https://github.com/apache/nuttx/pull/9351

   ## Summary
   - arch/nrf53: add SPI support
   
   ## Impact
   
   ## Testing
   thingy53 + BMI270 sensor over SPI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-testing] btashton closed pull request #59: Update CI Docker Image to use GitHub Container Registery

2023-05-20 Thread via GitHub


btashton closed pull request #59: Update CI Docker Image to use GitHub 
Container Registery
URL: https://github.com/apache/nuttx-testing/pull/59


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] btashton commented on pull request #9342: GD25 Flash memory - performance enhancements

2023-05-20 Thread via GitHub


btashton commented on PR #9342:
URL: https://github.com/apache/nuttx/pull/9342#issuecomment-1555924223

   Sorry @TimJTi did not mean to remove the draft status. Clicked the wrong 
button when reviewing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: openamp: decoupling the transport layer and virtio device layer

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 1f4b71d576 openamp: decoupling the transport layer and virtio device 
layer
1f4b71d576 is described below

commit 1f4b71d5760f24a9870959e063ae94a06a2dfa64
Author: wangbowen6 
AuthorDate: Sat May 20 18:41:15 2023 +0800

openamp: decoupling the transport layer and virtio device layer

Patch 17:
virtio: follow virtio 1.2 spec, add more virtio status and device

Patch 18:
virtio: decoupling the transport layer and virtio device layer

1. Add virtio device api to decouple the transport layer and virtio
   device layer.
2. Move the vrings info and virtqueue allocation/free  to the
   remoteproc transport layer;
3. Because 2, modify the rpmsg device also;

Signed-off-by: wangbowen6 
---
 ...ow-virtio-1.2-spec-add-more-virtio-status.patch |  93 +++
 ...upling-the-transport-layer-and-virtio-dev.patch | 635 +
 openamp/open-amp.defs  |   2 +
 3 files changed, 730 insertions(+)

diff --git 
a/openamp/0017-virtio-follow-virtio-1.2-spec-add-more-virtio-status.patch 
b/openamp/0017-virtio-follow-virtio-1.2-spec-add-more-virtio-status.patch
new file mode 100644
index 00..bc6eaef94a
--- /dev/null
+++ b/openamp/0017-virtio-follow-virtio-1.2-spec-add-more-virtio-status.patch
@@ -0,0 +1,93 @@
+From 61a7811f09b529341351c19ce1644b7e790daa5f Mon Sep 17 00:00:00 2001
+From: wangbowen6 
+Date: Tue, 9 May 2023 11:30:09 +0800
+Subject: [PATCH 1/2] virtio: follow virtio 1.2 spec, add more virtio status
+ and device
+
+Signed-off-by: wangbowen6 
+---
+ lib/include/openamp/virtio.h | 37 ++--
+ lib/virtio/virtio.c  | 14 ++
+ 2 files changed, 41 insertions(+), 10 deletions(-)
+
+diff --git a/lib/include/openamp/virtio.h open-amp/lib/include/openamp/virtio.h
+index 0303a5b..3001a06 100644
+--- a/lib/include/openamp/virtio.h
 open-amp/lib/include/openamp/virtio.h
+@@ -15,21 +15,38 @@ extern "C" {
+ #endif
+ 
+ /* VirtIO device IDs. */
+-#define VIRTIO_ID_NETWORK0x01UL
+-#define VIRTIO_ID_BLOCK  0x02UL
+-#define VIRTIO_ID_CONSOLE0x03UL
+-#define VIRTIO_ID_ENTROPY0x04UL
+-#define VIRTIO_ID_BALLOON0x05UL
+-#define VIRTIO_ID_IOMEMORY   0x06UL
+-#define VIRTIO_ID_RPMSG  0x07UL /* remote processor messaging */
+-#define VIRTIO_ID_SCSI   0x08UL
+-#define VIRTIO_ID_9P 0x09UL
+-#define VIRTIO_DEV_ANY_ID(-1)UL
++#define VIRTIO_ID_NETWORK  1UL
++#define VIRTIO_ID_BLOCK2UL
++#define VIRTIO_ID_CONSOLE  3UL
++#define VIRTIO_ID_ENTROPY  4UL
++#define VIRTIO_ID_BALLOON  5UL
++#define VIRTIO_ID_IOMEMORY 6UL
++#define VIRTIO_ID_RPMSG7UL /* remote processor messaging */
++#define VIRTIO_ID_SCSI 8UL
++#define VIRTIO_ID_9P   9UL
++#define VIRTIO_ID_RPROC_SERIAL 11UL
++#define VIRTIO_ID_GPU  16UL
++#define VIRTIO_ID_INPUT18UL
++#define VIRTIO_ID_VSOCK19UL
++#define VIRTIO_ID_CRYPTO   20UL
++#define VIRTIO_ID_IOMMU23UL
++#define VIRTIO_ID_MEM  24UL
++#define VIRTIO_ID_SOUND25UL
++#define VIRTIO_ID_FS   26UL
++#define VIRTIO_ID_PMEM 27UL
++#define VIRTIO_ID_RPMB 28UL
++#define VIRTIO_ID_SCMI 32UL
++#define VIRTIO_ID_I2C_ADAPTER  34UL
++#define VIRTIO_ID_BT   40UL
++#define VIRTIO_ID_GPIO 41UL
++#define VIRTIO_DEV_ANY_ID  -1UL
+ 
+ /* Status byte for guest to report progress. */
++#define VIRTIO_CONFIG_STATUS_RESET 0x00
+ #define VIRTIO_CONFIG_STATUS_ACK   0x01
+ #define VIRTIO_CONFIG_STATUS_DRIVER0x02
+ #define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04
++#define VIRTIO_CONFIG_FEATURES_OK  0x08
+ #define VIRTIO_CONFIG_STATUS_NEEDS_RESET 0x40
+ #define VIRTIO_CONFIG_STATUS_FAILED0x80
+ 
+diff --git a/lib/virtio/virtio.c open-amp/lib/virtio/virtio.c
+index d205784..d25aec3 100644
+--- a/lib/virtio/virtio.c
 open-amp/lib/virtio/virtio.c
+@@ -26,6 +26,20 @@ static const struct virtio_ident {
+   VIRTIO_ID_IOMEMORY, "IOMemory"}, {
+   VIRTIO_ID_SCSI, "SCSI"}, {
+   VIRTIO_ID_9P, "9P Transport"}, {
++  VIRTIO_ID_GPU, "GPU"}, {
++  VIRTIO_ID_INPUT, "Input"}, {
++  VIRTIO_ID_VSOCK, "Vsock Transport"}, {
++  VIRTIO_ID_CRYPTO, "Crypto"}, {
++  VIRTIO_ID_IOMMU, "IOMMU"}, {
++  VIRTIO_ID_MEM, "Memory"}, {
++  VIRTIO_ID_SOUND, "Sound"}, {
++  VIRTIO_ID_FS, "File System"}, {
++  VIRTIO_ID_PMEM, "Pmem"}, {
++  VIRTIO_ID_RPMB, "RPMB"}, {
++  VIRTIO_ID_SCMI, "SCMI"}, {
++  VIRTIO_ID_I2C_ADAPTER, "I2C Adapter"}, {
++  VIRTIO_ID_BT, "Bluetooth"}, {
++  VIRTIO_ID_GPIO, "GPIO" }, {
+   0, NULL}
+ };
+ 
+-- 
+2.25.1
+
diff --git 

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9348: openamp: decoupling the transport layer and virtio device layer

2023-05-20 Thread via GitHub


xiaoxiang781216 merged PR #9348:
URL: https://github.com/apache/nuttx/pull/9348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] GooTal opened a new issue, #9350: Is it there a runnable version of sqlite on NuttX ?

2023-05-20 Thread via GitHub


GooTal opened a new issue, #9350:
URL: https://github.com/apache/nuttx/issues/9350

   Hi, i notice that a lady or gentleman [ported sqlite to 
NuttX](https://nuttx.yahoogroups.narkive.com/kMS1Y0mL/porting-sqlite-to-undefined-reference-to-utimes-and-ftruncate)
 5 years ago. But it seems some problems occurred.
   
   I wonder if it\`s possbile to run sqlite on NuttX. Specifically, on 
rv-virt:knsh64 or rv-virt:nsh64 build of NuttX.
   
   Is it possible to read/write files using semihosting(on qemu) both on kernel 
build and flat build?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] dok-net opened a new issue, #9349: "C++ Example using CMake" in latest documentation and main branch is broken

2023-05-20 Thread via GitHub


dok-net opened a new issue, #9349:
URL: https://github.com/apache/nuttx/issues/9349

   https://nuttx.apache.org/docs/latest/guides/cpp_cmake.html states:
   ```
   Using the ‘build as a library’ procedure of NuttX, it is possible to build 
NuttX applications using C++ language and also the cmake build tool.
   ```
   
   This is not correct, at least on Ubuntu "jammy" or "" (toolchain `Ubuntu 
(deb)` as per `Installing/Toolchain`).
   Using pristine git checkouts (but "download stable release" fares no 
better), plus `make distclean`, then following the instructions to the word, 
there are multiple obvious issues.
   The include files `cstdio` and `string` are not found.
   The exported tar archive does not contain the libs board, gcc (IIRC), supc++.
   
   At least the `sim` target should be supported for this out-of-tree 
CMake-based build procedure and documented in the step-by-step tutorial style.
   
   With the later C++ releases, more exactly the standard library, I think they 
are a great showcase for the POSIX support in NUTTX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] CV-Bowen opened a new pull request, #9348: openamp: decoupling the transport layer and virtio device layer

2023-05-20 Thread via GitHub


CV-Bowen opened a new pull request, #9348:
URL: https://github.com/apache/nuttx/pull/9348

   ## Summary
   Patch 17:
   virtio: follow virtio 1.2 spec, add more virtio status and device
   
   Patch 18:
   virtio: decoupling the transport layer and virtio device layer
   
   1. Add virtio device api to decouple the transport layer and virtio device 
layer.
   2. Move the vrings info and virtqueue allocation/free  to the remoteproc 
transport layer;
   3. Because 2, modify the rpmsg device also;
   
   This PR is need by [#9297](https://github.com/apache/nuttx/pull/9297)
   
   ## Impact
   RPTUN
   
   ## Testing
   sim:rpserver and sim:rpproxy
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated (14d311ca0a -> b4a6c63d47)

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 14d311ca0a docs: Add copy button for code blocks
 new cd92cf4496 kinetis:edma {s|d}last needs to be total xfer size
 new 280bf95d8a s32k1xx:edma {s|d}last needs to be total xfer size
 new b4a6c63d47 s32k3xx:edma {s|d}last needs to be total xfer size

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 arch/arm/src/kinetis/kinetis_edma.c | 7 +--
 arch/arm/src/s32k1xx/s32k1xx_edma.c | 6 --
 arch/arm/src/s32k3xx/s32k3xx_edma.c | 7 +--
 3 files changed, 14 insertions(+), 6 deletions(-)



[nuttx] 01/03: kinetis:edma {s|d}last needs to be total xfer size

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit cd92cf44969bf4e178283fba34d972956c9a2a3e
Author: David Sidrane 
AuthorDate: Sat May 20 00:24:44 2023 -0700

kinetis:edma {s|d}last needs to be total xfer size
---
 arch/arm/src/kinetis/kinetis_edma.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/src/kinetis/kinetis_edma.c 
b/arch/arm/src/kinetis/kinetis_edma.c
index c2da8d2e45..753b719348 100644
--- a/arch/arm/src/kinetis/kinetis_edma.c
+++ b/arch/arm/src/kinetis/kinetis_edma.c
@@ -364,7 +364,9 @@ static inline void kinetis_tcd_configure(struct 
kinetis_edmatcd_s *tcd,
   tcd->attr = EDMA_TCD_ATTR_SSIZE(config->ssize) |  /* Transfer Attributes 
*/
   EDMA_TCD_ATTR_DSIZE(config->dsize);
   tcd->nbytes   = config->nbytes;
-  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ? -config->iter : 0;
+  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ?
+  -(config->iter * config->nbytes) : 0;
+
   tcd->daddr= config->daddr;
   tcd->doff = config->doff;
   tcd->citer= config->iter & EDMA_TCD_CITER_CITER_MASK;
@@ -373,7 +375,8 @@ static inline void kinetis_tcd_configure(struct 
kinetis_edmatcd_s *tcd,
   0 : EDMA_TCD_CSR_DREQ;
   tcd->csr |= config->flags & EDMA_CONFIG_INTHALF ?
   EDMA_TCD_CSR_INTHALF : 0;
-  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ? -config->iter : 0;
+  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ?
+  -(config->iter * config->nbytes) : 0;
 
   /* And special case flags */
 



[nuttx] 02/03: s32k1xx:edma {s|d}last needs to be total xfer size

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 280bf95d8a4592ba894b038557175171b6be6fd3
Author: David Sidrane 
AuthorDate: Sat May 20 00:25:20 2023 -0700

s32k1xx:edma {s|d}last needs to be total xfer size
---
 arch/arm/src/s32k1xx/s32k1xx_edma.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/src/s32k1xx/s32k1xx_edma.c 
b/arch/arm/src/s32k1xx/s32k1xx_edma.c
index 8e3077bdc3..de875e99c1 100644
--- a/arch/arm/src/s32k1xx/s32k1xx_edma.c
+++ b/arch/arm/src/s32k1xx/s32k1xx_edma.c
@@ -362,7 +362,8 @@ static inline void s32k1xx_tcd_configure(struct 
s32k1xx_edmatcd_s *tcd,
   tcd->attr = EDMA_TCD_ATTR_SSIZE(config->ssize) |  /* Transfer Attributes 
*/
   EDMA_TCD_ATTR_DSIZE(config->dsize);
   tcd->nbytes   = config->nbytes;
-  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ?  -config->iter : 0;
+  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ?
+  -(config->iter * config->nbytes) : 0;
   tcd->daddr= config->daddr;
   tcd->doff = config->doff;
   tcd->citer= config->iter & EDMA_TCD_CITER_CITER_MASK;
@@ -371,7 +372,8 @@ static inline void s32k1xx_tcd_configure(struct 
s32k1xx_edmatcd_s *tcd,
   0 : EDMA_TCD_CSR_DREQ;
   tcd->csr  |= config->flags & EDMA_CONFIG_INTHALF ?
   EDMA_TCD_CSR_INTHALF : 0;
-  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ?  -config->iter : 0;
+  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ?
+  -(config->iter * config->nbytes) : 0;
 
   /* And special case flags */
 



[nuttx] 03/03: s32k3xx:edma {s|d}last needs to be total xfer size

2023-05-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit b4a6c63d4738e01cc78931ada1411379c745adae
Author: David Sidrane 
AuthorDate: Sat May 20 00:25:36 2023 -0700

s32k3xx:edma {s|d}last needs to be total xfer size
---
 arch/arm/src/s32k3xx/s32k3xx_edma.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/src/s32k3xx/s32k3xx_edma.c 
b/arch/arm/src/s32k3xx/s32k3xx_edma.c
index 9c94b76f80..053c52c7ca 100644
--- a/arch/arm/src/s32k3xx/s32k3xx_edma.c
+++ b/arch/arm/src/s32k3xx/s32k3xx_edma.c
@@ -616,7 +616,9 @@ static inline void s32k3xx_tcd_configure(struct 
s32k3xx_edmatcd_s *tcd,
EDMA_TCD_ATTR_DMOD(config->dmod);
 #endif
   tcd->nbytes   = config->nbytes;
-  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ? -config->iter : 0;
+  tcd->slast= config->flags & EDMA_CONFIG_LOOPSRC ?
+  -(config->iter * config->nbytes) : 0;
+
   tcd->daddr= config->daddr;
   tcd->doff = config->doff;
   tcd->citer= config->iter & EDMA_TCD_CITER_MASK;
@@ -625,7 +627,8 @@ static inline void s32k3xx_tcd_configure(struct 
s32k3xx_edmatcd_s *tcd,
   0 : EDMA_TCD_CSR_DREQ;
   tcd->csr |= config->flags & EDMA_CONFIG_INTHALF ?
   EDMA_TCD_CSR_INTHALF : 0;
-  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ? -config->iter : 0;
+  tcd->dlastsga = config->flags & EDMA_CONFIG_LOOPDEST ?
+  -(config->iter * config->nbytes) : 0;
 
 #ifdef CONFIG_S32K3XX_DTCM_HEAP
   /* Remap address to backdoor address for eDMA */



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9346: kinetis s32k1 s32k3:edma {s|d}last needs to be total xfer size

2023-05-20 Thread via GitHub


xiaoxiang781216 merged PR #9346:
URL: https://github.com/apache/nuttx/pull/9346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9347: fs/partition: register partition device if caller doesn't provide handler

2023-05-20 Thread via GitHub


xiaoxiang781216 opened a new pull request, #9347:
URL: https://github.com/apache/nuttx/pull/9347

   ## Summary
   
   to avoid the duplication of common logic
   
   ## Impact
   
   New function
   
   ## Testing
   
   sim:mtdpart
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] michallenc commented on a diff in pull request #9309: Fix misc issues in code

2023-05-20 Thread via GitHub


michallenc commented on code in PR #9309:
URL: https://github.com/apache/nuttx/pull/9309#discussion_r1199581562


##
drivers/mtd/w25qxxxjv.c:
##
@@ -628,14 +626,9 @@ static void w25qxxxjv_write_disable(FAR struct 
w25qxxxjv_dev_s *priv)
 
 static void w25qxxxjv_set_die(FAR struct w25qxxxjv_dev_s *priv, uint8_t die)
 {
-  char buff[1] =
-{
-  die,
-};
-
   w25qxxxjv_write_enable(priv);
   w25qxxxjv_command_write(priv->qspi, W25QXXXJV_SW_DIE_SELECT,
-  (FAR const void *)buff, 1);
+  (FAR const void *), 1);

Review Comment:
   It seems it is this assertion 
https://github.com/apache/nuttx/blob/master/arch/arm/src/samv7/sam_qspi.c#L1401 
that is raised when `` is used. So some alignment problem will be there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] davids5 opened a new pull request, #9346: kinetis s32k1 s32k3:edma {s|d}last needs to be total xfer size

2023-05-20 Thread via GitHub


davids5 opened a new pull request, #9346:
URL: https://github.com/apache/nuttx/pull/9346

   ## Summary
   
   As reported in https://github.com/apache/nuttx/pull/9324 for the imxrt
   
   The edma  slast and dlast calculation needs to be total xfer size
   
## Impact
   
   DMA with TCDn_CITER or  TCDn_BITER not set to 1 would not reset the 
{s|d}last to the correct location.
   
   ## Testing
   
   Inspection
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org