[GitHub] [nuttx] jerpelea merged pull request #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full

2023-07-13 Thread via GitHub


jerpelea merged PR #9792:
URL: https://github.com/apache/nuttx/pull/9792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: net/udp: Fix the bug of overwriting when the udp recv buffer is full

2023-07-13 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new a7926405ca net/udp: Fix the bug of overwriting when the udp recv 
buffer is full
a7926405ca is described below

commit a7926405cafca178e137fbae05290c0f8a38cd51
Author: wangyingdong 
AuthorDate: Thu Jun 8 10:50:53 2023 +0800

net/udp: Fix the bug of overwriting when the udp recv buffer is full

Signed-off-by: wangyingdong 
---
 net/udp/udp_callback.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/udp/udp_callback.c b/net/udp/udp_callback.c
index f353bb32b1..6ccf330cd2 100644
--- a/net/udp/udp_callback.c
+++ b/net/udp/udp_callback.c
@@ -75,13 +75,13 @@ static uint16_t udp_datahandler(FAR struct net_driver_s 
*dev,
   uint8_t offset = 0;
 
 #if CONFIG_NET_RECV_BUFSIZE > 0
-  while (iob_get_queue_size(>readahead) > conn->rcvbufs)
+  if (iob_get_queue_size(>readahead) > conn->rcvbufs)
 {
-  iob = iob_remove_queue(>readahead);
-  iob_free_chain(iob);
+  netdev_iob_release(dev);
 #ifdef CONFIG_NET_STATISTICS
   g_netstats.udp.drop++;
 #endif
+  return 0;
 }
 #endif
 



[nuttx] branch master updated: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 0b69731a97 netdev/upperhalf:  fix visual studio Compiler Error C2059
0b69731a97 is described below

commit 0b69731a97ae0db2bfcd66fbc2e6fdcb479af4fe
Author: chao an 
AuthorDate: Thu Jul 13 22:59:45 2023 +0800

netdev/upperhalf:  fix visual studio Compiler Error C2059

D:\archer\code\nuttx\drivers\net\netdev_upperhalf.c(557,5): error C2059: 
syntax error : '{'

Compiler error C2059:
The token caused a syntax error.

Reference:

https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2059?view=msvc-170
Signed-off-by: chao an 
---
 drivers/net/netdev_upperhalf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/netdev_upperhalf.c b/drivers/net/netdev_upperhalf.c
index 9a5e2c544a..aa027c9772 100644
--- a/drivers/net/netdev_upperhalf.c
+++ b/drivers/net/netdev_upperhalf.c
@@ -552,9 +552,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   int ret = -ENOTTY; /* Default to ENOTTY to indicate not serving. */
   FAR struct iwreq *iwr = (FAR struct iwreq *)arg;
   FAR const struct wireless_ops_s *ops = lower->iw_ops;
-  const struct ether_addr zero =
-{
-};
+  struct ether_addr zero;
 
   /* Decode and dispatch the driver-specific IOCTL command */
 
@@ -618,6 +616,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   case SIOCSIWAP: /* Set access point MAC addresses */
 if (ops->bssid)
   {
+memset(, 0, sizeof(zero));
 if (memcmp(iwr->u.ap_addr.sa_data, , sizeof(zero)) != 0)
   {
 ret = ops->bssid(lower, iwr, true);



[GitHub] [nuttx] jerpelea merged pull request #9817: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread via GitHub


jerpelea merged PR #9817:
URL: https://github.com/apache/nuttx/pull/9817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: rpmsgblk: get return value from header

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 2ebc8aff16 rpmsgblk: get return value from header
2ebc8aff16 is described below

commit 2ebc8aff160bb3141c872a8b8aead8938bdcb99e
Author: liaoao 
AuthorDate: Wed Jul 12 20:48:14 2023 +0800

rpmsgblk: get return value from header

cookie->result as the return value of rpmsg operations,
it should get from remote response.

Signed-off-by: liaoao 
---
 drivers/misc/rpmsgblk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/rpmsgblk.c b/drivers/misc/rpmsgblk.c
index d54b1ebf35..9448251472 100644
--- a/drivers/misc/rpmsgblk.c
+++ b/drivers/misc/rpmsgblk.c
@@ -838,6 +838,7 @@ static int rpmsgblk_geometry_handler(FAR struct 
rpmsg_endpoint *ept,
   (FAR struct rpmsgblk_cookie_s *)(uintptr_t)header->cookie;
   FAR struct rpmsgblk_geometry_s *rsp = data;
 
+  cookie->result = header->result;
   if (cookie->result >= 0 && rsp->arglen > 0)
 {
   memcpy(cookie->data, rsp->buf, rsp->arglen);
@@ -874,6 +875,7 @@ static int rpmsgblk_ioctl_handler(FAR struct rpmsg_endpoint 
*ept,
   (FAR struct rpmsgblk_cookie_s *)(uintptr_t)header->cookie;
   FAR struct rpmsgblk_ioctl_s *rsp = data;
 
+  cookie->result = header->result;
   if (cookie->result >= 0 && rsp->arglen > 0)
 {
   memcpy(cookie->data, rsp->buf, rsp->arglen);



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9825: rpmsgblk: get return value from header

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9825:
URL: https://github.com/apache/nuttx/pull/9825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anjiahao1 commented on pull request #9706: libs/libc:Add support for gdb rsp protocol

2023-07-13 Thread via GitHub


anjiahao1 commented on PR #9706:
URL: https://github.com/apache/nuttx/pull/9706#issuecomment-1635226879

   > @anjiahao1 please normalize your config:
   > 
   > ```
   > /github/workspace/sources/nuttx/tools/testbuild.sh: line 338: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
   >   Normalize stm32f429i-disco/gdbstub
   > 55d54
   > < CONFIG_SYSTEM_GDBSTUB=y
   > ```
   
   
![image](https://github.com/apache/nuttx/assets/75056955/f521bb65-8604-4fb7-b7dd-571d40471f6e)
   
   i use clang in local,compiled successfully
   
![image](https://github.com/apache/nuttx/assets/75056955/e5799f67-b2c5-478d-940d-ea2797182270)
   
   
   looks like a problem with ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] leo11261 opened a new pull request, #9825: rpmsgblk: get return value from header

2023-07-13 Thread via GitHub


leo11261 opened a new pull request, #9825:
URL: https://github.com/apache/nuttx/pull/9825

   ## Summary
   cookie->result as the return value of rpmsg operations, it should get from 
remote response.
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao commented on a diff in pull request #9817: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread via GitHub


anchao commented on code in PR #9817:
URL: https://github.com/apache/nuttx/pull/9817#discussion_r1263234954


##
drivers/net/netdev_upperhalf.c:
##
@@ -554,6 +554,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   FAR const struct wireless_ops_s *ops = lower->iw_ops;
   const struct ether_addr zero =
 {
+  0

Review Comment:
   change to clean on use



##
drivers/net/netdev_upperhalf.c:
##
@@ -554,6 +554,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   FAR const struct wireless_ops_s *ops = lower->iw_ops;
   const struct ether_addr zero =
 {
+  0

Review Comment:
   change to clean on use



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] leo11261 opened a new pull request, #9824: assert: check intstack_sp when print last stack in irq context

2023-07-13 Thread via GitHub


leo11261 opened a new pull request, #9824:
URL: https://github.com/apache/nuttx/pull/9824

   ## Summary
   1、correct arguement of up_getusrsp
   2、move up_getusrsp to line 247, therefore, tcbstack can be printed
   correctly when sp is not within irq nor within tcbstack.
   3、check tcbstack from up_getusrsp
   4、remove force arguement for dump_stack
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] leo11261 opened a new pull request, #9822: rpmsg: use workqueue for rpmsgdev poll notify

2023-07-13 Thread via GitHub


leo11261 opened a new pull request, #9822:
URL: https://github.com/apache/nuttx/pull/9822

   ## Summary
   use workqueue for rpmsgdev poll notify to prevent
   calling rpmsgdev_poll_cb in interrupt context which will try to hold mutex 
in rpmsg_send
   
   ## Impact
   rpmsgdev
   
   ## Testing
   rpmsgdev test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] DannyPlusPlus commented on a diff in pull request #9798: add refcnt using epoll_create to fix bug when use popen which dup the fd and close at end after epoll_create

2023-07-13 Thread via GitHub


DannyPlusPlus commented on code in PR #9798:
URL: https://github.com/apache/nuttx/pull/9798#discussion_r1263213683


##
fs/vfs/fs_epoll.c:
##
@@ -246,6 +246,8 @@ static int epoll_do_create(int size, int flags)
   list_add_tail(>free, [i].node);
 }
 
+  eph->crefs++;

Review Comment:
   eph->crefs init val is zero, eph->crefs = 1 is the same as eph->crefs++



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: net/local: Support the abstract path to connect

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 7544b68aa9 net/local: Support the abstract path to connect
7544b68aa9 is described below

commit 7544b68aa9ee4258a160227cf3baf78d0df1255e
Author: yintao 
AuthorDate: Wed Jun 7 12:11:44 2023 +0800

net/local: Support the abstract path to connect

Signed-off-by: yintao 
---
 net/local/local_accept.c  |  3 +--
 net/local/local_listen.c  |  3 +--
 net/local/local_netpoll.c | 10 --
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/net/local/local_accept.c b/net/local/local_accept.c
index e1f099e425..63d921b6f8 100644
--- a/net/local/local_accept.c
+++ b/net/local/local_accept.c
@@ -125,8 +125,7 @@ int local_accept(FAR struct socket *psock, FAR struct 
sockaddr *addr,
   server = psock->s_conn;
 
   if (server->lc_proto != SOCK_STREAM ||
-  server->lc_state != LOCAL_STATE_LISTENING ||
-  server->lc_type  != LOCAL_TYPE_PATHNAME)
+  server->lc_state != LOCAL_STATE_LISTENING)
 {
   return -EOPNOTSUPP;
 }
diff --git a/net/local/local_listen.c b/net/local/local_listen.c
index 89a3c1b266..08125afba1 100644
--- a/net/local/local_listen.c
+++ b/net/local/local_listen.c
@@ -86,8 +86,7 @@ int local_listen(FAR struct socket *psock, int backlog)
   /* Some sanity checks */
 
   if (server->lc_proto != SOCK_STREAM ||
-  server->lc_state == LOCAL_STATE_UNBOUND ||
-  server->lc_type != LOCAL_TYPE_PATHNAME)
+  server->lc_state == LOCAL_STATE_UNBOUND)
 {
   net_unlock();
   return -EOPNOTSUPP;
diff --git a/net/local/local_netpoll.c b/net/local/local_netpoll.c
index f1df7756fd..c519658639 100644
--- a/net/local/local_netpoll.c
+++ b/net/local/local_netpoll.c
@@ -168,9 +168,8 @@ int local_pollsetup(FAR struct socket *psock, FAR struct 
pollfd *fds)
 }
 
 #ifdef CONFIG_NET_LOCAL_STREAM
-  if ((conn->lc_state == LOCAL_STATE_LISTENING ||
-   conn->lc_state == LOCAL_STATE_CONNECTING) &&
-   conn->lc_type  == LOCAL_TYPE_PATHNAME)
+  if (conn->lc_state == LOCAL_STATE_LISTENING ||
+   conn->lc_state == LOCAL_STATE_CONNECTING)
 {
   return local_event_pollsetup(conn, fds, true);
 }
@@ -322,9 +321,8 @@ int local_pollteardown(FAR struct socket *psock, FAR struct 
pollfd *fds)
 }
 
 #ifdef CONFIG_NET_LOCAL_STREAM
-  if ((conn->lc_state == LOCAL_STATE_LISTENING ||
-   conn->lc_state == LOCAL_STATE_CONNECTING) &&
-   conn->lc_type  == LOCAL_TYPE_PATHNAME)
+  if (conn->lc_state == LOCAL_STATE_LISTENING ||
+   conn->lc_state == LOCAL_STATE_CONNECTING)
 {
   return local_event_pollsetup(conn, fds, false);
 }



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9814: net/local: Support the abstract path to connect

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9814:
URL: https://github.com/apache/nuttx/pull/9814


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9798: add refcnt using epoll_create to fix bug when use popen which dup the fd and close at end after epoll_create

2023-07-13 Thread via GitHub


xiaoxiang781216 commented on code in PR #9798:
URL: https://github.com/apache/nuttx/pull/9798#discussion_r1263207461


##
fs/vfs/fs_epoll.c:
##
@@ -246,6 +246,8 @@ static int epoll_do_create(int size, int flags)
   list_add_tail(>free, [i].node);
 }
 
+  eph->crefs++;

Review Comment:
   the result is same since eph is allocated by kmm_zalloc. I guess 
@DannyPlusPlus use ++ just because other place use ++/-- too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] 01/04: examples/nimble: fix assertion during pthread create with zero priority

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git

commit 355153cff5bf17fa6d6c94ff656ad1aaaf1cd196
Author: Petro Karashchenko 
AuthorDate: Thu Jul 13 23:20:28 2023 +0300

examples/nimble: fix assertion during pthread create with zero priority

Signed-off-by: Petro Karashchenko 
---
 examples/nimble/nimble_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/nimble/nimble_main.c b/examples/nimble/nimble_main.c
index 4bc3d013e..c3864077d 100644
--- a/examples/nimble/nimble_main.c
+++ b/examples/nimble/nimble_main.c
@@ -59,7 +59,7 @@
 
 /* Not used now */
 
-#define TASK_DEFAULT_PRIORITY   0
+#define TASK_DEFAULT_PRIORITY   CONFIG_EXAMPLES_NIMBLE_PRIORITY
 #define TASK_DEFAULT_STACK  NULL
 #define TASK_DEFAULT_STACK_SIZE 0
 
@@ -67,7 +67,7 @@
  * External Functions Prototypes
  /
 
-void ble_hci_sock_ack_handler(void *param);
+void ble_hci_sock_ack_handler(FAR void *param);
 void ble_hci_sock_init(void);
 void ble_hci_sock_set_device(int dev);
 



[nuttx-apps] 03/04: wireless/bluetooth/nimble: add option to configure stack size of NimBLE NPL callout thread

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git

commit 4ac830ef1eaf5383d91b7bca14fab79e3b454f71
Author: Petro Karashchenko 
AuthorDate: Thu Jul 13 23:24:03 2023 +0300

wireless/bluetooth/nimble: add option to configure stack size of NimBLE NPL 
callout thread

Signed-off-by: Petro Karashchenko 
---
 wireless/bluetooth/nimble/Kconfig | 4 
 1 file changed, 4 insertions(+)

diff --git a/wireless/bluetooth/nimble/Kconfig 
b/wireless/bluetooth/nimble/Kconfig
index 975e4723d..a583e3119 100644
--- a/wireless/bluetooth/nimble/Kconfig
+++ b/wireless/bluetooth/nimble/Kconfig
@@ -14,6 +14,10 @@ config NIMBLE_REF
---help---
Git ref name to use when downloading from NimBLE repo
 
+config NIMBLE_CALLOUT_THREAD_STACKSIZE
+   int "Stack size of NimBLE NPL callout thread"
+   default DEFAULT_TASK_STACKSIZE
+
 if DEBUG_FEATURES
 
 config NIMBLE_DEBUG_ERROR



[nuttx-apps] branch master updated (4df395bfc -> 5dba460f5)

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


from 4df395bfc cmake: add support for boot utils
 new 355153cff examples/nimble: fix assertion during pthread create with 
zero priority
 new 0c7788cf2 wireless/bluetooth/nimble: fix build issue with nimBLE 
example
 new 4ac830ef1 wireless/bluetooth/nimble: add option to configure stack 
size of NimBLE NPL callout thread
 new 5dba460f5 wireless/bluetooth/nimble: increase number of ACL buffers 
available for controller

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 examples/nimble/nimble_main.c | 4 ++--
 wireless/bluetooth/nimble/Kconfig | 4 
 wireless/bluetooth/nimble/Makefile.nimble | 2 +-
 wireless/bluetooth/nimble/include/syscfg/syscfg.h | 6 +++---
 4 files changed, 10 insertions(+), 6 deletions(-)



[nuttx-apps] 02/04: wireless/bluetooth/nimble: fix build issue with nimBLE example

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git

commit 0c7788cf26660f3337b741225e094cc28a8ae0ce
Author: Petro Karashchenko 
AuthorDate: Thu Jul 13 23:21:35 2023 +0300

wireless/bluetooth/nimble: fix build issue with nimBLE example

The NimBLE source code is downloaded at the first pass of the
make system so some makefiles to include might be not in place
initially, but included after code is fetched

Signed-off-by: Petro Karashchenko 
---
 wireless/bluetooth/nimble/Makefile.nimble | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wireless/bluetooth/nimble/Makefile.nimble 
b/wireless/bluetooth/nimble/Makefile.nimble
index 84f7cb5af..e6d7fa456 100644
--- a/wireless/bluetooth/nimble/Makefile.nimble
+++ b/wireless/bluetooth/nimble/Makefile.nimble
@@ -38,7 +38,7 @@ NIMBLE_IGNORE += 
$(NIMBLE_ROOT)/porting/nimble/src/os_cputime_pwr2.c
 
 # include NimBLE porting defs
 
-include $(NIMBLE_ROOT)/porting/nimble/Makefile.defs
+-include $(NIMBLE_ROOT)/porting/nimble/Makefile.defs
 
 CSRCS += $(NIMBLE_SRC)
 



[nuttx-apps] 04/04: wireless/bluetooth/nimble: increase number of ACL buffers available for controller

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git

commit 5dba460f5fd6f295f8510a0d052c39fc5d00358e
Author: Petro Karashchenko 
AuthorDate: Thu Jul 13 23:25:57 2023 +0300

wireless/bluetooth/nimble: increase number of ACL buffers available for 
controller

Signed-off-by: Petro Karashchenko 
---
 wireless/bluetooth/nimble/include/syscfg/syscfg.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/wireless/bluetooth/nimble/include/syscfg/syscfg.h 
b/wireless/bluetooth/nimble/include/syscfg/syscfg.h
index 9be9a5eec..e4d063ed0 100644
--- a/wireless/bluetooth/nimble/include/syscfg/syscfg.h
+++ b/wireless/bluetooth/nimble/include/syscfg/syscfg.h
@@ -56,7 +56,7 @@
 /* Transport configuration */
 
 #define MYNEWT_VAL_BLE_TRANSPORT_ACL_FROM_HS_COUNT (10)
-#define MYNEWT_VAL_BLE_TRANSPORT_ACL_FROM_LL_COUNT (0)
+#define MYNEWT_VAL_BLE_TRANSPORT_ACL_FROM_LL_COUNT (10)
 #define MYNEWT_VAL_BLE_TRANSPORT_ACL_SIZE  (251)
 #define MYNEWT_VAL_BLE_TRANSPORT_EVT_COUNT (4)
 #define MYNEWT_VAL_BLE_TRANSPORT_EVT_DISCARDABLE_COUNT (16)
@@ -134,7 +134,7 @@
 #endif
 
 #ifdef CONFIG_NIMBLE_BLE_EXT_ADV
-#  define MYNEWT_VAL_BLE_EXT_ADV   (1)
+#  define MYNEWT_VAL_BLE_EXT_ADV(1)
 #  define MYNEWT_VAL_BLE_EXT_ADV_MAX_SIZE   
(CONFIG_NIMBLE_BLE_EXT_ADV_MAX_SIZE)
 #else
 #  define MYNEWT_VAL_BLE_EXT_ADV(0)
@@ -236,7 +236,7 @@
 #ifdef CONFIG_NIMBLE_BLE_SM_SC
 #  define MYNEWT_VAL_BLE_SM_SC  (1)
 #else
-#  define MYNEWT_VAL_BLE_SM_SC (0)
+#  define MYNEWT_VAL_BLE_SM_SC  (0)
 #endif
 
 #ifdef CONFIG_NIMBLE_BLE_SM_SC_DEBUG



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1836: Various improvements for NimBLE

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1836:
URL: https://github.com/apache/nuttx-apps/pull/1836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-website] branch asf-site updated: Publishing web: 8e851a05e38d691daba0a4a399ad969a6f0d1788 docs: 6a0ffa5c52f51f8a4ad3d89ab7a0d73633bab482

2023-07-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 65c60d82 Publishing web: 8e851a05e38d691daba0a4a399ad969a6f0d1788 
docs: 6a0ffa5c52f51f8a4ad3d89ab7a0d73633bab482
65c60d82 is described below

commit 65c60d8250c9acc9002f56ff176272689052f896
Author: Alin Jerpelea 
AuthorDate: Fri Jul 14 00:14:45 2023 +

Publishing web: 8e851a05e38d691daba0a4a399ad969a6f0d1788 docs: 
6a0ffa5c52f51f8a4ad3d89ab7a0d73633bab482
---
 content/docs/10.0.0/index.html | 2 +-
 content/docs/10.0.0/searchindex.js | 2 +-
 content/docs/10.0.1/index.html | 2 +-
 content/docs/10.0.1/searchindex.js | 2 +-
 content/docs/10.1.0/index.html | 2 +-
 content/docs/10.1.0/searchindex.js | 2 +-
 content/docs/10.2.0/index.html | 2 +-
 content/docs/10.2.0/searchindex.js | 2 +-
 content/docs/10.3.0/index.html | 2 +-
 content/docs/10.3.0/searchindex.js | 2 +-
 content/docs/11.0.0/index.html | 2 +-
 content/docs/11.0.0/searchindex.js | 2 +-
 content/docs/12.0.0/index.html | 2 +-
 content/docs/12.0.0/searchindex.js | 2 +-
 content/docs/12.1.0/index.html | 2 +-
 content/docs/12.1.0/searchindex.js | 2 +-
 content/docs/12.2.0/index.html | 2 +-
 content/docs/12.2.0/searchindex.js | 2 +-
 content/docs/latest/index.html | 2 +-
 content/docs/latest/searchindex.js | 2 +-
 content/feed.xml   | 4 ++--
 21 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 3bc89b80..37f9c178 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -131,7 +131,7 @@ by following these 
 NuttX Documentation
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 13 July 23 at 00:11
+Last Updated: 14 July 23 at 00:11
 
 Table of 
Contents
 
diff --git a/content/docs/10.0.0/searchindex.js 
b/content/docs/10.0.0/searchindex.js
index bd62279d..91bd65f2 100644
--- a/content/docs/10.0.0/searchindex.js
+++ b/content/docs/10.0.0/searchindex.js
@@ -1 +1 @@
-Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", "components/drivers/character/keypad", 
"components/drivers/character/pwm", "components/drivers/character/quadrature", 
"components/drivers/character/rtc", "components/drivers/character/serial", 
"components/drivers/character/timer", "components/drivers/chara [...]
\ No newline at end of file
+Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", "components/drivers/character/keypad", 
"components/drivers/character/pwm", "components/drivers/character/quadrature", 
"components/drivers/character/rtc", "components/drivers/character/serial", 
"components/drivers/character/timer", "components/drivers/chara [...]
\ No newline at end of file
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index b79a1f13..3f108e08 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -149,7 +149,7 @@ by following these 
 NuttX Documentation
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 13 July 23 at 00:11
+Last Updated: 14 July 23 at 00:11
 
 Table of 
Contents
 
diff --git a/content/docs/10.0.1/searchindex.js 
b/content/docs/10.0.1/searchindex.js
index 2d86c2e2..c6ecc4d6 100644
--- a/content/docs/10.0.1/searchindex.js
+++ b/content/docs/10.0.1/searchindex.js
@@ -1 +1 @@
-Search.setIndex({"docnames": ["applications/index", "boards/index", 
"components/binfmt", "components/drivers/block/index", 
"components/drivers/character/analog", "components/drivers/character/can", 
"components/drivers/character/index", 

[GitHub] [nuttx] acassis opened a new pull request, #9821: esp32-s3: Add initial support to I2S

2023-07-13 Thread via GitHub


acassis opened a new pull request, #9821:
URL: https://github.com/apache/nuttx/pull/9821

   ## Summary
   Add initial support to I2S
   ## Impact
   Users will be able to use audio on ESP32S3
   ## Testing
   WIP
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] 01/04: libc/printf: fix "%pS" length error

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 135959eb839a1c6d629bdd432eb8f02f8a527328
Author: yinshengkai 
AuthorDate: Wed Jun 7 15:14:31 2023 +0800

libc/printf: fix "%pS" length error

Signed-off-by: yinshengkai 
---
 libs/libc/stdio/lib_libvsprintf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libs/libc/stdio/lib_libvsprintf.c 
b/libs/libc/stdio/lib_libvsprintf.c
index a49fee0daa..06c9532b32 100644
--- a/libs/libc/stdio/lib_libvsprintf.c
+++ b/libs/libc/stdio/lib_libvsprintf.c
@@ -1166,7 +1166,9 @@ str_lpad:
 
   if (c == 'S')
 {
-  sprintf_internal(stream, "+%#tx/%#zx",
+  total_len +=
+  sprintf_internal(stream,
+   "+%#tx/%#zx",
addr - symbol->sym_value,
symbolsize);
 }



[nuttx] 03/04: libc: export lib_sprintf_internal function

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit fe9251b54608f6c53c5bb92d378cde919b32cb95
Author: yinshengkai 
AuthorDate: Sun Jun 25 12:23:01 2023 +0800

libc: export lib_sprintf_internal function

This function does not take numbered arguments in printf

Signed-off-by: yinshengkai 
---
 include/nuttx/streams.h   | 25 +++
 libs/libc/stdio/lib_libvsprintf.c | 64 ++-
 2 files changed, 68 insertions(+), 21 deletions(-)

diff --git a/include/nuttx/streams.h b/include/nuttx/streams.h
index 214d61d815..3e11371c3c 100644
--- a/include/nuttx/streams.h
+++ b/include/nuttx/streams.h
@@ -689,6 +689,31 @@ int lib_snoflush(FAR struct lib_sostream_s *this);
 int lib_sprintf(FAR struct lib_outstream_s *obj,
 FAR const IPTR char *fmt, ...) printf_like(2, 3);
 
+/
+ * Name: lib_sprintf_internal
+ *
+ * Description:
+ *   This function does not take numbered arguments in printf.
+ *   Equivalent to lib_sprintf when CONFIG_LIBC_NUMBERED_ARGS is not enabled
+ *
+ /
+
+int lib_sprintf_internal(FAR struct lib_outstream_s *obj,
+ FAR const IPTR char *fmt, ...) printf_like(2, 3);
+
+/
+ * Name: lib_vsprintf_internal
+ *
+ * Description:
+ *   This function does not take numbered arguments in printf.
+ *   Equivalent to lib_sprintf when CONFIG_LIBC_NUMBERED_ARGS is not enabled
+ *
+ /
+
+int lib_vsprintf_internal(FAR struct lib_outstream_s *stream,
+  FAR const IPTR char *fmt, va_list ap)
+  printf_like(2, 0);
+
 /
  * Name: lib_vsprintf
  *
diff --git a/libs/libc/stdio/lib_libvsprintf.c 
b/libs/libc/stdio/lib_libvsprintf.c
index 06c9532b32..2f13334f5c 100644
--- a/libs/libc/stdio/lib_libvsprintf.c
+++ b/libs/libc/stdio/lib_libvsprintf.c
@@ -155,23 +155,6 @@ static int vsprintf_internal(FAR struct lib_outstream_s 
*stream,
  * Private Functions
  /
 
-#ifdef CONFIG_ALLSYMS
-static int sprintf_internal(FAR struct lib_outstream_s *stream,
-FAR const IPTR char *fmt, ...)
-{
-  va_list ap;
-  int n;
-
-  /* Then let vsprintf_internal do the real work */
-
-  va_start(ap, fmt);
-  n = vsprintf_internal(stream, NULL, 0, fmt, ap);
-  va_end(ap);
-
-  return n;
-}
-#endif
-
 static int vsprintf_internal(FAR struct lib_outstream_s *stream,
  FAR struct arg_s *arglist, int numargs,
  FAR const IPTR char *fmt, va_list ap)
@@ -1167,10 +1150,10 @@ str_lpad:
   if (c == 'S')
 {
   total_len +=
-  sprintf_internal(stream,
-   "+%#tx/%#zx",
-   addr - symbol->sym_value,
-   symbolsize);
+  lib_sprintf_internal(stream,
+   "+%#tx/%#zx",
+   addr - symbol->sym_value,
+   symbolsize);
 }
 
   continue;
@@ -1382,3 +1365,42 @@ int lib_vsprintf(FAR struct lib_outstream_s *stream,
   return vsprintf_internal(stream, NULL, 0, fmt, ap);
 #endif
 }
+
+/
+ * Name: lib_sprintf_internal
+ *
+ * Description:
+ *   This function does not take numbered arguments in printf.
+ *   Equivalent to lib_sprintf when CONFIG_LIBC_NUMBERED_ARGS is not enabled
+ *
+ /
+
+int lib_sprintf_internal(FAR struct lib_outstream_s *stream,
+ FAR const IPTR char *fmt, ...)
+{
+  va_list ap;
+  int n;
+
+  /* Then let vsprintf_internal do the real work */
+
+  va_start(ap, fmt);
+  n = vsprintf_internal(stream, NULL, 0, fmt, ap);
+  va_end(ap);
+
+  return n;
+}
+
+/
+ * Name: lib_vsprintf_internal
+ *
+ * Description:
+ *   This function does not take numbered arguments in printf.
+ *   Equivalent to lib_sprintf when CONFIG_LIBC_NUMBERED_ARGS is not enabled
+ *
+ /
+
+int 

[nuttx] 04/04: syslog: replace lib_sprintf to lib_sprintf_internal

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 6a0ffa5c52f51f8a4ad3d89ab7a0d73633bab482
Author: yinshengkai 
AuthorDate: Sun Jun 25 12:36:29 2023 +0800

syslog: replace lib_sprintf to lib_sprintf_internal

Signed-off-by: yinshengkai 
---
 drivers/syslog/vsyslog.c | 43 ++-
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/drivers/syslog/vsyslog.c b/drivers/syslog/vsyslog.c
index fa5163bb8a..39ed721d8a 100644
--- a/drivers/syslog/vsyslog.c
+++ b/drivers/syslog/vsyslog.c
@@ -150,101 +150,102 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, 
FAR va_list *ap)
 defined(CONFIG_SYSLOG_PRIORITY) || defined(CONFIG_SYSLOG_PREFIX) || \
 defined(CONFIG_SYSLOG_PROCESS_NAME)
 
-  ret = lib_sprintf(,
+  ret = lib_sprintf_internal(,
 #if defined(CONFIG_SYSLOG_COLOR_OUTPUT)
   /* Reset the terminal style. */
 
-"\e[0m"
+ "\e[0m"
 #endif
 
 #ifdef CONFIG_SYSLOG_TIMESTAMP
 #  if defined(CONFIG_SYSLOG_TIMESTAMP_FORMATTED)
 #if defined(CONFIG_SYSLOG_TIMESTAMP_FORMAT_MICROSECOND)
-"[%s.%06ld] "
+ "[%s.%06ld] "
 #else
-"[%s] "
+ "[%s] "
 #endif
 #  else
-"[%5jd.%06ld] "
+ "[%5jd.%06ld] "
 #  endif
 #endif
 
 #if defined(CONFIG_SMP)
-"[CPU%d] "
+ "[CPU%d] "
 #endif
 
 #if defined(CONFIG_SYSLOG_PROCESSID)
   /* Prepend the Thread ID */
 
-"[%2d] "
+ "[%2d] "
 #endif
 
 #if defined(CONFIG_SYSLOG_COLOR_OUTPUT)
   /* Set the terminal style according to message priority. */
 
-"%s"
+ "%s"
 #endif
 
 #if defined(CONFIG_SYSLOG_PRIORITY)
   /* Prepend the message priority. */
 
-"[%6s] "
+ "[%6s] "
 #endif
 
 #if defined(CONFIG_SYSLOG_PREFIX)
   /* Prepend the prefix, if available */
 
-"[%s] "
+ "[%s] "
 #endif
 #if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_SYSLOG_PROCESS_NAME)
   /* Prepend the thread name */
 
-"%s: "
+ "%s: "
 #endif
 #ifdef CONFIG_SYSLOG_TIMESTAMP
 #  if defined(CONFIG_SYSLOG_TIMESTAMP_FORMATTED)
 #if defined(CONFIG_SYSLOG_TIMESTAMP_FORMAT_MICROSECOND)
-, date_buf, ts.tv_nsec / NSEC_PER_USEC
+ , date_buf, ts.tv_nsec / NSEC_PER_USEC
 #else
-, date_buf
+ , date_buf
 #endif
 #  else
-, (uintmax_t)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC
+ , (uintmax_t)ts.tv_sec
+ , ts.tv_nsec / NSEC_PER_USEC
 #  endif
 #endif
 
 #if defined(CONFIG_SMP)
-, up_cpu_index()
+ , up_cpu_index()
 #endif
 
 #if defined(CONFIG_SYSLOG_PROCESSID)
   /* Prepend the Thread ID */
 
-, nxsched_gettid()
+ , nxsched_gettid()
 #endif
 
 #if defined(CONFIG_SYSLOG_COLOR_OUTPUT)
   /* Set the terminal style according to message priority. */
 
-, g_priority_color[priority]
+ , g_priority_color[priority]
 #endif
 
 #if defined(CONFIG_SYSLOG_PRIORITY)
   /* Prepend the message priority. */
 
-, g_priority_str[priority]
+ , g_priority_str[priority]
 #endif
 
 #if defined(CONFIG_SYSLOG_PREFIX)
   /* Prepend the prefix, if available */
 
-, CONFIG_SYSLOG_PREFIX_STRING
+ , CONFIG_SYSLOG_PREFIX_STRING
 #endif
 
 #if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_SYSLOG_PROCESS_NAME)
   /* Prepend the thread name */
 
-, tcb != NULL ? tcb->name : "(null)"
+ , tcb != NULL ? tcb->name : "(null)"
 #endif
 );
 
@@ -252,7 +253,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR 
va_list *ap)
 
   /* Generate the output */
 
-  ret += lib_vsprintf(, fmt, *ap);
+  ret += lib_vsprintf_internal(, fmt, *ap);
 
   if (stream.last_ch != '\n')
 {



[nuttx] 02/04: syslog: replace %pV with lib_sprintf

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 0052ff2bd8616e49827d1aa6b2e9ac705e7275fe
Author: yinshengkai 
AuthorDate: Sun Jun 25 11:00:36 2023 +0800

syslog: replace %pV with lib_sprintf

%pV will increase the stack size

Signed-off-by: yinshengkai 
---
 drivers/syslog/vsyslog.c | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/syslog/vsyslog.c b/drivers/syslog/vsyslog.c
index e1a29c6c13..fa5163bb8a 100644
--- a/drivers/syslog/vsyslog.c
+++ b/drivers/syslog/vsyslog.c
@@ -82,7 +82,7 @@ static FAR const char * const g_priority_str[] =
 int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap)
 {
   struct lib_syslograwstream_s stream;
-  int ret;
+  int ret = 0;
 #if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_SYSLOG_PROCESS_NAME)
   FAR struct tcb_s *tcb = nxsched_get_tcb(nxsched_gettid());
 #endif
@@ -93,9 +93,6 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR 
va_list *ap)
   char date_buf[CONFIG_SYSLOG_TIMESTAMP_BUFFER];
 #  endif
 #endif
-  struct va_format vaf;
-  vaf.fmt = fmt;
-  vaf.va  = ap;
 
   /* Wrap the low-level output in a stream object and let lib_vsprintf
* do the work.
@@ -148,6 +145,11 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR 
va_list *ap)
 #  endif
 #endif
 
+#if defined(CONFIG_SYSLOG_COLOR_OUTPUT) || defined(CONFIG_SYSLOG_TIMESTAMP) || 
\
+defined(CONFIG_SMP) || defined(CONFIG_SYSLOG_PROCESSID) || \
+defined(CONFIG_SYSLOG_PRIORITY) || defined(CONFIG_SYSLOG_PREFIX) || \
+defined(CONFIG_SYSLOG_PROCESS_NAME)
+
   ret = lib_sprintf(,
 #if defined(CONFIG_SYSLOG_COLOR_OUTPUT)
   /* Reset the terminal style. */
@@ -199,7 +201,6 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR 
va_list *ap)
 
 "%s: "
 #endif
-"%pV"
 #ifdef CONFIG_SYSLOG_TIMESTAMP
 #  if defined(CONFIG_SYSLOG_TIMESTAMP_FORMATTED)
 #if defined(CONFIG_SYSLOG_TIMESTAMP_FORMAT_MICROSECOND)
@@ -245,10 +246,13 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, 
FAR va_list *ap)
 
 , tcb != NULL ? tcb->name : "(null)"
 #endif
+);
+
+#endif /* CONFIG_SYSLOG_COLOR_OUTPUT || CONFIG_SYSLOG_TIMESTAMP || ... */
 
   /* Generate the output */
 
-, );
+  ret += lib_vsprintf(, fmt, *ap);
 
   if (stream.last_ch != '\n')
 {



[nuttx] branch master updated (019b7a39d4 -> 6a0ffa5c52)

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 019b7a39d4 cmake: cmse support for armv8-m
 new 135959eb83 libc/printf: fix "%pS" length error
 new 0052ff2bd8 syslog: replace %pV with lib_sprintf
 new fe9251b546 libc: export lib_sprintf_internal function
 new 6a0ffa5c52 syslog: replace lib_sprintf to lib_sprintf_internal

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 drivers/syslog/vsyslog.c  | 57 ++
 include/nuttx/streams.h   | 25 +++
 libs/libc/stdio/lib_libvsprintf.c | 64 +++
 3 files changed, 100 insertions(+), 46 deletions(-)



[GitHub] [nuttx] pkarashchenko merged pull request #9780: Fix syslog stack usage is too large

2023-07-13 Thread via GitHub


pkarashchenko merged PR #9780:
URL: https://github.com/apache/nuttx/pull/9780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9798: add refcnt using epoll_create to fix bug when use popen which dup the fd and close at end after epoll_create

2023-07-13 Thread via GitHub


pkarashchenko commented on code in PR #9798:
URL: https://github.com/apache/nuttx/pull/9798#discussion_r1263061979


##
fs/vfs/fs_epoll.c:
##
@@ -246,6 +246,8 @@ static int epoll_do_create(int size, int flags)
   list_add_tail(>free, [i].node);
 }
 
+  eph->crefs++;

Review Comment:
   just a question: why `eph->crefs++;` and not `eph->crefs = 1;`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1829: iptables: add iptables libary

2023-07-13 Thread via GitHub


pkarashchenko commented on code in PR #1829:
URL: https://github.com/apache/nuttx-apps/pull/1829#discussion_r1263056734


##
include/netutils/xtables.h:
##
@@ -0,0 +1,494 @@
+/
+ * apps/include/netutils/xtables.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+#ifndef __APPS_INCLUDE_XTABLES_H
+#define __APPS_INCLUDE_XTABLES_H

Review Comment:
   `__APPS_INCLUDE_NETUTILS_XTABLES_H`



##
include/netutils/xtables.h:
##
@@ -0,0 +1,494 @@
+/
+ * apps/include/netutils/xtables.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+#ifndef __APPS_INCLUDE_XTABLES_H
+#define __APPS_INCLUDE_XTABLES_H
+
+/
+ * Included Files
+ /
+
+#include 
+#include 
+#include 
+
+#include 
+
+/
+ * Pre-processor Definitions
+ /
+
+#define XTABLES_VERSION_CODE 12
+
+/**
+ * Select the format the input has to conform to, as well as the target type
+ * (area pointed to with XTOPT_POINTER). Note that the storing is not always
+ * uniform. @cb->val will be populated with as much as there is space, i.e.
+ * exactly 2 items for ranges, but the target area can receive more values
+ * (e.g. in case of ranges), or less values (e.g. %XTTYPE_HOSTMASK).
+ *
+ * %XTTYPE_NONE:option takes no argument
+ * %XTTYPE_UINT*:   standard integer
+ * %XTTYPE_UINT*RC: colon-separated range of standard integers
+ * %XTTYPE_DOUBLE:  double-precision floating point number
+ * %XTTYPE_STRING:  arbitrary string
+ * %XTTYPE_TOSMASK: 8-bit TOS value with optional mask
+ * %XTTYPE_MARKMASK32:  32-bit mark with optional mask
+ * %XTTYPE_SYSLOGLEVEL: syslog level by name or number
+ * %XTTYPE_HOST:one host or address (ptr: union nf_inet_addr)
+ * %XTTYPE_HOSTMASK:one host or address, with an optional prefix length
+ *  ptr: union nf_inet_addr; only host portion is stored
+ * %XTTYPE_PROTOCOL:protocol number/name from /etc/protocols ptr: uint8_t
+ * %XTTYPE_PORT:16-bit port name or number (supports %XTOPT_NBO)
+ * %XTTYPE_PORTRC:  colon-separated port range (names acceptable),
+ *  (supports %XTOPT_NBO)
+ * %XTTYPE_PLEN:prefix length
+ * %XTTYPE_PLENMASK:prefix length (ptr: union nf_inet_addr)
+ * %XTTYPE_ETHERMAC:Ethernet MAC address in hex form
+ */
+
+enum xt_option_type
+{
+  XTTYPE_NONE,
+  XTTYPE_UINT8,
+  XTTYPE_UINT16,
+  XTTYPE_UINT32,
+  XTTYPE_UINT64,
+  XTTYPE_UINT8RC,
+  XTTYPE_UINT16RC,
+  XTTYPE_UINT32RC,
+  XTTYPE_UINT64RC,
+  XTTYPE_DOUBLE,
+  XTTYPE_STRING,
+  XTTYPE_TOSMASK,
+  XTTYPE_MARKMASK32,
+  XTTYPE_SYSLOGLEVEL,
+  XTTYPE_HOST,
+  XTTYPE_HOSTMASK,
+  XTTYPE_PROTOCOL,
+  XTTYPE_PORT,
+  XTTYPE_PORTRC,
+  XTTYPE_PLEN,
+  XTTYPE_PLENMASK,
+  XTTYPE_ETHERMAC,
+};
+
+enum xtables_tryload
+{
+  XTF_DONT_LOAD,
+  XTF_DURING_LOAD,
+  XTF_TRY_LOAD,
+  XTF_LOAD_MUST_SUCCEED,
+};
+
+enum 

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9817: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread via GitHub


pkarashchenko commented on code in PR #9817:
URL: https://github.com/apache/nuttx/pull/9817#discussion_r1263049265


##
drivers/net/netdev_upperhalf.c:
##
@@ -554,6 +554,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   FAR const struct wireless_ops_s *ops = lower->iw_ops;
   const struct ether_addr zero =
 {
+  0

Review Comment:
   ```suggestion
 {
   0, 0, 0, 0, 0, 0
 }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] branch master updated: cmake: add support for boot utils

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new 4df395bfc cmake: add support for boot utils
4df395bfc is described below

commit 4df395bfc4fc132270a7d040b9a379ebe629f79b
Author: raiden00pl 
AuthorDate: Thu Jul 13 11:37:39 2023 +0200

cmake: add support for boot utils
---
 boot/CMakeLists.txt|   2 +
 boot/mcuboot/CMakeLists.txt| 111 +
 boot/{ => miniboot}/CMakeLists.txt |  10 +-
 {boot => examples/mcuboot}/CMakeLists.txt  |   6 +-
 .../mcuboot/slot_confirm}/CMakeLists.txt   |   9 +-
 .../mcuboot/swap_test}/CMakeLists.txt  |  19 +++-
 .../mcuboot/update_agent}/CMakeLists.txt   |   9 +-
 7 files changed, 156 insertions(+), 10 deletions(-)

diff --git a/boot/CMakeLists.txt b/boot/CMakeLists.txt
index ce82730ee..50b7ba7c4 100644
--- a/boot/CMakeLists.txt
+++ b/boot/CMakeLists.txt
@@ -18,4 +18,6 @@
 #
 # 
##
 
+nuttx_add_subdirectory()
+
 nuttx_generate_kconfig(MENUDESC "Bootloader Utilities")
diff --git a/boot/mcuboot/CMakeLists.txt b/boot/mcuboot/CMakeLists.txt
new file mode 100644
index 0..4b0d73d1d
--- /dev/null
+++ b/boot/mcuboot/CMakeLists.txt
@@ -0,0 +1,111 @@
+# 
##
+# apps/boot/mcuboot/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may 
not
+# use this file except in compliance with the License.  You may obtain a copy 
of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# 
##
+
+if(CONFIG_BOOT_MCUBOOT)
+  nuttx_add_library(mcuboot)
+
+  if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/mcuboot)
+FetchContent_Declare(
+  mcuboot
+  DOWNLOAD_NAME "${CONFIG_MCUBOOT_VERSION}.tar.gz"
+  DOWNLOAD_DIR ${CMAKE_CURRENT_LIST_DIR}
+  URL 
"https://github.com/mcu-tools/mcuboot/archive/${CONFIG_MCUBOOT_VERSION}.tar.gz;
+  SOURCE_DIR
+  ${CMAKE_CURRENT_LIST_DIR}/mcuboot
+  BINARY_DIR
+  ${CMAKE_BINARY_DIR}/apps/boot/mcuboot/mcuboot
+  CONFIGURE_COMMAND
+  ""
+  BUILD_COMMAND
+  ""
+  INSTALL_COMMAND
+  ""
+  TEST_COMMAND
+  ""
+  DOWNLOAD_NO_PROGRESS true
+  TIMEOUT 30)
+
+FetchContent_GetProperties(mcuboot)
+
+if(NOT mcuboot_POPULATED)
+  FetchContent_Populate(mcuboot)
+endif()
+  endif()
+
+  set(SRCS
+mcuboot/boot/bootutil/src/boot_record.c
+mcuboot/boot/bootutil/src/bootutil_misc.c
+mcuboot/boot/bootutil/src/bootutil_public.c
+mcuboot/boot/bootutil/src/caps.c
+mcuboot/boot/bootutil/src/encrypted.c
+mcuboot/boot/bootutil/src/fault_injection_hardening.c
+mcuboot/boot/bootutil/src/fault_injection_hardening_delay_rng_mbedtls.c
+mcuboot/boot/bootutil/src/image_ec.c
+mcuboot/boot/bootutil/src/image_ec256.c
+mcuboot/boot/bootutil/src/image_ed25519.c
+mcuboot/boot/bootutil/src/image_rsa.c
+mcuboot/boot/bootutil/src/image_validate.c
+mcuboot/boot/bootutil/src/loader.c
+mcuboot/boot/bootutil/src/swap_misc.c
+mcuboot/boot/bootutil/src/swap_move.c
+mcuboot/boot/bootutil/src/swap_scratch.c
+mcuboot/boot/bootutil/src/tlv.c
+  )
+
+  list(APPEND SRCS 
mcuboot/boot/nuttx/src/flash_map_backend/flash_map_backend.c)
+
+  if(CONFIG_MCUBOOT_BOOTLOADER)
+nuttx_add_application(
+  NAME
+  mcuboot_loader
+  SRCS
+  ${CMAKE_CURRENT_LIST_DIR}/mcuboot/boot/nuttx/main.c
+  INCLUDE_DIRECTORIES
+  mcuboot/boot/bootutil/include
+  mcuboot/boot/nuttx/include
+  STACKSIZE
+  ${CONFIG_DEFAULT_TASK_STACKSIZE}
+  PRIORITY
+  SCHED_PRIORITY_DEFAULT)
+  endif()
+
+  if(CONFIG_MCUBOOT_WATCHDOG)
+list(APPEND SRCS mcuboot/boot/nuttx/src/watchdog/watchdog.c)
+  endif()
+
+  if(CONFIG_MCUBOOT_USE_TINYCRYPT)
+list(APPEND SRCS
+  mcuboot/ext/tinycrypt/lib/source/aes_encrypt.c
+  mcuboot/ext/tinycrypt/lib/source/aes_decrypt.c
+  mcuboot/ext/tinycrypt/lib/source/ctr_mode.c
+  mcuboot/ext/tinycrypt/lib/source/hmac.c
+  

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1835: cmake: add support for boot utils

2023-07-13 Thread via GitHub


pkarashchenko merged PR #1835:
URL: https://github.com/apache/nuttx-apps/pull/1835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated (73a06a4975 -> 019b7a39d4)

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 73a06a4975 cmake/win32: set default LINK_STACKSIZE to avoid stack 
overflow
 new 73e5b9405f cmake: avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in 
CMake 3.24
 new db65b6b0e6 cmake: allow nuttx_add_application to inherit includes from 
dependent target
 new 019b7a39d4 cmake: cmse support for armv8-m

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CMakeLists.txt| 6 ++
 arch/arm/src/cmake/armv8-m.cmake  | 4 
 cmake/nuttx_add_application.cmake | 9 +
 3 files changed, 15 insertions(+), 4 deletions(-)



[nuttx] 01/03: cmake: avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 73e5b9405fb5ad77af3dd39cc3866cc3a95e54a5
Author: raiden00pl 
AuthorDate: Thu Jul 13 11:39:24 2023 +0200

cmake: avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24
---
 CMakeLists.txt | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4dda33be20..72a7c2e152 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -40,6 +40,12 @@ if(POLICY CMP0115)
   cmake_policy(SET CMP0115 NEW)
 endif()
 
+# Avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24:
+
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
+  cmake_policy(SET CMP0135 NEW)
+endif()
+
 # Basic CMake configuration ##
 
 set(CMAKE_CXX_STANDARD 14)



[nuttx] 02/03: cmake: allow nuttx_add_application to inherit includes from dependent target

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit db65b6b0e624a80d86ed3259ec2c44d7036c4c3a
Author: raiden00pl 
AuthorDate: Thu Jul 13 16:10:19 2023 +0200

cmake: allow nuttx_add_application to inherit includes from dependent target
---
 cmake/nuttx_add_application.cmake | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/cmake/nuttx_add_application.cmake 
b/cmake/nuttx_add_application.cmake
index 8727154360..93e032c086 100644
--- a/cmake/nuttx_add_application.cmake
+++ b/cmake/nuttx_add_application.cmake
@@ -183,10 +183,11 @@ function(nuttx_add_application)
 # interface include and libraries
 foreach(dep ${DEPENDS})
   get_target_property(dep_type ${dep} TYPE)
-  # if (${dep_type} STREQUAL "STATIC_LIBRARY")
-  # target_link_libraries(${TARGET} PRIVATE ${dep}) else()
-  add_dependencies(${TARGET} ${dep})
-  # endif()
+  if (${dep_type} STREQUAL "STATIC_LIBRARY")
+target_link_libraries(${TARGET} PRIVATE ${dep})
+  else()
+add_dependencies(${TARGET} ${dep})
+  endif()
 endforeach()
   endif()
 endfunction()



[nuttx] 03/03: cmake: cmse support for armv8-m

2023-07-13 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 019b7a39d4d56ae8eedafceac787ed9444effac2
Author: raiden00pl 
AuthorDate: Thu Jul 13 16:26:06 2023 +0200

cmake: cmse support for armv8-m
---
 arch/arm/src/cmake/armv8-m.cmake | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/src/cmake/armv8-m.cmake b/arch/arm/src/cmake/armv8-m.cmake
index ce304aeaea..2ed0890760 100644
--- a/arch/arm/src/cmake/armv8-m.cmake
+++ b/arch/arm/src/cmake/armv8-m.cmake
@@ -59,4 +59,8 @@ if(CONFIG_ARMV8M_STACKCHECK)
   list(APPEND PLATFORM_FLAGS -finstrument-functions -ffixed-r10)
 endif()
 
+if(CONFIG_ARMV8M_CMSE)
+  list(APPEND PLATFORM_FLAGS -mcmse)
+endif()
+
 add_compile_options(${PLATFORM_FLAGS})



[GitHub] [nuttx] pkarashchenko merged pull request #9820: cmake: improvements

2023-07-13 Thread via GitHub


pkarashchenko merged PR #9820:
URL: https://github.com/apache/nuttx/pull/9820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9819: cmake/win32: set default LINK_STACKSIZE to avoid stack overflow

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9819:
URL: https://github.com/apache/nuttx/pull/9819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: cmake/win32: set default LINK_STACKSIZE to avoid stack overflow

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 73a06a4975 cmake/win32: set default LINK_STACKSIZE to avoid stack 
overflow
73a06a4975 is described below

commit 73a06a4975966294f99d507ee074ebe343a1aab7
Author: chao an 
AuthorDate: Thu Jul 13 22:15:03 2023 +0800

cmake/win32: set default LINK_STACKSIZE to avoid stack overflow

Signed-off-by: chao an 
---
 CMakeLists.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5fedeaa335..4dda33be20 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -603,6 +603,10 @@ if(NOT CONFIG_ARCH_SIM)
   endif()
 elseif(WIN32)
   target_link_options(nuttx PUBLIC /SAFESEH:NO)
+  math(EXPR LINK_STACKSIZE
+   "${CONFIG_SIM_STACKSIZE_ADJUSTMENT} + ${CONFIG_IDLETHREAD_STACKSIZE}"
+   OUTPUT_FORMAT DECIMAL)
+  target_link_options(nuttx PUBLIC /STACK:${LINK_STACKSIZE},${LINK_STACKSIZE})
   set(nuttx_libs_paths)
   foreach(lib ${nuttx_libs})
 list(APPEND nuttx_libs_paths $)



[nuttx-apps] branch master updated (b18cf9aab -> b4ec3d7d4)

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


from b18cf9aab testing/ostest: fix Compiler Warning (level 1) C4716: 
'function' must return a value
 add b4ec3d7d4 tools: Don't register app into nsh if WASM_BUILD_ONLY == y

No new revisions were added by this update.

Summary of changes:
 Application.mk | 16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1831: tools: Don't register app into nsh if WASM_BUILD_ONLY == y

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1831:
URL: https://github.com/apache/nuttx-apps/pull/1831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] branch master updated: testing/ostest: fix Compiler Warning (level 1) C4716: 'function' must return a value

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new b18cf9aab testing/ostest: fix Compiler Warning (level 1) C4716: 
'function' must return a value
b18cf9aab is described below

commit b18cf9aab303fde1aa7f038964331619a198c272
Author: chao an 
AuthorDate: Thu Jul 13 23:04:42 2023 +0800

testing/ostest: fix Compiler Warning (level 1) C4716: 'function' must 
return a value


https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4716?view=msvc-170
Signed-off-by: chao an 
---
 testing/ostest/pthread_exit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testing/ostest/pthread_exit.c b/testing/ostest/pthread_exit.c
index 19cc5fef8..a16d2a6ca 100644
--- a/testing/ostest/pthread_exit.c
+++ b/testing/ostest/pthread_exit.c
@@ -86,6 +86,8 @@ static int pthread_exit_main(int argc, char **argv)
 
   printf("pthread_exit_main %u: ERROR:  Still running\n", me);
   exit(0);
+
+  return 0;
 }
 
 /



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1834: testing/ostest: fix Compiler Warning (level 1) C4716: 'function' must return a value

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1834:
URL: https://github.com/apache/nuttx-apps/pull/1834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] branch master updated: examples/pwm: Fix PWM range

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new 0a7c308f1 examples/pwm: Fix PWM range
0a7c308f1 is described below

commit 0a7c308f1b609a5a41f0e8246a528f66f5deb284
Author: Lucas Saavedra Vaz 
AuthorDate: Thu Jul 13 11:18:44 2023 -0300

examples/pwm: Fix PWM range

This commit fixes the overflow that happens when setting the duty cycle to 
100% in the PWM example.
It now correctly passes the value 0x rather than 0x when setting 
the duty cycle to 100 and makes sure that no underflow happens when setting the 
duty cycle to 0.
---
 examples/pwm/pwm_main.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/examples/pwm/pwm_main.c b/examples/pwm/pwm_main.c
index 497d58abb..c5d4424a8 100644
--- a/examples/pwm/pwm_main.c
+++ b/examples/pwm/pwm_main.c
@@ -523,7 +523,8 @@ int main(int argc, FAR char *argv[])
   for (i = 0; i < CONFIG_PWM_NCHANNELS; i++)
 {
   info.channels[i].channel = g_pwmstate.channels[i];
-  info.channels[i].duty = b16divi(uitoub16(g_pwmstate.duties[i]), 100);
+  info.channels[i].duty = g_pwmstate.duties[i] ? \
+b16divi(uitoub16(g_pwmstate.duties[i]) - 1, 100) : 0;
   printf(" channel: %d duty: %08" PRIx32,
 info.channels[i].channel, info.channels[i].duty);
 }
@@ -531,7 +532,8 @@ int main(int argc, FAR char *argv[])
   printf("\n");
 
 #else
-  info.duty  = b16divi(uitoub16(g_pwmstate.duty), 100);
+  info.duty = g_pwmstate.duty ? \
+b16divi(uitoub16(g_pwmstate.duty) - 1, 100) : 0;
 #  ifdef CONFIG_PWM_PULSECOUNT
   info.count = g_pwmstate.count;
 



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1833: examples/pwm: Fix duty cycle overflow

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1833:
URL: https://github.com/apache/nuttx-apps/pull/1833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated (8ef5f02b66 -> 8277229f53)

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 8ef5f02b66 libs: fix visual studio Compiler Error C2036
 add 8277229f53 nxstyle: covert utf-8 to ascii

No new revisions were added by this update.

Summary of changes:
 libs/libc/stdio/lib_libgetstreams.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9815: nxstyle: covert utf-8 to ascii

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9815:
URL: https://github.com/apache/nuttx/pull/9815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: libs: fix visual studio Compiler Error C2036

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 8ef5f02b66 libs: fix visual studio Compiler Error C2036
8ef5f02b66 is described below

commit 8ef5f02b66f8af756e423332c519c33ec9d046ae
Author: chao an 
AuthorDate: Thu Jul 13 22:21:47 2023 +0800

libs: fix visual studio Compiler Error C2036

D:\code\nuttx\include\nuttx\net\netfilter\ip_tables.h(288,42): error C2036: 
"void *" : unknown size

Reference:

https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2036?view=msvc-170

Signed-off-by: chao an 
---
 include/nuttx/net/netfilter/ip_tables.h | 2 +-
 mm/mempool/mempool_multiple.c   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/nuttx/net/netfilter/ip_tables.h 
b/include/nuttx/net/netfilter/ip_tables.h
index e3750a6310..d5017fa6ea 100644
--- a/include/nuttx/net/netfilter/ip_tables.h
+++ b/include/nuttx/net/netfilter/ip_tables.h
@@ -285,7 +285,7 @@ struct ipt_get_entries
 static inline FAR struct xt_entry_target *
 ipt_get_target(FAR struct ipt_entry *e)
 {
-  return (FAR void *)e + e->target_offset;
+  return (FAR char *)e + e->target_offset;
 }
 
 #endif /* __INCLUDE_NUTTX_NET_NETFILTER_IP_TABLES_H */
diff --git a/mm/mempool/mempool_multiple.c b/mm/mempool/mempool_multiple.c
index 1885a9b568..67cf1a8416 100644
--- a/mm/mempool/mempool_multiple.c
+++ b/mm/mempool/mempool_multiple.c
@@ -193,13 +193,13 @@ retry:
 }
 
   ret = (FAR void *)ALIGN_UP(chunk->next, align);
-  if (chunk->end - ret < size)
+  if ((uintptr_t)chunk->end - (uintptr_t)ret < size)
 {
   goto retry;
 }
 
   chunk->used++;
-  chunk->next = ret + size;
+  chunk->next = (FAR char *)ret + size;
   return ret;
 }
 
@@ -738,7 +738,7 @@ mempool_multiple_mallinfo(FAR struct mempool_multiple_s 
*mpool)
   FAR struct mpool_chunk_s *chunk;
 
   chunk = (FAR struct mpool_chunk_s *)sq_peek(>chunk_queue);
-  info.fordblks += chunk->end - chunk->next;
+  info.fordblks += (uintptr_t)chunk->end - (uintptr_t)chunk->next;
 }
 
   nxmutex_unlock(>lock);



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9818: libs: fix visual studio Compiler Error C2036

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9818:
URL: https://github.com/apache/nuttx/pull/9818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9817: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread via GitHub


xiaoxiang781216 commented on code in PR #9817:
URL: https://github.com/apache/nuttx/pull/9817#discussion_r1262857706


##
drivers/net/netdev_upperhalf.c:
##
@@ -554,6 +554,7 @@ int netdev_upper_wireless_ioctl(FAR struct 
netdev_lowerhalf_s *lower,
   FAR const struct wireless_ops_s *ops = lower->iw_ops;
   const struct ether_addr zero =
 {
+  0

Review Comment:
   let's define a static const or fill the full field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9706: libs/libc:Add support for gdb rsp protocol

2023-07-13 Thread via GitHub


xiaoxiang781216 commented on PR #9706:
URL: https://github.com/apache/nuttx/pull/9706#issuecomment-1634622889

   @anjiahao1 please normalize your config:
   ```
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 338: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
 Normalize stm32f429i-disco/gdbstub
   55d54
   < CONFIG_SYSTEM_GDBSTUB=y
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: win/MSVC: add packed_struct macro implement

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 54740b3ad2 win/MSVC: add packed_struct macro implement
54740b3ad2 is described below

commit 54740b3ad21f3b62334ee2956a0dedf00af778de
Author: chao an 
AuthorDate: Thu Jul 13 22:45:30 2023 +0800

win/MSVC: add packed_struct macro implement

Signed-off-by: chao an 
---
 include/nuttx/compiler.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/nuttx/compiler.h b/include/nuttx/compiler.h
index fdf0435a71..cfebbf8ad8 100644
--- a/include/nuttx/compiler.h
+++ b/include/nuttx/compiler.h
@@ -880,8 +880,8 @@
 #  define aligned_data(n)
 #  define locate_code(n)
 #  define locate_data(n)
-#  define begin_packed_struct
-#  define end_packed_struct
+#  define begin_packed_struct __pragma(pack(push, 1))
+#  define end_packed_struct __pragma(pack(pop))
 #  define reentrant_function
 #  define naked_function
 #  define always_inline_function



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9816: win/MSVC: add packed_struct macro implement

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9816:
URL: https://github.com/apache/nuttx/pull/9816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated (b0965ab963 -> b7216d54ff)

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from b0965ab963 Fix nuttx coding style
 add b7216d54ff arm64: Use the correct cpu id for fpu idle task init

No new revisions were added by this update.

Summary of changes:
 arch/arm64/src/common/arm64_fpu.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9811: arm64: Use the correct cpu id for fpu idle task init

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9811:
URL: https://github.com/apache/nuttx/pull/9811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: Fix nuttx coding style

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new b0965ab963 Fix nuttx coding style
b0965ab963 is described below

commit b0965ab9631ed923924b3ec93102f13851fff8f4
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
AuthorDate: Thu Jul 13 15:50:40 2023 +0200

Fix nuttx coding style

Remove TABs
Fix indentation
Fix Multi-line comments
Fix Comments to the Right of Statements.
---
 arch/arm/src/cxd56xx/cxd56_dmac.c  |  46 ++---
 arch/arm/src/cxd56xx/cxd56_dmac.h  |  10 +-
 arch/arm/src/efm32/hardware/efm32_rmu.h| 206 ++---
 arch/arm/src/phy62xx/rom_sym_def.h |   4 +-
 arch/arm64/src/a64/hardware/a64_twi.h  |  44 ++---
 arch/arm64/src/common/arm64_arch_timer.h   |   6 +-
 arch/risc-v/src/esp32c3/esp32c3_bignum.h   |  18 +-
 arch/risc-v/src/esp32c3/esp32c3_efuse.h|  40 ++--
 arch/risc-v/src/esp32c3/esp32c3_rsa.h  |  40 ++--
 arch/risc-v/src/esp32c3/hardware/esp32c3_iomux.h   |  46 ++---
 arch/risc-v/src/esp32c3/hardware/esp32c3_rtccntl.h |   4 +-
 arch/risc-v/src/hpm6750/hpm6750_serial.h   |  72 ---
 arch/risc-v/src/litex/hardware/litex_uart.h|   4 +-
 arch/x86/include/i486/irq.h|   2 +-
 arch/xtensa/include/esp32/memory_layout.h  |   4 +-
 arch/xtensa/src/esp32/chip_macros.h|   2 +-
 arch/xtensa/src/esp32/hardware/esp32_dport.h   |  10 +-
 arch/xtensa/src/esp32/hardware/esp32_tim.h |  94 +-
 arch/xtensa/src/esp32s2/esp32s2_efuse.h|  40 ++--
 arch/xtensa/src/esp32s2/esp32s2_serial.c   |   2 +-
 .../src/esp32s2/hardware/esp32s2_gpio_sigmap.h |   4 +-
 arch/xtensa/src/esp32s3/chip_macros.h  |   2 +-
 arch/xtensa/src/esp32s3/esp32s3_efuse.h|  40 ++--
 arch/xtensa/src/esp32s3/hardware/esp32s3_soc.h |   2 +-
 boards/arm/cxd56xx/drivers/sensors/bmi160_scu.c|   4 +-
 .../arm/cxd56xx/spresense/include/cxd56_gpioif.h   |  18 +-
 boards/arm/imxrt/imxrt1020-evk/src/imxrt1020-evk.h |   2 +-
 boards/arm/lpc43xx/lpc4337-ws/include/board.h  |  34 ++--
 boards/arm/lpc43xx/lpc4370-link2/include/board.h   |  34 ++--
 boards/arm/samd5e5/metro-m4/include/board.h|   4 +-
 .../stm32h745i-disco/src/stm32h745i_disco.h|   6 +-
 drivers/modem/alt1250/altcom_pkt.h |   6 +-
 drivers/sensors/bmi270.c   |   2 +-
 33 files changed, 423 insertions(+), 429 deletions(-)

diff --git a/arch/arm/src/cxd56xx/cxd56_dmac.c 
b/arch/arm/src/cxd56xx/cxd56_dmac.c
index e5cf71d88a..f4b6cdec13 100644
--- a/arch/arm/src/cxd56xx/cxd56_dmac.c
+++ b/arch/arm/src/cxd56xx/cxd56_dmac.c
@@ -147,29 +147,29 @@ typedef struct
   uint32_t control;   /* Transfer control */
 } dmac_lli_t;
 
-#define CXD56_DMAC_M2M   0  /**< Memory to memory */
-#define CXD56_DMAC_M2P   1  /**< Memory to peripheral, DMAC controlled */
-#define CXD56_DMAC_P2M   2  /**< Peripheral to memory, DMAC controlled */
-#define CXD56_DMAC_P2P   3  /**< Peripheral to peripheral */
-#define CXD56_DMAC_P2CP  4  /**< P2P destination controlled */
-#define CXD56_DMAC_M2CP  5  /**< M2P peripheral controlled */
-#define CXD56_DMAC_CP2M  6  /**< P2M peripheral controlled */
-#define CXD56_DMAC_CP2P  7  /**< P2P source controlled */
-
-#define CXD56_DMAC_BSIZE10 /**< 1 burst */
-#define CXD56_DMAC_BSIZE41 /**< 4 burst */
-#define CXD56_DMAC_BSIZE82 /**< 8 burst */
-#define CXD56_DMAC_BSIZE16   3 /**< 16 burst */
-#define CXD56_DMAC_BSIZE32   4 /**< 32 burst */
-#define CXD56_DMAC_BSIZE64   5 /**< 64 burst */
-#define CXD56_DMAC_BSIZE128  6 /**< 128 burst */
-#define CXD56_DMAC_BSIZE256  7 /**< 256 burst */
-
-#define CXD56_DMAC_LITTLE_ENDIAN  0  /**< Little endian */
-#define CXD56_DMAC_BIG_ENDIAN 1  /**< Bit endian */
-
-#define CXD56_DMAC_MASTER1 0 /**< AHB master 1 */
-#define CXD56_DMAC_MASTER2 1 /**< AHB master 2 */
+#define CXD56_DMAC_M2M   0  /* Memory to memory */
+#define CXD56_DMAC_M2P   1  /* Memory to peripheral, DMAC controlled */
+#define CXD56_DMAC_P2M   2  /* Peripheral to memory, DMAC controlled */
+#define CXD56_DMAC_P2P   3  /* Peripheral to peripheral */
+#define CXD56_DMAC_P2CP  4  /* P2P destination controlled */
+#define CXD56_DMAC_M2CP  5  /* M2P peripheral controlled */
+#define CXD56_DMAC_CP2M  6  /* P2M peripheral controlled */
+#define CXD56_DMAC_CP2P  7  /* P2P source controlled */
+
+#define CXD56_DMAC_BSIZE10 /* 1 burst */
+#define CXD56_DMAC_BSIZE41 /* 4 burst */
+#define CXD56_DMAC_BSIZE82 /* 8 burst */
+#define CXD56_DMAC_BSIZE16   3 /* 16 burst */
+#define CXD56_DMAC_BSIZE32   4 /* 32 burst */
+#define CXD56_DMAC_BSIZE64   5

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9813: Fix nuttx coding style

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9813:
URL: https://github.com/apache/nuttx/pull/9813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated (601202ee4a -> d8797bde4e)

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 601202ee4a arm64: Use the correct aff in up_affinity_irq function
 add d8797bde4e arm_gicv2: accesses the non-secure copy in non-secure state

No new revisions were added by this update.

Summary of changes:
 arch/arm/src/armv7-a/arm_gicv2.c | 6 +++---
 arch/arm/src/armv7-r/arm_gicv2.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9810: arm64: Use the correct aff in up_affinity_irq function

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9810:
URL: https://github.com/apache/nuttx/pull/9810


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: arm64: Use the correct aff in up_affinity_irq function

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 601202ee4a arm64: Use the correct aff in up_affinity_irq function
601202ee4a is described below

commit 601202ee4ac86735bd7dc72e2f97bb3cad2f22d2
Author: zhangyuan21 
AuthorDate: Tue Jul 11 09:51:02 2023 +0800

arm64: Use the correct aff in up_affinity_irq function

Signed-off-by: zhangyuan21 
---
 arch/arm64/src/common/arm64_arch.h  |  2 +-
 arch/arm64/src/common/arm64_gicv3.c | 10 --
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/src/common/arm64_arch.h 
b/arch/arm64/src/common/arm64_arch.h
index b3361b8f6f..ecf9733d05 100644
--- a/arch/arm64/src/common/arm64_arch.h
+++ b/arch/arm64/src/common/arm64_arch.h
@@ -184,7 +184,7 @@
   ({ \
 uint64_t __mpidr = GET_MPIDR(); \
 __mpidr &= ~(MPIDR_AFFLVL_MASK << MPIDR_AFF ## aff_level ## _SHIFT); \
-__mpidr |= (cpu << MPIDR_AFF ## aff_level ## _SHIFT); \
+__mpidr |= ((core) << MPIDR_AFF ## aff_level ## _SHIFT); \
 __mpidr &= MPIDR_ID_MASK; \
 __mpidr; \
   })
diff --git a/arch/arm64/src/common/arm64_gicv3.c 
b/arch/arm64/src/common/arm64_gicv3.c
index 20ddd5edaf..e4dc93212b 100644
--- a/arch/arm64/src/common/arm64_gicv3.c
+++ b/arch/arm64/src/common/arm64_gicv3.c
@@ -53,6 +53,7 @@
  * selects distributor base for SPI
  * The macro translates to distributor base for GICv2 and GICv1
  */
+
 #define GET_DIST_BASE(intid)  ((intid < GIC_SPI_INT_BASE) ?  \
(gic_get_rdist() + GICR_SGI_BASE_OFF) \
: GIC_DIST_BASE)
@@ -245,7 +246,7 @@ void arm64_gic_irq_enable(unsigned int intid)
 
   if (GIC_IS_SPI(intid))
 {
-  arm64_gic_write_irouter(up_cpu_index(), intid);
+  arm64_gic_write_irouter((GET_MPIDR() & MPIDR_ID_MASK), intid);
 }
 }
 
@@ -615,7 +616,12 @@ void up_affinity_irq(int irq, cpu_set_t cpuset)
 {
   if (GIC_IS_SPI(irq))
 {
-  arm64_gic_write_irouter(cpuset, irq);
+  /* Only support interrupt routing mode 0,
+   * so routing to the first cpu in cpuset.
+   */
+
+  uint64_t mpid = arm64_get_mpid(ffs(cpuset) - 1);
+  arm64_gic_write_irouter(mpid, irq);
 }
 }
 



[nuttx-apps] branch master updated (73b888869 -> 7cfcb4921)

2023-07-13 Thread raiden00
This is an automated email from the ASF dual-hosted git repository.

raiden00 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


from 73b69 gdbstub:Support a general gdbstub, support serial port and 
network link
 add 7cfcb4921 cmake/apps: add more applications into cmake support

No new revisions were added by this update.

Summary of changes:
 examples/mtdpart/CMakeLists.txt|  2 +-
 examples/mtdrwb/CMakeLists.txt |  3 +-
 examples/nettest/host/CMakeLists.txt   |  4 +--
 examples/usrsocktest/CMakeLists.txt| 37 +-
 fsutils/flash_eraseall/CMakeLists.txt  |  2 +-
 fsutils/mksmartfs/CMakeLists.txt   |  2 +-
 netutils/iperf/CMakeLists.txt  | 17 +-
 system/nxplayer/CMakeLists.txt |  6 
 .../buttons => testing/fstest}/CMakeLists.txt  | 12 +++
 {examples/adc => testing/nxffs}/CMakeLists.txt |  6 ++--
 {netutils => wireless/bluetooth}/CMakeLists.txt|  4 +--
 .../bluetooth/btsak}/CMakeLists.txt| 23 ++
 12 files changed, 92 insertions(+), 26 deletions(-)
 copy {examples/buttons => testing/fstest}/CMakeLists.txt (83%)
 copy {examples/adc => testing/nxffs}/CMakeLists.txt (89%)
 copy {netutils => wireless/bluetooth}/CMakeLists.txt (90%)
 copy {system/netdb => wireless/bluetooth/btsak}/CMakeLists.txt (72%)



[GitHub] [nuttx-apps] raiden00pl merged pull request #1832: cmake/apps: add more applications into cmake support

2023-07-13 Thread via GitHub


raiden00pl merged PR #1832:
URL: https://github.com/apache/nuttx-apps/pull/1832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1835: cmake: add support for boot utils

2023-07-13 Thread via GitHub


raiden00pl opened a new pull request, #1835:
URL: https://github.com/apache/nuttx-apps/pull/1835

   ## Summary
   cmake: add support for boot utils
   ## Impact
   
   ## Testing
   nrf52/nrf91
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] raiden00pl opened a new pull request, #9820: cmake: improvements

2023-07-13 Thread via GitHub


raiden00pl opened a new pull request, #9820:
URL: https://github.com/apache/nuttx/pull/9820

   ## Summary
   
   - cmake: avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24
   - cmake: allow nuttx_add_application to inherit includes from dependent 
target
   - cmake: cmse support for armv8-m
   
   ## Impact
   
   ## Testing
   nrf52840-dk/mcuboot_app
   nrf52840-dk/mcuboot_loader
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9819: cmake/win32: set default LINK_STACKSIZE to avoid stack overflow

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9819:
URL: https://github.com/apache/nuttx/pull/9819

   ## Summary
   
   cmake/win32: set default LINK_STACKSIZE to avoid stack overflow
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   cmake 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] anchao opened a new pull request, #1834: testing/ostest: fix Compiler Warning (level 1) C4716: 'function' must return a value

2023-07-13 Thread via GitHub


anchao opened a new pull request, #1834:
URL: https://github.com/apache/nuttx-apps/pull/1834

   ## Summary
   
   testing/ostest: fix Compiler Warning (level 1) C4716: 'function' must return 
a value
   
   
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4716?view=msvc-170
   Signed-off-by: chao an 
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9818: libs: fix visual studio Compiler Error C2036

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9818:
URL: https://github.com/apache/nuttx/pull/9818

   ## Summary
   
   libs: fix visual studio Compiler Error C2036
   
   D:\code\nuttx\include\nuttx\net\netfilter\ip_tables.h(288,42): error C2036: 
"void *" : unknown size
   
   Reference:
   
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2036?view=msvc-170
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9817: netdev/upperhalf: fix visual studio Compiler Error C2059

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9817:
URL: https://github.com/apache/nuttx/pull/9817

   
   ## Summary
   
   netdev/upperhalf:  fix visual studio Compiler Error C2059
   
   
   D:\archer\code\nuttx\drivers\net\netdev_upperhalf.c(557,5): error C2059: 
syntax error : '{'
   
   Compiler error C2059:
   The token caused a syntax error.
   
   Reference:
   
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2059?view=msvc-170
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9816: win/MSVC: add packed_struct macro implement

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9816:
URL: https://github.com/apache/nuttx/pull/9816

   ## Summary
   
   win/MSVC: add packed_struct macro implement
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9815: nxstyle: covert utf-8 to ascii

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9815:
URL: https://github.com/apache/nuttx/pull/9815

   ## Summary
   
   nxstyle: covert utf-8 to ascii
   
   libs/libc/stdio/lib_libgetstreams.c: C source, UTF-8 Unicode text
   ->
   libs/libc/stdio/lib_libgetstreams.c: C source, ASCII text
   
   Signed-off-by: chao an 
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on a diff in pull request #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full

2023-07-13 Thread via GitHub


acassis commented on code in PR #9792:
URL: https://github.com/apache/nuttx/pull/9792#discussion_r1261147196


##
net/udp/udp_callback.c:
##
@@ -228,10 +228,6 @@ net_dataevent(FAR struct net_driver_s *dev, FAR struct 
udp_conn_s *conn,
*/
 
  ninfo("Dropped %d bytes\n", dev->d_len);
-
-#ifdef CONFIG_NET_STATISTICS
-  g_netstats.udp.drop++;
-#endif

Review Comment:
   Why net statistics for UDP packet drop is not increased in this case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on issue #6082: Export Make.defs broken, missing HEAD_OBJ, LDENDGROUP, LDSTARTGROUP

2023-07-13 Thread via GitHub


acassis commented on issue #6082:
URL: https://github.com/apache/nuttx/issues/6082#issuecomment-1634339561

   @ppisa maybe we need to open an issue to get library support for CMakefiles 
too!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] lucasssvaz opened a new pull request, #1833: examples/pwm: Fix duty cycle overflow

2023-07-13 Thread via GitHub


lucasssvaz opened a new pull request, #1833:
URL: https://github.com/apache/nuttx-apps/pull/1833

   ## Summary
   
   This commit fixes the overflow that happens when setting the duty cycle to 
100% in the PWM example. It now correctly passes the value `0x` rather than 
`0x` when setting the duty cycle to 100 and makes sure that no underflow 
happens when setting the duty cycle to 0.
   
   ## Impact
   
   Correct handling of the duty cycle range in the PWM example.
   
   ## Testing
   
   `esp32c3-devkit:pwm`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] yintao707 opened a new pull request, #9814: net/local: Support the abstract path to connect

2023-07-13 Thread via GitHub


yintao707 opened a new pull request, #9814:
URL: https://github.com/apache/nuttx/pull/9814

   ## Summary
   Support the abstract path to connect
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] yintao707 closed pull request #9812: net/local: Support the abstract path to connect

2023-07-13 Thread via GitHub


yintao707 closed pull request #9812: net/local: Support the abstract path to 
connect
URL: https://github.com/apache/nuttx/pull/9812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] simbit18 opened a new pull request, #9813: Fix nuttx coding style

2023-07-13 Thread via GitHub


simbit18 opened a new pull request, #9813:
URL: https://github.com/apache/nuttx/pull/9813

   ## Summary
   Remove TABs
   Fix indentation
   Fix Multi-line comments
   Fix Comments to the Right of Statements.
   ## Impact
   none
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] yintao707 opened a new pull request, #9812: net/local: Support the abstract path to connect

2023-07-13 Thread via GitHub


yintao707 opened a new pull request, #9812:
URL: https://github.com/apache/nuttx/pull/9812

   ## Summary
   Support the abstract path to connect
   
   ## Impact
   None
   
   ## Testing
   Pass vela CI
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] michi-jung commented on issue #8833: w5500 ethernet can not work well

2023-07-13 Thread via GitHub


michi-jung commented on issue #8833:
URL: https://github.com/apache/nuttx/issues/8833#issuecomment-1634210413

   @laoniaokkk It would be nice to have the 
`boards/arm/stm32/stm32f4discovery/ether_w5500` configuration running out of 
the box on upstream nuttx.  Could you take care of this?  I do not have access 
to this board.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] laoniaokkk commented on issue #8833: w5500 ethernet can not work well

2023-07-13 Thread via GitHub


laoniaokkk commented on issue #8833:
URL: https://github.com/apache/nuttx/issues/8833#issuecomment-1634200870

   > 
   I'm just modifying it(stm32_w5500.c  and stm32_exit_gpio.c) based on your 
docs. The drive of w5500 is correct, and actually your configuration of 
stm32_w5500 is valid
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] acassis commented on pull request #9761: Add supoort for hpm6360evk

2023-07-13 Thread via GitHub


acassis commented on PR #9761:
URL: https://github.com/apache/nuttx/pull/9761#issuecomment-1634177465

   > > @freakishness @pkarashchenko any idea why @liuzhao commit "add support 
for YT8512 phy" is in the middle of this PR?
   > 
   > This is my mistake, should I resubmit?
   
   I think can fix it using git rebase interactive, don't need to close and 
remove a new PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] zyfeier opened a new pull request, #9811: arm64: Use the correct cpu id for fpu idle task init

2023-07-13 Thread via GitHub


zyfeier opened a new pull request, #9811:
URL: https://github.com/apache/nuttx/pull/9811

   ## Summary
   
   Use the correct cpu id for fpu idle task init.
   
   ## Impact
   
   ARM64
   
   ## Testing
   
   fvp-armv8r:nsh_smp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] zyfeier opened a new pull request, #9810: arm64: Use the correct aff in up_affinity_irq function

2023-07-13 Thread via GitHub


zyfeier opened a new pull request, #9810:
URL: https://github.com/apache/nuttx/pull/9810

   ## Summary
   
   Fixed spi affinity fail issuue, set the correct aff in irouter register.
   
   ## Impact
   
   arm64 gicv3
   
   ## Testing
   
   fvp-armv8r:nsh_smp spi test case:
   ```
   irq_attach(i, irq_test_isr, NULL);
   up_enable_irq(i);
   up_affinity_irq(i, cpuset);
   up_trigger_irq(i, cpuset);
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] michi-jung commented on issue #8833: w5500 ethernet can not work well

2023-07-13 Thread via GitHub


michi-jung commented on issue #8833:
URL: https://github.com/apache/nuttx/issues/8833#issuecomment-1634139783

   @laoniaokkk Would you be willing to bring your fix upstream?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: net: Add msg_peek support for udp and tcp

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 57bf3e1fea net: Add msg_peek support for udp and tcp
57bf3e1fea is described below

commit 57bf3e1feae599aec41ba25c175e36c85611998e
Author: wangyingdong 
AuthorDate: Thu May 25 19:52:41 2023 +0800

net: Add msg_peek support for udp and tcp

Signed-off-by: wangyingdong 
---
 net/tcp/tcp_recvfrom.c | 21 +
 net/udp/udp_recvfrom.c | 34 --
 2 files changed, 41 insertions(+), 14 deletions(-)

diff --git a/net/tcp/tcp_recvfrom.c b/net/tcp/tcp_recvfrom.c
index c3c3f08cd9..68379418a1 100644
--- a/net/tcp/tcp_recvfrom.c
+++ b/net/tcp/tcp_recvfrom.c
@@ -57,6 +57,7 @@ struct tcp_recvfrom_s
   FAR socklen_t   *ir_fromlen;   /* Number of bytes allocated for 
address of sender */
   ssize_t  ir_recvlen;   /* The received length */
   int  ir_result;/* Success:OK, failure:negated errno 
*/
+  int  ir_flags; /* Flags on received message.  */
 };
 
 /
@@ -135,7 +136,8 @@ static size_t tcp_recvfrom_newdata(FAR struct net_driver_s 
*dev,
 
   /* Trim the copied buffers */
 
-  dev->d_iob = iob_trimhead(dev->d_iob, recvlen + offset);
+  dev->d_iob = iob_trimhead(dev->d_iob,
+  pstate->ir_flags & MSG_PEEK ? offset : recvlen + offset);
 
   ninfo("Received %d bytes (of %d)\n", (int)recvlen, (int)dev->d_len);
 
@@ -143,7 +145,7 @@ static size_t tcp_recvfrom_newdata(FAR struct net_driver_s 
*dev,
 
   tcp_update_recvlen(pstate, recvlen);
 
-  return recvlen;
+  return pstate->ir_flags & MSG_PEEK ? 0: recvlen;
 }
 
 /
@@ -261,6 +263,15 @@ static inline void tcp_readahead(struct tcp_recvfrom_s 
*pstate)
 
   tcp_update_recvlen(pstate, recvlen);
 
+  /* If it is in read-ahead mode,
+   * exit directly to avoid iob being released
+   */
+
+  if (pstate->ir_flags & MSG_PEEK)
+{
+  break;
+}
+
   /* If we took all of the data from the I/O buffer chain is empty, then
* release it.  If there is still data available in the I/O buffer
* chain, then just trim the data that we have taken from the
@@ -511,7 +522,8 @@ static void tcp_recvfrom_initialize(FAR struct tcp_conn_s 
*conn,
 FAR void *buf, size_t len,
 FAR struct sockaddr *infrom,
 FAR socklen_t *fromlen,
-FAR struct tcp_recvfrom_s *pstate)
+FAR struct tcp_recvfrom_s *pstate,
+int flags)
 {
   /* Initialize the state structure. */
 
@@ -522,6 +534,7 @@ static void tcp_recvfrom_initialize(FAR struct tcp_conn_s 
*conn,
   pstate->ir_buffer= buf;
   pstate->ir_from  = infrom;
   pstate->ir_fromlen   = fromlen;
+  pstate->ir_flags = flags;
 
   /* Set up the start time for the timeout */
 
@@ -612,7 +625,7 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR 
struct msghdr *msg,
* because we don't want anything to happen until we are ready.
*/
 
-  tcp_recvfrom_initialize(conn, buf, len, from, fromlen, );
+  tcp_recvfrom_initialize(conn, buf, len, from, fromlen, , flags);
 
   /* Handle any any TCP data already buffered in a read-ahead buffer.  NOTE
* that there may be read-ahead data to be retrieved even after the
diff --git a/net/udp/udp_recvfrom.c b/net/udp/udp_recvfrom.c
index e24690a5ba..e96543ff89 100644
--- a/net/udp/udp_recvfrom.c
+++ b/net/udp/udp_recvfrom.c
@@ -56,6 +56,7 @@ struct udp_recvfrom_s
   sem_tir_sem;   /* Semaphore signals recv completion 
*/
   ssize_t  ir_recvlen;   /* The received length */
   int  ir_result;/* Success:OK, failure:negated errno 
*/
+  int  ir_flags; /* Flags on received message.  */
 };
 
 /
@@ -208,11 +209,14 @@ static inline void udp_readahead(struct udp_recvfrom_s 
*pstate)
* buffer queue.
*/
 
-  iob_remove_queue(>readahead);
+  if (!(pstate->ir_flags & MSG_PEEK))
+{
+  iob_remove_queue(>readahead);
 
-  /* And free the I/O buffer chain */
+  /* And free the I/O buffer chain */
 
-  iob_free_chain(iob);
+  iob_free_chain(iob);
+}
 }
 }
 
@@ -422,13 +426,21 @@ static uint16_t udp_eventhandler(FAR struct net_driver_s 
*dev,
 
   udp_terminate(pstate, OK);
 
-  /* Indicate that the data has been consumed */
+  /* In read-ahead mode, UDP_NEWDATA and 

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9791: net: Add msg_peek support for udp and tcp

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9791:
URL: https://github.com/apache/nuttx/pull/9791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] xiaoxiang781216 merged pull request #9789: libs/libc/getpgid: add getpgid implementation

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9789:
URL: https://github.com/apache/nuttx/pull/9789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: libs/libc/getpgid: add getpgid implementation

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 79af1cdfe6 libs/libc/getpgid: add getpgid implementation
79af1cdfe6 is described below

commit 79af1cdfe6ada47db2e5827f6c1ab12dd26271ed
Author: guoshichao 
AuthorDate: Sat Jul 8 16:49:26 2023 +0800

libs/libc/getpgid: add getpgid implementation

1. the getpgid function can help to pass the
ltp/open_posix_testsuite/killpg related testcases
2. NuttX do not support process group, so we use the process id as
process group id
3. the implementation are referred to: 
https://pubs.opengroup.org/onlinepubs/9699919799/functions/getpgid.html

Signed-off-by: guoshichao 
---
 include/unistd.h   |  1 +
 libs/libc/unistd/Make.defs |  2 +-
 libs/libc/unistd/lib_getpgid.c | 73 ++
 3 files changed, 75 insertions(+), 1 deletion(-)

diff --git a/include/unistd.h b/include/unistd.h
index b712982311..a3c6ace08d 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -310,6 +310,7 @@ extern "C"
 pid_t   fork(void);
 pid_t   vfork(void);
 pid_t   getpid(void);
+pid_t   getpgid(pid_t pid);
 pid_t   getpgrp(void);
 pid_t   gettid(void);
 pid_t   getppid(void);
diff --git a/libs/libc/unistd/Make.defs b/libs/libc/unistd/Make.defs
index 352979caf1..d480781929 100644
--- a/libs/libc/unistd/Make.defs
+++ b/libs/libc/unistd/Make.defs
@@ -30,7 +30,7 @@ CSRCS += lib_setreuid.c lib_setregid.c lib_getrusage.c 
lib_utime.c lib_utimes.c
 CSRCS += lib_setrlimit.c lib_getrlimit.c lib_setpriority.c lib_getpriority.c
 CSRCS += lib_futimes.c lib_lutimes.c lib_gethostname.c lib_sethostname.c
 CSRCS += lib_fchownat.c lib_linkat.c lib_readlinkat.c lib_symlinkat.c
-CSRCS += lib_unlinkat.c lib_getpgrp.c
+CSRCS += lib_unlinkat.c lib_getpgrp.c lib_getpgid.c
 
 ifneq ($(CONFIG_SCHED_USER_IDENTITY),y)
 CSRCS += lib_setuid.c lib_setgid.c lib_getuid.c lib_getgid.c
diff --git a/libs/libc/unistd/lib_getpgid.c b/libs/libc/unistd/lib_getpgid.c
new file mode 100644
index 00..d09bceb9b2
--- /dev/null
+++ b/libs/libc/unistd/lib_getpgid.c
@@ -0,0 +1,73 @@
+/
+ * libs/libc/unistd/lib_getpgid.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include 
+#include 
+
+#include 
+#include 
+
+/
+ * Public Functions
+ /
+
+/
+ * Name: getpgid
+ *
+ * Description:
+ *   Get the Process Group ID of the required process id. But since NuttX do
+ *   not support process group, so the process group id are same as process
+ *   id, so this method will return the pid that transferred in directly,
+ *   which is same as getpgrp() method
+ *
+ * Input parameters:
+ *   pid - the process id that required to fetch the process group id
+ *
+ * Returned Value:
+ *   getpgid() shall return a process group ID. Otherwise, it shall return
+ *   (pid_t)-1 and set errno to indicate the error. If the given process id
+ *   are invalid, set errno as EINVAL, if the given process id do not exist,
+ *   set errno as ESRCH
+ *
+ /
+
+pid_t getpgid(pid_t pid)
+{
+  if (pid < 0)
+{
+  set_errno(EINVAL);
+  return INVALID_PROCESS_ID;
+}
+
+  if (pid == 0)
+{
+  return getpgrp();
+}
+  else if (_SIG_KILL(pid, 0) < 0)
+{
+  return INVALID_PROCESS_ID;
+}
+
+  return pid;
+}



[nuttx-apps] branch master updated: gdbstub:Support a general gdbstub, support serial port and network link

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new 73b69 gdbstub:Support a general gdbstub, support serial port and 
network link
73b69 is described below

commit 73b69b78b4e106aa527761ba0e0f204835b4
Author: anjiahao 
AuthorDate: Tue Jun 27 17:42:19 2023 +0800

gdbstub:Support a general gdbstub, support serial port and network link

Partially implement the gdb rsp protocol,
you can debug the nuttx kernel through the serial port or the network

Signed-off-by: anjiahao 
---
 system/gdbstub/Kconfig   |  25 +
 system/gdbstub/Make.defs |  23 +
 system/gdbstub/Makefile  |  30 ++
 system/gdbstub/gdbstub.c | 250 +++
 4 files changed, 328 insertions(+)

diff --git a/system/gdbstub/Kconfig b/system/gdbstub/Kconfig
new file mode 100644
index 0..31c833b3b
--- /dev/null
+++ b/system/gdbstub/Kconfig
@@ -0,0 +1,25 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config SYSTEM_GDBSTUB
+   tristate "GDBSTUB"
+   ---help---
+   Enable support for gdbstub.
+
+if SYSTEM_GDBSTUB
+
+config SYSTEM_GDBSTUB_STACKSIZE
+   int "gdbstub stack size"
+   default DEFAULT_TASK_STACKSIZE
+   ---help---
+   The size of stack allocated for the gdbstub task.
+
+config SYSTEM_GDBSTUB_PRIORITY
+   int "gdbstub priority"
+   default 100
+   ---help---
+   The priority of the gdbstub task.
+
+endif
diff --git a/system/gdbstub/Make.defs b/system/gdbstub/Make.defs
new file mode 100644
index 0..9324d49a1
--- /dev/null
+++ b/system/gdbstub/Make.defs
@@ -0,0 +1,23 @@
+
+# apps/system/gdbstub/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+ifneq ($(CONFIG_SYSTEM_GDBSTUB),)
+CONFIGURED_APPS += $(APPDIR)/system/gdbstub
+endif
diff --git a/system/gdbstub/Makefile b/system/gdbstub/Makefile
new file mode 100644
index 0..75df5cdf6
--- /dev/null
+++ b/system/gdbstub/Makefile
@@ -0,0 +1,30 @@
+
+# apps/system/gdbstub/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+include $(APPDIR)/Make.defs
+
+PROGNAME = gdbstub
+PRIORITY = $(CONFIG_SYSTEM_GDBSTUB_PRIORITY)
+STACKSIZE = $(CONFIG_SYSTEM_GDBSTUB_STACKSIZE)
+MODULE = $(CONFIG_SYSTEM_GDBSTUB)
+
+MAINSRC = gdbstub.c
+
+include $(APPDIR)/Application.mk
diff --git a/system/gdbstub/gdbstub.c b/system/gdbstub/gdbstub.c
new file mode 100644
index 0..b1dd7c594
--- /dev/null
+++ b/system/gdbstub/gdbstub.c
@@ -0,0 +1,250 @@
+/
+ * apps/system/gdbstub/gdbstub.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ 

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1822: gdbstub:Support a general gdbstub, support serial port and network link

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1822:
URL: https://github.com/apache/nuttx-apps/pull/1822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx] branch master updated: Fix nuttx coding style

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 1b1ac6f3b7 Fix nuttx coding style
1b1ac6f3b7 is described below

commit 1b1ac6f3b7fe9349c0a83007d3e8958e97597c87
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
AuthorDate: Thu Jul 13 09:52:33 2023 +0200

Fix nuttx coding style

Remove TABs
Fix indentation
Fix Multi-line comments
Fix Comments to the Right of Statements.

Fix nuttx coding style

Fix Comments to the Right of Statements.
---
 arch/arm/include/cxd56xx/pm.h  |  44 +-
 arch/arm/src/rtl8720c/amebaz_coex.h|   8 +-
 arch/arm/src/s32k3xx/hardware/s32k3xx_dmamux.h |   4 +-
 arch/arm/src/samd5e5/sam_usb.c | 109 ++--
 arch/arm/src/samd5e5/sam_wdt.c |   2 +-
 arch/arm/src/stm32/stm32_waste.h   |  16 +-
 arch/arm/src/stm32f7/stm32_waste.h |  16 +-
 arch/risc-v/src/esp32c3/hardware/esp32c3_saradc.h  | 172 +++---
 .../src/esp32c3/hardware/esp32c3_usb_serial_jtag.h |  78 +--
 arch/sparc/include/sparc_v8/irq.h  | 171 +++---
 arch/sparc/src/bm3803/bm3803-uart.h|  34 +-
 arch/sparc/src/s698pm/s698pm-uart.h|   4 +-
 arch/xtensa/src/esp32/esp32_spi_slave.c|   4 +-
 arch/xtensa/src/esp32s3/esp32s3_psram_octal.c  |  48 +-
 .../src/esp32s3/hardware/esp32s3_usb_serial_jtag.h |  76 +--
 .../arm/stm32/nucleo-l152re/src/stm32_ili93418b.c  |  12 +-
 drivers/audio/wm8994.c |   2 +-
 drivers/audio/wm8994.h | 642 +++--
 drivers/sensors/fxos8700cq.c   |   4 +-
 drivers/wireless/ISM2_905MHzGFSK250kbps.c  |   2 +-
 drivers/wireless/ieee80211/bcm43xxx/bcmf_ioctl.h   |   6 +-
 include/nuttx/video/video_controls.h   |   4 +-
 22 files changed, 597 insertions(+), 861 deletions(-)

diff --git a/arch/arm/include/cxd56xx/pm.h b/arch/arm/include/cxd56xx/pm.h
index 5689b2a683..133ade841f 100644
--- a/arch/arm/include/cxd56xx/pm.h
+++ b/arch/arm/include/cxd56xx/pm.h
@@ -34,26 +34,26 @@
 
 /* Boot Cause definitions */
 
-#define PM_BOOT_POR_NORMAL  (0xul) /** Power On Reset like as 
battery attached */
-#define PM_BOOT_POR_DEADBATT(0x0001ul) /** Battery charged from 
DeadBattery state */
-#define PM_BOOT_WDT_REBOOT  (0x0002ul) /** System WDT expired or 
Explicitly Self Reboot */
-#define PM_BOOT_WDT_RESET   (0x0004ul) /** Chip WDT expired (might be 
used in HV-only system) */
-#define PM_BOOT_DEEP_WKUPL  (0x0008ul) /** In DeepSleep state, 
Detected WKUPL signal */
-#define PM_BOOT_DEEP_WKUPS  (0x0010ul) /** In DeepSleep state, 
Detected WKUPS signal */
-#define PM_BOOT_DEEP_RTC(0x0020ul) /** In DeepSleep state, RTC 
Alarm expired */
-#define PM_BOOT_DEEP_USB_ATTACH (0x0040ul) /** In DeepSleep state, USB 
Connected */
-#define PM_BOOT_DEEP_OTHERS (0x0080ul) /** In DeepSleep state, 
Reserved others cause occurred */
-#define PM_BOOT_COLD_SCU_INT(0x0100ul) /** In ColdSleep state, 
Detected SCU Interrupt */
-#define PM_BOOT_COLD_RTC(0x1e00ul) /** In ColdSleep state, RTC 
Alarm Interrupt */
-#define PM_BOOT_COLD_RTC_ALM0   (0x0200ul) /** In ColdSleep state, RTC 
Alarm0 expired */
-#define PM_BOOT_COLD_RTC_ALM1   (0x0400ul) /** In ColdSleep state, RTC 
Alarm1 expired */
-#define PM_BOOT_COLD_RTC_ALM2   (0x0800ul) /** In ColdSleep state, RTC 
Alarm2 expired */
-#define PM_BOOT_COLD_RTC_ALMERR (0x1000ul) /** In ColdSleep state, RTC 
Alarm Error occurred */
-#define PM_BOOT_COLD_GPIO   (0x0ffful) /** In ColdSleep state, 
Detected GPIO interrupt */
-#define PM_BOOT_COLD_SEN_INT(0x1000ul) /** In ColdSleep state, 
Detected SEN_INT Interrupt */
-#define PM_BOOT_COLD_PMIC_INT   (0x2000ul) /** In ColdSleep state, 
Detected PMIC Interrupt */
-#define PM_BOOT_COLD_USB_DETACH (0x4000ul) /** In ColdSleep state, USB 
Disconnected */
-#define PM_BOOT_COLD_USB_ATTACH (0x8000ul) /** In ColdSleep state, USB 
Connected */
+#define PM_BOOT_POR_NORMAL  (0xul) /* Power On Reset like as 
battery attached */
+#define PM_BOOT_POR_DEADBATT(0x0001ul) /* Battery charged from 
DeadBattery state */
+#define PM_BOOT_WDT_REBOOT  (0x0002ul) /* System WDT expired or 
Explicitly Self Reboot */
+#define PM_BOOT_WDT_RESET   (0x0004ul) /* Chip WDT expired (might be 
used in HV-only system) */
+#define PM_BOOT_DEEP_WKUPL  (0x0008ul) /* In DeepSleep state, Detected 
WKUPL signal */
+#define PM_BOOT_DEEP_WKUPS  (0x0010ul) /* In DeepSleep state, Detected 
WKUPS signal */
+#define PM_BOOT_DEEP_RTC(0x0020ul) /* In DeepSleep state, RTC 
Alarm expired 

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9807: Fix nuttx coding style

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #9807:
URL: https://github.com/apache/nuttx/pull/9807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] laoniaokkk closed issue #8833: w5500 ethernet can not work well

2023-07-13 Thread via GitHub


laoniaokkk closed issue #8833: w5500 ethernet can not work well
URL: https://github.com/apache/nuttx/issues/8833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] laoniaokkk commented on issue #8833: w5500 ethernet can not work well

2023-07-13 Thread via GitHub


laoniaokkk commented on issue #8833:
URL: https://github.com/apache/nuttx/issues/8833#issuecomment-1634055172

   @michi-jung Thank you very much! The net is work well now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] anchao opened a new pull request, #9808: tools/ci: migrate some ci build configurations to CMake

2023-07-13 Thread via GitHub


anchao opened a new pull request, #9808:
URL: https://github.com/apache/nuttx/pull/9808

   ## Summary
   
   tools/ci: migrate some ci build configurations to CMake
   cmake: fix CMake build break
   drivers/sensors: fix build warning on GCC-12
   cmake/menuconfig: keep comment to original style to avoid unnecessary 
refreshes
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] anchao opened a new pull request, #1832: cmake/apps: add more applications into cmake support

2023-07-13 Thread via GitHub


anchao opened a new pull request, #1832:
URL: https://github.com/apache/nuttx-apps/pull/1832

   ## Summary
   
   cmake/apps: add more applications into cmake support
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx] simbit18 opened a new pull request, #9807: Fix nuttx coding style

2023-07-13 Thread via GitHub


simbit18 opened a new pull request, #9807:
URL: https://github.com/apache/nuttx/pull/9807

   ## Summary
   Remove TABs
   Fix indentation
   Fix Multi-line comments
   Fix Comments to the Right of Statements.
   ## Impact
   none
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1829: iptables: add iptables libary

2023-07-13 Thread via GitHub


xiaoxiang781216 merged PR #1829:
URL: https://github.com/apache/nuttx-apps/pull/1829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[nuttx-apps] branch master updated: iptables: add iptables libary

2023-07-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
 new bbb2b289c iptables: add iptables libary
bbb2b289c is described below

commit bbb2b289cfbce7660cab94338b02d61e5836d79b
Author: zhanghongyu 
AuthorDate: Wed Jul 5 10:25:55 2023 +0800

iptables: add iptables libary

Add xtables.c and xtables.h
In order to support the compilation of third-party utils, we encounter some
situations where the macro is not defined, refer to the common 
implementation
of other systems, add relevant definitions and empty function.

Signed-off-by: zhanghongyu 
---
 include/netutils/xtables.h  | 494 
 netutils/iptables/Kconfig   |  10 +
 netutils/iptables/Make.defs |  23 +++
 netutils/iptables/Makefile  |  25 +++
 netutils/iptables/xtables.c | 113 ++
 5 files changed, 665 insertions(+)

diff --git a/include/netutils/xtables.h b/include/netutils/xtables.h
new file mode 100644
index 0..5c8d4d8ff
--- /dev/null
+++ b/include/netutils/xtables.h
@@ -0,0 +1,494 @@
+/
+ * apps/include/netutils/xtables.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+#ifndef __APPS_INCLUDE_XTABLES_H
+#define __APPS_INCLUDE_XTABLES_H
+
+/
+ * Included Files
+ /
+
+#include 
+#include 
+#include 
+
+#include 
+
+/
+ * Pre-processor Definitions
+ /
+
+#define XTABLES_VERSION_CODE 12
+
+/**
+ * Select the format the input has to conform to, as well as the target type
+ * (area pointed to with XTOPT_POINTER). Note that the storing is not always
+ * uniform. @cb->val will be populated with as much as there is space, i.e.
+ * exactly 2 items for ranges, but the target area can receive more values
+ * (e.g. in case of ranges), or less values (e.g. %XTTYPE_HOSTMASK).
+ *
+ * %XTTYPE_NONE:option takes no argument
+ * %XTTYPE_UINT*:   standard integer
+ * %XTTYPE_UINT*RC: colon-separated range of standard integers
+ * %XTTYPE_DOUBLE:  double-precision floating point number
+ * %XTTYPE_STRING:  arbitrary string
+ * %XTTYPE_TOSMASK: 8-bit TOS value with optional mask
+ * %XTTYPE_MARKMASK32:  32-bit mark with optional mask
+ * %XTTYPE_SYSLOGLEVEL: syslog level by name or number
+ * %XTTYPE_HOST:one host or address (ptr: union nf_inet_addr)
+ * %XTTYPE_HOSTMASK:one host or address, with an optional prefix length
+ *  ptr: union nf_inet_addr; only host portion is stored
+ * %XTTYPE_PROTOCOL:protocol number/name from /etc/protocols ptr: uint8_t
+ * %XTTYPE_PORT:16-bit port name or number (supports %XTOPT_NBO)
+ * %XTTYPE_PORTRC:  colon-separated port range (names acceptable),
+ *  (supports %XTOPT_NBO)
+ * %XTTYPE_PLEN:prefix length
+ * %XTTYPE_PLENMASK:prefix length (ptr: union nf_inet_addr)
+ * %XTTYPE_ETHERMAC:Ethernet MAC address in hex form
+ */
+
+enum xt_option_type
+{
+  XTTYPE_NONE,
+  XTTYPE_UINT8,
+  XTTYPE_UINT16,
+  XTTYPE_UINT32,
+  XTTYPE_UINT64,
+  XTTYPE_UINT8RC,
+  XTTYPE_UINT16RC,
+  XTTYPE_UINT32RC,
+  XTTYPE_UINT64RC,
+  XTTYPE_DOUBLE,
+  XTTYPE_STRING,
+  XTTYPE_TOSMASK,
+  XTTYPE_MARKMASK32,
+  XTTYPE_SYSLOGLEVEL,
+  XTTYPE_HOST,
+  XTTYPE_HOSTMASK,
+  XTTYPE_PROTOCOL,
+  XTTYPE_PORT,
+  XTTYPE_PORTRC,
+  XTTYPE_PLEN,
+  XTTYPE_PLENMASK,
+  XTTYPE_ETHERMAC,
+};
+
+enum xtables_tryload
+{
+  XTF_DONT_LOAD,
+  XTF_DURING_LOAD,
+  XTF_TRY_LOAD,
+  XTF_LOAD_MUST_SUCCEED,
+};
+
+enum xtables_exittype
+{
+  OTHER_PROBLEM = 1,
+  PARAMETER_PROBLEM,
+  VERSION_PROBLEM,
+  RESOURCE_PROBLEM,
+  XTF_ONLY_ONCE,
+  XTF_NO_INVERT,
+  XTF_BAD_VALUE,
+  

  1   2   >