This is an automated email from the ASF dual-hosted git repository.
archer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1b068b0d4b sched/irq: remove scheduling check in csection
1b068b0d4b is described below
commit 1b068b0d4b70a1204d0282569affe54cdeb2f07c
Author: hujun5 <huj...@xiaomi.com>
AuthorDate: Wed Apr 10 10:06:27 2024 +0800
sched/irq: remove scheduling check in csection
1. The critical section does not prevent task scheduling
2. If the critical section is in sched_lock, there is no need to check,
scheduling is not going to happen
3. If sched_lock is in the critical section, sched_unlock will also
trigger scheduling without waiting for the exit of the critical section
4. After exiting the critical section, if there is an interrupt,
the scheduling will be automatically triggered
Signed-off-by: hujun5 <huj...@xiaomi.com>
---
sched/irq/irq_csection.c | 29 -----------------------------
1 file changed, 29 deletions(-)
diff --git a/sched/irq/irq_csection.c b/sched/irq/irq_csection.c
index b56ab2375d..83c4a65f7b 100644
--- a/sched/irq/irq_csection.c
+++ b/sched/irq/irq_csection.c
@@ -550,35 +550,6 @@ void leave_critical_section(irqstate_t flags)
DEBUGASSERT(spin_is_locked(&g_cpu_irqlock) &&
(g_cpu_irqset & (1 << cpu)) != 0);
- /* Check if releasing the lock held by this CPU will unlock the
- * critical section.
- */
-
- if ((g_cpu_irqset & ~(1 << cpu)) == 0)
- {
- /* Yes.. Check if there are pending tasks and that pre-
- * emption is also enabled. This is necessary because we
- * may have deferred the nxsched_merge_pending() call in
- * sched_unlock() because we were within a critical
- * section then.
- */
-
- if (list_pendingtasks()->head != NULL &&
- !nxsched_islocked_global())
- {
- /* Release any ready-to-run tasks that have collected
- * in g_pendingtasks. NOTE: This operation has a very
- * high likelihood of causing this task to be switched
- * out!
- */
-
- if (nxsched_merge_pending())
- {
- up_switch_context(this_task(), rtcb);
- }
- }
- }
-
/* Now, possibly on return from a context switch, clear our
* count on the lock. If all CPUs have released the lock,
* then unlock the global IRQ spinlock.
