Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xiaoxiang781216 merged PR #11745: URL: https://github.com/apache/nuttx/pull/11745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xiaoxiang781216 commented on PR #11745: URL: https://github.com/apache/nuttx/pull/11745#issuecomment-1961388126 > the CI failure dose not caused by this patch. yes, other patch make the break, but it fix. please update your patch to retrigger ci. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xuxin930 commented on PR #11745: URL: https://github.com/apache/nuttx/pull/11745#issuecomment-1961301900 the CI failure dose not caused by this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xuxin930 commented on code in PR #11745:
URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500264224
##
CMakeLists.txt:
##
@@ -84,7 +84,8 @@ if(NOT KCONFIGLIB)
$ pip install kconfiglib")
endif()
-if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)
+if(EXISTS ${NUTTX_DIR}/${BOARD_CONFIG}
Review Comment:
> Please merge the BOARD_CONFIG related commits into one.
Done, rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
anchao commented on code in PR #11745:
URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500230541
##
CMakeLists.txt:
##
@@ -84,7 +84,8 @@ if(NOT KCONFIGLIB)
$ pip install kconfiglib")
endif()
-if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)
+if(EXISTS ${NUTTX_DIR}/${BOARD_CONFIG}
Review Comment:
Please merge the BOARD_CONFIG related commits into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xuxin930 commented on code in PR #11745:
URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500182454
##
CMakeLists.txt:
##
@@ -84,7 +84,8 @@ if(NOT KCONFIGLIB)
$ pip install kconfiglib")
endif()
-if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)
+if(EXISTS ${NUTTX_DIR}/${BOARD_CONFIG}
Review Comment:
> how about if BOARD_CONFIG is an absolute path?
🙏Yes thanks, I made a mistake.
I submitted a new modification, please review.
since the configuration pair `[/:]` contains the character
`/`, we cannot judge it through `IS_ABSOLUTE`, so I used `EXSIST` to judge both
the absolute and relative paths.
and also use `NUTTX_BOARD_ABS_DIR` instead of `BOARD_CONFIG`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
anchao commented on code in PR #11745:
URL: https://github.com/apache/nuttx/pull/11745#discussion_r1500078532
##
CMakeLists.txt:
##
@@ -84,7 +84,8 @@ if(NOT KCONFIGLIB)
$ pip install kconfiglib")
endif()
-if(EXISTS ${BOARD_CONFIG} AND EXISTS ${BOARD_CONFIG}/defconfig)
+if(EXISTS ${NUTTX_DIR}/${BOARD_CONFIG}
Review Comment:
how about if BOARD_CONFIG is an absolute path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] cmake:fix the problems of using cmake to compile custom board [nuttx]
xuxin930 opened a new pull request, #11745:
URL: https://github.com/apache/nuttx/pull/11745
## Summary
### 1. **No config found when reconfig**
when reconfiguring a custom configuration, because `${BOARD_CONFIG}` uses a
_relative path_, it will cause the following error:
```cmake
# config first time
cmake -B out -DBOARD_CONFIG=coustom/boards/sim/sim/sim/config/nsh
# run first build for target menucofing
cmake --build out -t menuconfig
# run second build for final build will failed
cmake --build out
```
### 2. **Generate config.h error**
The result of `dequote` is inconsistent with `cfgdefine.c`
```c
// config example
CONFIG_INIT_ARGS="\"widgets\""
CONFIG_INIT_ENTRYPOINT="demo_main"
// generated wrong header file
#define CONFIG_INIT_ARGS \widgets\
#define CONFIG_INIT_ENTRYPOINT demo_main
//expected
#define CONFIG_INIT_ARGS "widgets"
#define CONFIG_INIT_ENTRYPOINT demo_main
```
### 3. **board.h is not linked in the binary directory**
fix `board.h` is not set correctly when using cmake to compile a board with
a `common` directory
## Impact
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
