Re: [PR] fix typo error in quickstart compiling_cmake [nuttx]

2024-02-15 Thread via GitHub


anchao merged PR #11694:
URL: https://github.com/apache/nuttx/pull/11694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix typo error in quickstart compiling_cmake [nuttx]

2024-02-14 Thread via GitHub


KMSorSMS commented on PR #11694:
URL: https://github.com/apache/nuttx/pull/11694#issuecomment-1944065348

   > git commit --amend git push -f
   
   sincerely thx, it works!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix typo error in quickstart compiling_cmake [nuttx]

2024-02-14 Thread via GitHub


jerpelea commented on PR #11694:
URL: https://github.com/apache/nuttx/pull/11694#issuecomment-1943870714

   git commit --amend
   git push -f
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix typo error in quickstart compiling_cmake [nuttx]

2024-02-14 Thread via GitHub


KMSorSMS commented on PR #11694:
URL: https://github.com/apache/nuttx/pull/11694#issuecomment-1943781442

   > please copy PR description as commit message
   
   I am trying, but wondering how to add this description to commit message, do 
I need to make another commit? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] fix typo error in quickstart compiling_cmake [nuttx]

2024-02-14 Thread via GitHub


KMSorSMS opened a new pull request, #11694:
URL: https://github.com/apache/nuttx/pull/11694

   I used
   ··
   cd nuttx
   cmake -B build -DBOARD_CONFIG=stm32f401rc-rs485:nsh -GNinja
   ··
   to config
   and when following the instruction in this official websites I found the 
command to use cmake to build the target is wrong.
   which is "cmake --build build -t menuconfig" also wrong the output dir 
"build/nuttx".
   and by the way, In my practice I find the bin file and elf file is not in 
build/nuttx but in build/. So I changed these. But I'm not 100% sure that my 
fix is right as I'm a beginner, but what I fix works fine in my computer. This 
is my first PR to the public doc. My fix maybe totally wrong as I am not get 
into the nuttx, just following the instruction and encountered some mistakes.
   thx for reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org