Re: [PR] irq: irq_cpu_locked can be remove [nuttx]

[via GitHub]

xiaoxiang781216 merged PR #12114:
URL: https://github.com/apache/nuttx/pull/12114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] irq: irq_cpu_locked can be remove [nuttx]

[via GitHub]

hujun260 commented on PR #12114:
URL: https://github.com/apache/nuttx/pull/12114#issuecomment-2048707713

   > @hujun260
   > 
   > Please describe which configurations and applications you tested.
   
   This patch will affect all SMP archs. We have tested it on multi-core 
scenarios using QEMU's arm64, as well as on other hardware platforms。
   
   Compilation Command:
   make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20
   
   Running Command:
   qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine 
virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on 
-serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] irq: irq_cpu_locked can be remove [nuttx]

[via GitHub]

masayuki2009 commented on PR #12114:
URL: https://github.com/apache/nuttx/pull/12114#issuecomment-2047712939

   @hujun260 
   
   Please describe which configurations and applications you tested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] irq: irq_cpu_locked can be remove [nuttx]

[via GitHub]

acassis commented on PR #12114:
URL: https://github.com/apache/nuttx/pull/12114#issuecomment-2047669279

   Strange, libmetal is failing! Maybe we should fallback to librock :-D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] irq: irq_cpu_locked can be remove [nuttx]

[via GitHub]

hujun260 opened a new pull request, #12114:
URL: https://github.com/apache/nuttx/pull/12114

   ## Summary
   All irq_cpu_locked is called in the critical_section, and the parameter 
is the current cpu id.
   so it must return false, We can safely delete.
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org