Re: [PR] netinit: Add check mount path retry option for delayed mounts [nuttx-apps]

2024-02-27 Thread via GitHub


xiaoxiang781216 merged PR #2313:
URL: https://github.com/apache/nuttx-apps/pull/2313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] netinit: Add check mount path retry option for delayed mounts [nuttx-apps]

2024-02-27 Thread via GitHub


PetervdPerk-NXP commented on code in PR #2313:
URL: https://github.com/apache/nuttx-apps/pull/2313#discussion_r1504718553


##
netutils/netinit/Kconfig:
##
@@ -118,6 +118,13 @@ config NETINIT_THREAD_PRIORITY
PHY polling is CPU intensive and can interfere with the 
usability of
of threads competing for CPU bandwidth.
 
+config NETINIT_RETRY_MOUNTPATH
+int "Network initialization retry mount path count"

Review Comment:
   good catch, fixed now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] netinit: Add check mount path retry option for delayed mounts [nuttx-apps]

2024-02-27 Thread via GitHub


xiaoxiang781216 commented on code in PR #2313:
URL: https://github.com/apache/nuttx-apps/pull/2313#discussion_r1504684945


##
netutils/netinit/Kconfig:
##
@@ -118,6 +118,13 @@ config NETINIT_THREAD_PRIORITY
PHY polling is CPU intensive and can interfere with the 
usability of
of threads competing for CPU bandwidth.
 
+config NETINIT_RETRY_MOUNTPATH
+int "Network initialization retry mount path count"

Review Comment:
   indent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] netinit: Add check mount path retry option for delayed mounts [nuttx-apps]

2024-02-26 Thread via GitHub


PetervdPerk-NXP opened a new pull request, #2313:
URL: https://github.com/apache/nuttx-apps/pull/2313

   ## Summary
   Some systems the sd card gets mounted later after netinit started this 
causes netinit to be unable to read the config. 
   
   This pr add a KConfig symbol to set retries to allow delayed mount
   
   ## Impact
   Minimal, default behavior is the same
   
   ## Testing
   Teensy
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org