Re: [PR] openamp: Fix void pointer arithmetic in openamp to remove compilation… [nuttx]
jlaitine commented on code in PR #11686: URL: https://github.com/apache/nuttx/pull/11686#discussion_r1492404443 ## openamp/libmetal.defs: ## @@ -79,6 +79,7 @@ libmetal.zip: $(Q) mv libmetal-$(VERSION) libmetal $(Q) patch -p0 < 0001-libmetal-add-metal_list_for_each_safe-support.patch $(Q) patch -p0 < 0002-libmetal-nuttx-io.c-align-access-when-read-write-siz.patch + $(Q) patch -p0 < 0003-libmetal-nuttx-io.c-Fix-void-pointer-arithmetic-in-a.patch Review Comment: Sure, the original patch is in this PR: https://github.com/OpenAMP/libmetal/pull/279 ; this is not merged in the openamp libmetal yet. So obviously I can't provide the fix for that patch either :) @CV-Bowen feel free to add my patch to the same PR, or squash the fix into your original patch. I am not sure what is the plan forward with that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] openamp: Fix void pointer arithmetic in openamp to remove compilation… [nuttx]
xiaoxiang781216 commented on code in PR #11686: URL: https://github.com/apache/nuttx/pull/11686#discussion_r1490803312 ## openamp/libmetal.defs: ## @@ -79,6 +79,7 @@ libmetal.zip: $(Q) mv libmetal-$(VERSION) libmetal $(Q) patch -p0 < 0001-libmetal-add-metal_list_for_each_safe-support.patch $(Q) patch -p0 < 0002-libmetal-nuttx-io.c-align-access-when-read-write-siz.patch + $(Q) patch -p0 < 0003-libmetal-nuttx-io.c-Fix-void-pointer-arithmetic-in-a.patch Review Comment: @jlaitine @CV-Bowen let's send the patch to OpenAMP community too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] openamp: Fix void pointer arithmetic in openamp to remove compilation… [nuttx]
jerpelea merged PR #11686: URL: https://github.com/apache/nuttx/pull/11686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] openamp: Fix void pointer arithmetic in openamp to remove compilation… [nuttx]
jlaitine opened a new pull request, #11686: URL: https://github.com/apache/nuttx/pull/11686 … warnings This fixes compilation errors caused by void * arithmetics added by a patch to openamp libmetal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
