[PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]

[via GitHub]

jerpelea opened a new pull request, #12070:
URL: https://github.com/apache/nuttx/pull/12070

   ## Summary
   Fixed logic error as noted by @kk-thrane
   
   ## Impact
   Correct logic
   
   ## Testing
   px4_fmu-v6x serial_test / gps / qgc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]

[via GitHub]

acassis merged PR #11990:
URL: https://github.com/apache/nuttx/pull/11990


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]

[via GitHub]

davids5 commented on PR #11990:
URL: https://github.com/apache/nuttx/pull/11990#issuecomment-2019959869

   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]

[via GitHub]

xiaoxiang781216 commented on code in PR #11990:
URL: https://github.com/apache/nuttx/pull/11990#discussion_r1537952227


##
arch/arm/src/stm32h7/stm32_serial.c:
##
@@ -3360,7 +3360,8 @@ static void up_dma_txavailable(struct uart_dev_s *dev)
 
   /* Only send when the DMA is idle */
 
-  if ((priv->dev.dmatx.length && priv->dev.dmatx.nlength) == 0 &&
+  if ((priv->dev.dmatx.length == 0 &&

Review Comment:
   don't need the inner ()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]

[via GitHub]

davids5 opened a new pull request, #11990:
URL: https://github.com/apache/nuttx/pull/11990

   ## Summary
   
   Fixed logic error as noted by @kk-thrane
   
   ## Impact
   
   Correct logic 
   
   ## Testing
   
   px4_fmu-v6x serial_test / gps / qgc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org