Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-25 Thread via GitHub


raiden00pl closed pull request #11570: Bring up changes from nuttx/pci branch
URL: https://github.com/apache/nuttx/pull/11570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-22 Thread via GitHub


xiaoxiang781216 commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1904038954

   Sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-21 Thread via GitHub


raiden00pl commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1903430149

   @xiaoxiang781216 what do you think about applying this pcie implementation 
first (with the changes from Brennan included). When your implementation goes 
upstream we can mark this work as legacy, port what is needed to the new 
version and when everything is ported, remove the legacy version. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-21 Thread via GitHub


xiaoxiang781216 commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902645073

   Yes, it will upstream once it's mature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-21 Thread via GitHub


raiden00pl commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902557940

   > Looks like my changes may have gotten dropped? I made quite a few fixes 
around the PCI stuff to the point were I was able to use it on my laptop and 
enumerate real devices. Let me see if I can find this.
   
   THB, this is the first time I see your 
https://github.com/btashton/incubator-nuttx/commits/pci-btashton/ branch and 
these commits where not included on nuttx/pic branch. I'll be happy to include 
these changes.
   
   > @raiden00pl we are developing a pcie driver framework, which may better 
than this one.
   
   @xiaoxiang781216 do you have any plans to add this to the upstream in the 
near future?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-20 Thread via GitHub


xiaoxiang781216 commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902494136

   @raiden00pl we are developing a pcie driver framework, which may better than 
this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-20 Thread via GitHub


btashton commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902461200

   I don't think this branch in the PR is ready to merge given the issues that 
were resolved. Why not pull these changes in?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-20 Thread via GitHub


acassis commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902408365

   @btashton is it possible to send the improvements you made on top of this 
commit? It should be very useful case we could get NuttX booting on real x84_64 
with PCIe support!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-20 Thread via GitHub


btashton commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902263640

   Here it is https://github.com/btashton/incubator-nuttx/commits/pci-btashton/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bring up changes from nuttx/pci branch [nuttx]

2024-01-20 Thread via GitHub


btashton commented on PR #11570:
URL: https://github.com/apache/nuttx/pull/11570#issuecomment-1902263340

   Looks like my changes may have gotten dropped?  I made quite a few fixes 
around the PCI stuff to the point were I was able to use it on my laptop and 
enumerate real devices.  Let me see if I can find this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org