Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 merged PR #11711: URL: https://github.com/apache/nuttx/pull/11711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494197673 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: if alloca can't implement easily with tasking compiler, it's better to keep alloca is undefined to force the user modify the code to not use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494195699 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: sp should be store in stack in this case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494187180 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: > can we change sp manually? how to restore the sp to original position ? setjmp/longjmp? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494184571 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: https://github.com/apache/nuttx-apps/pull/2291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494179577 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: can we change sp manually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494173314 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: Yes, seems still need to improve compatibility on the application side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1494152984 ## include/alloca.h: ## @@ -37,6 +37,11 @@ # undef __alloca # define alloca(size) _alloca(size) # define __alloca(size) _alloca(size) +#elif defined(__TASKING__) +# undef alloca +# undef __alloca +# define alloca(size) malloc(size) Review Comment: memory leak? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711:
URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493770346
##
tools/mkdeps.c:
##
@@ -81,12 +81,12 @@
* Private Types
/
-enum slashmode_e
+typedef enum
{
- MODE_FSLASH = 0,
- MODE_BSLASH = 1,
- MODE_DBLBACK = 2
-};
+ TOOLCHAIN_GNU = 0,
Review Comment:
emm... consider whether it is inappropriate to decide on behavior during
compilation? If the toolchain is changed after first configure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711:
URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493768159
##
tools/mkdeps.c:
##
@@ -81,12 +81,12 @@
* Private Types
/
-enum slashmode_e
+typedef enum
{
- MODE_FSLASH = 0,
- MODE_BSLASH = 1,
- MODE_DBLBACK = 2
-};
+ TOOLCHAIN_GNU = 0,
Review Comment:
should we use the same approach as incdir.c for compiler detecting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493760237 ## tools/Config.mk: ## @@ -268,6 +272,10 @@ else INCDIR ?= "$(TOPDIR)/tools/incdir$(HOSTEXEEXT)" endif +ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),) + INCDIR += -s Review Comment: ok. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493746557 ## tools/Config.mk: ## @@ -268,6 +272,10 @@ else INCDIR ?= "$(TOPDIR)/tools/incdir$(HOSTEXEEXT)" endif +ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),) + INCDIR += -s Review Comment: but, all compiler special options is handled in incdir.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493737114 ## tools/Config.mk: ## @@ -268,6 +272,10 @@ else INCDIR ?= "$(TOPDIR)/tools/incdir$(HOSTEXEEXT)" endif +ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),) + INCDIR += -s Review Comment: I think apply changes here would be more reasonable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493736875 ## tools/Config.mk: ## @@ -268,6 +272,10 @@ else INCDIR ?= "$(TOPDIR)/tools/incdir$(HOSTEXEEXT)" endif +ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),) + INCDIR += -s Review Comment: Incdir has multiple versions, c and shell. so，do we need to apply the similar change for all versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
xiaoxiang781216 commented on code in PR #11711: URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493728545 ## tools/Config.mk: ## @@ -268,6 +272,10 @@ else INCDIR ?= "$(TOPDIR)/tools/incdir$(HOSTEXEEXT)" endif +ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),) + INCDIR += -s Review Comment: but' it's better to move into incdir.sh like other compiler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] toolchain/tasking: add dependencies rules for tasking compiler [nuttx]
anchao commented on code in PR #11711:
URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493714313
##
tools/Config.mk:
##
@@ -636,7 +645,12 @@ endef
export DEFINE_PREFIX ?= $(subst X,,${shell $(DEFINE) "$(CC)" X 2>
${EMPTYFILE}})
export INCDIR_PREFIX ?= $(subst "X",,${shell $(INCDIR) "$(CC)" X 2>
${EMPTYFILE}})
-export INCSYSDIR_PREFIX ?= $(subst "X",,${shell $(INCDIR) -s "$(CC)" X 2>
${EMPTYFILE}})
+
+ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),y)
+ export INCSYSDIR_PREFIX ?= $(subst "X",,${shell $(INCDIR) "$(CC)" X 2>
${EMPTYFILE}})
+else
+ export INCSYSDIR_PREFIX ?= $(subst "X",,${shell $(INCDIR) -s "$(CC)" X 2>
${EMPTYFILE}})
Review Comment:
Done
##
tools/mkdeps.c:
##
@@ -115,6 +115,25 @@ static char g_posixpath[MAX_PATH];
static char g_shquote[MAX_SHQUOTE];
#endif
+static toolchain_t g_toolchain = TOOLCHAIN_GNU;
+
+static const char *g_moptions[TOOLCHAIN_NUM][2] =
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
