[jira] [Resolved] (OPENMEETINGS-2461) check digit & check special does not take effect
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2461. Fix Version/s: 5.1.0 Resolution: Fixed > check digit & check special does not take effect > > > Key: OPENMEETINGS-2461 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2461 > Project: Openmeetings > Issue Type: Bug > Components: Security >Affects Versions: 5.0.1, 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > check digit and check special takes no effect, the new user is still prompted > that his password is week and should put at least a digit and a special > character, otherwise, will not accept his registration. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2461) check digit & check special does not take effect
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202972#comment-17202972 ] ASF subversion and git services commented on OPENMEETINGS-2461: --- Commit 5c36cc2bb3937806d58cd38ab0e19c3a3a206cbe in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=5c36cc2 ] [OPENMEETINGS-2461] password can be weeker > check digit & check special does not take effect > > > Key: OPENMEETINGS-2461 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2461 > Project: Openmeetings > Issue Type: Bug > Components: Security >Affects Versions: 5.0.1, 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > check digit and check special takes no effect, the new user is still prompted > that his password is week and should put at least a digit and a special > character, otherwise, will not accept his registration. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2461] password can be weeker
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 5c36cc2 [OPENMEETINGS-2461] password can be weeker
5c36cc2 is described below
commit 5c36cc2bb3937806d58cd38ab0e19c3a3a206cbe
Author: Maxim Solodovnik
AuthorDate: Mon Sep 28 09:48:15 2020 +0700
[OPENMEETINGS-2461] password can be weeker
---
.../java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java
index 6fe4fff..3871588 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java
@@ -296,7 +296,7 @@ public class ConfigurationDao implements
IDataProviderDao {
reloadPwdCheckUpper();
break;
case CONFIG_PASS_CHECK_DIGIT:
- reloadPwdCheckNumber();
+ reloadPwdCheckDigit();
break;
case CONFIG_PASS_CHECK_SPECIAL:
reloadPwdCheckSpecial();
@@ -442,7 +442,7 @@ public class ConfigurationDao implements
IDataProviderDao {
setPwdCheckUpper(getBool(CONFIG_PASS_CHECK_UPPER, true));
}
- private void reloadPwdCheckNumber() {
+ private void reloadPwdCheckDigit() {
setPwdCheckDigit(getBool(CONFIG_PASS_CHECK_DIGIT, true));
}
@@ -527,6 +527,8 @@ public class ConfigurationDao implements
IDataProviderDao {
reloadLoginMinLength();
reloadPasswdMinLength();
reloadPwdCheckUpper();
+ reloadPwdCheckDigit();
+ reloadPwdCheckSpecial();
reloadDefaultGroup();
reloadSipContext();
reloadFnameMinLength();
[jira] [Commented] (OPENMEETINGS-2460) FireFox on iOS
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202967#comment-17202967 ] Maxim Solodovnik commented on OPENMEETINGS-2460: this seems to be extremely old FF :(( According to https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices this function is supported in FF since v63 current version is 80 > FireFox on iOS > -- > > Key: OPENMEETINGS-2460 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2460 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.1, 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Attachments: ff-ios.png > > > audio/video is not working. attached is the massage that shows when testing > settings -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2425) Translation to Arabic need to be improved
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202966#comment-17202966
]
Maxim Solodovnik commented on OPENMEETINGS-2425:
{quote}Your
account details{quote}
https://poeditor.com/projects/po_edit?order==_page=20=333773_language=43=512
OpenMeeting - is most probably Admin -> Config -> application.name
> Translation to Arabic need to be improved
> -
>
> Key: OPENMEETINGS-2425
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2425
> Project: Openmeetings
> Issue Type: Bug
> Components: Translations
>Affects Versions: 5.0.0
>Reporter: Ali Alhaidary
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.0.1
>
> Attachments: Application_ar.properties.xml,
> Application_ar.properties.xml, Application_ar.properties.xml,
> Application_ar.properties.xml, Application_ar.properties.xml,
> Application_ar.properties.xml, Application_ar.properties.xml, My rooms.png,
> Screenshot from 2020-09-09 23-24-59.png, Screenshot_2020-09-09 مَوْقِعُ
> النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه
> عَلَيْهُمْ).png, Screenshot_2020-09-10 مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ
> الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png, Screenshot_2020-09-10
> مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه
> عَلَيْهُمْ).png, Screenshot_2020-09-27 النُّجُومُ الخَمْسَةِ (ص).png,
> profile.png
>
>
> The (ROOMS) menu title does not have an entry in the language pack, so to
> whatever language you change, this menu title stays (ROOMS) and does (and can
> not) change...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2410) The page isn't redirecting properly
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202964#comment-17202964
]
Maxim Solodovnik commented on OPENMEETINGS-2410:
{quote}I had the same issue of " The page isn't redirecting properly" after
finishing the console installation and moving to the web installation.{quote}
Why do you need to run installation multiple times?
{quote}/opt/omdb.mv.db, but that file was root:root{quote}
permissions should be set correctly
{{DATA_DIR}} and {{logs}} should be writable
{{OM_HOME}} should be readable
and the app should have access to DB
> The page isn't redirecting properly
> ---
>
> Key: OPENMEETINGS-2410
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2410
> Project: Openmeetings
> Issue Type: Test
> Components: Installer
>Affects Versions: 5.0.0
> Environment: Ubuntu 18.04, 20.04 and Debian 9
> OM 5.0.0 Snapshot 3252
>Reporter: Alvaro
>Assignee: Maxim Solodovnik
>Priority: Major
> Attachments: Captura.png, tomcat4
>
>
> When run first time to start installing OM 5.0.0 Snapshot 3252:
> sudo -u nobody $CATALINA_HOME/bin/startup.sh
> /opt/open500 nobody:nogoup
> 4 different times in Ubuntu 18.04, 20.04 and Debian 9
> ...the page say: The page isn't redirecting properly
> A russian user got to run rightly so:
> sudo /opt/open500/bin/startup.sh
> ...and for me works also.
> With different versions of Firefox.
> Attached capture.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2458) Vote: New poll should show "Display name" not "Firstname Lastname"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-2458.
Fix Version/s: 5.1.0
Resolution: Fixed
> Vote: New poll should show "Display name" not "Firstname Lastname"
> --
>
> Key: OPENMEETINGS-2458
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2458
> Project: Openmeetings
> Issue Type: Improvement
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Fix For: 5.1.0
>
> Attachments: Bildschirmfoto vom 2020-09-26 21-42-41.png,
> Bildschirmfoto vom 2020-09-26 22-02-24.png
>
>
> When a new poll ist show, the first line shows
>
> {code:java}
> "firstname" "lastname" wants to know:{code}
>
> When lastname or firstname is empty the display is "null".
> Same behaviour in
> "Poll Results".
> "Settings"->"Search Users"
>
> Better use the "display name" as shown in the participant list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2457] code clean-up
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new be9e2af [OPENMEETINGS-2457] code clean-up
be9e2af is described below
commit be9e2af12db46e3d859494b1edece8260a677ec5
Author: Maxim Solodovnik
AuthorDate: Mon Sep 28 07:46:39 2020 +0700
[OPENMEETINGS-2457] code clean-up
---
.../org/apache/openmeetings/web/common/menu/OmMenuItem.java| 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
index e1e63fd..53377ac 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
@@ -26,6 +26,7 @@ import java.util.List;
import java.util.stream.Collectors;
import org.apache.wicket.AttributeModifier;
+import org.apache.wicket.Component;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.markup.html.link.AbstractLink;
import org.apache.wicket.model.Model;
@@ -98,8 +99,8 @@ public class OmMenuItem implements INavbarComponent {
return items.stream().map(mItem ->
((OmMenuItem)mItem).createLink(markupId, false)).collect(Collectors.toList());
}
};
+ setAttributes(item);
}
- item.add(AttributeModifier.append(ATTR_TITLE, desc));
return item;
}
@@ -118,10 +119,15 @@ public class OmMenuItem implements INavbarComponent {
if (topLevel) {
link.add(AttributeModifier.append(ATTR_CLASS,
"nav-link"));
}
- link.setVisible(visible);
+ setAttributes(link);
return link.setIconType(icon);
}
+ private void setAttributes(Component comp) {
+ comp.add(AttributeModifier.append(ATTR_TITLE, desc));
+ comp.setVisible(visible);
+ }
+
@Override
public ComponentPosition getPosition() {
return ComponentPosition.LEFT; //FIXME TODO
[jira] [Commented] (OPENMEETINGS-2457) user can vote multiple times
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202943#comment-17202943 ] ASF subversion and git services commented on OPENMEETINGS-2457: --- Commit be9e2af12db46e3d859494b1edece8260a677ec5 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=be9e2af ] [OPENMEETINGS-2457] code clean-up > user can vote multiple times > > > Key: OPENMEETINGS-2457 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2457 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > User can volte multiple times. > Only the first vote counts. > Expecation: > User gets an error message or poll is not displayed after 1st vote. > Looks like [#OPENMEETINGS-1631] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2458) Vote: New poll should show "Display name" not "Firstname Lastname"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202941#comment-17202941
]
ASF subversion and git services commented on OPENMEETINGS-2458:
---
Commit 46b55ae74d42dd5d934bcfa1180bd70a6c863f34 in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=46b55ae ]
[OPENMEETINGS-2458] display name is being used where appropriate
> Vote: New poll should show "Display name" not "Firstname Lastname"
> --
>
> Key: OPENMEETINGS-2458
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2458
> Project: Openmeetings
> Issue Type: Improvement
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Attachments: Bildschirmfoto vom 2020-09-26 21-42-41.png,
> Bildschirmfoto vom 2020-09-26 22-02-24.png
>
>
> When a new poll ist show, the first line shows
>
> {code:java}
> "firstname" "lastname" wants to know:{code}
>
> When lastname or firstname is empty the display is "null".
> Same behaviour in
> "Poll Results".
> "Settings"->"Search Users"
>
> Better use the "display name" as shown in the participant list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2458] display name is being used where appropriate
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 46b55ae [OPENMEETINGS-2458] display name is being used where
appropriate
46b55ae is described below
commit 46b55ae74d42dd5d934bcfa1180bd70a6c863f34
Author: Maxim Solodovnik
AuthorDate: Mon Sep 28 07:43:46 2020 +0700
[OPENMEETINGS-2458] display name is being used where appropriate
---
.../java/org/apache/openmeetings/db/entity/user/User.java | 12
.../org/apache/openmeetings/web/room/poll/VoteDialog.java | 14 --
.../openmeetings/web/user/profile/UserSearchPanel.java | 6 +-
3 files changed, 13 insertions(+), 19 deletions(-)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
index a1f7c82..05388a3 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
@@ -664,8 +664,8 @@ public class User extends HistoricalEntity {
StringBuilder sb = new StringBuilder();
String delim = "";
OmLanguage l = LabelDao.getLanguage(languageId);
- String first = l.isRtl() ? getLastname() : getFirstname();
- String last = l.isRtl() ? getFirstname() : getLastname();
+ String first = l.isRtl() ? lastname : firstname;
+ String last = l.isRtl() ? firstname : lastname;
if (!Strings.isEmpty(first)) {
sb.append(first);
delim = " ";
@@ -673,8 +673,12 @@ public class User extends HistoricalEntity {
if (!Strings.isEmpty(last)) {
sb.append(delim).append(last);
}
- if (Strings.isEmpty(sb) && address != null &&
!Strings.isEmpty(address.getEmail())) {
- sb.append(delim).append(address.getEmail());
+ if (Strings.isEmpty(sb)) {
+ if (Type.CONTACT == type && address != null &&
!Strings.isEmpty(address.getEmail())) {
+ sb.append(address.getEmail());
+ } else {
+ sb.append(login);
+ }
}
if (Strings.isEmpty(sb)) {
sb.append(DISPLAY_NAME_NA);
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/VoteDialog.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/VoteDialog.java
index 0bea815..94129cd 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/VoteDialog.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/VoteDialog.java
@@ -61,7 +61,7 @@ public class VoteDialog extends Modal {
private static final List answers = List.of(1, 2, 3, 4, 5, 6,
7, 8, 9, 10);
private PollAnswerForm form;
private final NotificationPanel feedback = new
NotificationPanel("feedback");
- private final IModel user = Model.of((String)null);
+ private final Label userLbl = new Label("user", Model.of(""));
@SpringBean
private UserDao userDao;
@SpringBean
@@ -104,7 +104,7 @@ public class VoteDialog extends Modal {
}
static String getName(Component c, User u) {
- return u == null ? "" : (getUserId().equals(u.getId()) ?
c.getString("1411") : u.getFirstname() + " " + u.getLastname());
+ return u == null ? "" : (getUserId().equals(u.getId()) ?
c.getString("1411") : u.getDisplayName());
}
public void updateModel(IPartialPageRequestHandler target, RoomPoll rp)
{
@@ -112,7 +112,7 @@ public class VoteDialog extends Modal {
a.setRoomPoll(rp);
User u = userDao.get(getUserId());
a.setVotedUser(u);
- user.setObject(getName(this, a.getRoomPoll().getCreator()));
+ userLbl.setDefaultModelObject(getName(this,
a.getRoomPoll().getCreator()));
form.setModelObject(a);
boolean typeNum = a.getRoomPoll() != null &&
RoomPoll.Type.NUMERIC == a.getRoomPoll().getType();
form.typeBool.setVisible(!typeNum);
@@ -120,12 +120,6 @@ public class VoteDialog extends Modal {
target.add(form);
}
- @Override
- protected void onDetach() {
- user.detach();
- super.onDetach();
- }
-
private class PollAnswerForm extends Form {
private static final long serialVersionUID = 1L;
private final WebMarkupContainer typeBool = new
WebMarkupContainer("typeBool");
@@
[jira] [Commented] (OPENMEETINGS-2410) The page isn't redirecting properly
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202861#comment-17202861 ] Ali Alhaidary commented on OPENMEETINGS-2410: - I had the same issue of " The page isn't redirecting properly" after finishing the console installation and moving to the web installation. Looking to the log, I found that it was trying to write on/to the file /opt/omdb.mv.db, but that file was root:root, I changed it to nobody:nobody, and continue the web installation. Later on I did not use tomcat3.sh to start, but startup.sh instead. Don't ask what or where or why, I am no expert in that. > The page isn't redirecting properly > --- > > Key: OPENMEETINGS-2410 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2410 > Project: Openmeetings > Issue Type: Test > Components: Installer >Affects Versions: 5.0.0 > Environment: Ubuntu 18.04, 20.04 and Debian 9 > OM 5.0.0 Snapshot 3252 >Reporter: Alvaro >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Captura.png, tomcat4 > > > When run first time to start installing OM 5.0.0 Snapshot 3252: > sudo -u nobody $CATALINA_HOME/bin/startup.sh > /opt/open500 nobody:nogoup > 4 different times in Ubuntu 18.04, 20.04 and Debian 9 > ...the page say: The page isn't redirecting properly > A russian user got to run rightly so: > sudo /opt/open500/bin/startup.sh > ...and for me works also. > With different versions of Firefox. > Attached capture. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2457) user can vote multiple times
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2457. Fix Version/s: 5.1.0 Resolution: Fixed > user can vote multiple times > > > Key: OPENMEETINGS-2457 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2457 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > User can volte multiple times. > Only the first vote counts. > Expecation: > User gets an error message or poll is not displayed after 1st vote. > Looks like [#OPENMEETINGS-1631] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2457) user can vote multiple times
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202821#comment-17202821 ] ASF subversion and git services commented on OPENMEETINGS-2457: --- Commit c3af88264ac2294db474c0c88e9aad58114e30f3 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=c3af882 ] [OPENMEETINGS-2457] vote menu is updated as expected > user can vote multiple times > > > Key: OPENMEETINGS-2457 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2457 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Major > > User can volte multiple times. > Only the first vote counts. > Expecation: > User gets an error message or poll is not displayed after 1st vote. > Looks like [#OPENMEETINGS-1631] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2457] vote menu is updated as expected
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new c3af882 [OPENMEETINGS-2457] vote menu is updated as expected
c3af882 is described below
commit c3af88264ac2294db474c0c88e9aad58114e30f3
Author: Maxim Solodovnik
AuthorDate: Sun Sep 27 19:34:53 2020 +0700
[OPENMEETINGS-2457] vote menu is updated as expected
---
.../openmeetings/web/common/menu/MenuPanel.java| 9 -
.../openmeetings/web/common/menu/OmMenuItem.java | 38 +++
.../openmeetings/web/common/menu/RoomMenuItem.java | 39 ---
.../openmeetings/web/room/menu/ActionsSubMenu.java | 44 +++---
.../openmeetings/web/room/menu/PollsSubMenu.java | 24 ++--
.../openmeetings/web/room/menu/RoomMenuPanel.java | 12 +++---
6 files changed, 70 insertions(+), 96 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/MenuPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/MenuPanel.java
index 72b2dd1..bc561fa 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/MenuPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/MenuPanel.java
@@ -34,12 +34,19 @@ import
de.agilecoders.wicket.core.markup.html.bootstrap.navbar.Navbar;
*/
public class MenuPanel extends Panel {
private static final long serialVersionUID = 1L;
+ private final Navbar navbar = new Navbar("menu");
public MenuPanel(String id, List menus) {
super(id);
setOutputMarkupPlaceholderTag(true);
setMarkupId(id);
- add(new Navbar("menu").addComponents(menus));
+ navbar.addComponents(menus);
+ }
+
+ @Override
+ protected void onInitialize() {
+ super.onInitialize();
+ add(navbar);
}
public void update(IPartialPageRequestHandler target) {
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
index 0056b8e..e1e63fd 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/menu/OmMenuItem.java
@@ -41,20 +41,34 @@ import
de.agilecoders.wicket.core.markup.html.bootstrap.navbar.NavbarDropDownBut
public class OmMenuItem implements INavbarComponent {
private static final long serialVersionUID = 1L;
- private String title;
- private String desc;
- private IconType icon;
- private List items = new ArrayList<>(0);
+ private final String title;
+ private final String desc;
+ private final IconType icon;
+ private final List items = new ArrayList<>(0);
private boolean visible = true;
+ public OmMenuItem(String title, String desc) {
+ this(title, desc, null, List.of());
+ }
+
+ public OmMenuItem(String title, String desc, boolean visible) {
+ this(title, desc);
+ this.visible = visible;
+ }
+
public OmMenuItem(String title, List items) {
- this.title = title;
- this.items = items;
+ this(title, null, null, items);
}
- public OmMenuItem(String title, String desc) {
+ public OmMenuItem(String title, String desc, IconType icon) {
+ this(title, desc, icon, List.of());
+ }
+
+ public OmMenuItem(String title, String desc, IconType icon,
List items) {
this.title = title;
this.desc = desc;
+ this.icon = icon;
+ this.items.addAll(items);
}
public OmMenuItem add(INavbarComponent item) {
@@ -66,14 +80,6 @@ public class OmMenuItem implements INavbarComponent {
return desc;
}
- public void setDesc(String desc) {
- this.desc = desc;
- }
-
- public void setIcon(IconType icon) {
- this.icon = icon;
- }
-
public void setVisible(boolean visible) {
this.visible = visible;
}
@@ -94,7 +100,6 @@ public class OmMenuItem implements INavbarComponent {
};
}
item.add(AttributeModifier.append(ATTR_TITLE, desc));
- item.setVisible(visible);
return item;
}
@@ -113,6 +118,7 @@ public class OmMenuItem implements INavbarComponent {
if (topLevel) {
link.add(AttributeModifier.append(ATTR_CLASS,
"nav-link"));
}
+ link.setVisible(visible);
[jira] [Updated] (OPENMEETINGS-2425) Translation to Arabic need to be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alhaidary updated OPENMEETINGS-2425: Attachment: Screenshot_2020-09-27 النُّجُومُ الخَمْسَةِ (ص).png some words in the confirmation email still needs to be translated and have no entry in the language table Your account details OpenMeeting > Translation to Arabic need to be improved > - > > Key: OPENMEETINGS-2425 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2425 > Project: Openmeetings > Issue Type: Bug > Components: Translations >Affects Versions: 5.0.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.1 > > Attachments: Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, My rooms.png, > Screenshot from 2020-09-09 23-24-59.png, Screenshot_2020-09-09 مَوْقِعُ > النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه > عَلَيْهُمْ).png, Screenshot_2020-09-10 مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ > الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png, Screenshot_2020-09-10 > مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه > عَلَيْهُمْ).png, Screenshot_2020-09-27 النُّجُومُ الخَمْسَةِ (ص).png, > profile.png > > > The (ROOMS) menu title does not have an entry in the language pack, so to > whatever language you change, this menu title stays (ROOMS) and does (and can > not) change... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2425) Translation to Arabic need to be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202794#comment-17202794 ] Ali Alhaidary commented on OPENMEETINGS-2425: - some words in the confirmation email still needs to be translated and have no entry in the language table !Screenshot_2020-09-27 النُّجُومُ الخَمْسَةِ (ص).png! . attached is screen shot. > Translation to Arabic need to be improved > - > > Key: OPENMEETINGS-2425 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2425 > Project: Openmeetings > Issue Type: Bug > Components: Translations >Affects Versions: 5.0.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.1 > > Attachments: Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, My rooms.png, > Screenshot from 2020-09-09 23-24-59.png, Screenshot_2020-09-09 مَوْقِعُ > النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه > عَلَيْهُمْ).png, Screenshot_2020-09-10 مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ > الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png, Screenshot_2020-09-10 > مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه > عَلَيْهُمْ).png, profile.png > > > The (ROOMS) menu title does not have an entry in the language pack, so to > whatever language you change, this menu title stays (ROOMS) and does (and can > not) change... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2461) check digit & check special does not take effect
Ali Alhaidary created OPENMEETINGS-2461: --- Summary: check digit & check special does not take effect Key: OPENMEETINGS-2461 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2461 Project: Openmeetings Issue Type: Bug Components: Security Affects Versions: 5.0.1, 5.1.0 Reporter: Ali Alhaidary Assignee: Maxim Solodovnik check digit and check special takes no effect, the new user is still prompted that his password is week and should put at least a digit and a special character, otherwise, will not accept his registration. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2460) FireFox on iOS
Ali Alhaidary created OPENMEETINGS-2460: --- Summary: FireFox on iOS Key: OPENMEETINGS-2460 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2460 Project: Openmeetings Issue Type: Bug Components: Audio/Video Affects Versions: 5.0.1, 5.1.0 Reporter: Ali Alhaidary Assignee: Maxim Solodovnik Attachments: ff-ios.png audio/video is not working. attached is the massage that shows when testing settings -- This message was sent by Atlassian Jira (v8.3.4#803005)
