[jira] [Commented] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235224#comment-17235224 ] Alvaro commented on OPENMEETINGS-2340: -- sudo systemctl restart coturn.service > Media server connection for user firstname lastname is failed, will try to > re-connect > - > > Key: OPENMEETINGS-2340 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M4 > Environment: Centos 7 (x64). Openmeetings installed according to the > instructions > https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on% > 20Centos% 207.pdf >Reporter: Alex >Assignee: Maxim Solodovnik >Priority: Major > Labels: RedHat > Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg > > > Periodically disappears and again there is a connection with the media server > (KMS) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2425) Translation to Arabic need to be improved
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235207#comment-17235207 ] Ali Alhaidary commented on OPENMEETINGS-2425: - ping :) > Translation to Arabic need to be improved > - > > Key: OPENMEETINGS-2425 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2425 > Project: Openmeetings > Issue Type: Bug > Components: Translations >Affects Versions: 5.0.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.1 > > Attachments: Apache_OpenMeetings_Arabic.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, Application_ar.properties.xml, > Application_ar.properties.xml, My rooms.png, Screenshot from 2020-09-09 > 23-24-59.png, Screenshot_2020-09-09 مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ > الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png, Screenshot_2020-09-10 > مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه > عَلَيْهُمْ).png, Screenshot_2020-09-10 مَوْقِعُ النُّجُومِ الخمسه (أَصْحَابُ > الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png, Screenshot_2020-09-27 > النُّجُومُ الخَمْسَةِ (ص).png, profile.png > > > The (ROOMS) menu title does not have an entry in the language pack, so to > whatever language you change, this menu title stays (ROOMS) and does (and can > not) change... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2340) Media server connection for user firstname lastname is failed, will try to re-connect
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235172#comment-17235172 ] Andrey commented on OPENMEETINGS-2340: -- Good afternoon! Yes, I tried to solve the problem using this guide, but it didn't help! > Media server connection for user firstname lastname is failed, will try to > re-connect > - > > Key: OPENMEETINGS-2340 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2340 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M4 > Environment: Centos 7 (x64). Openmeetings installed according to the > instructions > https://cwiki.apache.org/confluence/display/OPENMEETINGS/Tutorials+for+installing+OpenMeetings+and+Tools?preview=/27838216/148648452/Installation%20OpenMeetings%205.0.0-M4%20on% > 20Centos% 207.pdf >Reporter: Alex >Assignee: Maxim Solodovnik >Priority: Major > Labels: RedHat > Attachments: Error_Message.jpg, Log_of_Flip_Flop.jpg > > > Periodically disappears and again there is a connection with the media server > (KMS) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2514) Unenroll user seems to be broken
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235152#comment-17235152 ] ASF subversion and git services commented on OPENMEETINGS-2514: --- Commit 059b3638c4c4f821c8d543c7bacb3799fd158054 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=059b363 ] [OPENMEETINGS-2514] unenroll should be fixed > Unenroll user seems to be broken > > > Key: OPENMEETINGS-2514 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2514 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Unenroll user seems to be broken > If i hit the unenrool user button in the front end, the connection > doesn't dissapear all the way. The video and audio stream of the > unenrolled user stops but the unenrolled user stays in the room and > still can use the pointer (google maps like symbol) tool. >The Host sees the pointer blinking even so the user vanished from the > user list. The guest which was unenrolled still has a full list of users > cause he stays in the room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2514] unenroll should be fixed
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 059b363 [OPENMEETINGS-2514] unenroll should be fixed
059b363 is described below
commit 059b3638c4c4f821c8d543c7bacb3799fd158054
Author: Maxim Solodovnik
AuthorDate: Thu Nov 19 10:33:07 2020 +0700
[OPENMEETINGS-2514] unenroll should be fixed
---
.../org/apache/openmeetings/web/app/Application.java| 1 -
.../java/org/apache/openmeetings/web/room/raw-room.js | 17 ++---
.../openmeetings/web/room/sidebar/RoomSidebar.html | 10 ++
.../openmeetings/web/room/sidebar/RoomSidebar.java | 16 ++--
.../org/apache/openmeetings/web/room/wb/WbPanel.html| 12 ++--
.../org/apache/openmeetings/web/room/wb/raw-wb-board.js | 8 +++-
6 files changed, 31 insertions(+), 33 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java
index e431f7c..5debb49 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java
@@ -425,7 +425,6 @@ public class Application extends
AuthenticatedWebApplication implements IApplica
public static void kickUser(Client client) {
if (client != null) {
WebSocketHelper.sendRoom(new
TextRoomMessage(client.getRoom().getId(), client, RoomMessage.Type.KICK,
client.getUid()));
- get().cm.exitRoom(client);
}
}
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-room.js
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-room.js
index 025f98a..a54e350 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-room.js
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-room.js
@@ -308,14 +308,20 @@ var Room = (function() {
icon.hide();
}
}
- function __activityIcon(elem, selector, predicate, action) {
+ function __activityIcon(elem, selector, predicate, action, confirm) {
let icon = elem.find(selector);
if (predicate()) {
if (icon.length === 0) {
icon = OmUtil.tmpl('#user-actions-stub ' +
selector);
elem.append(icon);
}
- icon.off().click(action);
+ icon.off();
+ if (confirm) {
+ icon.confirmation('dispose');
+ icon.confirmation(confirm)
+ } else {
+ icon.click(action);
+ }
} else {
icon.hide();
}
@@ -440,7 +446,12 @@ var Room = (function() {
__rightOtherIcons(c, actions);
__activityIcon(actions, '.kick'
, () => !self && _hasRight('MODERATOR') &&
!_hasRight('SUPER_MODERATOR', c.rights)
- , function() { OmUtil.roomAction({action: 'kick', uid:
c.uid}); });
+ , null
+ , {
+ confirmationEvent: 'om-kick'
+ , placement: Settings.isRtl ? 'left' : 'right'
+ , onConfirm: () => OmUtil.roomAction({action:
'kick', uid: c.uid})
+ });
__activityIcon(actions, '.private-chat'
, () => options.userId !== c.user.id &&
$('#chatPanel').is(':visible')
, function() {
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.html
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.html
index 7b37644..14123fe 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.html
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.html
@@ -60,7 +60,6 @@
-
@@ -73,14 +72,14 @@
-
+
-
+
@@ -106,7 +105,10 @@
[jira] [Resolved] (OPENMEETINGS-2514) Unenroll user seems to be broken
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2514. Fix Version/s: 5.1.0 Resolution: Fixed > Unenroll user seems to be broken > > > Key: OPENMEETINGS-2514 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2514 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Unenroll user seems to be broken > If i hit the unenrool user button in the front end, the connection > doesn't dissapear all the way. The video and audio stream of the > unenrolled user stops but the unenrolled user stays in the room and > still can use the pointer (google maps like symbol) tool. >The Host sees the pointer blinking even so the user vanished from the > user list. The guest which was unenrolled still has a full list of users > cause he stays in the room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2514) Unenroll user seems to be broken
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2514: --- Affects Version/s: 5.0.1 > Unenroll user seems to be broken > > > Key: OPENMEETINGS-2514 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2514 > Project: Openmeetings > Issue Type: Bug >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > > Unenroll user seems to be broken > If i hit the unenrool user button in the front end, the connection > doesn't dissapear all the way. The video and audio stream of the > unenrolled user stops but the unenrolled user stays in the room and > still can use the pointer (google maps like symbol) tool. >The Host sees the pointer blinking even so the user vanished from the > user list. The guest which was unenrolled still has a full list of users > cause he stays in the room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2514) Unenroll user seems to be broken
Maxim Solodovnik created OPENMEETINGS-2514: -- Summary: Unenroll user seems to be broken Key: OPENMEETINGS-2514 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2514 Project: Openmeetings Issue Type: Bug Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Unenroll user seems to be broken If i hit the unenrool user button in the front end, the connection doesn't dissapear all the way. The video and audio stream of the unenrolled user stops but the unenrolled user stays in the room and still can use the pointer (google maps like symbol) tool. The Host sees the pointer blinking even so the user vanished from the user list. The guest which was unenrolled still has a full list of users cause he stays in the room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2441) Inviting for a meeting as user of type "USER" returns "Internal Error"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234815#comment-17234815
]
ASF subversion and git services commented on OPENMEETINGS-2441:
---
Commit b80d897bd8865a9a833a4765d6488e19dadd747b in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b80d897 ]
[OPENMEETINGS-2441] invitation saving should be more stable
> Inviting for a meeting as user of type "USER" returns "Internal Error"
> --
>
> Key: OPENMEETINGS-2441
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2441
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: log.txt
>
>
> Creating an invitation for a meeting as non "admin" user of type "USER"
> returns an "Internal error"
> The logfile contains
> {code:java}
> Unexpected error occurred
> org.springframework.dao.InvalidDataAccessApiUsageException: Encountered
> unmanaged object "org.apache.openmeetings.db.entity.user.User@12d1cbb4" in
> life cycle state unmanaged while cascading persistence via field
> "org.apache.openmeetings.db.entity.room.Invitation.invitedBy" during flush.
> However, this field does not allow cascade persist. You cannot flush
> unmanaged objects or graphs that have persistent associations to unmanaged
> objects{code}
> Creating an invitation as user "admin" works fine.
> [^log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2441] invitation saving should be more stable
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b80d897 [OPENMEETINGS-2441] invitation saving should be more stable
b80d897 is described below
commit b80d897bd8865a9a833a4765d6488e19dadd747b
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 23:21:29 2020 +0700
[OPENMEETINGS-2441] invitation saving should be more stable
---
.../main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
index df76dcc..77a4a95 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
@@ -41,6 +41,7 @@ import javax.persistence.PersistenceContext;
import org.apache.openmeetings.db.dao.IDataProviderDao;
import org.apache.openmeetings.db.entity.room.Invitation;
import org.apache.openmeetings.db.entity.room.Invitation.Valid;
+import org.apache.openmeetings.db.entity.user.User;
import org.apache.openmeetings.util.CalendarHelper;
import org.apache.wicket.util.string.Strings;
import org.slf4j.Logger;
@@ -118,6 +119,8 @@ public class InvitationDao implements
IDataProviderDao {
}
public Invitation update(Invitation invitation) {
+ // [OPENMEETINGS-2441] in life cycle state unmanaged while
cascading persistence via field
+ invitation.setInvitedBy(em.find(User.class,
invitation.getInvitedBy().getId()));
if (invitation.getId() == null) {
invitation.setInserted(new Date());
em.persist(invitation);
[jira] [Commented] (OPENMEETINGS-2441) Inviting for a meeting as user of type "USER" returns "Internal Error"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234800#comment-17234800
]
ASF subversion and git services commented on OPENMEETINGS-2441:
---
Commit b80d897bd8865a9a833a4765d6488e19dadd747b in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b80d897 ]
[OPENMEETINGS-2441] invitation saving should be more stable
> Inviting for a meeting as user of type "USER" returns "Internal Error"
> --
>
> Key: OPENMEETINGS-2441
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2441
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: log.txt
>
>
> Creating an invitation for a meeting as non "admin" user of type "USER"
> returns an "Internal error"
> The logfile contains
> {code:java}
> Unexpected error occurred
> org.springframework.dao.InvalidDataAccessApiUsageException: Encountered
> unmanaged object "org.apache.openmeetings.db.entity.user.User@12d1cbb4" in
> life cycle state unmanaged while cascading persistence via field
> "org.apache.openmeetings.db.entity.room.Invitation.invitedBy" during flush.
> However, this field does not allow cascade persist. You cannot flush
> unmanaged objects or graphs that have persistent associations to unmanaged
> objects{code}
> Creating an invitation as user "admin" works fine.
> [^log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2277) Can't listen any audio from OM on Mac-OSX
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234803#comment-17234803 ] Maxim Solodovnik commented on OPENMEETINGS-2277: This turn out to be Safari issue Should be self-fixed with the release of Safari 14.1 > Can't listen any audio from OM on Mac-OSX > -- > > Key: OPENMEETINGS-2277 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2277 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.0-M3 > Environment: MacBook Air (13-inch, Early 2015) > 10.15.3 > Browser: > * latest Safari > * latest Firefox (either audio or video is committed, not both) >Reporter: Marcus >Assignee: Sebastian Wagner >Priority: Major > Labels: OSX, audio, mac-os-x > Fix For: 5.1.0 > > > Apple Mac doesn't play any audio coming from OM > Although browser requests permission for Camera and Microphone and everything > looks fine (Audio/Video is transferred to the clients) the local audio is > dead. Only the tone for enter room and exit room is beeing played on local > audio. > Tested with loudspeakers as well as headphones and Apple-Play (personally I > don't know anything about Apple-Play, looks like something similar to Alexa?) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2441] invitation saving should be more stable
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b80d897 [OPENMEETINGS-2441] invitation saving should be more stable
b80d897 is described below
commit b80d897bd8865a9a833a4765d6488e19dadd747b
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 23:21:29 2020 +0700
[OPENMEETINGS-2441] invitation saving should be more stable
---
.../main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
index df76dcc..77a4a95 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
@@ -41,6 +41,7 @@ import javax.persistence.PersistenceContext;
import org.apache.openmeetings.db.dao.IDataProviderDao;
import org.apache.openmeetings.db.entity.room.Invitation;
import org.apache.openmeetings.db.entity.room.Invitation.Valid;
+import org.apache.openmeetings.db.entity.user.User;
import org.apache.openmeetings.util.CalendarHelper;
import org.apache.wicket.util.string.Strings;
import org.slf4j.Logger;
@@ -118,6 +119,8 @@ public class InvitationDao implements
IDataProviderDao {
}
public Invitation update(Invitation invitation) {
+ // [OPENMEETINGS-2441] in life cycle state unmanaged while
cascading persistence via field
+ invitation.setInvitedBy(em.find(User.class,
invitation.getInvitedBy().getId()));
if (invitation.getId() == null) {
invitation.setInserted(new Date());
em.persist(invitation);
[jira] [Commented] (OPENMEETINGS-2280) Android landscape mode cannot sign up as virtual keyboard covers UI
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234794#comment-17234794 ] Maxim Solodovnik commented on OPENMEETINGS-2280: [~sebawagner] Just have tested with my Android there are no scroll bars, but the dialog can be scrolled Are you sure the code need to be modified to address this issue? > Android landscape mode cannot sign up as virtual keyboard covers UI > --- > > Key: OPENMEETINGS-2280 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2280 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.0.0-M3, 5.0.0-M4 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Minor > Fix For: 5.1.0 > > > In Android, when in landscape mode, when going to the sign up screen the > virtual keyboard covers the UI. And the UI doesn't allow scrolling, so you > can't go to the bottom of the screen to see the captch. > Needs screenshot -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2441) Inviting for a meeting as user of type "USER" returns "Internal Error"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234786#comment-17234786
]
ASF subversion and git services commented on OPENMEETINGS-2441:
---
Commit b80d897bd8865a9a833a4765d6488e19dadd747b in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b80d897 ]
[OPENMEETINGS-2441] invitation saving should be more stable
> Inviting for a meeting as user of type "USER" returns "Internal Error"
> --
>
> Key: OPENMEETINGS-2441
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2441
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: log.txt
>
>
> Creating an invitation for a meeting as non "admin" user of type "USER"
> returns an "Internal error"
> The logfile contains
> {code:java}
> Unexpected error occurred
> org.springframework.dao.InvalidDataAccessApiUsageException: Encountered
> unmanaged object "org.apache.openmeetings.db.entity.user.User@12d1cbb4" in
> life cycle state unmanaged while cascading persistence via field
> "org.apache.openmeetings.db.entity.room.Invitation.invitedBy" during flush.
> However, this field does not allow cascade persist. You cannot flush
> unmanaged objects or graphs that have persistent associations to unmanaged
> objects{code}
> Creating an invitation as user "admin" works fine.
> [^log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2441] invitation saving should be more stable
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b80d897 [OPENMEETINGS-2441] invitation saving should be more stable
b80d897 is described below
commit b80d897bd8865a9a833a4765d6488e19dadd747b
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 23:21:29 2020 +0700
[OPENMEETINGS-2441] invitation saving should be more stable
---
.../main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
index df76dcc..77a4a95 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/room/InvitationDao.java
@@ -41,6 +41,7 @@ import javax.persistence.PersistenceContext;
import org.apache.openmeetings.db.dao.IDataProviderDao;
import org.apache.openmeetings.db.entity.room.Invitation;
import org.apache.openmeetings.db.entity.room.Invitation.Valid;
+import org.apache.openmeetings.db.entity.user.User;
import org.apache.openmeetings.util.CalendarHelper;
import org.apache.wicket.util.string.Strings;
import org.slf4j.Logger;
@@ -118,6 +119,8 @@ public class InvitationDao implements
IDataProviderDao {
}
public Invitation update(Invitation invitation) {
+ // [OPENMEETINGS-2441] in life cycle state unmanaged while
cascading persistence via field
+ invitation.setInvitedBy(em.find(User.class,
invitation.getInvitedBy().getId()));
if (invitation.getId() == null) {
invitation.setInserted(new Date());
em.persist(invitation);
[jira] [Resolved] (OPENMEETINGS-2441) Inviting for a meeting as user of type "USER" returns "Internal Error"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-2441.
Fix Version/s: 5.1.0
Resolution: Fixed
NREP for me, but tried to improve it
> Inviting for a meeting as user of type "USER" returns "Internal Error"
> --
>
> Key: OPENMEETINGS-2441
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2441
> Project: Openmeetings
> Issue Type: Bug
> Components: Calendar
>Affects Versions: 5.0.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: log.txt
>
>
> Creating an invitation for a meeting as non "admin" user of type "USER"
> returns an "Internal error"
> The logfile contains
> {code:java}
> Unexpected error occurred
> org.springframework.dao.InvalidDataAccessApiUsageException: Encountered
> unmanaged object "org.apache.openmeetings.db.entity.user.User@12d1cbb4" in
> life cycle state unmanaged while cascading persistence via field
> "org.apache.openmeetings.db.entity.room.Invitation.invitedBy" during flush.
> However, this field does not allow cascade persist. You cannot flush
> unmanaged objects or graphs that have persistent associations to unmanaged
> objects{code}
> Creating an invitation as user "admin" works fine.
> [^log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2513) Room is rendered incompletely
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234743#comment-17234743 ] ASF subversion and git services commented on OPENMEETINGS-2513: --- Commit 80cfe8355e184667bc93c4ea14d5f34929810fe2 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=80cfe83 ] [OPENMEETINGS-2513] code clean-up > Room is rendered incompletely > - > > Key: OPENMEETINGS-2513 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 > Project: Openmeetings > Issue Type: Bug > Components: Invitation, Room >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > Room is rendered with errors (some elements are missing) > In case password protected invitation is used > Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2466) Camera is occupied (on) even after leaving the room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2466. Resolution: Fixed this one should be more stable please re-open with additional details if still an issue > Camera is occupied (on) even after leaving the room > --- > > Key: OPENMEETINGS-2466 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2466 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > > Camera keeps occupied (on) even after leaving the room, no other application > can use it. It will turn off after logging out of OM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2513] code clean-up
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 80cfe83 [OPENMEETINGS-2513] code clean-up
80cfe83 is described below
commit 80cfe8355e184667bc93c4ea14d5f34929810fe2
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 22:37:27 2020 +0700
[OPENMEETINGS-2513] code clean-up
---
.../src/main/java/org/apache/openmeetings/web/pages/BasePage.java | 2 +-
.../src/main/java/org/apache/openmeetings/web/user/chat/Chat.java | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.java
index 0c993f0..c26357c 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.java
@@ -137,7 +137,7 @@ public abstract class BasePage extends
AsyncUrlFragmentAwarePage {
@Override
public List getDependencies() {
- return
List.of(JavaScriptHeaderItem.forUrl("https://www.googletagmanager.com/gtag/js?id=;
+ getGaCode()).setAsync(true));
+ return List.of(new
PriorityHeaderItem(JavaScriptHeaderItem.forUrl("https://www.googletagmanager.com/gtag/js?id=;
+ getGaCode()).setAsync(true)));
}
})));
StringBuilder script = new StringBuilder("initGA('")
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
index fdd7598..3d91602 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
@@ -176,9 +176,10 @@ public class Chat extends Panel {
@Override
public List getDependencies() {
- return
List.of(JavaScriptHeaderItem.forScript("const bstooltip = jQuery.fn.tooltip;",
"preserve-bs-tooltip")
- ,
JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference())
- ,
JavaScriptHeaderItem.forScript("jQuery.fn.tooltip = bstooltip;",
"restore-bs-tooltip")
+ return List.of(
+ new
PriorityHeaderItem(JavaScriptHeaderItem.forScript("const bstooltip =
jQuery.fn.tooltip;", "preserve-bs-tooltip"))
+ , new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference()))
+ , new
PriorityHeaderItem(JavaScriptHeaderItem.forScript("jQuery.fn.tooltip =
bstooltip;", "restore-bs-tooltip"))
);
}
});
[jira] [Resolved] (OPENMEETINGS-2474) Join Openmeeting through Mobile Device Browser
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2474. Resolution: Cannot Reproduce Please re-open with additional details if still an issue > Join Openmeeting through Mobile Device Browser > -- > > Key: OPENMEETINGS-2474 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2474 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.1 >Reporter: Tania Chowdhary >Assignee: Maxim Solodovnik >Priority: Major > > Hello, > When I joined openmeeting conference using invitation link of any mobile > device web browser (Chrome, Edge, Firefox, Opera, or Safari) I can hear or > see other users who joined through Laptop or computer but my camera and audio > didn't work! > Could you please let me know what kinds of permission do I need to provide my > mobile browser (I gave camera permission but, it same!) to join with > audio/video facilities! > > Thank you > Tania -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2501) I have a installation problem. Openmeetings 5.0.1
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234733#comment-17234733 ] Maxim Solodovnik commented on OPENMEETINGS-2501: [~Icetist] can this issue be closed? > I have a installation problem. Openmeetings 5.0.1 > - > > Key: OPENMEETINGS-2501 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2501 > Project: Openmeetings > Issue Type: Task > Components: Installer, OAuth >Affects Versions: 5.0.1 > Environment: Centos 8 >Reporter: Icetist >Assignee: Maxim Solodovnik >Priority: Major > Labels: RedHat > Fix For: 5.0.1 > > > Hello OpenMeetings, > > This is the first time using Jira so please consider. > I am installing Openmeetings 5.0.1 and I encountered an error on Pg 8, first > screenshot. There is a error like this: > > Cannot load the proper DB driver. Please download the corresponding jar file > and restart the OM server. Instructions: href="https://openmeetings.apache.org/MySQLConfig.html;>MySQL > > I am on Centos 8 and a beginner in linux. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2501) I have a installation problem. Openmeetings 5.0.1
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2501: --- Fix Version/s: (was: 5.0.1) > I have a installation problem. Openmeetings 5.0.1 > - > > Key: OPENMEETINGS-2501 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2501 > Project: Openmeetings > Issue Type: Task > Components: Installer, OAuth >Affects Versions: 5.0.1 > Environment: Centos 8 >Reporter: Icetist >Assignee: Maxim Solodovnik >Priority: Major > Labels: RedHat > > Hello OpenMeetings, > > This is the first time using Jira so please consider. > I am installing Openmeetings 5.0.1 and I encountered an error on Pg 8, first > screenshot. There is a error like this: > > Cannot load the proper DB driver. Please download the corresponding jar file > and restart the OM server. Instructions: href="https://openmeetings.apache.org/MySQLConfig.html;>MySQL > > I am on Centos 8 and a beginner in linux. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2455) (5.1.0) Library versions need to be updated
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234708#comment-17234708 ] ASF subversion and git services commented on OPENMEETINGS-2455: --- Commit 68589714c1e0bcef3cd8cbba83279dbc6d11e3f0 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=6858971 ] [OPENMEETINGS-2455] tomcat > (5.1.0) Library versions need to be updated > --- > > Key: OPENMEETINGS-2455 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2455 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Library versions need to be updated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2455] tomcat
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 6858971 [OPENMEETINGS-2455] tomcat 6858971 is described below commit 68589714c1e0bcef3cd8cbba83279dbc6d11e3f0 Author: Maxim Solodovnik AuthorDate: Wed Nov 18 22:05:39 2020 +0700 [OPENMEETINGS-2455] tomcat --- openmeetings-server/pom.xml | 2 +- pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openmeetings-server/pom.xml b/openmeetings-server/pom.xml index 655dd7c..53737de 100644 --- a/openmeetings-server/pom.xml +++ b/openmeetings-server/pom.xml @@ -118,7 +118,7 @@ prepare-web-server - web-server/apache-tomcat-9.0.39.tar.gz + web-server/apache-tomcat-9.0.40.tar.gz diff --git a/pom.xml b/pom.xml index dda33e7..91fab35 100644 --- a/pom.xml +++ b/pom.xml @@ -82,7 +82,7 @@ 5.0.2 5.15.1 5.3.1 - 9.0.39 + 9.0.40 3.0.18 3.4.1 2.7.1
[jira] [Commented] (OPENMEETINGS-2513) Room is rendered incompletely
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234389#comment-17234389 ] ASF subversion and git services commented on OPENMEETINGS-2513: --- Commit b9b202a120b2720ce46b339e0fe8a7525760a9f8 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b9b202a ] [OPENMEETINGS-2513] room is displayed as expected if entered via password protected invitation > Room is rendered incompletely > - > > Key: OPENMEETINGS-2513 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 > Project: Openmeetings > Issue Type: Bug > Components: Invitation, Room >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > Room is rendered with errors (some elements are missing) > In case password protected invitation is used > Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2513] room is displayed as expected if entered via password protected invitation
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b9b202a [OPENMEETINGS-2513] room is displayed as expected if entered
via password protected invitation
b9b202a is described below
commit b9b202a120b2720ce46b339e0fe8a7525760a9f8
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 15:49:57 2020 +0700
[OPENMEETINGS-2513] room is displayed as expected if entered via password
protected invitation
---
.../main/java/org/apache/openmeetings/web/room/RoomPanel.java | 11 ++-
.../main/java/org/apache/openmeetings/web/user/chat/Chat.java | 5 ++---
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
index e0f9780..f79c1bb 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
@@ -81,6 +81,7 @@ import
org.apache.wicket.authroles.authorization.strategies.role.annotations.Aut
import org.apache.wicket.core.request.handler.IPartialPageRequestHandler;
import org.apache.wicket.event.IEvent;
import org.apache.wicket.extensions.ajax.AjaxDownloadBehavior;
+import org.apache.wicket.markup.head.HeaderItem;
import org.apache.wicket.markup.head.IHeaderResponse;
import org.apache.wicket.markup.head.JavaScriptHeaderItem;
import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
@@ -108,6 +109,7 @@ import com.github.openjson.JSONObject;
import com.googlecode.wicket.jquery.core.JQueryBehavior;
import com.googlecode.wicket.jquery.core.Options;
import com.googlecode.wicket.jquery.ui.interaction.droppable.Droppable;
+import com.googlecode.wicket.jquery.ui.settings.JQueryUILibrarySettings;
import
de.agilecoders.wicket.core.markup.html.bootstrap.button.BootstrapAjaxLink;
import de.agilecoders.wicket.core.markup.html.bootstrap.button.Buttons;
@@ -679,7 +681,14 @@ public class RoomPanel extends BasePanel {
public void renderHead(IHeaderResponse response) {
super.renderHead(response);
response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(interview ?
INTERVIEWWB_JS_REFERENCE : WB_JS_REFERENCE)));
- response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(new
JavaScriptResourceReference(RoomPanel.class, "room.js";
+ response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(new
JavaScriptResourceReference(RoomPanel.class, "room.js"))) {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public List getDependencies() {
+ return List.of(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference(;
+ }
+ });
response.render(JavaScriptHeaderItem.forReference(TouchPunchResourceReference.instance()));
if (room.isVisible()) {
response.render(OnDomReadyHeaderItem.forScript(roomEnter.getCallbackScript()));
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
index ef941e3..fdd7598 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
@@ -60,8 +60,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.github.openjson.JSONObject;
-
-import
de.agilecoders.wicket.extensions.markup.html.bootstrap.jqueryui.JQueryUIJavaScriptReference;
+import com.googlecode.wicket.jquery.ui.settings.JQueryUILibrarySettings;
public class Chat extends Panel {
private static final long serialVersionUID = 1L;
@@ -178,7 +177,7 @@ public class Chat extends Panel {
@Override
public List getDependencies() {
return
List.of(JavaScriptHeaderItem.forScript("const bstooltip = jQuery.fn.tooltip;",
"preserve-bs-tooltip")
- ,
JQueryUIJavaScriptReference.asHeaderItem()
+ ,
JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference())
,
JavaScriptHeaderItem.forScript("jQuery.fn.tooltip = bstooltip;",
"restore-bs-tooltip")
);
}
[jira] [Commented] (OPENMEETINGS-2513) Room is rendered incompletely
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234382#comment-17234382 ] ASF subversion and git services commented on OPENMEETINGS-2513: --- Commit b9b202a120b2720ce46b339e0fe8a7525760a9f8 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b9b202a ] [OPENMEETINGS-2513] room is displayed as expected if entered via password protected invitation > Room is rendered incompletely > - > > Key: OPENMEETINGS-2513 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 > Project: Openmeetings > Issue Type: Bug > Components: Invitation, Room >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > Room is rendered with errors (some elements are missing) > In case password protected invitation is used > Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2513] room is displayed as expected if entered via password protected invitation
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b9b202a [OPENMEETINGS-2513] room is displayed as expected if entered
via password protected invitation
b9b202a is described below
commit b9b202a120b2720ce46b339e0fe8a7525760a9f8
Author: Maxim Solodovnik
AuthorDate: Wed Nov 18 15:49:57 2020 +0700
[OPENMEETINGS-2513] room is displayed as expected if entered via password
protected invitation
---
.../main/java/org/apache/openmeetings/web/room/RoomPanel.java | 11 ++-
.../main/java/org/apache/openmeetings/web/user/chat/Chat.java | 5 ++---
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
index e0f9780..f79c1bb 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.java
@@ -81,6 +81,7 @@ import
org.apache.wicket.authroles.authorization.strategies.role.annotations.Aut
import org.apache.wicket.core.request.handler.IPartialPageRequestHandler;
import org.apache.wicket.event.IEvent;
import org.apache.wicket.extensions.ajax.AjaxDownloadBehavior;
+import org.apache.wicket.markup.head.HeaderItem;
import org.apache.wicket.markup.head.IHeaderResponse;
import org.apache.wicket.markup.head.JavaScriptHeaderItem;
import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
@@ -108,6 +109,7 @@ import com.github.openjson.JSONObject;
import com.googlecode.wicket.jquery.core.JQueryBehavior;
import com.googlecode.wicket.jquery.core.Options;
import com.googlecode.wicket.jquery.ui.interaction.droppable.Droppable;
+import com.googlecode.wicket.jquery.ui.settings.JQueryUILibrarySettings;
import
de.agilecoders.wicket.core.markup.html.bootstrap.button.BootstrapAjaxLink;
import de.agilecoders.wicket.core.markup.html.bootstrap.button.Buttons;
@@ -679,7 +681,14 @@ public class RoomPanel extends BasePanel {
public void renderHead(IHeaderResponse response) {
super.renderHead(response);
response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(interview ?
INTERVIEWWB_JS_REFERENCE : WB_JS_REFERENCE)));
- response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(new
JavaScriptResourceReference(RoomPanel.class, "room.js";
+ response.render(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(new
JavaScriptResourceReference(RoomPanel.class, "room.js"))) {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public List getDependencies() {
+ return List.of(new
PriorityHeaderItem(JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference(;
+ }
+ });
response.render(JavaScriptHeaderItem.forReference(TouchPunchResourceReference.instance()));
if (room.isVisible()) {
response.render(OnDomReadyHeaderItem.forScript(roomEnter.getCallbackScript()));
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
index ef941e3..fdd7598 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/Chat.java
@@ -60,8 +60,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.github.openjson.JSONObject;
-
-import
de.agilecoders.wicket.extensions.markup.html.bootstrap.jqueryui.JQueryUIJavaScriptReference;
+import com.googlecode.wicket.jquery.ui.settings.JQueryUILibrarySettings;
public class Chat extends Panel {
private static final long serialVersionUID = 1L;
@@ -178,7 +177,7 @@ public class Chat extends Panel {
@Override
public List getDependencies() {
return
List.of(JavaScriptHeaderItem.forScript("const bstooltip = jQuery.fn.tooltip;",
"preserve-bs-tooltip")
- ,
JQueryUIJavaScriptReference.asHeaderItem()
+ ,
JavaScriptHeaderItem.forReference(JQueryUILibrarySettings.get().getJavaScriptReference())
,
JavaScriptHeaderItem.forScript("jQuery.fn.tooltip = bstooltip;",
"restore-bs-tooltip")
);
}
[jira] [Resolved] (OPENMEETINGS-2513) Room is rendered incompletely
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2513. Resolution: Fixed > Room is rendered incompletely > - > > Key: OPENMEETINGS-2513 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 > Project: Openmeetings > Issue Type: Bug > Components: Invitation, Room >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > Room is rendered with errors (some elements are missing) > In case password protected invitation is used > Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2513) Room is rendered incompletely
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2513: --- Priority: Critical (was: Major) > Room is rendered incompletely > - > > Key: OPENMEETINGS-2513 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 > Project: Openmeetings > Issue Type: Bug > Components: Invitation, Room >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.1.0 > > > Room is rendered with errors (some elements are missing) > In case password protected invitation is used > Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2513) Room is rendered incompletely
Maxim Solodovnik created OPENMEETINGS-2513: -- Summary: Room is rendered incompletely Key: OPENMEETINGS-2513 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2513 Project: Openmeetings Issue Type: Bug Components: Invitation, Room Affects Versions: 5.0.1 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 5.1.0 Room is rendered with errors (some elements are missing) In case password protected invitation is used Dev console contains errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
