[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253891#comment-17253891 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit b022ac2b8d01c96e8b398e7f6696db6b11562be2 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b022ac2 ] Revert "[OPENMEETINGS-2239] docs clean-up" This reverts commit 2ab49c7d640e4478ac74f96b226c7a49c5caf9fb. > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 6.0.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253890#comment-17253890 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit 2ab49c7d640e4478ac74f96b226c7a49c5caf9fb in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=2ab49c7 ] [OPENMEETINGS-2239] docs clean-up > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 6.0.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: Revert "[OPENMEETINGS-2239] docs clean-up"
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new b022ac2 Revert "[OPENMEETINGS-2239] docs clean-up" b022ac2 is described below commit b022ac2b8d01c96e8b398e7f6696db6b11562be2 Author: Maxim Solodovnik AuthorDate: Wed Dec 23 12:00:42 2020 +0700 Revert "[OPENMEETINGS-2239] docs clean-up" This reverts commit 2ab49c7d640e4478ac74f96b226c7a49c5caf9fb. --- openmeetings-server/src/site/markdown/AsteriskIntegration.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/openmeetings-server/src/site/markdown/AsteriskIntegration.md b/openmeetings-server/src/site/markdown/AsteriskIntegration.md index dd1163a..c6459d4 100644 --- a/openmeetings-server/src/site/markdown/AsteriskIntegration.md +++ b/openmeetings-server/src/site/markdown/AsteriskIntegration.md @@ -206,6 +206,13 @@ Modify `/etc/asterisk/confbridge.conf` [omsip_user] type=user marked=yes +dsp_drop_silence=yes +denoise=true + +[sip_user] +type=user +end_marked=yes +wait_marked=yes music_on_hold_when_empty=yes dsp_drop_silence=yes denoise=true
[openmeetings] branch master updated: [OPENMEETINGS-2239] docs clean-up
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 2ab49c7 [OPENMEETINGS-2239] docs clean-up 2ab49c7 is described below commit 2ab49c7d640e4478ac74f96b226c7a49c5caf9fb Author: Maxim Solodovnik AuthorDate: Wed Dec 23 12:00:07 2020 +0700 [OPENMEETINGS-2239] docs clean-up --- openmeetings-server/src/site/markdown/AsteriskIntegration.md | 7 --- 1 file changed, 7 deletions(-) diff --git a/openmeetings-server/src/site/markdown/AsteriskIntegration.md b/openmeetings-server/src/site/markdown/AsteriskIntegration.md index c6459d4..dd1163a 100644 --- a/openmeetings-server/src/site/markdown/AsteriskIntegration.md +++ b/openmeetings-server/src/site/markdown/AsteriskIntegration.md @@ -206,13 +206,6 @@ Modify `/etc/asterisk/confbridge.conf` [omsip_user] type=user marked=yes -dsp_drop_silence=yes -denoise=true - -[sip_user] -type=user -end_marked=yes -wait_marked=yes music_on_hold_when_empty=yes dsp_drop_silence=yes denoise=true
[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253858#comment-17253858 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit 61382c888eb6a9be61d37bcd9d988294a08df24b in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=61382c8 ] [OPENMEETINGS-2239] code clean-up > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 6.0.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2239] code clean-up
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 61382c8 [OPENMEETINGS-2239] code clean-up
61382c8 is described below
commit 61382c888eb6a9be61d37bcd9d988294a08df24b
Author: Maxim Solodovnik
AuthorDate: Wed Dec 23 10:06:26 2020 +0700
[OPENMEETINGS-2239] code clean-up
---
.../src/main/java/org/apache/openmeetings/core/remote/KStream.java| 4
1 file changed, 4 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index 5c1f5fd..75fa04c 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -62,7 +62,6 @@ import org.kurento.client.MediaObject;
import org.kurento.client.MediaPipeline;
import org.kurento.client.MediaProfileSpecType;
import org.kurento.client.MediaType;
-import org.kurento.client.OfferOptions;
import org.kurento.client.RecorderEndpoint;
import org.kurento.client.RtpEndpoint;
import org.kurento.client.WebRtcEndpoint;
@@ -577,9 +576,6 @@ public class KStream extends AbstractStream implements
ISipCallbacks {
@Override
public void onRegisterOk() {
rtpEndpoint = getRtpEndpoint(pipeline);
- OfferOptions options = new OfferOptions();
- options.setOfferToReceiveAudio(hasAudio);
- options.setOfferToReceiveVideo(hasVideo);
if (!sipClient) {
if (hasAudio) {
outgoingMedia.connect(rtpEndpoint,
MediaType.AUDIO);
[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253857#comment-17253857 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit a1a621b8abe5b23335c1c7a471aa33597dbe59ab in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a1a621b ] [OPENMEETINGS-2239] two-way audio-only SIP seems to work > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 6.0.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2239] two-way audio-only SIP seems to work
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new a1a621b [OPENMEETINGS-2239] two-way audio-only SIP seems to work
a1a621b is described below
commit a1a621b8abe5b23335c1c7a471aa33597dbe59ab
Author: Maxim Solodovnik
AuthorDate: Wed Dec 23 10:04:25 2020 +0700
[OPENMEETINGS-2239] two-way audio-only SIP seems to work
---
.../openmeetings/core/remote/AbstractStream.java | 10 -
.../org/apache/openmeetings/core/remote/KRoom.java | 2 +-
.../apache/openmeetings/core/remote/KStream.java | 24 --
3 files changed, 15 insertions(+), 21 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
index 2dd7230..64ac599 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
@@ -48,13 +48,13 @@ public abstract class AbstractStream {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean send) {
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean recv) {
WebRtcEndpoint.Builder builder = new
WebRtcEndpoint.Builder(pipeline);
- if (send != null) {
- if (send) {
- builder.sendonly();
- } else {
+ if (recv != null) {
+ if (recv) {
builder.recvonly();
+ } else {
+ builder.sendonly();
}
}
return builder.build();
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
index bc90f9b..3de644f 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
@@ -250,7 +250,7 @@ public class KRoom {
.filter(Client::isSip)
.findAny()
.ifPresent(c -> {
- StreamDesc sd =
c.addStream(StreamType.WEBCAM, Activity.AUDIO, Activity.VIDEO); // TODO check
this
+ StreamDesc sd =
c.addStream(StreamType.WEBCAM, Activity.AUDIO);
sd.setWidth(120).setHeight(90);
c.restoreActivities(sd);
KStream stream = join(sd,
processor.getHandler());
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index ffd91e1..5c1f5fd 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -283,16 +283,14 @@ public class KStream extends AbstractStream implements
ISipCallbacks {
endpoint.addTag("uid", uid);
}
- private RtpEndpoint getRtpEndpoint(MediaPipeline pipeline, String
direction) {
- RtpEndpoint endpoint = new RtpEndpoint.Builder(pipeline)
- //.withProperties(Properties.of(direction,
Boolean.TRUE))
- .build();
+ private RtpEndpoint getRtpEndpoint(MediaPipeline pipeline) {
+ RtpEndpoint endpoint = new
RtpEndpoint.Builder(pipeline).build();
setTags(endpoint, uid);
return endpoint;
}
- private WebRtcEndpoint createEndpoint(String sid, String uid, boolean
send) {
- WebRtcEndpoint endpoint = createWebRtcEndpoint(pipeline, send);
+ private WebRtcEndpoint createEndpoint(String sid, String uid, boolean
recv) {
+ WebRtcEndpoint endpoint = createWebRtcEndpoint(pipeline, recv);
setTags(endpoint, uid);
endpoint.addIceCandidateFoundListener(evt ->
kHandler.sendClient(sid
@@ -578,13 +576,11 @@ public class KStream extends AbstractStream implements
ISipCallbacks {
@Override
public void onRegisterOk() {
- rtpEndpoint = getRtpEndpoint(pipeline, sipClient ? "recvonly" :
"sendonly");
+ rtpEndpoint = getRtpEndpoint(pipeline);
[jira] [Resolved] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2541. Resolution: Information Provided > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Final.png > > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253803#comment-17253803 ] Lawrence Moore commented on OPENMEETINGS-2541: -- Got it working! I really appreciate that you were both willing to help. Thanks so much. This is a great product. > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Final.png > > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253678#comment-17253678 ] Alvaro commented on OPENMEETINGS-2541: -- It Maxim is telling, you can see it at attached capture: !Final.png! > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Final.png > > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alvaro updated OPENMEETINGS-2541: - Attachment: Final.png > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Final.png > > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253628#comment-17253628 ] Lawrence Moore commented on OPENMEETINGS-2541: -- Thank you both for your help. [~greenes2], I tried changing it to kurento.turn.user= and restarting Tomcat, but I still didn't see the screen that was shared. [~solomax], when I shared the screen or window in one account and looked on the other computer, I didn't see a blinking icon in the upper-right. Is there something else that might be misconfigured or that I might not be interpreting properly? I really want to get this working, so thank you both for your help. > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2239) (Re-) Implementation SIP
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253543#comment-17253543 ] ASF subversion and git services commented on OPENMEETINGS-2239: --- Commit 5608cbfee7be52e625f0197f1dbad0d53f1421e9 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=5608cbf ] [OPENMEETINGS-2239] another attempt to make 'softphone -> browser' work > (Re-) Implementation SIP > > > Key: OPENMEETINGS-2239 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2239 > Project: Openmeetings > Issue Type: Wish > Components: VoIP/SIP >Affects Versions: 5.0.0-M3 >Reporter: Rene Scholz >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 6.0.0 > > > In OM5 the SIP is no longer working - please "reactivate" ist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2239] another attempt to make 'softphone -> browser' work
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 5608cbf [OPENMEETINGS-2239] another attempt to make 'softphone ->
browser' work
5608cbf is described below
commit 5608cbfee7be52e625f0197f1dbad0d53f1421e9
Author: Maxim Solodovnik
AuthorDate: Tue Dec 22 21:40:51 2020 +0700
[OPENMEETINGS-2239] another attempt to make 'softphone -> browser' work
---
.../openmeetings/core/remote/AbstractStream.java | 12 +-
.../org/apache/openmeetings/core/remote/KRoom.java | 26 ++--
.../apache/openmeetings/core/remote/KStream.java | 140 -
.../openmeetings/core/remote/KTestStream.java | 4 +-
.../openmeetings/core/sip/ISipCallbacks.java | 4 +-
.../apache/openmeetings/core/sip/SipManager.java | 47 ---
.../openmeetings/core/sip/SipStackProcessor.java | 18 +--
.../openmeetings/core/remote/BaseMockedTest.java | 3 +-
.../src/site/markdown/AsteriskIntegration.md | 1 -
.../web/admin/connection/KStreamDto.java | 40 +++---
.../apache/openmeetings/web/app/TimerService.java | 3 +-
.../org/apache/openmeetings/web/room/raw-room.js | 28 +++--
12 files changed, 181 insertions(+), 145 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
index cfc18d4..2dd7230 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
@@ -48,8 +48,16 @@ public abstract class AbstractStream {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline) {
- return new WebRtcEndpoint.Builder(pipeline).build();
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean send) {
+ WebRtcEndpoint.Builder builder = new
WebRtcEndpoint.Builder(pipeline);
+ if (send != null) {
+ if (send) {
+ builder.sendonly();
+ } else {
+ builder.recvonly();
+ }
+ }
+ return builder.build();
}
public static RecorderEndpoint createRecorderEndpoint(MediaPipeline
pipeline, String path, MediaProfileSpecType profile) {
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
index 2062c5b..bc90f9b 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
@@ -1,7 +1,4 @@
/*
- * (C) Copyright 2014 Kurento (http://kurento.org/)
- */
-/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -52,15 +49,12 @@ import org.slf4j.LoggerFactory;
import com.github.openjson.JSONObject;
/**
- * Bean object dynamically created representing a conference room on the
MediaServer
+ * Dynamically created object representing a conference room on the MediaServer
*
*/
public class KRoom {
private static final Logger log = LoggerFactory.getLogger(KRoom.class);
- /**
-* Not injected by annotation but by constructor.
-*/
private final StreamProcessor processor;
private final RecordingChunkDao chunkDao;
private final Room room;
@@ -104,8 +98,6 @@ public class KRoom {
.put("uid", stream.getUid())
.toString()
);
- //FIXME TODO check close on stop sharing
- //FIXME TODO permission can be removed, some listener might be
required
}
public boolean isRecording() {
@@ -251,8 +243,22 @@ public class KRoom {
public void updateSipCount(final long count) {
if (count != sipCount) {
- sipCount = count;
processor.getByRoom(room.getId()).forEach(stream ->
stream.addSipProcessor(count));
+ if (sipCount == 0) {
+ processor.getClientManager()
+ .streamByRoom(room.getId())
+ .filter(Client::isSip)
+ .findAny()
+ .ifPresent(c -> {
+
[jira] [Commented] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253334#comment-17253334 ] Maxim Solodovnik commented on OPENMEETINGS-2541: [~lm1425] by default screen-sharing is not "popping up" It blinks an icon in upper-right corner click it to see the app/screen :))) > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2541) Screen Sharing Does Not Work
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1725#comment-1725 ] Alvaro commented on OPENMEETINGS-2541: -- Hello Lawrence, Right now i tested the virtualBox image and works right the screen-share for me in the both sens. Please, edit and modify this line: sudo nano /opt/open510/webapps/openmeetings/WEB-INF/classes/openmeetings.properties kurento.turn.user=nobody:2Y4$7g5! ...to kurento.turn.user= ..push Ctrl+x, will ask to save, press Y and Enter to exit editor. And restart Tomcat-OpenMeetings sudo /etc/init.d/tomcat4 restart Greetings > Screen Sharing Does Not Work > > > Key: OPENMEETINGS-2541 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2541 > Project: Openmeetings > Issue Type: Bug > Components: Screen-sharing >Affects Versions: 5.1.0 >Reporter: Lawrence Moore >Assignee: Maxim Solodovnik >Priority: Major > > Hi, please forgive me if this post is not appropriate, but I could not find > help from searching. I ran the OVA Live OpenMeetings 5.1.0 on Ubuntu 18.04 > lts for Virtual Box, and the audio, video, and white boarding were working > fine, but when I attempted to screen share, open meetings said that it was > sharing my screen, but no screen share appeared to the remote user. I tried > sharing my whole screen as well as various application windows, but nothing > ever appeared/was shared. I tried this with Google Chrome and Firefox. Any > help you can offer would be much appreciated. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
