[incubator-pinot] branch master updated (157f128 -> ec0da53)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 157f128 Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest (#5049) add ec0da53 Fix logging in HadoopPinotFS (#5050) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5050: Fix logging in HadoopPinotFS
fx19880617 merged pull request #5050: Fix logging in HadoopPinotFS URL: https://github.com/apache/incubator-pinot/pull/5050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5050: Fix logging in HadoopPinotFS
codecov-io commented on issue #5050: Fix logging in HadoopPinotFS URL: https://github.com/apache/incubator-pinot/pull/5050#issuecomment-581749329 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5050?src=pr=h1) Report > Merging [#5050](https://codecov.io/gh/apache/incubator-pinot/pull/5050?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/157f128e32fb4d1283a4a984160d9f0dd91c3dab?src=pr=desc) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5050?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5050 +/- ## + Coverage 58.47% 58.55% +0.07% Complexity 12 12 Files 1182 1182 Lines 6313563135 Branches 9287 9287 + Hits 3692136970 +49 + Misses2350223444 -58 - Partials 2712 2721 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5050?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `57.31% <0%> (-19.52%)` | `0% <0%> (ø)` | | | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `54.87% <0%> (-12.2%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `45.16% <0%> (-10.76%)` | `0% <0%> (ø)` | | | [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0%> (-7.15%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `63.41% <0%> (-6.1%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `67.74% <0%> (-5.38%)` | `0% <0%> (ø)` | | | [...e/segment/index/readers/OnHeapFloatDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRmxvYXREaWN0aW9uYXJ5LmphdmE=) | `94.73% <0%> (-5.27%)` | `0% <0%> (ø)` | | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `34.21% <0%> (-5.27%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `61.9% <0%> (-4.77%)` | `0% <0%> (ø)` | | | [.../java/org/apache/pinot/spi/data/TimeFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9UaW1lRmllbGRTcGVjLmphdmE=) | `92.59% <0%> (-1.24%)` | `0% <0%> (ø)` | | | ... and [17 more](https://codecov.io/gh/apache/incubator-pinot/pull/5050/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5050?src=pr=continue). > **Legend** - [Click
[GitHub] [incubator-pinot] haibow opened a new pull request #5050: Fix logging in HadoopPinotFS
haibow opened a new pull request #5050: Fix logging in HadoopPinotFS URL: https://github.com/apache/incubator-pinot/pull/5050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (f5fe4af -> 157f128)
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f5fe4af fixing start kafka command (#5042) add 157f128 Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest (#5049) No new revisions were added by this update. Summary of changes: .../HadoopSegmentBuildPushOfflineClusterIntegrationTest.java | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia merged pull request #5049: Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest
siddharthteotia merged pull request #5049: Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest URL: https://github.com/apache/incubator-pinot/pull/5049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5049: Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest
codecov-io commented on issue #5049: Ignore Hadoop Segment Build PushOfflineClusterIntegrationTest URL: https://github.com/apache/incubator-pinot/pull/5049#issuecomment-581725886 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5049?src=pr=h1) Report > Merging [#5049](https://codecov.io/gh/apache/incubator-pinot/pull/5049?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f5fe4af026824c2096559c62dfaac3ef52542b79?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5049?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5049 +/- ## == - Coverage 39.63% 39.59% -0.04% == Files1182 1182 Lines 6313563135 Branches 9287 9287 == - Hits2502225000 -22 - Misses 3593535976 +41 + Partials 2178 2159 -19 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5049?src=pr=tree) | Coverage Δ | | |---|---|---| | [...not/broker/requesthandler/RangeMergeOptimizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvUmFuZ2VNZXJnZU9wdGltaXplci5qYXZh) | `33.82% <0%> (-36.77%)` | :arrow_down: | | [.../filter/predicate/InPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL0luUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `45.45% <0%> (-12.99%)` | :arrow_down: | | [...r/dociditerators/RangelessBitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9SYW5nZWxlc3NCaXRtYXBEb2NJZEl0ZXJhdG9yLmphdmE=) | `66.66% <0%> (-11.12%)` | :arrow_down: | | [...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `32.95% <0%> (-10.89%)` | :arrow_down: | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `43.01% <0%> (-7.53%)` | :arrow_down: | | [...e/operator/dociditerators/BitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9CaXRtYXBEb2NJZEl0ZXJhdG9yLmphdmE=) | `53.57% <0%> (-7.15%)` | :arrow_down: | | [.../reader/impl/v1/VarByteChunkSingleValueReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC92MS9WYXJCeXRlQ2h1bmtTaW5nbGVWYWx1ZVJlYWRlci5qYXZh) | `59.37% <0%> (-6.25%)` | :arrow_down: | | [...me/impl/dictionary/IntOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvSW50T25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `78.04% <0%> (-6.1%)` | :arrow_down: | | [.../core/io/reader/impl/v1/SortedIndexReaderImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC92MS9Tb3J0ZWRJbmRleFJlYWRlckltcGwuamF2YQ==) | `83.01% <0%> (-3.78%)` | :arrow_down: | | [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/5049/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5049?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ
[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5049: Ignore HadoopSegmentBuildPushOfflineClusterIntegrationTest
siddharthteotia opened a new pull request #5049: Ignore HadoopSegmentBuildPushOfflineClusterIntegrationTest URL: https://github.com/apache/incubator-pinot/pull/5049 Until https://github.com/apache/incubator-pinot/issues/5044 is fixed, disable this test to get our internal release going. As a follow-up, we can look into the test and understand why it is failing locally when doing mvn test and as part of our release jobs and why travis is succeeding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj removed a comment on issue #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of…
harleyjj removed a comment on issue #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of… URL: https://github.com/apache/incubator-pinot/pull/5048#issuecomment-581713441 PR up https://github.com/apache/incubator-pinot/pull/5048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj commented on issue #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of…
harleyjj commented on issue #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of… URL: https://github.com/apache/incubator-pinot/pull/5048#issuecomment-581713441 PR up https://github.com/apache/incubator-pinot/pull/5048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj opened a new pull request #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of…
harleyjj opened a new pull request #5048: [TE] frontend - harleyjj/alert-details - bug fix and consolidation of… URL: https://github.com/apache/incubator-pinot/pull/5048 … anomaly filtering to a method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4973: Add Avro Schema Registry Message Decoder
codecov-io edited a comment on issue #4973: Add Avro Schema Registry Message Decoder URL: https://github.com/apache/incubator-pinot/pull/4973#issuecomment-573516649 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4973?src=pr=h1) Report > Merging [#4973](https://codecov.io/gh/apache/incubator-pinot/pull/4973?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e18f1a1b8f7887bae4b1b8700f075ca27e9136fb?src=pr=desc) will **decrease** coverage by `5.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4973?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4973 +/- ## - Coverage 57.34% 51.78% -5.57% Complexity 12 12 Files 1178 1182 +4 Lines 6261963135 +516 Branches 9201 9287 +86 - Hits 3591032695-3215 - Misses2403527914+3879 + Partials 2674 2526 -148 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4973?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...inot/plugin/inputformat/avro/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby1iYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvYXZyby9BdnJvUmVjb3JkUmVhZGVyLmphdmE=) | `79.31% <ø> (ø)` | `0 <0> (?)` | | | [...pache/pinot/plugin/inputformat/avro/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby1iYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvYXZyby9BdnJvVXRpbHMuamF2YQ==) | `40.68% <ø> (ø)` | `0 <0> (?)` | | | [...t/plugin/inputformat/avro/AvroRecordExtractor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby1iYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvYXZyby9BdnJvUmVjb3JkRXh0cmFjdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../pinot/plugin/inputformat/avro/AvroSchemaUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby1iYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvYXZyby9BdnJvU2NoZW1hVXRpbC5qYXZh) | `18.51% <ø> (ø)` | `0 <0> (?)` | | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | | | [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | | | [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | | | ... and [239 more](https://codecov.io/gh/apache/incubator-pinot/pull/4973/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [incubator-pinot] narendly commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import
narendly commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import URL: https://github.com/apache/incubator-pinot/pull/5032#issuecomment-581700718 This particular change will be included in the next major version release of Helix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
fx19880617 commented on a change in pull request #4973: Add Avro Schema
Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374432405
##
File path: pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml
##
@@ -0,0 +1,134 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+pinot-input-format
+org.apache.pinot
+0.3.0-SNAPSHOT
+
+ 4.0.0
+
+ pinot-confluent-avro
+ Pinot Avro
+ https://pinot.apache.org/
+
+${basedir}/../../..
+2.0.0
+5.3.1
+
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+
+
+
+
+ confluent
+ http://packages.confluent.io/maven/
+
+
+
+
+
+ org.apache.pinot
+ pinot-avro-base
+
+
+
+ org.apache.avro
+ avro
+
+
+ org.slf4j
+ slf4j-api
+
+
+ org.mortbay.jetty
+ jetty
+
+
+
+
+
+ org.apache.kafka
+ kafka-clients
Review comment:
Is this lib used anywhere in this decoder? shall we exclude this or explicit
specify it here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
fx19880617 commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374431904 ## File path: pinot-plugins/pinot-input-format/pinot-json/pom.xml ## @@ -39,5 +39,11 @@ commons-lang commons-lang + + org.apache.pinot + pinot-spi Review comment: I thought `pinot-spi` is in `pinot-plugins` pom (https://github.com/apache/incubator-pinot/blob/master/pinot-plugins/pom.xml#L50) so you don't need to put it here. Maybe to rebase from current master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5047: Reduce docker image size
codecov-io edited a comment on issue #5047: Reduce docker image size URL: https://github.com/apache/incubator-pinot/pull/5047#issuecomment-581693976 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=h1) Report > Merging [#5047](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/89fec1e375ec480b47508e757974d1cdd65d2c68?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5047 +/- ## + Coverage 58.69% 58.78% +0.08% Complexity 12 12 Files 1182 1182 Lines 6313063135 +5 Branches 9287 9287 + Hits 3705537113 +58 + Misses2335823306 -52 + Partials 2717 2716 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JCbG9ja0RvY0lkU2V0LmphdmE=) | `84.9% <0%> (-9.44%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `66.66% <0%> (-6.46%)` | `0% <0%> (ø)` | | | [...r/filter/predicate/PredicateEvaluatorProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1ByZWRpY2F0ZUV2YWx1YXRvclByb3ZpZGVyLmphdmE=) | `52.17% <0%> (-4.35%)` | `0% <0%> (ø)` | | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `75% <0%> (-4.17%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `61.11% <0%> (-2.78%)` | `0% <0%> (ø)` | | | [...r/helix/SegmentOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50T25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `58% <0%> (-1%)` | `0% <0%> (ø)` | | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `61.95% <0%> (-0.1%)` | `0% <0%> (ø)` | | | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `91.1% <0%> (+0.3%)` | `0% <0%> (ø)` | :arrow_down: | | [...a/org/apache/pinot/core/common/DataBlockCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YUJsb2NrQ2FjaGUuamF2YQ==) | `95.41% <0%> (+0.76%)` | `0% <0%> (ø)` | :arrow_down: | | ... and [21 more](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-pinot] codecov-io commented on issue #5047: Reduce docker image size
codecov-io commented on issue #5047: Reduce docker image size URL: https://github.com/apache/incubator-pinot/pull/5047#issuecomment-581693976 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=h1) Report > Merging [#5047](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/89fec1e375ec480b47508e757974d1cdd65d2c68?src=pr=desc) will **decrease** coverage by `19.19%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5047 +/- ## - Coverage 58.69% 39.49% -19.2% Files 1182 1182 Lines 6313063135 +5 Branches 9287 9287 - Hits 3705524937 -12118 - Misses2335836050 +12692 + Partials 2717 2148 -569 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcHRpb25zQXN0Tm9kZS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...ot/core/query/scheduler/TableBasedGroupMapper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvVGFibGVCYXNlZEdyb3VwTWFwcGVyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...t/core/segment/index/readers/OnHeapDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRGljdGlvbmFyeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...t/core/query/scheduler/OutOfCapacityException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvT3V0T2ZDYXBhY2l0eUV4Y2VwdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...ot/core/query/scheduler/SchedulerQueryContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvU2NoZWR1bGVyUXVlcnlDb250ZXh0LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...pinot/common/exception/TableNotFoundException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1RhYmxlTm90Rm91bmRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...aggregation/function/SumMVAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9TdW1NVkFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...spi/utils/retry/ExponentialBackoffRetryPolicy.java](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvcmV0cnkvRXhwb25lbnRpYWxCYWNrb2ZmUmV0cnlQb2xpY3kuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | ... and [566 more](https://codecov.io/gh/apache/incubator-pinot/pull/5047/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5047?src=pr=footer). Last
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema
Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374424801
##
File path:
pinot-plugins/pinot-input-format/pinot-confluent-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/confluent/KafkaConfluentSchemaRegistryAvroMessageDecoder.java
##
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.plugin.inputformat.avro.confluent;
+
+import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient;
+import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
+import io.confluent.kafka.serializers.KafkaAvroDeserializer;
+import org.apache.avro.generic.GenericData.Record;
+import org.apache.pinot.plugin.inputformat.avro.AvroRecordExtractor;
+import org.apache.pinot.spi.data.Schema;
+import org.apache.pinot.spi.data.readers.GenericRow;
+import org.apache.pinot.spi.data.readers.RecordExtractor;
+import org.apache.pinot.spi.plugin.PluginManager;
+import org.apache.pinot.spi.stream.StreamMessageDecoder;
+
+import java.util.Arrays;
+import java.util.Map;
+
+import static com.google.common.base.Preconditions.checkState;
+import static java.util.Objects.requireNonNull;
+
+public class KafkaConfluentSchemaRegistryAvroMessageDecoder implements
StreamMessageDecoder {
Review comment:
Added in pluggablestreams.rst
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5033: Set alias name in resultTable schema names
codecov-io edited a comment on issue #5033: Set alias name in resultTable schema names URL: https://github.com/apache/incubator-pinot/pull/5033#issuecomment-580908151 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=h1) Report > Merging [#5033](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f5fe4af026824c2096559c62dfaac3ef52542b79?src=pr=desc) will **decrease** coverage by `0.18%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5033 +/- ## == - Coverage 39.63% 39.45% -0.19% == Files1182 1182 Lines 6313563168 +33 Branches 9287 9293 +6 == - Hits2502224920 -102 - Misses 3593536082 +147 + Partials 2178 2166 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=tree) | Coverage Δ | | |---|---|---| | [...not/core/query/reduce/GroupByDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeURhdGFUYWJsZVJlZHVjZXIuamF2YQ==) | `58.7% <0%> (ø)` | :arrow_up: | | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `80.09% <100%> (+0.09%)` | :arrow_up: | | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `66.13% <66.66%> (+0.02%)` | :arrow_up: | | [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `89.18% <80.95%> (-2.02%)` | :arrow_down: | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `10.25% <0%> (-70.52%)` | :arrow_down: | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | :arrow_down: | | [.../filter/predicate/InPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL0luUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `46.75% <0%> (-11.69%)` | :arrow_down: | | [...r/dociditerators/RangelessBitmapDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9SYW5nZWxlc3NCaXRtYXBEb2NJZEl0ZXJhdG9yLmphdmE=) | `66.66% <0%> (-11.12%)` | :arrow_down: | | [...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `32.95% <0%> (-10.89%)` | :arrow_down: | | [.../predicate/NotEqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL05vdEVxdWFsc1ByZWRpY2F0ZUV2YWx1YXRvckZhY3RvcnkuamF2YQ==) | `50.74% <0%> (-8.96%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema
Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374418204
##
File path: pinot-plugins/pinot-input-format/pinot-avro-base/pom.xml
##
@@ -0,0 +1,59 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+pinot-input-format
+org.apache.pinot
+0.3.0-SNAPSHOT
+
+ 4.0.0
+
+ pinot-avro-base
+ Pinot Avro Base
+ https://pinot.apache.org/
+
+${basedir}/../../..
Review comment:
FYI, I had to add it back as the property is used by the build and fails
without it (mycila license error).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5047: Reduce docker image size
fx19880617 opened a new pull request #5047: Reduce docker image size URL: https://github.com/apache/incubator-pinot/pull/5047 This will reduce docker image size from 1.3GB to 300MB This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5046: Re-design the broker routing
codecov-io edited a comment on issue #5046: Re-design the broker routing URL: https://github.com/apache/incubator-pinot/pull/5046#issuecomment-581675126 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr=h1) Report > Merging [#5046](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f5fe4af026824c2096559c62dfaac3ef52542b79?src=pr=desc) will **increase** coverage by `18.98%`. > The diff coverage is `50.97%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5046 +/- ## = + Coverage 39.63% 58.61% +18.98% - Complexity0 12 +12 = Files 1182 1195 +13 Lines 6313563752 +617 Branches 9287 9397 +110 = + Hits 2502237370+12348 + Misses3593523633-12302 - Partials 2178 2749 +571 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/pinot/broker/routing/v2/RoutingManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9Sb3V0aW5nTWFuYWdlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...oker/routing/v2/timeboundary/TimeBoundaryInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi90aW1lYm91bmRhcnkvVGltZUJvdW5kYXJ5SW5mby5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../v2/instanceselector/BalancedInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL0JhbGFuY2VkSW5zdGFuY2VTZWxlY3Rvci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...ing/v2/segmentselector/OfflineSegmentSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvT2ZmbGluZVNlZ21lbnRTZWxlY3Rvci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...instanceselector/ReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL1JlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...er/routing/v2/segmentpruner/NoOpSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50cHJ1bmVyL05vT3BTZWdtZW50UHJ1bmVyLmphdmE=) | `20% <20%> (ø)` | `0 <0> (?)` | | | [.../org/apache/pinot/common/config/RoutingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JvdXRpbmdDb25maWcuamF2YQ==) | `70% <60%> (+70%)` | `0 <0> (ø)` | :arrow_down: | | [...ing/v2/segmentselector/SegmentSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvU2VnbWVudFNlbGVjdG9yRmFjdG9yeS5qYXZh) | `60% <60%> (ø)` | `0 <0> (?)` | | | [.../v2/segmentpruner/PartitionAwareSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50cHJ1bmVyL1BhcnRpdGlvbkF3YXJlU2VnbWVudFBydW5lci5qYXZh) | `64.63% <64.63%> (ø)` | `0 <0> (?)` | | | ... and [598 more](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr=continue). > **Legend** - [Click here to learn
[incubator-pinot] branch make_alias_in_output_schema updated (27b8f5c -> 6cfbcaf)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch make_alias_in_output_schema in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 27b8f5c Address comments add 6cfbcaf Address comments No new revisions were added by this update. Summary of changes: .../org/apache/pinot/sql/parsers/CalciteSqlParser.java | 18 ++ .../pinot/core/query/reduce/BrokerReduceService.java | 16 ++-- 2 files changed, 20 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5033: Set alias name in resultTable schema names
fx19880617 commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374402254
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +188,46 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+int selectListSize = selectList.size();
+if (columnNames.length != selectListSize) {
Review comment:
will do
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5033: Set alias name in resultTable schema names
fx19880617 commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374402217
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +188,46 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+int selectListSize = selectList.size();
+if (columnNames.length != selectListSize) {
+ return;
+}
+for (int i = 0; i < selectListSize; i++) {
+ Function selectFunc = selectList.get(i).getFunctionCall();
+ if (selectFunc != null && selectFunc.getOperator()
+ .equalsIgnoreCase(SqlKind.AS.toString())) {
+String aliasName = null;
Review comment:
make sense, will update the query parsing logic there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5033: Set alias name in resultTable schema names
fx19880617 commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374401016
##
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java
##
@@ -120,6 +120,10 @@ private void convertSelectList(PinotQuery pinotQuery,
BrokerRequest brokerReques
List aggregationInfoList = null;
for (Expression expression : pinotQuery.getSelectList()) {
ExpressionType type = expression.getType();
+ if (type == ExpressionType.FUNCTION &&
expression.getFunctionCall().getOperator().equalsIgnoreCase(SqlKind.AS.toString()))
{
Review comment:
It's up to us to set it, here we compile it into a function call with
operator = 'AS', operands[0] as alias_from_expression and operands[0] as
alias_to_expression
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374397320
##
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/PinotQuery2BrokerRequestConverter.java
##
@@ -120,6 +120,10 @@ private void convertSelectList(PinotQuery pinotQuery,
BrokerRequest brokerReques
List aggregationInfoList = null;
for (Expression expression : pinotQuery.getSelectList()) {
ExpressionType type = expression.getType();
+ if (type == ExpressionType.FUNCTION &&
expression.getFunctionCall().getOperator().equalsIgnoreCase(SqlKind.AS.toString()))
{
Review comment:
What is the SQL standard for `AS` keyword? Can it work on `FUNCTION` and
`LITERAL`? If not, we should add sanity check here to block the query. The
query should always to valid when it goes to the query engine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374398649
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +188,46 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+int selectListSize = selectList.size();
+if (columnNames.length != selectListSize) {
+ return;
+}
+for (int i = 0; i < selectListSize; i++) {
+ Function selectFunc = selectList.get(i).getFunctionCall();
+ if (selectFunc != null && selectFunc.getOperator()
+ .equalsIgnoreCase(SqlKind.AS.toString())) {
+String aliasName = null;
Review comment:
We should not perform sanity check here, but when we compile the query. At
this point, alias should always exist and should always be identifier.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374397723
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +188,46 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+int selectListSize = selectList.size();
+if (columnNames.length != selectListSize) {
Review comment:
Please add some comments explaining why this can happen
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5046: Re-design the broker routing
Jackie-Jiang opened a new pull request #5046: Re-design the broker routing URL: https://github.com/apache/incubator-pinot/pull/5046 Motivation: - De-couple the partition pruning from the replica-group routing - Support real-time replica-group routing - Handle the scenario of external view not matching instance partitions - Reduce the number of ZK accesses when processing cluster changes - Support segment refresh for routing purposr (time boundary info & partitioning info) - Support routing rebuild without restarting broker Added RoutingManager as the instance level entry of the routing with the following methods: - buildRouting() - removeRouting() - refreshSegment() - routingExists() - getRoutingTable() - getTimeBoundaryInfo() Break the routing table calculation into 3 steps: - Segment selection - Segment pruning - Instance selection This PR includes the implementation and tests Will plug the new broker routing in the following PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5045: Update travis tests
codecov-io commented on issue #5045: Update travis tests URL: https://github.com/apache/incubator-pinot/pull/5045#issuecomment-581656930 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5045?src=pr=h1) Report > Merging [#5045](https://codecov.io/gh/apache/incubator-pinot/pull/5045?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f5fe4af026824c2096559c62dfaac3ef52542b79?src=pr=desc) will **increase** coverage by `12.27%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5045?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5045 +/- ## + Coverage 39.63% 51.9% +12.27% - Complexity0 12 +12 Files 11821182 Lines 63135 63135 Branches 92879287 + Hits 25022 32772 +7750 + Misses35935 27839 -8096 - Partials 21782524 +346 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5045?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...nion/events/DefaultMinionEventObserverFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0RlZmF1bHRNaW5pb25FdmVudE9ic2VydmVyRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...executor/ConvertToRawIndexTaskExecutorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...pinot/minion/exception/TaskCancelledException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhjZXB0aW9uL1Rhc2tDYW5jZWxsZWRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...t/minion/executor/TaskExecutorFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvVGFza0V4ZWN1dG9yRmFjdG9yeVJlZ2lzdHJ5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | ... and [700 more](https://codecov.io/gh/apache/incubator-pinot/pull/5045/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5045?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
[GitHub] [incubator-pinot] jackjlli edited a comment on issue #5039: Close Kafka consumer before building or downloading immutable segment
jackjlli edited a comment on issue #5039: Close Kafka consumer before building or downloading immutable segment URL: https://github.com/apache/incubator-pinot/pull/5039#issuecomment-581653792 This PR does consider the case when Helix transition to ONLINE comes. There is only one host can win the change to commit. For the winner, it's ok to close the consumer since its consumption job is done. For the rest, they will get the Helix transition to ONLINE. If it's needed to catch up with the offset, it's ok to close the consumer after they finished catching up; if it's needed to download the segment, the current consumer is also unnecessary to leave it open. Thus, it's OK to close it before building or downloading the segment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5039: Close Kafka consumer before building or downloading immutable segment
jackjlli commented on issue #5039: Close Kafka consumer before building or downloading immutable segment URL: https://github.com/apache/incubator-pinot/pull/5039#issuecomment-581653792 This PR does consider the case when Helix transition to ONLINE comes. There is only one host can win the change to commit. For the winner, it's ok to close the consumer since its consumption job is done. For the rest, after catching up the offset if needed, it's ok to close the consumer; if it's needed to download the segment, the current consumer is also unnecessary. Thus, it's OK to close it before building or downloading the segment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5043: Update travis to also include quickstart
fx19880617 commented on issue #5043: Update travis to also include quickstart URL: https://github.com/apache/incubator-pinot/pull/5043#issuecomment-581642425 > How much time does this add? We have a 1 hr limit right? Should we remove kafka-0.9 at this point? Please review new PR here: https://github.com/apache/incubator-pinot/pull/5045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5045: Update travis tests
fx19880617 opened a new pull request #5045: Update travis tests URL: https://github.com/apache/incubator-pinot/pull/5045 - Only test on default Kafka 2.0 - Change `RUN_INTEGRATION_TEST` parameter to `TEST_CATEGORY`, currently support three values: - `UNIT_TEST`: same as old behavior of doing unit test without integration test - `INTEGRATION_TEST`: same as old behavior of doing integration test - `QUICKSTART`: - build pinot distribution - start batch quickstart - send 1 count star query to check if results is same as expected loaded rows - start streaming quickstart - send 3 count star query to check if results is increasing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5033: Set alias name in resultTable schema names
codecov-io edited a comment on issue #5033: Set alias name in resultTable schema names URL: https://github.com/apache/incubator-pinot/pull/5033#issuecomment-580908151 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=h1) Report > Merging [#5033](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9b5bdbb56d8628e3e650ebb0716f76438e65bf27?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `77.14%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5033 +/- ## + Coverage 58.71% 58.77% +0.05% Complexity 12 12 Files 1181 1182 +1 Lines 6310263164 +62 Branches 9287 9295 +8 + Hits 3704937122 +73 + Misses2332923324 -5 + Partials 2724 2718 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `87.96% <100%> (+0.52%)` | `0 <0> (ø)` | :arrow_down: | | [...not/core/query/reduce/GroupByDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeURhdGFUYWJsZVJlZHVjZXIuamF2YQ==) | `87.37% <100%> (+2.04%)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `93.3% <100%> (+3.05%)` | `0 <0> (ø)` | :arrow_down: | | [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `88.23% <72.41%> (-5.18%)` | `0 <0> (ø)` | | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `23.68% <0%> (-21.06%)` | `0% <0%> (ø)` | | | [.../broker/routing/builder/InstanceConfigManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0luc3RhbmNlQ29uZmlnTWFuYWdlci5qYXZh) | `85.71% <0%> (-14.29%)` | `0% <0%> (ø)` | | | [...config/instance/InstanceAssignmentConfigUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZ1V0aWxzLmphdmE=) | `67.5% <0%> (-5%)` | `0% <0%> (ø)` | | | [...a/org/apache/pinot/common/config/TagNameUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhZ05hbWVVdGlscy5qYXZh) | `82.75% <0%> (-3.45%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `58.33% <0%> (-2.78%)` | `0% <0%> (ø)` | | | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `79.48% <0%> (-2.57%)` | `0% <0%> (ø)` | | | ... and [36 more](https://codecov.io/gh/apache/incubator-pinot/pull/5033/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5033?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-pinot] fx19880617 closed issue #5041: StartKafkaCommand does not consider command line arguments
fx19880617 closed issue #5041: StartKafkaCommand does not consider command line arguments URL: https://github.com/apache/incubator-pinot/issues/5041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import
mcvsubbu commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import URL: https://github.com/apache/incubator-pinot/pull/5032#issuecomment-581635954 Also, when you finally remove the old APIs, do a major revision bump since that is a backward-incompatible change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import
mcvsubbu commented on issue #5032: Use zookeeper-api module in Apache Helix and remove IOItec import URL: https://github.com/apache/incubator-pinot/pull/5032#issuecomment-581635599 These are incompatible changes with earlier version of Helix. You should keep the old one at least for one release _after_ introducing the new APIs, so as to allow users to migrate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5044: mvn test fails
fx19880617 commented on issue #5044: mvn test fails URL: https://github.com/apache/incubator-pinot/issues/5044#issuecomment-581628760 I feel it's better to use `getResourceAsStream` if it could read the schema file from `pinot-integration-tests` jar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch make_alias_in_output_schema updated (b9a92e9 -> 27b8f5c)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch make_alias_in_output_schema in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b9a92e9 Address comments add 27b8f5c Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b9a92e9) \ N -- N -- N refs/heads/make_alias_in_output_schema (27b8f5c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java| 6 +++--- .../java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java | 4 ++-- .../org/apache/pinot/core/query/reduce/BrokerReduceService.java | 3 ++- .../org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java | 3 ++- 4 files changed, 9 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch make_alias_in_output_schema updated (c4c49db -> b9a92e9)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch make_alias_in_output_schema in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c4c49db Adding test for cast with reduce add b9a92e9 Address comments No new revisions were added by this update. Summary of changes: .../parsers/PinotQuery2BrokerRequestConverter.java | 7 +++--- .../core/query/reduce/BrokerReduceService.java | 25 -- 2 files changed, 18 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #5044: mvn test fails
mcvsubbu commented on issue #5044: mvn test fails URL: https://github.com/apache/incubator-pinot/issues/5044#issuecomment-581623128 @fx19880617 any suggestions? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5033: Set alias name in resultTable schema names
fx19880617 commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374345898
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
+ LOGGER.error("Response schema size {} is different from number of
selection expressions {}", columnNames.length,
+ selectList.size());
+ return;
+}
+for (int i = 0; i < selectList.size(); i++) {
+ if (selectList.get(i).getFunctionCall() != null &&
selectList.get(i).getFunctionCall().getOperator()
+ .equalsIgnoreCase("AS")) {
+String aliasName = null;
+if
(selectList.get(i).getFunctionCall().getOperands().get(1).getIdentifier() !=
null) {
+ aliasName =
selectList.get(i).getFunctionCall().getOperands().get(1).getIdentifier().getName();
+}
+Literal aliasLiteral =
selectList.get(i).getFunctionCall().getOperands().get(1).getLiteral();
+if (aliasLiteral != null) {
+ if (aliasLiteral.isSetStringValue()) {
+aliasName = aliasLiteral.getStringValue();
+ }
+}
+if (aliasName != null) {
+ columnNames[i] = aliasName;
+}
Review comment:
technically it shouldn't be null, this is just for sanity check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia opened a new issue #5044: mvn test fails
siddharthteotia opened a new issue #5044: mvn test fails URL: https://github.com/apache/incubator-pinot/issues/5044 While rebasing on latest master, our release jobs failed `java.io.FileNotFoundException: file://some/path/pinot/pinot-integration-tests/target/pinot-integration-tests-0.3.0-SNAPSHOT-tests.jar!/On_Time_On_Time_Performance_2014_100k_subset_nonulls.schema (No such file or directory) 51460 at java.io.FileInputStream.open0(Native Method) 51461 at java.io.FileInputStream.open(FileInputStream.java:195) 51462 at java.io.FileInputStream.(FileInputStream.java:138) 51463 at com.fasterxml.jackson.core.JsonFactory.createParser(JsonFactory.java:766) 51464 at com.fasterxml.jackson.databind.ObjectReader.readValue(ObjectReader.java:1262) 51465 at org.apache.pinot.spi.utils.JsonUtils.fileToObject(JsonUtils.java:68) 51466 at org.apache.pinot.spi.data.Schema.fromFile(Schema.java:75) 51467 at org.apache.pinot.integration.tests.HadoopSegmentBuildPushOfflineClusterIntegrationTest.setUp(HadoopSegmentBuildPushOfflineClusterIntegrationTest.java:94)` This can also be reproduced locally by doing mvn test. It looks like getClassLoader().getResource(getSchemaFileName()) works as long as the resource is a physical file. In this case, the resource is a schema file in the test-jar produced when pinot-integration-tests module was built -- this is why there is an exclamation mark in the path at the end of jar file name. This link seems to suggest that we should be doing getResourceAsStream() in such cases when the resource file is inside a bundled jar. https://stackoverflow.com/questions/26675048/classloader-getresource-doesnt-work-in-jar-file/26675158 One another way is to probably copy this schema file in src/test/resources folder for pinot-hadoop module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5033: Set alias name in resultTable schema names
fx19880617 commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374340165
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
Review comment:
Good point, will remove this logging, and let it return directly
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (0b3a60d -> f5fe4af)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0b3a60d [TE] Add reference link to labelling anomalies in alert notifications (#5037) add f5fe4af fixing start kafka command (#5042) No new revisions were added by this update. Summary of changes: .../apache/pinot/tools/admin/command/StartKafkaCommand.java | 12 .../java/org/apache/pinot/tools/utils/KafkaStarterUtils.java | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5042: Fixing StartKafkaCommand to use comandline arguments
fx19880617 merged pull request #5042: Fixing StartKafkaCommand to use comandline arguments URL: https://github.com/apache/incubator-pinot/pull/5042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (89fec1e -> 0b3a60d)
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 89fec1e Change SqlConformanceLevel from LENIENT to BABEL (#5031) add 0b3a60d [TE] Add reference link to labelling anomalies in alert notifications (#5037) No new revisions were added by this update. Summary of changes: .../detection/yaml/translator/SubscriptionConfigTranslator.java| 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai merged pull request #5037: [TE] Add reference link to labelling anomalies in alert notifications
akshayrai merged pull request #5037: [TE] Add reference link to labelling anomalies in alert notifications URL: https://github.com/apache/incubator-pinot/pull/5037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4952: Adding new Controller APIs for retrieving and setting tag for an instance
Jackie-Jiang commented on a change in pull request #4952: Adding new Controller
APIs for retrieving and setting tag for an instance
URL: https://github.com/apache/incubator-pinot/pull/4952#discussion_r374267251
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java
##
@@ -176,4 +178,20 @@ public SuccessResponse dropInstance(
}
return new SuccessResponse("Successfully dropped instance");
}
-}
+
+ @PUT
+ @Path("/instances/{instanceName}")
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Update the specified instance", consumes =
MediaType.APPLICATION_JSON, notes = "Update specified instance with given
instance config")
+ @ApiResponses(value = {@ApiResponse(code = 200, message = "Success"),
@ApiResponse(code = 500, message = "Internal error")})
+ public SuccessResponse updateInstance(
+ @ApiParam(value = "Instance name", required = true, example =
"Server_a.b.com_2 | Broker_my.broker.com_3") @PathParam("instanceName")
String instanceName,
+ Instance instance) {
+LOGGER.info("Instance update request received for instance: {}",
instanceName);
+if (!pinotHelixResourceManager.updateInstance(instanceName,
instance).isSuccessful()) {
+ throw new ControllerApplicationException(LOGGER, "Failure to update
instance", Response.Status.INTERNAL_SERVER_ERROR);
+}
+return new SuccessResponse("Instance successfully updated");
+ }
+}
Review comment:
(nit) new line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4952: Adding new Controller APIs for retrieving and setting tag for an instance
Jackie-Jiang commented on a change in pull request #4952: Adding new Controller
APIs for retrieving and setting tag for an instance
URL: https://github.com/apache/incubator-pinot/pull/4952#discussion_r374268191
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -358,6 +358,19 @@ public synchronized PinotResourceManagerResponse
addInstance(Instance instance)
}
}
+ /**
+ * Update a given instance for the specified Instance ID
+ */
+ public synchronized PinotResourceManagerResponse updateInstance(String
instanceIdToUpdate, Instance newInstance) {
+List instances = getAllInstances();
+if (!instances.contains(instanceIdToUpdate)) {
+ return PinotResourceManagerResponse.failure("Instance " +
instanceIdToUpdate + " does not exists");
+} else {
+ _helixAdmin.setInstanceConfig(_helixClusterName, instanceIdToUpdate,
newInstance.toInstanceConfig());
Review comment:
This won't be able the change the instance host/port. In order to do that,
you need to use data accessor to set it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374259052
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
Review comment:
How about `SELECT *`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374259502
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
+ LOGGER.error("Response schema size {} is different from number of
selection expressions {}", columnNames.length,
+ selectList.size());
+ return;
+}
+for (int i = 0; i < selectList.size(); i++) {
+ if (selectList.get(i).getFunctionCall() != null &&
selectList.get(i).getFunctionCall().getOperator()
Review comment:
Cache `selectList.get(i).getFunctionCall()`, same for other places
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374259380
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
+ LOGGER.error("Response schema size {} is different from number of
selection expressions {}", columnNames.length,
+ selectList.size());
+ return;
+}
+for (int i = 0; i < selectList.size(); i++) {
Review comment:
Cache `selectList.size()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5033: Set alias name in resultTable schema names
Jackie-Jiang commented on a change in pull request #5033: Set alias name in
resultTable schema names
URL: https://github.com/apache/incubator-pinot/pull/5033#discussion_r374261484
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -178,7 +185,45 @@ public BrokerResponseNative
reduceOnDataTable(BrokerRequest brokerRequest,
}
DataTableReducer dataTableReducer =
ResultReducerFactory.getResultReducer(brokerRequest);
-dataTableReducer.reduceAndSetResults(tableName, cachedDataSchema,
dataTableMap, brokerResponseNative, brokerMetrics);
+dataTableReducer
+.reduceAndSetResults(tableName, cachedDataSchema, dataTableMap,
brokerResponseNative, brokerMetrics);
+updateAliasToSchemaName(brokerRequest, brokerResponseNative);
return brokerResponseNative;
}
-}
+
+ private static void updateAliasToSchemaName(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative) {
+if (brokerRequest.getPinotQuery() == null) {
+ return;
+}
+QueryOptions queryOptions = new
QueryOptions(brokerRequest.getQueryOptions());
+if (!queryOptions.isResponseFormatSQL()) {
+ return;
+}
+DataSchema dataSchema =
brokerResponseNative.getResultTable().getDataSchema();
+List selectList =
brokerRequest.getPinotQuery().getSelectList();
+String[] columnNames = dataSchema.getColumnNames();
+if (columnNames.length != selectList.size()) {
+ LOGGER.error("Response schema size {} is different from number of
selection expressions {}", columnNames.length,
+ selectList.size());
+ return;
+}
+for (int i = 0; i < selectList.size(); i++) {
+ if (selectList.get(i).getFunctionCall() != null &&
selectList.get(i).getFunctionCall().getOperator()
+ .equalsIgnoreCase("AS")) {
+String aliasName = null;
+if
(selectList.get(i).getFunctionCall().getOperands().get(1).getIdentifier() !=
null) {
+ aliasName =
selectList.get(i).getFunctionCall().getOperands().get(1).getIdentifier().getName();
+}
+Literal aliasLiteral =
selectList.get(i).getFunctionCall().getOperands().get(1).getLiteral();
+if (aliasLiteral != null) {
+ if (aliasLiteral.isSetStringValue()) {
+aliasName = aliasLiteral.getStringValue();
+ }
+}
+if (aliasName != null) {
+ columnNames[i] = aliasName;
+}
Review comment:
Can you simplify the logic here and add some comments? Can `aliasName` be
`null` when `AS` keyword is found?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance
mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-581546277 Please update the commit message. Also, i am not sure where (or even how) to document the fact that if multiple updates happen, not all of them will be taken. For now, we can add that as a part of the commit message at least, I suppose. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema
Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374193754
##
File path: pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml
##
@@ -0,0 +1,134 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+pinot-input-format
+org.apache.pinot
+0.3.0-SNAPSHOT
+
+ 4.0.0
+
+ pinot-confluent-avro
+ Pinot Avro
+ https://pinot.apache.org/
+
+${basedir}/../../..
+2.0.0
+5.3.1
+
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+
+
+
+
+ confluent
+ http://packages.confluent.io/maven/
+
+
+
+
+
+ org.apache.pinot
+ pinot-avro-base
+
+
+
+ org.apache.avro
+ avro
+
+
+ org.slf4j
+ slf4j-api
+
+
+ org.mortbay.jetty
+ jetty
+
+
+
+
+
+ org.apache.kafka
+ kafka-clients
Review comment:
The schema registry client has a dependency and a dependency convergence
error is thrown without an explicit dependency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374193200 ## File path: pinot-plugins/pinot-input-format/pinot-parquet/pom.xml ## @@ -55,5 +65,11 @@ + + org.apache.pinot + pinot-spi Review comment: Same as above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374193070 ## File path: pinot-plugins/pinot-input-format/pinot-json/pom.xml ## @@ -39,5 +39,11 @@ commons-lang commons-lang + + org.apache.pinot + pinot-spi Review comment: The build failed with a dependency error without it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374192924 ## File path: pinot-plugins/pinot-input-format/pinot-csv/pom.xml ## @@ -43,5 +43,11 @@ commons-lang commons-lang + Review comment: The build failed with a dependency error without it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #4973: Add Avro Schema Registry Message Decoder
elonazoulay commented on a change in pull request #4973: Add Avro Schema
Registry Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r374190597
##
File path: pinot-plugins/pinot-input-format/pinot-avro-base/pom.xml
##
@@ -0,0 +1,59 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+pinot-input-format
+org.apache.pinot
+0.3.0-SNAPSHOT
+
+ 4.0.0
+
+ pinot-avro-base
+ Pinot Avro Base
+ https://pinot.apache.org/
+
+${basedir}/../../..
Review comment:
Thanks @fx19880617! Removed. I noticed that this property is set in all the
plugins under pinot-input-format. Does it make sense to remove those as well in
a separate commit?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5043: Update travis to also include quickstart
fx19880617 opened a new pull request #5043: Update travis to also include quickstart URL: https://github.com/apache/incubator-pinot/pull/5043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 closed pull request #5043: Update travis to also include quickstart
fx19880617 closed pull request #5043: Update travis to also include quickstart URL: https://github.com/apache/incubator-pinot/pull/5043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5042: Fixing StartKafkaCommand to use comandline arguments
fx19880617 opened a new pull request #5042: Fixing StartKafkaCommand to use comandline arguments URL: https://github.com/apache/incubator-pinot/pull/5042 Per issue https://github.com/apache/incubator-pinot/issues/5041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] 01/01: fixing start kafka command
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch ISSUE-5041
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 093ed70edef3e914f2ae26a28c88335d7e6eacfa
Author: Xiang Fu
AuthorDate: Mon Feb 3 01:26:53 2020 -0800
fixing start kafka command
---
.../apache/pinot/tools/admin/command/StartKafkaCommand.java | 12
.../java/org/apache/pinot/tools/utils/KafkaStarterUtils.java | 2 +-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartKafkaCommand.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartKafkaCommand.java
index e342c73..548daa6 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartKafkaCommand.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartKafkaCommand.java
@@ -20,6 +20,7 @@ package org.apache.pinot.tools.admin.command;
import java.io.File;
import java.io.IOException;
+import java.util.Properties;
import org.apache.pinot.spi.stream.StreamDataProvider;
import org.apache.pinot.spi.stream.StreamDataServerStartable;
import org.apache.pinot.tools.Command;
@@ -45,7 +46,7 @@ public class StartKafkaCommand extends
AbstractBaseAdminCommand implements Comma
private int _brokerId = KafkaStarterUtils.DEFAULT_BROKER_ID;
@Option(name = "-zkAddress", required = false, metaVar = "", usage =
"Address of Zookeeper.")
- private String _zkAddress = "localhost:2181";
+ private String _zkAddress = KafkaStarterUtils.DEFAULT_ZK_STR;
private StreamDataServerStartable _kafkaStarter;
@Override
@@ -71,15 +72,18 @@ public class StartKafkaCommand extends
AbstractBaseAdminCommand implements Comma
@Override
public boolean execute()
throws IOException {
+Properties kafkaConfiguration =
KafkaStarterUtils.getDefaultKafkaConfiguration();
+kafkaConfiguration.put(KafkaStarterUtils.BROKER_ID, _brokerId);
+kafkaConfiguration.put(KafkaStarterUtils.PORT, _port);
+kafkaConfiguration.put(KafkaStarterUtils.ZOOKEEPER_CONNECT, _zkAddress);
try {
- _kafkaStarter =
StreamDataProvider.getServerDataStartable(KafkaStarterUtils.KAFKA_SERVER_STARTABLE_CLASS_NAME,
KafkaStarterUtils.getDefaultKafkaConfiguration());
+ _kafkaStarter = StreamDataProvider
+
.getServerDataStartable(KafkaStarterUtils.KAFKA_SERVER_STARTABLE_CLASS_NAME,
kafkaConfiguration);
} catch (Exception e) {
throw new RuntimeException("Failed to start " +
KafkaStarterUtils.KAFKA_SERVER_STARTABLE_CLASS_NAME, e);
}
_kafkaStarter.start();
-
LOGGER.info("Start kafka at localhost:" + _port + " in thread " +
Thread.currentThread().getName());
-
savePID(System.getProperty("java.io.tmpdir") + File.separator +
".kafka.pid");
return true;
}
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/utils/KafkaStarterUtils.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/utils/KafkaStarterUtils.java
index 724ab87..0f7eb4e 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/utils/KafkaStarterUtils.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/utils/KafkaStarterUtils.java
@@ -36,7 +36,7 @@ public class KafkaStarterUtils {
public static final String PORT = "port";
public static final String BROKER_ID = "broker.id";
- private static final String ZOOKEEPER_CONNECT = "zookeeper.connect";
+ public static final String ZOOKEEPER_CONNECT = "zookeeper.connect";
private static final String LOG_DIRS = "log.dirs";
public static final String KAFKA_SERVER_STARTABLE_CLASS_NAME =
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch ISSUE-5041 created (now 093ed70)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch ISSUE-5041 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 093ed70 fixing start kafka command This branch includes the following new commits: new 093ed70 fixing start kafka command The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
