[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5070: Support non-literal expressions for right-side operand in predicate comparison
Jackie-Jiang commented on issue #5070: Support non-literal expressions for right-side operand in predicate comparison URL: https://github.com/apache/incubator-pinot/pull/5070#issuecomment-592245251 @fx19880617 Not related to this PR but these 2 queries does not work and make the test flaky: `SELECT COUNT(WeatherDelay) FROM mytable WHERE ArrDelay > CarrierDelay LIMIT 26` `SELECT COUNT(WeatherDelay) FROM mytable WHERE ArrDelay - CarrierDelay > 0 LIMIT 26` I think there are some bugs in the ExpressionFilterOperator This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig
fx19880617 merged pull request #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig URL: https://github.com/apache/incubator-pinot/pull/5073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (16e6fbf -> 9abf0a4)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 16e6fbf [Cleanup] Remove the old broker routing (#5101) add 9abf0a4 Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig (#5073) No new revisions were added by this update. Summary of changes: .../pinot/controller/api/resources/Constants.java | 1 + .../api/resources/PinotClusterConfigs.java | 121 + .../pinot/tools/admin/PinotAdministrator.java | 2 + .../admin/command/AbstractBaseAdminCommand.java| 24 +++- .../admin/command/OperateClusterConfigCommand.java | 149 + 5 files changed, 291 insertions(+), 6 deletions(-) create mode 100644 pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java create mode 100644 pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/OperateClusterConfigCommand.java - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4958: Decouple segment selection/pruning from routing table builder
Jackie-Jiang commented on issue #4958: Decouple segment selection/pruning from routing table builder URL: https://github.com/apache/incubator-pinot/issues/4958#issuecomment-592240066 Clean up the old implementation: #5101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang closed issue #4958: Decouple segment selection/pruning from routing table builder
Jackie-Jiang closed issue #4958: Decouple segment selection/pruning from routing table builder URL: https://github.com/apache/incubator-pinot/issues/4958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (9f33abe -> 16e6fbf)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 9f33abe [TE] Add additional safeguard around jira description length
(#5100)
add 16e6fbf [Cleanup] Remove the old broker routing (#5101)
No new revisions were added by this update.
Summary of changes:
.../broker/api/resources/PinotBrokerDebug.java | 4 +-
.../broker/api/resources/PinotBrokerRouting.java | 2 +-
.../broker/broker/BrokerAdminApiApplication.java | 2 +-
...okerResourceOnlineOfflineStateModelFactory.java | 2 +-
.../BrokerUserDefineMessageHandlerFactory.java | 2 +-
.../broker/broker/helix/HelixBrokerStarter.java| 2 +-
.../requesthandler/BaseBrokerRequestHandler.java | 4 +-
.../SingleConnectionBrokerRequestHandler.java | 2 +-
.../routing/HelixExternalViewBasedRouting.java | 625 -
.../HelixExternalViewBasedTimeBoundaryService.java | 148 -
.../broker/routing/{v2 => }/RoutingManager.java| 18 +-
.../apache/pinot/broker/routing/RoutingTable.java | 56 --
.../broker/routing/RoutingTableBuilderFactory.java | 143 -
.../broker/routing/RoutingTableLookupRequest.java | 79 ---
.../pinot/broker/routing/TimeBoundaryService.java | 65 ---
.../builder/BalancedRandomRoutingTableBuilder.java | 62 --
.../BasePartitionAwareRoutingTableBuilder.java | 160 --
.../routing/builder/BaseRoutingTableBuilder.java | 220
.../builder/DefaultOfflineRoutingTableBuilder.java | 139 -
.../DefaultRealtimeRoutingTableBuilder.java| 119
.../builder/GeneratorBasedRoutingTableBuilder.java | 293 --
.../HighLevelConsumerBasedRoutingTableBuilder.java | 95
.../routing/builder/InstanceConfigManager.java | 81 ---
.../builder/LargeClusterRoutingTableBuilder.java | 63 ---
.../LowLevelConsumerRoutingTableBuilder.java | 139 -
.../builder/LowLevelRoutingTableBuilderUtil.java | 81 ---
.../PartitionAwareOfflineRoutingTableBuilder.java | 209 ---
.../PartitionAwareRealtimeRoutingTableBuilder.java | 145 -
.../routing/builder/RoutingTableBuilder.java | 64 ---
.../instanceselector/BalancedInstanceSelector.java | 2 +-
.../instanceselector/BaseInstanceSelector.java | 2 +-
.../instanceselector/InstanceSelector.java | 2 +-
.../instanceselector/InstanceSelectorFactory.java | 2 +-
.../ReplicaGroupInstanceSelector.java | 2 +-
.../segmentpruner/PartitionSegmentPruner.java | 2 +-
.../{v2 => }/segmentpruner/SegmentPruner.java | 2 +-
.../segmentpruner/SegmentPrunerFactory.java| 2 +-
.../segmentselector/OfflineSegmentSelector.java| 2 +-
.../segmentselector/RealtimeSegmentSelector.java | 2 +-
.../{v2 => }/segmentselector/SegmentSelector.java | 2 +-
.../segmentselector/SegmentSelectorFactory.java| 2 +-
.../routing/selector/MergedSegmentSelector.java| 95
.../broker/routing/selector/SegmentSelector.java | 49 --
.../routing/selector/SegmentSelectorProvider.java | 47 --
.../{v2 => }/timeboundary/TimeBoundaryInfo.java| 2 +-
.../{v2 => }/timeboundary/TimeBoundaryManager.java | 2 +-
.../broker/broker/HelixBrokerStarterTest.java | 4 +-
...ixExternalViewBasedTimeBoundaryServiceTest.java | 167 --
.../broker/routing/RandomRoutingTableTest.java | 107
.../pinot/broker/routing/RoutingTableTest.java | 303 --
.../BalancedRandomRoutingTableBuilderTest.java | 126 -
.../HighLevelConsumerRoutingTableBuilderTest.java | 119
.../LargeClusterRoutingTableBuilderTest.java | 275 -
.../LowLevelConsumerRoutingTableBuilderTest.java | 271 -
...rtitionAwareOfflineRoutingTableBuilderTest.java | 404 -
...titionAwareRealtimeRoutingTableBuilderTest.java | 374
.../instanceselector/InstanceSelectorTest.java | 6 +-
.../{v2 => }/segmentpruner/SegmentPrunerTest.java | 2 +-
.../segmentselector/SegmentSelectorTest.java | 6 +-
.../selector/MergedSegmentSelectorTest.java| 149 -
.../timeboundary/TimeBoundaryManagerTest.java | 2 +-
.../apache/pinot/common/config/RoutingConfig.java | 13 +-
62 files changed, 44 insertions(+), 5527 deletions(-)
delete mode 100644
pinot-broker/src/main/java/org/apache/pinot/broker/routing/HelixExternalViewBasedRouting.java
delete mode 100644
pinot-broker/src/main/java/org/apache/pinot/broker/routing/HelixExternalViewBasedTimeBoundaryService.java
rename pinot-broker/src/main/java/org/apache/pinot/broker/routing/{v2 =>
}/RoutingManager.java (97%)
delete mode 100644
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTable.java
delete mode 100644
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTableBuilderFactory.java
delete mode 100644
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5101: [Cleanup] Remove the old broker routing
Jackie-Jiang merged pull request #5101: [Cleanup] Remove the old broker routing URL: https://github.com/apache/incubator-pinot/pull/5101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (b880c47 -> 9f33abe)
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b880c47 Fix the duplicate broker refresh message (#5102) add 9f33abe [TE] Add additional safeguard around jira description length (#5100) No new revisions were added by this update. Summary of changes: .../detection/alert/scheme/DetectionJiraAlerter.java| 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai merged pull request #5100: [TE] Add additional safeguard around jira description length
akshayrai merged pull request #5100: [TE] Add additional safeguard around jira description length URL: https://github.com/apache/incubator-pinot/pull/5100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5101: [Cleanup] Remove the old broker routing
codecov-io commented on issue #5101: [Cleanup] Remove the old broker routing URL: https://github.com/apache/incubator-pinot/pull/5101#issuecomment-592235747 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5101?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@754532e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5101?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5101 +/- ## = Coverage ? 57.72% Complexity? 12 = Files ? 1174 Lines ?62051 Branches ? 9112 = Hits ?35819 Misses?23598 Partials ? 2634 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5101?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...outing/segmentselector/SegmentSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50c2VsZWN0b3IvU2VnbWVudFNlbGVjdG9yRmFjdG9yeS5qYXZh) | `60% <ø> (ø)` | `0 <0> (?)` | | | [...outing/segmentselector/OfflineSegmentSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50c2VsZWN0b3IvT2ZmbGluZVNlZ21lbnRTZWxlY3Rvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...ing/instanceselector/BalancedInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0JhbGFuY2VkSW5zdGFuY2VTZWxlY3Rvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | | | [...instanceselector/ReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL1JlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `71.97% <ø> (ø)` | `0 <0> (?)` | | | [...pinot/broker/broker/BrokerAdminApiApplication.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlckFkbWluQXBpQXBwbGljYXRpb24uamF2YQ==) | `94.11% <ø> (ø)` | `0 <0> (?)` | | | [...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=) | `76.66% <ø> (ø)` | `0 <0> (?)` | | | [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `81.48% <ø> (ø)` | `0 <0> (?)` | | | [...r/helix/BrokerUserDefineMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVNZXNzYWdlSGFuZGxlckZhY3RvcnkuamF2YQ==) | `80.95% <ø> (ø)` | `0 <0> (?)` | | | [...oker/routing/timeboundary/TimeBoundaryManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy90aW1lYm91bmRhcnkvVGltZUJvdW5kYXJ5TWFuYWdlci5qYXZh) | `87.5% <ø> (ø)` | `0 <0> (?)` | | | ... and [11 more](https://codecov.io/gh/apache/incubator-pinot/pull/5101/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5101?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[incubator-pinot] branch master updated (754532e9 -> b880c47)
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 754532e9 [TE] Change the jetty version to be compatible of loading the certificate for HTTPS (#5099) add b880c47 Fix the duplicate broker refresh message (#5102) No new revisions were added by this update. Summary of changes: .../apache/pinot/controller/helix/core/PinotHelixResourceManager.java| 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #5102: Fix the duplicate broker refresh message
jackjlli merged pull request #5102: Fix the duplicate broker refresh message URL: https://github.com/apache/incubator-pinot/pull/5102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5101: [Cleanup] Remove the old broker routing
Jackie-Jiang opened a new pull request #5101: [Cleanup] Remove the old broker routing URL: https://github.com/apache/incubator-pinot/pull/5101 NOTE: MergedSegmentSelector is also removed. We will re-implement it and integrate it into the new SegmentSelectors This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig
codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig URL: https://github.com/apache/incubator-pinot/pull/5073#issuecomment-586694558 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=h1) Report > Merging [#5073](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3126d56f7b4688f03bf1afdd9d13ff991376a762?src=pr=desc) will **decrease** coverage by `0.77%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5073 +/- ## - Coverage 58.46% 57.68% -0.78% Complexity 12 12 Files 1209 1196 -13 Lines 6460563195-1410 Branches 9508 9325 -183 - Hits 3776936452-1317 + Misses2406724026 -41 + Partials 2769 2717 -52 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/pinot/controller/api/resources/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0NvbnN0YW50cy5qYXZh) | `21.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ols/admin/command/OperateClusterConfigCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvT3BlcmF0ZUNsdXN0ZXJDb25maWdDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../controller/api/resources/PinotClusterConfigs.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90Q2x1c3RlckNvbmZpZ3MuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../tools/admin/command/AbstractBaseAdminCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWJzdHJhY3RCYXNlQWRtaW5Db21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0% <0%> (-96%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-53.85%)` | `0% <0%> (ø)` | | | [...che/pinot/core/startree/v2/StarTreeV2Metadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9TdGFyVHJlZVYyTWV0YWRhdGEuamF2YQ==) | `62.5% <0%> (-29.17%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | | | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `39.02% <0%> (-21.96%)` | `0% <0%> (ø)` | | | ... and [128 more](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=continue). > **Legend** - [Click here
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig
codecov-io edited a comment on issue #5073: Adding PinotClusterConfig APIs in controller and corresponding Pinot Admin SubCommand: OperateClusterConfig URL: https://github.com/apache/incubator-pinot/pull/5073#issuecomment-586694558 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=h1) Report > Merging [#5073](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3126d56f7b4688f03bf1afdd9d13ff991376a762?src=pr=desc) will **decrease** coverage by `0.69%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5073 +/- ## === - Coverage 58.46% 57.76% -0.7% Complexity 12 12 === Files 1209 1196 -13 Lines 6460563195 -1410 Branches 9508 9325-183 === - Hits 3776936505 -1264 + Misses2406723976 -91 + Partials 2769 2714 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/pinot/controller/api/resources/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0NvbnN0YW50cy5qYXZh) | `21.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ols/admin/command/OperateClusterConfigCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvT3BlcmF0ZUNsdXN0ZXJDb25maWdDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../controller/api/resources/PinotClusterConfigs.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90Q2x1c3RlckNvbmZpZ3MuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../tools/admin/command/AbstractBaseAdminCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWJzdHJhY3RCYXNlQWRtaW5Db21tYW5kLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0% <0%> (-96%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-53.85%)` | `0% <0%> (ø)` | | | [...che/pinot/core/startree/v2/StarTreeV2Metadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9TdGFyVHJlZVYyTWV0YWRhdGEuamF2YQ==) | `62.5% <0%> (-29.17%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | | | [...gregation/function/FastHLLAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GYXN0SExMQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `55.55% <0%> (-8.97%)` | `0% <0%> (ø)` | | | ... and [123 more](https://codecov.io/gh/apache/incubator-pinot/pull/5073/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5073?src=pr=continue). > **Legend** - [Click here to learn
[incubator-pinot] branch adding_cluster_config_ops updated (cd37ee1 -> 4dba420)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_cluster_config_ops in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard cd37ee1 Address comments add 4dba420 Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (cd37ee1) \ N -- N -- N refs/heads/adding_cluster_config_ops (4dba420) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../apache/pinot/tools/admin/command/OperateClusterConfigCommand.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch adding_cluster_config_ops updated (b3374fc -> cd37ee1)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_cluster_config_ops in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b3374fc Address comments add cd37ee1 Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b3374fc) \ N -- N -- N refs/heads/adding_cluster_config_ops (cd37ee1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../apache/pinot/tools/admin/command/OperateClusterConfigCommand.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch dependabot/maven/thirdeye/jackson.version-2.10.2 updated (0e0342e -> 318d84a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/thirdeye/jackson.version-2.10.2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0e0342e Bump jackson.version from 2.9.9 to 2.10.2 in /thirdeye add fdfb97e [TE][subscription] Dimension Recipient Alerter should be agnostic to individual errors; Emit metrics to track emails and jiras (#5091) add 3126d56 Support non-literal expressions for right-side operand in predicate comparison (#5070) add 3c91a6d Remove the support of the old Star-Tree (#5086) add 00fd911 [TE][subscription] destroy jira connections after use (#5097) add 754532e9 [TE] Change the jetty version to be compatible of loading the certificate for HTTPS (#5099) add 318d84a Bump jackson.version from 2.9.9 to 2.10.2 in /thirdeye This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0e0342e) \ N -- N -- N refs/heads/dependabot/maven/thirdeye/jackson.version-2.10.2 (318d84a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../apache/pinot/common/config/IndexingConfig.java | 10 - .../SegmentsValidationAndRetentionConfig.java | 10 - .../pinot/common/data/StarTreeIndexSpec.java | 128 --- .../common/metadata/segment/SegmentZKMetadata.java | 22 +- .../pinot/common/segment/SegmentMetadata.java | 19 - .../pinot/common/segment/StarTreeMetadata.java | 73 -- .../pinot/common/utils/request/RequestUtils.java | 29 +- .../apache/pinot/sql/parsers/CalciteSqlParser.java | 100 +- .../org/apache/pinot/startree/hll/HllConfig.java | 131 --- .../apache/pinot/startree/hll/HllConstants.java| 24 - .../apache/pinot/startree/hll/HllSizeUtils.java| 60 -- .../pinot/common/config/IndexingConfigTest.java| 48 - .../pinot/common/config/TableConfigTest.java | 127 +-- .../apache/pinot/common/data/FieldSpecTest.java| 19 - .../org/apache/pinot/common/data/SchemaTest.java | 56 +- .../common/metadata/SegmentZKMetadataTest.java |6 +- .../pinot/sql/parsers/CalciteSqlCompilerTest.java | 95 +- .../realtime/PinotLLCRealtimeSegmentManager.java |2 +- .../SegmentSizeBasedFlushThresholdUpdater.java |2 +- .../helix/core/util/ZKMetadataUtils.java |2 +- .../validation/OfflineSegmentIntervalChecker.java |2 +- .../RealtimeSegmentValidationManager.java |6 +- .../PinotLLCRealtimeSegmentManagerTest.java|4 +- .../segment/FlushThresholdUpdaterTest.java |4 +- .../controller/utils/SegmentMetadataMockUtils.java |4 +- .../core/data/manager/BaseTableDataManager.java|4 +- .../realtime/HLRealtimeSegmentDataManager.java |2 +- .../realtime/LLRealtimeSegmentDataManager.java | 10 +- .../data/readers/PinotSegmentRecordReader.java |2 +- .../generator/SegmentGeneratorConfig.java | 67 +- .../immutable/ImmutableSegmentLoader.java |6 +- .../indexsegment/mutable/MutableSegmentImpl.java | 40 +- .../pinot/core/minion/BackfillDateTimeColumn.java |7 - .../apache/pinot/core/minion/SegmentConverter.java | 10 +- .../apache/pinot/core/minion/SegmentPurger.java| 16 +- .../core/operator/CombineGroupByOperator.java |2 +- .../operator/CombineGroupByOrderByOperator.java|4 +- .../pinot/core/operator/CombineOperator.java |2 +- .../pinot/core/operator/ExecutionStatistics.java | 14 +- .../operator/blocks/IntermediateResultsBlock.java | 43 +- .../operator/filter/ExpressionFilterOperator.java |2 +- .../operator/query/AggregationGroupByOperator.java | 14 +- .../query/AggregationGroupByOrderByOperator.java | 14 +- .../core/operator/query/AggregationOperator.java | 12 +- .../query/DictionaryBasedAggregationOperator.java | 14 +- .../operator/query/EmptySelectionOperator.java |2 +- .../query/MetadataBasedAggregationOperator.java| 10 +- .../core/operator/query/SelectionOnlyOperator.java |5 +- .../operator/query/SelectionOrderByOperator.java |9 +- .../core/plan/AggregationFunctionInitializer.java | 38 - .../plan/AggregationGroupByOrderByPlanNode.java|7 +- .../core/plan/AggregationGroupByPlanNode.java |6 +- .../pinot/core/plan/AggregationPlanNode.java |6 +-
[GitHub] [incubator-pinot] akshayrai opened a new pull request #5100: [TE] Add additional safeguard around jira description length
akshayrai opened a new pull request #5100: [TE] Add additional safeguard around jira description length URL: https://github.com/apache/incubator-pinot/pull/5100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch adding_cluster_config_ops updated (fc5b785 -> b3374fc)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_cluster_config_ops in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fc5b785 Address comments add b3374fc Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fc5b785) \ N -- N -- N refs/heads/adding_cluster_config_ops (b3374fc) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../apache/pinot/tools/admin/command/OperateClusterConfigCommand.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch adding_cluster_config_ops updated (6d6a3e6 -> fc5b785)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_cluster_config_ops in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6d6a3e6 Address comments add fc5b785 Address comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (6d6a3e6) \ N -- N -- N refs/heads/adding_cluster_config_ops (fc5b785) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java | 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh opened a new pull request #5099: [TE] Change the jetty version to be compatible of loading the certificate for HTTPS
jihaozh opened a new pull request #5099: [TE] Change the jetty version to be compatible of loading the certificate for HTTPS URL: https://github.com/apache/incubator-pinot/pull/5099 PR5095 upgraded the jetty version. However, it cannot loads the certificate correctly. This PR changes it to a version that's compatible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai merged pull request #5097: [TE][subscription] destroy jira connections after use
akshayrai merged pull request #5097: [TE][subscription] destroy jira connections after use URL: https://github.com/apache/incubator-pinot/pull/5097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated: [TE][subscription] destroy jira connections after use (#5097)
This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 00fd911 [TE][subscription] destroy jira connections after use (#5097)
00fd911 is described below
commit 00fd911936f10420c612cbe7200b9b6a89ddcafa
Author: Akshay Rai
AuthorDate: Thu Feb 27 10:54:57 2020 -0800
[TE][subscription] destroy jira connections after use (#5097)
---
.../thirdeye/detection/alert/DetectionAlertTaskRunner.java | 1 +
.../thirdeye/detection/alert/scheme/DetectionAlertScheme.java | 4
.../thirdeye/detection/alert/scheme/DetectionJiraAlerter.java | 6 ++
.../thirdeye/notification/commons/ThirdEyeJiraClient.java | 10 +-
4 files changed, 20 insertions(+), 1 deletion(-)
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
index 7291756..cfa27a1 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
@@ -112,6 +112,7 @@ public class DetectionAlertTaskRunner implements TaskRunner
{
detAlertTaskFactory.loadAlertSchemes(alertConfig,
taskContext.getThirdEyeAnomalyConfiguration(), result);
for (DetectionAlertScheme alertScheme : alertSchemes) {
alertScheme.run();
+alertScheme.destroy();
}
updateAlertConfigWatermarks(result, alertConfig);
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
index 8aaf6d7..c89fc2b 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
@@ -54,6 +54,10 @@ public abstract class DetectionAlertScheme {
public abstract void run() throws Exception;
+ public void destroy() {
+// do nothing
+ }
+
/**
* Plug the appropriate template based on configuration.
*/
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionJiraAlerter.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionJiraAlerter.java
index 49f978c..df807df 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionJiraAlerter.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionJiraAlerter.java
@@ -21,6 +21,7 @@ package org.apache.pinot.thirdeye.detection.alert.scheme;
import com.atlassian.jira.rest.client.api.domain.Issue;
import com.google.common.base.Preconditions;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -171,6 +172,11 @@ public class DetectionJiraAlerter extends
DetectionAlertScheme {
}
@Override
+ public void destroy() {
+this.jiraClient.close();
+ }
+
+ @Override
public void run() throws Exception {
Preconditions.checkNotNull(result);
if (result.getAllAnomalies().size() == 0) {
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/ThirdEyeJiraClient.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/ThirdEyeJiraClient.java
index 2820905..8ce9097 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/ThirdEyeJiraClient.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/ThirdEyeJiraClient.java
@@ -35,6 +35,7 @@ import
com.atlassian.jira.rest.client.api.domain.input.TransitionInput;
import
com.atlassian.jira.rest.client.internal.async.AsynchronousJiraRestClientFactory;
import com.google.common.base.Joiner;
import java.io.File;
+import java.io.IOException;
import java.net.URI;
import java.util.ArrayList;
import java.util.Collections;
@@ -60,7 +61,6 @@ public class ThirdEyeJiraClient {
private static final String JIRA_REOPEN_TRANSITION = "Reopen";
public static final String PROP_ISSUE_TYPE = "issuetype";
public static final String PROP_PROJECT = "project";
- public static final String PROP_SUMMARY = "summary";
public static final String PROP_ASSIGNEE = "assignee";
public static final String PROP_MERGE_GAP = "mergeGap";
public static final String PROP_LABELS = "labels";
@@ -249,4 +249,12 @@
[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5097: [TE][subscription] destroy jira connections after use
jihaozh commented on a change in pull request #5097: [TE][subscription] destroy
jira connections after use
URL: https://github.com/apache/incubator-pinot/pull/5097#discussion_r385292732
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionAlertScheme.java
##
@@ -54,6 +54,8 @@ public DetectionAlertScheme(DetectionAlertConfigDTO
subsConfig, DetectionAlertFi
public abstract void run() throws Exception;
+ public abstract void destroy() throws Exception;
Review comment:
Can we put a default implementation here so that not all subclasses need to
implement this interface?
Define it like this here, and only overrides it in Jira alerter. So that no
changes is needed for other alerters.
```
public void destroy() {
// do nothing
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
