[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6067: Always quote literal when converting from PinotQuery to BrokerRequest
Jackie-Jiang commented on pull request #6067: URL: https://github.com/apache/incubator-pinot/pull/6067#issuecomment-700440542 Closing this PR because seems this will cause more inconsistency between SQL and PQL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6067: Always quote literal when converting from PinotQuery to BrokerRequest
Jackie-Jiang commented on pull request #6067: URL: https://github.com/apache/incubator-pinot/pull/6067#issuecomment-700373385 @siddharthteotia Good question! This legacy behavior only applies to aggregation function, and the query example you give is transform function, where PQL has the same behavior as SQL. The affected functions are the aggregation function with literal parameters, such as `idSet`, `distinctCountThetaSketch`. There are only a few of them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
