codecov-io commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-509297732 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=h1) Report > Merging [#4368](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/33f583b2a84a8a22143a26c9cc6b80dc2a81563c?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `63.41%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4368 +/- ## ============================================ + Coverage 55.7% 55.77% +0.06% Complexity 20 20 ============================================ Files 1066 1067 +1 Lines 55403 55564 +161 Branches 7894 7911 +17 ============================================ + Hits 30865 30991 +126 - Misses 22150 22183 +33 - Partials 2388 2390 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/pinot/core/minion/SegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vU2VnbWVudENvbnZlcnRlci5qYXZh) | `72.28% <100%> (+1.77%)` | `0 <0> (ø)` | :arrow_down: | | [...indexsegment/generator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRHZW5lcmF0b3JDb25maWcuamF2YQ==) | `51.93% <40%> (-0.08%)` | `0 <0> (ø)` | | | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `83.9% <60%> (-2.79%)` | `0 <0> (ø)` | | | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `66.5% <0%> (-4%)` | `0% <0%> (ø)` | | | [...segment/creator/impl/SegmentDictionaryCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50RGljdGlvbmFyeUNyZWF0b3IuamF2YQ==) | `79.87% <0%> (-3.91%)` | `0% <0%> (ø)` | | | [...gment/index/readers/ImmutableDictionaryReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvSW1tdXRhYmxlRGljdGlvbmFyeVJlYWRlci5qYXZh) | `90.47% <0%> (-3.79%)` | `0% <0%> (ø)` | | | [...inot/core/realtime/impl/RealtimeSegmentConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1JlYWx0aW1lU2VnbWVudENvbmZpZy5qYXZh) | `95.16% <0%> (-1.4%)` | `0% <0%> (ø)` | | | [.../core/segment/index/loader/IndexLoadingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9JbmRleExvYWRpbmdDb25maWcuamF2YQ==) | `68.88% <0%> (-0.53%)` | `0% <0%> (ø)` | | | [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50Q29udmVydGVyLmphdmE=) | `35.82% <0%> (-0.12%)` | `0% <0%> (ø)` | | | ... and [20 more](https://codecov.io/gh/apache/incubator-pinot/pull/4368/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=footer). Last update [33f583b...7ed7b10](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
