[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6165: Add table level lock for segment upload

2020-10-23 Thread GitBox 


codecov-io edited a comment on pull request #6165:
URL: https://github.com/apache/incubator-pinot/pull/6165#issuecomment-713177186


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=h1) 
Report
   > Merging 
[#6165](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc)
 will **decrease** coverage by `2.39%`.
   > The diff coverage is `38.09%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/6165/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6165  +/-   ##
   ==
   - Coverage   66.44%   64.05%   -2.40% 
   ==
 Files1075 1237 +162 
 Lines   5477358482+3709 
 Branches 8168 8655 +487 
   ==
   + Hits3639637462+1066 
   - Misses  1570018284+2584 
   - Partials 2677 2736  +59 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #unittests | `64.05% <38.09%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=)
 | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
   | 
[...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==)
 | `71.42% <ø> (-28.58%)` | :arrow_down: |
   | 
[.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=)
 | `33.96% <0.00%> (-32.71%)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=)
 | `53.33% <0.00%> (-3.81%)` | :arrow_down: |
   | 
[.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==)
 | `35.55% <0.00%> (-13.29%)` | :arrow_down: |
   | 
[...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0pzb25Bc3luY0h0dHBQaW5vdENsaWVudFRyYW5zcG9ydC5qYXZh)
 | `10.90% <0.00%> (-51.10%)` | :arrow_down: |
   | 
[.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=)
 | `0.00% <0.00%> (-34.29%)` | :arrow_down: |
   | 
[...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh)
 | `73.80% <ø> (+0.63%)` | :arrow_up: |
   | 
[.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=)
 | `90.27% <ø> (+5.55%)` | :arrow_up: |
   | 
[...pinot/common/function/AggregationFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vQWdncmVnYXRpb25GdW5jdGlvblR5cGUuamF2YQ==)
 | `98.27% <ø> (-1.73%)` | :arrow_down: |
   | ... and [1075 
more](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6165: Add table level lock for segment upload

2020-10-22 Thread GitBox 


codecov-io edited a comment on pull request #6165:
URL: https://github.com/apache/incubator-pinot/pull/6165#issuecomment-713177186


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=h1) 
Report
   > Merging 
[#6165](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc)
 will **increase** coverage by `6.64%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/6165/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6165  +/-   ##
   ==
   + Coverage   66.44%   73.08%   +6.64% 
   ==
 Files1075 1237 +162 
 Lines   5477358482+3709 
 Branches 8168 8654 +486 
   ==
   + Hits3639642744+6348 
   + Misses  1570012925-2775 
   - Partials 2677 2813 +136 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integration | `46.19% <49.14%> (?)` | |
   | #unittests | `64.05% <38.09%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==)
 | `100.00% <ø> (ø)` | |
   | 
[.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=)
 | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=)
 | `53.33% <0.00%> (-3.81%)` | :arrow_down: |
   | 
[.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==)
 | `44.44% <0.00%> (-4.40%)` | :arrow_down: |
   | 
[.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=)
 | `24.00% <0.00%> (-10.29%)` | :arrow_down: |
   | 
[...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh)
 | `78.57% <ø> (+5.40%)` | :arrow_up: |
   | 
[.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=)
 | `90.27% <ø> (+5.55%)` | :arrow_up: |
   | 
[...pinot/common/function/AggregationFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vQWdncmVnYXRpb25GdW5jdGlvblR5cGUuamF2YQ==)
 | `98.27% <ø> (-1.73%)` | :arrow_down: |
   | 
[.../pinot/common/function/DateTimePatternHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRGF0ZVRpbWVQYXR0ZXJuSGFuZGxlci5qYXZh)
 | `83.33% <ø> (ø)` | |
   | 
[...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==)
 | `88.88% <ø> (+44.44%)` | :arrow_up: |
   | ... and [1010 
more](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6165: Add table level lock for segment upload

2020-10-22 Thread GitBox 


codecov-io edited a comment on pull request #6165:
URL: https://github.com/apache/incubator-pinot/pull/6165#issuecomment-713177186


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=h1) 
Report
   > Merging 
[#6165](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc)
 will **decrease** coverage by `2.39%`.
   > The diff coverage is `38.09%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/6165/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6165  +/-   ##
   ==
   - Coverage   66.44%   64.05%   -2.40% 
   ==
 Files1075 1237 +162 
 Lines   5477358482+3709 
 Branches 8168 8654 +486 
   ==
   + Hits3639637458+1062 
   - Misses  1570018289+2589 
   - Partials 2677 2735  +58 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #unittests | `64.05% <38.09%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=)
 | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
   | 
[...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==)
 | `71.42% <ø> (-28.58%)` | :arrow_down: |
   | 
[.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=)
 | `33.96% <0.00%> (-32.71%)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=)
 | `53.33% <0.00%> (-3.81%)` | :arrow_down: |
   | 
[.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==)
 | `35.55% <0.00%> (-13.29%)` | :arrow_down: |
   | 
[...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0pzb25Bc3luY0h0dHBQaW5vdENsaWVudFRyYW5zcG9ydC5qYXZh)
 | `10.90% <0.00%> (-51.10%)` | :arrow_down: |
   | 
[.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=)
 | `0.00% <0.00%> (-34.29%)` | :arrow_down: |
   | 
[...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh)
 | `73.80% <ø> (+0.63%)` | :arrow_up: |
   | 
[.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=)
 | `90.27% <ø> (+5.55%)` | :arrow_up: |
   | 
[...pinot/common/function/AggregationFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vQWdncmVnYXRpb25GdW5jdGlvblR5cGUuamF2YQ==)
 | `98.27% <ø> (-1.73%)` | :arrow_down: |
   | ... and [1076 
more](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6165: Add table level lock for segment upload

2020-10-20 Thread GitBox 


codecov-io edited a comment on pull request #6165:
URL: https://github.com/apache/incubator-pinot/pull/6165#issuecomment-713177186


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=h1) 
Report
   > Merging 
[#6165](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc)
 will **increase** coverage by `6.45%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/6165/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6165  +/-   ##
   ==
   + Coverage   66.44%   72.90%   +6.45% 
   ==
 Files1075 1232 +157 
 Lines   5477358233+3460 
 Branches 8168 8624 +456 
   ==
   + Hits3639642454+6058 
   + Misses  1570012967-2733 
   - Partials 2677 2812 +135 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integration | `45.16% <49.14%> (?)` | |
   | #unittests | `64.02% <38.09%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==)
 | `100.00% <ø> (ø)` | |
   | 
[.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=)
 | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=)
 | `53.33% <0.00%> (-3.81%)` | :arrow_down: |
   | 
[.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==)
 | `44.44% <0.00%> (-4.40%)` | :arrow_down: |
   | 
[.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=)
 | `24.00% <0.00%> (-10.29%)` | :arrow_down: |
   | 
[...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh)
 | `78.57% <ø> (+5.40%)` | :arrow_up: |
   | 
[.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=)
 | `90.27% <ø> (+5.55%)` | :arrow_up: |
   | 
[...pinot/common/function/AggregationFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vQWdncmVnYXRpb25GdW5jdGlvblR5cGUuamF2YQ==)
 | `98.27% <ø> (-1.73%)` | :arrow_down: |
   | 
[.../pinot/common/function/DateTimePatternHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRGF0ZVRpbWVQYXR0ZXJuSGFuZGxlci5qYXZh)
 | `83.33% <ø> (ø)` | |
   | 
[...ot/common/function/FunctionDefinitionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25EZWZpbml0aW9uUmVnaXN0cnkuamF2YQ==)
 | `88.88% <ø> (+44.44%)` | :arrow_up: |
   | ... and [992 
more](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6165: Add table level lock for segment upload

2020-10-20 Thread GitBox 


codecov-io edited a comment on pull request #6165:
URL: https://github.com/apache/incubator-pinot/pull/6165#issuecomment-713177186


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=h1) 
Report
   > Merging 
[#6165](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc)
 will **decrease** coverage by `21.28%`.
   > The diff coverage is `49.14%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/6165/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#6165   +/-   ##
   ===
   - Coverage   66.44%   45.16%   -21.29% 
   ===
 Files1075 1232  +157 
 Lines   5477358233 +3460 
 Branches 8168 8624  +456 
   ===
   - Hits3639626301-10095 
   - Misses  1570029764+14064 
   + Partials 2677 2168  -509 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integration | `45.16% <49.14%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==)
 | `100.00% <ø> (ø)` | |
   | 
[.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=)
 | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
   | 
[...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[...che/pinot/broker/queryquota/MaxHitRateTracker.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9NYXhIaXRSYXRlVHJhY2tlci5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ache/pinot/broker/queryquota/QueryQuotaEntity.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9RdWVyeVF1b3RhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=)
 | `26.66% <0.00%> (-30.48%)` | :arrow_down: |
   | 
[.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==)
 | `22.22% <0.00%> (-26.62%)` | :arrow_down: |
   | 
[.../org/apache/pinot/client/ResultTableResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L1Jlc3VsdFRhYmxlUmVzdWx0U2V0LmphdmE=)
 | `24.00% <0.00%> (-10.29%)` | :arrow_down: |
   | 
[...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh)
 | `64.28% <ø> (-8.89%)` | :arrow_down: |
   | 
[.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=)
 | `90.27% <ø> (+5.55%)` | :arrow_up: |
   | ... and [1213 
more](https://codecov.io/gh/apache/incubator-pinot/pull/6165/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6165?src=pr=continue).
   > **Legend** -