[GitHub] [incubator-pinot] jackjlli commented on pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-12 Thread GitBox 


jackjlli commented on pull request #6005:
URL: https://github.com/apache/incubator-pinot/pull/6005#issuecomment-691313748


   > Could you add a test such that it fails with the original code, and passes 
with the old code?
   
   Test added.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli commented on pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-12 Thread GitBox 


jackjlli commented on pull request #6005:
URL: https://github.com/apache/incubator-pinot/pull/6005#issuecomment-691313748







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli commented on pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-12 Thread GitBox 


jackjlli commented on pull request #6005:
URL: https://github.com/apache/incubator-pinot/pull/6005#issuecomment-691313748


   > Could you add a test such that it fails with the original code, and passes 
with the old code?
   
   Test added.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

[GitHub] [incubator-pinot] jackjlli commented on pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-11 Thread GitBox 


jackjlli commented on pull request #6005:
URL: https://github.com/apache/incubator-pinot/pull/6005#issuecomment-691313748


   > Could you add a test such that it fails with the original code, and passes 
with the old code?
   
   Test added.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org