[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4975: Adding pinot-batch-ingestion-spark module
kishoreg commented on a change in pull request #4975: Adding pinot-batch-ingestion-spark module URL: https://github.com/apache/incubator-pinot/pull/4975#discussion_r366034956 ## File path: pinot-distribution/pinot-assembly.xml ## @@ -114,6 +114,7 @@ **/pinot-stream-ingestion/pinot-stream-ingestion/** **/pinot-stream-ingestion/pinot-kafka-*/** **/pinot-batch-ingestion/pinot-batch-ingestion/** + **/pinot-batch-ingestion/pinot-batch-ingestion-common/** **/pinot-batch-ingestion/pinot-ingestion-common/** Review comment: please check the path here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4975: Adding pinot-batch-ingestion-spark module
kishoreg commented on a change in pull request #4975: Adding
pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975#discussion_r366035100
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/pom.xml
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+pinot-batch-ingestion
+org.apache.pinot
+0.3.0-SNAPSHOT
+..
+
+ 4.0.0
+ pinot-batch-ingestion-common
+ Pinot Batch Ingestion Common
+ https://pinot.apache.org/
+
+${basedir}/../../..
+
+
+
+ org.apache.pinot
+ pinot-spi
+ ${project.version}
+
+
Review comment:
this should be provided?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
