snleee commented on a change in pull request #4533: [Instance Assignment]
De-couple assignment strategy from SegmentAssignment
URL: https://github.com/apache/incubator-pinot/pull/4533#discussion_r314898313
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignment.java
##########
@@ -23,37 +23,42 @@
import org.apache.commons.configuration.Configuration;
import org.apache.helix.HelixManager;
import org.apache.pinot.common.config.TableConfig;
+import org.apache.pinot.common.utils.InstancePartitionsType;
+import org.apache.pinot.controller.helix.core.assignment.InstancePartitions;
/**
- * Strategy to assign segment to instances or rebalance all segments in a
table.
+ * Interface for segment assignment and table rebalancing.
*/
-public interface SegmentAssignmentStrategy {
+public interface SegmentAssignment {
Review comment:
Can you add the `TODO` document for adding support for custom segment
assignment strategy?
I agree that it's not the right time to add the interface since we need the
proper design for it. I can see multiple ways to achieve custom segment
assignment (e.g. cost model - currently the cost is based on # of segments, we
can extend this to add resources like storage factor into the cost).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
