[GitHub] [incubator-pinot] xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence
xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence URL: https://github.com/apache/incubator-pinot/pull/3992#discussion_r267483867 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/stats/RealtimeColumnStatistics.java ## @@ -139,6 +140,11 @@ public boolean isSorted() { return false; } +// Values in BYTES are not comparable +if(_block.getMetadata().getDataType().getStoredType() == DataType.BYTES) { Review comment: Updated with ByteArray comparison. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence
xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence URL: https://github.com/apache/incubator-pinot/pull/3992#discussion_r267483867 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/stats/RealtimeColumnStatistics.java ## @@ -139,6 +140,11 @@ public boolean isSorted() { return false; } +// Values in BYTES are not comparable +if(_block.getMetadata().getDataType().getStoredType() == DataType.BYTES) { Review comment: Updated with ByteArray comparison. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence
xiangfu1 commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence URL: https://github.com/apache/incubator-pinot/pull/3992#discussion_r267483867 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/stats/RealtimeColumnStatistics.java ## @@ -139,6 +140,11 @@ public boolean isSorted() { return false; } +// Values in BYTES are not comparable +if(_block.getMetadata().getDataType().getStoredType() == DataType.BYTES) { Review comment: Update with ByteArray comparison. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org