This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push: new d8f9140 [TE] Include a detection description field to describe the alert (#3798) d8f9140 is described below commit d8f91404c826cdeb23cf20612102646060a3418e Author: Akshay Rai <akshayra...@gmail.com> AuthorDate: Thu Feb 7 15:36:04 2019 -0800 [TE] Include a detection description field to describe the alert (#3798) --- .../pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java | 9 +++++++++ .../pinot/thirdeye/detection/DetectionMigrationResource.java | 1 + .../org/apache/pinot/thirdeye/detection/DetectionResource.java | 1 + .../thirdeye/detection/LegacyAnomalyFunctionTranslator.java | 1 + .../pinot/thirdeye/detection/algorithm/DimensionWrapper.java | 1 + .../thirdeye/detection/algorithm/LegacyAlertFilterWrapper.java | 1 + .../thirdeye/detection/algorithm/LegacyDimensionWrapper.java | 1 + .../pinot/thirdeye/detection/algorithm/LegacyMergeWrapper.java | 1 + .../apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java | 1 + .../thirdeye/detection/algorithm/RuleBasedFilterWrapper.java | 1 + .../detection/algorithm/stage/AnomalyFilterStageWrapper.java | 1 + .../thirdeye/detection/algorithm/stage/GrouperStageWrapper.java | 1 + .../thirdeye/detection/finetune/GridSearchTuningAlgorithm.java | 1 + .../pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java | 1 + .../thirdeye/detection/yaml/YamlDetectionConfigTranslator.java | 3 +++ .../thirdeye/detection/DetectionPipelineTaskRunnerTest.java | 2 ++ .../detection/yaml/YamlDetectionConfigTranslatorTest.java | 2 ++ .../pinot/thirdeye/detection/migrated-detection-config-1.json | 3 ++- .../pinot/thirdeye/detection/migrated-detection-config-2.json | 3 ++- .../apache/pinot/thirdeye/detection/yaml/pipeline-config-1.yaml | 1 + .../apache/pinot/thirdeye/detection/yaml/pipeline-config-2.yaml | 1 + 21 files changed, 35 insertions(+), 2 deletions(-) diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java index 2a4e6c3..6294405 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DetectionConfigBean.java @@ -35,6 +35,7 @@ import java.util.Objects; public class DetectionConfigBean extends AbstractBean { String cron; String name; + String description; long lastTimestamp; Map<String, Object> properties; boolean active; @@ -65,6 +66,14 @@ public class DetectionConfigBean extends AbstractBean { this.name = name; } + public String getDescription() { + return description; + } + + public void setDescription(String description) { + this.description = description; + } + public String getCron() { return cron; } diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java index 80698d2..811e594 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java @@ -117,6 +117,7 @@ public class DetectionMigrationResource { private Map<String, Object> translateAnomalyFunctionToYaml(AnomalyFunctionDTO anomalyFunctionDTO) { Map<String, Object> yamlConfigs = new LinkedHashMap<>(); yamlConfigs.put("detectionName", anomalyFunctionDTO.getFunctionName()); + yamlConfigs.put("description", "<Please edit and provide a description for this alert>"); yamlConfigs.put("metric", anomalyFunctionDTO.getMetric()); yamlConfigs.put("dataset", anomalyFunctionDTO.getCollection()); yamlConfigs.put("pipelineType", "Composite"); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java index e7247eb..7bc737b 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java @@ -191,6 +191,7 @@ public class DetectionResource { DetectionConfigDTO config = new DetectionConfigDTO(); config.setId(Long.MAX_VALUE); config.setName("preview"); + config.setDescription("previewing the detection"); config.setProperties(MapUtils.getMap(properties, "properties")); config.setComponentSpecs(MapUtils.getMap(properties, "componentSpecs")); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java index 7b2905e..0735406 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java @@ -86,6 +86,7 @@ public class LegacyAnomalyFunctionTranslator { DetectionConfigDTO config = new DetectionConfigDTO(); config.setName(anomalyFunctionDTO.getFunctionName()); + config.setDescription("<Please edit and provide a description for this alert>"); config.setCron(anomalyFunctionDTO.getCron()); config.setProperties(properties); config.setActive(false); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java index d328574..09c36d4 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java @@ -235,6 +235,7 @@ public class DimensionWrapper extends DetectionPipeline { DetectionConfigDTO nestedConfig = new DetectionConfigDTO(); nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); nestedConfig.setComponents(this.config.getComponents()); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyAlertFilterWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyAlertFilterWrapper.java index cebd2e2..075dd2a 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyAlertFilterWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyAlertFilterWrapper.java @@ -109,6 +109,7 @@ public class LegacyAlertFilterWrapper extends DetectionPipeline { } nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime - this.alertFilterLookBack, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyDimensionWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyDimensionWrapper.java index e8a17ad..2a08cfd 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyDimensionWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyDimensionWrapper.java @@ -96,6 +96,7 @@ public class LegacyDimensionWrapper extends DimensionWrapper { DetectionConfigDTO nestedConfig = new DetectionConfigDTO(); nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyMergeWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyMergeWrapper.java index 16f58a3..3f87d59 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyMergeWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/LegacyMergeWrapper.java @@ -157,6 +157,7 @@ public class LegacyMergeWrapper extends DetectionPipeline { } nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java index 21a1874..474b3c6 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/MergeWrapper.java @@ -110,6 +110,7 @@ public class MergeWrapper extends DetectionPipeline { nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); nestedConfig.setComponents(this.config.getComponents()); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/RuleBasedFilterWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/RuleBasedFilterWrapper.java index 363c837..093449b 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/RuleBasedFilterWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/RuleBasedFilterWrapper.java @@ -62,6 +62,7 @@ public abstract class RuleBasedFilterWrapper extends DetectionPipeline { Preconditions.checkArgument(properties.containsKey(PROP_CLASS_NAME), "Nested missing " + PROP_CLASS_NAME); nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/AnomalyFilterStageWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/AnomalyFilterStageWrapper.java index 82717b8..80eb54c 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/AnomalyFilterStageWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/AnomalyFilterStageWrapper.java @@ -76,6 +76,7 @@ public class AnomalyFilterStageWrapper extends DetectionPipeline { Preconditions.checkArgument(properties.containsKey(PROP_CLASS_NAME), "Nested missing " + PROP_CLASS_NAME); nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); if (this.metricUrn != null){ properties.put(PROP_METRIC_URN, this.metricUrn); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/GrouperStageWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/GrouperStageWrapper.java index 6f48189..9163639 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/GrouperStageWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/stage/GrouperStageWrapper.java @@ -69,6 +69,7 @@ public class GrouperStageWrapper extends DetectionPipeline { Preconditions.checkArgument(properties.containsKey(PROP_CLASS_NAME), "Nested missing " + PROP_CLASS_NAME); nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(properties); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/finetune/GridSearchTuningAlgorithm.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/finetune/GridSearchTuningAlgorithm.java index 55e5083..30d67ac 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/finetune/GridSearchTuningAlgorithm.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/finetune/GridSearchTuningAlgorithm.java @@ -143,6 +143,7 @@ public class GridSearchTuningAlgorithm implements TuningAlgorithm { DetectionConfigDTO config = new DetectionConfigDTO(); config.setId(Long.MAX_VALUE); config.setName("preview"); + config.setDescription("previewing the detection"); config.setProperties(properties); return config; diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java index 7096d48..86c773c 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java @@ -84,6 +84,7 @@ public class AnomalyFilterWrapper extends DetectionPipeline { } nestedConfig.setId(this.config.getId()); nestedConfig.setName(this.config.getName()); + nestedConfig.setDescription(this.config.getDescription()); nestedConfig.setProperties(nestedProp); nestedConfig.setComponents(this.config.getComponents()); DetectionPipeline pipeline = this.provider.loadPipeline(nestedConfig, this.startTime, this.endTime); diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslator.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslator.java index fe2aee3..69ca5c8 100644 --- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslator.java +++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslator.java @@ -38,6 +38,7 @@ import org.yaml.snakeyaml.Yaml; public abstract class YamlDetectionConfigTranslator { protected static final Logger LOG = LoggerFactory.getLogger(YamlDetectionConfigTranslator.class); private static final String PROP_NAME = "detectionName"; + private static final String PROP_DESC_NAME = "description"; private static final String PROP_ACTIVE = "active"; protected Map<String, Object> yamlConfig; @@ -79,6 +80,7 @@ public abstract class YamlDetectionConfigTranslator { DetectionConfigDTO config = new DetectionConfigDTO(); config.setName(MapUtils.getString(yamlConfig, PROP_NAME)); + config.setDescription(MapUtils.getString(yamlConfig, PROP_DESC_NAME)); config.setLastTimestamp(System.currentTimeMillis()); config.setActive(true); YamlTranslationResult translationResult = translateYaml(); @@ -107,5 +109,6 @@ public abstract class YamlDetectionConfigTranslator { */ protected void validateYAML(Map<String, Object> yamlConfig) { Preconditions.checkArgument(yamlConfig.containsKey(PROP_NAME), "Property missing " + PROP_NAME); + Preconditions.checkArgument(yamlConfig.containsKey(PROP_DESC_NAME), "Property missing " + PROP_DESC_NAME); } } diff --git a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunnerTest.java b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunnerTest.java index f419dd8..c520983 100644 --- a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunnerTest.java +++ b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunnerTest.java @@ -74,6 +74,7 @@ public class DetectionPipelineTaskRunnerTest { DetectionConfigDTO detector = new DetectionConfigDTO(); detector.setProperties(this.properties); detector.setName("myName"); + detector.setDescription("myDescription"); detector.setCron("myCron"); this.detectorId = this.detectionDAO.save(detector); @@ -106,6 +107,7 @@ public class DetectionPipelineTaskRunnerTest { Assert.assertEquals(this.runs.get(0).getStartTime(), 1250); Assert.assertEquals(this.runs.get(0).getEndTime(), 1500); Assert.assertEquals(this.runs.get(0).getConfig().getName(), "myName"); + Assert.assertEquals(this.runs.get(0).getConfig().getDescription(), "myDescription"); Assert.assertEquals(this.runs.get(0).getConfig().getProperties().get("className"), "myClassName"); Assert.assertEquals(this.runs.get(0).getConfig().getCron(), "myCron"); } diff --git a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslatorTest.java b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslatorTest.java index 0e780ff..ebdfd21 100644 --- a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslatorTest.java +++ b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslatorTest.java @@ -25,6 +25,7 @@ public class YamlDetectionConfigTranslatorTest { Map<String, Object> yamlConfigs = new HashMap<>(); yamlConfigs.put("detectionName", "testPipeline"); + yamlConfigs.put("description", "myTestPipeline"); MetricConfigDTO metricConfigDTO = new MetricConfigDTO(); metricConfigDTO.setName("a_daily_metric"); metricConfigDTO.setDataset("a_test_dataset"); @@ -34,6 +35,7 @@ public class YamlDetectionConfigTranslatorTest { YamlDetectionConfigTranslator translator = new MockYamlDetectionConfigTranslator(yamlConfigs, new MockDataProvider()); DetectionConfigDTO detectionConfigDTO = translator.generateDetectionConfig(); Assert.assertEquals(detectionConfigDTO.getName(), "testPipeline"); + Assert.assertEquals(detectionConfigDTO.getDescription(), "myTestPipeline"); Assert.assertEquals(detectionConfigDTO.getCron(), "0 0 14 * * ? *"); Assert.assertEquals(detectionConfigDTO.getProperties().get("yamlConfigs"), yamlConfigs); } diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json index bb112e5..3f39305 100644 --- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json +++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json @@ -1,6 +1,7 @@ { "cron":"0 0 14 * * ? *", "name":"test_function", + "description":"<Please edit and provide a description for this alert>", "properties":{ "className":"org.apache.pinot.thirdeye.detection.wrapper.ChildKeepingMergeWrapper", "nested":[ @@ -29,7 +30,7 @@ ] }, "active":true, - "yaml":"detectionName: test_function\nmetric: test_metric\ndataset: test_collection\npipelineType: Composite\ndimensionExploration:\n dimensions:\n - platform\nfilters:\n platform:\n - desktop\n - tablet\nrules:\n- detection:\n - name: detection_rule1\n type: PERCENTAGE_RULE\n params:\n percentageChange: 0.05\n pattern: DOWN\n", + "yaml":"detectionName: test_function\ndescription: <Please edit and provide a description for this alert>\nmetric: test_metric\ndataset: test_collection\npipelineType: Composite\ndimensionExploration:\n dimensions:\n - platform\nfilters:\n platform:\n - desktop\n - tablet\nrules:\n- detection:\n - name: detection_rule1\n type: PERCENTAGE_RULE\n params:\n percentageChange: 0.05\n pattern: DOWN\n", "componentSpecs":{ "detection_rule1:PERCENTAGE_RULE":{ "percentageChange":0.05, diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json index e5b0054..e08ffdb 100644 --- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json +++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json @@ -1,6 +1,7 @@ { "cron":"0 0 14 * * ? *", "name":"test_function", + "description":"<Please edit and provide a description for this alert>", "lastTimestamp":1547772179159, "properties":{ "className":"org.apache.pinot.thirdeye.detection.wrapper.ChildKeepingMergeWrapper", @@ -26,7 +27,7 @@ ] }, "active":true, - "yaml":"detectionName: test_function\nmetric: test_metric\ndataset: test_collection\npipelineType: Composite\nfilters:\n score_challenge_type:\n - Captcha Challenge\nrules:\n- detection:\n - name: detection_rule1\n type: THRESHOLD\n params:\n min: '0.70'\n", + "yaml":"detectionName: test_function\ndescription: <Please edit and provide a description for this alert>\nmetric: test_metric\ndataset: test_collection\npipelineType: Composite\nfilters:\n score_challenge_type:\n - Captcha Challenge\nrules:\n- detection:\n - name: detection_rule1\n type: THRESHOLD\n params:\n min: '0.70'\n", "componentSpecs":{ "detection_rule1:THRESHOLD":{ "min":"0.70", diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-1.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-1.yaml index 911d0d9..1aba72f 100644 --- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-1.yaml +++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-1.yaml @@ -1,4 +1,5 @@ detectionName: testPipeline +description: My test pipeline metric: test_metric dataset: test_dataset pipelineType: Composite diff --git a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-2.yaml b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-2.yaml index 323325e..2d48e72 100644 --- a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-2.yaml +++ b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/yaml/pipeline-config-2.yaml @@ -1,4 +1,5 @@ detectionName: testPipeline +description: My test pipeline metric: test_metric dataset: test_dataset pipelineType: Composite --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org