[incubator-pinot] branch master updated: [TE] add anomaly detection as a service - new table for storing ad-hoc data (#5866)

[akshayrai09]

This is an automated email from the ASF dual-hosted git repository.

akshayrai09 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new c425b0f  [TE] add anomaly detection as a service - new table for 
storing ad-hoc data (#5866)
c425b0f is described below

commit c425b0feabf674bd5e8de3b034c126bb8ffdd9fc
Author: Yanwen(Jason) Lin <34975811+jasonyanw...@users.noreply.github.com>
AuthorDate: Tue Aug 25 15:04:00 2020 -0400

    [TE] add anomaly detection as a service - new table for storing ad-hoc data 
(#5866)
    
    Phase 2 is separated into two parts. This PR is for the 1st part. The main 
change is that a new table is created for storing online ad-hoc data. The PR 
for Phase 1 can be found in #5769.
    
    Here are some other minor changes:
    * Remove the cleanExistingState method in the AnomalyDetectionResource. 
This is not necessary because each request is distinct now and the monitor job 
will periodically clean them (dataset/metric/detection configs, ad-hoc data).
    * Remove the suffix appended to metric as the metric name is allowed to be 
duplicate.
    
    The 2nd part of phase 2 is about creating a new endpoint to provide 
registering and CRUD operations on ad-hoc data.
---
 .../apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java   | 2 ++
 .../pinot/thirdeye/api/detection/AnomalyDetectionResourceTest.java      | 1 +
 2 files changed, 3 insertions(+)

diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
index 16b476c..ac3d863 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
@@ -184,6 +184,8 @@ public class AnomalyDetectionResource {
 
     // TODO: refactor code to resolve request configurations in one place 
(e.g. default/customized config names)
 
+    // TODO: refactor code to resolve request configurations in one place 
(e.g. default/customized config names)
+
     try {
       Preconditions.checkNotNull(start, "Detection start time is not 
provided");
       Preconditions.checkNotNull(end, "Detection end time is not provided");
diff --git 
a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResourceTest.java
 
b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResourceTest.java
index d6bfd98..7b52d98 100644
--- 
a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResourceTest.java
+++ 
b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResourceTest.java
@@ -48,6 +48,7 @@ import java.io.IOException;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
+
 public class AnomalyDetectionResourceTest {
   private static final String DEFAULT_DETECTION_NAME = "online_detection";
   private static final String DEFAULT_DATASET_NAME = "online_dataset";


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org