[pulsar-manager] branch master updated: Added JWT Token Support (#203)
This is an automated email from the ASF dual-hosted git repository.
guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git
The following commit(s) were added to refs/heads/master by this push:
new c3ebbd1 Added JWT Token Support (#203)
c3ebbd1 is described below
commit c3ebbd1b39b0e7a1bee2403c6513641cb55e1eac
Author: Yuvaraj L
AuthorDate: Fri Oct 25 11:28:30 2019 +0530
Added JWT Token Support (#203)
* Added JWT Token Authentication Support Upgraded Spring and gradle to
4.10.2
* Added pulsarJwtToken to Test Cases
* Send token only when configured
* Fixed License header formatting
Signed-off-by: Yuvaraj Loganathan
* Reverted Spring & gradle upgrade
Will raise an separate pull request for the upgrade
Signed-off-by: Yuvaraj Loganathan
* Reverted Gradle Version
Signed-off-by: Yuvaraj Loganathan
---
.gitignore| 2 ++
front-end/src/utils/request.js| 2 +-
.../pulsar/manager/controller/EnvironmentsController.java | 11 +++
.../pulsar/manager/service/impl/BookiesServiceImpl.java | 8
.../manager/service/impl/BrokerStatsServiceImpl.java | 15 ++-
.../pulsar/manager/service/impl/BrokersServiceImpl.java | 7 +++
.../pulsar/manager/service/impl/ClustersServiceImpl.java | 8
.../manager/service/impl/EnvironmentCacheServiceImpl.java | 7 +++
.../manager/service/impl/NamespacesServiceImpl.java | 7 +++
.../pulsar/manager/service/impl/TenantsServiceImpl.java | 7 +++
.../pulsar/manager/service/impl/TopicsServiceImpl.java| 7 +++
.../pulsar/manager/zuul/EnvironmentForward.java | 8 ++--
src/main/resources/application.properties | 6 +-
.../pulsar/manager/service/BookiesServiceImplTest.java| 8
.../manager/service/BrokerStatsServiceImplTest.java | 8
.../pulsar/manager/service/BrokersServiceImplTest.java| 10 ++
.../pulsar/manager/service/ClustersServiceImplTest.java | 8
.../pulsar/manager/service/NamespacesServiceImplTest.java | 11 +++
.../pulsar/manager/service/TenantsServiceImplTest.java| 8
.../pulsar/manager/service/TopicsServiceImplTest.java | 11 +++
20 files changed, 154 insertions(+), 5 deletions(-)
diff --git a/.gitignore b/.gitignore
index a892a4f..5b37fc9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,3 +45,5 @@ build/
front-end/data/
*.log
dbdata
+src/main/resources/local.properties
+
diff --git a/front-end/src/utils/request.js b/front-end/src/utils/request.js
index df7d81f..dcbe922 100644
--- a/front-end/src/utils/request.js
+++ b/front-end/src/utils/request.js
@@ -22,7 +22,7 @@ import router from '../router'
// create an axios instance
const service = axios.create({
baseURL: process.env.BASE_API, // api 的 base_url
- timeout: 5000 // request timeout
+ timeout: 6 // request timeout
})
// request interceptor
diff --git
a/src/main/java/io/streamnative/pulsar/manager/controller/EnvironmentsController.java
b/src/main/java/io/streamnative/pulsar/manager/controller/EnvironmentsController.java
index 49d92e5..d7dea7f 100644
---
a/src/main/java/io/streamnative/pulsar/manager/controller/EnvironmentsController.java
+++
b/src/main/java/io/streamnative/pulsar/manager/controller/EnvironmentsController.java
@@ -24,8 +24,10 @@ import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiParam;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
+import org.apache.commons.lang3.StringUtils;
import org.hibernate.validator.constraints.Range;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
import org.springframework.http.ResponseEntity;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.bind.annotation.RequestBody;
@@ -50,6 +52,9 @@ public class EnvironmentsController {
@Autowired
private EnvironmentsRepository environmentsRepository;
+@Value("${backend.jwt.token}")
+private String pulsarJwtToken;
+
@Autowired
private EnvironmentCacheService environmentCacheService;
@@ -102,6 +107,9 @@ public class EnvironmentsController {
}
Map header = Maps.newHashMap();
header.put("Content-Type", "application/json");
+if (StringUtils.isNotBlank(pulsarJwtToken)) {
+header.put("Authorization", String.format("Bearer %s",
pulsarJwtToken));
+}
String httpTestResult = HttpUtil.doGet(environmentEntity.getBroker() +
"/metrics", header);
if (httpTestResult == null) {
result.put("error", "This environment is error. Please check it");
@@ -129,6 +137,9 @@ public class EnvironmentsController {
[GitHub] [pulsar] jerrypeng opened a new pull request #5463: Function runtime pluggable
jerrypeng opened a new pull request #5463: Function runtime pluggable URL: https://github.com/apache/pulsar/pull/5463 Master Issue: https://github.com/apache/pulsar/issues/4176 ### Motivation Currently, Pulsar Function runtime does not expose a clean interface to make it pluggable. ### Modifications Make Pulsar Function Runtime Factory pluggable to make specifying Function Runtimes more flexible and allow the development of future runtimes to be more smooth since a complete interface is extracted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #3594: [pulsar-broker] vip-status checker for tls-only mode broker
rdhabalia removed a comment on issue #3594: [pulsar-broker] vip-status checker for tls-only mode broker URL: https://github.com/apache/pulsar/pull/3594#issuecomment-546063820 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-546198138 rerun java8 tests rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546198075 rerun cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (6823628 -> bf9a901)
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6823628 Handle tearDown exception for test stability (#5460) add bf9a901 [pulsar-client] Fix message corruption on OOM for batch messages (#5443) No new revisions were added by this update. Summary of changes: .../client/impl/BatchMessageContainerImpl.java | 28 ++ .../apache/pulsar/client/impl/ProducerImpl.java| 2 +- 2 files changed, 25 insertions(+), 5 deletions(-)
[GitHub] [pulsar] rdhabalia merged pull request #5443: [pulsar-client] Fix message corruption on OOM for batch messages
rdhabalia merged pull request #5443: [pulsar-client] Fix message corruption on OOM for batch messages URL: https://github.com/apache/pulsar/pull/5443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (7c3f3bd -> 6823628)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7c3f3bd Expose metrics of Caffeine caches (#5320) add 6823628 Handle tearDown exception for test stability (#5460) No new revisions were added by this update. Summary of changes: .../bookkeeper/test/MockedBookKeeperTestCase.java | 24 +- 1 file changed, 14 insertions(+), 10 deletions(-)
[GitHub] [pulsar] merlimat merged pull request #5460: Handle tearDown exception for test stability
merlimat merged pull request #5460: Handle tearDown exception for test stability URL: https://github.com/apache/pulsar/pull/5460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence
jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence URL: https://github.com/apache/pulsar/pull/5453#issuecomment-546187195 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] sunlc210 opened a new issue #76: Transfer data is blocked by flush
sunlc210 opened a new issue #76: Transfer data is blocked by flush
URL: https://github.com/apache/pulsar-client-go/issues/76
To pump data buy filebeat to pulsar cluster , by using go client .
Found that ,after sending message to pulsar successfully, there will be
blocked by using flush function.
the code is below ：
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
if !ok {
p.log.Error("internalFlush block ,Flush error")
fr.waitGroup.Done()
return
}
p.log.Info("InternalFlush corrctly: ")
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
fr.err = e
fr.waitGroup.Done()
},
})
}
func (p *partitionProducer) Send(ctx context.Context, msg *ProducerMessage)
error {
wg := sync.WaitGroup{}
wg.Add(1)
var err error
p.internalSendAsync(ctx, msg, func(ID MessageID, message
*ProducerMessage, e error) {
err = e
wg.Done()
}, true)
// When sending synchronously we flush immediately to avoid
// the increased latency and reduced throughput of batching
p.log.Info("---beginning flsuh ")
if err = p.Flush(); err != nil {
return err
}
p.log.Info("---end flsuh ")
wg.Wait()
return err
}
’
log as below
time="2019-10-25T10:39:53+08:00" level=info msg="InternalFlush corrctly: "
name=dc_jh1 topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="---end
flsuh " name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info
msg="---beginning flsuh " name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="InternalFlush corrctly: "
name=dc_jh1 topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="---end
flsuh " name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info
msg="---beginning flsuh ----" name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="InternalFlush corrctly: "
name=dc_jh1 topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="---end
flsuh " name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info
msg="---beginning flsuh " name=dc_jh1
topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
time="2019-10-25T10:39:53+08:00" level=info msg="InternalFlush corrctly: "
name=dc_jh1 topic="persistent://crossjhwx/jh2wx/20191024-partition-0"
the problem is occured on below section
p.log.Info("InternalFlush corrctly: ")
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
fr.err = e
fr.waitGroup.Done()
},
})
no idea the logic ,but make sure the error is occur on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] pouledodue commented on issue #5459: macOS 10.15 support
pouledodue commented on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-546150532 @e14nielson https://github.com/apache/pulsar/issues/5248#issuecomment-533939386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] gm7y8 commented on issue #5425: website page `coding_guide` return 404
gm7y8 commented on issue #5425: website page `coding_guide` return 404 URL: https://github.com/apache/pulsar/issues/5425#issuecomment-546149019 @jiazhai can i pick this up? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5455: Update test docker scripts and library
aahmed-se commented on issue #5455: Update test docker scripts and library URL: https://github.com/apache/pulsar/pull/5455#issuecomment-546144640 run integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-546144185 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build
aahmed-se commented on issue #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458#issuecomment-546143954 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5456: [integration-tests]Enable messaging tests to integration tests.
jerrypeng commented on issue #5456: [integration-tests]Enable messaging tests to integration tests. URL: https://github.com/apache/pulsar/pull/5456#issuecomment-546142477 @codelipenghui some of the PersistentTopicMessagingTest are failing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5328: Increase the retries count for PulsarFunctionStateTest
merlimat commented on issue #5328: Increase the retries count for PulsarFunctionStateTest URL: https://github.com/apache/pulsar/pull/5328#issuecomment-546137897 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546132739 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-546132176 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia opened a new pull request #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData
rdhabalia opened a new pull request #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData URL: https://github.com/apache/pulsar/pull/5462 ### Motivation with #3677, ServerCnx is not storing client's `authenticationData` which is used by custom authorization provider and it always receives `authenticationData` as null and custom auth-provider fails with authorization. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546096081 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546126133 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic
rdhabalia commented on issue #3986: [pulsar-broker] Introduce publish rate-limiting on topic URL: https://github.com/apache/pulsar/pull/3986#issuecomment-546126280 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546126133 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf
merlimat commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf URL: https://github.com/apache/pulsar/pull/5359#issuecomment-546122189 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence
merlimat commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence URL: https://github.com/apache/pulsar/pull/5453#issuecomment-546120867 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat closed pull request #5331: Avoid rethrowing exception during test teardown
merlimat closed pull request #5331: Avoid rethrowing exception during test teardown URL: https://github.com/apache/pulsar/pull/5331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5460: Handle tearDown exception for test stability
aahmed-se commented on issue #5460: Handle tearDown exception for test stability URL: https://github.com/apache/pulsar/pull/5460#issuecomment-546115727 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia removed a comment on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546115353 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546115353 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5358: PIP-45: Switch ManagedLedger to use MetadataStore interface
merlimat commented on issue #5358: PIP-45: Switch ManagedLedger to use MetadataStore interface URL: https://github.com/apache/pulsar/pull/5358#issuecomment-546114978 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (402ecec -> 7c3f3bd)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 402ecec [pulsar-client] support set read-position based on timestamp (#5075) add 7c3f3bd Expose metrics of Caffeine caches (#5320) No new revisions were added by this update. Summary of changes: distribution/server/src/assemble/LICENSE.bin.txt | 1 + pom.xml| 6 ++ pulsar-broker/pom.xml | 1 - .../pulsar/broker/BookKeeperClientFactoryImpl.java | 9 +--- .../pulsar/broker/namespace/OwnershipCache.java| 14 - .../common/naming/NamespaceBundleFactory.java | 7 ++- .../pulsar/broker/stats/PrometheusMetricsTest.java | 7 +++ .../apache/pulsar/io/PulsarFunctionE2ETest.java| 2 +- pulsar-zookeeper-utils/pom.xml | 4 .../apache/pulsar/stats/CacheMetricsCollector.java | 17 ++- .../pulsar/zookeeper/GlobalZooKeeperCache.java | 2 +- .../pulsar/zookeeper/LocalZooKeeperCache.java | 2 +- .../zookeeper/ZkBookieRackAffinityMapping.java | 3 ++- .../ZkIsolatedBookieEnsemblePlacementPolicy.java | 5 +++-- .../apache/pulsar/zookeeper/ZooKeeperCache.java| 24 -- .../zookeeper/ZkBookieRackAffinityMappingTest.java | 6 +++--- ...kIsolatedBookieEnsemblePlacementPolicyTest.java | 24 +++--- 17 files changed, 82 insertions(+), 52 deletions(-) copy pulsar-broker-common/src/main/java/org/apache/pulsar/common/configuration/Category.java => pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/stats/CacheMetricsCollector.java (72%)
[GitHub] [pulsar] merlimat merged pull request #5320: Expose metrics of Caffeine caches
merlimat merged pull request #5320: Expose metrics of Caffeine caches URL: https://github.com/apache/pulsar/pull/5320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5461: (WIP) Add Unified native clients build step
aahmed-se opened a new pull request #5461: (WIP) Add Unified native clients build step URL: https://github.com/apache/pulsar/pull/5461 Remove python2 from package. make python point to python3 make pip point to pip3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5458: [cpp-build] Do not install libsnappy at each build
merlimat commented on issue #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458#issuecomment-546113583 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5447: Apache Beam support for Pulsar
aahmed-se commented on issue #5447: Apache Beam support for Pulsar URL: https://github.com/apache/pulsar/issues/5447#issuecomment-546110903 this should be a request in the beam repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jm7647 commented on issue #5454: mysql JDBC Sink - consumer error
jm7647 commented on issue #5454: mysql JDBC Sink - consumer error
URL: https://github.com/apache/pulsar/issues/5454#issuecomment-546101921
This is producer code I used based on your sample - still same error:
producer = client.create_producer(
topic='pulsar-mysql-jdbc-sink-topic',
properties={"EVENT": "INSERT"},
schema=AvroSchema(Test))
r = Test(id=1, name="Hello World")
producer.send(r)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] vicaya commented on issue #3671: pulsar-admin topics list public/default fails
vicaya commented on issue #3671: pulsar-admin topics list public/default fails URL: https://github.com/apache/pulsar/issues/3671#issuecomment-546100467 See this on a 2.4.0 cluster as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia merged pull request #5075: [pulsar-client] support set read-position based on timestamp
rdhabalia merged pull request #5075: [pulsar-client] support set read-position based on timestamp URL: https://github.com/apache/pulsar/pull/5075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (991c2a2 -> 402ecec)
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 991c2a2 Multiple unit tests improvements (#5439) add 402ecec [pulsar-client] support set read-position based on timestamp (#5075) No new revisions were added by this update. Summary of changes: .../apache/pulsar/broker/service/ServerCnx.java| 7 +- .../org/apache/pulsar/broker/service/Topic.java| 2 +- .../service/nonpersistent/NonPersistentTopic.java | 2 +- .../broker/service/persistent/PersistentTopic.java | 31 ++-- .../apache/pulsar/client/impl/RawReaderImpl.java | 1 + .../service/PersistentTopicConcurrentTest.java | 8 +- .../pulsar/broker/service/PersistentTopicTest.java | 26 +++ .../pulsar/broker/service/ServerCnxTest.java | 65 +--- .../client/api/SimpleProducerConsumerTest.java | 1 + .../org/apache/pulsar/client/impl/ReaderTest.java | 87 ++ .../apache/pulsar/client/api/ReaderBuilder.java| 13 .../apache/pulsar/client/impl/ConsumerImpl.java| 22 -- .../pulsar/client/impl/ReaderBuilderImpl.java | 7 ++ .../org/apache/pulsar/client/impl/ReaderImpl.java | 7 +- .../pulsar/client/impl/ZeroQueueConsumerImpl.java | 5 +- .../client/impl/conf/ReaderConfigurationData.java | 5 ++ .../apache/pulsar/common/api/proto/PulsarApi.java | 57 ++ .../apache/pulsar/common/protocol/Commands.java| 9 ++- pulsar-common/src/main/proto/PulsarApi.proto | 6 +- 19 files changed, 289 insertions(+), 72 deletions(-)
[GitHub] [pulsar] rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx
rdhabalia commented on issue #3705: [pulsar-broker] add support for connection expiry and renew-cnx URL: https://github.com/apache/pulsar/pull/3705#issuecomment-546096081 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5455: Update test docker scripts and library
aahmed-se commented on issue #5455: Update test docker scripts and library URL: https://github.com/apache/pulsar/pull/5455#issuecomment-546078472 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5459: macOS 10.15 support
aahmed-se commented on issue #5459: macOS 10.15 support URL: https://github.com/apache/pulsar/issues/5459#issuecomment-546078221 the packages published are for mac os 10.14, will try to publish osx 10.15 packages next release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #3594: [pulsar-broker] vip-status checker for tls-only mode broker
rdhabalia commented on issue #3594: [pulsar-broker] vip-status checker for tls-only mode broker URL: https://github.com/apache/pulsar/pull/3594#issuecomment-546063820 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5460: Handle tearDown exception for test stability
aahmed-se opened a new pull request #5460: Handle tearDown exception for test stability URL: https://github.com/apache/pulsar/pull/5460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5458: [cpp-build] Do not install libsnappy at each build
merlimat opened a new pull request #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458 ### Motivation The docker image containing libsnappy was already pushed to docker hub so there's no need to install the package in the container at each build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5317: Allow to specify delivery delay in C++ client
merlimat commented on issue #5317: Allow to specify delivery delay in C++ client URL: https://github.com/apache/pulsar/pull/5317#issuecomment-546045116 run cpp tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (978efaf -> 991c2a2)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 978efaf [proxy] Fix proxy to be able to re-send request body (#5361) add 991c2a2 Multiple unit tests improvements (#5439) No new revisions were added by this update. Summary of changes: .../apache/pulsar/tests/PulsarTestListener.java| 17 +- .../mledger/impl/ManagedLedgerFactoryImpl.java | 20 +- .../mledger/impl/ManagedLedgerBkTest.java | 2 + .../bookkeeper/test/BookKeeperClusterTestCase.java | 1 + .../org/apache/bookkeeper/test/PortManager.java| 97 ++--- pom.xml| 7 +- .../org/apache/pulsar/PulsarBrokerStarter.java | 11 +- .../apache/pulsar/broker/NoOpShutdownService.java | 19 +- .../org/apache/pulsar/broker/PulsarService.java| 19 +- .../loadbalance/impl/SimpleLoadManagerImpl.java| 2 +- .../pulsar/broker/service/BrokerService.java | 10 +- .../stats/prometheus/NamespaceStatsAggregator.java | 1 + .../broker/BookKeeperClientFactoryImplTest.java| 3 + .../apache/pulsar/broker/SLAMonitoringTest.java| 4 +- .../apache/pulsar/broker/admin/AdminApiTest.java | 6 +- .../apache/pulsar/broker/admin/AdminApiTest2.java | 7 +- .../broker/admin/BrokerAdminClientTlsAuthTest.java | 14 +- .../pulsar/broker/admin/v1/V1_AdminApiTest.java| 3 + .../pulsar/broker/admin/v1/V1_AdminApiTest2.java | 4 + .../broker/auth/MockedPulsarServiceBaseTest.java | 28 +- .../broker/cache/ResourceQuotaCacheTest.java | 10 +- .../AntiAffinityNamespaceGroupTest.java| 44 ++- .../broker/loadbalance/LoadBalancerTest.java | 9 +- .../loadbalance/ModularLoadManagerImplTest.java| 35 +- .../loadbalance/SimpleLoadManagerImplTest.java | 13 +- .../namespace/NamespaceCreateBundlesTest.java | 4 +- .../broker/namespace/NamespaceServiceTest.java | 4 +- .../broker/namespace/OwnershipCacheTest.java | 6 +- .../broker/service/AdvertisedAddressTest.java | 22 +- .../broker/service/BacklogQuotaManagerTest.java| 2 + .../pulsar/broker/service/BatchMessageTest.java| 11 +- .../broker/service/BrokerBkEnsemblesTests.java | 4 +- .../broker/service/BrokerBookieIsolationTest.java | 26 +- .../pulsar/broker/service/MaxMessageSizeTest.java | 2 + .../PersistentDispatcherFailoverConsumerTest.java | 15 +- .../broker/service/PersistentFailoverE2ETest.java | 30 +- .../service/PersistentMessageFinderTest.java | 10 +- .../broker/service/PersistentQueueE2ETest.java | 4 +- .../service/PersistentTopicConcurrentTest.java | 2 + .../pulsar/broker/service/PersistentTopicTest.java | 12 +- .../pulsar/broker/service/ReplicatorTestBase.java | 4 + .../pulsar/broker/service/ServerCnxTest.java | 12 +- .../persistent/PersistentSubscriptionTest.java | 14 +- .../pulsar/broker/stats/PrometheusMetricsTest.java | 3 - .../buffer/PersistentTransactionBufferTest.java| 10 +- .../apache/pulsar/broker/web/WebServiceTest.java | 6 +- .../api/AuthorizationProducerConsumerTest.java | 27 +- .../pulsar/client/api/BrokerServiceLookupTest.java | 49 ++- .../client/api/ClientDeduplicationFailureTest.java | 19 +- .../client/api/DispatcherBlockConsumerTest.java| 118 --- .../pulsar/client/api/NonPersistentTopicTest.java | 10 +- .../pulsar/client/api/ServiceUrlProviderTest.java | 2 +- .../pulsar/client/api/TlsProducerConsumerBase.java | 9 + .../client/api/v1/V1_ProducerConsumerTest.java | 4 +- .../client/impl/BrokerClientIntegrationTest.java | 56 ++- .../pulsar/client/impl/ConnectionPoolTest.java | 6 +- .../pulsar/client/impl/TopicsConsumerImplTest.java | 1 + .../impl/UnAcknowledgedMessagesTimeoutTest.java| 152 .../worker/PulsarFunctionE2ESecurityTest.java | 6 +- .../worker/PulsarFunctionLocalRunTest.java | 2 + .../worker/PulsarFunctionPublishTest.java | 7 +- .../functions/worker/PulsarFunctionStateTest.java | 389 - .../worker/PulsarWorkerAssignmentTest.java | 2 + .../apache/pulsar/io/PulsarFunctionAdminTest.java | 2 + .../apache/pulsar/io/PulsarFunctionE2ETest.java| 6 +- .../websocket/proxy/ProxyPublishConsumeTest.java | 13 +- .../pulsar/client/cli/PulsarClientToolTest.java| 11 +- .../pulsar/client/impl/schema/BooleanSchema.java | 15 +- .../pulsar/client/impl/schema/ByteBufSchema.java | 15 +- .../client/impl/schema/ByteBufferSchema.java | 19 +- .../pulsar/client/impl/schema/ByteSchema.java | 15 +- .../pulsar/client/impl/schema/BytesSchema.java | 16 +- .../pulsar/client/impl/schema/DateSchema.java | 15 +- .../pulsar/client/impl/schema/DoubleSchema.java| 16 +- .../pulsar/client/impl/schema/FloatSchema.java | 15 +-
[GitHub] [pulsar] merlimat merged pull request #5439: Multiple unit tests improvements
merlimat merged pull request #5439: Multiple unit tests improvements URL: https://github.com/apache/pulsar/pull/5439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #4400: PIP 37: [pulsar-client] support large message size
rdhabalia commented on issue #4400: PIP 37: [pulsar-client] support large message size URL: https://github.com/apache/pulsar/pull/4400#issuecomment-546039490 I think rebasing this PR takes lot of time as txn and other changes have changed a lot after this PR. @merlimat can you please review it as multiple users need this feature and #4247 and txn is not useful for multiple reasons. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5075: [pulsar-client] support set read-position based on timestamp
rdhabalia commented on issue #5075: [pulsar-client] support set read-position based on timestamp URL: https://github.com/apache/pulsar/pull/5075#issuecomment-546037295 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5232: Upgrade dependencies for security fixes
aahmed-se commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-546026629 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5320: Expose metrics of Caffeine caches
merlimat commented on issue #5320: Expose metrics of Caffeine caches URL: https://github.com/apache/pulsar/pull/5320#issuecomment-546023994 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (a71ac20 -> 978efaf)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a71ac20 Fix website io connector 404 (#5347) add 978efaf [proxy] Fix proxy to be able to re-send request body (#5361) No new revisions were added by this update. Summary of changes: .../pulsar/proxy/server/AdminProxyHandler.java | 40 ++ .../pulsar/tests/integration/proxy/TestProxy.java | 24 + 2 files changed, 64 insertions(+)
[pulsar] branch master updated (b4e5d15 -> a71ac20)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from b4e5d15 Standalone should use crc32c by default as well (#5385)
add a71ac20 Fix website io connector 404 (#5347)
No new revisions were added by this update.
Summary of changes:
.../version-2.1.0-incubating => docs}/io-aerospike.md | 5 ++---
.../version-2.1.0-incubating => docs}/io-cassandra.md | 5 ++---
site2/docs/io-connectors.md | 1 -
.../versioned_docs/version-2.3.1 => docs}/io-elasticsearch.md | 3 +--
site2/docs/io-file-source.md | 2 +-
site2/{website/versioned_docs/version-2.3.1 => docs}/io-file.md | 3 +--
site2/{website/versioned_docs/version-2.3.1 => docs}/io-hdfs.md | 5 ++---
.../{website/versioned_docs/version-2.3.1 => docs}/io-influxdb.md | 5 ++---
site2/{website/versioned_docs/version-2.4.1 => docs}/io-jdbc.md | 3 +--
site2/{website/versioned_docs/version-2.3.0 => docs}/io-kafka.md | 5 ++---
.../version-2.1.0-incubating => docs}/io-kinesis.md | 8 +++-
site2/{website/versioned_docs/version-2.3.1 => docs}/io-mongo.md | 3 +--
site2/docs/io-netty-source.md | 2 +-
site2/{website/versioned_docs/version-2.3.0 => docs}/io-netty.md | 5 ++---
site2/docs/io-rabbitmq-source.md | 2 +-
.../{website/versioned_docs/version-2.3.1 => docs}/io-rabbitmq.md | 4 +---
site2/{website/versioned_docs/version-2.3.2 => docs}/io-redis.md | 3 +--
site2/{website/versioned_docs/version-2.3.1 => docs}/io-solr.md | 3 +--
.../version-2.1.0-incubating => docs}/io-twitter.md | 4 +---
19 files changed, 26 insertions(+), 45 deletions(-)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/io-aerospike.md (90%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/io-cassandra.md (90%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-elasticsearch.md
(90%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-file.md (95%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-hdfs.md (95%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-influxdb.md (94%)
copy site2/{website/versioned_docs/version-2.4.1 => docs}/io-jdbc.md (94%)
copy site2/{website/versioned_docs/version-2.3.0 => docs}/io-kafka.md (98%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/io-kinesis.md (92%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-mongo.md (92%)
copy site2/{website/versioned_docs/version-2.3.0 => docs}/io-netty.md (92%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-rabbitmq.md (98%)
copy site2/{website/versioned_docs/version-2.3.2 => docs}/io-redis.md (95%)
copy site2/{website/versioned_docs/version-2.3.1 => docs}/io-solr.md (94%)
copy site2/{website/versioned_docs/version-2.1.0-incubating =>
docs}/io-twitter.md (93%)
[GitHub] [pulsar] merlimat merged pull request #5347: [Docs]Fix website io connector link 404
merlimat merged pull request #5347: [Docs]Fix website io connector link 404 URL: https://github.com/apache/pulsar/pull/5347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat closed issue #5360: Proxy doesn't send request body on redirects
merlimat closed issue #5360: Proxy doesn't send request body on redirects URL: https://github.com/apache/pulsar/issues/5360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (c5c44a9 -> b4e5d15)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c5c44a9 Add test for links to other markdown docs. (#5411) add b4e5d15 Standalone should use crc32c by default as well (#5385) No new revisions were added by this update. Summary of changes: conf/standalone.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[pulsar] branch master updated (c5c44a9 -> b4e5d15)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c5c44a9 Add test for links to other markdown docs. (#5411) add b4e5d15 Standalone should use crc32c by default as well (#5385) No new revisions were added by this update. Summary of changes: conf/standalone.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[GitHub] [pulsar] merlimat commented on issue #5043: [zookeeper] bump zookeeper to version 3.5.5
merlimat commented on issue #5043: [zookeeper] bump zookeeper to version 3.5.5 URL: https://github.com/apache/pulsar/pull/5043#issuecomment-545980449 > Fyi now 3.5.6 is available :) Yes, and it includes fix for upgrading ZK with missing snapshot: https://issues.apache.org/jira/browse/ZOOKEEPER-3056 @addisonj This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (c5c44a9 -> b4e5d15)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c5c44a9 Add test for links to other markdown docs. (#5411) add b4e5d15 Standalone should use crc32c by default as well (#5385) No new revisions were added by this update. Summary of changes: conf/standalone.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[GitHub] [pulsar] merlimat merged pull request #5385: Standalone should use crc32c by default as well
merlimat merged pull request #5385: Standalone should use crc32c by default as well URL: https://github.com/apache/pulsar/pull/5385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5342: Use simple GC settings when running integration tests
merlimat commented on issue #5342: Use simple GC settings when running integration tests URL: https://github.com/apache/pulsar/pull/5342#issuecomment-545974819 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng edited a comment on issue #5454: mysql JDBC Sink - consumer error
tuteng edited a comment on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-545966420 http://pulsar.apache.org/docs/en/next/io-connectors/ It is already being fixed. https://github.com/apache/pulsar/pull/5347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5456: [integration-tests]Enable messaging tests to integration tests.
tuteng commented on issue #5456: [integration-tests]Enable messaging tests to integration tests. URL: https://github.com/apache/pulsar/pull/5456#issuecomment-545970319 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (a95bea6 -> ba6dfaf)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a95bea6 Add support for partitioned topic consumer seek by time. (#5435) add ba6dfaf [Doc] Add *authenticateMetricsEndpoint* option in administration-proxy.md (#5406) No new revisions were added by this update. Summary of changes: site2/docs/administration-proxy.md | 1 + 1 file changed, 1 insertion(+)
[pulsar] branch master updated (ba6dfaf -> c5c44a9)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from ba6dfaf [Doc] Add *authenticateMetricsEndpoint* option in administration-proxy.md (#5406) add c5c44a9 Add test for links to other markdown docs. (#5411) No new revisions were added by this update. Summary of changes: site2/README.md | 8 + site2/website/__tests__/doc-links.test.js | 67 ++ site2/website/__tests__/docs.test.js | 354 -- site2/website/__tests__/index.test.js | 18 -- site2/website/jest-puppeteer.config.js| 10 - 5 files changed, 75 insertions(+), 382 deletions(-) create mode 100644 site2/website/__tests__/doc-links.test.js delete mode 100644 site2/website/__tests__/docs.test.js delete mode 100644 site2/website/__tests__/index.test.js delete mode 100644 site2/website/jest-puppeteer.config.js
[GitHub] [pulsar] merlimat merged pull request #5406: [Doc] Add *authenticateMetricsEndpoint* option in administration-prox…
merlimat merged pull request #5406: [Doc] Add *authenticateMetricsEndpoint* option in administration-prox… URL: https://github.com/apache/pulsar/pull/5406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #5411: Add test for links to other markdown docs.
merlimat merged pull request #5411: Add test for links to other markdown docs. URL: https://github.com/apache/pulsar/pull/5411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5454: mysql JDBC Sink - consumer error
tuteng commented on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-545966420 http://pulsar.apache.org/docs/en/next/io-connectors/ It is already being fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jm7647 commented on issue #5454: mysql JDBC Sink - consumer error
jm7647 commented on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-545940153 I was hoping you have some python example. There is nothing I could find on your web side regarding producer for that sink. All links related to builtin connectors are broken: https://pulsar.apache.org/docs/en/io-connectors/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery
codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-545908928 run integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery
codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-545908413 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5457: [transaction-coordinator] Ownership change listeners
codelipenghui commented on issue #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#issuecomment-545907008 @jiazhai @sijie According to our discussion offline, please help take a look, Is this PR suitable for kop? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new pull request #5457: [transaction-coordinator] Ownership change listeners
codelipenghui opened a new pull request #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457 ### Motivation This is the first part to implement transaction coordinator startup, this PR added ownership change listeners, using the ownership change listeners can get namespace bundle/topics is owned or unload by this broker. transaction coordinator can add listeners to create transaction coordinator instance, also some other component can use it to get the change event of ownership. ### Modifications Add namespace bundle ownership listener Add topic ownership listener ### Verifying this change Added new unit tests ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5456: [integration-tests]Enable messaging tests to integration tests.
codelipenghui commented on issue #5456: [integration-tests]Enable messaging tests to integration tests. URL: https://github.com/apache/pulsar/pull/5456#issuecomment-545893754 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-go] branch master updated: fix: avoid assert panic (#73)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 8a2ff05 fix: avoid assert panic (#73)
8a2ff05 is described below
commit 8a2ff054d85bcbdba433b18639745920bbabc64c
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:09:44 2019 +0800
fix: avoid assert panic (#73)
- add assert check
Fixes #64
Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
---
pulsar/impl_partition_producer.go | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/pulsar/impl_partition_producer.go
b/pulsar/impl_partition_producer.go
index 07e2da0..f09cd42 100644
--- a/pulsar/impl_partition_producer.go
+++ b/pulsar/impl_partition_producer.go
@@ -23,10 +23,11 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/pulsar/internal"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
log "github.com/sirupsen/logrus"
)
@@ -293,7 +294,12 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
+ pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
+ if !ok {
+ fr.waitGroup.Done()
+ return
+ }
+
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
@@ -349,12 +355,14 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
}
func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt) {
- pi := p.pendingQueue.Peek().(*pendingItem)
+ pi, ok := p.pendingQueue.Peek().(*pendingItem)
- if pi == nil {
+ if !ok {
p.log.Warnf("Received ack for %v although the pending queue is
empty", response.GetMessageId())
return
- } else if pi.sequenceID != response.GetSequenceId() {
+ }
+
+ if pi.sequenceID != response.GetSequenceId() {
p.log.Warnf("Received ack for %v on sequenceId %v - expected:
%v", response.GetMessageId(),
response.GetSequenceId(), pi.sequenceID)
return
[pulsar-client-go] branch master updated: refactor: gofmt code (#75)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 84fb576 refactor: gofmt code (#75)
84fb576 is described below
commit 84fb5765f1e817a2e2bdcafedcc73095c4c2f2c2
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:13:24 2019 +0800
refactor: gofmt code (#75)
Motivation:
code is not fmt, should be with gofmt
Modifications:
- gofmt once
Fixes #74
Change-Id: Ic4eb14080bb0da22be418ff1385d90209f2b9d27
---
examples/consumer-listener/consumer-listener.go | 62 -
examples/consumer/consumer.go | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/examples/consumer-listener/consumer-listener.go
b/examples/consumer-listener/consumer-listener.go
index c20d731..0a8e6c9 100644
--- a/examples/consumer-listener/consumer-listener.go
+++ b/examples/consumer-listener/consumer-listener.go
@@ -18,47 +18,47 @@
package main
import (
-"fmt"
-"log"
+ "fmt"
+ "log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
-if err != nil {
-log.Fatal(err)
-}
+ client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
+ if err != nil {
+ log.Fatal(err)
+ }
-defer client.Close()
+ defer client.Close()
-channel := make(chan pulsar.ConsumerMessage, 100)
+ channel := make(chan pulsar.ConsumerMessage, 100)
-options := pulsar.ConsumerOptions{
-Topic:"topic-1",
-SubscriptionName: "my-subscription",
-Type: pulsar.Shared,
-}
+ options := pulsar.ConsumerOptions{
+ Topic:"topic-1",
+ SubscriptionName: "my-subscription",
+ Type: pulsar.Shared,
+ }
-options.MessageChannel = channel
+ options.MessageChannel = channel
-consumer, err := client.Subscribe(options)
-if err != nil {
-log.Fatal(err)
-}
+ consumer, err := client.Subscribe(options)
+ if err != nil {
+ log.Fatal(err)
+ }
-defer consumer.Close()
+ defer consumer.Close()
-// Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
-// the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
-// shared across multiple consumers as well
-for cm := range channel {
-msg := cm.Message
-fmt.Printf("Received message msgId: %v -- content: '%s'\n",
-msg.ID(), string(msg.Payload()))
+ // Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
+ // the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
+ // shared across multiple consumers as well
+ for cm := range channel {
+ msg := cm.Message
+ fmt.Printf("Received message msgId: %v -- content: '%s'\n",
+ msg.ID(), string(msg.Payload()))
-if err := consumer.Ack(msg); err != nil {
-log.Fatal(err)
-}
-}
+ if err := consumer.Ack(msg); err != nil {
+ log.Fatal(err)
+ }
+ }
}
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index c408386..5250a02 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -22,7 +22,7 @@ import (
"fmt"
"log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
[pulsar-client-go] branch master updated: fix: avoid assert panic (#73)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 8a2ff05 fix: avoid assert panic (#73)
8a2ff05 is described below
commit 8a2ff054d85bcbdba433b18639745920bbabc64c
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:09:44 2019 +0800
fix: avoid assert panic (#73)
- add assert check
Fixes #64
Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
---
pulsar/impl_partition_producer.go | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/pulsar/impl_partition_producer.go
b/pulsar/impl_partition_producer.go
index 07e2da0..f09cd42 100644
--- a/pulsar/impl_partition_producer.go
+++ b/pulsar/impl_partition_producer.go
@@ -23,10 +23,11 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/pulsar/internal"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
log "github.com/sirupsen/logrus"
)
@@ -293,7 +294,12 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
+ pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
+ if !ok {
+ fr.waitGroup.Done()
+ return
+ }
+
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
@@ -349,12 +355,14 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
}
func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt) {
- pi := p.pendingQueue.Peek().(*pendingItem)
+ pi, ok := p.pendingQueue.Peek().(*pendingItem)
- if pi == nil {
+ if !ok {
p.log.Warnf("Received ack for %v although the pending queue is
empty", response.GetMessageId())
return
- } else if pi.sequenceID != response.GetSequenceId() {
+ }
+
+ if pi.sequenceID != response.GetSequenceId() {
p.log.Warnf("Received ack for %v on sequenceId %v - expected:
%v", response.GetMessageId(),
response.GetSequenceId(), pi.sequenceID)
return
[pulsar-client-go] branch master updated: refactor: gofmt code (#75)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 84fb576 refactor: gofmt code (#75)
84fb576 is described below
commit 84fb5765f1e817a2e2bdcafedcc73095c4c2f2c2
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:13:24 2019 +0800
refactor: gofmt code (#75)
Motivation:
code is not fmt, should be with gofmt
Modifications:
- gofmt once
Fixes #74
Change-Id: Ic4eb14080bb0da22be418ff1385d90209f2b9d27
---
examples/consumer-listener/consumer-listener.go | 62 -
examples/consumer/consumer.go | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/examples/consumer-listener/consumer-listener.go
b/examples/consumer-listener/consumer-listener.go
index c20d731..0a8e6c9 100644
--- a/examples/consumer-listener/consumer-listener.go
+++ b/examples/consumer-listener/consumer-listener.go
@@ -18,47 +18,47 @@
package main
import (
-"fmt"
-"log"
+ "fmt"
+ "log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
-if err != nil {
-log.Fatal(err)
-}
+ client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
+ if err != nil {
+ log.Fatal(err)
+ }
-defer client.Close()
+ defer client.Close()
-channel := make(chan pulsar.ConsumerMessage, 100)
+ channel := make(chan pulsar.ConsumerMessage, 100)
-options := pulsar.ConsumerOptions{
-Topic:"topic-1",
-SubscriptionName: "my-subscription",
-Type: pulsar.Shared,
-}
+ options := pulsar.ConsumerOptions{
+ Topic:"topic-1",
+ SubscriptionName: "my-subscription",
+ Type: pulsar.Shared,
+ }
-options.MessageChannel = channel
+ options.MessageChannel = channel
-consumer, err := client.Subscribe(options)
-if err != nil {
-log.Fatal(err)
-}
+ consumer, err := client.Subscribe(options)
+ if err != nil {
+ log.Fatal(err)
+ }
-defer consumer.Close()
+ defer consumer.Close()
-// Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
-// the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
-// shared across multiple consumers as well
-for cm := range channel {
-msg := cm.Message
-fmt.Printf("Received message msgId: %v -- content: '%s'\n",
-msg.ID(), string(msg.Payload()))
+ // Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
+ // the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
+ // shared across multiple consumers as well
+ for cm := range channel {
+ msg := cm.Message
+ fmt.Printf("Received message msgId: %v -- content: '%s'\n",
+ msg.ID(), string(msg.Payload()))
-if err := consumer.Ack(msg); err != nil {
-log.Fatal(err)
-}
-}
+ if err := consumer.Ack(msg); err != nil {
+ log.Fatal(err)
+ }
+ }
}
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index c408386..5250a02 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -22,7 +22,7 @@ import (
"fmt"
"log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
[pulsar-client-go] branch master updated: refactor: gofmt code (#75)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 84fb576 refactor: gofmt code (#75)
84fb576 is described below
commit 84fb5765f1e817a2e2bdcafedcc73095c4c2f2c2
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:13:24 2019 +0800
refactor: gofmt code (#75)
Motivation:
code is not fmt, should be with gofmt
Modifications:
- gofmt once
Fixes #74
Change-Id: Ic4eb14080bb0da22be418ff1385d90209f2b9d27
---
examples/consumer-listener/consumer-listener.go | 62 -
examples/consumer/consumer.go | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/examples/consumer-listener/consumer-listener.go
b/examples/consumer-listener/consumer-listener.go
index c20d731..0a8e6c9 100644
--- a/examples/consumer-listener/consumer-listener.go
+++ b/examples/consumer-listener/consumer-listener.go
@@ -18,47 +18,47 @@
package main
import (
-"fmt"
-"log"
+ "fmt"
+ "log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
-if err != nil {
-log.Fatal(err)
-}
+ client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
+ if err != nil {
+ log.Fatal(err)
+ }
-defer client.Close()
+ defer client.Close()
-channel := make(chan pulsar.ConsumerMessage, 100)
+ channel := make(chan pulsar.ConsumerMessage, 100)
-options := pulsar.ConsumerOptions{
-Topic:"topic-1",
-SubscriptionName: "my-subscription",
-Type: pulsar.Shared,
-}
+ options := pulsar.ConsumerOptions{
+ Topic:"topic-1",
+ SubscriptionName: "my-subscription",
+ Type: pulsar.Shared,
+ }
-options.MessageChannel = channel
+ options.MessageChannel = channel
-consumer, err := client.Subscribe(options)
-if err != nil {
-log.Fatal(err)
-}
+ consumer, err := client.Subscribe(options)
+ if err != nil {
+ log.Fatal(err)
+ }
-defer consumer.Close()
+ defer consumer.Close()
-// Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
-// the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
-// shared across multiple consumers as well
-for cm := range channel {
-msg := cm.Message
-fmt.Printf("Received message msgId: %v -- content: '%s'\n",
-msg.ID(), string(msg.Payload()))
+ // Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
+ // the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
+ // shared across multiple consumers as well
+ for cm := range channel {
+ msg := cm.Message
+ fmt.Printf("Received message msgId: %v -- content: '%s'\n",
+ msg.ID(), string(msg.Payload()))
-if err := consumer.Ack(msg); err != nil {
-log.Fatal(err)
-}
-}
+ if err := consumer.Ack(msg); err != nil {
+ log.Fatal(err)
+ }
+ }
}
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index c408386..5250a02 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -22,7 +22,7 @@ import (
"fmt"
"log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
[pulsar-client-go] branch master updated: fix: avoid assert panic (#73)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 8a2ff05 fix: avoid assert panic (#73)
8a2ff05 is described below
commit 8a2ff054d85bcbdba433b18639745920bbabc64c
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:09:44 2019 +0800
fix: avoid assert panic (#73)
- add assert check
Fixes #64
Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
---
pulsar/impl_partition_producer.go | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/pulsar/impl_partition_producer.go
b/pulsar/impl_partition_producer.go
index 07e2da0..f09cd42 100644
--- a/pulsar/impl_partition_producer.go
+++ b/pulsar/impl_partition_producer.go
@@ -23,10 +23,11 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/pulsar/internal"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
log "github.com/sirupsen/logrus"
)
@@ -293,7 +294,12 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
+ pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
+ if !ok {
+ fr.waitGroup.Done()
+ return
+ }
+
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
@@ -349,12 +355,14 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
}
func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt) {
- pi := p.pendingQueue.Peek().(*pendingItem)
+ pi, ok := p.pendingQueue.Peek().(*pendingItem)
- if pi == nil {
+ if !ok {
p.log.Warnf("Received ack for %v although the pending queue is
empty", response.GetMessageId())
return
- } else if pi.sequenceID != response.GetSequenceId() {
+ }
+
+ if pi.sequenceID != response.GetSequenceId() {
p.log.Warnf("Received ack for %v on sequenceId %v - expected:
%v", response.GetMessageId(),
response.GetSequenceId(), pi.sequenceID)
return
[pulsar-client-go] branch master updated: fix: avoid assert panic (#73)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 8a2ff05 fix: avoid assert panic (#73)
8a2ff05 is described below
commit 8a2ff054d85bcbdba433b18639745920bbabc64c
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:09:44 2019 +0800
fix: avoid assert panic (#73)
- add assert check
Fixes #64
Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
---
pulsar/impl_partition_producer.go | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/pulsar/impl_partition_producer.go
b/pulsar/impl_partition_producer.go
index 07e2da0..f09cd42 100644
--- a/pulsar/impl_partition_producer.go
+++ b/pulsar/impl_partition_producer.go
@@ -23,10 +23,11 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/pulsar/internal"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
log "github.com/sirupsen/logrus"
)
@@ -293,7 +294,12 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
+ pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
+ if !ok {
+ fr.waitGroup.Done()
+ return
+ }
+
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
@@ -349,12 +355,14 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
}
func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt) {
- pi := p.pendingQueue.Peek().(*pendingItem)
+ pi, ok := p.pendingQueue.Peek().(*pendingItem)
- if pi == nil {
+ if !ok {
p.log.Warnf("Received ack for %v although the pending queue is
empty", response.GetMessageId())
return
- } else if pi.sequenceID != response.GetSequenceId() {
+ }
+
+ if pi.sequenceID != response.GetSequenceId() {
p.log.Warnf("Received ack for %v on sequenceId %v - expected:
%v", response.GetMessageId(),
response.GetSequenceId(), pi.sequenceID)
return
[pulsar-client-go] branch master updated: refactor: gofmt code (#75)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 84fb576 refactor: gofmt code (#75)
84fb576 is described below
commit 84fb5765f1e817a2e2bdcafedcc73095c4c2f2c2
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:13:24 2019 +0800
refactor: gofmt code (#75)
Motivation:
code is not fmt, should be with gofmt
Modifications:
- gofmt once
Fixes #74
Change-Id: Ic4eb14080bb0da22be418ff1385d90209f2b9d27
---
examples/consumer-listener/consumer-listener.go | 62 -
examples/consumer/consumer.go | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/examples/consumer-listener/consumer-listener.go
b/examples/consumer-listener/consumer-listener.go
index c20d731..0a8e6c9 100644
--- a/examples/consumer-listener/consumer-listener.go
+++ b/examples/consumer-listener/consumer-listener.go
@@ -18,47 +18,47 @@
package main
import (
-"fmt"
-"log"
+ "fmt"
+ "log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
-if err != nil {
-log.Fatal(err)
-}
+ client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
+ if err != nil {
+ log.Fatal(err)
+ }
-defer client.Close()
+ defer client.Close()
-channel := make(chan pulsar.ConsumerMessage, 100)
+ channel := make(chan pulsar.ConsumerMessage, 100)
-options := pulsar.ConsumerOptions{
-Topic:"topic-1",
-SubscriptionName: "my-subscription",
-Type: pulsar.Shared,
-}
+ options := pulsar.ConsumerOptions{
+ Topic:"topic-1",
+ SubscriptionName: "my-subscription",
+ Type: pulsar.Shared,
+ }
-options.MessageChannel = channel
+ options.MessageChannel = channel
-consumer, err := client.Subscribe(options)
-if err != nil {
-log.Fatal(err)
-}
+ consumer, err := client.Subscribe(options)
+ if err != nil {
+ log.Fatal(err)
+ }
-defer consumer.Close()
+ defer consumer.Close()
-// Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
-// the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
-// shared across multiple consumers as well
-for cm := range channel {
-msg := cm.Message
-fmt.Printf("Received message msgId: %v -- content: '%s'\n",
-msg.ID(), string(msg.Payload()))
+ // Receive messages from channel. The channel returns a struct which
contains message and the consumer from where
+ // the message was received. It's not necessary here since we have 1
single consumer, but the channel could be
+ // shared across multiple consumers as well
+ for cm := range channel {
+ msg := cm.Message
+ fmt.Printf("Received message msgId: %v -- content: '%s'\n",
+ msg.ID(), string(msg.Payload()))
-if err := consumer.Ack(msg); err != nil {
-log.Fatal(err)
-}
-}
+ if err := consumer.Ack(msg); err != nil {
+ log.Fatal(err)
+ }
+ }
}
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index c408386..5250a02 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -22,7 +22,7 @@ import (
"fmt"
"log"
-"github.com/apache/pulsar-client-go/pulsar"
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
[pulsar-client-go] branch master updated: fix: avoid assert panic (#73)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 8a2ff05 fix: avoid assert panic (#73)
8a2ff05 is described below
commit 8a2ff054d85bcbdba433b18639745920bbabc64c
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Thu Oct 24 18:09:44 2019 +0800
fix: avoid assert panic (#73)
- add assert check
Fixes #64
Change-Id: Ibd355440ccf3b06ac60575a9306cfb66cb80d759
---
pulsar/impl_partition_producer.go | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/pulsar/impl_partition_producer.go
b/pulsar/impl_partition_producer.go
index 07e2da0..f09cd42 100644
--- a/pulsar/impl_partition_producer.go
+++ b/pulsar/impl_partition_producer.go
@@ -23,10 +23,11 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/pulsar/internal"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
log "github.com/sirupsen/logrus"
)
@@ -293,7 +294,12 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
+ pi, ok := p.pendingQueue.PeekLast().(*pendingItem)
+ if !ok {
+ fr.waitGroup.Done()
+ return
+ }
+
pi.sendRequests = append(pi.sendRequests, {
msg: nil,
callback: func(id MessageID, message *ProducerMessage, e error)
{
@@ -349,12 +355,14 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
}
func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt) {
- pi := p.pendingQueue.Peek().(*pendingItem)
+ pi, ok := p.pendingQueue.Peek().(*pendingItem)
- if pi == nil {
+ if !ok {
p.log.Warnf("Received ack for %v although the pending queue is
empty", response.GetMessageId())
return
- } else if pi.sequenceID != response.GetSequenceId() {
+ }
+
+ if pi.sequenceID != response.GetSequenceId() {
p.log.Warnf("Received ack for %v on sequenceId %v - expected:
%v", response.GetMessageId(),
response.GetSequenceId(), pi.sequenceID)
return
[GitHub] [pulsar-client-go] wolfstudy closed issue #74: fmt code
wolfstudy closed issue #74: fmt code URL: https://github.com/apache/pulsar-client-go/issues/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy merged pull request #75: [ISSUE #74]refactor: gofmt code
wolfstudy merged pull request #75: [ISSUE #74]refactor: gofmt code URL: https://github.com/apache/pulsar-client-go/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy closed pull request #65: [Issue 64] fix bug: type assert cause panic
wolfstudy closed pull request #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy closed issue #64: producer pending queue peek last with empty queue cause panic
wolfstudy closed issue #64: producer pending queue peek last with empty queue cause panic URL: https://github.com/apache/pulsar-client-go/issues/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy merged pull request #73: [ISSUE #64]fix: avoid assert panic
wolfstudy merged pull request #73: [ISSUE #64]fix: avoid assert panic URL: https://github.com/apache/pulsar-client-go/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] liketic closed pull request #5363: Merge module pulsar-client-tools-test into pulsar-client-tools
liketic closed pull request #5363: Merge module pulsar-client-tools-test into pulsar-client-tools URL: https://github.com/apache/pulsar/pull/5363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] liketic commented on issue #5363: Merge module pulsar-client-tools-test into pulsar-client-tools
liketic commented on issue #5363: Merge module pulsar-client-tools-test into pulsar-client-tools URL: https://github.com/apache/pulsar/pull/5363#issuecomment-545842684 @sijie The purpose is move the test and source code into one module. However, seems I missed the dependency problem which make us separate them. I'll close this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5443: [pulsar-client] Fix message corruption on OOM for batch messages
jiazhai commented on issue #5443: [pulsar-client] Fix message corruption on OOM for batch messages URL: https://github.com/apache/pulsar/pull/5443#issuecomment-545839689 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] liketic commented on a change in pull request #5364: [broker] Fix incorrect log format
liketic commented on a change in pull request #5364: [broker] Fix incorrect log
format
URL: https://github.com/apache/pulsar/pull/5364#discussion_r338480135
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokerStatsBase.java
##
@@ -167,7 +167,7 @@ public LoadManagerReport getLoadReport() throws Exception {
throw new RestException(Status.CONFLICT,
lm.getClass().getName() + " does not support this operation");
}
} catch (Exception e) {
-log.error("Unable to get Resource Availability - [{}]", e);
+log.error("Unable to get Resource Availability", e);
Review comment:
OK. Then shall we change other logs to only print a exception message in
this class ? Such as:
https://github.com/apache/pulsar/blob/ad09efe26afa29cd3a87b90b15e7b722e2beb5c5/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokerStatsBase.java#L67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence
jiazhai commented on issue #5453: [Cpp] Fixed negative ack tracker constructor sequence URL: https://github.com/apache/pulsar/pull/5453#issuecomment-545839018 @merlimat Thanks for the fix. seems [ci](https://builds.apache.org/job/pulsar_precommit_cpp/10208/console) failed with `check-format` ``` -- Build files have been written to: /pulsar/pulsar-client-cpp Scanning dependencies of target check-format clang-format checks failed, run 'make format' to fix CMakeFiles/check-format.dir/build.make:57: recipe for target 'CMakeFiles/check-format' failed ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5456: [integration-tests]Enable messaging tests to integration tests.
jiazhai commented on issue #5456: [integration-tests]Enable messaging tests to integration tests. URL: https://github.com/apache/pulsar/pull/5456#issuecomment-545837696 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5320: Expose metrics of Caffeine caches
sijie commented on issue #5320: Expose metrics of Caffeine caches URL: https://github.com/apache/pulsar/pull/5320#issuecomment-545830380 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5279: Support for python native logging from python wrapper
sijie commented on issue #5279: Support for python native logging from python wrapper URL: https://github.com/apache/pulsar/pull/5279#issuecomment-545826686 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5278: Fixed reader cursor seek with disconnection
sijie commented on issue #5278: Fixed reader cursor seek with disconnection URL: https://github.com/apache/pulsar/pull/5278#issuecomment-545826384 @merlimat If we don't disconnect the consumers, how do consumers reset their state? e.g. pending queue, acknowledgement, and etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
