[GitHub] [pulsar] mattisonchao closed pull request #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class.
mattisonchao closed pull request #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class. URL: https://github.com/apache/pulsar/pull/17323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] congbobo184 opened a new pull request, #17326: [fix][flaky] Fix flaky test testSendTxnAckBatchMessageToDLQ
congbobo184 opened a new pull request, #17326: URL: https://github.com/apache/pulsar/pull/17326 ### Motivation when `redeliveryCount > deadLetterPolicy.getMaxRedeliverCount()`, the batch message can also be received by the client. This test passed before because `removeExpiredMessagesFromQueue` removed messages from `incomingMessages` ### Modification ``` redeliveryCount > deadLetterPolicy.getMaxRedeliverCount() ``` don't invoke `executeNotifyCallback(message);` ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation - [x] `doc-not-needed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17092: [improve][broker]: DelayedDeliveryTracker init and addMessage
coderzc commented on PR #17092: URL: https://github.com/apache/pulsar/pull/17092#issuecomment-1229805180 @Guohaozai, Do you have time to deal with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mans2singh commented on pull request #17312: [fix][standalone] Updated tip section of consume a message
mans2singh commented on PR #17312: URL: https://github.com/apache/pulsar/pull/17312#issuecomment-1229802295 Thanks @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch remove_unsupported_test created (now f0e807c77f3)
This is an automated email from the ASF dual-hosted git repository. mattisonchao pushed a change to branch remove_unsupported_test in repository https://gitbox.apache.org/repos/asf/pulsar.git at f0e807c77f3 [branch-2.9] Remove unsupported test. This branch includes the following new commits: new f0e807c77f3 [branch-2.9] Remove unsupported test. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] 01/01: [branch-2.9] Remove unsupported test.
This is an automated email from the ASF dual-hosted git repository.
mattisonchao pushed a commit to branch remove_unsupported_test
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit f0e807c77f3e59039c850d3dcc3187e987c4e7c9
Author: mattisonchao
AuthorDate: Mon Aug 29 13:38:24 2022 +0800
[branch-2.9] Remove unsupported test.
---
.../org/apache/pulsar/broker/service/ServerCnxTest.java | 17 -
1 file changed, 17 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
index 8edda7761c7..814e81cb399 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
@@ -1962,21 +1962,4 @@ public class ServerCnxTest {
}
}
-@Test
-public void testHandleAuthResponseWithoutClientVersion() {
-ServerCnx cnx = mock(ServerCnx.class, CALLS_REAL_METHODS);
-CommandAuthResponse authResponse = mock(CommandAuthResponse.class);
-org.apache.pulsar.common.api.proto.AuthData authData =
mock(org.apache.pulsar.common.api.proto.AuthData.class);
-when(authResponse.getResponse()).thenReturn(authData);
-when(authResponse.hasResponse()).thenReturn(true);
-when(authResponse.getResponse().hasAuthMethodName()).thenReturn(true);
-when(authResponse.getResponse().hasAuthData()).thenReturn(true);
-when(authResponse.hasClientVersion()).thenReturn(false);
-try {
-cnx.handleAuthResponse(authResponse);
-} catch (Exception ignore) {
-}
-verify(authResponse, times(1)).hasClientVersion();
-verify(authResponse, times(0)).getClientVersion();
-}
}
[GitHub] [pulsar] hsluoyz commented on pull request #17324: [improve][doc] Add casdoor document for administration-pulsar-manager
hsluoyz commented on PR #17324: URL: https://github.com/apache/pulsar/pull/17324#issuecomment-1229801193 @tuteng plz review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] SignorMercurio commented on issue #13453: [Website] generate HTML for Pulsar configuration pages
SignorMercurio commented on issue #13453: URL: https://github.com/apache/pulsar/issues/13453#issuecomment-1229783392 @Anonymitaet The Pulsar Configuration part is finished now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #16672: [improve][broker] Add `keyHashRangeIndex` to distinguish the same hashRanges with the same consumerName
Technoboy- commented on PR #16672: URL: https://github.com/apache/pulsar/pull/16672#issuecomment-1229780922 Decide to add more descriptions for this part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #16672: [improve][broker] Add `keyHashRangeIndex` to distinguish the same hashRanges with the same consumerName
Technoboy- closed pull request #16672: [improve][broker] Add `keyHashRangeIndex` to distinguish the same hashRanges with the same consumerName URL: https://github.com/apache/pulsar/pull/16672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] jakiuncle commented on pull request #17324: [improve][doc] Add casdoor document for administration-pulsar-manager
jakiuncle commented on PR #17324: URL: https://github.com/apache/pulsar/pull/17324#issuecomment-1229778811 - [x ] `doc` (Your PR contains doc changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] jakiuncle commented on pull request #17324: [improve][doc] Add casdoor document for administration-pulsar-manager
jakiuncle commented on PR #17324: URL: https://github.com/apache/pulsar/pull/17324#issuecomment-1229776312 * [x] `doc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc opened a new pull request, #17325: [fix][client-c++] Fix wrong consumers size
coderzc opened a new pull request, #17325: URL: https://github.com/apache/pulsar/pull/17325 Fixes #14848 ### Motivation We should execute `callback` before executing `readerCreatedCallback_`, otherwise, we may get the wrong consumers size. More see: https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/lib/ReaderImpl.cc#L84-L92 ### Modifications execute `callback` before executing `readerCreatedCallback_` ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17324: [improve][doc] Add casdoor document for administration-pulsar-manager
github-actions[bot] commented on PR #17324: URL: https://github.com/apache/pulsar/pull/17324#issuecomment-1229756584 @jakiuncle Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] jakiuncle opened a new pull request, #17324: [improve][doc] Add casdoor document for administration-pulsar-manager
jakiuncle opened a new pull request, #17324: URL: https://github.com/apache/pulsar/pull/17324 Fixes https://github.com/apache/pulsar-manager/pull/446 **Modifications:** Add document for casdoor. 1. How to install casdoor 2. How to use casdoor 3. What we need do in pulsar-manager code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
lhotari commented on PR #17319: URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1229738043 @tisonkun @maxsxu please join the review too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class.
mattisonchao commented on PR #17323: URL: https://github.com/apache/pulsar/pull/17323#issuecomment-1229733386 Looks like we will break the current test environment. So, I close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] youzipi commented on pull request #17275: [cleanup][broker][Modernizer] fix violations in pulsar-broker
youzipi commented on PR #17275: URL: https://github.com/apache/pulsar/pull/17275#issuecomment-1229733567 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class.
mattisonchao closed pull request #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class. URL: https://github.com/apache/pulsar/pull/17323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch branch-2.9 updated (7317c84421e -> 6e8b04149ac)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 7317c84421e [fix][client] Fix reach redeliverCount client can't send batch messages to DLQ (#17317) new 7527005672f [package management service] check service status before run commands (#12847) new 6e8b04149ac [improve][functions][admin] Improve the package download process (#16365) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/pulsar/broker/PulsarService.java| 12 ++- .../pulsar/broker/admin/impl/PackagesBase.java | 4 + .../apache/pulsar/broker/admin/v3/Packages.java| 21 +++-- .../broker/admin/v3/PackagesApiNotEnabledTest.java | 104 + .../pulsar/broker/admin/v3/PackagesApiTest.java| 21 - .../pulsar/client/admin/internal/PackagesImpl.java | 98 ++- 6 files changed, 224 insertions(+), 36 deletions(-) create mode 100644 pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
[GitHub] [pulsar] codelipenghui commented on pull request #12847: [package management service] check service status before run commands
codelipenghui commented on PR #12847: URL: https://github.com/apache/pulsar/pull/12847#issuecomment-1229721204 Depends by https://github.com/apache/pulsar/pull/16365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] 01/02: [package management service] check service status before run commands (#12847)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 7527005672fa0d7e3306edafaf7ac717811edc22
Author: Rui Fu
AuthorDate: Fri Nov 19 22:58:31 2021 +0800
[package management service] check service status before run commands
(#12847)
### Motivation
`pulsar-admin` runs packages management services commands, but if the
broker is not enabled the service, it will throw NPE.
The root cause is
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java#L45-L47,
the `PackagesManagement` might be null if the service is not enabled.
### Modifications
Check `isEnablePackagesManagement` before each internal request.
(cherry picked from commit 747bf2175f7dabe71f90426c2771b505c5983010)
---
.../org/apache/pulsar/broker/PulsarService.java| 12 ++-
.../pulsar/broker/admin/impl/PackagesBase.java | 4 +
.../apache/pulsar/broker/admin/v3/Packages.java| 21 +++--
.../broker/admin/v3/PackagesApiNotEnabledTest.java | 91 ++
.../pulsar/broker/admin/v3/PackagesApiTest.java| 3 +
5 files changed, 121 insertions(+), 10 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
index 9211a4efa45..e47bd1bc783 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
@@ -247,7 +247,7 @@ public class PulsarService implements AutoCloseable,
ShutdownService {
private AdditionalServlets brokerAdditionalServlets;
// packages management service
-private PackagesManagement packagesManagement;
+private Optional packagesManagement = Optional.empty();
private PrometheusMetricsServlet metricsServlet;
private List pendingMetricsProviders;
@@ -1593,16 +1593,22 @@ public class PulsarService implements AutoCloseable,
ShutdownService {
}
}
+public PackagesManagement getPackagesManagement() throws
UnsupportedOperationException {
+return packagesManagement.orElseThrow(() -> new
UnsupportedOperationException("Package Management Service "
++ "is not enabled in the broker."));
+}
+
private void startPackagesManagementService() throws IOException {
// TODO: using provider to initialize the packages management service.
-this.packagesManagement = new PackagesManagementImpl();
+PackagesManagement packagesManagementService = new
PackagesManagementImpl();
+this.packagesManagement = Optional.of(packagesManagementService);
PackagesStorageProvider storageProvider = PackagesStorageProvider
.newProvider(config.getPackagesManagementStorageProvider());
DefaultPackagesStorageConfiguration storageConfiguration = new
DefaultPackagesStorageConfiguration();
storageConfiguration.setProperty(config.getProperties());
PackagesStorage storage =
storageProvider.getStorage(storageConfiguration);
storage.initialize();
-packagesManagement.initialize(storage);
+packagesManagementService.initialize(storage);
}
public Optional getListenPortHTTP() {
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java
index ccb611d066d..8a8dcd9f03b 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PackagesBase.java
@@ -65,6 +65,8 @@ public class PackagesBase extends AdminResource {
asyncResponse.resume(new RestException(Response.Status.NOT_FOUND,
throwable.getMessage()));
} else if (throwable instanceof WebApplicationException) {
asyncResponse.resume(throwable);
+} else if (throwable instanceof UnsupportedOperationException) {
+asyncResponse.resume(new
RestException(Response.Status.SERVICE_UNAVAILABLE, throwable.getMessage()));
} else {
log.error("Encountered unexpected error", throwable);
asyncResponse.resume(new
RestException(Response.Status.INTERNAL_SERVER_ERROR, throwable.getMessage()));
@@ -116,6 +118,8 @@ public class PackagesBase extends AdminResource {
} else {
throw new
RestException(Response.Status.INTERNAL_SERVER_ERROR, e.getCause().getMessage());
}
+} catch (UnsupportedOperationException e) {
+throw new
RestException(Response.Status.SERVICE_UNAVAILABLE, e.getMessage());
}
};
} catch
[pulsar] 02/02: [improve][functions][admin] Improve the package download process (#16365)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 6e8b04149ac3c5e86dc7c1d56f65a31db6c69dc1
Author: Yong Zhang
AuthorDate: Thu Aug 11 11:05:44 2022 +0800
[improve][functions][admin] Improve the package download process (#16365)
* Improve the package download process
---
*Motivation*
Improve the package download process to handle the download
body more efficient.
(cherry picked from commit 1fe8c06ce37092e37de3562651c56d3d6bb1b91a)
---
.../broker/admin/v3/PackagesApiNotEnabledTest.java | 17 +++-
.../pulsar/broker/admin/v3/PackagesApiTest.java| 18 +++-
.../pulsar/client/admin/internal/PackagesImpl.java | 98 --
3 files changed, 105 insertions(+), 28 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
index 4eb1e528d0d..becddb173b2 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
@@ -20,6 +20,10 @@ package org.apache.pulsar.broker.admin.v3;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.fail;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Comparator;
import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.packages.management.core.common.PackageMetadata;
@@ -45,14 +49,23 @@ public class PackagesApiNotEnabledTest extends
MockedPulsarServiceBaseTest {
}
@Test(timeOut = 6)
-public void testPackagesOperationsWithoutPackagesServiceEnabled() {
+public void testPackagesOperationsWithoutPackagesServiceEnabled() throws
Exception {
// download package api should return 503 Service Unavailable exception
String unknownPackageName = "function://public/default/unknown@v1";
+Path tmp = Files.createTempDirectory("package-test-tmp");
try {
-admin.packages().download(unknownPackageName, "/test/unknown");
+admin.packages().download(unknownPackageName,
tmp.toAbsolutePath().toString() + "/unknown");
fail("should throw 503 error");
} catch (PulsarAdminException e) {
assertEquals(503, e.getStatusCode());
+} finally {
+Files.walk(tmp).sorted(Comparator.reverseOrder()).forEach(p -> {
+try {
+Files.delete(p);
+} catch (IOException e) {
+throw new RuntimeException(e);
+}
+});
}
// get metadata api should return 503 Service Unavailable exception
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
index c38594478aa..79efb42f63c 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
@@ -32,7 +32,11 @@ import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
import java.util.Collections;
+import java.util.Comparator;
import java.util.List;
@Test(groups = "broker")
@@ -101,14 +105,24 @@ public class PackagesApiTest extends
MockedPulsarServiceBaseTest {
}
@Test(timeOut = 6)
-public void testPackagesOperationsFailed() {
+public void testPackagesOperationsFailed() throws IOException {
// download a non-existent package should return not found exception
String unknownPackageName = "function://public/default/unknown@v1";
+
+Path tmp = Files.createTempDirectory("package-test-tmp");
try {
-admin.packages().download(unknownPackageName, "/test/unknown");
+admin.packages().download(unknownPackageName, tmp.toAbsolutePath()
+ "/unknown");
fail("should throw 404 error");
} catch (PulsarAdminException e) {
assertEquals(404, e.getStatusCode());
+} finally {
+Files.walk(tmp).sorted(Comparator.reverseOrder()).forEach(p -> {
+try {
+Files.delete(p);
+} catch (IOException e) {
+throw new RuntimeException(e);
+}
+});
}
// get the metadata of a non-existent package should return not found
exception
diff --git
[pulsar] branch branch-2.10 updated: [improve][functions][admin] Improve the package download process (#16365)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new 003122ce8a3 [improve][functions][admin] Improve the package download
process (#16365)
003122ce8a3 is described below
commit 003122ce8a3966579e37b896214aba92d114263c
Author: Yong Zhang
AuthorDate: Thu Aug 11 11:05:44 2022 +0800
[improve][functions][admin] Improve the package download process (#16365)
* Improve the package download process
---
*Motivation*
Improve the package download process to handle the download
body more efficient.
(cherry picked from commit 1fe8c06ce37092e37de3562651c56d3d6bb1b91a)
---
.../broker/admin/v3/PackagesApiNotEnabledTest.java | 17 +++-
.../pulsar/broker/admin/v3/PackagesApiTest.java| 18 +++-
.../pulsar/client/admin/internal/PackagesImpl.java | 98 --
3 files changed, 105 insertions(+), 28 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
index 3fd39d30d2d..2c39fbbaf8d 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiNotEnabledTest.java
@@ -20,6 +20,10 @@ package org.apache.pulsar.broker.admin.v3;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.fail;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Comparator;
import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.packages.management.core.common.PackageMetadata;
@@ -45,14 +49,23 @@ public class PackagesApiNotEnabledTest extends
MockedPulsarServiceBaseTest {
}
@Test(timeOut = 6)
-public void testPackagesOperationsWithoutPackagesServiceEnabled() {
+public void testPackagesOperationsWithoutPackagesServiceEnabled() throws
Exception {
// download package api should return 503 Service Unavailable exception
String unknownPackageName = "function://public/default/unknown@v1";
+Path tmp = Files.createTempDirectory("package-test-tmp");
try {
-admin.packages().download(unknownPackageName, "/test/unknown");
+admin.packages().download(unknownPackageName,
tmp.toAbsolutePath().toString() + "/unknown");
fail("should throw 503 error");
} catch (PulsarAdminException e) {
assertEquals(503, e.getStatusCode());
+} finally {
+Files.walk(tmp).sorted(Comparator.reverseOrder()).forEach(p -> {
+try {
+Files.delete(p);
+} catch (IOException e) {
+throw new RuntimeException(e);
+}
+});
}
// get metadata api should return 503 Service Unavailable exception
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
index 69331c02c7d..dd082681b23 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/PackagesApiTest.java
@@ -32,7 +32,11 @@ import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
import java.util.Collections;
+import java.util.Comparator;
import java.util.List;
@Test(groups = "broker-admin")
@@ -101,14 +105,24 @@ public class PackagesApiTest extends
MockedPulsarServiceBaseTest {
}
@Test(timeOut = 6)
-public void testPackagesOperationsFailed() {
+public void testPackagesOperationsFailed() throws IOException {
// download a non-existent package should return not found exception
String unknownPackageName = "function://public/default/unknown@v1";
+
+Path tmp = Files.createTempDirectory("package-test-tmp");
try {
-admin.packages().download(unknownPackageName, "/test/unknown");
+admin.packages().download(unknownPackageName, tmp.toAbsolutePath()
+ "/unknown");
fail("should throw 404 error");
} catch (PulsarAdminException e) {
assertEquals(404, e.getStatusCode());
+} finally {
+Files.walk(tmp).sorted(Comparator.reverseOrder()).forEach(p -> {
+try {
+Files.delete(p);
+} catch (IOException e) {
+throw
[GitHub] [pulsar] coderzc commented on issue #14848: Flaky-test: C++ ClientTest.testReferenceCount
coderzc commented on issue #14848: URL: https://github.com/apache/pulsar/issues/14848#issuecomment-1229717680 +1 https://github.com/apache/pulsar/runs/8062672745?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao opened a new pull request, #17323: [Branch-2.9] Add `Mockito-inline` to help mock final class.
mattisonchao opened a new pull request, #17323: URL: https://github.com/apache/pulsar/pull/17323 ### Motivation The branch-2.9 test is broken. see error. ``` Error: Tests run: 75, Failures: 30, Errors: 0, Skipped: 31, Time elapsed: 5.748 s <<< FAILURE! - in org.apache.pulsar.broker.service.ServerCnxTest Error: testHandleAuthResponseWithoutClientVersion(org.apache.pulsar.broker.service.ServerCnxTest) Time elapsed: 0.007 s <<< FAILURE! org.mockito.exceptions.base.MockitoException: Cannot mock/spy class org.apache.pulsar.common.api.proto.CommandAuthResponse Mockito cannot mock/spy because : - final class at org.apache.pulsar.broker.service.ServerCnxTest.testHandleAuthResponseWithoutClientVersion(ServerCnxTest.java:1968) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45) at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73) at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) ``` We can add the `Mockito-inline` dependency to help mock the final class. ### Modifications Add `Mockito-inline` dependency. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch branch-2.10 updated: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe (#17291)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new a7b277254ae [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
(#17291)
a7b277254ae is described below
commit a7b277254aef7ed7c32f5c57482a10413617bc60
Author: Yan Zhao
AuthorDate: Mon Aug 29 11:23:02 2022 +0800
[Branch-2.10] [fix] [broker] Fix bookeeper packages npe (#17291)
---
conf/standalone.conf | 20 +
.../org/apache/pulsar/PulsarStandaloneBuilder.java | 7 --
.../org/apache/pulsar/PulsarStandaloneStarter.java | 8 +--
.../common/conf/InternalConfigurationData.java | 26 +++---
.../functions/worker/PulsarWorkerService.java | 13 ++-
.../pulsar/functions/worker/WorkerUtils.java | 3 ++-
.../bookkeeper/BookKeeperPackagesStorage.java | 13 ---
.../BookKeeperPackagesStorageConfiguration.java| 4
.../bookkeeper/BookKeeperPackagesStorageTest.java | 8 +++
9 files changed, 68 insertions(+), 34 deletions(-)
diff --git a/conf/standalone.conf b/conf/standalone.conf
index 5f90ea1ce3f..8eb25a2aa65 100644
--- a/conf/standalone.conf
+++ b/conf/standalone.conf
@@ -19,11 +19,15 @@
### --- General broker settings --- ###
-# Zookeeper quorum connection string
-zookeeperServers=
+# The metadata store URL
+# Examples:
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181
+# * my-zk-1:2181,my-zk-2:2181,my-zk-3:2181 (will default to ZooKeeper when the
schema is not specified)
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181/my-chroot-path (to add a ZK
chroot path)
+metadataStoreUrl=
-# Configuration Store connection string
-configurationStoreServers=
+# The metadata store URL for the configuration data. If empty, we fall back to
use metadataStoreUrl
+configurationMetadataStoreUrl=
brokerServicePort=6650
@@ -1087,3 +1091,11 @@ zooKeeperOperationTimeoutSeconds=-1
# ZooKeeper cache expiry time in seconds
# Deprecated: use metadataStoreCacheExpirySeconds
zooKeeperCacheExpirySeconds=-1
+
+# Zookeeper quorum connection string
+# Deprecated: use metadataStoreUrl
+zookeeperServers=
+
+# Configuration Store connection string
+# Deprecated: use configurationMetadataStoreUrl
+configurationStoreServers=
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
index 581db63bb0e..70d457dbb46 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
@@ -21,6 +21,7 @@ package org.apache.pulsar;
import static org.apache.commons.lang3.StringUtils.isBlank;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.ServiceConfigurationUtils;
+import org.apache.pulsar.metadata.impl.ZKMetadataStore;
public final class PulsarStandaloneBuilder {
@@ -114,8 +115,10 @@ public final class PulsarStandaloneBuilder {
}
// Set ZK server's host to localhost
-pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" +
pulsarStandalone.getZkPort());
-pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers +
":" + pulsarStandalone.getZkPort());
+final String metadataStoreUrl =
+ZKMetadataStore.ZK_SCHEME_IDENTIFIER + zkServers + ":" +
pulsarStandalone.getZkPort();
+pulsarStandalone.getConfig().setMetadataStoreUrl(metadataStoreUrl);
+
pulsarStandalone.getConfig().setConfigurationMetadataStoreUrl(metadataStoreUrl);
pulsarStandalone.getConfig().setRunningStandalone(true);
return pulsarStandalone;
}
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
index 92b3e3e64ee..b8ec534b893 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
@@ -28,6 +28,7 @@ import org.apache.logging.log4j.LogManager;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.common.configuration.PulsarConfigurationLoader;
import org.apache.pulsar.common.util.CmdGenerateDocs;
+import org.apache.pulsar.metadata.impl.ZKMetadataStore;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -100,8 +101,11 @@ public class PulsarStandaloneStarter extends
PulsarStandalone {
}
}
}
-config.setZookeeperServers(zkServers + ":" + this.getZkPort());
-config.setConfigurationStoreServers(zkServers + ":" +
this.getZkPort());
+
+final String metadataStoreUrl =
+
[GitHub] [pulsar] Technoboy- merged pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Technoboy- merged PR #17291: URL: https://github.com/apache/pulsar/pull/17291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] 01/01: [Branch-2.9] Add `Mockito-inline` to help mock final class.
This is an automated email from the ASF dual-hosted git repository.
mattisonchao pushed a commit to branch add_mockito_inline
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit b2456e897da0a2315d4c7108a4e29b700d59ccf7
Author: mattisonchao
AuthorDate: Mon Aug 29 11:19:47 2022 +0800
[Branch-2.9] Add `Mockito-inline` to help mock final class.
---
pom.xml | 12
1 file changed, 12 insertions(+)
diff --git a/pom.xml b/pom.xml
index 4ea7ccd..07c2059ec48 100644
--- a/pom.xml
+++ b/pom.xml
@@ -317,6 +317,12 @@ flexible messaging model and an intuitive client
API.
${mockito.version}
+
+org.mockito
+mockito-inline
+${mockito.version}
+
+
org.powermock
powermock-api-mockito2
@@ -1278,6 +1284,12 @@ flexible messaging model and an intuitive client
API.
test
+
+ org.mockito
+ mockito-inline
+ test
+
+
org.powermock
powermock-api-mockito2
[pulsar] branch add_mockito_inline created (now b2456e897da)
This is an automated email from the ASF dual-hosted git repository. mattisonchao pushed a change to branch add_mockito_inline in repository https://gitbox.apache.org/repos/asf/pulsar.git at b2456e897da [Branch-2.9] Add `Mockito-inline` to help mock final class. This branch includes the following new commits: new b2456e897da [Branch-2.9] Add `Mockito-inline` to help mock final class. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [pulsar] poorbarcode opened a new pull request, #17322: [improve][schema]autoSkipNonRecoverableData work for schema Ledger
poorbarcode opened a new pull request, #17322: URL: https://github.com/apache/pulsar/pull/17322 Fixes #17221 Master Issue: #17221 ### Modifications If data that cannot be recovered is found, triggers meta-data clearing ### Documentation - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #13453: [Website] generate HTML for Pulsar configuration pages
Anonymitaet commented on issue #13453: URL: https://github.com/apache/pulsar/issues/13453#issuecomment-1229698060 @SignorMercurio we have not completely finished it, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17198: [feature][doc] Generate client config docs from source code
Anonymitaet commented on PR #17198: URL: https://github.com/apache/pulsar/pull/17198#issuecomment-1229695061 @Technoboy- Could you please review this PR from the technical perspective? Thank you!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] urfreespace commented on a diff in pull request #17198: [feature][doc] Generate client config docs from source code
urfreespace commented on code in PR #17198: URL: https://github.com/apache/pulsar/pull/17198#discussion_r956855426 ## pulsar-client/pom.xml: ## @@ -182,6 +182,12 @@ awaitility test + + org.apache.pulsar + pulsar-broker-common + 2.11.0-SNAPSHOT Review Comment: OK, I see now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #17153: [feature][broker] Allow to configure the entry filters per namespace and per topic
gaozhangmin commented on PR #17153: URL: https://github.com/apache/pulsar/pull/17153#issuecomment-1229691953 @eolivelli I will add a configuration parameter in case of the overridden -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Nicklee007 commented on pull request #17276: [fix][broker]Fix memoryLimitController currentUsage and MaxQueueSize semaphore leak when batchMessageContainer add message exception
Nicklee007 commented on PR #17276: URL: https://github.com/apache/pulsar/pull/17276#issuecomment-1229691139 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] urfreespace merged pull request #17197: [fix][doc] Migrate config docs to pulsar-site
urfreespace merged PR #17197: URL: https://github.com/apache/pulsar/pull/17197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (ee7bfb5a1f2 -> ac640d98b17)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from ee7bfb5a1f2 [fix][standalone] Updated tip section of consume a message (#17312) add ac640d98b17 [fix][doc] Migrate config docs to pulsar-site (#17197) No new revisions were added by this update. Summary of changes: .../pulsar/broker/BaseGenerateDocumentation.java |6 +- site2/docs/reference-configuration-broker.md | 3904 site2/docs/reference-configuration-client.md | 229 -- site2/docs/reference-configuration-pulsar-proxy.md | 940 - site2/docs/reference-configuration-standalone.md | 1465 site2/docs/reference-configuration-websocket.md| 501 --- site2/docs/reference-configuration.md | 12 +- site2/tools/generate-config-docs.sh| 35 - site2/website/sidebars.json| 20 +- 9 files changed, 4 insertions(+), 7108 deletions(-) delete mode 100644 site2/docs/reference-configuration-broker.md delete mode 100644 site2/docs/reference-configuration-client.md delete mode 100644 site2/docs/reference-configuration-pulsar-proxy.md delete mode 100644 site2/docs/reference-configuration-standalone.md delete mode 100644 site2/docs/reference-configuration-websocket.md delete mode 100755 site2/tools/generate-config-docs.sh
[GitHub] [pulsar] RobertIndie commented on issue #17298: [Doc] Fix the example for metadata store with etcd
RobertIndie commented on issue #17298: URL: https://github.com/apache/pulsar/issues/17298#issuecomment-1229684578 > Hi @sijie , > > I'm interested in updating this doc could you please assign this to me. > > TIA, Pradhyumna K R Thanks. I have assigned it to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-test-infra] branch dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1 updated (414d66c -> e8e132f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git discard 414d66c Bump @actions/core from 1.2.4 to 1.9.1 in /paths-filter add 306a9f0 Remove unused legacy docbot (#60) add e8e132f Bump @actions/core from 1.2.4 to 1.9.1 in /paths-filter This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (414d66c) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1 (e8e132f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: doc-label-check/.eslintignore | 4 - doc-label-check/.eslintrc.js |28 - doc-label-check/.gitignore | 4 - doc-label-check/.prettierignore| 5 - doc-label-check/.prettierrc.js | 8 - doc-label-check/README.md | 122 - doc-label-check/__tests__/files.test.ts|30 - doc-label-check/__tests__/labels.test.ts |40 - doc-label-check/__tests__/logger.test.ts |43 - doc-label-check/__tests__/patterns.test.ts |76 - doc-label-check/__tests__/readme.test.ts |33 - doc-label-check/__tests__/utils.test.ts| 127 - doc-label-check/action.yml |37 - doc-label-check/dist/index.js | 10601 --- doc-label-check/jest.config.js |11 - doc-label-check/package-lock.json | 6350 doc-label-check/package.json |34 - doc-label-check/src/enums.ts |10 - doc-label-check/src/labels.ts |65 - doc-label-check/src/logger.ts |29 - doc-label-check/src/main.ts| 245 - doc-label-check/src/patterns.ts| 5 - doc-label-check/src/types.ts |40 - doc-label-check/src/utils.ts | 146 - doc-label-check/tsconfig.json |12 - 25 files changed, 18105 deletions(-) delete mode 100644 doc-label-check/.eslintignore delete mode 100644 doc-label-check/.eslintrc.js delete mode 100644 doc-label-check/.gitignore delete mode 100644 doc-label-check/.prettierignore delete mode 100644 doc-label-check/.prettierrc.js delete mode 100644 doc-label-check/README.md delete mode 100644 doc-label-check/__tests__/files.test.ts delete mode 100644 doc-label-check/__tests__/labels.test.ts delete mode 100644 doc-label-check/__tests__/logger.test.ts delete mode 100644 doc-label-check/__tests__/patterns.test.ts delete mode 100644 doc-label-check/__tests__/readme.test.ts delete mode 100644 doc-label-check/__tests__/utils.test.ts delete mode 100644 doc-label-check/action.yml delete mode 100644 doc-label-check/dist/index.js delete mode 100644 doc-label-check/jest.config.js delete mode 100644 doc-label-check/package-lock.json delete mode 100644 doc-label-check/package.json delete mode 100644 doc-label-check/src/enums.ts delete mode 100644 doc-label-check/src/labels.ts delete mode 100644 doc-label-check/src/logger.ts delete mode 100644 doc-label-check/src/main.ts delete mode 100644 doc-label-check/src/patterns.ts delete mode 100644 doc-label-check/src/types.ts delete mode 100644 doc-label-check/src/utils.ts delete mode 100644 doc-label-check/tsconfig.json
[pulsar-test-infra] branch dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1 updated (71fe82b -> 7ccd350)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git discard 71fe82b Bump @actions/core from 1.2.6 to 1.9.1 in /test-reporter add 306a9f0 Remove unused legacy docbot (#60) add 7ccd350 Bump @actions/core from 1.2.6 to 1.9.1 in /test-reporter This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (71fe82b) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1 (7ccd350) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: doc-label-check/.eslintignore | 4 - doc-label-check/.eslintrc.js |28 - doc-label-check/.gitignore | 4 - doc-label-check/.prettierignore| 5 - doc-label-check/.prettierrc.js | 8 - doc-label-check/README.md | 122 - doc-label-check/__tests__/files.test.ts|30 - doc-label-check/__tests__/labels.test.ts |40 - doc-label-check/__tests__/logger.test.ts |43 - doc-label-check/__tests__/patterns.test.ts |76 - doc-label-check/__tests__/readme.test.ts |33 - doc-label-check/__tests__/utils.test.ts| 127 - doc-label-check/action.yml |37 - doc-label-check/dist/index.js | 10601 --- doc-label-check/jest.config.js |11 - doc-label-check/package-lock.json | 6350 doc-label-check/package.json |34 - doc-label-check/src/enums.ts |10 - doc-label-check/src/labels.ts |65 - doc-label-check/src/logger.ts |29 - doc-label-check/src/main.ts| 245 - doc-label-check/src/patterns.ts| 5 - doc-label-check/src/types.ts |40 - doc-label-check/src/utils.ts | 146 - doc-label-check/tsconfig.json |12 - 25 files changed, 18105 deletions(-) delete mode 100644 doc-label-check/.eslintignore delete mode 100644 doc-label-check/.eslintrc.js delete mode 100644 doc-label-check/.gitignore delete mode 100644 doc-label-check/.prettierignore delete mode 100644 doc-label-check/.prettierrc.js delete mode 100644 doc-label-check/README.md delete mode 100644 doc-label-check/__tests__/files.test.ts delete mode 100644 doc-label-check/__tests__/labels.test.ts delete mode 100644 doc-label-check/__tests__/logger.test.ts delete mode 100644 doc-label-check/__tests__/patterns.test.ts delete mode 100644 doc-label-check/__tests__/readme.test.ts delete mode 100644 doc-label-check/__tests__/utils.test.ts delete mode 100644 doc-label-check/action.yml delete mode 100644 doc-label-check/dist/index.js delete mode 100644 doc-label-check/jest.config.js delete mode 100644 doc-label-check/package-lock.json delete mode 100644 doc-label-check/package.json delete mode 100644 doc-label-check/src/enums.ts delete mode 100644 doc-label-check/src/labels.ts delete mode 100644 doc-label-check/src/logger.ts delete mode 100644 doc-label-check/src/main.ts delete mode 100644 doc-label-check/src/patterns.ts delete mode 100644 doc-label-check/src/types.ts delete mode 100644 doc-label-check/src/utils.ts delete mode 100644 doc-label-check/tsconfig.json
[pulsar-test-infra] branch dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1 updated (491a9e5 -> be92d51)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git discard 491a9e5 Bump @actions/core from 1.2.6 to 1.9.1 in /setup-maven add 306a9f0 Remove unused legacy docbot (#60) add be92d51 Bump @actions/core from 1.2.6 to 1.9.1 in /setup-maven This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (491a9e5) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1 (be92d51) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: doc-label-check/.eslintignore | 4 - doc-label-check/.eslintrc.js |28 - doc-label-check/.gitignore | 4 - doc-label-check/.prettierignore| 5 - doc-label-check/.prettierrc.js | 8 - doc-label-check/README.md | 122 - doc-label-check/__tests__/files.test.ts|30 - doc-label-check/__tests__/labels.test.ts |40 - doc-label-check/__tests__/logger.test.ts |43 - doc-label-check/__tests__/patterns.test.ts |76 - doc-label-check/__tests__/readme.test.ts |33 - doc-label-check/__tests__/utils.test.ts| 127 - doc-label-check/action.yml |37 - doc-label-check/dist/index.js | 10601 --- doc-label-check/jest.config.js |11 - doc-label-check/package-lock.json | 6350 doc-label-check/package.json |34 - doc-label-check/src/enums.ts |10 - doc-label-check/src/labels.ts |65 - doc-label-check/src/logger.ts |29 - doc-label-check/src/main.ts| 245 - doc-label-check/src/patterns.ts| 5 - doc-label-check/src/types.ts |40 - doc-label-check/src/utils.ts | 146 - doc-label-check/tsconfig.json |12 - 25 files changed, 18105 deletions(-) delete mode 100644 doc-label-check/.eslintignore delete mode 100644 doc-label-check/.eslintrc.js delete mode 100644 doc-label-check/.gitignore delete mode 100644 doc-label-check/.prettierignore delete mode 100644 doc-label-check/.prettierrc.js delete mode 100644 doc-label-check/README.md delete mode 100644 doc-label-check/__tests__/files.test.ts delete mode 100644 doc-label-check/__tests__/labels.test.ts delete mode 100644 doc-label-check/__tests__/logger.test.ts delete mode 100644 doc-label-check/__tests__/patterns.test.ts delete mode 100644 doc-label-check/__tests__/readme.test.ts delete mode 100644 doc-label-check/__tests__/utils.test.ts delete mode 100644 doc-label-check/action.yml delete mode 100644 doc-label-check/dist/index.js delete mode 100644 doc-label-check/jest.config.js delete mode 100644 doc-label-check/package-lock.json delete mode 100644 doc-label-check/package.json delete mode 100644 doc-label-check/src/enums.ts delete mode 100644 doc-label-check/src/labels.ts delete mode 100644 doc-label-check/src/logger.ts delete mode 100644 doc-label-check/src/main.ts delete mode 100644 doc-label-check/src/patterns.ts delete mode 100644 doc-label-check/src/types.ts delete mode 100644 doc-label-check/src/utils.ts delete mode 100644 doc-label-check/tsconfig.json
[pulsar-test-infra] branch dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 updated (8997f67 -> 4ec51af)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git discard 8997f67 Bump @actions/core from 1.6.0 to 1.9.1 in /gh-actions-artifact-client add 306a9f0 Remove unused legacy docbot (#60) add 4ec51af Bump @actions/core from 1.6.0 to 1.9.1 in /gh-actions-artifact-client This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (8997f67) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 (4ec51af) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: doc-label-check/.eslintignore | 4 - doc-label-check/.eslintrc.js |28 - doc-label-check/.gitignore | 4 - doc-label-check/.prettierignore| 5 - doc-label-check/.prettierrc.js | 8 - doc-label-check/README.md | 122 - doc-label-check/__tests__/files.test.ts|30 - doc-label-check/__tests__/labels.test.ts |40 - doc-label-check/__tests__/logger.test.ts |43 - doc-label-check/__tests__/patterns.test.ts |76 - doc-label-check/__tests__/readme.test.ts |33 - doc-label-check/__tests__/utils.test.ts| 127 - doc-label-check/action.yml |37 - doc-label-check/dist/index.js | 10601 --- doc-label-check/jest.config.js |11 - doc-label-check/package-lock.json | 6350 doc-label-check/package.json |34 - doc-label-check/src/enums.ts |10 - doc-label-check/src/labels.ts |65 - doc-label-check/src/logger.ts |29 - doc-label-check/src/main.ts| 245 - doc-label-check/src/patterns.ts| 5 - doc-label-check/src/types.ts |40 - doc-label-check/src/utils.ts | 146 - doc-label-check/tsconfig.json |12 - 25 files changed, 18105 deletions(-) delete mode 100644 doc-label-check/.eslintignore delete mode 100644 doc-label-check/.eslintrc.js delete mode 100644 doc-label-check/.gitignore delete mode 100644 doc-label-check/.prettierignore delete mode 100644 doc-label-check/.prettierrc.js delete mode 100644 doc-label-check/README.md delete mode 100644 doc-label-check/__tests__/files.test.ts delete mode 100644 doc-label-check/__tests__/labels.test.ts delete mode 100644 doc-label-check/__tests__/logger.test.ts delete mode 100644 doc-label-check/__tests__/patterns.test.ts delete mode 100644 doc-label-check/__tests__/readme.test.ts delete mode 100644 doc-label-check/__tests__/utils.test.ts delete mode 100644 doc-label-check/action.yml delete mode 100644 doc-label-check/dist/index.js delete mode 100644 doc-label-check/jest.config.js delete mode 100644 doc-label-check/package-lock.json delete mode 100644 doc-label-check/package.json delete mode 100644 doc-label-check/src/enums.ts delete mode 100644 doc-label-check/src/labels.ts delete mode 100644 doc-label-check/src/logger.ts delete mode 100644 doc-label-check/src/main.ts delete mode 100644 doc-label-check/src/patterns.ts delete mode 100644 doc-label-check/src/types.ts delete mode 100644 doc-label-check/src/utils.ts delete mode 100644 doc-label-check/tsconfig.json
[pulsar-test-infra] branch dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1 updated (c52f963 -> 3f8fbf2)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git discard c52f963 Bump @actions/core from 1.6.0 to 1.9.1 in /http-cache-action add 306a9f0 Remove unused legacy docbot (#60) add 3f8fbf2 Bump @actions/core from 1.6.0 to 1.9.1 in /http-cache-action This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c52f963) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1 (3f8fbf2) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: doc-label-check/.eslintignore | 4 - doc-label-check/.eslintrc.js |28 - doc-label-check/.gitignore | 4 - doc-label-check/.prettierignore| 5 - doc-label-check/.prettierrc.js | 8 - doc-label-check/README.md | 122 - doc-label-check/__tests__/files.test.ts|30 - doc-label-check/__tests__/labels.test.ts |40 - doc-label-check/__tests__/logger.test.ts |43 - doc-label-check/__tests__/patterns.test.ts |76 - doc-label-check/__tests__/readme.test.ts |33 - doc-label-check/__tests__/utils.test.ts| 127 - doc-label-check/action.yml |37 - doc-label-check/dist/index.js | 10601 --- doc-label-check/jest.config.js |11 - doc-label-check/package-lock.json | 6350 doc-label-check/package.json |34 - doc-label-check/src/enums.ts |10 - doc-label-check/src/labels.ts |65 - doc-label-check/src/logger.ts |29 - doc-label-check/src/main.ts| 245 - doc-label-check/src/patterns.ts| 5 - doc-label-check/src/types.ts |40 - doc-label-check/src/utils.ts | 146 - doc-label-check/tsconfig.json |12 - 25 files changed, 18105 deletions(-) delete mode 100644 doc-label-check/.eslintignore delete mode 100644 doc-label-check/.eslintrc.js delete mode 100644 doc-label-check/.gitignore delete mode 100644 doc-label-check/.prettierignore delete mode 100644 doc-label-check/.prettierrc.js delete mode 100644 doc-label-check/README.md delete mode 100644 doc-label-check/__tests__/files.test.ts delete mode 100644 doc-label-check/__tests__/labels.test.ts delete mode 100644 doc-label-check/__tests__/logger.test.ts delete mode 100644 doc-label-check/__tests__/patterns.test.ts delete mode 100644 doc-label-check/__tests__/readme.test.ts delete mode 100644 doc-label-check/__tests__/utils.test.ts delete mode 100644 doc-label-check/action.yml delete mode 100644 doc-label-check/dist/index.js delete mode 100644 doc-label-check/jest.config.js delete mode 100644 doc-label-check/package-lock.json delete mode 100644 doc-label-check/package.json delete mode 100644 doc-label-check/src/enums.ts delete mode 100644 doc-label-check/src/labels.ts delete mode 100644 doc-label-check/src/logger.ts delete mode 100644 doc-label-check/src/main.ts delete mode 100644 doc-label-check/src/patterns.ts delete mode 100644 doc-label-check/src/types.ts delete mode 100644 doc-label-check/src/utils.ts delete mode 100644 doc-label-check/tsconfig.json
[GitHub] [pulsar] Pradhyumnakashyap commented on issue #17298: [Doc] Fix the example for metadata store with etcd
Pradhyumnakashyap commented on issue #17298: URL: https://github.com/apache/pulsar/issues/17298#issuecomment-1229683882 Hi @sijie , I'm interested in updating this doc could you please assign this to me. TIA, Pradhyumna K R -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on issue #17311: 执行mvn clean install -DskipTests报错
nodece commented on issue #17311: URL: https://github.com/apache/pulsar/issues/17311#issuecomment-1229683520 The root cause is `broker.keystore.jks` not found, the Maven can copy this resource, but the IDEA cannot. Please run the `mvn clean install -DskipTests=true` first, and then run your test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16557: [PIP-169] Support split bundle by flow or qps
lordcheng10 commented on PR #16557: URL: https://github.com/apache/pulsar/pull/16557#issuecomment-1229681406 The vote has been passed(vote thread: https://lists.apache.org/thread/g6stjsrymmq3850pdt9whzgx91tx33v8), PTAL，thanks! @codelipenghui @Technoboy- @Technoboy- @eolivelli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17289: [improve][client-c++]Support include message header size when check maxMessageSize
coderzc commented on PR #17289: URL: https://github.com/apache/pulsar/pull/17289#issuecomment-1229679613 > Odd, why is the java client compilation failed? https://github.com/apache/pulsar/runs/8033665923?check_suite_focus=true > > ``` > Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project pulsar-client-original: Compilation failure > Error: /Users/runner/work/pulsar/pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java:[222,39] no suitable method found for sendMessage(long,long,int,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) > Error: method org.apache.pulsar.client.impl.ProducerImpl.sendMessage(long,long,int,org.apache.pulsar.client.api.MessageId,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) is not applicable > Error:(actual and formal argument lists differ in length) > Error: method org.apache.pulsar.client.impl.ProducerImpl.sendMessage(long,long,long,int,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) is not applicable > ``` See: #17300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16898: [fix][function] Fix load trust certificate
nodece commented on code in PR #16898:
URL: https://github.com/apache/pulsar/pull/16898#discussion_r956846884
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java:
##
@@ -283,15 +283,15 @@ public static PulsarClient getPulsarClient(String
pulsarServiceUrl) {
}
public static PulsarClient getPulsarClient(String pulsarServiceUrl, String
authPlugin, String authParams,
- Boolean useTls, String
tlsTrustCertsFilePath,
+ Boolean useTls /* Deprecated
*/, String tlsTrustCertsFilePath,
Review Comment:
Thank @eolivelli for your feedback! this has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] nguyenthanhlong98 commented on issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka
nguyenthanhlong98 commented on issue #17294: URL: https://github.com/apache/pulsar/issues/17294#issuecomment-1229678168 @nodece, yes, there are vectors in the doc that don't support tls, but i hope there is a configuration that can replace tls for example Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] SignorMercurio commented on issue #13453: [Website] generate HTML for Pulsar configuration pages
SignorMercurio commented on issue #13453: URL: https://github.com/apache/pulsar/issues/13453#issuecomment-1229675510 Shall we close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka
nodece commented on issue #17294: URL: https://github.com/apache/pulsar/issues/17294#issuecomment-1229670673 Sorry, I don't know how to config the vector, but it looks like not supported the TLS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16412: [feature][CLI] Add commands to run 'scanOffloadedLedgers'.
github-actions[bot] commented on PR #16412: URL: https://github.com/apache/pulsar/pull/16412#issuecomment-1229667421 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #16861: [branch-2.8] testMaxNumPartitionsPerPartitionedTopicTopicCreation is broken
github-actions[bot] commented on issue #16861: URL: https://github.com/apache/pulsar/issues/16861#issuecomment-1229666974 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #10328: startMessageIdInclusive not avail in c++ / python
BewareMyPower commented on issue #10328: URL: https://github.com/apache/pulsar/issues/10328#issuecomment-1229662379 The C++ client will be supported after https://github.com/apache/pulsar/pull/17209 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nguyenthanhlong98 commented on issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka
nguyenthanhlong98 commented on issue #17294: URL: https://github.com/apache/pulsar/issues/17294#issuecomment-1229660061 @nodece Thank you, but this config is only for pulsar client and broker of pulsar. I want config for vector and pulsar https://vector.dev/docs/reference/configuration/sinks/pulsar/ Because in vector's doc there is no config tls for vector and pulsar so i don't know how to configure effectively Thanks @nodece -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17296: [improve]Use Text Blocks improve too long string in ServiceConfiguration doc annotation
Anonymitaet commented on PR #17296: URL: https://github.com/apache/pulsar/pull/17296#issuecomment-1229653874 @Technoboy- could you please review this PR from the technical perspective? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #17289: [improve][client-c++]Support include message header size when check maxMessageSize
shibd commented on PR #17289: URL: https://github.com/apache/pulsar/pull/17289#issuecomment-1229651663 Odd, why is the java client compilation failed? https://github.com/apache/pulsar/runs/8033665923?check_suite_focus=true ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project pulsar-client-original: Compilation failure Error: /Users/runner/work/pulsar/pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java:[222,39] no suitable method found for sendMessage(long,long,int,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) Error: method org.apache.pulsar.client.impl.ProducerImpl.sendMessage(long,long,int,org.apache.pulsar.client.api.MessageId,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) is not applicable Error:(actual and formal argument lists differ in length) Error: method org.apache.pulsar.client.impl.ProducerImpl.sendMessage(long,long,long,int,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf) is not applicable ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (076205d9128 -> ee7bfb5a1f2)
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 076205d9128 [improve][doc] sync Connection URLs section (#17304) add ee7bfb5a1f2 [fix][standalone] Updated tip section of consume a message (#17312) No new revisions were added by this update. Summary of changes: site2/docs/getting-started-standalone.md| 2 +- site2/docs/standalone.md| 2 +- .../version-2.10.0-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.10.0-deprecated/standalone.md| 2 +- .../version-2.10.1-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.10.1-deprecated/standalone.md| 2 +- .../website/versioned_docs/version-2.10.x/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.10.x/standalone.md | 2 +- .../website/versioned_docs/version-2.3.2/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.3.2/standalone.md| 2 +- .../website/versioned_docs/version-2.4.0/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.4.0/standalone.md| 2 +- .../website/versioned_docs/version-2.4.1/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.4.1/standalone.md| 2 +- .../website/versioned_docs/version-2.4.2/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.4.2/standalone.md| 2 +- .../website/versioned_docs/version-2.5.0/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.5.0/standalone.md| 2 +- .../website/versioned_docs/version-2.5.1/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.5.1/standalone.md| 2 +- .../website/versioned_docs/version-2.5.2/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.5.2/standalone.md| 2 +- .../website/versioned_docs/version-2.6.0/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.6.0/standalone.md| 2 +- .../website/versioned_docs/version-2.6.1/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.6.1/standalone.md| 2 +- .../website/versioned_docs/version-2.6.2/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.6.2/standalone.md| 2 +- .../website/versioned_docs/version-2.6.3/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.6.3/standalone.md| 2 +- .../website/versioned_docs/version-2.6.4/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.6.4/standalone.md| 2 +- .../website/versioned_docs/version-2.7.0/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.7.0/standalone.md| 2 +- .../website/versioned_docs/version-2.7.1/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.7.1/standalone.md| 2 +- .../website/versioned_docs/version-2.7.2/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.7.2/standalone.md| 2 +- .../website/versioned_docs/version-2.7.3/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.7.3/standalone.md| 2 +- .../website/versioned_docs/version-2.7.4/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.7.4/standalone.md| 2 +- .../version-2.8.0-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.8.0-deprecated/standalone.md | 2 +- .../version-2.8.1-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.8.1-deprecated/standalone.md | 2 +- .../version-2.8.2-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.8.2-deprecated/standalone.md | 2 +- .../version-2.8.3-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.8.3-deprecated/standalone.md | 2 +- .../website/versioned_docs/version-2.8.x/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.8.x/standalone.md| 2 +- .../version-2.9.0-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.9.0-deprecated/standalone.md | 2 +- .../version-2.9.1-deprecated/getting-started-standalone.md | 2 +- site2/website/versioned_docs/version-2.9.1-deprecated/standalone.md | 2 +- .../version-2.9.2-deprecated/getting-started-standalone.md | 2 +-
[GitHub] [pulsar] Anonymitaet merged pull request #17312: [fix][standalone] Updated tip section of consume a message
Anonymitaet merged PR #17312: URL: https://github.com/apache/pulsar/pull/17312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17320: [fix][doc] Add more information for producer_request_hold policy
Anonymitaet commented on PR #17320: URL: https://github.com/apache/pulsar/pull/17320#issuecomment-1229645558 @Technoboy- Could you please review this PR from the technical perspective? If it is technically correct, then technical writers can review it from the technical writing perspective. Thank you!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [improve][doc] sync Connection URLs section (#17304)
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 076205d9128 [improve][doc] sync Connection URLs section (#17304)
076205d9128 is described below
commit 076205d912876eaa5794ef5b357084b3b47200c2
Author: tison
AuthorDate: Mon Aug 29 09:41:32 2022 +0800
[improve][doc] sync Connection URLs section (#17304)
---
site2/docs/client-libraries-cpp.md| 16 +---
site2/docs/client-libraries-dotnet.md | 22 ++
site2/docs/client-libraries-go.md | 22 --
site2/docs/client-libraries-java.md | 20 +++-
site2/docs/client-libraries-node.md | 15 +--
site2/docs/client-libraries-python.md | 24 ++--
6 files changed, 61 insertions(+), 58 deletions(-)
diff --git a/site2/docs/client-libraries-cpp.md
b/site2/docs/client-libraries-cpp.md
index 235af0804bf..c4dcafe43a7 100644
--- a/site2/docs/client-libraries-cpp.md
+++ b/site2/docs/client-libraries-cpp.md
@@ -341,30 +341,24 @@
${PULSAR_HOME}/pulsar-client-cpp/build/lib/Release/pulsar.dll
## Connection URLs
-To connect Pulsar using client libraries, you need to specify a Pulsar
protocol URL.
+To connect to Pulsar using client libraries, you need to specify a [Pulsar
protocol](developing-binary-protocol.md) URL.
-Pulsar protocol URLs are assigned to specific clusters, you can use the Pulsar
URI scheme. The default port is `6650`. The following is an example for
localhost.
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar`
scheme. The following is an example of `localhost` with the default port `6650`:
```http
-
pulsar://localhost:6650
-
```
-In a Pulsar cluster in production, the URL looks as follows.
+If you have multiple brokers, separate `IP:port` by commas:
```http
-
-pulsar://pulsar.us-west.example.com:6650
-
+pulsar://localhost:6550,localhost:6651,localhost:6652
```
-If you use TLS authentication, you need to add `ssl`, and the default port is
`6651`. The following is an example.
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in
the scheme:
```http
-
pulsar+ssl://pulsar.us-west.example.com:6651
-
```
## Create a producer
diff --git a/site2/docs/client-libraries-dotnet.md
b/site2/docs/client-libraries-dotnet.md
index d8c3ad5b4b6..a0e4f89629c 100644
--- a/site2/docs/client-libraries-dotnet.md
+++ b/site2/docs/client-libraries-dotnet.md
@@ -54,6 +54,28 @@ To install the Pulsar C# client library, following these
steps:
```
+## Connection URLs
+
+To connect to Pulsar using client libraries, you need to specify a [Pulsar
protocol](developing-binary-protocol.md) URL.
+
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar`
scheme. The following is an example of `localhost` with the default port `6650`:
+
+```http
+pulsar://localhost:6650
+```
+
+If you have multiple brokers, separate `IP:port` by commas:
+
+```http
+pulsar://localhost:6550,localhost:6651,localhost:6652
+```
+
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in
the scheme:
+
+```http
+pulsar+ssl://pulsar.us-west.example.com:6651
+```
+
## Client
This section describes some configuration examples for the Pulsar C# client.
diff --git a/site2/docs/client-libraries-go.md
b/site2/docs/client-libraries-go.md
index 4f64ea8f6e0..f9e74dcdf06 100644
--- a/site2/docs/client-libraries-go.md
+++ b/site2/docs/client-libraries-go.md
@@ -53,36 +53,22 @@ $ ./test_example
To connect to Pulsar using client libraries, you need to specify a [Pulsar
protocol](developing-binary-protocol.md) URL.
-Pulsar protocol URLs are assigned to specific clusters, use the `pulsar`
scheme and have a default port of 6650. Here's an example for `localhost`:
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar`
scheme. The following is an example of `localhost` with the default port `6650`:
```http
-
pulsar://localhost:6650
-
-```
-
-If you have multiple brokers, you can set the URL as below.
-
-```
-
-pulsar://localhost:6550,localhost:6651,localhost:6652
-
```
-A URL for a production Pulsar cluster may look something like this:
+If you have multiple brokers, separate `IP:port` by commas:
```http
-
-pulsar://pulsar.us-west.example.com:6650
-
+pulsar://localhost:6550,localhost:6651,localhost:6652
```
-If you're using [TLS](security-tls-authentication.md) authentication, the URL
will look like something like this:
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in
the scheme:
```http
-
pulsar+ssl://pulsar.us-west.example.com:6651
-
```
## Create a client
diff --git a/site2/docs/client-libraries-java.md
b/site2/docs/client-libraries-java.md
index 26f9f784200..e4978f01037 100644
---
[GitHub] [pulsar] Anonymitaet closed issue #17303: Sync (Duplicate) "Connection URLs" section for all clients
Anonymitaet closed issue #17303: Sync (Duplicate) "Connection URLs" section for all clients URL: https://github.com/apache/pulsar/issues/17303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #17304: [improve][doc] sync Connection URLs section
Anonymitaet merged PR #17304: URL: https://github.com/apache/pulsar/pull/17304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [improve][workflow] Upgrade to latest docbot action
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 438cdfe80aa [improve][workflow] Upgrade to latest docbot action
438cdfe80aa is described below
commit 438cdfe80aa533238e516c046931967f55af7fb7
Author: Max Xu
AuthorDate: Mon Aug 29 09:40:40 2022 +0800
[improve][workflow] Upgrade to latest docbot action
---
.github/workflows/ci-documentbot.yml | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/.github/workflows/ci-documentbot.yml
b/.github/workflows/ci-documentbot.yml
index 7730757decb..fcc23bfded3 100644
--- a/.github/workflows/ci-documentbot.yml
+++ b/.github/workflows/ci-documentbot.yml
@@ -38,19 +38,8 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
steps:
- - name: Checkout action
-uses: actions/checkout@v3
-with:
- repository: apache/pulsar-test-infra
- ref: master
-
- - name: Set up Go
-uses: actions/setup-go@v3
-with:
- go-version: 1.18
-
- name: Labeling
-uses: ./docbot
+uses: apache/pulsar-test-infra/docbot@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
[GitHub] [pulsar] Anonymitaet merged pull request #17266: [improve][workflow] Upgrade to latest docbot action
Anonymitaet merged PR #17266: URL: https://github.com/apache/pulsar/pull/17266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lin-zhao opened a new pull request, #17320: [fix][doc] Add more information for producer_request_hold policy
lin-zhao opened a new pull request, #17320: URL: https://github.com/apache/pulsar/pull/17320 Clarifies that producer_request_hold holds the message for at most client operation timeout. ### Motivation Clarifies the behavior of producer_request_hold policy that raised some confusion in the community. ### Modifications - Namespaces admin doc includes mention of client operation timeout when explaining producer_request_hold - Cookbook for retention expiry includes mention of client operation timeout in the example for producer_request_hold ### Documentation - [x ] `doc` (Your PR contains doc changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #17228: [fix][ml] refresh the ledgers map when the offload complete failed
zymap commented on PR #17228: URL: https://github.com/apache/pulsar/pull/17228#issuecomment-1229628719 ping @hangc0276 @codelipenghui . Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17301: [Doc] Added explanations for documentation landing page
tisonkun commented on PR #17301: URL: https://github.com/apache/pulsar/pull/17301#issuecomment-1229626456 @D-2-Ed you may tag this PR as `doc` instead of `doc-complete` :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17167: [feat][proxy] Support proxy limit maximum connections per IP
mattisonchao commented on code in PR #17167:
URL: https://github.com/apache/pulsar/pull/17167#discussion_r956820491
##
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##
@@ -144,22 +146,29 @@ public ProxyConnection(ProxyService proxyService,
DnsAddressResolverGroup dnsAdd
this.dnsAddressResolverGroup = dnsAddressResolverGroup;
this.state = State.Init;
this.brokerProxyValidator = service.getBrokerProxyValidator();
+this.connectionController = proxyService.getConnectionController();
}
@Override
public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
super.channelRegistered(ctx);
ProxyService.ACTIVE_CONNECTIONS.inc();
-if (ProxyService.ACTIVE_CONNECTIONS.get() >
service.getConfiguration().getMaxConcurrentInboundConnections()) {
-state = State.Closing;
-ctx.close();
+SocketAddress rmAddress = ctx.channel().remoteAddress();
+ConnectionController.State state =
connectionController.increaseConnection(rmAddress);
+if (!state.equals(ConnectionController.State.OK)) {
+ctx.writeAndFlush(Commands.newError(-1,
ServerError.NotAllowedError,
+
state.equals(ConnectionController.State.REACH_MAX_CONNECTION)
+? "Reached the maximum number of connections"
+: "Reached the maximum number of connections on
address" + rmAddress))
+.addListener(result -> ctx.close());
ProxyService.REJECTED_CONNECTIONS.inc();
}
}
@Override
public void channelUnregistered(ChannelHandlerContext ctx) throws
Exception {
super.channelUnregistered(ctx);
+connectionController.decreaseConnection(ctx.channel().remoteAddress());
Review Comment:
fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #17301: [Doc] Added explanations for documentation landing page
Huanli-Meng commented on PR #17301: URL: https://github.com/apache/pulsar/pull/17301#issuecomment-1229623195 > @Huanli-Meng - Can you approve this PR? @D-2-Ed Done. PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a diff in pull request #17301: [Doc] Added explanations for documentation landing page
Huanli-Meng commented on code in PR #17301:
URL: https://github.com/apache/pulsar/pull/17301#discussion_r956817418
##
site2/docs/about.md:
##
@@ -10,21 +10,27 @@ import BlockLink from "@site/src/components/BlockLink";
import { docUrl } from "@site/src/utils/index";
-# Welcome to the doc portal!
+# Welcome to the Apache Pulsar documentation portal
***
-This portal holds a variety of support documents to help you work with Pulsar
. If you’re a beginner, there are tutorials and explainers to help you
understand Pulsar and how it works.
+This portal holds a variety of topics, tutorials, guides, and reference
material to help you work with Pulsar.
-If you’re an experienced coder, review this page to learn the easiest way to
access the specific content you’re looking for.
+## Choose your path
+Select one of the content blocks below to begin your Pulsar journey. If you ...
+* Are new to Pulsar, start with **About Pulsar** to learn about features and
concepts.
+* Want to jump to the quickstart, select **Get Started**.
+* Are an operator responsible for architecting and supporting Apache Pulsar.
start with **Install, Deploy, Upgrade**.
+* Are a developer who wants to master Apache Pulsar, select **Pulsar for
Developers**.
+* If you just want to try out Pulsar, select **How To** for access to the
"hello world" tutorial.
Review Comment:
```suggestion
* Want to try out Pulsar, select **How To** for access to the "hello world"
tutorial.
```
##
site2/docs/about.md:
##
@@ -10,21 +10,27 @@ import BlockLink from "@site/src/components/BlockLink";
import { docUrl } from "@site/src/utils/index";
-# Welcome to the doc portal!
+# Welcome to the Apache Pulsar documentation portal
***
-This portal holds a variety of support documents to help you work with Pulsar
. If you’re a beginner, there are tutorials and explainers to help you
understand Pulsar and how it works.
+This portal holds a variety of topics, tutorials, guides, and reference
material to help you work with Pulsar.
-If you’re an experienced coder, review this page to learn the easiest way to
access the specific content you’re looking for.
+## Choose your path
+Select one of the content blocks below to begin your Pulsar journey. If you ...
+* Are new to Pulsar, start with **About Pulsar** to learn about features and
concepts.
+* Want to jump to the quickstart, select **Get Started**.
+* Are an operator responsible for architecting and supporting Apache Pulsar.
start with **Install, Deploy, Upgrade**.
+* Are a developer who wants to master Apache Pulsar, select **Pulsar for
Developers**.
+* If you just want to try out Pulsar, select **How To** for access to the
"hello world" tutorial.
+* If you are an experienced Pulsar coder looking for API, metrics, or
configuration documentation, go to **Reference**.
Review Comment:
```suggestion
* An experienced Pulsar coder looking for API, metrics, or configuration
documentation, go to **Reference**.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17167: [feat][proxy] Support proxy limit maximum connections per IP
codelipenghui commented on code in PR #17167:
URL: https://github.com/apache/pulsar/pull/17167#discussion_r956810174
##
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##
@@ -144,22 +146,29 @@ public ProxyConnection(ProxyService proxyService,
DnsAddressResolverGroup dnsAdd
this.dnsAddressResolverGroup = dnsAddressResolverGroup;
this.state = State.Init;
this.brokerProxyValidator = service.getBrokerProxyValidator();
+this.connectionController = proxyService.getConnectionController();
}
@Override
public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
super.channelRegistered(ctx);
ProxyService.ACTIVE_CONNECTIONS.inc();
-if (ProxyService.ACTIVE_CONNECTIONS.get() >
service.getConfiguration().getMaxConcurrentInboundConnections()) {
-state = State.Closing;
-ctx.close();
+SocketAddress rmAddress = ctx.channel().remoteAddress();
+ConnectionController.State state =
connectionController.increaseConnection(rmAddress);
+if (!state.equals(ConnectionController.State.OK)) {
+ctx.writeAndFlush(Commands.newError(-1,
ServerError.NotAllowedError,
+
state.equals(ConnectionController.State.REACH_MAX_CONNECTION)
+? "Reached the maximum number of connections"
+: "Reached the maximum number of connections on
address" + rmAddress))
+.addListener(result -> ctx.close());
ProxyService.REJECTED_CONNECTIONS.inc();
}
}
@Override
public void channelUnregistered(ChannelHandlerContext ctx) throws
Exception {
super.channelUnregistered(ctx);
+connectionController.decreaseConnection(ctx.channel().remoteAddress());
Review Comment:
We should add tests to ensure the connection count of the same remote
address will decrease after the connection is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[pulsar-site] branch asf-site-next updated: Updated site at revision 760f7b47
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch asf-site-next
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/asf-site-next by this push:
new 45a346e51d1 Updated site at revision 760f7b47
45a346e51d1 is described below
commit 45a346e51d140ad752280322df943e9f261782a3
Author: Pulsar Site Updater
AuthorDate: Mon Aug 29 00:44:36 2022 +
Updated site at revision 760f7b47
---
content/index.html | 2 +-
content/swagger/master/swagger.json| 288 ++---
content/swagger/master/swaggerfunctions.json | 188 +++---
content/swagger/master/swaggerlookup.json | 106
content/swagger/master/swaggerpackages.json| 106
content/swagger/master/swaggersink.json| 106
content/swagger/master/swaggersource.json | 106
content/swagger/master/swaggertransactions.json| 106
content/swagger/master/v2/swagger.json | 288 ++---
content/swagger/master/v2/swaggerlookup.json | 106
content/swagger/master/v3/swaggerfunctions.json| 188 +++---
content/swagger/master/v3/swaggerpackages.json | 106
content/swagger/master/v3/swaggersink.json | 106
content/swagger/master/v3/swaggersource.json | 106
content/swagger/master/v3/swaggertransactions.json | 106
15 files changed, 1007 insertions(+), 1007 deletions(-)
diff --git a/content/index.html b/content/index.html
index 90b2c3d0a15..a2e6f93afaf 100644
--- a/content/index.html
+++ b/content/index.html
@@ -23,7 +23,7 @@
!function(){function
t(t){document.documentElement.setAttribute("data-theme",t)}var e=function(){var
t=null;try{t=localStorage.getItem("theme")}catch(t){}return
t}();t(null!==e?e:"light")}(),document.documentElement.setAttribute("data-announcement-bar-initially-dismissed",function(){try{return"true"===localStorage.getItem("docusaurus.announcement.dismiss")}catch(t){}return!1}())
-Skip to main
content Pulsar Summit Asia 2022 will take place
on November 19th and 20th, 2022. The CFP is open now! https://sessionize.com/pulsar-summit-asi [...]
+Skip to main
content Pulsar Summit Asia 2022 will take place
on November 19th and 20th, 2022. The CFP is open now! https://sessionize.com/pulsar-summit-asi [...]
http://www.apache.org/; target="_blank" rel="noopener noreferrer"
class="footer__link-item">Foundationhttps://www.apache.org/events/current- [...]
Apache Pulsar is available under the
https://www.apache.org/licenses/LICENSE-2.0; target="_blank">Apache
License, version 2.0.
diff --git a/content/swagger/master/swagger.json
b/content/swagger/master/swagger.json
index a5a60d6fb65..bc61512efc6 100644
--- a/content/swagger/master/swagger.json
+++ b/content/swagger/master/swagger.json
@@ -22170,9 +22170,6 @@
"peerAddress" : {
"$ref" : "#/definitions/SocketAddress"
},
-"subscription" : {
- "type" : "string"
-},
"tlsCertificates" : {
"type" : "array",
"items" : {
@@ -22184,6 +22181,9 @@
},
"commandData" : {
"type" : "string"
+},
+"subscription" : {
+ "type" : "string"
}
}
},
@@ -22232,6 +22232,10 @@
"type" : "string",
"enum" : [ "producer_request_hold", "producer_exception",
"consumer_backlog_eviction" ]
},
+"limit" : {
+ "type" : "integer",
+ "format" : "int64"
+},
"limitSize" : {
"type" : "integer",
"format" : "int64"
@@ -22239,10 +22243,6 @@
"limitTime" : {
"type" : "integer",
"format" : "int32"
-},
-"limit" : {
- "type" : "integer",
- "format" : "int64"
}
}
},
@@ -22791,12 +22791,12 @@
"rootName" : {
"type" : "string"
},
-"fullRootName" : {
- "$ref" : "#/definitions/PropertyName"
-},
"subtypeResolver" : {
"$ref" : "#/definitions/SubtypeResolver"
},
+"fullRootName" : {
+ "$ref" : "#/definitions/PropertyName"
+},
"defaultVisibilityChecker" : {
"$ref" : "#/definitions/VisibilityCheckerObject"
},
@@ -22809,12 +22809,12 @@
"typeFactory" : {
"$ref" : "#/definitions/TypeFactory"
},
-"handlerInstantiator" : {
- "$ref" : "#/definitions/HandlerInstantiator"
-},
"propertyNamingStrategy" : {
"$ref" : "#/definitions/PropertyNamingStrategy"
},
+"handlerInstantiator" : {
+ "$ref" : "#/definitions/HandlerInstantiator"
+},
[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#0909853)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 760f7b47f43 Docs sync done from apache/pulsar(#0909853) 760f7b47f43 is described below commit 760f7b47f437267a3c9d71d14c73e99ba32bd1ec Author: Pulsar Site Updater AuthorDate: Mon Aug 29 00:01:46 2022 + Docs sync done from apache/pulsar(#0909853)
[GitHub] [pulsar] eolivelli commented on a diff in pull request #17082: [fix][broker] Skip not connectable URL when get redirectionUrl
eolivelli commented on code in PR #17082:
URL: https://github.com/apache/pulsar/pull/17082#discussion_r956763118
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java:
##
@@ -493,13 +502,47 @@ private URI getRedirectionUrl(ClusterData
differentClusterData) throws Malformed
} else {
serviceNameResolver.updateServiceUrl(differentClusterData.getServiceUrl());
}
-URL webUrl = new
URL(serviceNameResolver.resolveHostUri().toString());
-return
UriBuilder.fromUri(uri.getRequestUri()).host(webUrl.getHost()).port(webUrl.getPort()).build();
+return getConnectableURI(serviceNameResolver);
} catch (PulsarClientException.InvalidServiceURL exception) {
throw new MalformedURLException(exception.getMessage());
}
}
+private CompletableFuture getConnectableURI(PulsarServiceNameResolver
serviceNameResolver) {
+return CompletableFuture.supplyAsync(() -> {
+String hostUri = serviceNameResolver.resolveHostUri().toString();
+String firstHostUri = hostUri;
+boolean connectable = false;
+URL webUrl = null;
+do {
+try {
+webUrl = new URL(hostUri);
+Socket socket = new Socket();
+socket.connect(new InetSocketAddress(webUrl.getHost(),
webUrl.getPort()), 5000);
Review Comment:
This is going to create dunmy TCP connections to Pulsar brokers.
I don't think that the network monitors/auditing tools will be happy.
If you need thus feature that we must add a configuration flag to enable
this new behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #17082: [fix][broker] Skip not connectable URL when get redirectionUrl
eolivelli commented on code in PR #17082:
URL: https://github.com/apache/pulsar/pull/17082#discussion_r956763118
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java:
##
@@ -493,13 +502,47 @@ private URI getRedirectionUrl(ClusterData
differentClusterData) throws Malformed
} else {
serviceNameResolver.updateServiceUrl(differentClusterData.getServiceUrl());
}
-URL webUrl = new
URL(serviceNameResolver.resolveHostUri().toString());
-return
UriBuilder.fromUri(uri.getRequestUri()).host(webUrl.getHost()).port(webUrl.getPort()).build();
+return getConnectableURI(serviceNameResolver);
} catch (PulsarClientException.InvalidServiceURL exception) {
throw new MalformedURLException(exception.getMessage());
}
}
+private CompletableFuture getConnectableURI(PulsarServiceNameResolver
serviceNameResolver) {
+return CompletableFuture.supplyAsync(() -> {
+String hostUri = serviceNameResolver.resolveHostUri().toString();
+String firstHostUri = hostUri;
+boolean connectable = false;
+URL webUrl = null;
+do {
+try {
+webUrl = new URL(hostUri);
+Socket socket = new Socket();
+socket.connect(new InetSocketAddress(webUrl.getHost(),
webUrl.getPort()), 5000);
Review Comment:
This is going to create dunmy TCP connections to Pulsar brokers.
I don't think that the broker will be happy.
If you need thus feature that we must add a configuration flag to enable
this new behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #16898: [fix][function-worker] Fix load trust certificate
eolivelli commented on code in PR #16898:
URL: https://github.com/apache/pulsar/pull/16898#discussion_r956762828
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java:
##
@@ -283,15 +283,15 @@ public static PulsarClient getPulsarClient(String
pulsarServiceUrl) {
}
public static PulsarClient getPulsarClient(String pulsarServiceUrl, String
authPlugin, String authParams,
- Boolean useTls, String
tlsTrustCertsFilePath,
+ Boolean useTls /* Deprecated
*/, String tlsTrustCertsFilePath,
Review Comment:
This is not a public API
It is better to remove the parameter.
The parameter means 'useTls' and if you set it you expect that you use TLS.
This is not true anymore so it can lead to subtle security bugs.
I strongly believe that we must remove this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #17308: [fix] Combination of autocreate + forced delete of partitioned topic with active consumer leaves topic metadata inconsistent.
eolivelli commented on PR #17308: URL: https://github.com/apache/pulsar/pull/17308#issuecomment-1229521264 (As discussed offline) As a follow up work we should disable automatic topic creation before deleting a namespace, this way we will allow users to delete namespaces and tenants more easily -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari opened a new pull request, #17319: [improve][CI] Replace test reporting with less verbose solution
lhotari opened a new pull request, #17319: URL: https://github.com/apache/pulsar/pull/17319 Fixes #16736 ### Motivation See #16736 This PR reduces noise in test reporting and removes the misleading check runs from PR checks. ### Modifications - remove separate workflow that added GitHub Actions check runs - replaces test reporting with https://github.com/mikepenz/action-junit-report which has been copied to https://github.com/apache/pulsar-test-infra/tree/master/action-junit-report -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #17213: [Discuss] Shall we record pulsar cluster name in bookeeper ledger metadata?
eolivelli commented on issue #17213: URL: https://github.com/apache/pulsar/issues/17213#issuecomment-1229520462 The proposal names sense to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#0909853)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 6c9536b8a63 Docs sync done from apache/pulsar(#0909853) 6c9536b8a63 is described below commit 6c9536b8a634f13810d95e96bc5a75efe4fb8895 Author: Pulsar Site Updater AuthorDate: Sun Aug 28 18:01:58 2022 + Docs sync done from apache/pulsar(#0909853)
[GitHub] [pulsar] eolivelli commented on issue #16736: CI: Replace current GitHub Actions test reporting solution with less verbose solution
eolivelli commented on issue #16736: URL: https://github.com/apache/pulsar/issues/16736#issuecomment-1229519866 The experiments looks promising -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-test-infra] branch dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 updated (923aa53 -> 8997f67)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git omit 923aa53 Bump @actions/core from 1.6.0 to 1.9.1 in /gh-actions-artifact-client add 8997f67 Bump @actions/core from 1.6.0 to 1.9.1 in /gh-actions-artifact-client This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (923aa53) \ N -- N -- N refs/heads/dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 (8997f67) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[pulsar-test-infra] branch dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1 updated (fdaf147 -> 414d66c)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
discard fdaf147 Bump @actions/core from 1.2.4 to 1.9.1 in /paths-filter
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add 414d66c Bump @actions/core from 1.2.4 to 1.9.1 in /paths-filter
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (fdaf147)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/paths-filter/actions/core-1.9.1 (414d66c)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create mode 100644 action-junit-report/.eslintrc.json
create mode
[pulsar-test-infra] branch dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1 updated (bb52dec -> 923aa53)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
omit bb52dec Bump @actions/core from 1.6.0 to 1.9.1 in
/gh-actions-artifact-client
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add 923aa53 Bump @actions/core from 1.6.0 to 1.9.1 in
/gh-actions-artifact-client
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (bb52dec)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/gh-actions-artifact-client/actions/core-1.9.1
(923aa53)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create
[pulsar-test-infra] branch dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1 updated (ed3e397 -> 71fe82b)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
discard ed3e397 Bump @actions/core from 1.2.6 to 1.9.1 in /test-reporter
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add 71fe82b Bump @actions/core from 1.2.6 to 1.9.1 in /test-reporter
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (ed3e397)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/test-reporter/actions/core-1.9.1 (71fe82b)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create mode 100644 action-junit-report/.eslintrc.json
create
[pulsar-test-infra] branch dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1 updated (0abf0df -> 491a9e5)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
discard 0abf0df Bump @actions/core from 1.2.6 to 1.9.1 in /setup-maven
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add 491a9e5 Bump @actions/core from 1.2.6 to 1.9.1 in /setup-maven
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (0abf0df)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/setup-maven/actions/core-1.9.1 (491a9e5)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create mode 100644 action-junit-report/.eslintrc.json
create mode 100644
[pulsar-test-infra] branch dependabot/npm_and_yarn/doc-label-check/actions/core-1.9.1 updated (0e2bebd -> c5aaede)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/doc-label-check/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
discard 0e2bebd Bump @actions/core from 1.2.4 to 1.9.1 in /doc-label-check
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add c5aaede Bump @actions/core from 1.2.4 to 1.9.1 in /doc-label-check
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (0e2bebd)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/doc-label-check/actions/core-1.9.1 (c5aaede)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create mode 100644 action-junit-report/.eslintrc.json
[pulsar-test-infra] branch dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1 updated (429396f -> c52f963)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1
in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git
discard 429396f Bump @actions/core from 1.6.0 to 1.9.1 in /http-cache-action
add 08d54aa [improve][docbot] Move the preceding steps into the action
(#68)
add eeb9107 Add copy of https://github.com/mikepenz/action-junit-report @
v3/e187db4
add c52f963 Bump @actions/core from 1.6.0 to 1.9.1 in /http-cache-action
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (429396f)
\
N -- N -- N
refs/heads/dependabot/npm_and_yarn/http-cache-action/actions/core-1.9.1
(c52f963)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../.eslintignore | 0
action-junit-report/.eslintrc.json |57 +
action-junit-report/.gitattributes | 1 +
.../.gitignore | 5 +-
.../.prettierignore| 0
.../.prettierrc.json | 0
.../LICENSE|30 +-
action-junit-report/README.md | 228 +
action-junit-report/SECURITY.md| 9 +
action-junit-report/__tests__/testParser.test.ts | 618 +
action-junit-report/__tests__/utils.test.ts|33 +
action-junit-report/action.yml |87 +
action-junit-report/dist/index.js | 15284 +++
action-junit-report/dist/index.js.map | 1 +
.../dist/licenses.txt | 1014 +-
action-junit-report/dist/sourcemap-register.js | 1 +
.../jest.config.js | 0
action-junit-report/package-lock.json | 11552 ++
action-junit-report/package.json |55 +
action-junit-report/src/annotator.ts | 144 +
action-junit-report/src/main.ts| 134 +
action-junit-report/src/testParser.ts | 418 +
action-junit-report/src/utils.ts |52 +
.../test_results/cunit/testEmpty.xml | 3 +
.../test_results/cunit/testFailure.xml |18 +
.../test_results/issues/testDisabled.xml |39 +
.../test_results/junit-web-test/expected.xml |28 +
.../junit-web-test/expectedRetries.xml |33 +
.../com.mikepenz.DummyTest#test_02_dummy.xml | 5 +
.../com.mikepenz.DummyTest3#test_01.xml| 1 +
.../com.mikepenz.DummyUtilTest#test_01_dummy.xml | 4 +
action-junit-report/test_results/mocha/mocha.xml |11 +
action-junit-report/test_results/nested/junit.xml |28 +
action-junit-report/test_results/perl/result.xml | 4 +
.../test_results/python/__init__.py| 0
action-junit-report/test_results/python/report.xml |13 +
.../test_results/python/test_sample.py |14 +
.../test_results/tests/email/pom.xml |32 +
.../action/surefire/report/email/EmailAddress.java |34 +
.../report/email/InvalidEmailAddressException.java | 7 +
.../surefire/report/email/EmailAddressTest.java|80 +
...tion.surefire.report.email.EmailAddressTest.xml |48 +
action-junit-report/test_results/tests/pom.xml |81 +
.../test_results/tests/utils/pom.xml |98 +
.../action/surefire/report/calc/CalcUtils.java |62 +
.../action/surefire/report/calc/StringUtils.java |29 +
.../action/surefire/report/calc/AllOkTest.java |10 +
.../action/surefire/report/calc/CalcUtilsTest.kt |33 +
.../surefire/report/calc/StringUtilsTest.java |51 +
.../TEST-action.surefire.report.calc.AllOkTest.xml | 4 +
...T-action.surefire.report.calc.CalcUtilsTest.xml |20 +
...action.surefire.report.calc.StringUtilsTest.xml |54 +
action-junit-report/test_results/xunit/report.xml |11 +
.../tsconfig.json | 2 +-
docbot/action.yml |11 +-
55 files changed, 29717 insertions(+), 874 deletions(-)
copy {paths-filter => action-junit-report}/.eslintignore (100%)
create mode 100644
[GitHub] [pulsar] AnonHxy commented on pull request #16946: [Improve][Broker]Reduce GetReplicatedSubscriptionStatus local REST call
AnonHxy commented on PR #16946: URL: https://github.com/apache/pulsar/pull/16946#issuecomment-1229518061 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #16736: CI: Replace current GitHub Actions test reporting solution with less verbose solution
lhotari commented on issue #16736: URL: https://github.com/apache/pulsar/issues/16736#issuecomment-1229513716 running an experiment in https://github.com/lhotari/pulsar/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] shibd opened a new pull request, #17318: [fix][client] When using batch receive timeout, will receive duplicate messages.
shibd opened a new pull request, #17318: URL: https://github.com/apache/pulsar/pull/17318 ### Motivation Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout. ### Modifications - Add consumer epoch on `notifyPendingBatchReceivedCallBack`. - Reuse `notifyPendingBatchReceivedCallBack` logic. ### Verifying this change - `testBatchReceiveRedeliveryAddEpoch` unit test covers the scene. ### Documentation - [x] `doc-not-needed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17273: [fix][broker] Fix broker cache eviction of entries read by active cursors
lhotari commented on code in PR #17273:
URL: https://github.com/apache/pulsar/pull/17273#discussion_r956751759
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java:
##
@@ -45,33 +45,48 @@
*/
public class ManagedCursorContainer implements Iterable {
+private final OrderingType orderingType;
+private final OrderingFilter orderingFilter;
+
private static class Item {
final ManagedCursor cursor;
PositionImpl position;
int idx;
-Item(ManagedCursor cursor, int idx) {
+Item(ManagedCursor cursor, PositionImpl position, int idx) {
this.cursor = cursor;
-this.position = (PositionImpl) cursor.getMarkDeletedPosition();
+this.position = position;
this.idx = idx;
}
}
-public enum CursorType {
-DurableCursor,
-NonDurableCursor,
-ALL
+private enum OrderingType {
+MARKDELETED_POSITION,
+READ_POSITION
+}
Review Comment:
I updated the Javadoc and ended up simplifying ManagedCursorContainer. I
removed that OrderingType and OrderingFilter completely and instead modified
the add method to explicitly pass the position which is used for ordering. If
this is null, the cursor won't be tracked in the heap and ordered. This feels
more consistent with the "cursorUpdated" method which also takes a cursor and
position parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17273: [fix][broker] Fix broker cache eviction of entries read by active cursors
lhotari commented on code in PR #17273:
URL: https://github.com/apache/pulsar/pull/17273#discussion_r956751532
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -3513,31 +3495,22 @@ public void activateCursor(ManagedCursor cursor) {
if (activeCursors.get(cursor.getName()) == null) {
activeCursors.add(cursor);
}
-if (!cursor.isDurable() &&
nonDurableActiveCursors.get(cursor.getName()) == null) {
-nonDurableActiveCursors.add(cursor);
-}
}
public void deactivateCursor(ManagedCursor cursor) {
+deactivateCursorByName(cursor.getName());
+}
+
+private void deactivateCursorByName(String cursorName) {
synchronized (activeCursors) {
-if (activeCursors.get(cursor.getName()) != null) {
-activeCursors.removeCursor(cursor.getName());
-if (!activeCursors.hasDurableCursors()) {
-// cleanup cache if there is no active subscription
-entryCache.clear();
-} else {
-// if removed subscription was the slowest subscription :
update cursor and let it clear cache:
-// till new slowest-cursor's read-position
-discardEntriesFromCache((ManagedCursorImpl)
activeCursors.getSlowestReader(),
-getPreviousPosition((PositionImpl)
activeCursors.getSlowestReader().getReadPosition()));
-}
-}
-if (!cursor.isDurable()) {
-nonDurableActiveCursors.removeCursor(cursor.getName());
+if (activeCursors.get(cursorName) != null) {
+activeCursors.removeCursor(cursorName);
Review Comment:
Thanks for the suggestion. I made this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] Pomelongan commented on pull request #17206: [improve][broker][PIP-149]make deletePersistence method async in Namespaces
Pomelongan commented on PR #17206: URL: https://github.com/apache/pulsar/pull/17206#issuecomment-1229462509 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Pomelongan commented on pull request #17206: [improve][broker][PIP-149]make deletePersistence method async in Namespaces
Pomelongan commented on PR #17206: URL: https://github.com/apache/pulsar/pull/17206#issuecomment-1229453375 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch branch-2.9 updated: [fix][client] Fix reach redeliverCount client can't send batch messages to DLQ (#17317)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.9 by this push:
new 7317c84421e [fix][client] Fix reach redeliverCount client can't send
batch messages to DLQ (#17317)
7317c84421e is described below
commit 7317c84421ef33e5391139774d8f5847328d9714
Author: congbo <39078850+congbobo...@users.noreply.github.com>
AuthorDate: Sun Aug 28 20:10:57 2022 +0800
[fix][client] Fix reach redeliverCount client can't send batch messages to
DLQ (#17317)
(cherry picked from commit 0909853873fc61395df7a68de13335d9f770383a)
---
.../client/impl/TransactionEndToEndTest.java | 66 ++
.../apache/pulsar/client/impl/ConsumerImpl.java| 11 +++-
2 files changed, 75 insertions(+), 2 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
index cb943a8b0b9..7771c4ca0ed 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
@@ -1116,6 +1116,7 @@ public class TransactionEndToEndTest extends
TransactionTestBase {
@Cleanup
ProducerImpl producer = (ProducerImpl)
pulsarClient.newProducer()
.topic(topic)
+.enableBatching(false)
.sendTimeout(1, TimeUnit.SECONDS)
.create();
@@ -1160,4 +1161,69 @@ public class TransactionEndToEndTest extends
TransactionTestBase {
assertEquals(value, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
}
+
+@Test
+public void testSendTxnAckBatchMessageToDLQ() throws Exception {
+String topic = NAMESPACE1 + "/testSendTxnAckBatchMessageToDLQ";
+String subName = "test";
+String value1 = "test1";
+String value2 = "test2";
+@Cleanup
+ProducerImpl producer = (ProducerImpl)
pulsarClient.newProducer()
+.topic(topic)
+.sendTimeout(1, TimeUnit.SECONDS)
+.create();
+
+@Cleanup
+Consumer consumer = pulsarClient.newConsumer()
+.topic(topic)
+.subscriptionType(SubscriptionType.Shared)
+// consumer can't receive the same message three times
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName(subName)
+.subscribe();
+
+@Cleanup
+Consumer deadLetterConsumer = pulsarClient.newConsumer()
+.topic(String.format("%s-%s" +
RetryMessageUtil.DLQ_GROUP_TOPIC_SUFFIX,
+topic, subName))
+.subscriptionType(SubscriptionType.Shared)
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName("test")
+.subscribe();
+
+producer.sendAsync(value1.getBytes());
+producer.sendAsync(value2.getBytes());
+Transaction transaction =
pulsarClient.newTransaction().withTransactionTimeout(1, TimeUnit.MINUTES)
+.build().get();
+
+Message message = consumer.receive();
+assertEquals(value1, new String(message.getValue()));
+// consumer receive the batch message one the first time,
redeliverCount = 0
+consumer.acknowledgeAsync(message.getMessageId(), transaction).get();
+
+transaction.abort().get();
+
+// consumer will receive the batch message two and then receive
+// the message one and message two again, redeliverCount = 1
+for (int i = 0; i < 3; i ++) {
+message = consumer.receive();
+}
+
+transaction = pulsarClient.newTransaction().withTransactionTimeout(5,
TimeUnit.MINUTES)
+.build().get();
+
+assertEquals(value2, new String(message.getValue()));
+// consumer receive the batch message two the second time,
redeliverCount = 1, also can be received
+consumer.acknowledgeAsync(message.getMessageId(), transaction).get();
+
+transaction.abort().get();
+
+// consumer receive the batch message the third time, redeliverCount =
2,
+// the message will be sent to DLQ, can't receive
+assertNull(consumer.receive(3, TimeUnit.SECONDS));
+
+assertEquals(value1, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
+assertEquals(value2, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
+}
}
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
[pulsar] branch branch-2.10 updated: [fix][client] Fix reach redeliverCount client can't send batch messages to DLQ (#17317)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new 718068d5bed [fix][client] Fix reach redeliverCount client can't send
batch messages to DLQ (#17317)
718068d5bed is described below
commit 718068d5bedd7cf07d2d8e06efbc67f8d581e82a
Author: congbo <39078850+congbobo...@users.noreply.github.com>
AuthorDate: Sun Aug 28 20:10:57 2022 +0800
[fix][client] Fix reach redeliverCount client can't send batch messages to
DLQ (#17317)
(cherry picked from commit 0909853873fc61395df7a68de13335d9f770383a)
---
.../client/impl/TransactionEndToEndTest.java | 66 ++
.../apache/pulsar/client/impl/ConsumerImpl.java| 11 +++-
2 files changed, 75 insertions(+), 2 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
index 1df364f18b2..6868f49fa14 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
@@ -1116,6 +1116,7 @@ public class TransactionEndToEndTest extends
TransactionTestBase {
@Cleanup
ProducerImpl producer = (ProducerImpl)
pulsarClient.newProducer()
.topic(topic)
+.enableBatching(false)
.sendTimeout(1, TimeUnit.SECONDS)
.create();
@@ -1160,4 +1161,69 @@ public class TransactionEndToEndTest extends
TransactionTestBase {
assertEquals(value, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
}
+
+@Test
+public void testSendTxnAckBatchMessageToDLQ() throws Exception {
+String topic = NAMESPACE1 + "/testSendTxnAckBatchMessageToDLQ";
+String subName = "test";
+String value1 = "test1";
+String value2 = "test2";
+@Cleanup
+ProducerImpl producer = (ProducerImpl)
pulsarClient.newProducer()
+.topic(topic)
+.sendTimeout(1, TimeUnit.SECONDS)
+.create();
+
+@Cleanup
+Consumer consumer = pulsarClient.newConsumer()
+.topic(topic)
+.subscriptionType(SubscriptionType.Shared)
+// consumer can't receive the same message three times
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName(subName)
+.subscribe();
+
+@Cleanup
+Consumer deadLetterConsumer = pulsarClient.newConsumer()
+.topic(String.format("%s-%s" +
RetryMessageUtil.DLQ_GROUP_TOPIC_SUFFIX,
+topic, subName))
+.subscriptionType(SubscriptionType.Shared)
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName("test")
+.subscribe();
+
+producer.sendAsync(value1.getBytes());
+producer.sendAsync(value2.getBytes());
+Transaction transaction =
pulsarClient.newTransaction().withTransactionTimeout(1, TimeUnit.MINUTES)
+.build().get();
+
+Message message = consumer.receive();
+assertEquals(value1, new String(message.getValue()));
+// consumer receive the batch message one the first time,
redeliverCount = 0
+consumer.acknowledgeAsync(message.getMessageId(), transaction).get();
+
+transaction.abort().get();
+
+// consumer will receive the batch message two and then receive
+// the message one and message two again, redeliverCount = 1
+for (int i = 0; i < 3; i ++) {
+message = consumer.receive();
+}
+
+transaction = pulsarClient.newTransaction().withTransactionTimeout(5,
TimeUnit.MINUTES)
+.build().get();
+
+assertEquals(value2, new String(message.getValue()));
+// consumer receive the batch message two the second time,
redeliverCount = 1, also can be received
+consumer.acknowledgeAsync(message.getMessageId(), transaction).get();
+
+transaction.abort().get();
+
+// consumer receive the batch message the third time, redeliverCount =
2,
+// the message will be sent to DLQ, can't receive
+assertNull(consumer.receive(3, TimeUnit.SECONDS));
+
+assertEquals(value1, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
+assertEquals(value2, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
+}
}
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
[pulsar] 01/02: [fix][client] Fix reach redeliverCount client can't send messages to DLQ (#17287)
This is an automated email from the ASF dual-hosted git repository.
bogong pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit eb77b522ba0931ed22b32be5999ea68ad6337f2f
Author: congbo <39078850+congbobo...@users.noreply.github.com>
AuthorDate: Sat Aug 27 12:38:08 2022 +0800
[fix][client] Fix reach redeliverCount client can't send messages to DLQ
(#17287)
(cherry picked from commit 4a28c087fe1308ea4eabc104b3d4889b47316afe)
---
.../client/impl/TransactionEndToEndTest.java | 55 ++
.../apache/pulsar/client/impl/ConsumerImpl.java| 13 +++--
2 files changed, 64 insertions(+), 4 deletions(-)
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
index 72eef04bad9..e2683afa2df 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
@@ -51,6 +51,7 @@ import org.apache.pulsar.broker.service.Topic;
import org.apache.pulsar.broker.service.persistent.PersistentSubscription;
import org.apache.pulsar.broker.transaction.TransactionTestBase;
import org.apache.pulsar.client.api.Consumer;
+import org.apache.pulsar.client.api.DeadLetterPolicy;
import org.apache.pulsar.client.api.Message;
import org.apache.pulsar.client.api.MessageId;
import org.apache.pulsar.client.api.Producer;
@@ -67,6 +68,7 @@ import
org.apache.pulsar.client.api.transaction.TransactionCoordinatorClientExce
import org.apache.pulsar.client.api.transaction.TxnID;
import org.apache.pulsar.client.impl.transaction.TransactionImpl;
import org.apache.pulsar.client.internal.DefaultImplementation;
+import org.apache.pulsar.client.util.RetryMessageUtil;
import org.apache.pulsar.common.api.proto.CommandAck;
import org.apache.pulsar.common.naming.TopicName;
import org.apache.pulsar.common.policies.data.PersistentTopicInternalStats;
@@ -1169,4 +1171,57 @@ public class TransactionEndToEndTest extends
TransactionTestBase {
assertTrue(ex instanceof PulsarClientException.TimeoutException);
}
}
+
+@Test
+public void testSendTxnAckMessageToDLQ() throws Exception {
+String topic = NAMESPACE1 + "/testSendTxnAckMessageToDLQ";
+String subName = "test";
+String value = "test";
+@Cleanup
+ProducerImpl producer = (ProducerImpl)
pulsarClient.newProducer()
+.topic(topic)
+.sendTimeout(1, TimeUnit.SECONDS)
+.create();
+
+@Cleanup
+Consumer consumer = pulsarClient.newConsumer()
+.topic(topic)
+.subscriptionType(SubscriptionType.Shared)
+// consumer can't receive the same message three times
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName(subName)
+.subscribe();
+
+@Cleanup
+Consumer deadLetterConsumer = pulsarClient.newConsumer()
+.topic(String.format("%s-%s" +
RetryMessageUtil.DLQ_GROUP_TOPIC_SUFFIX,
+topic, subName))
+.subscriptionType(SubscriptionType.Shared)
+
.deadLetterPolicy(DeadLetterPolicy.builder().maxRedeliverCount(1).build())
+.subscriptionName("test")
+.subscribe();
+
+producer.send(value.getBytes());
+Transaction transaction =
pulsarClient.newTransaction().withTransactionTimeout(1, TimeUnit.MINUTES)
+.build().get();
+
+// consumer receive the message the first time, redeliverCount = 0
+consumer.acknowledgeAsync(consumer.receive().getMessageId(),
transaction).get();
+
+transaction.abort().get();
+
+transaction = pulsarClient.newTransaction().withTransactionTimeout(5,
TimeUnit.MINUTES)
+.build().get();
+
+// consumer receive the message the second time, redeliverCount = 1,
also can be received
+consumer.acknowledgeAsync(consumer.receive().getMessageId(),
transaction).get();
+
+transaction.abort().get();
+
+// consumer receive the message the third time, redeliverCount = 2,
+// the message will be sent to DLQ, can't receive
+assertNull(consumer.receive(3, TimeUnit.SECONDS));
+
+assertEquals(value, new String(deadLetterConsumer.receive(3,
TimeUnit.SECONDS).getValue()));
+}
}
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
index 4cb334b38e4..809e7c674b9 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@
