[GitHub] [pulsar-site] momo-jun commented on pull request #251: correct homepage link and remove dangling bottom block
momo-jun commented on PR #251: URL: https://github.com/apache/pulsar-site/pull/251#issuecomment-1277065009 If I understand the PR correctly, it changes the redirection of the `QUICKSTART` button on the home page from Image1 to Image2. Because the `Get Started > Quickstart` button on the top also redirects to Image2. It's quite confusing when the buttons with the identical label redirect to two different pages. That's how I understand the issue. https://user-images.githubusercontent.com/60642177/195511669-3e6ae26b-7a6e-4c13-9778-068a912f0d91.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17872: [fix][broker] ClassCastException when specify flow_or_qps_equally_div…
codecov-commenter commented on PR #17872: URL: https://github.com/apache/pulsar/pull/17872#issuecomment-1277059151 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17872?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@0678b82`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17872?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17872 +/- ## = Coverage ? 44.78% Complexity?15782 = Files ? 1359 Lines ? 118230 Branches ?12847 = Hits ?52949 Misses?59862 Partials ? 5419 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `44.78% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [fix][broker] Fix system service namespace create internal event topic. (#17867)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 29baa0b2e57 [fix][broker] Fix system service namespace create internal
event topic. (#17867)
29baa0b2e57 is described below
commit 29baa0b2e57e9240dca1d76cd1e38bab95f47357
Author: Jiwei Guo
AuthorDate: Thu Oct 13 13:17:16 2022 +0800
[fix][broker] Fix system service namespace create internal event topic.
(#17867)
---
.../pulsar/broker/service/BrokerService.java | 3 ++-
.../SystemTopicBasedTopicPoliciesService.java | 4 +++
.../apache/pulsar/broker/admin/AdminApi2Test.java | 2 +-
.../systopic/PartitionedSystemTopicTest.java | 30 +++---
4 files changed, 33 insertions(+), 6 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
index 0ff8bfac457..63ab3352ef2 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
@@ -1595,7 +1595,8 @@ public class BrokerService implements Closeable {
RetentionPolicies retentionPolicies = null;
OffloadPoliciesImpl topicLevelOffloadPolicies = null;
-if (pulsar.getConfig().isTopicLevelPoliciesEnabled()) {
+if (pulsar.getConfig().isTopicLevelPoliciesEnabled()
+&&
!NamespaceService.isSystemServiceNamespace(namespace.toString())) {
try {
TopicPolicies topicPolicies =
pulsar.getTopicPoliciesService().getTopicPolicies(topicName);
if (topicPolicies != null) {
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
index 9c3c8488971..4bd3a0952f0 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
@@ -101,6 +101,10 @@ public class SystemTopicBasedTopicPoliciesService
implements TopicPoliciesServic
private CompletableFuture sendTopicPolicyEvent(TopicName topicName,
ActionType actionType,
TopicPolicies
policies) {
+if
(NamespaceService.isHeartbeatNamespace(topicName.getNamespaceObject())) {
+return CompletableFuture.failedFuture(
+new BrokerServiceException.NotAllowedException("Not
allowed to send event to health check topic"));
+}
CompletableFuture result = new CompletableFuture<>();
try {
createSystemTopicFactoryIfNeeded();
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
index ff4168d0e3d..cab1333b5bf 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
@@ -558,7 +558,7 @@ public class AdminApi2Test extends
MockedPulsarServiceBaseTest {
* @param namespaceName
* @throws Exception
*/
-@Test(dataProvider = "namespaceNames", timeOut = 1)
+@Test(dataProvider = "namespaceNames", timeOut = 3)
public void testResetCursorOnPosition(String namespaceName) throws
Exception {
final String topicName = "persistent://prop-xyz/use/" + namespaceName
+ "/resetPosition";
final int totalProducedMessages = 50;
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java
index 9beebe1883b..510abae87bc 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java
@@ -38,6 +38,7 @@ import org.apache.pulsar.broker.service.BrokerTestBase;
import org.apache.pulsar.broker.service.Topic;
import org.apache.pulsar.broker.service.persistent.PersistentTopic;
import org.apache.pulsar.client.admin.ListTopicsOptions;
+import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.client.api.Consumer;
import org.apache.pulsar.client.api.Message;
import org.apache.pulsar.client.api.MessageId;
@@ -172,10 +173,31 @@ public class PartitionedSystemTopicTest extends
BrokerTestBase
[GitHub] [pulsar] Technoboy- merged pull request #17867: [fix][broker] Fix system service namespace create internal event topic.
Technoboy- merged PR #17867: URL: https://github.com/apache/pulsar/pull/17867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #17888: [fix][storage] Fix port conflict in bookkeeper.conf
liangyepianzhou commented on code in PR #17888: URL: https://github.com/apache/pulsar/pull/17888#discussion_r994146763 ## conf/bookkeeper.conf: ## @@ -694,7 +694,7 @@ httpServerEnabled=false # The http server port to listen on. Default value is 8080. # Use `8000` as the port to keep it consistent with prometheus stats provider -httpServerPort=8000 +httpServerPort=8001 Review Comment: Thanks for your feedback! When deploying the cluster before, there were often conflicts due to the port of prometheusStatsHttpPort=8000. Then I found that there are two configurations whose port is 8000 in the bookkeeper. If not for this reason I will redeploy the cluster and find out the real reason for the port conflict later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #10: Find libpulsarwithdeps.a when LINK_STATIC is ON
BewareMyPower commented on PR #10: URL: https://github.com/apache/pulsar-client-python/pull/10#issuecomment-1277033670 @merlimat Let's continue the [discussion](https://github.com/apache/pulsar-client-python/pull/11#discussion_r994085749) here. I don't understand well about the advantage of packaging both `libpulsar.so` and `libboost_python.so` (than including `libboost_python.a` and `libpulsarwithdeps.a`). > If we use the .a, everything is visible and subject to symbols conflict (eg if you load another Python extension that uses this symbols) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r57342 [1/2] - in /dev/pulsar/pulsar-2.10.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/
Author: jianghaiting Date: Thu Oct 13 04:58:18 2022 New Revision: 57342 Log: Staging artifacts and signature for Pulsar release 2.10.2 Added: dev/pulsar/pulsar-2.10.2-candidate-3/ dev/pulsar/pulsar-2.10.2-candidate-3/DEB/ dev/pulsar/pulsar-2.10.2-candidate-3/DEB/Packages.gz (with props) dev/pulsar/pulsar-2.10.2-candidate-3/DEB/Packages.gz.asc dev/pulsar/pulsar-2.10.2-candidate-3/DEB/Packages.gz.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client-dev.deb (with props) dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client-dev.deb.asc dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client-dev.deb.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client.deb (with props) dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client.deb.asc dev/pulsar/pulsar-2.10.2-candidate-3/DEB/apache-pulsar-client.deb.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/ dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-2.10.2-1.x86_64.rpm (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-2.10.2-1.x86_64.rpm.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-2.10.2-1.x86_64.rpm.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.10.2-1.x86_64.rpm (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.10.2-1.x86_64.rpm.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-debuginfo-2.10.2-1.x86_64.rpm.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-devel-2.10.2-1.x86_64.rpm (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-devel-2.10.2-1.x86_64.rpm.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/apache-pulsar-client-devel-2.10.2-1.x86_64.rpm.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/ dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/028f5bdf43fc1c6639519a475447e12dd98cd4824de57693d5d7450a1d14a48d-filelists.sqlite.bz2 (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/028f5bdf43fc1c6639519a475447e12dd98cd4824de57693d5d7450a1d14a48d-filelists.sqlite.bz2.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/028f5bdf43fc1c6639519a475447e12dd98cd4824de57693d5d7450a1d14a48d-filelists.sqlite.bz2.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/62ea12effe26546733aace32a84be8cd493d04f1d5757a01f76fb62667421880-other.xml.gz (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/62ea12effe26546733aace32a84be8cd493d04f1d5757a01f76fb62667421880-other.xml.gz.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/62ea12effe26546733aace32a84be8cd493d04f1d5757a01f76fb62667421880-other.xml.gz.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/736d5eb499d782aefc289297b1c95c0f5c2a870867a5d51a50f43fca99f1f50c-primary.sqlite.bz2 (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/736d5eb499d782aefc289297b1c95c0f5c2a870867a5d51a50f43fca99f1f50c-primary.sqlite.bz2.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/736d5eb499d782aefc289297b1c95c0f5c2a870867a5d51a50f43fca99f1f50c-primary.sqlite.bz2.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/7452284bc4aa1e769a95bbea0741d6cd196066f82feaa280d3b745c072e76fbc-other.sqlite.bz2 (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/7452284bc4aa1e769a95bbea0741d6cd196066f82feaa280d3b745c072e76fbc-other.sqlite.bz2.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/7452284bc4aa1e769a95bbea0741d6cd196066f82feaa280d3b745c072e76fbc-other.sqlite.bz2.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/a965187309c2b038c7a0e608c40ba77ac16a0e6ec6c6f2ed1a272ebbd813b9cf-filelists.xml.gz (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/a965187309c2b038c7a0e608c40ba77ac16a0e6ec6c6f2ed1a272ebbd813b9cf-filelists.xml.gz.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/a965187309c2b038c7a0e608c40ba77ac16a0e6ec6c6f2ed1a272ebbd813b9cf-filelists.xml.gz.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/e4ad77096f9190fbe4469d2509cbacd3290fe6bfc1e9187c297f5c653231cdb5-primary.xml.gz (with props) dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/e4ad77096f9190fbe4469d2509cbacd3290fe6bfc1e9187c297f5c653231cdb5-primary.xml.gz.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/e4ad77096f9190fbe4469d2509cbacd3290fe6bfc1e9187c297f5c653231cdb5-primary.xml.gz.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/repomd.xml dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/repomd.xml.asc dev/pulsar/pulsar-2.10.2-candidate-3/RPMS/repodata/repomd.xml.sha512 dev/pulsar/pulsar-2.10.2-candidate-3/apache-pulsar-2.10.2-bin.tar.gz (with props) dev/pulsar/pulsar-2.10.2-candidate-3/apache-pulsar-2.10.2-bin.tar.gz.asc
svn commit: r57342 [2/2] - in /dev/pulsar/pulsar-2.10.2-candidate-3: ./ DEB/ RPMS/ RPMS/repodata/ connectors/
Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.asc == --- dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.asc (added) +++ dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.asc Thu Oct 13 04:58:18 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEAlHmu9irQwds/9X0v47fRUCjIcQFAmNHj9gACgkQv47fRUCj +IcS1Hg/+LBc/1W3cWg2o7unA83xjkfaXOelWWpfAq/IeAAhpChQBOVqdtMyedukb +kmhwpDl/hN69Azt2q0JtdCzOMeP9nMgNU7dp1XI2pPPmow1WiSB+ZM+JUJYwXQqc +kikxEteJB+F19NcyCn8UiipLHcbXxeAB5bqwW70gNWVKcKGs1FSIUEN7v2XUFZWZ +Jh6zQB+mZYmGPljYTPYYwk3R9DFtp/lEtxzGdcjSc0MTLIJCyzmhuwYXlmIwVVSg +wgEPdId3SiQok4Sd3CXcBvnouk4mxuC3r46VmEbB2jzIKnHjMoYNdM4G108BUxlS +6bTToiNGzCayS8f31V/6YCx/ZLp52dJDXtOtVqbcpoByhuoaTV4HZLv/VpBXbU0U +dkvSBeSCk9yix+ZQfuc1PMz8gt6qNaseK3qmwdKvje7e6NNW5x0AsV7B2akjECpJ +YVZnjDZlNh2VQah+HixOoH5rQvmP8kVJXvm2qvuH/EMBtldgrrfn5HffiUq2Scj1 +Ut1aMXh0Yyc/lLoVO/s8fR2owGsgv2jsPJUyJGjXVzZltbHYeUI9Me0PloqrdeqR +fA/hdGfmMjshzuyPplsuaHSdK6KgJk6Pem+tk4hvdUeSdJt5Vp9jG6Jlg/FNroWs +0WVagX8ddyeBqSmst8b/FYgKrB3gBMgzv3smGk1GO6nEKph32as= +=Yh0T +-END PGP SIGNATURE- Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.sha512 == --- dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.sha512 (added) +++ dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-mysql-2.10.2.nar.sha512 Thu Oct 13 04:58:18 2022 @@ -0,0 +1 @@ +6a721b76dd674faad581553ec01b02ae2b4000178c89a7bd47349f3081924f9dafd48f4f60b2fda9a508611c3a6be244f760b9d1b3dd2c66441b460e52154445 ./connectors/pulsar-io-debezium-mysql-2.10.2.nar Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar == Binary file - no diff available. Propchange: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar -- svn:mime-type = application/octet-stream Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.asc == --- dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.asc (added) +++ dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.asc Thu Oct 13 04:58:18 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEAlHmu9irQwds/9X0v47fRUCjIcQFAmNHj9EACgkQv47fRUCj +IcSXIA//ZYcqqeaNYC5sd43WE5K5g4+mewOTKHkHRcHoJqfZqVWxmRwIyXfGx/Ph +FUbLfo3Cgnvd3qZ/GwmJ8G28XEXle8pltq620ii6z0ffpU0iMoPyHjqx6FsM/PQI +SObPILXgJXedwcyyeVcOL5l6X2tC8YA2G/jnRVOoW9IOG0wJejIfQDRJvM3qf25e +RhTMh0KSr/178v5tK1VQ89O0cPeGukRpDHQHvaFC7hGIWQFFZ95GVChw4U73sFA8 +HAmROZ8cwunApTfojH7grnfz/yhm4reOom3erTg2VofHGpRYj0H8iLj1CeZMYDJ2 +X9tF6oSkgTBwJt4j3mb3MZVHl36U7LFOh05tqWWMmxL6FRaraNoLDyPXuLgFexhx +JNtWHtfol6JSglRAmsS7d/rywlCHpT6KQT10ibtjmnzmsnKaWvthz3Os7TmK2vid +CSuknUrXr8OyQuqWEn0JcEVDP70r/+W1k+BC8gv7xgWPxm69HdIbhZKnXPPBxWXL +R2JQQ/6LLpr+lH8MqMr+j0UWS97DsA2QcgGBZfX+mTFQ5RPLNHpdKrxHStBND5CX +wpJ0fXxgl+jINIK/CzKELuoEe2N/M2IN+VGbfQ6ObHpLKutvIp3SCXs5NBFkXBgb +w2lHRIBKta5yRcYyofdabth416ILGe+89F960Mt4BbVqbu4zUPI= +=s6KE +-END PGP SIGNATURE- Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.sha512 == --- dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.sha512 (added) +++ dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-oracle-2.10.2.nar.sha512 Thu Oct 13 04:58:18 2022 @@ -0,0 +1 @@ +c10cc5f3172383d26a1a986bd43b3a4e8257e1cbcab151f5e4b616b5e98916f33efd1b470cf83b4b502b677a96320ca52606a9f0db1f641a6dc96017fcdd78f7 ./connectors/pulsar-io-debezium-oracle-2.10.2.nar Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-postgres-2.10.2.nar == Binary file - no diff available. Propchange: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-postgres-2.10.2.nar -- svn:mime-type = application/octet-stream Added: dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-postgres-2.10.2.nar.asc == --- dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-postgres-2.10.2.nar.asc (added) +++ dev/pulsar/pulsar-2.10.2-candidate-3/connectors/pulsar-io-debezium-postgres-2.10.2.nar.asc Thu Oct 13 04:58:18
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17888: [fix][storage] Fix port conflict in bookkeeper.conf
codelipenghui commented on code in PR #17888: URL: https://github.com/apache/pulsar/pull/17888#discussion_r994142418 ## conf/bookkeeper.conf: ## @@ -694,7 +694,7 @@ httpServerEnabled=false # The http server port to listen on. Default value is 8080. # Use `8000` as the port to keep it consistent with prometheus stats provider -httpServerPort=8000 +httpServerPort=8001 Review Comment: @liangyepianzhou If the bookie side enabled the http server, prometheus should also use the http server port, not a separate port. Can you reproduce the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun opened a new pull request, #252: fix blog edit url
tisonkun opened a new pull request, #252: URL: https://github.com/apache/pulsar-site/pull/252 blog sources have been changed. cc @Anonymitaet @urfreespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy
tjiuming commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r994140864
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -2354,72 +2355,105 @@ private void scheduleDeferredTrimming(boolean
isTruncate, CompletableFuture p
}
private void maybeOffloadInBackground(CompletableFuture
promise) {
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() != NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+if (config.getLedgerOffloader() == null || config.getLedgerOffloader()
== NullLedgerOffloader.INSTANCE
+|| config.getLedgerOffloader().getOffloadPolicies() == null) {
+return;
+}
+
+final OffloadPoliciesImpl policies =
config.getLedgerOffloader().getOffloadPolicies();
+final long offloadThresholdInBytes =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInBytes()).orElse(-1L);
+final long offloadThresholdInSeconds =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInSeconds()).orElse(-1L);
+if (offloadThresholdInBytes >= 0 || offloadThresholdInSeconds >= 0) {
executor.executeOrdered(name, safeRun(() ->
maybeOffload(promise)));
}
}
private void maybeOffload(CompletableFuture finalPromise) {
if (!offloadMutex.tryLock()) {
scheduledExecutor.schedule(safeRun(() ->
maybeOffloadInBackground(finalPromise)),
- 100, TimeUnit.MILLISECONDS);
-} else {
-CompletableFuture unlockingPromise = new
CompletableFuture<>();
-unlockingPromise.whenComplete((res, ex) -> {
-offloadMutex.unlock();
-if (ex != null) {
-finalPromise.completeExceptionally(ex);
-} else {
-finalPromise.complete(res);
-}
-});
+100, TimeUnit.MILLISECONDS);
+return;
+}
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() !=
NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
-!= null) {
-long threshold =
config.getLedgerOffloader().getOffloadPolicies()
-.getManagedLedgerOffloadThresholdInBytes();
-
-long sizeSummed = 0;
-long alreadyOffloadedSize = 0;
-long toOffloadSize = 0;
-
-ConcurrentLinkedDeque toOffload = new
ConcurrentLinkedDeque<>();
-
-// go through ledger list from newest to oldest and build a
list to offload in oldest to newest order
-for (Map.Entry e :
ledgers.descendingMap().entrySet()) {
-long size = e.getValue().getSize();
-sizeSummed += size;
-boolean alreadyOffloaded = e.getValue().hasOffloadContext()
-&& e.getValue().getOffloadContext().getComplete();
-if (alreadyOffloaded) {
-alreadyOffloadedSize += size;
-} else if (sizeSummed > threshold) {
-toOffloadSize += size;
-toOffload.addFirst(e.getValue());
-}
-}
+CompletableFuture unlockingPromise = new
CompletableFuture<>();
+unlockingPromise.whenComplete((res, ex) -> {
+offloadMutex.unlock();
+if (ex != null) {
+finalPromise.completeExceptionally(ex);
+} else {
+finalPromise.complete(res);
+}
+});
-if (toOffload.size() > 0) {
-log.info("[{}] Going to automatically offload ledgers {}"
-+ ", total size = {}, already offloaded =
{}, to offload = {}",
-name,
toOffload.stream().map(LedgerInfo::getLedgerId).collect(Collectors.toList()),
-sizeSummed, alreadyOffloadedSize, toOffloadSize);
-offloadLoop(unlockingPromise, toOffload,
PositionImpl.LATEST, Optional.empty());
-} else {
-// offloadLoop will complete immediately with an empty
list to offload
-log.debug("[{}] Nothing to offload,
[GitHub] [pulsar] codecov-commenter commented on pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup
codecov-commenter commented on PR #17869: URL: https://github.com/apache/pulsar/pull/17869#issuecomment-1277029704 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17869?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@7e4c746`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17869?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17869 +/- ## = Coverage ? 70.74% Complexity? 437 = Files ? 26 Lines ? 2246 Branches ? 245 = Hits ? 1589 Misses? 484 Partials ? 173 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `70.74% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower closed pull request #38: Build on Intel-based macOS with statically linked dependencies
BewareMyPower closed pull request #38: Build on Intel-based macOS with statically linked dependencies URL: https://github.com/apache/pulsar-client-cpp/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #38: Build on Intel-based macOS with statically linked dependencies
BewareMyPower commented on PR #38: URL: https://github.com/apache/pulsar-client-cpp/pull/38#issuecomment-1277029251 Close this PR since we cannot use `libpulsarwithdeps.a` to build a universal binary, which is recommended to use on macOS. See https://github.com/apache/pulsar-client-python/pull/11#discussion_r993427825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
codecov-commenter commented on PR #17992: URL: https://github.com/apache/pulsar/pull/17992#issuecomment-1277027509 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17992?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@51be6cd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17992?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17992 +/- ## = Coverage ? 70.74% Complexity? 437 = Files ? 26 Lines ? 2246 Branches ? 245 = Hits ? 1589 Misses? 484 Partials ? 173 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `70.74% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-client-python] branch main updated: Build wheel files in CI (#11)
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git
The following commit(s) were added to refs/heads/main by this push:
new 22c6797 Build wheel files in CI (#11)
22c6797 is described below
commit 22c6797aa83cb381182a8f8efdb200705ad3b42d
Author: Matteo Merli
AuthorDate: Wed Oct 12 21:45:15 2022 -0700
Build wheel files in CI (#11)
### Motivation
Added CI jobs to build wheel files for Mac and Linux.
### Modifications
* Simplified `CMakeList.txt` for easier detection of Boost-Python
* Added PR validation to build wheels for small number of combinations
* Added job triggered on when a tag is pushed to create all the
combination of wheels for Py (3.7, 3.8, 3.9, 3.10), OS (Mac, linux glibc, linux
musl) and CPU (x86_64 and arm64).
* The wheels binaries are tested to verify no libraries/symbols are missing
* The wheels are uploaded as artifacts for the job, so that they can later
be staged for official release.
---
.github/workflows/ci-build-release-wheels.yaml | 143 +
.github/workflows/ci-pr-validation.yaml| 92 +-
.gitignore | 4 +-
CMakeLists.txt | 106 +++
build-mac-wheels.sh| 334 -
...tall-cpp-client.sh => copy-deps-versionfile.sh} | 19 +-
.../{install-cpp-client.sh => dep-version.py} | 20 +-
build-support/install-cpp-client.sh| 47 ++-
.../install-cpp-client.sh => dependencies.yaml | 25 +-
.../build-wheel-inside-docker.sh | 26 +-
pkg/mac/build-dependencies.sh | 237 +++
pkg/mac/build-mac-wheels.sh| 80 +
pkg/mac/build-pulsar-cpp.sh| 64
.../install-cpp-client.sh => pkg/mac/common.sh | 19 +-
pkg/manylinux2014/Dockerfile | 56
pkg/manylinux_musl/Dockerfile | 53
.../install-cpp-client.sh => pkg/test-wheel.sh | 18 +-
pulsar-client-cpp-version.txt | 2 +-
pulsar/__init__.py | 2 +-
19 files changed, 849 insertions(+), 498 deletions(-)
diff --git a/.github/workflows/ci-build-release-wheels.yaml
b/.github/workflows/ci-build-release-wheels.yaml
new file mode 100644
index 000..f79bfc2
--- /dev/null
+++ b/.github/workflows/ci-build-release-wheels.yaml
@@ -0,0 +1,143 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build release wheels
+on:
+ push:
+tags:
+ - '*'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+
+ linux-wheel:
+name: Wheel ${{matrix.image.name}} - Py ${{matrix.python.version}} -
${{matrix.cpu.platform}}
+runs-on: ubuntu-22.04
+timeout-minutes: 300
+
+strategy:
+ fail-fast: false
+ matrix:
+image:
+ - {name: 'manylinux2014', py_suffix: ''}
+ - {name: 'manylinux_musl', py_suffix: '-alpine'}
+python:
+ - {version: '3.7', spec: 'cp37-cp37m'}
+ - {version: '3.8', spec: 'cp38-cp38'}
+ - {version: '3.9', spec: 'cp39-cp39'}
+ - {version: '3.10', spec: 'cp310-cp310'}
+cpu:
+ - {arch: 'x86_64', platform: 'x86_64'}
+ - {arch: 'aarch64', platform: 'arm64'}
+
+steps:
+ - name: checkout
+uses: actions/checkout@v3
+
+ - name: Set up QEMU
+uses: docker/setup-qemu-action@v2
+
+ - uses: docker/setup-buildx-action@v2
+ - run: build-support/copy-deps-versionfile.sh
+
+ - name: Build Manylinux Docker image
+uses: docker/build-push-action@v3
+with:
+ context: ./pkg/${{matrix.image.name}}
+ load: true
+ tags: build:latest
+ platforms: linux/${{matrix.cpu.arch}}
+ build-args: |
+PLATFORM=${{matrix.cpu.platform}}
+ARCH=${{matrix.cpu.arch}}
+PYTHON_VERSION=${{matrix.python.version}}
+
[GitHub] [pulsar-client-python] BewareMyPower merged pull request #11: Build wheel files in CI
BewareMyPower merged PR #11: URL: https://github.com/apache/pulsar-client-python/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #11: Build wheel files in CI
BewareMyPower commented on PR #11: URL: https://github.com/apache/pulsar-client-python/pull/11#issuecomment-1277026025 LGTM. Great job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16171: [fix][client] Fix duplicate messages caused by seek
nodece commented on code in PR #16171:
URL: https://github.com/apache/pulsar/pull/16171#discussion_r994136417
##
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##
@@ -252,6 +252,10 @@ private void receiveMessageFromConsumer(ConsumerImpl
consumer, boolean batchR
messagesFuture =
consumer.receiveAsync().thenApply(Collections::singletonList);
}
messagesFuture.thenAcceptAsync(messages -> {
+if (consumer.isDuringSeek()) {
+receiveMessageFromConsumer(consumer, batchReceive);
Review Comment:
> 2\. If `ConsumerImpl.seek` fails, the messages have popped from
`incomingMessages` cannot be consumed until `redeliver` executes
Good catch! We need to consider this.
> It looks like not only from the MultiTopicConsumer.
Yes.
> If it is from the user side, using a consumer to receive the messages and
another thread try to seek the subscription to another position, they will also
receive the duplicated messages right?
For `MultiTopicConsumer`, this is right, because the `MultiTopicConsumer`
has a loop to pulling the messsage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18015: [refactor][doc] Improve the IA of the Kubernetes chapter and merge into the deployment chapter
momo-jun commented on code in PR #18015: URL: https://github.com/apache/pulsar/pull/18015#discussion_r994135171 ## site2/docs/helm-deploy.md: ## @@ -1,17 +1,20 @@ --- id: helm-deploy -title: Deploy Pulsar cluster using Helm -sidebar_label: "Deployment" +title: Deploy a Pulsar cluster on Kubernetes +sidebar_label: "Deploy" --- -Before running `helm install`, you need to decide how to run Pulsar. -Options can be specified using Helm's `--set option.name=value` command line option. +Before deploying a Pulsar cluster, you need to [prepare Kubernetes resources](helm-prepare.md) and then continue with the following steps. +1. Select configuration options +2. Install dependent charts +3. Prepare Helm release +4. Deploy your Pulsar cluster using Helm ## Select configuration options -In each section, collect the options that are combined to use with the `helm install` command. +Specify how to run Pulsar using Helm's `--set option.name=value` command line option. In each section, collect the options that are combined to use with the `helm install` command. -### Kubernetes namespace + Kubernetes namespace Review Comment: Yes, that's my intention to make the hot links simple and clean for general steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17875: [improve][test] Improve NamespacesTest to reduce the execution time
codelipenghui commented on PR #17875: URL: https://github.com/apache/pulsar/pull/17875#issuecomment-1277021001 @poorbarcode Please help resolve the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17872: [fix][broker] ClassCastException when specify flow_or_qps_equally_div…
codelipenghui closed pull request #17872: [fix][broker] ClassCastException when specify flow_or_qps_equally_div… URL: https://github.com/apache/pulsar/pull/17872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17746: [fix][test] Fix TransactionTest failure due to clean up after class
codecov-commenter commented on PR #17746: URL: https://github.com/apache/pulsar/pull/17746#issuecomment-1277019374 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17746?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@c952f3c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17746?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17746 +/- ## = Coverage ? 70.92% Complexity? 437 = Files ? 26 Lines ? 2246 Branches ? 245 = Hits ? 1593 Misses? 480 Partials ? 173 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `70.92% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17880: [improve][broker] Add URL check when add/update cluster.
codecov-commenter commented on PR #17880: URL: https://github.com/apache/pulsar/pull/17880#issuecomment-1277015553 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17880?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@0678b82`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17880?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17880 +/- ## = Coverage ? 26.08% Complexity? 3221 = Files ? 367 Lines ?41172 Branches ? 4217 = Hits ?10740 Misses?28682 Partials ? 1750 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `26.08% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup
codelipenghui closed pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup URL: https://github.com/apache/pulsar/pull/17869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17985: [fix][broker] Fix starting bookie in the standalone not respecting the `standalone.conf`
codelipenghui commented on PR #17985: URL: https://github.com/apache/pulsar/pull/17985#issuecomment-1277010596 @RobertIndie > So I set it to confReturn.setLedgerStorageClass(SortedLedgerStorage.class.getName()); when starting the bookie in the standalone, and it works. Not sure what the exact reason is. But it looks like change the default value of the configuration. I think there should be some error logs from the bookie side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug.
codelipenghui closed pull request #17992: [improve][broker] Add test case for system topic schema not compatible bug. URL: https://github.com/apache/pulsar/pull/17992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] armanjupriya-er opened a new issue, #48: [Feature] Support IPV6 in Pulsar CPP Client
armanjupriya-er opened a new issue, #48: URL: https://github.com/apache/pulsar-client-cpp/issues/48 ## Support IPV6 Communication in Pulsar CPP client Currently, Pulsar CPP Client does not support IPV6 communication. Pulsar CPP client needs to support IPV6 communication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #15640: [fix][storage] Autorecovery default reppDnsResolverClass to ZkBookieRackAffinityMapping
codecov-commenter commented on PR #15640: URL: https://github.com/apache/pulsar/pull/15640#issuecomment-1277008218 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/15640?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15640](https://codecov.io/gh/apache/pulsar/pull/15640?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d090bc2) into [master](https://codecov.io/gh/apache/pulsar/commit/6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6c65ca0) will **decrease** coverage by `7.93%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/pulsar/pull/15640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15640 +/- ## - Coverage 34.91% 26.97% -7.94% + Complexity 5707 3534-2173 Files 607 393 -214 Lines 5339643418-9978 Branches 5712 4462-1250 - Hits 1864411714-6930 + Misses3211929864-2255 + Partials 2633 1840 -793 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `26.97% <0.00%> (-7.94%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/15640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...g/apache/pulsar/compaction/CompactedTopicImpl.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vQ29tcGFjdGVkVG9waWNJbXBsLmphdmE=) | `11.42% <0.00%> (+0.71%)` | :arrow_up: | | [...ava/org/apache/pulsar/broker/admin/v2/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../org/apache/pulsar/client/impl/RawMessageImpl.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Jhd01lc3NhZ2VJbXBsLmphdmE=) | `0.00% <0.00%> (-93.11%)` | :arrow_down: | | [.../pulsar/broker/service/SharedConsumerAssignor.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NoYXJlZENvbnN1bWVyQXNzaWdub3IuamF2YQ==) | `3.70% <0.00%> (-64.82%)` | :arrow_down: | | [.../pulsar/broker/service/PublishRateLimiterImpl.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1Ymxpc2hSYXRlTGltaXRlckltcGwuamF2YQ==) | `0.00% <0.00%> (-58.00%)` | :arrow_down: | | [...ion/pendingack/impl/MLPendingAckStoreProvider.java](https://codecov.io/gh/apache/pulsar/pull/15640/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9wZW5kaW5nYWNrL2ltcGwvTUxQZW5kaW5nQWNrU3RvcmVQcm92aWRlci5qYXZh) | `16.86% <0.00%> (-50.61%)` | :arrow_down: | |
[GitHub] [pulsar] codelipenghui closed issue #17640: slowly-test: org.apache.pulsar.broker.admin.AdminApiTest
codelipenghui closed issue #17640: slowly-test: org.apache.pulsar.broker.admin.AdminApiTest URL: https://github.com/apache/pulsar/issues/17640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (44ae3487cc2 -> e4d3c494677)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 44ae3487cc2 [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker (#18000) add e4d3c494677 [improve][test] Improve AdminApiTest to reduce the execution time (#17980) No new revisions were added by this update. Summary of changes: .../apache/pulsar/broker/admin/AdminApiTest.java | 131 - 1 file changed, 100 insertions(+), 31 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #17980: [improve][test] Improve AdminApiTest to reduce the execution time
codelipenghui merged PR #17980: URL: https://github.com/apache/pulsar/pull/17980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker (#18000)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 44ae3487cc2 [fix][broker] Fix the order of resource close in the
InMemoryDelayedDeliveryTracker (#18000)
44ae3487cc2 is described below
commit 44ae3487cc2aaaebdc5ce892d05eef76ca0384c6
Author: Cong Zhao
AuthorDate: Thu Oct 13 12:20:12 2022 +0800
[fix][broker] Fix the order of resource close in the
InMemoryDelayedDeliveryTracker (#18000)
---
.../delayed/InMemoryDelayedDeliveryTracker.java| 9 ++--
.../delayed/InMemoryDeliveryTrackerTest.java | 49 +++---
2 files changed, 49 insertions(+), 9 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
index 11d663322be..ba8a9311817 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
@@ -33,7 +33,7 @@ import
org.apache.pulsar.common.util.collections.TripleLongPriorityQueue;
@Slf4j
public class InMemoryDelayedDeliveryTracker implements DelayedDeliveryTracker,
TimerTask {
-private final TripleLongPriorityQueue priorityQueue = new
TripleLongPriorityQueue();
+protected final TripleLongPriorityQueue priorityQueue = new
TripleLongPriorityQueue();
private final PersistentDispatcherMultipleConsumers dispatcher;
@@ -41,7 +41,7 @@ public class InMemoryDelayedDeliveryTracker implements
DelayedDeliveryTracker, T
private final Timer timer;
// Current timeout or null if not set
-private Timeout timeout;
+protected Timeout timeout;
// Timestamp at which the timeout is currently set
private long currentTimeoutTarget;
@@ -265,7 +265,7 @@ public class InMemoryDelayedDeliveryTracker implements
DelayedDeliveryTracker, T
if (log.isDebugEnabled()) {
log.debug("[{}] Timer triggered", dispatcher.getName());
}
-if (timeout.isCancelled()) {
+if (timeout == null || timeout.isCancelled()) {
return;
}
@@ -279,10 +279,11 @@ public class InMemoryDelayedDeliveryTracker implements
DelayedDeliveryTracker, T
@Override
public void close() {
-priorityQueue.close();
if (timeout != null) {
timeout.cancel();
+timeout = null;
}
+priorityQueue.close();
}
@Override
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/delayed/InMemoryDeliveryTrackerTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/delayed/InMemoryDeliveryTrackerTest.java
index 1ff47a4ca50..11b681d80a6 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/delayed/InMemoryDeliveryTrackerTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/delayed/InMemoryDeliveryTrackerTest.java
@@ -28,13 +28,13 @@ import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
+import static org.testng.Assert.assertNull;
import static org.testng.Assert.assertTrue;
-
import io.netty.util.HashedWheelTimer;
import io.netty.util.Timeout;
import io.netty.util.Timer;
import io.netty.util.TimerTask;
-
+import io.netty.util.concurrent.DefaultThreadFactory;
import java.time.Clock;
import java.util.Collections;
import java.util.NavigableMap;
@@ -42,10 +42,7 @@ import java.util.Set;
import java.util.TreeMap;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
-
-import io.netty.util.concurrent.DefaultThreadFactory;
import lombok.Cleanup;
-
import org.apache.bookkeeper.mledger.impl.PositionImpl;
import
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
import org.awaitility.Awaitility;
@@ -433,4 +430,46 @@ public class InMemoryDeliveryTrackerTest {
assertFalse(tracker.shouldPauseAllDeliveries());
}
+@Test
+public void testClose() throws Exception {
+Timer timer = new HashedWheelTimer(new
DefaultThreadFactory("pulsar-in-memory-delayed-delivery-test"),
+1, TimeUnit.MILLISECONDS);
+
+PersistentDispatcherMultipleConsumers dispatcher =
mock(PersistentDispatcherMultipleConsumers.class);
+
+AtomicLong clockTime = new AtomicLong();
+Clock clock = mock(Clock.class);
+when(clock.millis()).then(x -> clockTime.get());
+
+final Exception[] exceptions = new Exception[1];
+
+InMemoryDelayedDeliveryTracker tracker = new
InMemoryDelayedDeliveryTracker(dispatcher, timer, 1, clock,
+true, 0)
[GitHub] [pulsar] codelipenghui merged pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
codelipenghui merged PR #18000: URL: https://github.com/apache/pulsar/pull/18000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
liangyepianzhou opened a new pull request, #17746: URL: https://github.com/apache/pulsar/pull/17746 ### Motivation Fix `testGetTxnID`: transaction Id is not begin at 0; `testSubscriptionRecreateTopic` : topic is already exsit. and `testPendingAckMarkDeletePosition`: failed to get TP manager stats due to `testEndTPRecoveringWhenManagerLedgerDisReadable` set a mock 'TransactionPendingAckStoreProvider' into pulsar. ### Modification fix them. ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] Anything that affects deployment ### Documentation - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) ### Matching PR in forked repository PR in forked repository: https://github.com/liangyepianzhou/pulsar/pull/3 After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class
codelipenghui closed pull request #17746: [fix][flaky-test] Fix TransactionTest failure due to clean up after class URL: https://github.com/apache/pulsar/pull/17746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall opened a new issue, #18029: Flaky-test: AdminApi2Test.resetClusters
michaeljmarshall opened a new issue, #18029: URL: https://github.com/apache/pulsar/issues/18029 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/actions/runs/3232396920/jobs/5309016207 ### Exception stacktrace ``` Error: Tests run: 77, Failures: 1, Errors: 0, Skipped: 61, Time elapsed: 478.051 s <<< FAILURE! - in org.apache.pulsar.broker.admin.AdminApi2Test Error: resetClusters(org.apache.pulsar.broker.admin.AdminApi2Test) Time elapsed: 0.235 s <<< FAILURE! org.apache.pulsar.client.admin.PulsarAdminException$ServerSideErrorException: --- An unexpected error occurred in the server --- Message: org.apache.zookeeper.KeeperException$NotEmptyException: KeeperErrorCode = Directory not empty for /managed-ledgers/prop-xyz/ns1/persistent Stacktrace: org.apache.pulsar.metadata.api.MetadataStoreException: org.apache.zookeeper.KeeperException$NotEmptyException: KeeperErrorCode = Directory not empty for /managed-ledgers/prop-xyz/ns1/persistent at org.apache.pulsar.metadata.impl.ZKMetadataStore.getException(ZKMetadataStore.java:449) at org.apache.pulsar.metadata.impl.ZKMetadataStore.handleDeleteResult(ZKMetadataStore.java:279) at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$batchOperation$7(ZKMetadataStore.java:191) at org.apache.zookeeper.MockZooKeeper.multi(MockZooKeeper.java:1006) at org.apache.pulsar.metadata.impl.ZKMetadataStore.batchOperation(ZKMetadataStore.java:165) at org.apache.pulsar.metadata.impl.batching.AbstractBatchedMetadataStore.flush(AbstractBatchedMetadataStore.java:117) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: org.apache.zookeeper.KeeperException$NotEmptyException: KeeperErrorCode = Directory not empty for /managed-ledgers/prop-xyz/ns1/persistent at org.apache.zookeeper.KeeperException.create(KeeperException.java:132) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.pulsar.metadata.impl.ZKMetadataStore.getException(ZKMetadataStore.java:439) ... 12 more at org.apache.pulsar.client.admin.PulsarAdminException.wrap(PulsarAdminException.java:252) at org.apache.pulsar.client.admin.internal.BaseResource.sync(BaseResource.java:351) at org.apache.pulsar.client.admin.internal.NamespacesImpl.deleteNamespace(NamespacesImpl.java:231) at org.apache.pulsar.broker.service.BrokerTestBase.deleteNamespaceGraceFully(BrokerTestBase.java:156) at org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.deleteNamespaceGraceFully(MockedPulsarServiceBaseTest.java:673) at org.apache.pulsar.broker.admin.AdminApi2Test.resetClusters(AdminApi2Test.java:167) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61) at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366) at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320) at org.testng.internal.TestInvoker.runConfigMethods(TestInvoker.java:701) at org.testng.internal.TestInvoker.runAfterGroupsConfigurations(TestInvoker.java:677) at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:661) at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174) at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46) at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822) at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147) at
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #11: Build wheel files in CI
BewareMyPower commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994096690
##
pkg/manylinux2014/Dockerfile:
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/manylinux2014_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+ARG PLATFORM
+ARG ARCH
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip3 install pyyaml
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
Anyway. It's not a blocker for this PR. This way works as it's protected by
test. I will check the macOS build soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16171: [fix][client] Fix duplicate messages caused by seek
codelipenghui commented on code in PR #16171:
URL: https://github.com/apache/pulsar/pull/16171#discussion_r994093124
##
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##
@@ -252,6 +252,10 @@ private void receiveMessageFromConsumer(ConsumerImpl
consumer, boolean batchR
messagesFuture =
consumer.receiveAsync().thenApply(Collections::singletonList);
}
messagesFuture.thenAcceptAsync(messages -> {
+if (consumer.isDuringSeek()) {
+receiveMessageFromConsumer(consumer, batchReceive);
Review Comment:
I also have a question about this part.
It looks like not only from the MultiTopicConsumer. If it is from the user
side, using a consumer to receive the messages and another thread try to seek
the subscription to another position, they will also receive the duplicated
messages right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #11: Build wheel files in CI
BewareMyPower commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994089236
##
pkg/manylinux2014/Dockerfile:
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/manylinux2014_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+ARG PLATFORM
+ARG ARCH
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip3 install pyyaml
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
Yeah, I see `auditwheel` includes the `libboost_python.so` and
`libpulsar.so`.
> (eg if you load another Python extension that uses this symbols)
But I don't understand when will this conflict happen. The deps or
libpulsar.so are still statically linked. Could you explain more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] zymap commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy
zymap commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r994088378
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -2354,72 +2355,105 @@ private void scheduleDeferredTrimming(boolean
isTruncate, CompletableFuture p
}
private void maybeOffloadInBackground(CompletableFuture
promise) {
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() != NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+if (config.getLedgerOffloader() == null || config.getLedgerOffloader()
== NullLedgerOffloader.INSTANCE
+|| config.getLedgerOffloader().getOffloadPolicies() == null) {
+return;
+}
+
+final OffloadPoliciesImpl policies =
config.getLedgerOffloader().getOffloadPolicies();
+final long offloadThresholdInBytes =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInBytes()).orElse(-1L);
+final long offloadThresholdInSeconds =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInSeconds()).orElse(-1L);
+if (offloadThresholdInBytes >= 0 || offloadThresholdInSeconds >= 0) {
executor.executeOrdered(name, safeRun(() ->
maybeOffload(promise)));
}
}
private void maybeOffload(CompletableFuture finalPromise) {
if (!offloadMutex.tryLock()) {
scheduledExecutor.schedule(safeRun(() ->
maybeOffloadInBackground(finalPromise)),
- 100, TimeUnit.MILLISECONDS);
-} else {
-CompletableFuture unlockingPromise = new
CompletableFuture<>();
-unlockingPromise.whenComplete((res, ex) -> {
-offloadMutex.unlock();
-if (ex != null) {
-finalPromise.completeExceptionally(ex);
-} else {
-finalPromise.complete(res);
-}
-});
+100, TimeUnit.MILLISECONDS);
+return;
+}
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() !=
NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
-!= null) {
-long threshold =
config.getLedgerOffloader().getOffloadPolicies()
-.getManagedLedgerOffloadThresholdInBytes();
-
-long sizeSummed = 0;
-long alreadyOffloadedSize = 0;
-long toOffloadSize = 0;
-
-ConcurrentLinkedDeque toOffload = new
ConcurrentLinkedDeque<>();
-
-// go through ledger list from newest to oldest and build a
list to offload in oldest to newest order
-for (Map.Entry e :
ledgers.descendingMap().entrySet()) {
-long size = e.getValue().getSize();
-sizeSummed += size;
-boolean alreadyOffloaded = e.getValue().hasOffloadContext()
-&& e.getValue().getOffloadContext().getComplete();
-if (alreadyOffloaded) {
-alreadyOffloadedSize += size;
-} else if (sizeSummed > threshold) {
-toOffloadSize += size;
-toOffload.addFirst(e.getValue());
-}
-}
+CompletableFuture unlockingPromise = new
CompletableFuture<>();
+unlockingPromise.whenComplete((res, ex) -> {
+offloadMutex.unlock();
+if (ex != null) {
+finalPromise.completeExceptionally(ex);
+} else {
+finalPromise.complete(res);
+}
+});
-if (toOffload.size() > 0) {
-log.info("[{}] Going to automatically offload ledgers {}"
-+ ", total size = {}, already offloaded =
{}, to offload = {}",
-name,
toOffload.stream().map(LedgerInfo::getLedgerId).collect(Collectors.toList()),
-sizeSummed, alreadyOffloadedSize, toOffloadSize);
-offloadLoop(unlockingPromise, toOffload,
PositionImpl.LATEST, Optional.empty());
-} else {
-// offloadLoop will complete immediately with an empty
list to offload
-log.debug("[{}] Nothing to offload, total
[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #11: Build wheel files in CI
merlimat commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994087683
##
pkg/manylinux2014/Dockerfile:
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/manylinux2014_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+ARG PLATFORM
+ARG ARCH
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip3 install pyyaml
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
Also, there is a check for the resulting wheels to be loaded in a fresh
container. That will protect against missing dependencies or linking errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #15640: [fix][storage] Autorecovery default reppDnsResolverClass to ZkBookieRackAffinityMapping
michaeljmarshall commented on PR #15640: URL: https://github.com/apache/pulsar/pull/15640#issuecomment-1276991928 Rebased and pushed with force to get new CI to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy
codelipenghui commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r994087613
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -2354,72 +2355,105 @@ private void scheduleDeferredTrimming(boolean
isTruncate, CompletableFuture p
}
private void maybeOffloadInBackground(CompletableFuture
promise) {
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() != NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+if (config.getLedgerOffloader() == null || config.getLedgerOffloader()
== NullLedgerOffloader.INSTANCE
+|| config.getLedgerOffloader().getOffloadPolicies() == null) {
+return;
+}
+
+final OffloadPoliciesImpl policies =
config.getLedgerOffloader().getOffloadPolicies();
+final long offloadThresholdInBytes =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInBytes()).orElse(-1L);
+final long offloadThresholdInSeconds =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInSeconds()).orElse(-1L);
+if (offloadThresholdInBytes >= 0 || offloadThresholdInSeconds >= 0) {
executor.executeOrdered(name, safeRun(() ->
maybeOffload(promise)));
}
}
private void maybeOffload(CompletableFuture finalPromise) {
if (!offloadMutex.tryLock()) {
scheduledExecutor.schedule(safeRun(() ->
maybeOffloadInBackground(finalPromise)),
- 100, TimeUnit.MILLISECONDS);
-} else {
-CompletableFuture unlockingPromise = new
CompletableFuture<>();
-unlockingPromise.whenComplete((res, ex) -> {
-offloadMutex.unlock();
-if (ex != null) {
-finalPromise.completeExceptionally(ex);
-} else {
-finalPromise.complete(res);
-}
-});
+100, TimeUnit.MILLISECONDS);
+return;
+}
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() !=
NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
-!= null) {
-long threshold =
config.getLedgerOffloader().getOffloadPolicies()
-.getManagedLedgerOffloadThresholdInBytes();
-
-long sizeSummed = 0;
-long alreadyOffloadedSize = 0;
-long toOffloadSize = 0;
-
-ConcurrentLinkedDeque toOffload = new
ConcurrentLinkedDeque<>();
-
-// go through ledger list from newest to oldest and build a
list to offload in oldest to newest order
-for (Map.Entry e :
ledgers.descendingMap().entrySet()) {
-long size = e.getValue().getSize();
-sizeSummed += size;
-boolean alreadyOffloaded = e.getValue().hasOffloadContext()
-&& e.getValue().getOffloadContext().getComplete();
-if (alreadyOffloaded) {
-alreadyOffloadedSize += size;
-} else if (sizeSummed > threshold) {
-toOffloadSize += size;
-toOffload.addFirst(e.getValue());
-}
-}
+CompletableFuture unlockingPromise = new
CompletableFuture<>();
+unlockingPromise.whenComplete((res, ex) -> {
+offloadMutex.unlock();
+if (ex != null) {
+finalPromise.completeExceptionally(ex);
+} else {
+finalPromise.complete(res);
+}
+});
-if (toOffload.size() > 0) {
-log.info("[{}] Going to automatically offload ledgers {}"
-+ ", total size = {}, already offloaded =
{}, to offload = {}",
-name,
toOffload.stream().map(LedgerInfo::getLedgerId).collect(Collectors.toList()),
-sizeSummed, alreadyOffloadedSize, toOffloadSize);
-offloadLoop(unlockingPromise, toOffload,
PositionImpl.LATEST, Optional.empty());
-} else {
-// offloadLoop will complete immediately with an empty
list to offload
-log.debug("[{}] Nothing to
[GitHub] [pulsar] michaeljmarshall commented on pull request #15640: [fix][storage] Autorecovery default reppDnsResolverClass to ZkBookieRackAffinityMapping
michaeljmarshall commented on PR #15640: URL: https://github.com/apache/pulsar/pull/15640#issuecomment-1276990187 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #11: Build wheel files in CI
BewareMyPower commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994085968
##
pkg/manylinux_musl/Dockerfile:
##
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/musllinux_1_1_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ARG ARCH
+ENV ARCH=${ARCH}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip install pyyaml
+
+RUN apk add cmake
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
I see `auditwheel` fix this issue by adding dynamic libraries to the
`site-packages` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #11: Build wheel files in CI
merlimat commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994085749
##
pkg/manylinux2014/Dockerfile:
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/manylinux2014_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+ARG PLATFORM
+ARG ARCH
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip3 install pyyaml
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
It’s on purpose. The Linux build is linking to the shared libs and
`auditwheel` will include them into the wheel archive.
It’s actually preferable to use the libpulsar.so (with all the other deps)
because it will hide the symbols inside the so. If we use the .a, everything is
visible and subject to symbols conflict (eg if you load another Python
extension that uses this symbols)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
michaeljmarshall commented on PR #17754: URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1276989174 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18025: [improve][misc] Highlight change to threading
michaeljmarshall commented on code in PR #18025: URL: https://github.com/apache/pulsar/pull/18025#discussion_r994084103 ## .github/PULL_REQUEST_TEMPLATE.md: ## @@ -83,6 +84,6 @@ apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. -The tests will be run in the forked repository until all PR review comments have +The tests will be run in the forkedrepository until all PR review comments have Review Comment: Good catch, I misread the diff initially thinking it was a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #251: correct homepage link and remove dangling bottom block
Anonymitaet commented on PR #251: URL: https://github.com/apache/pulsar-site/pull/251#issuecomment-1276982115 @tisonkun thanks for your contribution! Are you changing the default page from image 1 to image 2? Image 1  Image 2  Navigating uses to image1 is an intended behavior from doc's team since we want users to choose their path based on roles and objectives rather than give a "fixed" choice for them. Similar case: https://docs.starburst.io/get-started/index.html https://user-images.githubusercontent.com/50226895/195493181-7c9c21fb-0d6d-48e8-9b8c-2fd16bf95ce3.png;> @D-2-Ed @DaveDuggins thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #11: Build wheel files in CI
BewareMyPower commented on code in PR #11:
URL:
https://github.com/apache/pulsar-client-python/pull/11#discussion_r994079713
##
pkg/manylinux_musl/Dockerfile:
##
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/musllinux_1_1_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ARG ARCH
+ENV ARCH=${ARCH}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip install pyyaml
+
+RUN apk add cmake
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
```suggestion
./b2 -d0 address-model=64 cxxflags=-fPIC link=static threading=multi
variant=release install && \
```
##
pkg/manylinux2014/Dockerfile:
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+ARG ARCH
+FROM quay.io/pypa/manylinux2014_${ARCH}
+
+ARG PYTHON_VERSION
+ARG PYTHON_SPEC
+ARG PLATFORM
+ARG ARCH
+
+ENV PYTHON_VERSION=${PYTHON_VERSION}
+ENV PYTHON_SPEC=${PYTHON_SPEC}
+
+ENV PATH="/opt/python/${PYTHON_SPEC}/bin:${PATH}"
+
+ENV PYTHON_INCLUDE_DIR /opt/python/${PYTHON_SPEC}/include
+ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
+
+RUN pip3 install pyyaml
+
+ADD .build/dependencies.yaml /
+ADD .build/dep-version.py /usr/local/bin
+
+# Download and compile boost
+RUN BOOST_VERSION=$(dep-version.py boost) && \
+BOOST_VERSION_UNDESRSCORE=$(echo $BOOST_VERSION | sed 's/\./_/g') && \
+curl -O -L
https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz
&& \
+tar xfz boost_${BOOST_VERSION_UNDESRSCORE}.tar.gz && \
+cd boost_${BOOST_VERSION_UNDESRSCORE} && \
+./bootstrap.sh --with-libraries=python && \
+./b2 -d0 address-model=64 cxxflags=-fPIC link=shared threading=multi
variant=release install && \
Review Comment:
```suggestion
./b2 -d0 address-model=64 cxxflags=-fPIC link=static threading=multi
variant=release install && \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] zymap commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy
zymap commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r994079456
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -2354,72 +2355,105 @@ private void scheduleDeferredTrimming(boolean
isTruncate, CompletableFuture p
}
private void maybeOffloadInBackground(CompletableFuture
promise) {
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() != NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+if (config.getLedgerOffloader() == null || config.getLedgerOffloader()
== NullLedgerOffloader.INSTANCE
+|| config.getLedgerOffloader().getOffloadPolicies() == null) {
+return;
+}
+
+final OffloadPoliciesImpl policies =
config.getLedgerOffloader().getOffloadPolicies();
+final long offloadThresholdInBytes =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInBytes()).orElse(-1L);
+final long offloadThresholdInSeconds =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInSeconds()).orElse(-1L);
+if (offloadThresholdInBytes >= 0 || offloadThresholdInSeconds >= 0) {
executor.executeOrdered(name, safeRun(() ->
maybeOffload(promise)));
}
}
private void maybeOffload(CompletableFuture finalPromise) {
if (!offloadMutex.tryLock()) {
scheduledExecutor.schedule(safeRun(() ->
maybeOffloadInBackground(finalPromise)),
- 100, TimeUnit.MILLISECONDS);
-} else {
-CompletableFuture unlockingPromise = new
CompletableFuture<>();
-unlockingPromise.whenComplete((res, ex) -> {
-offloadMutex.unlock();
-if (ex != null) {
-finalPromise.completeExceptionally(ex);
-} else {
-finalPromise.complete(res);
-}
-});
+100, TimeUnit.MILLISECONDS);
+return;
+}
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() !=
NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
-!= null) {
-long threshold =
config.getLedgerOffloader().getOffloadPolicies()
-.getManagedLedgerOffloadThresholdInBytes();
-
-long sizeSummed = 0;
-long alreadyOffloadedSize = 0;
-long toOffloadSize = 0;
-
-ConcurrentLinkedDeque toOffload = new
ConcurrentLinkedDeque<>();
-
-// go through ledger list from newest to oldest and build a
list to offload in oldest to newest order
-for (Map.Entry e :
ledgers.descendingMap().entrySet()) {
-long size = e.getValue().getSize();
-sizeSummed += size;
-boolean alreadyOffloaded = e.getValue().hasOffloadContext()
-&& e.getValue().getOffloadContext().getComplete();
-if (alreadyOffloaded) {
-alreadyOffloadedSize += size;
-} else if (sizeSummed > threshold) {
-toOffloadSize += size;
-toOffload.addFirst(e.getValue());
-}
-}
+CompletableFuture unlockingPromise = new
CompletableFuture<>();
+unlockingPromise.whenComplete((res, ex) -> {
+offloadMutex.unlock();
+if (ex != null) {
+finalPromise.completeExceptionally(ex);
+} else {
+finalPromise.complete(res);
+}
+});
-if (toOffload.size() > 0) {
-log.info("[{}] Going to automatically offload ledgers {}"
-+ ", total size = {}, already offloaded =
{}, to offload = {}",
-name,
toOffload.stream().map(LedgerInfo::getLedgerId).collect(Collectors.toList()),
-sizeSummed, alreadyOffloadedSize, toOffloadSize);
-offloadLoop(unlockingPromise, toOffload,
PositionImpl.LATEST, Optional.empty());
-} else {
-// offloadLoop will complete immediately with an empty
list to offload
-log.debug("[{}] Nothing to offload, total
[GitHub] [pulsar] coderzc commented on a diff in pull request #17611: [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2
coderzc commented on code in PR #17611:
URL: https://github.com/apache/pulsar/pull/17611#discussion_r994078743
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java:
##
@@ -0,0 +1,572 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.delayed;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static org.apache.bookkeeper.mledger.util.Futures.executeWithRetry;
+import com.google.common.collect.HashBasedTable;
+import com.google.common.collect.Range;
+import com.google.common.collect.RangeMap;
+import com.google.common.collect.Table;
+import com.google.common.collect.TreeRangeMap;
+import com.google.protobuf.ByteString;
+import io.netty.util.Timeout;
+import io.netty.util.Timer;
+import java.time.Clock;
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import javax.annotation.concurrent.ThreadSafe;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.mledger.ManagedCursor;
+import org.apache.bookkeeper.mledger.ManagedLedgerException;
+import org.apache.bookkeeper.mledger.impl.PositionImpl;
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.DelayedIndex;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotMetadata;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegment;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegmentMetadata;
+import
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
+import org.apache.pulsar.common.util.collections.TripleLongPriorityQueue;
+
+@Slf4j
+@ThreadSafe
+public class BucketDelayedDeliveryTracker extends
InMemoryDelayedDeliveryTracker {
+
+protected static final int AsyncOperationTimeoutSeconds = 30;
+
+public static final String DELAYED_BUCKET_KEY_PREFIX =
"#pulsar.internal.delayed.bucket";
+
+public static final String DELIMITER = "_";
+
+private final long minIndexCountPerBucket;
+
+private final long timeStepPerBucketSnapshotSegment;
+
+private final int maxNumBuckets;
+
+private final ManagedCursor cursor;
+
+public final BucketSnapshotStorage bucketSnapshotStorage;
+
+private long numberDelayedMessages;
+
+private final BucketState lastMutableBucketState;
+
+private final TripleLongPriorityQueue sharedBucketPriorityQueue;
+
+private final RangeMap immutableBuckets;
+
+private final Table snapshotSegmentLastIndexTable;
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+ long fixedDelayDetectionLookahead,
+ BucketSnapshotStorage bucketSnapshotStorage,
+ long minIndexCountPerBucket, long
timeStepPerBucketSnapshotSegment,
+ int maxNumBuckets) {
+this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
+fixedDelayDetectionLookahead,
+bucketSnapshotStorage, minIndexCountPerBucket,
timeStepPerBucketSnapshotSegment, maxNumBuckets);
+}
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis, Clock clock,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+ long
[GitHub] [pulsar] Anonymitaet commented on issue #18026: [Doc][improve] Auto-detect broken links and integrate into CI process
Anonymitaet commented on issue #18026: URL: https://github.com/apache/pulsar/issues/18026#issuecomment-1276972995 For external tools, normally we use https://www.drlinkcheck.com/ to check URLs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode opened a new pull request, #18027: [ci-run][improve][test] Improve KeySharedSubscriptionTest to reduce the execution time
poorbarcode opened a new pull request, #18027: URL: https://github.com/apache/pulsar/pull/18027 relate to: - 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy
codelipenghui commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r994072402
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -2354,72 +2355,105 @@ private void scheduleDeferredTrimming(boolean
isTruncate, CompletableFuture p
}
private void maybeOffloadInBackground(CompletableFuture
promise) {
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() != NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+if (config.getLedgerOffloader() == null || config.getLedgerOffloader()
== NullLedgerOffloader.INSTANCE
+|| config.getLedgerOffloader().getOffloadPolicies() == null) {
+return;
+}
+
+final OffloadPoliciesImpl policies =
config.getLedgerOffloader().getOffloadPolicies();
+final long offloadThresholdInBytes =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInBytes()).orElse(-1L);
+final long offloadThresholdInSeconds =
+
Optional.ofNullable(policies.getManagedLedgerOffloadThresholdInSeconds()).orElse(-1L);
+if (offloadThresholdInBytes >= 0 || offloadThresholdInSeconds >= 0) {
executor.executeOrdered(name, safeRun(() ->
maybeOffload(promise)));
}
}
private void maybeOffload(CompletableFuture finalPromise) {
if (!offloadMutex.tryLock()) {
scheduledExecutor.schedule(safeRun(() ->
maybeOffloadInBackground(finalPromise)),
- 100, TimeUnit.MILLISECONDS);
-} else {
-CompletableFuture unlockingPromise = new
CompletableFuture<>();
-unlockingPromise.whenComplete((res, ex) -> {
-offloadMutex.unlock();
-if (ex != null) {
-finalPromise.completeExceptionally(ex);
-} else {
-finalPromise.complete(res);
-}
-});
+100, TimeUnit.MILLISECONDS);
+return;
+}
-if (config.getLedgerOffloader() != null
-&& config.getLedgerOffloader() !=
NullLedgerOffloader.INSTANCE
-&& config.getLedgerOffloader().getOffloadPolicies() != null
-&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
-!= null) {
-long threshold =
config.getLedgerOffloader().getOffloadPolicies()
-.getManagedLedgerOffloadThresholdInBytes();
-
-long sizeSummed = 0;
-long alreadyOffloadedSize = 0;
-long toOffloadSize = 0;
-
-ConcurrentLinkedDeque toOffload = new
ConcurrentLinkedDeque<>();
-
-// go through ledger list from newest to oldest and build a
list to offload in oldest to newest order
-for (Map.Entry e :
ledgers.descendingMap().entrySet()) {
-long size = e.getValue().getSize();
-sizeSummed += size;
-boolean alreadyOffloaded = e.getValue().hasOffloadContext()
-&& e.getValue().getOffloadContext().getComplete();
-if (alreadyOffloaded) {
-alreadyOffloadedSize += size;
-} else if (sizeSummed > threshold) {
-toOffloadSize += size;
-toOffload.addFirst(e.getValue());
-}
-}
+CompletableFuture unlockingPromise = new
CompletableFuture<>();
+unlockingPromise.whenComplete((res, ex) -> {
+offloadMutex.unlock();
+if (ex != null) {
+finalPromise.completeExceptionally(ex);
+} else {
+finalPromise.complete(res);
+}
+});
-if (toOffload.size() > 0) {
-log.info("[{}] Going to automatically offload ledgers {}"
-+ ", total size = {}, already offloaded =
{}, to offload = {}",
-name,
toOffload.stream().map(LedgerInfo::getLedgerId).collect(Collectors.toList()),
-sizeSummed, alreadyOffloadedSize, toOffloadSize);
-offloadLoop(unlockingPromise, toOffload,
PositionImpl.LATEST, Optional.empty());
-} else {
-// offloadLoop will complete immediately with an empty
list to offload
-log.debug("[{}] Nothing to
[GitHub] [pulsar] Technoboy- commented on issue #18011: Topic metadata unable to be updated using the admin REST API - Error 405 Method not Allowed
Technoboy- commented on issue #18011: URL: https://github.com/apache/pulsar/issues/18011#issuecomment-1276970996 > > > > @Technoboy- Can you confirm that the change did take place by editing the properties then running `curl -L http://:8080/admin/v2/persistentproperties` to see if they did in fact change? > > The curl command doesn't throw an error or return anything. yes, it works. https://user-images.githubusercontent.com/6297296/195490745-0130012c-76a2-4bd9-9140-601aab68ced2.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #18015: [refactor][doc] Improve the IA of the Kubernetes chapter and merge into the deployment chapter
Anonymitaet commented on code in PR #18015: URL: https://github.com/apache/pulsar/pull/18015#discussion_r994065210 ## site2/docs/helm-deploy.md: ## @@ -1,17 +1,20 @@ --- id: helm-deploy -title: Deploy Pulsar cluster using Helm -sidebar_label: "Deployment" +title: Deploy a Pulsar cluster on Kubernetes +sidebar_label: "Deploy" --- -Before running `helm install`, you need to decide how to run Pulsar. -Options can be specified using Helm's `--set option.name=value` command line option. +Before deploying a Pulsar cluster, you need to [prepare Kubernetes resources](helm-prepare.md) and then continue with the following steps. +1. Select configuration options +2. Install dependent charts +3. Prepare Helm release +4. Deploy your Pulsar cluster using Helm ## Select configuration options -In each section, collect the options that are combined to use with the `helm install` command. +Specify how to run Pulsar using Helm's `--set option.name=value` command line option. In each section, collect the options that are combined to use with the `helm install` command. -### Kubernetes namespace + Kubernetes namespace Review Comment: Why use instead of ###? Is this an intended behavior for not showing the heading on the right navigation? ## site2/docs/helm-deploy.md: ## @@ -304,9 +307,9 @@ helm repo update helm install pulsar-storage-provisioner streamnative/local-storage-provisioner ``` -### Install cert-manager + Install cert-manager -The Pulsar Helm chart uses the [cert-manager](https://github.com/jetstack/cert-manager) to provision and manage TLS certificates automatically. To enable TLS encryption for brokers or proxies, you need to install the cert-manager in advance. +The Pulsar Helm chart uses the [cert-manager](https://github.com/jetstack/cert-manager) to provision and manages TLS certificates automatically. To enable TLS encryption for brokers or proxies, you need to install the cert-manager in advance. Review Comment: ```suggestion The Pulsar Helm chart uses the [cert-manager](https://github.com/jetstack/cert-manager) to provision and manage TLS certificates automatically. To enable TLS encryption for brokers or proxies, you need to install the cert-manager in advance. ``` use xxx to provision and manage ## site2/docs/helm-deploy.md: ## @@ -376,3 +375,23 @@ To find the IP addresses of those components, run the following command: kubectl get service -n ``` +## Troubleshooting + +Although we have done our best to make these charts as seamless as possible, troubles do go out of our control occasionally. We have been collecting tips and tricks for troubleshooting common issues. Please check it first before raising an [issue](https://github.com/apache/pulsar/issues/new/choose), and feel free to add your solutions by creating a [Pull Request](https://github.com/apache/pulsar/compare). Review Comment: ```suggestion Although we have done our best to make these charts as seamless as possible, troubles do go out of our control occasionally. We have been collecting tips and tricks for troubleshooting common issues. Check it first before raising an [issue](https://github.com/apache/pulsar/issues/new/choose), and feel free to add your solutions by creating a [Pull Request](https://github.com/apache/pulsar/compare). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #18026: [Doc][improve] Auto-detect broken links and integrate into CI process
tisonkun commented on issue #18026: URL: https://github.com/apache/pulsar/issues/18026#issuecomment-1276963153 Since we build some pages on the fly instead of all content static, we may need an external sensor/crawler or static check after the site was built. Related issue: #18014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong opened a new issue, #18026: [Doc][improve] Auto-detect broken links and integrate into CI process
labuladong opened a new issue, #18026: URL: https://github.com/apache/pulsar/issues/18026 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? After #17495 and #17599, we can see many broken links in the Pulsar document. And more links may break during further evolution. ### What is your suggestion? In #17599 I use a script but it's not reliable enough so I have to check the links list manually. I suggest developing a reliable script to auto-detect the incorrect links in the Pulsar document. Maybe we can integrate this script into the CI process which is related to document change. Before development, I'd like to enumerate all kinds of broken links. ### 1. wrong markdown file reference For example the link of [this page](https://pulsar.apache.org/docs/next/admin-api-tenants/#get-configuration): https://user-images.githubusercontent.com/37220920/195486126-e8a3de23-4cc5-4319-a11f-7c222b2a1b4a.png;> The markdown content is `[configuration](reference-configuration.md)`, but the `reference-configuration.md` file not exists. ### 2. 404 URL path For example the link of [this page](https://pulsar.apache.org/docs/next/client-libraries-websocket/#query-param): https://user-images.githubusercontent.com/37220920/195486601-aea69e74-005d-4c2c-8fb1-02fcc80d1f9c.png;> The markdown content is `[type](/api/client/index.html?org/apache/pulsar/client/api/CompressionType.html)`, but the Pulsar site doesn't have this path. ### 3. confusing URL path For example the link of [this page](https://pulsar.apache.org/docs/next/functions-debug-cli/):  The markdown content is `[Pulsar Functions CLI](/tools/pulsar-admin/)`, but this refers to a confusing page: https://user-images.githubusercontent.com/37220920/195488231-79bb5f13-e832-415b-81f5-36c0330908b4.png;> ### 4. invalid title anchor We can use `#` to refer to a specific block of HTML this way: `[dataDir](reference-configuration.md#zookeeper-dataDir)`. So if our script can detect the anchor will be better. Our script should be able to detect these broken links and print warning messages to users. cc @tisonkun @Anonymitaet @momo-jun @michaeljmarshall ### Any reference? _No response_ ### Are you willing to submit a PR? - [X] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (c57d7a0c320 -> 7628fad4b27)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from c57d7a0c320 [refactor][client] Remove useless locks in batch receiving. (#18005) add 7628fad4b27 [improve][broker] Make CompactedTopicImpl.findStartPointLoop work more efficiently (#17976) No new revisions were added by this update. Summary of changes: .../pulsar/compaction/CompactedTopicImpl.java | 6 +- .../pulsar/compaction/CompactedTopicImplTest.java | 147 + 2 files changed, 151 insertions(+), 2 deletions(-) create mode 100644 pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicImplTest.java
[GitHub] [pulsar] codelipenghui merged pull request #17976: [improve][broker] Make CompactedTopicImpl.findStartPointLoop work more efficiently
codelipenghui merged PR #17976: URL: https://github.com/apache/pulsar/pull/17976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #17611: [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2
coderzc commented on code in PR #17611:
URL: https://github.com/apache/pulsar/pull/17611#discussion_r994061179
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java:
##
@@ -0,0 +1,573 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.delayed;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static org.apache.bookkeeper.mledger.util.Futures.executeWithRetry;
+import com.google.common.collect.HashBasedTable;
+import com.google.common.collect.Range;
+import com.google.common.collect.RangeMap;
+import com.google.common.collect.Table;
+import com.google.common.collect.TreeRangeMap;
+import com.google.protobuf.ByteString;
+import io.netty.util.Timeout;
+import io.netty.util.Timer;
+import java.nio.ByteBuffer;
+import java.time.Clock;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import javax.annotation.concurrent.ThreadSafe;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.mledger.ManagedCursor;
+import org.apache.bookkeeper.mledger.ManagedLedgerException;
+import org.apache.bookkeeper.mledger.impl.PositionImpl;
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.DelayedIndex;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotMetadata;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegment;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegmentMetadata;
+import
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
+import org.apache.pulsar.common.util.collections.TripleLongPriorityQueue;
+import org.roaringbitmap.RoaringBitmap;
+
+@Slf4j
+@ThreadSafe
+public class BucketDelayedDeliveryTracker extends
InMemoryDelayedDeliveryTracker {
+
+protected static final int AsyncOperationTimeoutSeconds = 30;
+
+public static final String DELAYED_BUCKET_KEY_PREFIX =
"#pulsar.internal.delayed.bucket";
+
+public static final String DELIMITER = "_";
+
+private final long minIndexCountPerBucket;
+
+private final long timeStepPerBucketSnapshotSegment;
+
+private final int maxNumBuckets;
+
+private final ManagedCursor cursor;
+
+public final BucketSnapshotStorage bucketSnapshotStorage;
+
+private long numberDelayedMessages;
+
+private final BucketState lastMutableBucketState;
+
+private final TripleLongPriorityQueue sharedBucketPriorityQueue;
+
+private final RangeMap immutableBuckets;
+
+private final Table snapshotSegmentLastIndexTable;
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+ long fixedDelayDetectionLookahead,
+ BucketSnapshotStorage bucketSnapshotStorage,
+ long minIndexCountPerBucket, long
timeStepPerBucketSnapshotSegment,
+ int maxNumBuckets) {
+this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
+fixedDelayDetectionLookahead,
+bucketSnapshotStorage, minIndexCountPerBucket,
timeStepPerBucketSnapshotSegment, maxNumBuckets);
+}
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis, Clock clock,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+
[GitHub] [pulsar] coderzc commented on a diff in pull request #17611: [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2
coderzc commented on code in PR #17611:
URL: https://github.com/apache/pulsar/pull/17611#discussion_r994056727
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java:
##
@@ -0,0 +1,573 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.delayed;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static org.apache.bookkeeper.mledger.util.Futures.executeWithRetry;
+import com.google.common.collect.HashBasedTable;
+import com.google.common.collect.Range;
+import com.google.common.collect.RangeMap;
+import com.google.common.collect.Table;
+import com.google.common.collect.TreeRangeMap;
+import com.google.protobuf.ByteString;
+import io.netty.util.Timeout;
+import io.netty.util.Timer;
+import java.nio.ByteBuffer;
+import java.time.Clock;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import javax.annotation.concurrent.ThreadSafe;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.mledger.ManagedCursor;
+import org.apache.bookkeeper.mledger.ManagedLedgerException;
+import org.apache.bookkeeper.mledger.impl.PositionImpl;
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.DelayedIndex;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotMetadata;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegment;
+import
org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegmentMetadata;
+import
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
+import org.apache.pulsar.common.util.collections.TripleLongPriorityQueue;
+import org.roaringbitmap.RoaringBitmap;
+
+@Slf4j
+@ThreadSafe
+public class BucketDelayedDeliveryTracker extends
InMemoryDelayedDeliveryTracker {
+
+protected static final int AsyncOperationTimeoutSeconds = 30;
+
+public static final String DELAYED_BUCKET_KEY_PREFIX =
"#pulsar.internal.delayed.bucket";
+
+public static final String DELIMITER = "_";
+
+private final long minIndexCountPerBucket;
+
+private final long timeStepPerBucketSnapshotSegment;
+
+private final int maxNumBuckets;
+
+private final ManagedCursor cursor;
+
+public final BucketSnapshotStorage bucketSnapshotStorage;
+
+private long numberDelayedMessages;
+
+private final BucketState lastMutableBucketState;
+
+private final TripleLongPriorityQueue sharedBucketPriorityQueue;
+
+private final RangeMap immutableBuckets;
+
+private final Table snapshotSegmentLastIndexTable;
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+ long fixedDelayDetectionLookahead,
+ BucketSnapshotStorage bucketSnapshotStorage,
+ long minIndexCountPerBucket, long
timeStepPerBucketSnapshotSegment,
+ int maxNumBuckets) {
+this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
+fixedDelayDetectionLookahead,
+bucketSnapshotStorage, minIndexCountPerBucket,
timeStepPerBucketSnapshotSegment, maxNumBuckets);
+}
+
+BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers
dispatcher,
+ Timer timer, long tickTimeMillis, Clock clock,
+ boolean isDelayedDeliveryDeliverAtTimeStrict,
+
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #11: Build wheel files in CI
BewareMyPower commented on code in PR #11: URL: https://github.com/apache/pulsar-client-python/pull/11#discussion_r994056189 ## dependencies.yaml: ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +boost: 1.80.0 +cmake: 3.24.2 +protobuf: 3.20.0 +zlib: 1.2.12 +zstd: 1.5.2 +snappy: 1.1.9 +openssl: 1.1.1q +curl: 7.85.0 Review Comment: I see, I will review this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
coderzc commented on PR #18000: URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1276949086 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #45: Fix code format check using clang-format 10.0.0
BewareMyPower commented on PR #45: URL: https://github.com/apache/pulsar-client-cpp/pull/45#issuecomment-1276948836 @merlimat Yeah, removing these scripts looks good to me too. > I think we should stick with that and we should set the format in the CMakeFiles.txt too. So this PR would aim at sticking the clang-format to 11.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower closed pull request #43: Update README.md
BewareMyPower closed pull request #43: Update README.md URL: https://github.com/apache/pulsar-client-cpp/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #43: Update README.md
BewareMyPower commented on PR #43: URL: https://github.com/apache/pulsar-client-cpp/pull/43#issuecomment-1276948584 This part of README has changed, close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-client-cpp] branch main updated: Use parametrized job to build packages (#36)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new ce8fe5a Use parametrized job to build packages (#36) ce8fe5a is described below commit ce8fe5a68f5594f4c79b709a0818005811ea8999 Author: Matteo Merli AuthorDate: Wed Oct 12 19:30:35 2022 -0700 Use parametrized job to build packages (#36) ### Motivation Consolidated all the RPM/DEB/APK jobs into a single matrix --- .github/workflows/ci-build-binary-artifacts.yaml | 213 +++ .github/workflows/ci-pr-validation.yaml | 91 +++--- 2 files changed, 46 insertions(+), 258 deletions(-) diff --git a/.github/workflows/ci-build-binary-artifacts.yaml b/.github/workflows/ci-build-binary-artifacts.yaml index dd48231..21e13db 100644 --- a/.github/workflows/ci-build-binary-artifacts.yaml +++ b/.github/workflows/ci-build-binary-artifacts.yaml @@ -29,188 +29,21 @@ concurrency: jobs: - deb-packaging-x86_64: -name: Build Debian Package - x86_64 -runs-on: ubuntu-20.04 -timeout-minutes: 120 - -steps: - - name: checkout -uses: actions/checkout@v2 - - - name: Package Pulsar source -run: build-support/generate-source-archive.sh - - - uses: docker/setup-buildx-action@v2 - - run: build-support/copy-deps-versionfile.sh - - - name: Build dependencies Docker image -uses: docker/build-push-action@v3 -with: - context: ./pkg/deb - load: true - tags: build-deb-x86_64:latest - build-args: PLATFORM=x86_64 - cache-from: type=gha - cache-to: type=gha,mode=max - - - name: Build Debian packages -run: pkg/deb/docker-build-deb-x86_64.sh build-deb-x86_64:latest - - - name: Upload artifacts -uses: actions/upload-artifact@v3 -with: - name: deb-x86_64 - path: pkg/deb/BUILD/DEB - - deb-packaging-arm64: -name: Build Debian Package - Arm64 -runs-on: ubuntu-20.04 -timeout-minutes: 120 - -steps: - - name: checkout -uses: actions/checkout@v2 - - - name: Set up QEMU -uses: docker/setup-qemu-action@v1 - - - name: Package Pulsar source -run: build-support/generate-source-archive.sh - - - uses: docker/setup-buildx-action@v2 - - run: build-support/copy-deps-versionfile.sh - - - name: Build dependencies Docker image -uses: docker/build-push-action@v3 -with: - context: ./pkg/deb - load: true - tags: build-deb-arm64:latest - build-args: PLATFORM=aarch64 - platforms: linux/arm64 - cache-from: type=gha - cache-to: type=gha,mode=max - - - name: Build Debian packages -run: pkg/deb/docker-build-deb-arm64.sh build-deb-arm64:latest - - - name: Upload artifacts -uses: actions/upload-artifact@v3 -with: - name: deb-arm64 - path: pkg/deb/BUILD/DEB - - rpm-packaging-x86_64: -name: Build RPM Package - x86_64 -runs-on: ubuntu-20.04 -timeout-minutes: 120 - -steps: - - name: checkout -uses: actions/checkout@v2 - - - name: Package Pulsar source -run: build-support/generate-source-archive.sh - - - uses: docker/setup-buildx-action@v2 - - run: build-support/copy-deps-versionfile.sh - - - name: Build dependencies Docker image -uses: docker/build-push-action@v3 -with: - context: ./pkg/rpm - load: true - tags: build-rpm-x86_64:latest - build-args: PLATFORM=x86_64 - cache-from: type=gha - cache-to: type=gha,mode=max - - - name: Build RPM packages -run: pkg/rpm/docker-build-rpm-x86_64.sh build-rpm-x86_64:latest - - - name: Upload artifacts -uses: actions/upload-artifact@v3 -with: - name: rpm-x86_64 - path: pkg/rpm/RPMS - - rpm-packaging-arm64: -name: Build RPM Package - arm64 -runs-on: ubuntu-20.04 -timeout-minutes: 120 - -steps: - - name: checkout -uses: actions/checkout@v2 - - - name: Set up QEMU -uses: docker/setup-qemu-action@v1 - - - name: Package Pulsar source -run: build-support/generate-source-archive.sh - - - uses: docker/setup-buildx-action@v2 - - run: build-support/copy-deps-versionfile.sh - - - name: Build dependencies Docker image -uses: docker/build-push-action@v3 -with: - context: ./pkg/rpm - load: true - tags: build-rpm-arm64:latest - build-args: PLATFORM=aarch64 - platforms: linux/arm64 - cache-from: type=gha - cache-to: type=gha,mode=max - - - name: Build RPM packages -run: pkg/rpm/docker-build-rpm-arm64.sh build-rpm-arm64:latest - - - name:
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #36: Use parametrized job to build packages
BewareMyPower merged PR #36: URL: https://github.com/apache/pulsar-client-cpp/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #18025: [improve][misc] Highlight change to threading
tisonkun commented on code in PR #18025: URL: https://github.com/apache/pulsar/pull/18025#discussion_r994052500 ## .github/PULL_REQUEST_TEMPLATE.md: ## @@ -83,6 +84,6 @@ apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. -The tests will be run in the forked repository until all PR review comments have +The tests will be run in the forkedrepository until all PR review comments have Review Comment: Unintended changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] 01/04: Apply modernizer-maven-plugin to managed-ledger module. (#16363)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 44d45af6d21b4b4de8dfbdfeda148f7ab85219f5
Author: Marvin Cai
AuthorDate: Mon Aug 8 05:59:03 2022 -0700
Apply modernizer-maven-plugin to managed-ledger module. (#16363)
To encourage the use of modern & jdk builtin APIs.
---
managed-ledger/pom.xml | 18
.../bookkeeper/mledger/ManagedLedgerConfig.java| 6 ++--
.../mledger/impl/LedgerMetadataUtils.java | 11 ---
.../mledger/impl/ManagedCursorContainer.java | 7 ++---
.../bookkeeper/mledger/impl/ManagedCursorImpl.java | 34 +++---
.../mledger/impl/ManagedLedgerFactoryImpl.java | 5 ++--
.../bookkeeper/mledger/impl/ManagedLedgerImpl.java | 24 +++
.../bookkeeper/mledger/impl/OpReadEntry.java | 4 +--
.../bookkeeper/mledger/impl/RangeSetWrapper.java | 4 +--
.../cache/EntryCacheDefaultEvictionPolicy.java | 4 +--
.../mledger/impl/cache/EntryCacheDisabled.java | 7 ++---
.../mledger/impl/cache/RangeEntryCacheImpl.java| 9 +++---
.../impl/cache/RangeEntryCacheManagerImpl.java | 4 +--
.../bookkeeper/mledger/offload/OffloadUtils.java | 8 ++---
.../apache/bookkeeper/mledger/util/RangeCache.java | 4 +--
.../bookkeeper/mledger/SimpleBookKeeperTest.java | 4 +--
.../bookkeeper/mledger/impl/EntryCacheTest.java| 4 +--
.../mledger/impl/ManagedCursorConcurrencyTest.java | 10 ---
.../mledger/impl/ManagedCursorContainerTest.java | 4 ++-
...ManagedCursorIndividualDeletedMessagesTest.java | 6 ++--
.../mledger/impl/ManagedCursorListAckTest.java | 4 +--
.../bookkeeper/mledger/impl/ManagedCursorTest.java | 13 -
.../mledger/impl/ManagedLedgerBkTest.java | 17 ++-
.../ManagedLedgerFactoryChangeLedgerPathTest.java | 9 +++---
.../impl/ManagedLedgerSingleBookieTest.java| 4 +--
.../bookkeeper/mledger/impl/ManagedLedgerTest.java | 13 +
.../mledger/impl/NonDurableCursorTest.java | 11 ---
.../mledger/impl/OffloadPrefixReadTest.java| 10 +++
.../bookkeeper/mledger/impl/OffloadPrefixTest.java | 19 ++--
.../mledger/impl/RangeSetWrapperTest.java | 5 ++--
30 files changed, 149 insertions(+), 133 deletions(-)
diff --git a/managed-ledger/pom.xml b/managed-ledger/pom.xml
index dfa1ffeecde..39cfce5d6aa 100644
--- a/managed-ledger/pom.xml
+++ b/managed-ledger/pom.xml
@@ -124,6 +124,24 @@
+
+org.gaul
+modernizer-maven-plugin
+
+ true
+ 17
+
+
+
+modernizer
+verify
+
+ modernizer
+
+
+
+
+
org.apache.maven.plugins
maven-jar-plugin
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
index 788732e763a..92c9c911981 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
@@ -19,7 +19,7 @@
package org.apache.bookkeeper.mledger;
import static com.google.common.base.Preconditions.checkArgument;
-import com.google.common.base.Charsets;
+import java.nio.charset.StandardCharsets;
import java.time.Clock;
import java.util.Arrays;
import java.util.Map;
@@ -68,7 +68,7 @@ public class ManagedLedgerConfig {
private long readEntryTimeoutSeconds = 120;
private long addEntryTimeoutSeconds = 120;
private DigestType digestType = DigestType.CRC32C;
-private byte[] password = "".getBytes(Charsets.UTF_8);
+private byte[] password = "".getBytes(StandardCharsets.UTF_8);
private boolean unackedRangesOpenCacheSetEnabled = true;
private Class
bookKeeperEnsemblePlacementPolicyClassName;
private Map bookKeeperEnsemblePlacementPolicyProperties;
@@ -271,7 +271,7 @@ public class ManagedLedgerConfig {
*the password to set
*/
public ManagedLedgerConfig setPassword(String password) {
-this.password = password.getBytes(Charsets.UTF_8);
+this.password = password.getBytes(StandardCharsets.UTF_8);
return this;
}
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/LedgerMetadataUtils.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/LedgerMetadataUtils.java
index 8049220e964..b32b81b2349 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/LedgerMetadataUtils.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/LedgerMetadataUtils.java
@@ -18,7 +18,6 @@
*/
package org.apache.bookkeeper.mledger.impl;
-import
[pulsar] 02/04: [enh][broker] Add metrics for entry cache insertion, eviction (#17248)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit df33f59cb4f95bbbe1d93813db6be7d859684d2f
Author: Michael Marshall
AuthorDate: Wed Aug 24 14:00:45 2022 -0700
[enh][broker] Add metrics for entry cache insertion, eviction (#17248)
Fixes https://github.com/apache/pulsar/issues/16584
### Motivation
With the `RangeCache`, it is hard to reason about its behavior other than
cache hits/misses or the cache's size hitting the limit and triggering a size
based eviction. This PR adds 3 new metrics to help provide additional insight
into the cache's behavior. It adds `pulsar_ml_cache_inserted_entries_total`,
`pulsar_ml_cache_evicted_entries_total`, and `pulsar_ml_cache_entries`.
### Modifications
* Add new metrics for cache insertion, eviction, and current number of
entries.
* Add new methods to the `ManagedLedgerFactoryMXBean` interface.
* Update several method return values in the `RangeCache`.
* Update tests.
### Verifying this change
This change is covered by modified tests that already existed.
### Does this pull request potentially affect one of the following parts:
There is a breaking change to the `RangeCache` class for the `clear` and
the `evictLEntriesBeforeTimestamp` methods. The previous result was a `long`,
and now it is a `Pair`. The new result matches the same style as
`evictLeastAccessedEntries`. Given that this class is only meant for use within
the broker, I think it is reasonable to break these methods. I will send a note
to the mailing list.
### Documentation
- [x] `doc`
---
.../mledger/ManagedLedgerFactoryMXBean.java| 15
.../impl/ManagedLedgerFactoryMBeanImpl.java| 27 ++
.../mledger/impl/cache/RangeEntryCacheImpl.java| 14 +--
.../impl/cache/RangeEntryCacheManagerImpl.java | 4 +++-
.../apache/bookkeeper/mledger/util/RangeCache.java | 12 ++
.../mledger/impl/EntryCacheManagerTest.java| 18 +++
.../bookkeeper/mledger/util/RangeCacheTest.java| 5 ++--
.../stats/metrics/ManagedLedgerCacheMetrics.java | 3 +++
site2/docs/reference-metrics.md| 3 +++
9 files changed, 87 insertions(+), 14 deletions(-)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerFactoryMXBean.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerFactoryMXBean.java
index ea5b2074ffa..f71583ab886 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerFactoryMXBean.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerFactoryMXBean.java
@@ -66,4 +66,19 @@ public interface ManagedLedgerFactoryMXBean {
* Get the number of cache evictions during the last minute.
*/
long getNumberOfCacheEvictions();
+
+/**
+ * Cumulative number of entries inserted into the cache.
+ */
+long getCacheInsertedEntriesCount();
+
+/**
+ * Cumulative number of entries evicted from the cache.
+ */
+long getCacheEvictedEntriesCount();
+
+/**
+ * Current number of entries in the cache.
+ */
+long getCacheEntriesCount();
}
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryMBeanImpl.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryMBeanImpl.java
index d514d8381d9..a5f0c67e68a 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryMBeanImpl.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryMBeanImpl.java
@@ -19,6 +19,7 @@
package org.apache.bookkeeper.mledger.impl;
import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.LongAdder;
import org.apache.bookkeeper.mledger.ManagedLedgerFactoryMXBean;
import org.apache.pulsar.common.stats.Rate;
@@ -31,6 +32,10 @@ public class ManagedLedgerFactoryMBeanImpl implements
ManagedLedgerFactoryMXBean
final Rate cacheMisses = new Rate();
final Rate cacheEvictions = new Rate();
+private final LongAdder insertedEntryCount = new LongAdder();
+private final LongAdder evictedEntryCount = new LongAdder();
+private final LongAdder cacheEntryCount = new LongAdder();
+
public ManagedLedgerFactoryMBeanImpl(ManagedLedgerFactoryImpl factory)
throws Exception {
this.factory = factory;
}
@@ -64,6 +69,16 @@ public class ManagedLedgerFactoryMBeanImpl implements
ManagedLedgerFactoryMXBean
cacheEvictions.recordEvent();
}
+public void recordCacheInsertion() {
+insertedEntryCount.increment();
+cacheEntryCount.increment();
+}
+
+public void recordNumberOfCacheEntriesEvicted(int count) {
+
[pulsar] 04/04: [bug][broker] fix memory leak in case of error conditions in PendingReadsManager (#17995)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 1fc4ccf8240447d0b164e059400701365f2477e3
Author: Enrico Olivelli
AuthorDate: Wed Oct 12 10:58:05 2022 +0200
[bug][broker] fix memory leak in case of error conditions in
PendingReadsManager (#17995)
Co-authored-by: Enrico Olivelli
---
.../apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java| 5 +
1 file changed, 5 insertions(+)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
index 4c374d8ace6..30216871e76 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
@@ -356,6 +356,8 @@ public class PendingReadsManager {
@Override
public void
readEntriesFailed(ManagedLedgerException exception,
Object
dummyCtx3) {
+entries.forEach(Entry::release);
+
entriesFromLeft.forEach(Entry::release);
callback.readEntriesFailed(exception, ctx);
}
};
@@ -366,6 +368,7 @@ public class PendingReadsManager {
@Override
public void
readEntriesFailed(ManagedLedgerException exception, Object dummyCtx4) {
+entries.forEach(Entry::release);
callback.readEntriesFailed(exception, ctx);
}
};
@@ -388,6 +391,7 @@ public class PendingReadsManager {
@Override
public void
readEntriesFailed(ManagedLedgerException exception,
Object
dummyCtx6) {
+entries.forEach(Entry::release);
callback.readEntriesFailed(exception, ctx);
}
};
@@ -410,6 +414,7 @@ public class PendingReadsManager {
@Override
public void
readEntriesFailed(ManagedLedgerException exception,
Object
dummyCtx8) {
+entries.forEach(Entry::release);
callback.readEntriesFailed(exception, ctx);
}
};
[pulsar] branch branch-2.11 updated (2e85be99747 -> 1fc4ccf8240)
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 2e85be99747 [improve][client] Refactor SchemaHash to reduce call of hashFunction in SchemaHash (#17948) new 44d45af6d21 Apply modernizer-maven-plugin to managed-ledger module. (#16363) new df33f59cb4f [enh][broker] Add metrics for entry cache insertion, eviction (#17248) new 55a0cb4841e [managed-ledger] Do not send duplicate reads to BK/offloaders (#17241) new 1fc4ccf8240 [bug][broker] fix memory leak in case of error conditions in PendingReadsManager (#17995) The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: managed-ledger/pom.xml | 18 + .../bookkeeper/mledger/ManagedLedgerConfig.java| 6 +- .../mledger/ManagedLedgerFactoryMXBean.java| 15 + .../mledger/impl/LedgerMetadataUtils.java | 11 +- .../mledger/impl/ManagedCursorContainer.java | 7 +- .../bookkeeper/mledger/impl/ManagedCursorImpl.java | 34 +- .../mledger/impl/ManagedLedgerFactoryImpl.java | 5 +- .../impl/ManagedLedgerFactoryMBeanImpl.java| 27 ++ .../bookkeeper/mledger/impl/ManagedLedgerImpl.java | 24 +- .../bookkeeper/mledger/impl/OpReadEntry.java | 4 +- .../bookkeeper/mledger/impl/RangeSetWrapper.java | 4 +- .../cache/EntryCacheDefaultEvictionPolicy.java | 4 +- .../mledger/impl/cache/EntryCacheDisabled.java | 7 +- .../mledger/impl/cache/PendingReadsManager.java| 452 .../mledger/impl/cache/RangeEntryCacheImpl.java| 125 +++--- .../impl/cache/RangeEntryCacheManagerImpl.java | 8 +- .../bookkeeper/mledger/offload/OffloadUtils.java | 8 +- .../apache/bookkeeper/mledger/util/RangeCache.java | 16 +- .../bookkeeper/mledger/SimpleBookKeeperTest.java | 4 +- .../mledger/impl/EntryCacheManagerTest.java| 18 + .../bookkeeper/mledger/impl/EntryCacheTest.java| 4 +- .../mledger/impl/ManagedCursorConcurrencyTest.java | 10 +- .../mledger/impl/ManagedCursorContainerTest.java | 4 +- ...ManagedCursorIndividualDeletedMessagesTest.java | 6 +- .../mledger/impl/ManagedCursorListAckTest.java | 4 +- .../bookkeeper/mledger/impl/ManagedCursorTest.java | 13 +- .../mledger/impl/ManagedLedgerBkTest.java | 17 +- .../ManagedLedgerFactoryChangeLedgerPathTest.java | 9 +- .../impl/ManagedLedgerSingleBookieTest.java| 4 +- .../bookkeeper/mledger/impl/ManagedLedgerTest.java | 13 +- .../mledger/impl/NonDurableCursorTest.java | 11 +- .../mledger/impl/OffloadPrefixReadTest.java| 10 +- .../bookkeeper/mledger/impl/OffloadPrefixTest.java | 19 +- .../mledger/impl/RangeSetWrapperTest.java | 5 +- .../impl/cache/PendingReadsManagerTest.java| 462 + .../bookkeeper/mledger/util/RangeCacheTest.java| 5 +- .../stats/metrics/ManagedLedgerCacheMetrics.java | 3 + .../client/api/MessageDispatchThrottlingTest.java | 8 + site2/docs/reference-metrics.md| 3 + 39 files changed, 1225 insertions(+), 182 deletions(-) create mode 100644 managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java create mode 100644 managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManagerTest.java
[pulsar] 03/04: [managed-ledger] Do not send duplicate reads to BK/offloaders (#17241)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 55a0cb4841e1329bd2137611bad391b5f483ae70
Author: Enrico Olivelli
AuthorDate: Fri Sep 2 15:09:34 2022 +0200
[managed-ledger] Do not send duplicate reads to BK/offloaders (#17241)
---
.../mledger/impl/cache/PendingReadsManager.java| 447
.../mledger/impl/cache/RangeEntryCacheImpl.java| 106 +++--
.../impl/cache/PendingReadsManagerTest.java| 462 +
.../client/api/MessageDispatchThrottlingTest.java | 8 +
4 files changed, 986 insertions(+), 37 deletions(-)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
new file mode 100644
index 000..4c374d8ace6
--- /dev/null
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/PendingReadsManager.java
@@ -0,0 +1,447 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.mledger.impl.cache;
+
+import static
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.createManagedLedgerException;
+import io.prometheus.client.Counter;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.AllArgsConstructor;
+import lombok.Value;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.apache.bookkeeper.mledger.AsyncCallbacks;
+import org.apache.bookkeeper.mledger.Entry;
+import org.apache.bookkeeper.mledger.ManagedLedgerException;
+import org.apache.bookkeeper.mledger.impl.EntryImpl;
+
+/**
+ * PendingReadsManager tries to prevent sending duplicate reads to BK.
+ */
+public class PendingReadsManager {
+
+private static final Counter COUNT_ENTRIES_READ_FROM_BK = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_entries_read")
+.help("Total number of entries read from BK")
+.register();
+
+private static final Counter COUNT_ENTRIES_NOTREAD_FROM_BK = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_entries_notread")
+.help("Total number of entries not read from BK")
+.register();
+
+private static final Counter COUNT_PENDING_READS_MATCHED = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_matched")
+.help("Pending reads reused with perfect range match")
+.register();
+private static final Counter COUNT_PENDING_READS_MATCHED_INCLUDED = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_matched_included")
+.help("Pending reads reused by attaching to a read with a larger
range")
+.register();
+private static final Counter COUNT_PENDING_READS_MISSED = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_missed")
+.help("Pending reads that didn't find a match")
+.register();
+
+private static final Counter
COUNT_PENDING_READS_MATCHED_OVERLAPPING_MISS_LEFT = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_matched_overlapping_miss_left")
+.help("Pending reads that didn't find a match but they partially
overlap with another read")
+.register();
+
+private static final Counter
COUNT_PENDING_READS_MATCHED_BUT_OVERLAPPING_MISS_RIGHT = Counter
+.build()
+
.name("pulsar_ml_cache_pendingreads_matched_overlapping_miss_right")
+.help("Pending reads that didn't find a match but they partially
overlap with another read")
+.register();
+
+private static final Counter
COUNT_PENDING_READS_MATCHED_BUT_OVERLAPPING_MISS_BOTH = Counter
+.build()
+.name("pulsar_ml_cache_pendingreads_matched_overlapping_miss_both")
+.help("Pending reads that didn't find a match but
[GitHub] [pulsar] github-actions[bot] commented on issue #15477: Python Pulsar-Client: Import error with Python 3.10
github-actions[bot] commented on issue #15477: URL: https://github.com/apache/pulsar/issues/15477#issuecomment-1276940132 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Jason918 merged pull request #18005: [refactor][client] Remove useless locks in batch receiving
Jason918 merged PR #18005: URL: https://github.com/apache/pulsar/pull/18005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-go] maolinHu commented on issue #858: concurrent map iteration and map write
maolinHu commented on issue #858:
URL:
https://github.com/apache/pulsar-client-go/issues/858#issuecomment-1276938451
properties := make(map[string]string)
for _, data := range Arr {
msg := {
Payload: data,
Properties: properties,
}
p.sendAsync(ctx, msg, fn)
}
I guess it is caused by multiplexing map(pulsar.ProducerMessage.Properties)
when send asyn, This is an occasional bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #16153: PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.
github-actions[bot] commented on issue #16153: URL: https://github.com/apache/pulsar/issues/16153#issuecomment-1276939022 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [refactor][client] Remove useless locks in batch receiving. (#18005)
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c57d7a0c320 [refactor][client] Remove useless locks in batch receiving. (#18005) c57d7a0c320 is described below commit c57d7a0c32031854e50c45ebb7dce3263aa3a96d Author: Baodi Shi AuthorDate: Thu Oct 13 10:20:18 2022 +0800 [refactor][client] Remove useless locks in batch receiving. (#18005) --- .../main/java/org/apache/pulsar/client/impl/ConsumerBase.java | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java index e66675ceb6c..07206820b95 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java @@ -38,8 +38,6 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; import java.util.concurrent.atomic.AtomicLongFieldUpdater; -import java.util.concurrent.locks.Lock; -import java.util.concurrent.locks.ReentrantLock; import lombok.Getter; import lombok.Setter; import org.apache.pulsar.client.api.BatchReceivePolicy; @@ -95,7 +93,6 @@ public abstract class ConsumerBase extends HandlerState implements Consumer CONSUMER_EPOCH = AtomicLongFieldUpdater.newUpdater(ConsumerBase.class, "consumerEpoch"); @@ -910,13 +907,7 @@ public abstract class ConsumerBase extends HandlerState implements Consumer
[GitHub] [pulsar] github-actions[bot] commented on pull request #17522: [improve][transactions] Add command to list transaction coordinators
github-actions[bot] commented on PR #17522: URL: https://github.com/apache/pulsar/pull/17522#issuecomment-1276937493 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17577: [feat][pulsar-client-api] support to Cumulative Acknowledge for multiple partitions or topics in user friendly manner
github-actions[bot] commented on PR #17577: URL: https://github.com/apache/pulsar/pull/17577#issuecomment-1276937452 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] annotated tag v2.10.2-candidate-3 updated (11b5df797b2 -> 4e671d2a1d0)
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a change to annotated tag v2.10.2-candidate-3 in repository https://gitbox.apache.org/repos/asf/pulsar.git *** WARNING: tag v2.10.2-candidate-3 was modified! *** from 11b5df797b2 (commit) to 4e671d2a1d0 (tag) tagging 11b5df797b2e9cb48dfc38137f0b7ef736a8a47c (commit) replaces v2.10.2-candidate-2 by JiangHaiting on Thu Oct 13 10:07:34 2022 +0800 - Log - Release v2.10.2-candidate-3 -BEGIN PGP SIGNATURE- iQJMBAABCgA2FiEEAlHmu9irQwds/9X0v47fRUCjIcQFAmNHcuYYHGppYW5naGFp dGluZ0BhcGFjaGUub3JnAAoJEL+O30VAoyHEFwIP/2a+ipEvGP7NSxHhld58kNIJ yWasMdXHCXCcYi+adHf2vrfHtDcyjV9/m4ZdcerMnKd/EbEgk39P/JRFLH9vdWsc duHHa1apKaxxrgDFE8GsKabwflGwaf0/ZUieR6wia8SpsFJJIWAqF3kyLWLn0hZp s/qcWHum+Sqkx4rXArAJ8n6YFRb/LAK+U2CvEdCCWOxqNGKhPi3T1P81o3jJcztP U/U8MKZkGbaUp529nkirsSo888lGKkXkTIDFV7Rm39YVLQFSjTmzLgK5MFFks906 rx2s334VisxsPcHrqYKOqY9N/jS4PPdiOjki+4Zv8V0l2D5EPTmKE2RWi4t2e9mh kBh1wKZ2vkIZDJNrv9GfHE5R63HckaM5YnoqsvmjIjjzPP0/4OYUjtWxfIh4aGal qdcZSvIpKBifZC4Ak4tHilyHzR/bgSjzVZemQLTcNkjyiqksLUQ/0qNt7UAz2Lwh 5c0eyRZSucWFQkAkbb1uOUYyfGXDn/dn0sxzpAEWr3d29IY/kBFjKWbTSrzFo610 VYo6r/w7isVToDcad2xWdHrBiivtUedzqBE2IuWhHqC01rC7zaKIqzEJV01rbziC cchW4oEhS3B5ryCmHWk6jh8Ea2ByhoBxxbU6QsgaFA9e3BR1JU8UHCzkgKL6mJ8p nMtpGPeFbc7ZhEVuWazh =NU3e -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[GitHub] [pulsar] labuladong commented on issue #17495: [Doc] Tracking issue for incorrect contents and links
labuladong commented on issue #17495: URL: https://github.com/apache/pulsar/issues/17495#issuecomment-1276929751 > I think we need a broken links sensor to report and guard the condition. This is a great idea, I'll open an issue to discuss it in detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17867: [fix][broker] Fix system service namespace create internal event topic.
codecov-commenter commented on PR #17867: URL: https://github.com/apache/pulsar/pull/17867#issuecomment-1276925939 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17867?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@7e420c6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/pulsar/pull/17867?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #17867 +/- ## = Coverage ? 71.05% Complexity? 438 = Files ? 26 Lines ? 2246 Branches ? 245 = Hits ? 1596 Misses? 477 Partials ? 173 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `71.05% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: Avoid unnecessary creation of BitSetRecyclable objects (#17998)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 6c65ca0d8a8 Avoid unnecessary creation of BitSetRecyclable objects
(#17998)
6c65ca0d8a8 is described below
commit 6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b
Author: LinChen <1572139...@qq.com>
AuthorDate: Thu Oct 13 09:51:48 2022 +0800
Avoid unnecessary creation of BitSetRecyclable objects (#17998)
Co-authored-by: leolinchen
---
.../org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java| 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index b67c74fdc79..20f760d893a 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -2188,11 +2188,12 @@ public class ManagedCursorImpl implements ManagedCursor
{
individualDeletedMessages);
}
} else if (config.isDeletionAtBatchIndexLevelEnabled() &&
batchDeletedIndexes != null) {
-BitSetRecyclable bitSet =
batchDeletedIndexes.computeIfAbsent(position, (v) ->
-BitSetRecyclable.create().resetWords(position.ackSet));
BitSetRecyclable givenBitSet =
BitSetRecyclable.create().resetWords(position.ackSet);
-bitSet.and(givenBitSet);
-givenBitSet.recycle();
+BitSetRecyclable bitSet =
batchDeletedIndexes.computeIfAbsent(position, (v) -> givenBitSet);
+if (givenBitSet != bitSet) {
+bitSet.and(givenBitSet);
+givenBitSet.recycle();
+}
if (bitSet.isEmpty()) {
PositionImpl previousPosition =
ledger.getPreviousPosition(position);
individualDeletedMessages.addOpenClosed(previousPosition.getLedgerId(),
[GitHub] [pulsar] Technoboy- merged pull request #17998: [improve][broker] Avoid unnecessary creation of BitSetRecyclable objects
Technoboy- merged PR #17998: URL: https://github.com/apache/pulsar/pull/17998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] dave2wave opened a new pull request, #18025: [improve][misc] Highlight change to threading
dave2wave opened a new pull request, #18025: URL: https://github.com/apache/pulsar/pull/18025 Whenever a PR changes the threading model we need to make clear that we should track these changes ### Motivation I want follow changes in the threading model in order to help understand and document Pulsar's internal architecture. Adding a checkbox should hopefully make developers more thoughtful about explicitly noting changes to the threading model. ### Modifications Adds a checkbox about "the threading model" ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is to the PULL REQUEST TEMPLATE no test coverage required. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17599: [Doc] Batch of broken links
labuladong commented on issue #17599: URL: https://github.com/apache/pulsar/issues/17599#issuecomment-1276919045 The broken link list has been updated. And I'm trying to develop a reliable script to auto-detect broken links. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] 01/01: [improve][misc] Highlight change to threading
This is an automated email from the ASF dual-hosted git repository. wave pushed a commit to branch dave2wave-patch-3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 1eeb8ef1fb49b5f678435e4fe1f704c5edb577a8 Author: Dave Fisher AuthorDate: Wed Oct 12 18:40:40 2022 -0700 [improve][misc] Highlight change to threading Whenever a PR changes the threading model we need to make clear that we should track these changes --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1b984758380..b6ef48bda60 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -56,6 +56,7 @@ This change added tests and can be verified as follows: - [ ] The public API - [ ] The schema - [ ] The default values of configurations +- [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options @@ -83,6 +84,6 @@ apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. -The tests will be run in the forked repository until all PR review comments have +The tests will be run in the forkedrepository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. -->
[pulsar] branch dave2wave-patch-3 created (now 1eeb8ef1fb4)
This is an automated email from the ASF dual-hosted git repository. wave pushed a change to branch dave2wave-patch-3 in repository https://gitbox.apache.org/repos/asf/pulsar.git at 1eeb8ef1fb4 [improve][misc] Highlight change to threading This branch includes the following new commits: new 1eeb8ef1fb4 [improve][misc] Highlight change to threading The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar] branch master updated (92b47085b2c -> 240ca436d8a)
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 92b47085b2c [fix][txn] optimize the ack/send future in TransactionImpl (#1) add 240ca436d8a [improve][common] Add thread name for RateLimiter. (#18013) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pulsar/common/util/RateLimiter.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
[GitHub] [pulsar] Technoboy- merged pull request #18013: [improve][common] Add thread name for RateLimiter.
Technoboy- merged PR #18013: URL: https://github.com/apache/pulsar/pull/18013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: There is no master branch in pulsar-site
This is an automated email from the ASF dual-hosted git repository. wave pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new b97db86e150 There is no master branch in pulsar-site b97db86e150 is described below commit b97db86e15009c092831fe0032421d0235a445df Author: Dave Fisher AuthorDate: Wed Oct 12 18:04:08 2022 -0700 There is no master branch in pulsar-site --- .asf.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.asf.yaml b/.asf.yaml index 3b6a55f408c..b6c376f0293 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -28,7 +28,7 @@ github: rebase: false protected_branches: # Protect these branches for the website -master: +main: whatever: Just a placehold to make it take effects asf-site: whatever: Just a placehold to make it take effects
[pulsar-site] branch asf-site-next updated: Updated site at revision e2e0c30
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch asf-site-next
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/asf-site-next by this push:
new af6c019a6e2 Updated site at revision e2e0c30
af6c019a6e2 is described below
commit af6c019a6e26bbf1cc2693cae6d15a85824c1117
Author: Pulsar Site Updater
AuthorDate: Thu Oct 13 01:03:26 2022 +
Updated site at revision e2e0c30
---
content/index.html | 2 +-
.../config/reference-configuration-broker.md | 2 +-
.../config/reference-configuration-standalone.md | 2 +-
content/swagger/master/swagger.json| 106 ++---
content/swagger/master/swaggerfunctions.json | 78 +++
content/swagger/master/swaggerlookup.json | 24 ++---
content/swagger/master/swaggerpackages.json| 24 ++---
content/swagger/master/swaggersink.json| 24 ++---
content/swagger/master/swaggersource.json | 24 ++---
content/swagger/master/swaggertransactions.json| 24 ++---
content/swagger/master/v2/swagger.json | 106 ++---
content/swagger/master/v2/swaggerlookup.json | 24 ++---
content/swagger/master/v3/swaggerfunctions.json| 78 +++
content/swagger/master/v3/swaggerpackages.json | 24 ++---
content/swagger/master/v3/swaggersink.json | 24 ++---
content/swagger/master/v3/swaggersource.json | 24 ++---
content/swagger/master/v3/swaggertransactions.json | 24 ++---
17 files changed, 307 insertions(+), 307 deletions(-)
diff --git a/content/index.html b/content/index.html
index 52726222069..d3aee2338f2 100644
--- a/content/index.html
+++ b/content/index.html
@@ -23,7 +23,7 @@
!function(){function
t(t){document.documentElement.setAttribute("data-theme",t)}var e=function(){var
t=null;try{t=localStorage.getItem("theme")}catch(t){}return
t}();t(null!==e?e:"light")}(),document.documentElement.setAttribute("data-announcement-bar-initially-dismissed",function(){try{return"true"===localStorage.getItem("docusaurus.announcement.dismiss")}catch(t){}return!1}())
-Skip to main
content Pulsar Summit Asia 2022 will take place
on November 19th and 20th, 2022. The CFP is open now! https://sessionize.com/pulsar-summit-asi [...]
+Skip to main
content Pulsar Summit Asia 2022 will take place
on November 19th and 20th, 2022. The CFP is open now! https://sessionize.com/pulsar-summit-asi [...]
http://www.apache.org/; target="_blank" rel="noopener noreferrer"
class="footer__link-item">Foundationhttps://www.apache.org/events/current- [...]
Apache Pulsar is available under the
https://www.apache.org/licenses/LICENSE-2.0; target="_blank">Apache
License, version 2.0.
diff --git a/content/reference/latest/config/reference-configuration-broker.md
b/content/reference/latest/config/reference-configuration-broker.md
index 8b6f544be30..226efdd8083 100644
--- a/content/reference/latest/config/reference-configuration-broker.md
+++ b/content/reference/latest/config/reference-configuration-broker.md
@@ -2984,7 +2984,7 @@ Max memory size for broker handling messages sending from
producers.
**Type**: `int`
-**Default**: `869`
+**Default**: `868`
**Dynamic**: `true`
diff --git
a/content/reference/latest/config/reference-configuration-standalone.md
b/content/reference/latest/config/reference-configuration-standalone.md
index 8b6f544be30..226efdd8083 100644
--- a/content/reference/latest/config/reference-configuration-standalone.md
+++ b/content/reference/latest/config/reference-configuration-standalone.md
@@ -2984,7 +2984,7 @@ Max memory size for broker handling messages sending from
producers.
**Type**: `int`
-**Default**: `869`
+**Default**: `868`
**Dynamic**: `true`
diff --git a/content/swagger/master/swagger.json
b/content/swagger/master/swagger.json
index bf5a01668b7..221d386269b 100644
--- a/content/swagger/master/swagger.json
+++ b/content/swagger/master/swagger.json
@@ -22994,9 +22994,6 @@
"peerAddress" : {
"$ref" : "#/definitions/SocketAddress"
},
-"subscription" : {
- "type" : "string"
-},
"tlsCertificates" : {
"type" : "array",
"items" : {
@@ -23008,6 +23005,9 @@
},
"commandData" : {
"type" : "string"
+},
+"subscription" : {
+ "type" : "string"
}
}
},
@@ -23056,6 +23056,10 @@
"type" : "string",
"enum" : [ "producer_request_hold", "producer_exception",
"consumer_backlog_eviction" ]
},
+"limit" : {
+ "type" : "integer",
+ "format" : "int64"
+},
"limitSize" : {
"type" : "integer",
"format" : "int64"
@@ -23063,10 +23067,6 @@
Error while running github feature from .asf.yaml in pulsar-site!
An error occurred while running github feature in .asf.yaml!: [GitHub] Request error with message: "Branch not found". (status code: 404)
[pulsar-site] branch main updated: Protect master and deployment branches (#248)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new e2e0c30c407 Protect master and deployment branches (#248) e2e0c30c407 is described below commit e2e0c30c407d2986783a9c9deb72f839e1f674fa Author: tison AuthorDate: Thu Oct 13 08:42:30 2022 +0800 Protect master and deployment branches (#248) --- .asf.yaml | 8 1 file changed, 8 insertions(+) diff --git a/.asf.yaml b/.asf.yaml index 61f64641065..3b6a55f408c 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -26,6 +26,14 @@ github: squash: true merge: false rebase: false + protected_branches: +# Protect these branches for the website +master: + whatever: Just a placehold to make it take effects +asf-site: + whatever: Just a placehold to make it take effects +asf-site-next: + whatever: Just a placehold to make it take effects notifications: commits: commits@pulsar.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #248: Protect master and deployment branches
urfreespace merged PR #248: URL: https://github.com/apache/pulsar-site/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
