[GitHub] [pulsar] ziang123 commented on a diff in pull request #19027: [improve][sql] Some optimized points in #9224
ziang123 commented on code in PR #19027:
URL: https://github.com/apache/pulsar/pull/19027#discussion_r1083228971
##
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java:
##
@@ -589,42 +588,55 @@ public boolean advanceNextPosition() {
.filter(col ->
PulsarColumnHandle.HandleKeyValueType.NONE
.equals(col.getHandleKeyValueType()))
.collect(toImmutableSet()));
+
Optional>
decodedValue =
messageDecoder.decodeRow(this.currentMessage.getData());
decodedValue.ifPresent(currentRowValuesMap::putAll);
}
for (DecoderColumnHandle columnHandle : columnHandles) {
-if (columnHandle.isInternal()) {
-if
(PulsarInternalColumn.PARTITION.getName().equals(columnHandle.getName())) {
+//String names =
PulsarInternalColumn.getNameByColumnHandle(columnHandle);
+switch (columnHandle.getName()) {
+case "__partition__":
currentRowValuesMap.put(columnHandle,
longValueProvider(this.partition));
-} else if
(PulsarInternalColumn.EVENT_TIME.getName().equals(columnHandle.getName())) {
+break;
+case "__event_time__":
currentRowValuesMap.put(columnHandle,
PulsarFieldValueProviders.timeValueProvider(
this.currentMessage.getEventTime(),
this.currentMessage.getEventTime() == 0));
-} else if
(PulsarInternalColumn.PUBLISH_TIME.getName().equals(columnHandle.getName())) {
+break;
+case "__publish_time__":
currentRowValuesMap.put(columnHandle,
PulsarFieldValueProviders.timeValueProvider(
this.currentMessage.getPublishTime(),
this.currentMessage.getPublishTime() == 0));
-} else if
(PulsarInternalColumn.MESSAGE_ID.getName().equals(columnHandle.getName())) {
+break;
+case "__message_id__":
currentRowValuesMap.put(columnHandle, bytesValueProvider(
this.currentMessage.getMessageId().toString().getBytes()));
-} else if
(PulsarInternalColumn.SEQUENCE_ID.getName().equals(columnHandle.getName())) {
+break;
+case "__sequence_id__":
currentRowValuesMap.put(columnHandle,
longValueProvider(this.currentMessage.getSequenceId()));
-} else if
(PulsarInternalColumn.PRODUCER_NAME.getName().equals(columnHandle.getName())) {
+break;
+case "__producer_name__":
currentRowValuesMap.put(columnHandle,
bytesValueProvider(this.currentMessage.getProducerName().getBytes()));
-} else if
(PulsarInternalColumn.KEY.getName().equals(columnHandle.getName())) {
+break;
+case "__key__":
String key = this.currentMessage.getKey().orElse(null);
currentRowValuesMap.put(columnHandle,
bytesValueProvider(key == null ? null : key.getBytes()));
-} else if
(PulsarInternalColumn.PROPERTIES.getName().equals(columnHandle.getName())) {
+break;
+case "__properties__":
try {
currentRowValuesMap.put(columnHandle,
bytesValueProvider(
new
ObjectMapper().writeValueAsBytes(this.currentMessage.getProperties(;
} catch (JsonProcessingException e) {
throw new RuntimeException(e);
}
-} else {
-throw new IllegalArgumentException("unknown internal field
" + columnHandle.getName());
-}
+break;
+default:
+try {
+throw new IllegalArgumentException("unknown internal
field " + columnHandle.getName());
+} finally {
+break;
+}
Review Comment:
It was because I saw this 9224 issue, the third Internal Column decode
optimize
https://github.com/apache/pulsar/issues/9224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #19027: [improve][sql] Some optimized points in #9224
tisonkun commented on code in PR #19027:
URL: https://github.com/apache/pulsar/pull/19027#discussion_r1083228208
##
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java:
##
@@ -589,42 +588,55 @@ public boolean advanceNextPosition() {
.filter(col ->
PulsarColumnHandle.HandleKeyValueType.NONE
.equals(col.getHandleKeyValueType()))
.collect(toImmutableSet()));
+
Optional>
decodedValue =
messageDecoder.decodeRow(this.currentMessage.getData());
decodedValue.ifPresent(currentRowValuesMap::putAll);
}
for (DecoderColumnHandle columnHandle : columnHandles) {
-if (columnHandle.isInternal()) {
-if
(PulsarInternalColumn.PARTITION.getName().equals(columnHandle.getName())) {
+//String names =
PulsarInternalColumn.getNameByColumnHandle(columnHandle);
+switch (columnHandle.getName()) {
+case "__partition__":
currentRowValuesMap.put(columnHandle,
longValueProvider(this.partition));
-} else if
(PulsarInternalColumn.EVENT_TIME.getName().equals(columnHandle.getName())) {
+break;
+case "__event_time__":
currentRowValuesMap.put(columnHandle,
PulsarFieldValueProviders.timeValueProvider(
this.currentMessage.getEventTime(),
this.currentMessage.getEventTime() == 0));
-} else if
(PulsarInternalColumn.PUBLISH_TIME.getName().equals(columnHandle.getName())) {
+break;
+case "__publish_time__":
currentRowValuesMap.put(columnHandle,
PulsarFieldValueProviders.timeValueProvider(
this.currentMessage.getPublishTime(),
this.currentMessage.getPublishTime() == 0));
-} else if
(PulsarInternalColumn.MESSAGE_ID.getName().equals(columnHandle.getName())) {
+break;
+case "__message_id__":
currentRowValuesMap.put(columnHandle, bytesValueProvider(
this.currentMessage.getMessageId().toString().getBytes()));
-} else if
(PulsarInternalColumn.SEQUENCE_ID.getName().equals(columnHandle.getName())) {
+break;
+case "__sequence_id__":
currentRowValuesMap.put(columnHandle,
longValueProvider(this.currentMessage.getSequenceId()));
-} else if
(PulsarInternalColumn.PRODUCER_NAME.getName().equals(columnHandle.getName())) {
+break;
+case "__producer_name__":
currentRowValuesMap.put(columnHandle,
bytesValueProvider(this.currentMessage.getProducerName().getBytes()));
-} else if
(PulsarInternalColumn.KEY.getName().equals(columnHandle.getName())) {
+break;
+case "__key__":
String key = this.currentMessage.getKey().orElse(null);
currentRowValuesMap.put(columnHandle,
bytesValueProvider(key == null ? null : key.getBytes()));
-} else if
(PulsarInternalColumn.PROPERTIES.getName().equals(columnHandle.getName())) {
+break;
+case "__properties__":
try {
currentRowValuesMap.put(columnHandle,
bytesValueProvider(
new
ObjectMapper().writeValueAsBytes(this.currentMessage.getProperties(;
} catch (JsonProcessingException e) {
throw new RuntimeException(e);
}
-} else {
-throw new IllegalArgumentException("unknown internal field
" + columnHandle.getName());
-}
+break;
+default:
+try {
+throw new IllegalArgumentException("unknown internal
field " + columnHandle.getName());
+} finally {
+break;
+}
Review Comment:
```suggestion
throw new IllegalArgumentException("unknown internal
field " + columnHandle.getName());
```
Also, I don't think the refactor from if-else to switch is necessary. Please
revert or explain why you do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7346: Unable to include *.tar.gz python dependencies in the Pulsar Function package
tisonkun commented on issue #7346: URL: https://github.com/apache/pulsar/issues/7346#issuecomment-1399153774 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7354: Support basic-authentication in function jar urls when registering/updating functions via REST API
tisonkun commented on issue #7354: URL: https://github.com/apache/pulsar/issues/7354#issuecomment-1399153529 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7391: When creating function application, set parallelism greater than 1, and multiple jars will be copied under the same node.
tisonkun commented on issue #7391: URL: https://github.com/apache/pulsar/issues/7391#issuecomment-1399153353 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7346: Unable to include *.tar.gz python dependencies in the Pulsar Function package
tisonkun closed issue #7346: Unable to include *.tar.gz python dependencies in the Pulsar Function package URL: https://github.com/apache/pulsar/issues/7346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7354: Support basic-authentication in function jar urls when registering/updating functions via REST API
tisonkun closed issue #7354: Support basic-authentication in function jar urls when registering/updating functions via REST API URL: https://github.com/apache/pulsar/issues/7354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7391: When creating function application, set parallelism greater than 1, and multiple jars will be copied under the same node.
tisonkun closed issue #7391: When creating function application, set parallelism greater than 1, and multiple jars will be copied under the same node. URL: https://github.com/apache/pulsar/issues/7391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7441: Perf client should produce and consume AVRO objects
tisonkun commented on issue #7441: URL: https://github.com/apache/pulsar/issues/7441#issuecomment-1399153305 IIRC it's implemented now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] sijie opened a new issue, #7441: Perf client should produce and consume AVRO objects
sijie opened a new issue, #7441: URL: https://github.com/apache/pulsar/issues/7441 *Motivation* We should use perf tool to benchmark producing and consuming messages using Schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7441: Perf client should produce and consume AVRO objects
tisonkun closed issue #7441: Perf client should produce and consume AVRO objects URL: https://github.com/apache/pulsar/issues/7441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7441: Perf client should produce and consume AVRO objects
tisonkun commented on issue #7441: URL: https://github.com/apache/pulsar/issues/7441#issuecomment-1399153272 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7505: start/stop function fail
tisonkun commented on issue #7505: URL: https://github.com/apache/pulsar/issues/7505#issuecomment-1399153214 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7505: start/stop function fail
tisonkun closed issue #7505: start/stop function fail URL: https://github.com/apache/pulsar/issues/7505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7530: In some cases, the workerport does not listening after the functions worker process is started.
tisonkun closed issue #7530: In some cases, the workerport does not listening after the functions worker process is started. URL: https://github.com/apache/pulsar/issues/7530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7530: In some cases, the workerport does not listening after the functions worker process is started.
tisonkun commented on issue #7530: URL: https://github.com/apache/pulsar/issues/7530#issuecomment-1399153195 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7531: prebuild protoc incompatible for build project
tisonkun closed issue #7531: prebuild protoc incompatible for build project URL: https://github.com/apache/pulsar/issues/7531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7531: prebuild protoc incompatible for build project
tisonkun commented on issue #7531: URL: https://github.com/apache/pulsar/issues/7531#issuecomment-1399153152 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7535: Modify the create/update function mode
tisonkun closed issue #7535: Modify the create/update function mode URL: https://github.com/apache/pulsar/issues/7535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7535: Modify the create/update function mode
tisonkun commented on issue #7535: URL: https://github.com/apache/pulsar/issues/7535#issuecomment-1399153112 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7538: [Question] How to generate sequenceId for commit marker in partition topic
tisonkun closed issue #7538: [Question] How to generate sequenceId for commit marker in partition topic URL: https://github.com/apache/pulsar/issues/7538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7538: [Question] How to generate sequenceId for commit marker in partition topic
tisonkun commented on issue #7538: URL: https://github.com/apache/pulsar/issues/7538#issuecomment-1399153060 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7547: Queue declaration parameters for rabbitMQ source connector configurable
tisonkun commented on issue #7547: URL: https://github.com/apache/pulsar/issues/7547#issuecomment-1399152962 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7547: Queue declaration parameters for rabbitMQ source connector configurable
tisonkun closed issue #7547: Queue declaration parameters for rabbitMQ source connector configurable URL: https://github.com/apache/pulsar/issues/7547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7551: Function instance/deps class loading mechanism is confused
tisonkun commented on issue #7551: URL: https://github.com/apache/pulsar/issues/7551#issuecomment-1399152889 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7551: Function instance/deps class loading mechanism is confused
tisonkun closed issue #7551: Function instance/deps class loading mechanism is confused URL: https://github.com/apache/pulsar/issues/7551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6833: deploy pulsar dev,test,pro cluster at the same time , i hope the pulsar-Operator just like tidb-Operator
tisonkun commented on issue #6833: URL: https://github.com/apache/pulsar/issues/6833#issuecomment-1399152833 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6833: deploy pulsar dev,test,pro cluster at the same time , i hope the pulsar-Operator just like tidb-Operator
tisonkun closed issue #6833: deploy pulsar dev,test,pro cluster at the same time , i hope the pulsar-Operator just like tidb-Operator URL: https://github.com/apache/pulsar/issues/6833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6883: Java Pulsar function can't find SerDe class on schema init
tisonkun closed issue #6883: Java Pulsar function can't find SerDe class on schema init URL: https://github.com/apache/pulsar/issues/6883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6883: Java Pulsar function can't find SerDe class on schema init
tisonkun commented on issue #6883: URL: https://github.com/apache/pulsar/issues/6883#issuecomment-1399152732 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6902: Jackson shading issues
tisonkun commented on issue #6902: URL: https://github.com/apache/pulsar/issues/6902#issuecomment-1399152701 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6902: Jackson shading issues
tisonkun closed issue #6902: Jackson shading issues URL: https://github.com/apache/pulsar/issues/6902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6906: Add access to user-config when initializing a function
tisonkun commented on issue #6906: URL: https://github.com/apache/pulsar/issues/6906#issuecomment-1399152638 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6906: Add access to user-config when initializing a function
tisonkun closed issue #6906: Add access to user-config when initializing a function URL: https://github.com/apache/pulsar/issues/6906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6912: Autocreate tenant/namespace
tisonkun commented on issue #6912: URL: https://github.com/apache/pulsar/issues/6912#issuecomment-1399152586 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6912: Autocreate tenant/namespace
tisonkun closed issue #6912: Autocreate tenant/namespace URL: https://github.com/apache/pulsar/issues/6912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6979: More visibility for delayed message
tisonkun commented on issue #6979: URL: https://github.com/apache/pulsar/issues/6979#issuecomment-1399152501 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. For open-ended discussion, you can start a thread on https://github.com/apache/pulsar/discussions/categories/general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6979: More visibility for delayed message
tisonkun closed issue #6979: More visibility for delayed message URL: https://github.com/apache/pulsar/issues/6979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #7025: Deduplication for partitioned topics
tisonkun closed issue #7025: Deduplication for partitioned topics URL: https://github.com/apache/pulsar/issues/7025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7025: Deduplication for partitioned topics
tisonkun commented on issue #7025: URL: https://github.com/apache/pulsar/issues/7025#issuecomment-1399152392 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #7138: PIP 37-Follow up: Chunk message with batching enabled
tisonkun commented on issue #7138: URL: https://github.com/apache/pulsar/issues/7138#issuecomment-1399152357 @rdhabalia is this issue still relevant? It seems stale and no one works on it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #5583: Rate limiting or priority control to restrict the resource consumption while restart the whole pulsar cluster
tisonkun commented on issue #5583: URL: https://github.com/apache/pulsar/issues/5583#issuecomment-1399152248 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #5583: Rate limiting or priority control to restrict the resource consumption while restart the whole pulsar cluster
tisonkun closed issue #5583: Rate limiting or priority control to restrict the resource consumption while restart the whole pulsar cluster URL: https://github.com/apache/pulsar/issues/5583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6269: Segmentation fault when using python client in pyenv environment on OSX Catalina
tisonkun closed issue #6269: Segmentation fault when using python client in pyenv environment on OSX Catalina URL: https://github.com/apache/pulsar/issues/6269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6269: Segmentation fault when using python client in pyenv environment on OSX Catalina
tisonkun commented on issue #6269: URL: https://github.com/apache/pulsar/issues/6269#issuecomment-1399152200 Closed as stale. The development of the Python client has been permanently moved to http://github.com/apache/pulsar-client-python. Please open an issue there if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6320: Support consume a topic in reverse order
tisonkun commented on issue #6320: URL: https://github.com/apache/pulsar/issues/6320#issuecomment-1399152153 Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6320: Support consume a topic in reverse order
tisonkun closed issue #6320: Support consume a topic in reverse order URL: https://github.com/apache/pulsar/issues/6320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #6353: Clients support acknowledgment at batch index level.
tisonkun closed issue #6353: Clients support acknowledgment at batch index level. URL: https://github.com/apache/pulsar/issues/6353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #6353: Clients support acknowledgment at batch index level.
tisonkun commented on issue #6353: URL: https://github.com/apache/pulsar/issues/6353#issuecomment-1399152080 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18162: [Bug] Caused by: org.apache.pulsar.common.util.FutureUtil$LowOverheadTimeoutException: Failed to load topic within timeout
github-actions[bot] commented on issue #18162: URL: https://github.com/apache/pulsar/issues/18162#issuecomment-1399147575 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18682: [Doc] inaccurate docs on Reference Page
github-actions[bot] commented on issue #18682: URL: https://github.com/apache/pulsar/issues/18682#issuecomment-1399147290 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18683: Flaky-test: ProxyAuthenticationTest.authenticatedSocketTest
github-actions[bot] commented on issue #18683: URL: https://github.com/apache/pulsar/issues/18683#issuecomment-1399147280 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18894: [Bug] msgInCounter and msgOutCounter don't match
github-actions[bot] commented on issue #18894: URL: https://github.com/apache/pulsar/issues/18894#issuecomment-1399147193 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18973: [Bug] pulsar-admin functions update does not update the function binary from a local file
github-actions[bot] commented on issue #18973: URL: https://github.com/apache/pulsar/issues/18973#issuecomment-1399147105 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18972: [Bug] pulsar-admin functions upload does not appear to work at all.
github-actions[bot] commented on issue #18972: URL: https://github.com/apache/pulsar/issues/18972#issuecomment-1399147122 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19018: [Doc] [Admin REST API] Missing examples for registering sinks, sources, functions
github-actions[bot] commented on issue #19018: URL: https://github.com/apache/pulsar/issues/19018#issuecomment-1399147082 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#457a0d5)
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 0a6f7571ca6 Docs sync done from apache/pulsar (#457a0d5) 0a6f7571ca6 is described below commit 0a6f7571ca68da59c19248a08b00123db81c86d2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Sat Jan 21 01:43:04 2023 + Docs sync done from apache/pulsar (#457a0d5) --- .../reference/next/config/reference-configuration-broker.md | 11 +++ .../next/config/reference-configuration-pulsar-proxy.md | 11 +++ .../next/config/reference-configuration-standalone.md | 11 +++ 3 files changed, 33 insertions(+) diff --git a/static/reference/next/config/reference-configuration-broker.md b/static/reference/next/config/reference-configuration-broker.md index 2ca37163a64..5ad60cd72e5 100644 --- a/static/reference/next/config/reference-configuration-broker.md +++ b/static/reference/next/config/reference-configuration-broker.md @@ -5058,6 +5058,17 @@ Number of threads used by Websocket service **Category**: WebSocket +### webSocketPingDurationSeconds +Interval of time to sending the ping to keep alive in WebSocket proxy. This value greater than 0 means enabled + +**Type**: `int` + +**Default**: `-1` + +**Dynamic**: `false` + +**Category**: WebSocket + ### webSocketServiceEnabled Enable the WebSocket API service in broker diff --git a/static/reference/next/config/reference-configuration-pulsar-proxy.md b/static/reference/next/config/reference-configuration-pulsar-proxy.md index 567909312ef..21f9e2b65da 100644 --- a/static/reference/next/config/reference-configuration-pulsar-proxy.md +++ b/static/reference/next/config/reference-configuration-pulsar-proxy.md @@ -1074,6 +1074,17 @@ Name of the cluster to which this broker belongs to **Category**: WebSocket +### webSocketPingDurationSeconds +Interval of time to sending the ping to keep alive in WebSocket proxy. This value greater than 0 means enabled + +**Type**: `int` + +**Default**: `-1` + +**Dynamic**: `false` + +**Category**: WebSocket + ### webSocketServiceEnabled Enable or disable the WebSocket servlet diff --git a/static/reference/next/config/reference-configuration-standalone.md b/static/reference/next/config/reference-configuration-standalone.md index 2ca37163a64..5ad60cd72e5 100644 --- a/static/reference/next/config/reference-configuration-standalone.md +++ b/static/reference/next/config/reference-configuration-standalone.md @@ -5058,6 +5058,17 @@ Number of threads used by Websocket service **Category**: WebSocket +### webSocketPingDurationSeconds +Interval of time to sending the ping to keep alive in WebSocket proxy. This value greater than 0 means enabled + +**Type**: `int` + +**Default**: `-1` + +**Dynamic**: `false` + +**Category**: WebSocket + ### webSocketServiceEnabled Enable the WebSocket API service in broker
[GitHub] [pulsar] michaeljmarshall commented on pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor
michaeljmarshall commented on PR #19295: URL: https://github.com/apache/pulsar/pull/19295#issuecomment-1398849932 @lhotari - yes, that proxy test is failing because of my changes. Pushing up a fix now. Note that the fix includes a new call to `authenticate` in the `ServerCnx`. I think this is reasonable, but it does slightly change the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor
michaeljmarshall commented on code in PR #19295:
URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082976985
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java:
##
@@ -61,13 +80,47 @@ public AuthenticationDataSource getAuthDataSource() {
return authenticationDataSource;
}
+/**
+ * Warning: this method is not intended to be called concurrently.
+ */
+@Override
+public CompletableFuture authenticateAsync(AuthData authData) {
+if (authRole != null) {
+// Authentication is already completed
+return CompletableFuture.completedFuture(null);
+}
+this.authenticationDataSource = new AuthenticationDataCommand(
Review Comment:
Since this is a class for single stage authentication, there are no
`AuthChallenges`. The primary reason to set this here instead of the
constructor is that we set it with the `authData` that we authenticate. Note
that this class always has `isExpired` return `false`, which means there are
never any `AuthChallenges` generated.
If this were a multi-stage auth, this solution would not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] michaeljmarshall commented on a diff in pull request #349: [doc][improve] Improve landing page 3 first sections
michaeljmarshall commented on code in PR #349:
URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1082919747
##
src/pages/index.js:
##
@@ -191,7 +190,9 @@ export default function Home() {
/>
[
{
-title: "Cloud-native",
-Svg: require("../../static/img/Technology-Solution.svg").default,
-content: "A multiple layer approach separating compute from storage to
work with cloud infrastructures and Kubernetes.",
+title: "Automatic Load Balancing",
+Svg: require("../../static/img/automatic-load-balancing.svg").default,
+content: "Add or remove nodes and let Pulsar load balance topic bundles
automatically. Hot spotted topic bundles are automatically split and evenly
distributed across the brokers.",
},
{
title: "Serverless functions",
Svg: require("../../static/img/proven-in-production.svg").default,
-content:"Write serverless functions with developer-friendly APIs to
natively process data immediately upon arrival. No need to run your own stream
processing engine.",
+content:"Write and deploy functions natively using Pulsar Functions.
Process messages using Java, Go, or Python without deploying fully-fledged
applications. Kubernetes runtime is bundled.",
},
{
-title: "Horizontally scalable",
+title: "Rapid Horizontal Scalability",
Svg: require("../../static/img/horizontally-scalable.svg").default,
-content: "Expand capacity seamlessly to hundreds of nodes.",
+content: "Scales horizontally to handle the increased load. Its unique
design and separate storage layer enable handling the sudden surge in traffic
by scaling out in seconds.",
},
{
-title: "Low latency with durability",
+title: "Low-latency messaging and streaming",
Svg: require("../../static/img/low-latency.svg").default,
-content:"Low publish latency (< 5ms) at scale with strong durability
guarantees.",
+content:"Acknowledge messages individually (RabbitMQ style) or cumulative
per partition (i.e., offset-like). Enables use cases such as distributed work
queues or order-preserving data streams at very large scales (hundreds of
nodes) and low latency (<5ms).",
},
{
-title: "Geo-replication",
+title: "Seamless Geo-Replication",
Svg: require("../../static/img/geo-replication.svg").default,
-content: "Configurable replication between data centers across multiple
geographic regions.",
+content: "Protect against complete zone outages using replication across
different geographic regions. Flexible and configurable replication strategies
across distant Pulsar Clusters. Uniquely supports automatic client failover to
healthy clusters.",
},
{
title: "Multi-tenancy",
Svg: require("../../static/img/multi-tenancy.svg").default,
-content:"Built from the ground up as a multi-tenant system. Supports
isolation, authentication, authorization, and quotas.",
+content:"Maintain one cluster for your entire organization using tenants.
Access control across data and actions using tenant policies. Isolate specific
brokers to a tenant when maximum noisy neighbor protection is needed.",
},
{
-title: "Persistent storage",
+title: "Official multi-language support",
Svg: require("../../static/img/persistent-storage.svg").default,
-content:"Persistent message storage based on Apache BookKeeper. IO-level
isolation between write, and read operations.",
+content:"Officially maintained Pulsar Clients for Java, Go, Python, C++,
Node.js, and C#.",
},
{
-title: "Client libraries",
-Svg: require("../../static/img/client-libraries.svg").default,
-content: "Flexible messaging models with high-level APIs for Java, Go,
Python, C++, Node.js, WebSocket and C#.",
+title: "Official 3rd party integrations",
+Svg:
require("../../static/img/official-3rd-party-integrations.svg").default,
+content: "Pulsar has officially maintained connectors with popular 3rd
parties: MySQL, Elasticsearch, Cassandra, and more. Allows streaming data in
(source) or out (sink).",
},
{
-title: "Operability",
-Svg: require("../../static/img/operability.svg").default,
+title: "Supports up to 1M topics",
Review Comment:
It's out of the scope of this PR, but I wonder if we should provide users
with a reference architecture to better understand how they can achieve the 1M
topics. Maybe it could be a "cookbook". One reason I mention this is because a
user might be interested to know how many nodes are required to achieve this
high number of topics.
##
src/components/HomepageFeatures.js:
##
@@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown";
const FeatureList = (language) => [
{
-title: "Cloud-native",
-Svg: require("../../static/img/Technology-Solution.svg").default,
-content: "A multiple layer approach separating compute from storage to
work with cloud infrastructures and
[GitHub] [pulsar] poorbarcode opened a new pull request, #19302: [improve] [admin] Make the default value of param --get-subscription-backlog-size of admin API topics stats true
poorbarcode opened a new pull request, #19302:
URL: https://github.com/apache/pulsar/pull/19302
### Motivation
In the PR https://github.com/apache/pulsar/pull/9302, the property backlog
size of each subscription returned in the response of the API topics stats, by
default this property is always equal to 0 in response, and this will confuse
users. Since the calculation of backlog size is done in broker memory, there is
no significant overhead(the process is described in the following section), so
I think the correct values should be displayed by default.
Discuss in mail list
- https://lists.apache.org/thread/wvjrp3co9fyl596onwv037944kdz000d
The following two APIs should be affected:
In Pulsar admin API
```
pulsar-admin topics stats persistent://test-tenant/ns1/tp1
--get-subscription-backlog-size
pulsar-admin topics stats persistent://test-tenant/ns1/tp1 -sbs
```
the default value of parameter `--get-subscription-backlog-size` will be
`true`
In Pulsar Rest API
```
curl GET
"http://127.0.0.1:8080/test-tenant/ns1/tp1/stats?subscriptionBacklogSize=true;
```
the default value of the parameter `subscriptionBacklogSize` will be `true`
The following is the process of calculating backlog size:
- Divide `PersistentTopc.ledgers` into two parts according to the ledgerId
of the mark delete position of the cursor. The second part is ledgers
indicating the messages still need to be consumed, aka backlogSizeInLedgers.
- Find the LedgerInfo whose ledgerId is the same as the ledgerId of the mark
delete position of the cursor, and we can also divide the ledger into two
parts, the second part is entries indicating the messages still need to be
consumed, multiply the average size of each entry in metrics by the number of
still need to be consumed entries we can get the backlog size in this ledger.
aka backlogSizeInEntries.
- `backlogSizeInLedgers` + `backlogSizeInEntries`
### Modifications
Make the default value of param "--get-subscription-backlog-size" of admin
API "topics stats" `true`
### Documentation
- [ ] `doc`
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc-complete`
### Matching PR in forked repository
PR in forked repository:
- https://github.com/poorbarcode/pulsar/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19301: [fix][client]The format of the example in the auth-params description is incorrect
github-actions[bot] commented on PR #19301: URL: https://github.com/apache/pulsar/pull/19301#issuecomment-1398618213 @zzccctv Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] zzccctv opened a new pull request, #19301: [fix][client]The format of the example in the auth-params description is incorrect
zzccctv opened a new pull request, #19301: URL: https://github.com/apache/pulsar/pull/19301 Motivation The format of the example in the auth-params description is incorrect Modifications Add quotation marks Documentation - [ ] doc - [ ] doc-required - [ ] doc-not-needed - [ ] doc-complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] massakam commented on pull request #19298: [feat][cli] Add read command to pulsar-client-tools
massakam commented on PR #19298:
URL: https://github.com/apache/pulsar/pull/19298#issuecomment-1398471160
> Have you tested it with pulsar-shell?
It seems to work fine on pulsar-shell as well.
```sh
$ ./bin/pulsar-shell
Using directory: /home/massakam/.pulsar-shell
Welcome to Pulsar shell!
Service URL: pulsar://localhost:6650/
Admin URL: http://localhost:8080/
Type help to get started or try the autocompletion (TAB button).
Type exit or quit to end the shell session.
default(localhost)> client read -m Earliest -n 5
persistent://public/default/t1
2023-01-20T23:25:24,112+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x05f137b5,
L:/127.0.0.1:43390 - R:localhost/127.0.0.1:6650]] Connected to server
2023-01-20T23:25:24,118+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConsumerStatsRecorderImpl - Starting Pulsar
consumer status recorder with config:
{"topicNames":["persistent://public/default/t1"],"topicsPattern":null,"subscriptionName":"reader-749d586940","subscriptionType":"Exclusive","subscriptionProperties":null,"subscriptionMode":"NonDurable","receiverQueueSize":1000,"acknowledgementsGroupTimeMicros":10,"maxAcknowledgmentGroupSize":1000,"negativeAckRedeliveryDelayMicros":6000,"maxTotalReceiverQueueSizeAcrossPartitions":5,"consumerName":null,"ackTimeoutMillis":0,"tickDurationMillis":1000,"priorityLevel":0,"maxPendingChunkedMessage":10,"autoAckOldestChunkedMessageOnQueueFull":false,"expireTimeOfIncompleteChunkedMessageMillis":6,"cryptoFailureAction":"FAIL","properties":{},"readCompacted":false,"subscriptionInitialPosition":"Latest","patternAutoDiscoveryPeriod":60,"regexSubscriptionMode":"PersistentOnly","deadLetterPolicy":null,"retryEnable
":false,"autoUpdatePartitions":true,"autoUpdatePartitionsIntervalSeconds":60,"replicateSubscriptionState":false,"resetIncludeHead":false,"batchIndexAckEnabled":false,"ackReceiptEnabled":false,"poolMessages":true,"startPaused":false,"autoScaledReceiverQueueSizeEnabled":false,"topicConfigurations":[],"maxPendingChuckedMessage":10}
2023-01-20T23:25:24,119+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConsumerStatsRecorderImpl - Pulsar client config:
{"serviceUrl":"pulsar://localhost:6650/","authPluginClassName":null,"authParams":null,"authParamMap":null,"operationTimeoutMs":3,"lookupTimeoutMs":3,"statsIntervalSeconds":60,"numIoThreads":6,"numListenerThreads":6,"connectionsPerBroker":1,"connectionMaxIdleSeconds":180,"useTcpNoDelay":true,"useTls":false,"tlsKeyFilePath":"","tlsCertificateFilePath":"","tlsTrustCertsFilePath":"","tlsAllowInsecureConnection":false,"tlsHostnameVerificationEnable":false,"concurrentLookupRequest":5000,"maxLookupRequest":5,"maxLookupRedirects":20,"maxNumberOfRejectedRequestPerConnection":50,"keepAliveIntervalSeconds":30,"connectionTimeoutMs":1,"requestTimeoutMs":6,"readTimeoutMs":6,"autoCertRefreshSeconds":300,"initialBackoffIntervalNanos":1,"maxBackoffIntervalNanos":600,"enableBusyWait":false,"listenerName":null,"useKeyStoreT
ls":false,"sslProvider":null,"tlsKeyStoreType":"JKS","tlsKeyStorePath":"","tlsKeyStorePassword":"*","tlsTrustStoreType":"JKS","tlsTrustStorePath":"","tlsTrustStorePassword":"*","tlsCiphers":[],"tlsProtocols":[],"memoryLimitBytes":0,"proxyServiceUrl":null,"proxyProtocol":null,"enableTransaction":false,"dnsLookupBindAddress":null,"dnsLookupBindPort":0,"socks5ProxyAddress":null,"socks5ProxyUsername":null,"socks5ProxyPassword":null}
2023-01-20T23:25:24,121+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConsumerImpl -
[persistent://public/default/t1][reader-749d586940] Subscribing to topic on cnx
[id: 0x05f137b5, L:/127.0.0.1:43390 - R:localhost/127.0.0.1:6650], consumerId 0
2023-01-20T23:25:24,124+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConsumerImpl -
[persistent://public/default/t1][reader-749d586940] Subscribed to topic on
localhost/127.0.0.1:6650 -- consumer: 0
- got message -
key:[null], properties:[], content:test
- got message -
key:[null], properties:[], content:test
- got message -
key:[null], properties:[], content:test
- got message -
key:[null], properties:[], content:test
- got message -
key:[null], properties:[], content:test
2023-01-20T23:25:24,135+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ConsumerImpl - [persistent://public/default/t1]
[reader-749d586940] Closed consumer
2023-01-20T23:25:24,137+0900 [main] INFO
org.apache.pulsar.client.impl.PulsarClientImpl - Client closing. URL:
pulsar://localhost:6650/
2023-01-20T23:25:24,137+0900 [pulsar-client-io-71-3] INFO
org.apache.pulsar.client.impl.ClientCnx - [id: 0x05f137b5, L:/127.0.0.1:43390 !
R:localhost/127.0.0.1:6650] Disconnected
2023-01-20T23:25:26,141+0900 [main] INFO
[GitHub] [pulsar] lhotari commented on a diff in pull request #19270: [cleanup][broker] Validate originalPrincipal earlier in ServerCnx
lhotari commented on code in PR #19270:
URL: https://github.com/apache/pulsar/pull/19270#discussion_r1082536276
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -965,15 +961,23 @@ protected void handleConnect(CommandConnect connect) {
remoteAddress, originalPrincipal);
}
}
+if (service.isAuthorizationEnabled()) {
+validateRoleAndOriginalPrincipal();
+}
} catch (Exception e) {
-service.getPulsarStats().recordConnectionCreateFail();
logAuthException(remoteAddress, "connect", getPrincipal(),
Optional.empty(), e);
-String msg = "Unable to authenticate";
-writeAndFlush(Commands.newError(-1,
ServerError.AuthenticationError, msg));
-close();
+closeForAuthenticationError();
}
}
+private void closeForAuthenticationError() {
+state = State.Failed;
+service.getPulsarStats().recordConnectionCreateFail();
+String msg = "Unable to authenticate";
+writeAndFlush(Commands.newError(-1, ServerError.AuthenticationError,
msg));
+close();
Review Comment:
It's already like this in the original code, but I'd assume that
`ctx.writeAndFlush(...).addListener(ChannelFutureListener.CLOSE);` (or
`org.apache.pulsar.common.util.netty.NettyChannelUtil.writeAndFlushWithClosePromise`)
should be used so that the channel doesn't get closed before the error has
been written to the channel.
https://github.com/apache/pulsar/blob/d6fcdb8e1e192e0d9e2fbe6307d273b27ed2930f/pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/NettyChannelUtil.java#L59-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] labuladong commented on pull request #19253: [fix][test] testSingleTopicConsumerBatchShortName
labuladong commented on PR #19253: URL: https://github.com/apache/pulsar/pull/19253#issuecomment-1398372158 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [improve][ci] Improve code coverage reporting (#19296)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 457a0d5ec6a [improve][ci] Improve code coverage reporting (#19296)
457a0d5ec6a is described below
commit 457a0d5ec6a79ce957ea2fa30c4859eb9a87222e
Author: Lari Hotari
AuthorDate: Fri Jan 20 14:52:19 2023 +0200
[improve][ci] Improve code coverage reporting (#19296)
---
.github/actions/upload-coverage/action.yml | 16 ++-
build/pulsar_ci_tool.sh| 56 +++---
codecov.yml| 14 +-
pom.xml| 5 ++
.../integration/containers/PulsarContainer.java| 3 +-
5 files changed, 62 insertions(+), 32 deletions(-)
diff --git a/.github/actions/upload-coverage/action.yml
b/.github/actions/upload-coverage/action.yml
index 97d311caf50..a9706e77333 100644
--- a/.github/actions/upload-coverage/action.yml
+++ b/.github/actions/upload-coverage/action.yml
@@ -83,4 +83,18 @@ runs:
with:
flags: ${{ inputs.flags }}
fail_ci_if_error: true
-verbose: true
\ No newline at end of file
+verbose: true
+- name: "Show link to Codecov report"
+ shell: bash
+ run: |
+if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
+ head_sha=$(jq -r '.pull_request.head.sha' "${GITHUB_EVENT_PATH}")
+else
+ head_sha=$(git rev-parse HEAD)
+fi
+tee -a "$GITHUB_STEP_SUMMARY" target/classpath_$artifactId || true
done
@@ -468,7 +462,8 @@ ci_create_test_coverage_report() {
else
cd "$SCRIPT_DIR/.."
fi
- local execFiles=$(find . '(' -path "*/target/jacoco.exec" -or -path
"*/target/jacoco_*.exec" ')' -printf "%P\n")
+
+ local execFiles=$(find . '(' -path "*/target/jacoco.exec" -or -path
"*/target/jacoco_*.exec" ')' -printf "%P\n" )
if [[ -n "$execFiles" ]]; then
mkdir -p /tmp/jacocoDir
if [ ! -f /tmp/jacocoDir/jacococli.jar ]; then
@@ -492,41 +487,42 @@ ci_create_test_coverage_report() {
done
} | sort | uniq)
+# projects that aren't considered as production code and their own
src/main/java source code shouldn't be analysed
+local excludeProjectsPattern="testmocks|testclient|buildtools"
+
# iterate projects
for project in $projects; do
local artifactId="$(printf "%s" "$projectToArtifactIdMapping" | grep -F
"$project " | cut -d' ' -f2)"
- if [ -d "$project/target/classes" ]; then
+ if [[ -d "$project/target/classes" && -d "$project/src/main/java" ]];
then
mkdir -p "$classesDir/$project"
cp -Rl "$project/target/classes" "$classesDir/$project"
-echo "/$artifactId/" >> $filterArtifactsFile
- fi
- local scope=runtime
- if [ -d $project/src/main/java ]; then
echo "$project/src/main/java" >> $sourcefilesFile
- else
-# for integration tests, there's no dependencies in the runtime scope
-scope=test
fi
- if [ -f "target/classpath_$artifactId" ]; then
-echo "Found cached classpath for $artifactId."
-cat "target/classpath_$artifactId" >> $completeClasspathFile
+ echo "/$artifactId/" >> $filterArtifactsFile
+ if [[ -n "$(echo "$project" | grep -v -E "$excludeProjectsPattern")" ]];
then
+if [ -f "target/classpath_$artifactId" ]; then
+ echo "Found cached
[GitHub] [pulsar] lhotari merged pull request #19296: [improve][ci] Improve code coverage reporting
lhotari merged PR #19296: URL: https://github.com/apache/pulsar/pull/19296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics
labuladong commented on issue #19216: URL: https://github.com/apache/pulsar/issues/19216#issuecomment-1398336034 Seems it's still flaky: https://github.com/apache/pulsar/actions/runs/3937453167/jobs/6795361656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: Update Pulsar PMC members and committers (#387)
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new c3c261b6222 Update Pulsar PMC members and committers (#387)
c3c261b6222 is described below
commit c3c261b6222c1e27ac6598f831703a12c186f164
Author: Lari Hotari
AuthorDate: Fri Jan 20 14:51:19 2023 +0200
Update Pulsar PMC members and committers (#387)
Process to update data/team.js file:
1. Logged in to https://whimsy.apache.org/roster/committee/pulsar with
browser
2. Appended ".json" to URL so that browser goes to
https://whimsy.apache.org/roster/committee/pulsar.json
3. Clicked "Save as..." and stored the JSON as ~/Downloads/pulsar.json
4. Ran this command in a bash shell:
{ echo -n "module.exports = " && cat ~/Downloads/pulsar.json | jq '{"pmc":
[.roster| to_entries | sort_by(.key) | .[] |
select(.value.role|startswith("PMC")) | {"name":.value.name, "apacheId":
.key}], "committers": [.roster| to_entries | sort_by(.key) | .[] |
select(.value.role=="Committer") | {"name":.value.name, "apacheId": .key}]}' }
| perl -pe 's/$/;\n/ if eof' > data/team.js
---
data/team.js | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/data/team.js b/data/team.js
index 0eaccb3c00d..2bb44da80c8 100644
--- a/data/team.js
+++ b/data/team.js
@@ -4,6 +4,10 @@ module.exports = {
"name": "Sahaya Andrews",
"apacheId": "andrews"
},
+{
+ "name": "Bo Cong",
+ "apacheId": "bogong"
+},
{
"name": "Brad McMillen",
"apacheId": "bradtm"
@@ -80,6 +84,10 @@ module.exports = {
"name": "Matteo Merli",
"apacheId": "mmerli"
},
+{
+ "name": "Nicolò Boschi",
+ "apacheId": "nicoloboschi"
+},
{
"name": "Nozomi Kurihara",
"apacheId": "nkurihar"
@@ -124,6 +132,10 @@ module.exports = {
"name": "David Fisher",
"apacheId": "wave"
},
+{
+ "name": "Yunze Xu",
+ "apacheId": "xyz"
+},
{
"name": "Yuki Shiga",
"apacheId": "yushiga"
@@ -151,12 +163,12 @@ module.exports = {
"apacheId": "ayegorov"
},
{
- "name": "Daniel Blankensteiner",
- "apacheId": "blankensteiner"
+ "name": "Baodi Shi",
+ "apacheId": "baodi"
},
{
- "name": "Bo Cong",
- "apacheId": "bogong"
+ "name": "Daniel Blankensteiner",
+ "apacheId": "blankensteiner"
},
{
"name": "Christophe Bornet",
@@ -210,10 +222,6 @@ module.exports = {
"name": "Qiang Zhao",
"apacheId": "mattisonchao"
},
-{
- "name": "Nicolò Boschi",
- "apacheId": "nicoloboschi"
-},
{
"name": "Neng Lu",
"apacheId": "nlu90"
@@ -254,10 +262,6 @@ module.exports = {
"name": "Marvin Cai",
"apacheId": "xxc"
},
-{
- "name": "Yunze Xu",
- "apacheId": "xyz"
-},
{
"name": "Yijie Shen",
"apacheId": "yjshen"
[GitHub] [pulsar-site] eolivelli merged pull request #387: Update Pulsar PMC members and committers
eolivelli merged PR #387: URL: https://github.com/apache/pulsar-site/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong opened a new pull request, #19300: [improve][cli] improve admin `set-backlog-quota` more clear
labuladong opened a new pull request, #19300: URL: https://github.com/apache/pulsar/pull/19300 Fixes #19196 ### Motivation The parameters of backlog retention policies need to be clarified. Size limit is only useful in `destination_storage` and time limit is only useful in `message_age`. ### Modifications 1. Make `--limit` optional, because `message_age` doesn't need this parameter. 2. When the quota type is `message_age`, use the time limit. When the quota type is `destination_storage`, use the size limit. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [x] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [x] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] yonigibbs commented on issue #19299: [Doc] Example Window Function has different names in docs and in the examples folder
yonigibbs commented on issue #19299: URL: https://github.com/apache/pulsar/issues/19299#issuecomment-1398326044 Found one more thing: the docs around starting window functions (https://pulsar.apache.org/docs/2.11.x/functions-quickstart/#start-window-functions) give these two commands: ``` bin/pulsar-client consume -s test-sub -n 0 test_window_result ``` and ``` bin/pulsar-client produce -m "3" -n 10 test_window_src ``` However in the actual supplied example (see https://github.com/apache/pulsar/blob/master/pulsar-functions/java-examples/src/main/resources/example-window-function-config.yaml#L24-L25) we see this: ``` inputs: ["test_src"] output: "test_result" ``` Notice the the topic names are different: they're missing the word `window` in their names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] yonigibbs opened a new issue, #19299: [Doc] Example Window Function has different names in docs and in the examples folder
yonigibbs opened a new issue, #19299: URL: https://github.com/apache/pulsar/issues/19299 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? The example window function supplied with 2.11 is called `example` (see https://github.com/apache/pulsar/blob/master/pulsar-functions/java-examples/src/main/resources/example-window-function-config.yaml#L22). However in the documentation it expects it to be called `window-example`. See step 3 at https://pulsar.apache.org/docs/2.11.x/functions-quickstart/#start-window-functions, where it asks you to type in this command: ``` bin/pulsar-admin functions get \ --tenant test \ --namespace test-namespace \ --name window-example ``` ### What is your suggestion? Either fix the documentation or the example file supplied with the build. Suggest the latter, as otherwise the other issue is that there's another example called `example`, and if you follow the docs, as I did, and try to install one example function followed by another it fails (the second attempt to create a function fails, as the function already exists from the previous step). ### Any reference? _No response_ ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19296: [improve][ci] Improve code coverage reporting
codecov-commenter commented on PR #19296: URL: https://github.com/apache/pulsar/pull/19296#issuecomment-1398308556 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#19296](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (602f60f) into [master](https://codecov.io/gh/apache/pulsar/commit/29c244a74b5464eb6e40e3c3662effb9fa0a76a2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (29c244a) will **increase** coverage by `10.04%`. > The diff coverage is `87.93%`. [](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #19296 +/- ## = + Coverage 52.84% 62.89% +10.04% - Complexity2236726118 +3751 = Files 1824 1895 +71 Lines136749 137475 +726 Branches 1504715091 +44 = + Hits 7226486460+14196 + Misses5696843085-13883 - Partials 7517 7930 +413 ``` | Flag | Coverage Δ | | |---|---|---| | inttests | `23.99% <56.89%> (+1.63%)` | :arrow_up: | | systests | `25.59% <53.44%> (+0.58%)` | :arrow_up: | | unittests | `60.72% <86.20%> (+13.69%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../org/apache/pulsar/websocket/WebSocketService.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9XZWJTb2NrZXRTZXJ2aWNlLmphdmE=) | `72.02% <ø> (+5.82%)` | :arrow_up: | | [...che/pulsar/websocket/AbstractWebSocketHandler.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXdlYnNvY2tldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3dlYnNvY2tldC9BYnN0cmFjdFdlYlNvY2tldEhhbmRsZXIuamF2YQ==) | `42.02% <37.50%> (+1.31%)` | :arrow_up: | | [...pulsar/metadata/impl/MetadataStoreFactoryImpl.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9NZXRhZGF0YVN0b3JlRmFjdG9yeUltcGwuamF2YQ==) | `80.00% <92.85%> (+30.00%)` | :arrow_up: | | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `78.83% <100.00%> (+4.82%)` | :arrow_up: | | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `98.70% <100.00%> (+0.43%)` | :arrow_up: | | [...apache/pulsar/metadata/impl/EtcdMetadataStore.java](https://codecov.io/gh/apache/pulsar/pull/19296?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvaW1wbC9FdGNkTWV0YWRhdGFTdG9yZS5qYXZh) | `81.43% <100.00%> (-1.48%)` | :arrow_down: | |
[GitHub] [pulsar-site] lhotari opened a new pull request, #387: Update Pulsar PMC members and committers
lhotari opened a new pull request, #387:
URL: https://github.com/apache/pulsar-site/pull/387
Process used to update `data/team.js` file:
1. Logged in to https://whimsy.apache.org/roster/committee/pulsar with
browser
2. Appended ".json" to URL so that browser goes to
https://whimsy.apache.org/roster/committee/pulsar.json
3. Clicked "Save as..." and stored the JSON as ~/Downloads/pulsar.json
4. Ran this command in a bash shell:
```bash
{ echo -n "module.exports = " && cat ~/Downloads/pulsar.json | jq '{"pmc":
[.roster| to_entries | sort_by(.key) | .[] |
select(.value.role|startswith("PMC")) | {"name":.value.name, "apacheId":
.key}], "committers": [.roster| to_entries | sort_by(.key) | .[] |
select(.value.role=="Committer") | {"name":.value.name, "apacheId": .key}]}' }
| perl -pe 's/$/;\n/ if eof' > data/team.js
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] massakam opened a new pull request, #19298: [feat][cli] Add read command to pulsar-client-tools
massakam opened a new pull request, #19298: URL: https://github.com/apache/pulsar/pull/19298 ### Motivation I thought it would be convenient to create a reader easily with CLI, so I added the read command to pulsar-client-tools. Example of use: ```sh $ ./bin/pulsar-client read -m 48:-1 -n 5 persistent://public/default/t1 - got message - key:[null], properties:[], content:m0 - got message - key:[null], properties:[], content:m1 - got message - key:[null], properties:[], content:m2 - got message - key:[null], properties:[], content:m3 - got message - key:[null], properties:[], content:m4 ``` ### Verifying this change - [ ] Make sure that the change passes the CI checks. ### Documentation - [ ] `doc-required` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #19294: [fix][cli][branch-2.10] Fix mbeans to json
nodece commented on PR #19294: URL: https://github.com/apache/pulsar/pull/19294#issuecomment-1398193060 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-dotpulsar] annotated tag 2.8.0 updated (99d26b4 -> 5e2d8ae)
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a change to annotated tag 2.8.0 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git *** WARNING: tag 2.8.0 was modified! *** from 99d26b4 (commit) to 5e2d8ae (tag) tagging 99d26b46ce7febb8c64f9c0cabfca227d008ce9b (commit) replaces 2.7.0 by Daniel Blankensteiner on Fri Jan 20 09:51:28 2023 +0100 - Log - Release 2.8.0 --- No new revisions were added by this update. Summary of changes:
[GitHub] [pulsar] lhotari commented on issue #19297: Flaky-test: ReplicatorTest.testDoNotReplicateSystemTopic
lhotari commented on issue #19297: URL: https://github.com/apache/pulsar/issues/19297#issuecomment-1398082751 There's also #12774, but the problem seems to be different. In this case, it looks like there's a race condition in the test itself. https://github.com/apache/pulsar/blob/3ba6fa8f2f31e7805aad5cb03252ad5c519c10c2/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java#L1493-L1501 @nicoloboschi can you check this since you added `consumerFromR2` in #18896? It seems that the problem is that `consumerFromR2` will auto-create the topic in r2 and there's a possibility that r2 creates the topic in r1 when replication starts? That's why the line 1499 could fail with ConflictException? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-dotpulsar] branch master updated: Make ready for release 2.8.0
This is an automated email from the ASF dual-hosted git repository.
blankensteiner pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 99d26b4 Make ready for release 2.8.0
99d26b4 is described below
commit 99d26b46ce7febb8c64f9c0cabfca227d008ce9b
Author: Daniel Blankensteiner
AuthorDate: Fri Jan 20 09:49:46 2023 +0100
Make ready for release 2.8.0
---
CHANGELOG.md | 2 +-
src/DotPulsar/DotPulsar.csproj | 4 ++--
.../Internal/AsyncQueueWithCursorTests.cs | 18 +-
3 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c4b9f00..eb4e77a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this
file.
The format is based on [Keep a
Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-## [Unreleased]
+## [2.8.0] - 2023-01-20
### Added
diff --git a/src/DotPulsar/DotPulsar.csproj b/src/DotPulsar/DotPulsar.csproj
index 6bebccf..af3a1c8 100644
--- a/src/DotPulsar/DotPulsar.csproj
+++ b/src/DotPulsar/DotPulsar.csproj
@@ -1,8 +1,8 @@
-
+
netstandard2.0;netstandard2.1;net6.0;net7.0
-2.7.0
+2.8.0
$(Version)
$(Version)
ApachePulsar,DanskeCommodities,dblank
diff --git a/tests/DotPulsar.Tests/Internal/AsyncQueueWithCursorTests.cs
b/tests/DotPulsar.Tests/Internal/AsyncQueueWithCursorTests.cs
index 61994d7..7a1ac38 100644
--- a/tests/DotPulsar.Tests/Internal/AsyncQueueWithCursorTests.cs
+++ b/tests/DotPulsar.Tests/Internal/AsyncQueueWithCursorTests.cs
@@ -431,10 +431,7 @@ public class AsyncQueueWithCursorTests
{
private int Number { get; }
-public QueueItem(int number)
-{
-Number = number;
-}
+public QueueItem(int number) => Number = number;
public void Dispose() { }
@@ -444,14 +441,9 @@ public class AsyncQueueWithCursorTests
if (ReferenceEquals(this, other)) return true;
return Number == other.Number;
}
-public override bool Equals(object? obj)
-{
-if (ReferenceEquals(null, obj)) return false;
-if (ReferenceEquals(this, obj)) return true;
-if (obj.GetType() != this.GetType()) return false;
-return Equals((QueueItem) obj);
-}
-public override int GetHashCode() =>
-Number;
+
+public override bool Equals(object? obj) => obj is QueueItem qi &&
Equals(qi);
+
+public override int GetHashCode() => Number;
}
}
[GitHub] [pulsar] lhotari opened a new issue, #19297: Flaky-test: ReplicatorTest.testDoNotReplicateSystemTopic
lhotari opened a new issue, #19297: URL: https://github.com/apache/pulsar/issues/19297 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/actions/runs/3965645897/jobs/6795733528#step:11:1096 ### Exception stacktrace ``` Error: testDoNotReplicateSystemTopic(org.apache.pulsar.broker.service.ReplicatorTest) Time elapsed: 11.45 s <<< FAILURE! org.apache.pulsar.client.admin.PulsarAdminException$ConflictException: This topic already exists at org.apache.pulsar.client.admin.PulsarAdminException.wrap(PulsarAdminException.java:252) at org.apache.pulsar.client.admin.internal.BaseResource.sync(BaseResource.java:352) at org.apache.pulsar.client.admin.internal.TopicsImpl.createNonPartitionedTopic(TopicsImpl.java:308) at org.apache.pulsar.client.admin.Topics.createNonPartitionedTopic(Topics.java:539) at org.apache.pulsar.broker.service.ReplicatorTest.testDoNotReplicateSystemTopic(ReplicatorTest.java:1499) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139) at org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47) at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76) at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) Suppressed: org.apache.pulsar.client.admin.PulsarAdminException$ConflictException: This topic already exists at org.apache.pulsar.client.admin.internal.BaseResource.getApiException(BaseResource.java:287) at org.apache.pulsar.client.admin.internal.BaseResource$1.failed(BaseResource.java:136) at org.glassfish.jersey.client.JerseyInvocation$1.failed(JerseyInvocation.java:882) at org.glassfish.jersey.client.JerseyInvocation$1.completed(JerseyInvocation.java:863) at org.glassfish.jersey.client.ClientRuntime.processResponse(ClientRuntime.java:229) ``` ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #17017: [improve][broker] Add close function worker
nodece closed pull request #17017: [improve][broker] Add close function worker URL: https://github.com/apache/pulsar/pull/17017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #16898: [fix][function] Fix load trust certificate
nodece commented on PR #16898: URL: https://github.com/apache/pulsar/pull/16898#issuecomment-1398062365 Ping @michaeljmarshall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #15173: [cleanup][client] Cleanup the creation ssl context
nodece closed pull request #15173: [cleanup][client] Cleanup the creation ssl context URL: https://github.com/apache/pulsar/pull/15173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #16568: [improve][client] Add original principal and authentication data support
nodece closed pull request #16568: [improve][client] Add original principal and authentication data support URL: https://github.com/apache/pulsar/pull/16568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor
nodece commented on code in PR #19295:
URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java:
##
@@ -61,13 +80,47 @@ public AuthenticationDataSource getAuthDataSource() {
return authenticationDataSource;
}
+/**
+ * Warning: this method is not intended to be called concurrently.
+ */
+@Override
+public CompletableFuture authenticateAsync(AuthData authData) {
+if (authRole != null) {
+// Authentication is already completed
+return CompletableFuture.completedFuture(null);
+}
+this.authenticationDataSource = new AuthenticationDataCommand(
Review Comment:
I have one question:
When having `AuthChallenge`, do we need to renew `AuthenticationState`?
It looks like so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor
nodece commented on code in PR #19295:
URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java:
##
@@ -61,13 +80,47 @@ public AuthenticationDataSource getAuthDataSource() {
return authenticationDataSource;
}
+/**
+ * Warning: this method is not intended to be called concurrently.
+ */
+@Override
+public CompletableFuture authenticateAsync(AuthData authData) {
+if (authRole != null) {
+// Authentication is already completed
+return CompletableFuture.completedFuture(null);
+}
+this.authenticationDataSource = new AuthenticationDataCommand(
Review Comment:
I have one question:
When having `AuthChallenge`, do we need to renew `AuthenticationState`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ```yaml # these are values used in pulsar-helm-chart CI, they aren't examples of production settings bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 ### Example of configuring `topicLevelPoliciesEnabled=true` in your `values.yaml` `topicLevelPoliciesEnabled=true` requires setting `systemTopicEnabled=true`. ```yaml broker: configData: systemTopicEnabled: "true" topicLevelPoliciesEnabled: "true" ``` GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ```yaml # these are values used in pulsar-helm-chart CI, they aren't examples of production settings bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 ### Example of configuring `topicLevelPoliciesEnabled=true` in your `values.yaml` ```yaml broker: configData: systemTopicEnabled: "true" topicLevelPoliciesEnabled: "true" ``` GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ```yaml # these are values used in pulsar-helm-chart CI, they aren't examples of production settings bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 ### Example of configuring `topicLevelPoliciesEnabled=true` in your `values.yaml` ```yaml broker: configData: topicLevelPoliciesEnabled: "true" ``` GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ```yaml bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 ### Example of configuring `topicLevelPoliciesEnabled=true` in your `values.yaml` ```yaml broker: configData: topicLevelPoliciesEnabled: "true" ``` GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari edited a comment on the discussion: How to set up Broker config and other configs like bookie etc ### Configuring Pulsar Broker and Bookkeeper in Apache Pulsar Helm chart Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ``` bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] lhotari added a comment to the discussion: How to set up Broker config and other configs like bookie etc
GitHub user lhotari added a comment to the discussion: How to set up Broker config and other configs like bookie etc Here's an example from the pulsar-helm-chart CI tests: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/.ci/clusters/values-broker-tls.yaml#L43-L60 ``` bookkeeper: replicaCount: 3 configData: diskUsageThreshold: "0.999" diskUsageWarnThreshold: "0.999" PULSAR_PREFIX_diskUsageThreshold: "0.999" PULSAR_PREFIX_diskUsageWarnThreshold: "0.999" broker: replicaCount: 1 configData: ## Enable `autoSkipNonRecoverableData` since bookkeeper is running ## without persistence autoSkipNonRecoverableData: "true" # storage settings managedLedgerDefaultEnsembleSize: "1" managedLedgerDefaultWriteQuorum: "1" managedLedgerDefaultAckQuorum: "1" ``` For the broker, use the `broker.configData` key in your `values.yaml`. If the key is in the default `broker.conf` file for a particular version of Pulsar ([broker.conf for 2.10.3](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf)), you can use the key directly. There are some special cases where the key is missing from the [broker.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/broker.conf) or [bookkeeper.conf](https://github.com/apache/pulsar/blob/v2.10.3/conf/bookkeeper.conf) file. In those cases, it's necessary to add `PULSAR_PREFIX_` to the configuration key. The way this works is that a Python script [apply-config-from-env.py](https://github.com/apache/pulsar/blob/v2.10.3/docker/pulsar/scripts/apply-config-from-env.py) is used to apply environment variables found in the config file. If there's no match, for a key config, it's necessary to use an environment variable with `PULSAR_PREFIX_` to add the new key to the default template config file. Here's how the pulsar-helm-chart uses apply-config-from-env.py as part of the command for the container: https://github.com/apache/pulsar-helm-chart/blob/8ad7cf6b6508a23546a8d5a66e5319cf36f39712/charts/pulsar/templates/broker-statefulset.yaml#L204 GitHub link: https://github.com/apache/pulsar/discussions/19276#discussioncomment-4734960 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
