(pulsar-site) branch dependabot/npm_and_yarn/follow-redirects-1.15.6 deleted (was c49b547e229b)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/follow-redirects-1.15.6 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git was c49b547e229b build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(pulsar-site) branch main updated: build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 (#854)
This is an automated email from the ASF dual-hosted git repository. visortelle pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 8c91e927054d build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 (#854) 8c91e927054d is described below commit 8c91e927054dd1ad7aed1b2f6c6cf27902a1d310 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Sun Mar 17 06:33:23 2024 +0300 build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 (#854) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index cf6e545e058e..bc422471ee37 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6968,12 +6968,12 @@ __metadata: linkType: hard "follow-redirects@npm:^1.0.0, follow-redirects@npm:^1.14.7": - version: 1.15.5 - resolution: "follow-redirects@npm:1.15.5" + version: 1.15.6 + resolution: "follow-redirects@npm:1.15.6" peerDependenciesMeta: debug: optional: true - checksum: 5ca49b5ce6f44338cbfc3546823357e7a70813cecc9b7b768158a1d32c1e62e7407c944402a918ea8c38ae2e78266312d617dc68783fac502cbb55e1047b34ec + checksum: a62c378dfc8c00f60b9c80cab158ba54e99ba0239a5dd7c81245e5a5b39d10f0c35e249c3379eae719ff0285fff88c365dd446fab19dee771f1d76252df1bbf5 languageName: node linkType: hard
Re: [PR] build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 [pulsar-site]
visortelle merged PR #854: URL: https://github.com/apache/pulsar-site/pull/854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 [pulsar-site]
dependabot[bot] opened a new pull request, #854: URL: https://github.com/apache/pulsar-site/pull/854 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. Commits https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06;>35a517c Release version 1.15.6 of the npm package. https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b;>c4f847f Drop Proxy-Authorization across hosts. https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76;>8526b4a Use GitHub for disclosure. See full diff in https://github.com/follow-redirects/follow-redirects/compare/v1.15.5...v1.15.6;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/pulsar-site/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-site) branch dependabot/npm_and_yarn/follow-redirects-1.15.6 created (now c49b547e229b)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/follow-redirects-1.15.6 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at c49b547e229b build(deps): Bump follow-redirects from 1.15.5 to 1.15.6 No new revisions were added by this update.
[I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]
lhotari opened a new issue, #22286: URL: https://github.com/apache/pulsar/issues/22286 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation [IntelliJ checkstyle plugin](https://plugins.jetbrains.com/plugin/1065-checkstyle-idea) dropped support for checkstyle 8.x in the 5.88.0 version update. Fails with this error message: > The Checkstyle rules file could not be parsed. cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation The file has been blocked for 60s ### Solution - Upgrade `buildtools/src/main/resources/pulsar/checkstyle.xml` to support newer checkstyle 10.x version - Upgrade checkstyle to 10.x ### Alternatives _No response_ ### Anything else? _No response_ ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][broker] Fix wrong double-checked locking for readOnActiveConsumerTask in dispatcher [pulsar]
BewareMyPower commented on PR #22279: URL: https://github.com/apache/pulsar/pull/22279#issuecomment-2001921237 @lhotari This PR is merged too quickly without a 2nd review. After revisiting the code, I found the double-checked locking is unnecessary. `scheduleReadOnActiveConsumer()` is always called in `pickAndScheduleActiveConsumer()`, which is always called in `addConsumer()` and `removeConsumer()`. However, both of them are synchronized methods. So `scheduleReadOnActiveConsumer` could never be called concurrently. The original motivation is the IDE warning: https://github.com/apache/pulsar/assets/18204803/b0db0c41-87ba-4a4c-bc5a-315e6acc924e;> It's true that it's a non-atomic operation on volatile field 'readOnActiveConsumerTask'. It's a commonly seen error to access a volatile field so IDE gives such warnings. However, we don't need to make `scheduleReadOnActiveConsumer()` thread safe. Unfortunately, there is no comment that notes this point. The lack of such comments makes code hard to maintain. Generally, developers assume all methods must be thread safe so the code might become unnecessarily complicated. I opened another PR (https://github.com/apache/pulsar/pull/22285) that improves the code quality and reduces the unnecessary atomicity. That PR also reverts the changes of this PR. PTAL again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [improve][broker] Remove the atomicity on active consumer of a dispatcher [pulsar]
BewareMyPower opened a new pull request, #22285: URL: https://github.com/apache/pulsar/pull/22285 ### Motivation The modifications on `AbstractDispatcherSingleActiveConsumer#activeConsumer` only happen on `pickAndScheduleActiveConsumer`, which is only called in `addConsumer` and `removeConsumer`. However, both `addConsumer` and `removeConsumer` are synchronized methods so that we don't have to perform an atomic operation on `activeConsumer`. The composite operations on `activeConsumer` also happen on synchronized methods like `disconnectActiveConsumers`. The only access to `activeConsumer` that is not synchronized is the read on `activeConsumer` like `getActiveConsumer()` and `isConsumerConnected()`. ### Modifications Remove the `ACTIVE_CONSUMER_UPDATER` and note some methods are not thread safe or there is no need to make them thread safe. Besides, since `pickAndScheduleActiveConsumer` is never called concurrently, we don't need a double-checked locking on `readOnActiveConsumerTask`. Instead, just synchronize the modification in the scheduled task. ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix][ml] No rollover inactive ledgers when metadata service is invailable [pulsar]
codecov-commenter commented on PR #22284: URL: https://github.com/apache/pulsar/pull/22284#issuecomment-2001895673 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22284?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `50.0%` with `1 lines` in your changes are missing coverage. Please review. > Project coverage is 73.63%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`d04bbaa`)](https://app.codecov.io/gh/apache/pulsar/pull/22284?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 60 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/22284?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) ```diff @@ Coverage Diff @@ ## master #22284 +/- ## + Coverage 73.57% 73.63% +0.06% - Complexity3262432735 +111 Files 1877 1887 +10 Lines139502 139436 -66 Branches 1529915292 -7 + Hits 102638 102680 +42 + Misses2890828801 -107 + Partials 7956 7955 -1 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22284/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22284/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `26.85% <0.00%> (+2.26%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22284/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `24.55% <0.00%> (+0.23%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22284/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `72.90% <50.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22284?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22284?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `80.53% <50.00%> (-0.13%)` | :arrow_down: | ... and [95 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22284/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar) branch master updated: [fix][broker] Fix wrong double-checked locking for readOnActiveConsumerTask in dispatcher (#22279)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4e0c145c89a [fix][broker] Fix wrong double-checked locking for
readOnActiveConsumerTask in dispatcher (#22279)
4e0c145c89a is described below
commit 4e0c145c89a35ec9b41fa22862edac59e28d892d
Author: Yunze Xu
AuthorDate: Sat Mar 16 14:56:34 2024 +0800
[fix][broker] Fix wrong double-checked locking for readOnActiveConsumerTask
in dispatcher (#22279)
---
.../PersistentDispatcherSingleActiveConsumer.java | 26 +-
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
index 0f43eb6c5cc..637ede8a41f 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
@@ -74,6 +74,7 @@ public class PersistentDispatcherSingleActiveConsumer extends
AbstractDispatcher
protected volatile int readBatchSize;
protected final Backoff readFailureBackoff;
private volatile ScheduledFuture readOnActiveConsumerTask = null;
+private final Object lockForReadOnActiveConsumerTask = new Object();
private final RedeliveryTracker redeliveryTracker;
@@ -123,18 +124,23 @@ public class PersistentDispatcherSingleActiveConsumer
extends AbstractDispatcher
return;
}
-readOnActiveConsumerTask =
topic.getBrokerService().executor().schedule(() -> {
-if (log.isDebugEnabled()) {
-log.debug("[{}] Rewind cursor and read more entries after {}
ms delay", name,
-
serviceConfig.getActiveConsumerFailoverDelayTimeMillis());
+synchronized (lockForReadOnActiveConsumerTask) {
+if (readOnActiveConsumerTask != null) {
+return;
}
-Consumer activeConsumer = ACTIVE_CONSUMER_UPDATER.get(this);
-cursor.rewind(activeConsumer != null &&
activeConsumer.readCompacted());
+readOnActiveConsumerTask =
topic.getBrokerService().executor().schedule(() -> {
+if (log.isDebugEnabled()) {
+log.debug("[{}] Rewind cursor and read more entries after
{} ms delay", name,
+
serviceConfig.getActiveConsumerFailoverDelayTimeMillis());
+}
+Consumer activeConsumer = ACTIVE_CONSUMER_UPDATER.get(this);
+cursor.rewind(activeConsumer != null &&
activeConsumer.readCompacted());
-notifyActiveConsumerChanged(activeConsumer);
-readMoreEntries(activeConsumer);
-readOnActiveConsumerTask = null;
-}, serviceConfig.getActiveConsumerFailoverDelayTimeMillis(),
TimeUnit.MILLISECONDS);
+notifyActiveConsumerChanged(activeConsumer);
+readMoreEntries(activeConsumer);
+readOnActiveConsumerTask = null;
+}, serviceConfig.getActiveConsumerFailoverDelayTimeMillis(),
TimeUnit.MILLISECONDS);
+}
}
@Override
Re: [PR] [fix][broker] Fix wrong double-checked locking for readOnActiveConsumerTask in dispatcher [pulsar]
lhotari merged PR #22279: URL: https://github.com/apache/pulsar/pull/22279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(pulsar-site) branch bewaremypower/release-note-cpp-3.5.0 deleted (was a47f47c933ef)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch bewaremypower/release-note-cpp-3.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git was a47f47c933ef Add the release note for C++ client 3.5.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
