[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19153: [improve] PIP-241: add TopicEventListener / topic events for the BrokerService

2023-01-17 Thread GitBox 


Demogorgon314 commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1070934942


##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -283,6 +286,8 @@ public class BrokerService implements Closeable {
 private Set 
brokerEntryMetadataInterceptors;
 private Set brokerEntryPayloadProcessors;
 
+private final List topicEventListeners = new 
CopyOnWriteArrayList<>();

Review Comment:
   Can we add a separate class like `TopicEventListeners` or 
`TopicEventService` to package all operations to let the `BrokerService` duty 
more clear? 

What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19153: [improve] PIP-241: add TopicEventListener / topic events for the BrokerService

2023-01-16 Thread GitBox 


Demogorgon314 commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1070934942


##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -283,6 +286,8 @@ public class BrokerService implements Closeable {
 private Set 
brokerEntryMetadataInterceptors;
 private Set brokerEntryPayloadProcessors;
 
+private final List topicEventListeners = new 
CopyOnWriteArrayList<>();

Review Comment:
   Can we add a separate class like `TopicEventListeners` or 
`TopicEventService` to package all operations to let the `BrokerService` 
duty more clear? 

What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org