[GitHub] [pulsar] eolivelli commented on a change in pull request #7266: [pulsar-broker] Dispatch batch messages according consumer permits

[GitBox]

eolivelli commented on a change in pull request #7266:
URL: https://github.com/apache/pulsar/pull/7266#discussion_r632765919



##
File path: conf/bkenv.sh
##
@@ -39,7 +39,7 @@ BOOKIE_MEM=${BOOKIE_MEM:-${PULSAR_MEM:-"-Xms2g -Xmx2g 
-XX:MaxDirectMemorySize=2g
 BOOKIE_GC=${BOOKIE_GC:-${PULSAR_GC:-"-XX:+UseG1GC -XX:MaxGCPauseMillis=10 
-XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions 
-XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 
-XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB"}}
 
 # Extra options to be passed to the jvm
-BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS:-"-Dio.netty.leakDetectionLevel=disabled
 ${PULSAR_EXTRA_OPTS:-"-Dio.netty.recycler.maxCapacity.default=1000 
-Dio.netty.recycler.linkCapacity=1024"}"} ${BOOKIE_MEM} ${BOOKIE_GC}"
+BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS:-"-Dio.netty.leakDetectionLevel=advanced
 ${PULSAR_EXTRA_OPTS:-"-Dio.netty.recycler.maxCapacity.default=1000 
-Dio.netty.recycler.linkCapacity=1024"}"} ${BOOKIE_MEM} ${BOOKIE_GC}"

Review comment:
   Are you sure?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #7266: [pulsar-broker] Dispatch batch messages according consumer permits

[GitBox]

eolivelli commented on a change in pull request #7266:
URL: https://github.com/apache/pulsar/pull/7266#discussion_r631621502



##
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/Entry.java
##
@@ -65,4 +65,39 @@
  */
 boolean release();
 
+/**
+ * Get number of batch messages into the entry.
+ * @return
+ */
+int getNumberOfBatchMessages();
+
+/**
+ * Set number of batch messages into the entry.
+ * @param numberOfBatchMessages
+ */
+void setNumberOfBatchMessages(int numberOfBatchMessages);
+
+/**
+ * Set data size of the entry.
+ * @param totalSizeInBytes
+ */
+void setTotalSizeInBytes(int totalSizeInBytes);
+
+/**
+ * Set total number of chunked messages in entry.
+ * @param totalChunkedMessages
+ */
+void setTotalChunkedMessages(int totalChunkedMessages);
+
+/**
+ * Get total data size of the entry.
+ * @return
+ */
+int getTotalSizeInBytes();
+
+/**
+ * Get total number of chuncked messages.
+ * @return
+ */
+int getTotalChunkedMessages();

Review comment:
   I agree with @codelipenghui 
   it is unfortunate to add these methods here.
   we are going to use them (and the underlying fields) only on the Dispatcher.
   
   it would be better (for instance) to have some EntryWithMetatadata object in 
Dispatcher that wraps the Entry and adds these fields




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org