[GitHub] [pulsar] poorbarcode commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete
poorbarcode commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1483796776 > The files GeoPersistentReplicator and ShadowReplicator do not exist in branch-2.10. So this modification should not be cherry-picked to branch-2.10. I removed the changes of `ShadowReplicator` when I did cherry-picking, so I re-tagged it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete
poorbarcode commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1384902136 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete
poorbarcode commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1383818058 @codelipenghui @mattisonchao > Why not only add the pending messages after producer.sendAsync is called? > Why can't we move this line to else branch? Great suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
