[GitHub] [pulsar] srkukarni commented on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox 


srkukarni commented on pull request #7010:
URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632344106


   To unblock this pr, I've removed stats changes. Lets discuss that in a 
separate issue



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar] srkukarni commented on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox 


srkukarni commented on pull request #7010:
URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632290148


   @jerrypeng 
   1. Some methods are updating multiple counters/gauages. That still has to be 
in sync block to ensure that we get consistent stats
   2. The fact that today this class is using an already thread safe data 
structure is merely detail. If for whatever reason we switch it to some other 
impl, the methods should still be thread safe. Thus don;t you think its better 
to declare the methods synchronized explicitly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org