Re: [PR] [fix][ci] Don't allow merging PR without successful result [pulsar]

2024-04-23 Thread via GitHub


BewareMyPower merged PR #22563:
URL: https://github.com/apache/pulsar/pull/22563


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [fix][ci] Don't allow merging PR without successful result [pulsar]

2024-04-22 Thread via GitHub


lhotari opened a new pull request, #22563:
URL: https://github.com/apache/pulsar/pull/22563

   ### Motivation
   
   Currently it's possible to merge a PR when it hasn't been approved at all 
and no tests have run.
   The reason for this is that the required job gets skipped in this case.
   
   ### Modifications
   
   - Fix the rules for `Pulsar CI checks completed` build step in the workflow.
   - Continue to skip the step for cancelled scheduled jobs for other 
repositories than apache/pulsar.
   - Add some comments to explain the logic
   - Explicitly require preconditions build step to succeed
   
   ### Documentation
   
   
   
   - [ ] `doc` 
   - [ ] `doc-required` 
   - [x] `doc-not-needed` 
   - [ ] `doc-complete` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org