Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
lhotari merged PR #22595: URL: https://github.com/apache/pulsar/pull/22595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
thetumbled commented on PR #22595: URL: https://github.com/apache/pulsar/pull/22595#issuecomment-2079048232 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
thetumbled commented on code in PR #22595:
URL: https://github.com/apache/pulsar/pull/22595#discussion_r1580519788
##
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java:
##
@@ -349,7 +349,8 @@ public void testSubscriberPermission() throws Exception {
} catch (Exception e) {
// my-sub1 has no msg backlog, so expire message won't be issued
on that subscription
assertTrue(e.getMessage().startsWith("Expire message by timestamp
not issued on topic"));
-}sub1Admin.topics().peekMessages(topicName, subscriptionName,
1);
+}
+sub1Admin.topics().peekMessages(topicName, subscriptionName, 1);
Review Comment:
Just to correct the code format by the way, not logical change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
thetumbled commented on code in PR #22595:
URL: https://github.com/apache/pulsar/pull/22595#discussion_r1580519788
##
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java:
##
@@ -349,7 +349,8 @@ public void testSubscriberPermission() throws Exception {
} catch (Exception e) {
// my-sub1 has no msg backlog, so expire message won't be issued
on that subscription
assertTrue(e.getMessage().startsWith("Expire message by timestamp
not issued on topic"));
-}sub1Admin.topics().peekMessages(topicName, subscriptionName,
1);
+}
+sub1Admin.topics().peekMessages(topicName, subscriptionName, 1);
Review Comment:
Just to correct the code format by the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
thetumbled commented on code in PR #22595:
URL: https://github.com/apache/pulsar/pull/22595#discussion_r1580519788
##
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java:
##
@@ -349,7 +349,8 @@ public void testSubscriberPermission() throws Exception {
} catch (Exception e) {
// my-sub1 has no msg backlog, so expire message won't be issued
on that subscription
assertTrue(e.getMessage().startsWith("Expire message by timestamp
not issued on topic"));
-}sub1Admin.topics().peekMessages(topicName, subscriptionName,
1);
+}
+sub1Admin.topics().peekMessages(topicName, subscriptionName, 1);
Review Comment:
Just to correct the code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
lhotari commented on code in PR #22595:
URL: https://github.com/apache/pulsar/pull/22595#discussion_r1580497818
##
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java:
##
@@ -349,7 +349,8 @@ public void testSubscriberPermission() throws Exception {
} catch (Exception e) {
// my-sub1 has no msg backlog, so expire message won't be issued
on that subscription
assertTrue(e.getMessage().startsWith("Expire message by timestamp
not issued on topic"));
-}sub1Admin.topics().peekMessages(topicName, subscriptionName,
1);
+}
+sub1Admin.topics().peekMessages(topicName, subscriptionName, 1);
Review Comment:
Is this change related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]
thetumbled commented on PR #22595: URL: https://github.com/apache/pulsar/pull/22595#issuecomment-2078588760 PTAL, thanks. @Technoboy- @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
