[GitHub] [pulsar] rdhabalia commented on issue #5314: [pulsar-broker] fix ns-isolation api to fetch policy for specific broker
rdhabalia commented on issue #5314: [pulsar-broker] fix ns-isolation api to fetch policy for specific broker URL: https://github.com/apache/pulsar/pull/5314#issuecomment-538872399 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5313: [pulsar-cli] fix ns-isolation-policy api output
rdhabalia commented on issue #5313: [pulsar-cli] fix ns-isolation-policy api output URL: https://github.com/apache/pulsar/pull/5313#issuecomment-538872218 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5165: [PIP-43] Support producer to send msg with different schema
jiazhai commented on issue #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#issuecomment-539001984 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Guchman commented on issue #5312: Function REST API documentation is insufficient for Create POST action
Guchman commented on issue #5312: Function REST API documentation is insufficient for Create POST action URL: https://github.com/apache/pulsar/issues/5312#issuecomment-538965217 I think expected behaviour is to support application/json:) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event
jiazhai commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276#issuecomment-539006838 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5279: Support for python native logging from python wrapper
merlimat commented on issue #5279: Support for python native logging from python wrapper URL: https://github.com/apache/pulsar/pull/5279#issuecomment-539085590 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-538224332 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-538710782 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-538710748 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-537047021 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-538613945 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-538710795 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #5314: [pulsar-broker] fix ns-isolation api to fetch policy for specific broker
merlimat merged pull request #5314: [pulsar-broker] fix ns-isolation api to fetch policy for specific broker URL: https://github.com/apache/pulsar/pull/5314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #5205: [doc] Fix broken links to the info about schemas and Schema Registry
merlimat merged pull request #5205: [doc] Fix broken links to the info about schemas and Schema Registry URL: https://github.com/apache/pulsar/pull/5205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [doc] Fix broken links to the info about schemas and Schema Registry (#5205)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7b06d3a [doc] Fix broken links to the info about schemas and Schema Registry (#5205) 7b06d3a is described below commit 7b06d3a48da41ad54c25a911da19d94a7a4d6b43 Author: Sergii Zhevzhyk AuthorDate: Mon Oct 7 17:41:45 2019 +0200 [doc] Fix broken links to the info about schemas and Schema Registry (#5205) * Fix broken links to the info about schemas and Schema Registry * Fix broken links to the info about schemas and Schema Registry in the 2.4.1 version --- site2/docs/client-libraries-java.md | 2 +- site2/docs/concepts-messaging.md| 2 +- site2/docs/concepts-overview.md | 1 - site2/docs/sql-overview.md | 2 +- site2/website/versioned_docs/version-2.4.1/client-libraries-java.md | 2 +- site2/website/versioned_docs/version-2.4.1/concepts-messaging.md| 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/site2/docs/client-libraries-java.md b/site2/docs/client-libraries-java.md index 74aa773..3cc914e 100644 --- a/site2/docs/client-libraries-java.md +++ b/site2/docs/client-libraries-java.md @@ -612,7 +612,7 @@ boolean|`resetIncludeHead`|If set to true, the first message to be returned is t ## Schema -In Pulsar, all message data consists of byte arrays "under the hood." [Message schemas](concepts-schema-registry.md) enable you to use other types of data when constructing and handling messages (from simple types like strings to more complex, application-specific types). If you construct, say, a [producer](#producers) without specifying a schema, then the producer can only produce messages of type `byte[]`. Here's an example: +In Pulsar, all message data consists of byte arrays "under the hood." [Message schemas](schema-get-started.md) enable you to use other types of data when constructing and handling messages (from simple types like strings to more complex, application-specific types). If you construct, say, a [producer](#producers) without specifying a schema, then the producer can only produce messages of type `byte[]`. Here's an example: ```java Producer producer = client.newProducer() diff --git a/site2/docs/concepts-messaging.md b/site2/docs/concepts-messaging.md index 50ac13f..3eb3564 100644 --- a/site2/docs/concepts-messaging.md +++ b/site2/docs/concepts-messaging.md @@ -14,7 +14,7 @@ Messages are the basic "unit" of Pulsar. They're what producers publish to topic Component | Purpose :-|:--- -Value / data payload | The data carried by the message. All Pulsar messages carry raw bytes, although message data can also conform to data [schemas](concepts-schema-registry.md) +Value / data payload | The data carried by the message. All Pulsar messages carry raw bytes, although message data can also conform to data [schemas](schema-get-started.md) Key | Messages can optionally be tagged with keys, which can be useful for things like [topic compaction](concepts-topic-compaction.md) Properties | An optional key/value map of user-defined properties Producer name | The name of the producer that produced the message (producers are automatically given default names, but you can apply your own explicitly as well) diff --git a/site2/docs/concepts-overview.md b/site2/docs/concepts-overview.md index 22aa35c..0614290 100644 --- a/site2/docs/concepts-overview.md +++ b/site2/docs/concepts-overview.md @@ -28,4 +28,3 @@ Key features of Pulsar are listed below: - [Authentication and Authorization](concepts-authentication.md) - [Topic Compaction](concepts-topic-compaction.md) - [Tiered Storage](concepts-tiered-storage.md) -- [Schema Registry](concepts-schema-registry.md) diff --git a/site2/docs/sql-overview.md b/site2/docs/sql-overview.md index 76ce57c..d40df95 100644 --- a/site2/docs/sql-overview.md +++ b/site2/docs/sql-overview.md @@ -4,7 +4,7 @@ title: Pulsar SQL Overview sidebar_label: Overview --- -One of the common use cases of Pulsar is storing streams of event data. Often the event data is structured which predefined fields. There is tremendous value for users to be able to query the existing data that is already stored in Pulsar topics. With the implementation of the [Schema Registry](concepts-schema-registry.md), structured data can be stored in Pulsar and allows for the potential to query that data via SQL language. +One of the common use cases of Pulsar is storing streams of event data. Often the event data is structured which predefined fields. There is tremendous value for users to be able to query the existing data that is already stored in Pulsar topics. With the implementation of the [Schema
[GitHub] [pulsar] merlimat merged pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event
merlimat merged pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (e5ded1b -> e840375)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e5ded1b Add a source connector for MongoDB (#5316) add e840375 Fixed race condition while triggering message redelivery after an ack-timeout event (#5276) No new revisions were added by this update. Summary of changes: .../org/apache/pulsar/broker/service/Consumer.java | 30 ++ 1 file changed, 19 insertions(+), 11 deletions(-)
[GitHub] [pulsar] merlimat merged pull request #5313: [pulsar-cli] fix ns-isolation-policy api output
merlimat merged pull request #5313: [pulsar-cli] fix ns-isolation-policy api output URL: https://github.com/apache/pulsar/pull/5313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (e840375 -> de233d4)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e840375 Fixed race condition while triggering message redelivery after an ack-timeout event (#5276) add de233d4 [pulsar-cli] fix ns-isolation-policy api output (#5313) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pulsar/admin/cli/CliCommand.java | 10 +- .../java/org/apache/pulsar/admin/cli/CmdFunctionWorker.java| 6 +++--- 2 files changed, 4 insertions(+), 12 deletions(-)
[pulsar] branch master updated (7b06d3a -> 21e2b52)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7b06d3a [doc] Fix broken links to the info about schemas and Schema Registry (#5205) add 21e2b52 Fix Cmake to build _pulsar for osx (#5263) No new revisions were added by this update. Summary of changes: pulsar-client-cpp/CMakeLists.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)
[GitHub] [pulsar] aahmed-se merged pull request #5263: Fix Cmake to build _pulsar for osx
aahmed-se merged pull request #5263: Fix Cmake to build _pulsar for osx URL: https://github.com/apache/pulsar/pull/5263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on a change in pull request #5322: Fix bk write failure part 2
rdhabalia commented on a change in pull request #5322: Fix bk write failure
part 2
URL: https://github.com/apache/pulsar/pull/5322#discussion_r332227446
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##
@@ -342,15 +345,13 @@ public void addComplete(Position pos, Object ctx) {
@Override
public synchronized void addFailed(ManagedLedgerException exception,
Object ctx) {
-
-// fence topic when failed to write a message to BK
-isFenced = true;
-
if (exception instanceof ManagedLedgerFencedException) {
// If the managed ledger has been fenced, we cannot continue using
it. We need to close and reopen
close();
} else {
+// fence topic when failed to write a message to BK
+isFenced = true;
Review comment:
why are we avoiding fencing ledger when topic actually sees
`ManagedLedgerFencedException`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5331: Avoid rethrowing exception during test teardown
merlimat opened a new pull request #5331: Avoid rethrowing exception during test teardown URL: https://github.com/apache/pulsar/pull/5331 ### Motivation In several cases, the test get stuck on the broker teardown. Do not re-throw the exception here, since the test logic itself was already successful. ``` 20:18:36.507 [main:org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest@176] WARN org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest - Failed to clean up mocked pulsar service: org.apache.pulsar.broker.PulsarServerException: org.apache.pulsar.broker.PulsarServerException: java.util.concurrent.TimeoutException at org.apache.pulsar.broker.PulsarService.close(PulsarService.java:319) ~[classes/:?] at org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.internalCleanup(MockedPulsarServiceBaseTest.java:161) [test-classes/:?] at org.apache.pulsar.broker.admin.NamespacesTest.cleanup(NamespacesTest.java:173) [test-classes/:?] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] TRManderson opened a new pull request #5332: [docs] Fix broken link to k8s YAML definitions
TRManderson opened a new pull request #5332: [docs] Fix broken link to k8s YAML definitions URL: https://github.com/apache/pulsar/pull/5332 The file path to the relevant directory was moved under the deployment subdirectory, this fixes that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5322: Fix bk write failure part 2
jerrypeng commented on a change in pull request #5322: Fix bk write failure
part 2
URL: https://github.com/apache/pulsar/pull/5322#discussion_r332250591
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##
@@ -342,15 +345,13 @@ public void addComplete(Position pos, Object ctx) {
@Override
public synchronized void addFailed(ManagedLedgerException exception,
Object ctx) {
-
-// fence topic when failed to write a message to BK
-isFenced = true;
-
if (exception instanceof ManagedLedgerFencedException) {
// If the managed ledger has been fenced, we cannot continue using
it. We need to close and reopen
close();
} else {
+// fence topic when failed to write a message to BK
+isFenced = true;
Review comment:
@rdhabalia I add this set here in a previous PR part of a line of PRs to fix
problems in message deduplication (#5218). Setting "isFenced = true;" there
when the exception is ManagedLedgerFencedException is inappropriate because of
this check in close():
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L895
There is already logic in the close() method to fence the topic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5328: Increase the retries count for PulsarFunctionStateTest
merlimat opened a new pull request #5328: Increase the retries count for PulsarFunctionStateTest URL: https://github.com/apache/pulsar/pull/5328 ### Motivation The test has been intermittently failing: ``` 2019-10-07\T\20:09:37.235 [ERROR] testPulsarFunctionState(org.apache.pulsar.functions.worker.PulsarFunctionStateTest) Time elapsed: 2.607 s <<< FAILURE! java.lang.AssertionError: expected [1] but found [0] at org.testng.Assert.fail(Assert.java:96) at org.testng.Assert.failNotEquals(Assert.java:776) at org.testng.Assert.assertEqualsImpl(Assert.java:137) at org.testng.Assert.assertEquals(Assert.java:118) at org.testng.Assert.assertEquals(Assert.java:652) at org.testng.Assert.assertEquals(Assert.java:662) at org.apache.pulsar.functions.worker.PulsarFunctionStateTest.testPulsarFunctionState(PulsarFunctionStateTest.java:316) ``` Increasing the number of retries, since this seems related to slowness in Jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5329: Fix ConsumerRedeliveryTest by ensure clean state on each run
merlimat opened a new pull request #5329: Fix ConsumerRedeliveryTest by ensure clean state on each run URL: https://github.com/apache/pulsar/pull/5329 ### Motivation The test retries are failing because the state for the prev execution lingers on. ``` 2019-10-07\T\21:21:48.362 [ERROR] org.apache.pulsar.client.api.ConsumerRedeliveryTest.testOrderedRedelivery(org.apache.pulsar.client.api.ConsumerRedeliveryTest) 2019-10-07\T\21:21:48.363 [INFO] Run 1: PASS 2019-10-07\T\21:21:48.363 [ERROR] Run 2: ConsumerRedeliveryTest.testOrderedRedelivery:74 ยป ProducerBusy Producer with n... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
jiazhai commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-539170200 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5322: Fix bk write failure part 2
jerrypeng commented on a change in pull request #5322: Fix bk write failure
part 2
URL: https://github.com/apache/pulsar/pull/5322#discussion_r332208797
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -624,6 +617,12 @@ private synchronized void
internalAsyncAddEntry(OpAddEntry addOperation) {
}
}
+@Override
+public void readyToCreateNewLedger() {
+ // only set transition state to ClosedLedger if current state is
WriteFailed
+ STATE_UPDATER.compareAndSet(this, State.WriteFailed,
State.ClosedLedger);
Review comment:
will add
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5330: Added basic metadata store API and initial ZK implementation
merlimat opened a new pull request #5330: Added basic metadata store API and initial ZK implementation URL: https://github.com/apache/pulsar/pull/5330 ### Motivation This PR is the first in a series of changes. The ultimate goal is to have all the metadata accesses to ZooKeeper to be routed through a single, pluggable interface. This PR defines the first cut of the `MetadataStore` interface, along with the ZK implementation. Subsequent PRs will start converting metadata accesses. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5321: [pulsar-broker] Disable stickyRead by default
jiazhai commented on issue #5321: [pulsar-broker] Disable stickyRead by default URL: https://github.com/apache/pulsar/pull/5321#issuecomment-539168802 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5075: [pulsar-client] support set read-position based on timestamp
jiazhai commented on issue #5075: [pulsar-client] support set read-position based on timestamp URL: https://github.com/apache/pulsar/pull/5075#issuecomment-539170020 @rdhabalia Would you please help rebase this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] chairmank commented on issue #5318: Pulsar 2.4.1 - Broker stops server Admin API at random
chairmank commented on issue #5318: Pulsar 2.4.1 - Broker stops server Admin API at random URL: https://github.com/apache/pulsar/issues/5318#issuecomment-539181519 related to https://github.com/apache/pulsar/pull/5079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] chairmank edited a comment on issue #5318: Pulsar 2.4.1 - Broker stops server Admin API at random
chairmank edited a comment on issue #5318: Pulsar 2.4.1 - Broker stops server Admin API at random URL: https://github.com/apache/pulsar/issues/5318#issuecomment-539181519 related to https://github.com/apache/pulsar/pull/5079#issuecomment-531491624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rocketraman commented on issue #2328: Pulsar broker start failure when set functionsWorkerEnabled=true
rocketraman commented on issue #2328: Pulsar broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/2328#issuecomment-539105749 I have this same issue with running Pulsar on Kubernetes. I see that the script `gen-yml-from-env.py` is supposed to update `functions_worker.yml`, but I think the script is missing the value `pulsarFunctionsCluster` in INT_KEYS `https://github.com/apache/pulsar/blob/60d2bfa389815b1769b36a0158059bfc3372a9a0/docker/pulsar/scripts/gen-yml-from-env.py#L30` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rocketraman edited a comment on issue #2328: Pulsar broker start failure when set functionsWorkerEnabled=true
rocketraman edited a comment on issue #2328: Pulsar broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/2328#issuecomment-539105749 I have this same issue with running Pulsar on Kubernetes. I see that the script `gen-yml-from-env.py` is supposed to update `functions_worker.yml`, but I think the script is missing the value `pulsarFunctionsCluster` in INT_KEYS. I created a followup issue https://github.com/apache/pulsar/issues/5325. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] cdbartholomew commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true
cdbartholomew commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/5325#issuecomment-539168930 @rocketraman expanding on @sijie's comment, I can confirm that if you set it as an environment variable, it gets applied. I have added this to my broker configmap for k8s: ``` apiVersion: v1 data: PF_pulsarFunctionsCluster: ``` Then `gen-yml-from-env.py` picks it up and applies it to `functions_worker.yml`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] hanbo1990 opened a new issue #5326: pulsar released package missing configuraion for ranges from bookkie
hanbo1990 opened a new issue #5326: pulsar released package missing configuraion for ranges from bookkie URL: https://github.com/apache/pulsar/issues/5326 **Describe the bug** Standalone pulsar's bookie creates data/ranges folder even bookkeeper's data path is changed to another folder. This data/ranges folder is used by data.bookkeeper.ranges, which can be configured in the bookkeeper package downloaded from apache bookkeeper but not pulsar. **To Reproduce** Steps to reproduce the behavior: 1. Go to the conf folder and change all data paths of the bookie. Don't use any path containing `data/` 2. Execute standalone with `--bookkeeper-dir` pointing to other locations outside PULSAR_HOME for some time. **Expected behavior** No data/ranges should exist because bookkeeper's data folder is changed to another location, but I can still see it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] miton18 opened a new pull request #5327: typo: traffic
miton18 opened a new pull request #5327: typo: traffic URL: https://github.com/apache/pulsar/pull/5327 typo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5319: Collect broker publish latency in prometheus
merlimat commented on issue #5319: Collect broker publish latency in prometheus URL: https://github.com/apache/pulsar/pull/5319#issuecomment-539158166 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true
sijie commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/5325#issuecomment-539167556 @rocketraman INT_KEYS are used for the settings whose value is Integer. So I don't think pulsarFunctionCluster is an INT key. You need to specify the function settings by prefixing the settings with "PF_". That says, you need to specify the system variable "PF_pulsarFunctionCluster", so that `gen-yml-from-env.py` can work as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rocketraman opened a new issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true
rocketraman opened a new issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/5325 **Describe the bug** The Kubernetes deployment sets `PF_pulsarFunctionsCluster` but this doesn't appear to get applied to `conf/functions_worker.yml`. Looking at the source, it appears that the script `gen-yml-from-env.py` is supposed to update `functions_worker.yml`, but I think the script is missing the value `pulsarFunctionsCluster` in INT_KEYS at line: https://github.com/apache/pulsar/blob/60d2bfa389815b1769b36a0158059bfc3372a9a0/docker/pulsar/scripts/gen-yml-from-env.py#L30. This is a followup to issue https://github.com/apache/pulsar/issues/2328. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5317: Allow to specify delivery delay in C++ client
merlimat commented on issue #5317: Allow to specify delivery delay in C++ client URL: https://github.com/apache/pulsar/pull/5317#issuecomment-539127526 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5322: Fix bk write failure part 2
merlimat commented on a change in pull request #5322: Fix bk write failure part
2
URL: https://github.com/apache/pulsar/pull/5322#discussion_r332197883
##
File path:
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerErrorsTest.java
##
@@ -329,40 +329,6 @@ public void addComplete(Position position, Object ctx) {
latch.await();
}
-@Test
-public void recoverAfterWriteError() throws Exception {
Review comment:
Got it .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5322: Fix bk write failure part 2
merlimat commented on a change in pull request #5322: Fix bk write failure part
2
URL: https://github.com/apache/pulsar/pull/5322#discussion_r332197410
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -624,6 +617,12 @@ private synchronized void
internalAsyncAddEntry(OpAddEntry addOperation) {
}
}
+@Override
+public void readyToCreateNewLedger() {
+ // only set transition state to ClosedLedger if current state is
WriteFailed
+ STATE_UPDATER.compareAndSet(this, State.WriteFailed,
State.ClosedLedger);
Review comment:
```suggestion
if (STATE_UPDATER.compareAndSet(this, State.WriteFailed,
State.ClosedLedger)) {
log.info("[{}] Managed ledger is now ready to accept writes
again", name);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5317: Allow to specify delivery delay in C++ client
merlimat commented on issue #5317: Allow to specify delivery delay in C++ client URL: https://github.com/apache/pulsar/pull/5317#issuecomment-539249390 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new pull request #5335: Build python 37 artifacts and use them for the docker image
aahmed-se opened a new pull request #5335: Build python 37 artifacts and use them for the docker image URL: https://github.com/apache/pulsar/pull/5335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache
aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache URL: https://github.com/apache/pulsar/pull/5334#issuecomment-539293552 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-go] branch master updated: (refactor)clean code (#70)
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 702405f (refactor)clean code (#70)
702405f is described below
commit 702405fa17a05882bdb08a64bc20319e1d516a78
Author: xujianhai666 <52450794+xujianhai...@users.noreply.github.com>
AuthorDate: Tue Oct 8 12:05:09 2019 +0800
(refactor)clean code (#70)
Change-Id: I480f5b8bb580887543cde66824b2f5704f8fa6e8
- use goimports import lib
- use switch-case instrad of if-else for newClient in pulsar/impl_client.go
---
pulsar/consumer_test.go | 1 +
pulsar/impl_client.go | 7 ---
pulsar/internal/connection.go | 12 +++-
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/pulsar/consumer_test.go b/pulsar/consumer_test.go
index cda9506..e6f4d52 100644
--- a/pulsar/consumer_test.go
+++ b/pulsar/consumer_test.go
@@ -850,6 +850,7 @@ func TestConsumer_Flow(t *testing.T) {
SubscriptionName: "sub-1",
ReceiverQueueSize: 4,
})
+ assert.Nil(t, err)
for msgNum := 0; msgNum < 100; msgNum++ {
if err := producer.Send(ctx, {
diff --git a/pulsar/impl_client.go b/pulsar/impl_client.go
index aeda1c0..7077155 100644
--- a/pulsar/impl_client.go
+++ b/pulsar/impl_client.go
@@ -54,15 +54,16 @@ func newClient(options ClientOptions) (Client, error) {
}
var tlsConfig *internal.TLSOptions
- if url.Scheme == "pulsar" {
+ switch url.Scheme {
+ case "pulsar":
tlsConfig = nil
- } else if url.Scheme == "pulsar+ssl" {
+ case "pulsar+ssl":
tlsConfig = {
AllowInsecureConnection:
options.TLSAllowInsecureConnection,
TrustCertsFilePath: options.TLSTrustCertsFilePath,
ValidateHostname:options.TLSValidateHostname,
}
- } else {
+ default:
return nil, newError(ResultInvalidConfiguration,
fmt.Sprintf("Invalid URL scheme '%s'", url.Scheme))
}
diff --git a/pulsar/internal/connection.go b/pulsar/internal/connection.go
index 8084017..fe43f79 100644
--- a/pulsar/internal/connection.go
+++ b/pulsar/internal/connection.go
@@ -28,11 +28,12 @@ import (
"sync/atomic"
"time"
+ "github.com/golang/protobuf/proto"
+ log "github.com/sirupsen/logrus"
+
"github.com/apache/pulsar-client-go/pkg/auth"
"github.com/apache/pulsar-client-go/pkg/pb"
"github.com/apache/pulsar-client-go/util"
- "github.com/golang/protobuf/proto"
- log "github.com/sirupsen/logrus"
)
type TLSOptions struct {
@@ -356,6 +357,9 @@ func (c *connection) receivedCommand(cmd *pb.BaseCommand,
headersAndPayload []by
case pb.BaseCommand_MESSAGE:
err = c.handleMessage(cmd.GetMessage(), headersAndPayload)
+ if err != nil {
+ c.Close()
+ }
case pb.BaseCommand_PING:
c.handlePing()
case pb.BaseCommand_PONG:
@@ -364,9 +368,7 @@ func (c *connection) receivedCommand(cmd *pb.BaseCommand,
headersAndPayload []by
case pb.BaseCommand_ACTIVE_CONSUMER_CHANGE:
default:
- if err != nil {
- c.log.Errorf("Received invalid command type: %s",
cmd.Type)
- }
+ c.log.Errorf("Received invalid command type: %s", cmd.Type)
c.Close()
}
}
[GitHub] [pulsar-client-go] wolfstudy merged pull request #70: [refactor] clean code
wolfstudy merged pull request #70: [refactor] clean code URL: https://github.com/apache/pulsar-client-go/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539346131 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539278587 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539278683 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] grantwwu commented on issue #4780: Clarify how retention interacts with readers
grantwwu commented on issue #4780: Clarify how retention interacts with readers URL: https://github.com/apache/pulsar/pull/4780#issuecomment-539332962 Er, this got merged with TODOs still in it... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539346131 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5320: Expose metrics of Caffeine and Guava caches
merlimat commented on a change in pull request #5320: Expose metrics of
Caffeine and Guava caches
URL: https://github.com/apache/pulsar/pull/5320#discussion_r332277957
##
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/stats/CacheMetricsCollector.java
##
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.stats;
+
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public class CacheMetricsCollector {
+
+public static final
io.prometheus.client.cache.caffeine.CacheMetricsCollector CAFFEINE = new
io.prometheus.client.cache.caffeine.CacheMetricsCollector()
+.register();
+
+public static final io.prometheus.client.guava.cache.CacheMetricsCollector
GUAVA = new io.prometheus.client.guava.cache.CacheMetricsCollector()
Review comment:
I was initially planning to instruments also Guava caches, though the
remaining ones we have are not very interesting, so dropped the ball.
I have removed guava now. PTAL.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5322: Fix bk write failure part 2
jerrypeng commented on issue #5322: Fix bk write failure part 2 URL: https://github.com/apache/pulsar/pull/5322#issuecomment-539261288 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5335: Build python 37 artifacts and use them for the docker image
aahmed-se commented on issue #5335: Build python 37 artifacts and use them for the docker image URL: https://github.com/apache/pulsar/pull/5335#issuecomment-539272173 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on a change in pull request #5335: Build python 37 artifacts and use them for the docker image
merlimat commented on a change in pull request #5335: Build python 37 artifacts
and use them for the docker image
URL: https://github.com/apache/pulsar/pull/5335#discussion_r332304347
##
File path: docker/pulsar/scripts/install-pulsar-client-37.sh
##
@@ -20,5 +20,5 @@
set -x
-WHEEL_FILE=$(ls /pulsar/pulsar-client | grep cp35)
+WHEEL_FILE=$(ls /pulsar/pulsar-client | grep cp37)
pip3.5 install /pulsar/pulsar-client/${WHEEL_FILE}
Review comment:
`pip3.7` or `pip3`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #70: [refactor] clean code
wolfstudy commented on issue #70: [refactor] clean code URL: https://github.com/apache/pulsar-client-go/pull/70#issuecomment-539283480 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5329: Fix ConsumerRedeliveryTest by ensure clean state on each run
merlimat commented on issue #5329: Fix ConsumerRedeliveryTest by ensure clean state on each run URL: https://github.com/apache/pulsar/pull/5329#issuecomment-539246854 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5321: [pulsar-broker] Disable stickyRead by default
merlimat commented on issue #5321: [pulsar-broker] Disable stickyRead by default URL: https://github.com/apache/pulsar/pull/5321#issuecomment-539246934 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5319: Collect broker publish latency in prometheus
merlimat commented on issue #5319: Collect broker publish latency in prometheus URL: https://github.com/apache/pulsar/pull/5319#issuecomment-539247286 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539278587 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-539278683 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (21e2b52 -> d7012ae)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 21e2b52 Fix Cmake to build _pulsar for osx (#5263) add d7012ae Collect broker publish latency in prometheus (#5319) No new revisions were added by this update. Summary of changes: .../pulsar/broker/service/AbstractTopic.java | 18 ++- .../pulsar/broker/service/BrokerService.java | 3 + .../org/apache/pulsar/broker/service/Producer.java | 2 +- .../org/apache/pulsar/broker/service/Topic.java| 9 +- .../metrics/DataSketchesSummaryLogger.java | 125 .../broker/stats/prometheus/metrics/Summary.java | 131 + 6 files changed, 280 insertions(+), 8 deletions(-) create mode 100644 pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/DataSketchesSummaryLogger.java create mode 100644 pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/Summary.java
[GitHub] [pulsar] merlimat merged pull request #5319: Collect broker publish latency in prometheus
merlimat merged pull request #5319: Collect broker publish latency in prometheus URL: https://github.com/apache/pulsar/pull/5319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache
aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache URL: https://github.com/apache/pulsar/pull/5334#issuecomment-539299026 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rocketraman commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true
rocketraman commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/5325#issuecomment-539317646 Hmm, for some reason it did not work for me. I have exactly that (based on the sample in the repo) and yet the broker was still starting up with an error looking for cluster "standalone". Will try again tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rocketraman opened a new issue #5309: [docs] Clarify wording around retention policies
rocketraman opened a new issue #5309: [docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/issues/5309 In section https://pulsar.apache.org/docs/en/cookbooks-retention-expiry/#retention-policies, this text appears: > When you set a size limit of, say, 10 gigabytes, then messages in all topics in the namespace, even acknowledged messages, will be retained until the size limit for the topic is reached; if you set a time limit of, say, 1 day, then messages for all topics in the namespace will be retained for 24 hours. The "**even** acknowledged messages" seems to imply the settings apply to all messages, both unacked and acked. As I understand the retention settings, these apply *only* to acknowledged messages, which implies that unacked messages are retained indefinitely (or actually as per the backlog quota size and retention policy). So I think this wording would be clearer if it said something like this: > When you set a size limit of, say, 10 gigabytes, then acknowledged messages in all topics in the namespace will be retained until the size limit for the topic is reached; if you set a time limit of, say, 1 day, then acknowledged messages for all topics in the namespace will be retained for 24 hours. The retention settings do not affect unacknowledged messages -- these are instead controlled by the backlog quota and retention policy. Let me know if this is correct, and if so, I would be happy to submit a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5305: [functions] Add log level in a property for log topic
wolfstudy commented on issue #5305: [functions] Add log level in a property for log topic URL: https://github.com/apache/pulsar/pull/5305#issuecomment-539325826 run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #69: [ISSUE #68][feat]add Option for new producer (#68)
wolfstudy commented on issue #69: [ISSUE #68][feat]add Option for new producer (#68) URL: https://github.com/apache/pulsar-client-go/pull/69#issuecomment-539327527 I think this is a good proposal to refactor the API interface. @xujianhai666 Can you fix this for `ClientOption` and `ConsumerOption` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #66: Fix interface conversion panic
wolfstudy commented on issue #66: Fix interface conversion panic URL: https://github.com/apache/pulsar-client-go/pull/66#issuecomment-539327960 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5333: Do not use timed receive in BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer
merlimat opened a new pull request #5333: Do not use timed receive in BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer URL: https://github.com/apache/pulsar/pull/5333 ### Motivation The test is failing because the `receive(1, TimeUnit.SECONDS)` takes more than 1 sec to receive a message. Also, removing all explicit test timeouts, since we already have a default timeout. ``` Stacktrace java.lang.NullPointerException at org.apache.pulsar.client.impl.BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer(BrokerClientIntegrationTest.java:383) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat opened a new pull request #5334: When building docker image, copy tarball at the end to use build cache
merlimat opened a new pull request #5334: When building docker image, copy tarball at the end to use build cache URL: https://github.com/apache/pulsar/pull/5334 ### Motivation Since the Pulsar tarball is the only part that keeps changing, we should copy it at the very end so that the rest of the build steps can be cached. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5335: Build python 37 artifacts and use them for the docker image
aahmed-se commented on issue #5335: Build python 37 artifacts and use them for the docker image URL: https://github.com/apache/pulsar/pull/5335#issuecomment-539272206 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on a change in pull request #5335: Build python 37 artifacts and use them for the docker image
aahmed-se commented on a change in pull request #5335: Build python 37
artifacts and use them for the docker image
URL: https://github.com/apache/pulsar/pull/5335#discussion_r332304726
##
File path: docker/pulsar/scripts/install-pulsar-client-37.sh
##
@@ -20,5 +20,5 @@
set -x
-WHEEL_FILE=$(ls /pulsar/pulsar-client | grep cp35)
+WHEEL_FILE=$(ls /pulsar/pulsar-client | grep cp37)
pip3.5 install /pulsar/pulsar-client/${WHEEL_FILE}
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] bbonnin commented on issue #5305: [functions] Add log level in a property for log topic
bbonnin commented on issue #5305: [functions] Add log level in a property for log topic URL: https://github.com/apache/pulsar/pull/5305#issuecomment-539333682 is there a way to restart tests that have failed in local ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
