[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage
yjshen removed a comment on issue #6613: [cleanup] Optional usage URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604294181 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] AmitANetskope opened a new issue #6617: When ttlDurationDefaultInSeconds is set the messages are epired one by one every 5 minutes even before ttlDurationDefaultInSeconds is reached
AmitANetskope opened a new issue #6617: When ttlDurationDefaultInSeconds is set the messages are epired one by one every 5 minutes even before ttlDurationDefaultInSeconds is reached URL: https://github.com/apache/pulsar/issues/6617 Messages are being expired even before ttlDurationDefaultInSeconds is reached when ttlDurationDefaultInSeconds is set. **To Reproduce** 1. in broker conf auto topic creation is enabled 2. in broker set ttlDurationDefaultInSeconds to 604800 (in all brokers and restart them) 3. now create subscription to topic - persistent/public/default/amit_test 4. close the subscription 5. create producer to above topic - providing a name and setting timeout to 0 (also dedup has been enabled in broker conf) 6. Now send 2 messages to the topic using the producer one after another 7. Now close the producer and client 8. Now using admin stats monitor the topic - pulsar-broker:8080/admin/v2/persistent/public/default/amit_test/stats 9. under the subscription can see that 2 messages are present in msgBacklog and lastExpireTimestamp is 0 (and no active producers or consumers) 10. After couple of minutes can observe msgBacklog reduced to 1 and lastExpireTimestamp is set to recent timestamp 11. After 5 more min can observe msgBacklog reduced to 0 and lastExpireTimestamp is updated to recent timestamp **Expected behavior** Messages should not be expired until ttl is reached. **Desktop (please complete the following information):** - OS: Ubuntu - Pulsar version - 2.5.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers
codelipenghui commented on issue #6209: [broker] add feature BrokerDeduplicationAcrossProducers URL: https://github.com/apache/pulsar/pull/6209#issuecomment-604392425 @EugenDueck Sorry for the late response. Multiple producer deduplication looks a little complicated. I think the highest sequence ID maintained in the broker is insufficient to meet such a demand. Maybe we can use the same mechanism of acknowledging the state of the message. The broker maintains a bitset in memory for the not continuous sequence and a mark sequence ID for the continuous sequence that producers sent to the topic. The producers may cause discontinuities(0, 2, 3, 1, 5) and no longer send 5. So that we can add a time window and if the time window passed, sequence ID 4 will no longer be stored. And this also needs this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage
yjshen commented on issue #6613: [cleanup] Optional usage URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604336691 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage
yjshen commented on issue #6613: [cleanup] Optional usage URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604358290 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] cbornet commented on issue #6512: WIP: [protocol] Grpc protocol handler
cbornet commented on issue #6512: WIP: [protocol] Grpc protocol handler URL: https://github.com/apache/pulsar/pull/6512#issuecomment-604362452 Hi. I hope this can be reviewed soon. This PR makes a big change on ServerCnx which is modified very often by other PRs and so there are conflicts to resolve all the time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] murong00 commented on issue #6607: [pulsar-broker-common] Improve AuthTokenUtils to support a valid key file path
murong00 commented on issue #6607: [pulsar-broker-common] Improve AuthTokenUtils to support a valid key file path URL: https://github.com/apache/pulsar/pull/6607#issuecomment-604342876 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6616: [PulsarAdmin]Async autoTopicCreation
yjshen commented on issue #6616: [PulsarAdmin]Async autoTopicCreation URL: https://github.com/apache/pulsar/pull/6616#issuecomment-604358413 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] KannarFr commented on a change in pull request #6428: [Issue 5720][authorization provider] (WIP) Add more granularity
KannarFr commented on a change in pull request #6428: [Issue
5720][authorization provider] (WIP) Add more granularity
URL: https://github.com/apache/pulsar/pull/6428#discussion_r398546669
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/NamespaceOperation.java
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pulsar.common.policies.data;
+
+/**
+ * Namespace authorization operations.
+ */
+public enum NamespaceOperation {
Review comment:
Just rereading my words, and the example I gave is read/write as you
mentioned, my bad. I just don't want to limit authz possibilities. And I'm not
sure that Read/write cover all cases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] KannarFr commented on a change in pull request #6428: [Issue 5720][authorization provider] (WIP) Add more granularity
KannarFr commented on a change in pull request #6428: [Issue
5720][authorization provider] (WIP) Add more granularity
URL: https://github.com/apache/pulsar/pull/6428#discussion_r398545130
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/NamespaceOperation.java
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pulsar.common.policies.data;
+
+/**
+ * Namespace authorization operations.
+ */
+public enum NamespaceOperation {
Review comment:
We can probably simplify these actions I totally agree, I followed the
validated PIP-49. Simplify them is really hard: for example, list Namespaces in
a tenant should be tenant level authz but only for list Namespaces because it
can be done by a tenant user. But set rates for tenant must only be done by
super User and not a user, so we need these split.
I guess we can have this issue a lot of times, not every endpoints, but it's
hard to maintain. Which endpoint goes for this operation or this operation.
Split all of them if easy to maintain. This comes with the defaultauthz
provider which keeps the default role based as super user, tenant admin, or
producer/consume authz. But the provider is passing the operations.
The goal here is to enable plugins authz to have all authz powers and all
the context to authorize. In default case role is a user, but when you consider
role as a token with all authorized info deserialized in custom authz provider
it's so powerful.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage
yjshen commented on issue #6613: [cleanup] Optional usage URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604437451 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage
yjshen commented on issue #6613: [cleanup] Optional usage URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604417999 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6616: [PulsarAdmin]Async autoTopicCreation
yjshen commented on issue #6616: [PulsarAdmin]Async autoTopicCreation URL: https://github.com/apache/pulsar/pull/6616#issuecomment-604418101 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zhanghaou commented on issue #6433: MessageId#compare is not symmetric (MessageIdImpl, BatchMessageIdImpl)
zhanghaou commented on issue #6433: MessageId#compare is not symmetric (MessageIdImpl, BatchMessageIdImpl) URL: https://github.com/apache/pulsar/issues/6433#issuecomment-604428936 I'm interesting in fix this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6433: MessageId#compare is not symmetric (MessageIdImpl, BatchMessageIdImpl)
codelipenghui commented on issue #6433: MessageId#compare is not symmetric (MessageIdImpl, BatchMessageIdImpl) URL: https://github.com/apache/pulsar/issues/6433#issuecomment-604430322 @zhanghaou Thanks, look forwards to your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen removed a comment on issue #6616: [PulsarAdmin]Async autoTopicCreation
yjshen removed a comment on issue #6616: [PulsarAdmin]Async autoTopicCreation URL: https://github.com/apache/pulsar/pull/6616#issuecomment-604418101 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen opened a new pull request #6618: Number of placeholder doesn't match number of arguments in logging
yjshen opened a new pull request #6618: Number of placeholder doesn't match number of arguments in logging URL: https://github.com/apache/pulsar/pull/6618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen removed a comment on issue #6616: [PulsarAdmin]Async autoTopicCreation
yjshen removed a comment on issue #6616: [PulsarAdmin]Async autoTopicCreation URL: https://github.com/apache/pulsar/pull/6616#issuecomment-604358413 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lynnmatrix commented on issue #6601: ISSUE-6514 Add support for influxdb2 in pulsar-influxdb-sink(#6514)
lynnmatrix commented on issue #6601: ISSUE-6514 Add support for influxdb2 in pulsar-influxdb-sink(#6514) URL: https://github.com/apache/pulsar/pull/6601#issuecomment-604476198 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
