maskit commented on issue #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364618475
Actually I was looking into the code, and found much of duplicate code.
The blocks for `trustManager` and `keyManager` really seem like
`SecurityUtility::createNettySslContext`. Probably only difference is context
for client vs for server.
Using `SecurityUtility` class would also remove the dependency for
`org.apache.pulsar.client.impl.auth.AuthenticationDataTls`. That is what
`AuthenticationDataTls` use internally.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
